eslint-plugin-smarthr 2.1.0 → 2.2.1

package/CHANGELOG.md

@@ -2,6 +2,22 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+## [2.2.1](https://github.com/kufu/tamatebako/compare/eslint-plugin-smarthr-v2.2.0...eslint-plugin-smarthr-v2.2.1) (2025-11-18)
+
+
+### Bug Fixes
+
+* a11y-anchor-has-href-attributeがhrefにメソッドが指定されている場合に誤検知することがある問題を修正 ([#905](https://github.com/kufu/tamatebako/issues/905)) ([6ebd6ec](https://github.com/kufu/tamatebako/commit/6ebd6ecc074a7088652697dcb6bfb60b63a13fc4))
+* a11y-input-has-name-attributeでtemplate literalの場合、誤検知してしまう問題を修正 ([#904](https://github.com/kufu/tamatebako/issues/904)) ([d440e86](https://github.com/kufu/tamatebako/commit/d440e8675bf600dbe8a51e496d7076bcf617336f))
+
+## [2.2.0](https://github.com/kufu/tamatebako/compare/eslint-plugin-smarthr-v2.1.0...eslint-plugin-smarthr-v2.2.0) (2025-11-07)
+
+
+### Features
+
+* a11y-help-link-with-support-hrefで対象となる変数名のバグを修正 ([#890](https://github.com/kufu/tamatebako/issues/890)) ([c9c4984](https://github.com/kufu/tamatebako/commit/c9c49848293fd88640e886c6586ae8d92a99f40c))
+* trim-propsでtemplate literalもautofixの対象にする ([#884](https://github.com/kufu/tamatebako/issues/884)) ([4072950](https://github.com/kufu/tamatebako/commit/40729507f5084308128ca39d5887ee81f2f67dd5))
+
 ## [2.1.0](https://github.com/kufu/tamatebako/compare/eslint-plugin-smarthr-v2.0.0...eslint-plugin-smarthr-v2.1.0) (2025-10-29)
 
 

package/package.json

@@ -1,12 +1,12 @@
 {
   "name": "eslint-plugin-smarthr",
-  "version": "2.1.0",
+  "version": "2.2.1",
   "author": "SmartHR",
   "license": "MIT",
   "description": "A sharable ESLint plugin for SmartHR",
   "main": "index.js",
   "engines": {
-    "node": ">=22.21.0"
+    "node": ">=22.21.1"
   },
   "scripts": {
     "test": "jest"
@@ -26,7 +26,7 @@
     "json5": "^2.2.3"
   },
   "devDependencies": {
-    "typescript-eslint": "^8.46.2"
+    "typescript-eslint": "^8.46.3"
   },
   "peerDependencies": {
     "eslint": "^9"
@@ -37,5 +37,5 @@
     "eslintplugin",
     "smarthr"
   ],
-  "gitHead": "41a58b02c8a6116db8f65bfed94283fa0187d53f"
+  "gitHead": "a730418d8a507045795ce6140a58b5aea18c818b"
 }

package/rules/a11y-anchor-has-href-attribute/index.js

@@ -91,7 +91,7 @@ module.exports = {
           reporter(node)
         }
       },
-      [`${ANCHOR_ELEMENT}:has(${HREF_ATTRIBUTE}:matches([value=null],:has(Literal[value=/^(|#)$/])))`]: reporter,
+      [`${ANCHOR_ELEMENT}:has(${HREF_ATTRIBUTE}:matches([value=null],:has(>Literal[value=/^(|#)$/]),:has(>JSXExpressionContainer[expression.value=/^(|#)$/])))`]: reporter,
     }
   },
 }

package/rules/a11y-help-link-with-support-href/index.js

@@ -1,7 +1,7 @@
 const SCHEMA = []
 
 const SUPPORT_URL_PREFIX_REGEX = /(\/|\.)support\./
-const SUPPORT_IDENTIFIER_REGEX = /(S|(^|_)s)upport(.*)(H(ref|REF)|U(rl|URL))$/
+const SUPPORT_IDENTIFIER_REGEX = /(S|(^|_)s)upport(.*)(H(ref|REF)|U(rl|RL))$/
 const PATH_OBJ_REGEX = /^((p|P)ath|PATH)\./
 const SUPPORT_PATH_MEMBER_REGEX = /\.support\./
 

package/rules/a11y-input-has-name-attribute/index.js

@@ -67,7 +67,7 @@ module.exports = {
  - 適切に指定することで同じname属性を指定したinput[radio]とグループが確立され、適切なキーボード操作を行えるようになります${MESSAGE_UNDEFINED_NAME_PART}`,
         })
       },
-      [`${INPUT_ELEMENT}${notHasSpreadAttribute} ${NAME_ATTRIBUTE}:not([value.value=${INPUT_NAME_REGEX}])`]: (node) => {
+      [`${INPUT_ELEMENT}${notHasSpreadAttribute} ${NAME_ATTRIBUTE}[value.value]:not([value.value=${INPUT_NAME_REGEX}])`]: (node) => {
         context.report({
           node,
           message: `${node.parent.name.name} のname属性の値(${node.value.value})はブラウザの自動補完が適切に行えない可能性があるため${MESSAGE_PART_FORMAT}`,

package/rules/trim-props/index.js

@@ -1,5 +1,4 @@
 const SCHEMA = []
-const EXTRA_SPACE_REGES = /(^\s+|\s+$)/
 
 /**
  * @type {import('@typescript-eslint/utils').TSESLint.RuleModule<''>}
@@ -12,22 +11,20 @@ module.exports = {
   },
   create(context) {
     return {
-      JSXOpeningElement: (node) =>
-        node.attributes.forEach((current) => {
-          const attribute = current.value?.type === 'JSXExpressionContainer' ? current.value.expression : current.value
-          const props = attribute?.value
-
-          if (typeof props === 'string' && EXTRA_SPACE_REGES.test(props)) {
-            return context.report({
-              node,
-              loc: current.loc,
-              message: '属性に設定している文字列から先頭、末尾の空白文字を削除してください',
-              fix(fixer) {
-                return fixer.replaceTextRange([attribute.range[0] + 1, attribute.range[1] - 1], props.trim())
-              },
-            })
-          }
+      'JSXAttribute Literal[value=/(^ | $)/]': (node) => {
+        return context.report({
+          node,
+          message: '属性に設定している文字列から先頭、末尾の空白文字を削除してください',
+          fix: (fixer) => fixer.replaceText(node, context.sourceCode.getText(node).replace(/^('|")\s+/, '$1').replace(/\s+('|")$/, '$1')),
+        })
+      },
+      'JSXAttribute TemplateLiteral:has(TemplateElement:matches(:first-child[value.raw=/^ /],:last-child[value.raw=/ $/]))': (node) => {
+        return context.report({
+          node,
+          message: '属性に設定している文字列から先頭、末尾の空白文字を削除してください',
+          fix: (fixer) => fixer.replaceText(node, context.sourceCode.getText(node).replace(/(^`\s+|\s+`$)/g, '`')),
         })
+      },
     }
   },
 }

package/test/a11y-help-link-with-support-href.js

@@ -19,7 +19,8 @@ ruleTester.run('a11y-help-link-with-support-href', rule, {
     { code: `<HelpLink href="//support.hoge" />` },
     { code: `<HelpLink href={"//support.hoge"} />` },
     { code: `<HelpLink href={path.support.hoge} />` },
-    { code: `<HelpLink href={supportUrl} />` },
+    { code: `<HelpLink href={supportURL} />` },
+    { code: `<HelpLink href={supportHref} />` },
   ],
   invalid: [
     { code: `<Anchor href="//support.hoge">any</Anchor>`, errors: [{ message: errorText }] },

package/test/a11y-input-has-name-attribute.js

@@ -26,6 +26,7 @@ ruleTester.run('a11y-input-has-name-attribute', rule, {
     { code: '<HogeTextarea name="hoge" />' },
     { code: '<select name="hoge" />' },
     { code: '<Select name="hoge[0][Fuga]" />' },
+    { code: '<Select name={`ABC`} />' },
     { code: '<Input {...hoge} />', options: [{ checkType: 'allow-spread-attributes' }] },
     { code: '<Input {...args1} {...args2} />', options: [{ checkType: 'allow-spread-attributes' }] },
     { code: '<Input {...args} hoge="fuga" />', options: [{ checkType: 'allow-spread-attributes' }] },

package/test/trim-props.js

@@ -16,8 +16,9 @@ ruleTester.run('trim-props', rule, {
     { code: '<a href="https://www.google.com">google</a>' },
     { code: '<a href={"https://www.google.com"}>google</a>' },
     { code: '<img src="/sample.jpg" alt="sample" />' },
-    { code: '<img src={"/sample.jpg"} alt={"sample"} />' },
+    { code: `<img src={'/sample.jpg'} alt={'sample'} />` },
     { code: '<div data-spec="info-area">....</div>' },
+    { code: '<div data-spec={`a${b} c`}>....</div>' },
   ],
   invalid: [
     {
@@ -59,8 +60,8 @@ ruleTester.run('trim-props', rule, {
       ],
     },
     {
-      code: '<img src={" /sample.jpg"} alt={"sample "} />',
-      output: '<img src={"/sample.jpg"} alt={"sample"} />',
+      code: `<img src={' /sample.jpg'} alt={'sample '} />`,
+      output: `<img src={'/sample.jpg'} alt={'sample'} />`,
       errors: [
         { message: '属性に設定している文字列から先頭、末尾の空白文字を削除してください' },
         { message: '属性に設定している文字列から先頭、末尾の空白文字を削除してください' },
@@ -76,5 +77,15 @@ ruleTester.run('trim-props', rule, {
       output: '<div data-spec={"info-area"}>....</div>',
       errors: [{ message: '属性に設定している文字列から先頭、末尾の空白文字を削除してください' }],
     },
+    {
+      code: '<div data-spec={` ab c `}>....</div>',
+      output: '<div data-spec={`ab c`}>....</div>',
+      errors: [{ message: '属性に設定している文字列から先頭、末尾の空白文字を削除してください' }],
+    },
+    {
+      code: '<div data-spec={` a${b} c `}>....</div>',
+      output: '<div data-spec={`a${b} c`}>....</div>',
+      errors: [{ message: '属性に設定している文字列から先頭、末尾の空白文字を削除してください' }],
+    },
   ],
-})
+})