eslint-plugin-smarthr 0.5.5 → 0.5.6

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/CHANGELOG.md CHANGED
@@ -2,6 +2,13 @@
2
2
 
3
3
  All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
4
4
 
5
+ ### [0.5.6](https://github.com/kufu/eslint-plugin-smarthr/compare/v0.5.5...v0.5.6) (2024-03-29)
6
+
7
+
8
+ ### Bug Fixes
9
+
10
+ * best-practice-for-layoutsで "a?.map(function)" のようにchainを使っている場合正しく検知できなかった問題を修正 ([#131](https://github.com/kufu/eslint-plugin-smarthr/issues/131)) ([80da1ca](https://github.com/kufu/eslint-plugin-smarthr/commit/80da1caa3d9b8cf9e3fc9d9cfd3f1b0e28be9e29))
11
+
5
12
  ### [0.5.5](https://github.com/kufu/eslint-plugin-smarthr/compare/v0.5.4...v0.5.5) (2024-03-29)
6
13
 
7
14
 
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "eslint-plugin-smarthr",
3
- "version": "0.5.5",
3
+ "version": "0.5.6",
4
4
  "author": "SmartHR",
5
5
  "license": "MIT",
6
6
  "description": "A sharable ESLint plugin for SmartHR",
@@ -40,6 +40,7 @@ const searchChildren = (node) => {
40
40
 
41
41
  switch(node.type) {
42
42
  case 'JSXExpressionContainer':
43
+ case 'ChainExpression':
43
44
  return searchChildren(node.expression)
44
45
  case 'CallExpression':
45
46
  return node.callee.property?.name !== 'map'
@@ -3,7 +3,7 @@ const RuleTester = require('eslint').RuleTester
3
3
 
4
4
  const ruleTester = new RuleTester({
5
5
  parserOptions: {
6
- ecmaVersion: 2018,
6
+ ecmaVersion: 12,
7
7
  ecmaFeatures: {
8
8
  experimentalObjectRestSpread: true,
9
9
  jsx: true,
@@ -3,7 +3,7 @@ const RuleTester = require('eslint').RuleTester
3
3
 
4
4
  const ruleTester = new RuleTester({
5
5
  parserOptions: {
6
- ecmaVersion: 2018,
6
+ ecmaVersion: 12,
7
7
  ecmaFeatures: {
8
8
  experimentalObjectRestSpread: true,
9
9
  jsx: true,
@@ -3,7 +3,7 @@ const RuleTester = require('eslint').RuleTester;
3
3
 
4
4
  const ruleTester = new RuleTester({
5
5
  parserOptions: {
6
- ecmaVersion: 2018,
6
+ ecmaVersion: 12,
7
7
  ecmaFeatures: {
8
8
  experimentalObjectRestSpread: true,
9
9
  jsx: true,
@@ -3,7 +3,7 @@ const RuleTester = require('eslint').RuleTester
3
3
 
4
4
  const ruleTester = new RuleTester({
5
5
  parserOptions: {
6
- ecmaVersion: 2018,
6
+ ecmaVersion: 12,
7
7
  ecmaFeatures: {
8
8
  experimentalObjectRestSpread: true,
9
9
  jsx: true,
@@ -3,7 +3,7 @@ const RuleTester = require('eslint').RuleTester;
3
3
 
4
4
  const ruleTester = new RuleTester({
5
5
  parserOptions: {
6
- ecmaVersion: 2018,
6
+ ecmaVersion: 12,
7
7
  ecmaFeatures: {
8
8
  experimentalObjectRestSpread: true,
9
9
  jsx: true,
@@ -3,7 +3,7 @@ const RuleTester = require('eslint').RuleTester
3
3
 
4
4
  const ruleTester = new RuleTester({
5
5
  parserOptions: {
6
- ecmaVersion: 2018,
6
+ ecmaVersion: 12,
7
7
  ecmaFeatures: {
8
8
  experimentalObjectRestSpread: true,
9
9
  jsx: true,
@@ -3,7 +3,7 @@ const RuleTester = require('eslint').RuleTester;
3
3
 
4
4
  const ruleTester = new RuleTester({
5
5
  parserOptions: {
6
- ecmaVersion: 2018,
6
+ ecmaVersion: 12,
7
7
  ecmaFeatures: {
8
8
  experimentalObjectRestSpread: true,
9
9
  jsx: true,
@@ -3,7 +3,7 @@ const RuleTester = require('eslint').RuleTester
3
3
 
4
4
  const ruleTester = new RuleTester({
5
5
  parserOptions: {
6
- ecmaVersion: 2018,
6
+ ecmaVersion: 12,
7
7
  ecmaFeatures: {
8
8
  experimentalObjectRestSpread: true,
9
9
  jsx: true,
@@ -3,7 +3,7 @@ const RuleTester = require('eslint').RuleTester
3
3
 
4
4
  const ruleTester = new RuleTester({
5
5
  parserOptions: {
6
- ecmaVersion: 2018,
6
+ ecmaVersion: 12,
7
7
  ecmaFeatures: {
8
8
  experimentalObjectRestSpread: true,
9
9
  jsx: true,
@@ -3,7 +3,7 @@ const RuleTester = require('eslint').RuleTester
3
3
 
4
4
  const ruleTester = new RuleTester({
5
5
  parserOptions: {
6
- ecmaVersion: 2018,
6
+ ecmaVersion: 12,
7
7
  ecmaFeatures: {
8
8
  experimentalObjectRestSpread: true,
9
9
  jsx: true,
@@ -3,7 +3,7 @@ const RuleTester = require('eslint').RuleTester
3
3
 
4
4
  const ruleTester = new RuleTester({
5
5
  parserOptions: {
6
- ecmaVersion: 2018,
6
+ ecmaVersion: 12,
7
7
  ecmaFeatures: {
8
8
  experimentalObjectRestSpread: true,
9
9
  jsx: true,
@@ -3,7 +3,7 @@ const RuleTester = require('eslint').RuleTester
3
3
 
4
4
  const ruleTester = new RuleTester({
5
5
  parserOptions: {
6
- ecmaVersion: 2018,
6
+ ecmaVersion: 12,
7
7
  ecmaFeatures: {
8
8
  experimentalObjectRestSpread: true,
9
9
  jsx: true,
@@ -3,7 +3,7 @@ const RuleTester = require('eslint').RuleTester
3
3
 
4
4
  const ruleTester = new RuleTester({
5
5
  parserOptions: {
6
- ecmaVersion: 2018,
6
+ ecmaVersion: 12,
7
7
  ecmaFeatures: {
8
8
  experimentalObjectRestSpread: true,
9
9
  jsx: true,
@@ -3,7 +3,7 @@ const RuleTester = require('eslint').RuleTester
3
3
 
4
4
  const ruleTester = new RuleTester({
5
5
  parserOptions: {
6
- ecmaVersion: 2018,
6
+ ecmaVersion: 12,
7
7
  ecmaFeatures: {
8
8
  experimentalObjectRestSpread: true,
9
9
  jsx: true,
@@ -3,7 +3,7 @@ const RuleTester = require('eslint').RuleTester
3
3
 
4
4
  const ruleTester = new RuleTester({
5
5
  parserOptions: {
6
- ecmaVersion: 2018,
6
+ ecmaVersion: 12,
7
7
  ecmaFeatures: {
8
8
  experimentalObjectRestSpread: true,
9
9
  jsx: true,
@@ -29,6 +29,9 @@ ruleTester.run('best-practice-for-button-element', rule, {
29
29
  { code: `<Stack><Hoge /><Hoge /></Stack>` },
30
30
  { code: `<Stack>{a}<Hoge /></Stack>` },
31
31
  { code: `<AnyStack>{a.map(action)}</AnyStack>` },
32
+ { code: `<AnyStack>{a?.map(action)}</AnyStack>` },
33
+ { code: `<AnyStack>{a.b?.map(action)}</AnyStack>` },
34
+ { code: `<AnyStack>{a?.b?.map(action)}</AnyStack>` },
32
35
  { code: `<AnyStack>{a && <><Hoge /><Hoge /></>}</AnyStack>` },
33
36
  { code: `<AnyStack>{a && a.map(action)}</AnyStack>` },
34
37
  { code: `<AnyStack>{a && a.b.map(action)}</AnyStack>` },
@@ -3,7 +3,7 @@ const RuleTester = require('eslint').RuleTester
3
3
 
4
4
  const ruleTester = new RuleTester({
5
5
  parserOptions: {
6
- ecmaVersion: 2018,
6
+ ecmaVersion: 12,
7
7
  ecmaFeatures: {
8
8
  experimentalObjectRestSpread: true,
9
9
  jsx: true,
@@ -3,7 +3,7 @@ const RuleTester = require('eslint').RuleTester
3
3
 
4
4
  const ruleTester = new RuleTester({
5
5
  parserOptions: {
6
- ecmaVersion: 2018,
6
+ ecmaVersion: 12,
7
7
  ecmaFeatures: {
8
8
  experimentalObjectRestSpread: true,
9
9
  jsx: true,
@@ -4,7 +4,7 @@ const RuleTester = require('eslint').RuleTester
4
4
  const ruleTester = new RuleTester({
5
5
  parserOptions: {
6
6
  sourceType: 'module',
7
- ecmaVersion: 2015
7
+ ecmaVersion: 12
8
8
  },
9
9
  })
10
10
 
@@ -4,7 +4,7 @@ const RuleTester = require('eslint').RuleTester
4
4
  const ruleTester = new RuleTester({
5
5
  parserOptions: {
6
6
  sourceType: 'module',
7
- ecmaVersion: 2015
7
+ ecmaVersion: 12
8
8
  },
9
9
  })
10
10
 
@@ -4,7 +4,7 @@ const RuleTester = require('eslint').RuleTester
4
4
  const ruleTester = new RuleTester({
5
5
  parserOptions: {
6
6
  sourceType: 'module',
7
- ecmaVersion: 2015
7
+ ecmaVersion: 12
8
8
  },
9
9
  })
10
10
 
@@ -3,7 +3,7 @@ const RuleTester = require('eslint').RuleTester
3
3
 
4
4
  const ruleTester = new RuleTester({
5
5
  parserOptions: {
6
- ecmaVersion: 2018,
6
+ ecmaVersion: 12,
7
7
  ecmaFeatures: {
8
8
  experimentalObjectRestSpread: true,
9
9
  jsx: true,
@@ -4,7 +4,7 @@ const RuleTester = require('eslint').RuleTester
4
4
  const ruleTester = new RuleTester({
5
5
  parserOptions: {
6
6
  sourceType: 'module',
7
- ecmaVersion: 2015
7
+ ecmaVersion: 12
8
8
  },
9
9
  })
10
10
 
@@ -4,7 +4,7 @@ const RuleTester = require('eslint').RuleTester
4
4
  const ruleTester = new RuleTester({
5
5
  parserOptions: {
6
6
  sourceType: 'module',
7
- ecmaVersion: 2015
7
+ ecmaVersion: 12
8
8
  },
9
9
  })
10
10