eslint-plugin-smarthr 0.3.8 → 0.3.9

package/CHANGELOG.md

@@ -2,6 +2,13 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+### [0.3.9](https://github.com/kufu/eslint-plugin-smarthr/compare/v0.3.8...v0.3.9) (2023-09-04)
+
+
+### Features
+
+* `new Date("YYYY/MM/DD")` のように日付文字列を直接設定している場合 `new Date(YYYY, MM - 1, DD)` に置き換えるfixerを追加 ([#76](https://github.com/kufu/eslint-plugin-smarthr/issues/76)) ([16a689a](https://github.com/kufu/eslint-plugin-smarthr/commit/16a689a6fe9ef240baaf66bcac08992328a64c4e))
+
 ### [0.3.8](https://github.com/kufu/eslint-plugin-smarthr/compare/v0.3.7...v0.3.8) (2023-09-01)
 
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-smarthr",
-  "version": "0.3.8",
+  "version": "0.3.9",
   "author": "SmartHR",
   "license": "MIT",
   "description": "A sharable ESLint plugin for SmartHR",

package/rules/best-practice-for-date/index.js

@@ -5,10 +5,31 @@ const MESSAGE_PARSE = `Date.parse は実行環境によって結果が異なる
  - 'new Date(2022, 12 - 1, 31).getTime()' のように数値を個別に指定する
  - dayjsなど、日付系ライブラリを利用する (例: 'dayjs(arg).valueOf()')`
 
+const SEPARATOR = '(\/|-)'
+const DATE_REGEX = new RegExp(`^([0-9]{4})${SEPARATOR}([0-9]{1,2})${SEPARATOR}([0-9]{1,2})`)
+
+const fixAction = (fixer, node, replacedSuffix = '') => {
+  const arg = node.arguments[0]
+
+  if (arg.type == 'Literal') {
+    const parsedArgs = arg.value.match(DATE_REGEX)
+
+    if (parsedArgs) {
+      return fixer.replaceText(
+        node,
+        `new Date(${parsedArgs[1] * 1}, ${parsedArgs[3] * 1} - 1, ${parsedArgs[5] * 1})${replacedSuffix}`
+      )
+    }
+  }
+}
+
+const SCHEMA = []
+
 module.exports = {
   meta: {
     type: 'problem',
-    schema: [],
+    fixable: 'code',
+    schema: SCHEMA,
   },
   create(context) {
     return {
@@ -20,6 +41,7 @@ module.exports = {
           context.report({
             node,
             message: MESSAGE_NEW_DATE,
+            fix: (fixer) => fixAction(fixer, node),
           });
         }
       },
@@ -31,10 +53,11 @@ module.exports = {
           context.report({
             node,
             message: MESSAGE_PARSE,
+            fix: (fixer) => fixAction(fixer, node, '.getTime()'),
           });
         }
       },
     }
   },
 }
-module.exports.schema = []
+module.exports.schema = SCHEMA