eslint-plugin-sfmc 4.3.0 → 4.4.1

package/README.md

@@ -128,7 +128,8 @@ export default [...sfmc.configs['recommended-next'], ...sfmc.configs['embedded-n
 | [`sfmc/ssjs-no-unsupported-syntax`](docs/rules/ssjs/no-unsupported-syntax.md)               | `error`                  | Flag ES6+ syntax not supported by SFMC                                   |
 | [`sfmc/ssjs-no-unknown-function`](docs/rules/ssjs/no-unknown-function.md)                   | `error`                  | Disallow unknown methods on Platform.\*, HTTP, Core Library, and WSProxy |
 | [`sfmc/ssjs-no-mcn-unsupported`](docs/rules/ssjs/no-mcn-unsupported.md)                     | off (`error` in `-next`) | Flag all SSJS API usage as unsupported in Marketing Cloud Next           |
-| [`sfmc/ssjs-no-deprecated-function`](docs/rules/ssjs/no-deprecated-function.md)             | `error`                  | Flag use of deprecated SFMC SSJS APIs (e.g. ContentArea, ContentAreaObj) |
+| [`sfmc/ssjs-no-deprecated-function`](docs/rules/ssjs/no-deprecated-function.md)             | `error`                  | Flag use of deprecated SFMC SSJS APIs (e.g. ContentArea, ErrorUtil)      |
+| [`sfmc/ssjs-no-nonexistent-global`](docs/rules/ssjs/no-nonexistent-global.md)               | `error`                  | Flag documented SSJS globals that throw ReferenceError at runtime        |
 | [`sfmc/ssjs-no-property-call`](docs/rules/ssjs/no-property-call.md)                         | `error`                  | Disallow calling Platform.Request/Response properties as functions       |
 | [`sfmc/ssjs-no-clr-header-access`](docs/rules/ssjs/no-clr-header-access.md)                 | `error`                  | Disallow CLR-unsafe reads of `HttpResponse.headers`; read via `for..in`  |
 | [`sfmc/ssjs-require-string-clr-content`](docs/rules/ssjs/require-string-clr-content.md)     | `error`                  | Require wrapping `HttpResponse.content` with `String()` before use       |

package/docs/rules/ssjs/no-deprecated-function.md

@@ -1,7 +1,8 @@
 # `sfmc/ssjs-no-deprecated-function`
 
-Flags calls to deprecated SFMC SSJS APIs. Currently focuses on the **Content Areas** feature,
-which has been retired and no longer allows creating or updating content.
+Flags calls to deprecated SFMC SSJS APIs, chiefly the **Content Areas** feature,
+which has been retired and no longer allows creating or updating content, plus the
+legacy `ErrorUtil` helper that only exists under the oldest Core version.
 
 ## What is flagged
 
@@ -16,6 +17,7 @@ which has been retired and no longer allows creating or updating content.
 | `ContentAreaObj.Retrieve(…)` | ContentAreaObj class is deprecated |
 | `<contentAreaVar>.Update(…)` | Instance method on a deprecated ContentAreaObj variable |
 | `<contentAreaVar>.Remove()` | Instance method on a deprecated ContentAreaObj variable |
+| `ErrorUtil.ThrowWSProxyError(…)` | Only exists under `Platform.Load("Core", "1")`; undefined in newer Core versions — check `result.Status` and `throw new Error(…)` instead |
 
 ## Examples
 

package/docs/rules/ssjs/no-nonexistent-global.md

@@ -0,0 +1,37 @@
+# `sfmc/ssjs-no-nonexistent-global`
+
+Flags bare-name SSJS globals that are officially documented but proven **not to exist
+at runtime** — calling them throws a `ReferenceError`. Unlike deprecated APIs (which
+still run), these never work.
+
+## What is flagged
+
+| API | Reason |
+|---|---|
+| `Redirect(url, movedPermanently)` | Not injected by `Platform.Load` under any Core version; calling it throws a `ReferenceError`. Use `Platform.Response.Redirect(url, movedPermanently)` instead. |
+
+The list is driven by `ssjs-data`'s `notDefinedAtRuntime` flag, so new phantom globals
+are picked up automatically without editing this rule.
+
+## Examples
+
+### ❌ Incorrect
+
+```js
+// Bare-name Redirect does not exist at runtime — throws ReferenceError
+Redirect('https://example.com', false);
+```
+
+### ✅ Correct
+
+```js
+// Platform.Response.Redirect is always available in CloudPages
+Platform.Response.Redirect('https://example.com', false);
+```
+
+## Rule details
+
+- **Type:** `problem`
+- **Fixable:** No
+- **Recommended:** Yes
+- **Strict:** Yes

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "eslint-plugin-sfmc",
-    "version": "4.3.0",
+    "version": "4.4.1",
     "description": "ESLint plugin for Salesforce Marketing Cloud Engagement+Next - AMPscript, Server-Side JavaScript (SSJS) and Handlebars",
     "type": "module",
     "main": "src/index.js",
@@ -42,7 +42,7 @@
         "eslint-plugin-mso-email": "^2.0.0",
         "handlebars-data": "^0.3.0",
         "mso-conditional-parser": "^2.0.1",
-        "ssjs-data": "^0.18.0"
+        "ssjs-data": "^0.20.0"
     },
     "peerDependencies": {
         "eslint": ">=9.0.0"

package/src/index.js

@@ -43,6 +43,7 @@ import ssjsNoUnsupportedSyntax from './rules/ssjs/no-unsupported-syntax.js';
 import ssjsNoUnknownFunction from './rules/ssjs/no-unknown-function.js';
 import ssjsNoMcnUnsupported from './rules/ssjs/no-mcn-unsupported.js';
 import ssjsNoDeprecatedFunction from './rules/ssjs/no-deprecated-function.js';
+import ssjsNoNonexistentGlobal from './rules/ssjs/no-nonexistent-global.js';
 import ssjsNoPropertyCall from './rules/ssjs/no-property-call.js';
 import ssjsPlatformFunctionArity from './rules/ssjs/platform-function-arity.js';
 import ssjsCacheLoopLength from './rules/ssjs/cache-loop-length.js';
@@ -125,6 +126,7 @@ const plugin = {
         'ssjs-no-unknown-function': ssjsNoUnknownFunction,
         'ssjs-no-mcn-unsupported': ssjsNoMcnUnsupported,
         'ssjs-no-deprecated-function': ssjsNoDeprecatedFunction,
+        'ssjs-no-nonexistent-global': ssjsNoNonexistentGlobal,
         'ssjs-no-property-call': ssjsNoPropertyCall,
         'ssjs-platform-function-arity': ssjsPlatformFunctionArity,
         'ssjs-cache-loop-length': ssjsCacheLoopLength,
@@ -171,6 +173,7 @@ const ssjsMcnRules = {
     'sfmc/ssjs-require-platform-load': 'off',
     'sfmc/ssjs-no-unsupported-syntax': 'off',
     'sfmc/ssjs-no-deprecated-function': 'off',
+    'sfmc/ssjs-no-nonexistent-global': 'off',
     'sfmc/ssjs-no-property-call': 'off',
     'sfmc/ssjs-platform-function-arity': 'off',
     'sfmc/ssjs-cache-loop-length': 'off',
@@ -242,6 +245,7 @@ const ssjsRecommendedRules = {
     'sfmc/ssjs-no-unsupported-syntax': 'error',
     'sfmc/ssjs-no-unknown-function': 'error',
     'sfmc/ssjs-no-deprecated-function': 'error',
+    'sfmc/ssjs-no-nonexistent-global': 'error',
     'sfmc/ssjs-no-property-call': 'error',
     'sfmc/ssjs-platform-function-arity': 'error',
     'sfmc/ssjs-cache-loop-length': 'warn',
@@ -266,6 +270,7 @@ const ssjsStrictRules = {
     'sfmc/ssjs-no-unsupported-syntax': 'error',
     'sfmc/ssjs-no-unknown-function': 'error',
     'sfmc/ssjs-no-deprecated-function': 'error',
+    'sfmc/ssjs-no-nonexistent-global': 'error',
     'sfmc/ssjs-no-property-call': 'error',
     'sfmc/ssjs-platform-function-arity': 'error',
     'sfmc/ssjs-cache-loop-length': 'error',

package/src/rules/ssjs/no-deprecated-function.js

@@ -12,9 +12,15 @@
  *   - ContentAreaObj.Retrieve(...) — static method
  *   - <contentAreaObjVar>.Update(...) — instance method on a tracked ContentAreaObj variable
  *   - <contentAreaObjVar>.Remove()    — instance method on a tracked ContentAreaObj variable
+ *   - ErrorUtil.ThrowWSProxyError(...) — deprecated; only exists under Platform.Load("Core", "1")
  */
 
-import { platformFunctionLookup, SSJS_GLOBALS, CONTENT_AREA_OBJ_METHODS } from 'ssjs-data';
+import {
+    platformFunctionLookup,
+    SSJS_GLOBALS,
+    CONTENT_AREA_OBJ_METHODS,
+    ERROR_UTIL_METHODS,
+} from 'ssjs-data';
 
 // Lookup Map: lowercase name → entry, for SSJS_GLOBALS entries that are deprecated.
 // Used to flag bare calls like ContentArea(...) and ContentAreaByName(...).
@@ -38,6 +44,12 @@ const CONTENT_AREA_INSTANCE_DEPRECATED = new Set(
     ),
 );
 
+// Deprecated ErrorUtil methods (e.g. ThrowWSProxyError). Used to flag calls like
+// ErrorUtil.ThrowWSProxyError(result), which only exists under Platform.Load("Core", "1").
+const ERRORUTIL_DEPRECATED = new Set(
+    ERROR_UTIL_METHODS.filter((m) => m.deprecated).map((m) => m.name.toLowerCase()),
+);
+
 export default {
     meta: {
         type: 'suggestion',
@@ -52,6 +64,8 @@ export default {
                 "'ContentAreaObj.{{name}}' is deprecated. Content Areas are no longer supported.",
             deprecatedCoreInstance:
                 "'{{method}}' called on a ContentAreaObj variable is deprecated. Content Areas are no longer supported.",
+            deprecatedErrorUtil:
+                "'ErrorUtil.{{name}}' is deprecated — it only exists under Platform.Load(\"Core\", \"1\") and is undefined in newer Core versions. Check 'result.Status' and 'throw new Error(...)' instead.",
         },
         schema: [],
     },
@@ -143,6 +157,20 @@ export default {
                     return;
                 }
 
+                // ── ErrorUtil.ThrowWSProxyError(…) — deprecated ───────────────
+                if (
+                    callee.object.type === 'Identifier' &&
+                    callee.object.name === 'ErrorUtil' &&
+                    ERRORUTIL_DEPRECATED.has(methodName.toLowerCase())
+                ) {
+                    context.report({
+                        node: property,
+                        messageId: 'deprecatedErrorUtil',
+                        data: { name: methodName },
+                    });
+                    return;
+                }
+
                 // ── <contentAreaVar>.Update/Remove() — instance deprecated ─────
                 if (
                     callee.object.type === 'Identifier' &&

package/src/rules/ssjs/no-nonexistent-global.js

@@ -0,0 +1,67 @@
+/**
+ * Rule: ssjs-no-nonexistent-global
+ *
+ * Flags bare-name SSJS globals that are officially documented but proven NOT to
+ * exist at runtime as callable identifiers — calling them throws a ReferenceError.
+ *
+ * The offending names come from ssjs-data's `notDefinedAtRuntime` flag, so phantom
+ * globals are picked up automatically without editing this rule. Only bare-name
+ * callable phantoms (Identifier callees) are flagged here; object-namespace
+ * phantoms accessed via member calls (e.g. `Recipient.GetAttributeValue(...)`) are
+ * out of scope for this rule.
+ *
+ * Note: many bare-name Core globals (Write, Stringify, Base64Encode, Format,
+ * Redirect, …) are NOT phantom — they exist after `Platform.Load("core")` when
+ * called in the same scope as the load, so they are intentionally not flagged.
+ */
+
+import { notDefinedAtRuntimeGlobalLookup } from 'ssjs-data';
+
+/**
+ * Extract a runtime-safe replacement suggestion for a phantom global from its
+ * ssjs-data entry. Prefers the `Platform.*` call named in the officialDocsNote,
+ * falling back to a generic hint.
+ *
+ * @param {object} entry - The ssjs-data global entry.
+ * @returns {string} A replacement suggestion (e.g. `Platform.Response.Redirect(...)`).
+ */
+function replacementFor(entry) {
+    const source = `${entry.officialDocsNote ?? ''} ${entry.description ?? ''}`;
+    const match = source.match(/Platform\.[A-Za-z.]+\([^)]*\)/);
+    return match ? match[0] : 'a supported alternative';
+}
+
+export default {
+    meta: {
+        type: 'problem',
+        docs: {
+            description:
+                'Disallow SSJS globals that are documented but do not exist at runtime (throw ReferenceError)',
+        },
+        messages: {
+            nonexistentGlobal:
+                "'{{name}}' does not exist at runtime (calling it throws a ReferenceError). Use {{replacement}} instead.",
+        },
+        schema: [],
+    },
+
+    create(context) {
+        return {
+            CallExpression(node) {
+                const callee = node.callee;
+                if (callee.type !== 'Identifier') {
+                    return;
+                }
+                const entry = notDefinedAtRuntimeGlobalLookup.get(callee.name.toLowerCase());
+                if (!entry) {
+                    return;
+                }
+                context.report({
+                    node: callee,
+                    messageId: 'nonexistentGlobal',
+                    data: { name: callee.name, replacement: replacementFor(entry) },
+                });
+            },
+        };
+    },
+};