eslint-plugin-sfmc 0.1.1 → 0.2.0

package/src/rules/amp/require-rowcount-check.js

@@ -24,7 +24,9 @@ function isRowCountCall(node) {
 }
 
 function extractRowCountVariables(node, into) {
-    if (!node) return;
+    if (!node) {
+        return;
+    }
 
     if (isRowCountCall(node) && node.arguments && node.arguments.length > 0) {
         const argument = node.arguments[0];

package/src/rules/amp/require-variable-declaration.js

@@ -1,5 +1,5 @@
 /**
- * Requires that @variables are declared with `var` before being used in
+ * Requires that `@variables` are declared with `var` before being used in
  * `set` statements. System variables (@@) and personalization strings
  * (no @ prefix) are not affected.
  *
@@ -33,9 +33,13 @@ export default {
             },
 
             SetStatement(node) {
-                if (!node.target) return;
+                if (!node.target) {
+                    return;
+                }
                 const name = node.target.value;
-                if (name.startsWith('@@')) return;
+                if (name.startsWith('@@')) {
+                    return;
+                }
                 if (!declared.has(name.toLowerCase())) {
                     context.report({
                         node: node.target,

package/src/rules/ssjs/cache-loop-length.js

@@ -32,7 +32,9 @@ export default {
         return {
             ForStatement(node) {
                 const test = node.test;
-                if (!test || test.type !== 'BinaryExpression') return;
+                if (!test || test.type !== 'BinaryExpression') {
+                    return;
+                }
 
                 let lengthExpr = null;
                 if (containsMemberLength(test.right)) {
@@ -41,7 +43,9 @@ export default {
                     lengthExpr = test.left;
                 }
 
-                if (!lengthExpr) return;
+                if (!lengthExpr) {
+                    return;
+                }
 
                 context.report({
                     node: test,
@@ -54,7 +58,9 @@ export default {
 };
 
 function containsMemberLength(node) {
-    if (!node) return false;
+    if (!node) {
+        return false;
+    }
     if (
         node.type === 'MemberExpression' &&
         node.property.type === 'Identifier' &&
@@ -81,7 +87,7 @@ function buildCacheSuggestion(forNode, lengthExpr, context) {
             messageId: 'suggestCacheLength',
             data: { obj: objText },
             fix(fixer) {
-                const lastDecl = init.declarations[init.declarations.length - 1];
+                const lastDecl = init.declarations.at(-1);
                 return [
                     fixer.insertTextAfter(lastDecl, `, ${lenVar} = ${objText}.length`),
                     fixer.replaceText(lengthExpr, lenVar),

package/src/rules/ssjs/no-hardcoded-credentials.js

@@ -43,7 +43,9 @@ export default {
                     functionName = callee.property.name;
                 }
 
-                if (!functionName || !ENCRYPT_FUNCTIONS.has(functionName.toLowerCase())) return;
+                if (!functionName || !ENCRYPT_FUNCTIONS.has(functionName.toLowerCase())) {
+                    return;
+                }
 
                 for (const index of KEY_ARG_INDICES) {
                     const argument = node.arguments[index];

package/src/rules/ssjs/no-treatascontent-injection.js

@@ -19,8 +19,8 @@ export default {
         messages: {
             injection:
                 'Concatenating dynamic values into TreatAsContent() risks AMPscript injection. ' +
-                "Use Variable.SetValue() to pass values into AMPscript variables, then reference " +
-                "them with @varName inside the TreatAsContent string.",
+                'Use Variable.SetValue() to pass values into AMPscript variables, then reference ' +
+                'them with @varName inside the TreatAsContent string.',
         },
         schema: [],
     },
@@ -28,8 +28,12 @@ export default {
     create(context) {
         return {
             CallExpression(node) {
-                if (!isTreatAsContentCall(node)) return;
-                if (node.arguments.length === 0) return;
+                if (!isTreatAsContentCall(node)) {
+                    return;
+                }
+                if (node.arguments.length === 0) {
+                    return;
+                }
 
                 const arg = node.arguments[0];
                 if (containsConcatenation(arg)) {

package/src/rules/ssjs/no-unavailable-method.js

@@ -94,11 +94,15 @@ export default {
             // Array.prototype.map = ...  /  Array.isArray = ...  /  String.prototype.trim = ...
             AssignmentExpression(node) {
                 const left = node.left;
-                if (left.type !== 'MemberExpression') return;
+                if (left.type !== 'MemberExpression') {
+                    return;
+                }
 
                 const obj = left.object;
                 const prop = left.property;
-                if (prop.type !== 'Identifier') return;
+                if (prop.type !== 'Identifier') {
+                    return;
+                }
 
                 // Array.X = ...
                 if (obj.type === 'Identifier' && obj.name === 'Array') {
@@ -120,10 +124,14 @@ export default {
 
             CallExpression(node) {
                 const callee = node.callee;
-                if (callee.type !== 'MemberExpression') return;
+                if (callee.type !== 'MemberExpression') {
+                    return;
+                }
 
                 const prop = callee.property;
-                if (prop.type !== 'Identifier') return;
+                if (prop.type !== 'Identifier') {
+                    return;
+                }
 
                 const methodName = prop.name;
                 const receiver = callee.object;
@@ -134,20 +142,28 @@ export default {
                     receiver.name === 'Array' &&
                     polyfillByStaticName.has(methodName)
                 ) {
-                    if (ignored.has(methodName)) return;
+                    if (ignored.has(methodName)) {
+                        return;
+                    }
                     const entry = polyfillByStaticName.get(methodName);
                     pendingReports.push({ node: prop, entry });
                     return;
                 }
 
                 // ── Prototype methods ─────────────────────────────────────────
-                if (!polyfillByPrototypeName.has(methodName)) return;
-                if (ignored.has(methodName)) return;
+                if (!polyfillByPrototypeName.has(methodName)) {
+                    return;
+                }
+                if (ignored.has(methodName)) {
+                    return;
+                }
 
                 const entry = polyfillByPrototypeName.get(methodName);
 
                 // Skip known SFMC top-level objects to avoid false positives.
-                if (receiver.type === 'Identifier' && SFMC_RECEIVERS.has(receiver.name)) return;
+                if (receiver.type === 'Identifier' && SFMC_RECEIVERS.has(receiver.name)) {
+                    return;
+                }
 
                 // For methods that also exist on String.prototype in ES3
                 // (indexOf, lastIndexOf), only flag when the receiver is
@@ -161,7 +177,9 @@ export default {
                         (receiver.type === 'CallExpression' &&
                             receiver.callee.type === 'MemberExpression' &&
                             polyfillByPrototypeName.has(receiver.callee.property.name));
-                    if (!isDefinitelyArray) return;
+                    if (!isDefinitelyArray) {
+                        return;
+                    }
                 }
 
                 pendingReports.push({ node: prop, entry });
@@ -169,7 +187,9 @@ export default {
 
             'Program:exit'() {
                 for (const { node, entry } of pendingReports) {
-                    if (isAlreadyPolyfilled(entry.method)) continue;
+                    if (isAlreadyPolyfilled(entry.method)) {
+                        continue;
+                    }
 
                     context.report({
                         node,

package/src/rules/ssjs/no-unknown-core-method.js

@@ -30,7 +30,9 @@ export default {
         return {
             VariableDeclaration(node) {
                 for (const decl of node.declarations) {
-                    if (!decl.init || !decl.id || decl.id.type !== 'Identifier') continue;
+                    if (!decl.init || !decl.id || decl.id.type !== 'Identifier') {
+                        continue;
+                    }
                     const coreType = getCoreInitType(decl.init);
                     if (coreType) {
                         variableTypes.set(decl.id.name, coreType);
@@ -39,7 +41,9 @@ export default {
             },
 
             AssignmentExpression(node) {
-                if (node.left.type !== 'Identifier') return;
+                if (node.left.type !== 'Identifier') {
+                    return;
+                }
                 const coreType = getCoreInitType(node.right);
                 if (coreType) {
                     variableTypes.set(node.left.name, coreType);
@@ -48,18 +52,28 @@ export default {
 
             CallExpression(node) {
                 const callee = node.callee;
-                if (callee.type !== 'MemberExpression') return;
-                if (callee.object.type !== 'Identifier') return;
-                if (callee.property.type !== 'Identifier') return;
+                if (callee.type !== 'MemberExpression') {
+                    return;
+                }
+                if (callee.object.type !== 'Identifier') {
+                    return;
+                }
+                if (callee.property.type !== 'Identifier') {
+                    return;
+                }
 
                 const objectName = callee.object.name;
                 const method = callee.property.name;
 
                 const coreType = variableTypes.get(objectName);
-                if (!coreType) return;
+                if (!coreType) {
+                    return;
+                }
 
                 const objectDef = coreObjectLookup.get(coreType);
-                if (!objectDef) return;
+                if (!objectDef) {
+                    return;
+                }
 
                 const knownMethods = new Set(objectDef.methods.map((m) => m.toLowerCase()));
                 if (!knownMethods.has(method.toLowerCase())) {
@@ -79,9 +93,13 @@ export default {
 };
 
 function getCoreInitType(node) {
-    if (!node || node.type !== 'CallExpression') return null;
+    if (!node || node.type !== 'CallExpression') {
+        return null;
+    }
     const callee = node.callee;
-    if (callee.type !== 'MemberExpression') return null;
+    if (callee.type !== 'MemberExpression') {
+        return null;
+    }
 
     if (callee.property.type === 'Identifier' && callee.property.name === 'Init') {
         if (callee.object.type === 'Identifier' && coreObjectNames.has(callee.object.name)) {

package/src/rules/ssjs/no-unknown-http-method.js

@@ -23,9 +23,15 @@ export default {
         return {
             CallExpression(node) {
                 const callee = node.callee;
-                if (callee.type !== 'MemberExpression') return;
-                if (callee.object.type !== 'Identifier' || callee.object.name !== 'HTTP') return;
-                if (callee.property.type !== 'Identifier') return;
+                if (callee.type !== 'MemberExpression') {
+                    return;
+                }
+                if (callee.object.type !== 'Identifier' || callee.object.name !== 'HTTP') {
+                    return;
+                }
+                if (callee.property.type !== 'Identifier') {
+                    return;
+                }
 
                 const methodName = callee.property.name;
                 if (!httpMethodNames.has(methodName.toLowerCase())) {

package/src/rules/ssjs/no-unknown-platform-client-browser.js

@@ -1,13 +1,14 @@
 /**
  * Rule: no-unknown-platform-client-browser
  *
- * Flags calls to Platform.ClientBrowser.* where the method name does not
- * exist in the known SFMC Platform.ClientBrowser catalog.
+ * Flags calls to Platform.ClientBrowser.* — this namespace is deprecated.
+ * The methods previously under Platform.ClientBrowser.* are now available
+ * under Platform.Response.* (e.g. Platform.Response.Redirect,
+ * Platform.Response.SetCookie, Platform.Response.RemoveCookie).
+ * All Platform.ClientBrowser.* calls are flagged as unknown.
  */
 
-import { PLATFORM_CLIENT_BROWSER_METHODS } from 'ssjs-data';
-
-const knownMethods = new Set(PLATFORM_CLIENT_BROWSER_METHODS.map((m) => m.name.toLowerCase()));
+const knownMethods = new Set();
 
 export default {
     meta: {
@@ -25,7 +26,9 @@ export default {
         return {
             CallExpression(node) {
                 const callee = node.callee;
-                if (callee.type !== 'MemberExpression') return;
+                if (callee.type !== 'MemberExpression') {
+                    return;
+                }
 
                 if (
                     callee.object.type === 'MemberExpression' &&

package/src/rules/ssjs/no-unknown-platform-function.js

@@ -24,7 +24,9 @@ export default {
         return {
             CallExpression(node) {
                 const callee = node.callee;
-                if (callee.type !== 'MemberExpression') return;
+                if (callee.type !== 'MemberExpression') {
+                    return;
+                }
 
                 if (
                     callee.object.type === 'MemberExpression' &&

package/src/rules/ssjs/no-unknown-platform-request.js

@@ -25,7 +25,9 @@ export default {
         return {
             CallExpression(node) {
                 const callee = node.callee;
-                if (callee.type !== 'MemberExpression') return;
+                if (callee.type !== 'MemberExpression') {
+                    return;
+                }
 
                 if (
                     callee.object.type === 'MemberExpression' &&

package/src/rules/ssjs/no-unknown-platform-response.js

@@ -25,7 +25,9 @@ export default {
         return {
             CallExpression(node) {
                 const callee = node.callee;
-                if (callee.type !== 'MemberExpression') return;
+                if (callee.type !== 'MemberExpression') {
+                    return;
+                }
 
                 if (
                     callee.object.type === 'MemberExpression' &&

package/src/rules/ssjs/no-unknown-platform-variable.js

@@ -25,7 +25,9 @@ export default {
         return {
             CallExpression(node) {
                 const callee = node.callee;
-                if (callee.type !== 'MemberExpression') return;
+                if (callee.type !== 'MemberExpression') {
+                    return;
+                }
 
                 if (
                     callee.object.type === 'MemberExpression' &&

package/src/rules/ssjs/no-unknown-wsproxy-method.js

@@ -29,9 +29,7 @@ export default {
                         decl.id &&
                         decl.id.type === 'Identifier' &&
                         decl.init &&
-                        decl.init.type === 'NewExpression' &&
-                        decl.init.callee.type === 'Identifier' &&
-                        decl.init.callee.name === 'WSProxy'
+                        isWSProxyConstructor(decl.init)
                     ) {
                         wsproxyVariables.add(decl.id.name);
                     }
@@ -39,23 +37,26 @@ export default {
             },
 
             AssignmentExpression(node) {
-                if (
-                    node.left.type === 'Identifier' &&
-                    node.right.type === 'NewExpression' &&
-                    node.right.callee.type === 'Identifier' &&
-                    node.right.callee.name === 'WSProxy'
-                ) {
+                if (node.left.type === 'Identifier' && isWSProxyConstructor(node.right)) {
                     wsproxyVariables.add(node.left.name);
                 }
             },
 
             CallExpression(node) {
                 const callee = node.callee;
-                if (callee.type !== 'MemberExpression') return;
-                if (callee.object.type !== 'Identifier') return;
-                if (callee.property.type !== 'Identifier') return;
+                if (callee.type !== 'MemberExpression') {
+                    return;
+                }
+                if (callee.object.type !== 'Identifier') {
+                    return;
+                }
+                if (callee.property.type !== 'Identifier') {
+                    return;
+                }
 
-                if (!wsproxyVariables.has(callee.object.name)) return;
+                if (!wsproxyVariables.has(callee.object.name)) {
+                    return;
+                }
 
                 const methodName = callee.property.name;
                 if (!wsproxyMethodNames.has(methodName.toLowerCase())) {
@@ -69,3 +70,19 @@ export default {
         };
     },
 };
+function isWSProxyConstructor(node) {
+    if (!node || node.type !== 'NewExpression') {
+        return false;
+    }
+    const c = node.callee;
+    return (
+        c.type === 'MemberExpression' &&
+        c.property.type === 'Identifier' &&
+        c.property.name === 'WSProxy' &&
+        c.object.type === 'MemberExpression' &&
+        c.object.property.type === 'Identifier' &&
+        c.object.property.name === 'Util' &&
+        c.object.object.type === 'Identifier' &&
+        c.object.object.name === 'Script'
+    );
+}

package/src/rules/ssjs/no-unsupported-syntax.js

@@ -36,8 +36,7 @@ export default {
             unsupported: '{{label}} are not supported in SFMC SSJS. {{suggestion}}',
             suggestLogicalOr:
                 "Replace ?? with || (note: semantics differ for falsy values like 0, '', and false)",
-            suggestVarReturn:
-                'Assign the object to a variable, then return the variable',
+            suggestVarReturn: 'Assign the object to a variable, then return the variable',
         },
         schema: [
             {
@@ -65,8 +64,12 @@ export default {
         for (const [nodeType, entries] of unsupportedByNodeType) {
             listeners[nodeType] = function (node) {
                 for (const entry of entries) {
-                    if (allowed.has(entry.feature)) continue;
-                    if (entry.test && !entry.test(node)) continue;
+                    if (allowed.has(entry.feature)) {
+                        continue;
+                    }
+                    if (entry.test && !entry.test(node)) {
+                        continue;
+                    }
 
                     const report = {
                         node,
@@ -90,7 +93,9 @@ export default {
                                         node.right.range[0],
                                     );
                                     const offset = between.indexOf('??');
-                                    if (offset === -1) return null;
+                                    if (offset === -1) {
+                                        return null;
+                                    }
                                     const start = node.left.range[1] + offset;
                                     return fixer.replaceTextRange([start, start + 2], '||');
                                 },

package/src/rules/ssjs/platform-function-arity.js

@@ -26,7 +26,9 @@ export default {
         return {
             CallExpression(node) {
                 const callee = node.callee;
-                if (callee.type !== 'MemberExpression') return;
+                if (callee.type !== 'MemberExpression') {
+                    return;
+                }
 
                 if (
                     callee.object.type === 'MemberExpression' &&
@@ -38,7 +40,9 @@ export default {
                 ) {
                     const methodName = callee.property.name;
                     const entry = platformFunctionLookup.get(methodName.toLowerCase());
-                    if (!entry) return;
+                    if (!entry) {
+                        return;
+                    }
 
                     const actual = node.arguments.length;
 

package/src/rules/ssjs/prefer-parsejson-safe-arg.js

@@ -14,11 +14,11 @@ export default {
         fixable: 'code',
         docs: {
             description:
-                "Require concatenating an empty string to Platform.Function.ParseJSON() arguments to prevent 500 errors",
+                'Require concatenating an empty string to Platform.Function.ParseJSON() arguments to prevent 500 errors',
         },
         messages: {
             unsafeArg:
-                "Platform.Function.ParseJSON() may throw a 500 if the argument is undefined. " +
+                'Platform.Function.ParseJSON() may throw a 500 if the argument is undefined. ' +
                 "Concatenate an empty string to be safe: ParseJSON({{argText}} + '').",
         },
         schema: [],
@@ -27,12 +27,18 @@ export default {
     create(context) {
         return {
             CallExpression(node) {
-                if (!isParseJSONCall(node)) return;
-                if (node.arguments.length === 0) return;
+                if (!isParseJSONCall(node)) {
+                    return;
+                }
+                if (node.arguments.length === 0) {
+                    return;
+                }
 
                 const arg = node.arguments[0];
 
-                if (isAlreadySafe(arg)) return;
+                if (isAlreadySafe(arg)) {
+                    return;
+                }
 
                 context.report({
                     node: arg,
@@ -75,10 +81,12 @@ function isParseJSONCall(node) {
 
 function isAlreadySafe(arg) {
     // arg + ''  or  '' + arg
-    if (arg.type === 'BinaryExpression' && arg.operator === '+') {
-        if (isEmptyString(arg.left) || isEmptyString(arg.right)) {
-            return true;
-        }
+    if (
+        arg.type === 'BinaryExpression' &&
+        arg.operator === '+' &&
+        (isEmptyString(arg.left) || isEmptyString(arg.right))
+    ) {
+        return true;
     }
 
     // String literal passed directly — already a string

package/src/rules/ssjs/prefer-platform-load-version.js

@@ -66,10 +66,7 @@ export default {
                         messageId: 'outdatedVersion',
                         data: { actual: '(none)', expected: expectedVersion },
                         fix(fixer) {
-                            return fixer.insertTextAfter(
-                                arguments_[0],
-                                `, "${expectedVersion}"`,
-                            );
+                            return fixer.insertTextAfter(arguments_[0], `, "${expectedVersion}"`);
                         },
                     });
                     return;