eslint-plugin-secure-coding 5.3.4 → 5.4.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "eslint-plugin-secure-coding",
3
- "version": "5.3.4",
3
+ "version": "5.4.0",
4
4
  "description": "ESLint plugin for secure coding — detects LDAP, XPath, XXE, GraphQL and template injection, unsafe deserialization, ReDoS, missing authentication, and PII in logs.",
5
5
  "type": "commonjs",
6
6
  "main": "./src/index.js",
package/src/index.js CHANGED
@@ -1 +1 @@
1
- "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.configs=exports.plugin=exports.rules=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");exports.rules={get"no-graphql-injection"(){return require("./rules/no-graphql-injection").noGraphqlInjection},get"no-xxe-injection"(){return require("./rules/no-xxe-injection").noXxeInjection},get"no-xpath-injection"(){return require("./rules/no-xpath-injection").noXpathInjection},get"no-ldap-injection"(){return require("./rules/no-ldap-injection").noLdapInjection},get"no-directive-injection"(){return require("./rules/no-directive-injection").noDirectiveInjection},get"no-format-string-injection"(){return require("./rules/no-format-string-injection").noFormatStringInjection},get"no-template-injection"(){return require("./rules/no-template-injection").noTemplateInjection},get"no-sql-injection"(){return require("./rules/no-sql-injection").noSqlInjection},get"no-log-injection"(){return require("./rules/no-log-injection").noLogInjection},get"no-fail-open-auth"(){return require("./rules/no-fail-open-auth").noFailOpenAuth},get"no-homoglyph-identifiers"(){return require("./rules/no-homoglyph-identifiers").noHomoglyphIdentifiers},get"detect-non-literal-regexp"(){return require("./rules/detect-non-literal-regexp").detectNonLiteralRegexp},get"no-redos-vulnerable-regex"(){return require("./rules/no-redos-vulnerable-regex").noRedosVulnerableRegex},get"no-unsafe-regex-construction"(){return require("./rules/no-unsafe-regex-construction").noUnsafeRegexConstruction},get"detect-object-injection"(){return require("./rules/detect-object-injection").detectObjectInjection},get"no-unsafe-deserialization"(){return require("./rules/no-unsafe-deserialization").noUnsafeDeserialization},get"no-insecure-comparison"(){return require("./rules/no-insecure-comparison").noInsecureComparison},get"no-improper-sanitization"(){return require("./rules/no-improper-sanitization").noImproperSanitization},get"no-improper-type-validation"(){return require("./rules/no-improper-type-validation").noImproperTypeValidation},get"no-missing-authentication"(){return require("./rules/no-missing-authentication").noMissingAuthentication},get"no-privilege-escalation"(){return require("./rules/no-privilege-escalation").noPrivilegeEscalation},get"no-weak-password-recovery"(){return require("./rules/no-weak-password-recovery").noWeakPasswordRecovery},get"require-backend-authorization"(){return require("./rules/require-backend-authorization").requireBackendAuthorization},get"no-hardcoded-credentials"(){return require("./rules/no-hardcoded-credentials").noHardcodedCredentials},get"no-sensitive-data-exposure"(){return require("./rules/no-sensitive-data-exposure").noSensitiveDataExposure},get"no-pii-in-logs"(){return require("./rules/no-pii-in-logs").noPiiInLogs},get"no-unlimited-resource-allocation"(){return require("./rules/no-unlimited-resource-allocation").noUnlimitedResourceAllocation},get"no-unchecked-loop-condition"(){return require("./rules/no-unchecked-loop-condition").noUncheckedLoopCondition},get"detect-weak-password-validation"(){return require("./rules/detect-weak-password-validation").detectWeakPasswordValidation},get"no-electron-security-issues"(){return require("./rules/no-electron-security-issues").noElectronSecurityIssues},get"no-hardcoded-session-tokens"(){return require("./rules/no-hardcoded-session-tokens").noHardcodedSessionTokens},get"require-secure-defaults"(){return require("./rules/require-secure-defaults").requireSecureDefaults},get"no-bidi-characters"(){return require("./rules/no-bidi-characters").noBidiCharacters}};(0,eslint_devkit_1.withCanonicalDocsUrls)("plugin-secure-coding",exports.rules);exports.plugin={meta:{name:"eslint-plugin-secure-coding",version:"5.3.4"},rules:exports.rules};const recommendedRules={"secure-coding/no-graphql-injection":"warn","secure-coding/no-xxe-injection":"error","secure-coding/no-xpath-injection":"error","secure-coding/no-ldap-injection":"error","secure-coding/no-sql-injection":"error","secure-coding/no-log-injection":"error","secure-coding/no-fail-open-auth":"error","secure-coding/no-homoglyph-identifiers":"error","secure-coding/no-unsafe-deserialization":"warn","secure-coding/no-redos-vulnerable-regex":"error","secure-coding/no-unsafe-regex-construction":"error","secure-coding/no-hardcoded-credentials":"error","secure-coding/no-template-injection":"error","secure-coding/no-improper-sanitization":"error","secure-coding/no-privilege-escalation":"warn","secure-coding/no-weak-password-recovery":"warn","secure-coding/no-sensitive-data-exposure":"warn","secure-coding/no-unlimited-resource-allocation":"warn"};exports.configs={flagship:{plugins:{"secure-coding":exports.plugin},rules:{"secure-coding/no-hardcoded-credentials":"error","secure-coding/no-redos-vulnerable-regex":"error"}},recommended:{plugins:{"secure-coding":exports.plugin},rules:recommendedRules},"recommended-strict":{plugins:{"secure-coding":exports.plugin},rules:Object.fromEntries(Object.keys(recommendedRules).map(rule=>[rule,"error"]))},strict:{plugins:{"secure-coding":exports.plugin},rules:Object.fromEntries(Object.keys(exports.rules).map(ruleName=>[`secure-coding/${ruleName}`,"error"]))},"owasp-top-10":{plugins:{"secure-coding":exports.plugin},rules:{"secure-coding/no-privilege-escalation":"warn","secure-coding/no-hardcoded-credentials":"error","secure-coding/no-sensitive-data-exposure":"warn","secure-coding/no-graphql-injection":"error","secure-coding/no-xxe-injection":"error","secure-coding/no-xpath-injection":"error","secure-coding/no-ldap-injection":"error","secure-coding/no-weak-password-recovery":"error","secure-coding/no-unsafe-deserialization":"error"}}};exports.default=exports.plugin;
1
+ "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.configs=exports.plugin=exports.rules=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");exports.rules={get"no-graphql-injection"(){return require("./rules/no-graphql-injection").noGraphqlInjection},get"no-xxe-injection"(){return require("./rules/no-xxe-injection").noXxeInjection},get"no-xpath-injection"(){return require("./rules/no-xpath-injection").noXpathInjection},get"no-ldap-injection"(){return require("./rules/no-ldap-injection").noLdapInjection},get"no-directive-injection"(){return require("./rules/no-directive-injection").noDirectiveInjection},get"no-format-string-injection"(){return require("./rules/no-format-string-injection").noFormatStringInjection},get"no-template-injection"(){return require("./rules/no-template-injection").noTemplateInjection},get"no-sql-injection"(){return require("./rules/no-sql-injection").noSqlInjection},get"no-log-injection"(){return require("./rules/no-log-injection").noLogInjection},get"no-fail-open-auth"(){return require("./rules/no-fail-open-auth").noFailOpenAuth},get"no-homoglyph-identifiers"(){return require("./rules/no-homoglyph-identifiers").noHomoglyphIdentifiers},get"detect-non-literal-regexp"(){return require("./rules/detect-non-literal-regexp").detectNonLiteralRegexp},get"no-redos-vulnerable-regex"(){return require("./rules/no-redos-vulnerable-regex").noRedosVulnerableRegex},get"no-unsafe-regex-construction"(){return require("./rules/no-unsafe-regex-construction").noUnsafeRegexConstruction},get"detect-object-injection"(){return require("./rules/detect-object-injection").detectObjectInjection},get"no-unsafe-deserialization"(){return require("./rules/no-unsafe-deserialization").noUnsafeDeserialization},get"no-insecure-comparison"(){return require("./rules/no-insecure-comparison").noInsecureComparison},get"no-improper-sanitization"(){return require("./rules/no-improper-sanitization").noImproperSanitization},get"no-improper-type-validation"(){return require("./rules/no-improper-type-validation").noImproperTypeValidation},get"no-missing-authentication"(){return require("./rules/no-missing-authentication").noMissingAuthentication},get"no-privilege-escalation"(){return require("./rules/no-privilege-escalation").noPrivilegeEscalation},get"no-weak-password-recovery"(){return require("./rules/no-weak-password-recovery").noWeakPasswordRecovery},get"require-backend-authorization"(){return require("./rules/require-backend-authorization").requireBackendAuthorization},get"no-hardcoded-credentials"(){return require("./rules/no-hardcoded-credentials").noHardcodedCredentials},get"no-sensitive-data-exposure"(){return require("./rules/no-sensitive-data-exposure").noSensitiveDataExposure},get"no-pii-in-logs"(){return require("./rules/no-pii-in-logs").noPiiInLogs},get"no-unlimited-resource-allocation"(){return require("./rules/no-unlimited-resource-allocation").noUnlimitedResourceAllocation},get"no-unchecked-loop-condition"(){return require("./rules/no-unchecked-loop-condition").noUncheckedLoopCondition},get"detect-weak-password-validation"(){return require("./rules/detect-weak-password-validation").detectWeakPasswordValidation},get"no-electron-security-issues"(){return require("./rules/no-electron-security-issues").noElectronSecurityIssues},get"no-hardcoded-session-tokens"(){return require("./rules/no-hardcoded-session-tokens").noHardcodedSessionTokens},get"require-secure-defaults"(){return require("./rules/require-secure-defaults").requireSecureDefaults},get"no-bidi-characters"(){return require("./rules/no-bidi-characters").noBidiCharacters}};(0,eslint_devkit_1.withCanonicalDocsUrls)("plugin-secure-coding",exports.rules);exports.plugin={meta:{name:"eslint-plugin-secure-coding",version:"5.4.0"},rules:exports.rules};const recommendedRules={"secure-coding/no-graphql-injection":"warn","secure-coding/no-xxe-injection":"error","secure-coding/no-xpath-injection":"error","secure-coding/no-ldap-injection":"error","secure-coding/no-sql-injection":"error","secure-coding/no-log-injection":"error","secure-coding/no-fail-open-auth":"error","secure-coding/no-homoglyph-identifiers":"error","secure-coding/no-unsafe-deserialization":"warn","secure-coding/no-redos-vulnerable-regex":"error","secure-coding/no-unsafe-regex-construction":"error","secure-coding/no-hardcoded-credentials":"error","secure-coding/no-template-injection":"error","secure-coding/no-improper-sanitization":"error","secure-coding/no-privilege-escalation":"warn","secure-coding/no-weak-password-recovery":"warn","secure-coding/no-sensitive-data-exposure":"warn","secure-coding/no-unlimited-resource-allocation":"warn"};exports.configs={flagship:{plugins:{"secure-coding":exports.plugin},rules:{"secure-coding/no-hardcoded-credentials":"error","secure-coding/no-redos-vulnerable-regex":"error"}},recommended:{plugins:{"secure-coding":exports.plugin},rules:recommendedRules},"recommended-strict":{plugins:{"secure-coding":exports.plugin},rules:Object.fromEntries(Object.keys(recommendedRules).map(rule=>[rule,"error"]))},strict:{plugins:{"secure-coding":exports.plugin},rules:Object.fromEntries(Object.keys(exports.rules).map(ruleName=>[`secure-coding/${ruleName}`,"error"]))},"owasp-top-10":{plugins:{"secure-coding":exports.plugin},rules:{"secure-coding/no-privilege-escalation":"warn","secure-coding/no-hardcoded-credentials":"error","secure-coding/no-sensitive-data-exposure":"warn","secure-coding/no-graphql-injection":"error","secure-coding/no-xxe-injection":"error","secure-coding/no-xpath-injection":"error","secure-coding/no-ldap-injection":"error","secure-coding/no-weak-password-recovery":"error","secure-coding/no-unsafe-deserialization":"error"}}};exports.default=exports.plugin;
@@ -1 +1 @@
1
- "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.detectObjectInjection=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const eslint_devkit_3=require("@interlace/eslint-devkit");const resolve_reference_1=require("../../utils/resolve-reference");const fileUsesAstTooling=(0,eslint_devkit_3.createModuleEvidence)({packages:["@babel/types","@babel/traverse","recast","jscodeshift","eslint","estree-walker","ast-types","esrap","unist-util-visit"],scopes:["@typescript-eslint"]});const TYPED_ARRAY_CTORS=new Set(["Int8Array","Uint8Array","Uint8ClampedArray","Int16Array","Uint16Array","Int32Array","Uint32Array","Float32Array","Float64Array","BigInt64Array","BigUint64Array"]);const OBJECT_INJECTION_PATTERNS=[{pattern:"__proto__",dangerous:true,vulnerability:"prototype-pollution",safeAlternative:"Object.create(null) or Map",riskLevel:"critical"},{pattern:"prototype",dangerous:true,vulnerability:"prototype-pollution",safeAlternative:"Avoid prototype manipulation",riskLevel:"high"},{pattern:"constructor",dangerous:true,vulnerability:"method-injection",safeAlternative:"Validate property names against whitelist",riskLevel:"medium"}];exports.detectObjectInjection=(0,eslint_devkit_3.createRule)({name:"detect-object-injection",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-secure-coding/docs/rules/detect-object-injection.md",description:"Detects variable[key] as a left- or right-hand assignment operand",cwe:"CWE-915",confidence:"low"},messages:{objectInjection:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.WARNING,issueName:"Object injection",cwe:"CWE-915",description:"Object injection/Prototype pollution (incl. model/tool outputs)",severity:"{{riskLevel}}",fix:"{{safeAlternative}} \u2014 Not a finding when the key is a numeric index, a module constant, or guarded by Object.hasOwn / an allowlist",documentationLink:"https://portswigger.net/web-security/prototype-pollution"}),massAssignment:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Mass assignment",cwe:"CWE-915",description:"Every key of an untrusted object is copied onto this target, so the caller chooses which field is written \u2014 including one they should not control, such as isAdmin",severity:"HIGH",fix:"Copy an explicit allowlist of assignable fields instead of the caller's keys \u2014 Not a finding when the iterated object is module-built, or the body checks each key against an allowlist",documentationLink:"https://cwe.mitre.org/data/definitions/915.html"}),globalPrototypeWrite:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Global prototype pollution",cwe:"CWE-1321",description:"Assignment writes THROUGH {{step}}, so the property lands on Object.prototype and every object in the process inherits it",severity:"CRITICAL",fix:"Guard with Object.hasOwn, or build the target with Object.create(null) / a Map \u2014 Not a finding when the path is fixed at build time, or __proto__ / constructor / prototype are rejected first",documentationLink:"https://portswigger.net/web-security/prototype-pollution"})},schema:[{type:"object",properties:{allowLiterals:{type:"boolean",default:false,description:"Allow bracket notation with literal strings"},dangerousProperties:{type:"array",items:{type:"string"},default:["__proto__","prototype","constructor"],description:"Property NAMES treated as dangerous where the name is visible in the source \u2014 `obj['__proto__'] = v`. It cannot apply to a dynamic key (`obj[k] = v`), because there is no name to compare, and it does not gate the CWE-1321 traversal check, which is a fact about the language rather than a vocabulary. Set it to [] to stop reporting literal dangerous-property writes."}},additionalProperties:false}]},skipTestFiles:true,defaultOptions:[{allowLiterals:false,dangerousProperties:["__proto__","prototype","constructor"]}],create(context){const options=context.options[0]||{};const{allowLiterals:_allowLiterals=false,dangerousProperties=["__proto__","prototype","constructor"]}=options;const handledMemberExpressions=new WeakSet;const openCopyLoops=[];const armedLoops=new WeakSet;const sourceCode=context.sourceCode;const isInCodemodContext=(()=>{const filename=context.filename;if(/\/codemod[s]?\//i.test(filename))return true;if(/codemod\.[mc]?[jt]sx?$/i.test(filename))return true;return fileUsesAstTooling(sourceCode.ast)})();const isLiteralString=node=>{return(0,eslint_devkit_1.staticString)(node)!==null};const hasPrecedingValidation=(propertyNode,node)=>{if(propertyNode.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier){return false}const keyName=propertyNode.name;const isIncludesCall=testNode=>{return testNode.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression&&testNode.callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&(0,eslint_devkit_1.propertyName)(testNode.callee)==="includes"&&testNode.arguments.length>0&&testNode.arguments[0].type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&testNode.arguments[0].name===keyName};const isHasOwnPropertyCall=testNode=>{if(testNode.type!==eslint_devkit_1.AST_NODE_TYPES.CallExpression)return false;const callee=testNode.callee;const args=testNode.arguments;if(callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&(0,eslint_devkit_1.propertyName)(callee)==="call"&&args.length>=2&&args[1].type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&args[1].name===keyName){return true}if(callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&((0,eslint_devkit_1.propertyName)(callee)==="hasOwnProperty"||(0,eslint_devkit_1.propertyName)(callee)==="hasOwn")){const keyArg=(0,eslint_devkit_1.propertyName)(callee)==="hasOwn"?args[1]:args[0];if(keyArg?.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&keyArg.name===keyName){return true}}return false};const isInOperator=testNode=>{return testNode.type===eslint_devkit_1.AST_NODE_TYPES.BinaryExpression&&testNode.operator==="in"&&testNode.left.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&testNode.left.name===keyName};const hasValidation=testNode=>{if(testNode.type===eslint_devkit_1.AST_NODE_TYPES.UnaryExpression&&testNode.operator==="!"){return hasValidation(testNode.argument)}return isIncludesCall(testNode)||isHasOwnPropertyCall(testNode)||isInOperator(testNode)};const hasEarlyExit=consequent=>{if(consequent.type===eslint_devkit_1.AST_NODE_TYPES.BlockStatement){return consequent.body.some(stmt=>stmt.type===eslint_devkit_1.AST_NODE_TYPES.ThrowStatement||stmt.type===eslint_devkit_1.AST_NODE_TYPES.ReturnStatement)}return consequent.type===eslint_devkit_1.AST_NODE_TYPES.ThrowStatement||consequent.type===eslint_devkit_1.AST_NODE_TYPES.ReturnStatement};let current=node.parent;let foundFunctionBody=false;while(current&&!foundFunctionBody){if(current.type===eslint_devkit_1.AST_NODE_TYPES.IfStatement){if(hasValidation(current.test)){return true}}if(current.type===eslint_devkit_1.AST_NODE_TYPES.BlockStatement&&current.parent&&(current.parent.type===eslint_devkit_1.AST_NODE_TYPES.FunctionDeclaration||current.parent.type===eslint_devkit_1.AST_NODE_TYPES.FunctionExpression||current.parent.type===eslint_devkit_1.AST_NODE_TYPES.ArrowFunctionExpression)){foundFunctionBody=true;const blockBody=current.body;const nodeIndex=blockBody.findIndex(stmt=>{let check=node;while(check){if(check===stmt)return true;check=check.parent}return false});for(let i=0;i<nodeIndex;i++){const stmt=blockBody[i];if(stmt.type===eslint_devkit_1.AST_NODE_TYPES.IfStatement&&hasValidation(stmt.test)&&hasEarlyExit(stmt.consequent)){return true}}}current=current.parent}return false};const hasDisqualifyingLiteralAffix=node=>{if(node.type!==eslint_devkit_1.AST_NODE_TYPES.BinaryExpression||node.operator!=="+"){return false}const bin=node;const literalText=n=>{if(n.type!==eslint_devkit_1.AST_NODE_TYPES.Literal)return null;const v=n.value;if(typeof v!=="string"&&typeof v!=="number")return null;const s=String(v);return s.length>0?s:null};const prefix=literalText(bin.left);if(prefix!==null&&!dangerousProperties.some(d=>d.startsWith(prefix))){return true}const suffix=literalText(bin.right);if(suffix!==null&&!dangerousProperties.some(d=>d.endsWith(suffix))){return true}return false};const NUMERIC_RENDERING_CHARS=/[0-9NI]/;const hasNumericOperandInConcatenation=node=>{if(node.type!==eslint_devkit_1.AST_NODE_TYPES.BinaryExpression||node.operator!=="+"||dangerousProperties.some(name=>NUMERIC_RENDERING_CHARS.test(name))){return false}const anyNumericOperand=operand=>{if(operand.type===eslint_devkit_1.AST_NODE_TYPES.BinaryExpression&&operand.operator==="+"){const chain=operand;return anyNumericOperand(chain.left)||anyNumericOperand(chain.right)}return isNumericKey(operand)};const bin=node;return anyNumericOperand(bin.left)||anyNumericOperand(bin.right)};const hasVisibleNonConstantInitialiser=node=>{const scope=sourceCode.getScope(node);const variable=(0,resolve_reference_1.resolvedReference)(scope,node);if(!variable||variable.defs.length!==1){return false}const def=variable.defs[0];if(def.type!=="Variable"){return false}const init=def.node.init;if(!init){return false}return!(0,eslint_devkit_2.isStaticExpression)({node:init,scope:sourceCode.getScope(init)})};const chainRoot=node=>{let cur=node;while(cur.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression)cur=cur.object;return cur.type===eslint_devkit_1.AST_NODE_TYPES.Identifier?cur:null};const isLocallyConstructed=id=>{const variable=(0,resolve_reference_1.resolvedReference)(sourceCode.getScope(id),id);if(!variable||variable.defs.length!==1)return false;const def=variable.defs[0];if(def.type!=="Variable")return false;if(variable.references.filter(ref=>ref.isWrite()).length>1)return false;const init=def.node.init;if(!init)return false;return init.type===eslint_devkit_1.AST_NODE_TYPES.ObjectExpression||init.type===eslint_devkit_1.AST_NODE_TYPES.ArrayExpression||(0,eslint_devkit_2.isStaticExpression)({node:init,scope:sourceCode.getScope(init)})};const REQUEST_ROOTS=new Set(["req","request","ctx","context","event"]);const isUntrustedExpression=node=>{const root=chainRoot(node);if(root===null)return false;if(!REQUEST_ROOTS.has(root.name))return false;return!isLocallyConstructed(root)};const isSymbolKey=node=>{if(node.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&node.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&node.object.name==="Symbol"){return true}if(node.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier)return false;const variable=(0,resolve_reference_1.resolvedReference)(sourceCode.getScope(node),node);if(!variable||variable.defs.length!==1)return false;const def=variable.defs[0];if(def.type!=="Variable")return false;if(variable.references.filter(ref=>ref.isWrite()).length>1)return false;const init=def.node.init;if(init?.type!==eslint_devkit_1.AST_NODE_TYPES.CallExpression)return false;const callee=init.callee;return callee.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&callee.name==="Symbol"||callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&callee.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&callee.object.name==="Symbol"};const isImportedBinding=node=>{const root=chainRoot(node);if(root===null)return false;const variable=(0,resolve_reference_1.resolvedReference)(sourceCode.getScope(root),root);if(!variable||variable.defs.length!==1)return false;const def=variable.defs[0];if(def.type==="ImportBinding"){return true}if(def.type!=="Variable")return false;if(variable.references.filter(ref=>ref.isWrite()).length>1)return false;const init=def.node.init;return init?.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression&&init.callee.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&init.callee.name==="require"};const isDangerousPropertyAccess=propertyNode=>{if(isSymbolKey(propertyNode))return false;if(isImportedBinding(propertyNode))return false;{const root=chainRoot(propertyNode);if(root!==null&&isLocallyConstructed(root))return false}if(isNumericKey(propertyNode)||hasDisqualifyingLiteralAffix(propertyNode)||hasNumericOperandInConcatenation(propertyNode)){return false}if(propertyNode.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&!hasVisibleNonConstantInitialiser(propertyNode)){const name=propertyNode.name;if(/^[A-Z][A-Z0-9_]{2,}$/.test(name)){return false}if(/^[a-z]/.test(name)&&/(?:Code|Status|Version|Kind|Mode|Type|Stage|Level|Phase|Step|Flag|Num|Count)$/.test(name)){return false}}if(isLiteralString(propertyNode)){const propName=String(propertyNode.value);if(dangerousProperties.includes(propName)){return true}return false}return true};const isPrototypelessObject=objectNode=>{if(objectNode.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier){return false}const varName=objectNode.name;let current=objectNode;while(current){if(current.type===eslint_devkit_1.AST_NODE_TYPES.BlockStatement||current.type===eslint_devkit_1.AST_NODE_TYPES.Program){const statements=current.type===eslint_devkit_1.AST_NODE_TYPES.BlockStatement?current.body:current.body;for(const stmt of statements){if(stmt.type===eslint_devkit_1.AST_NODE_TYPES.VariableDeclaration){for(const decl of stmt.declarations){if(decl.id.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&decl.id.name===varName&&decl.init){if(decl.init.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression&&decl.init.callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&decl.init.callee.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&decl.init.callee.object.name==="Object"&&decl.init.callee.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&decl.init.callee.property.name==="create"&&decl.init.arguments.length>0&&decl.init.arguments[0].type===eslint_devkit_1.AST_NODE_TYPES.Literal&&decl.init.arguments[0].value===null){return true}if(decl.init.type===eslint_devkit_1.AST_NODE_TYPES.ArrayExpression&&decl.init.elements.length>0&&decl.init.elements[0]?.type===eslint_devkit_1.AST_NODE_TYPES.SpreadElement){return true}}}}}}current=current.parent}return false};const extractPropertyAccess=node=>{let object;let property;let propertyNode;let isAssignment=false;if(node.type===eslint_devkit_1.AST_NODE_TYPES.AssignmentExpression&&node.left.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression){object=sourceCode.getText(node.left.object);property=sourceCode.getText(node.left.property);propertyNode=node.left.property;isAssignment=true}else{const memberNode=node;object=sourceCode.getText(memberNode.object);property=sourceCode.getText(memberNode.property);propertyNode=memberNode.property;isAssignment=false}const pattern=OBJECT_INJECTION_PATTERNS.find(p=>new RegExp(p.pattern,"i").test(property)||dangerousProperties.includes(property.replace(/['"]/g,"")))||null;return{object,property,propertyNode,isAssignment,pattern}};const stepName=m=>{if(!m.computed&&m.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier)return m.property.name;if(m.computed&&m.property.type===eslint_devkit_1.AST_NODE_TYPES.Literal&&typeof m.property.value==="string"){return m.property.value}return null};const globalPrototypeWrite=node=>{if(node.left.type!==eslint_devkit_1.AST_NODE_TYPES.MemberExpression)return null;const steps=[];let cur=node.left.object;while(cur.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression){const name=stepName(cur);if(name===null)return null;steps.unshift(name);cur=cur.object}if(steps.includes("__proto__"))return"__proto__";for(let i=0;i<steps.length-1;i++){if(steps[i]==="constructor"&&steps[i+1]==="prototype")return"constructor.prototype"}return null};const isHighRiskAssignment=node=>{if(node.left.type!=="MemberExpression"){return false}if(!node.left.computed){return false}if(isPrototypelessObject(node.left.object)){return false}if(isTypedArrayObject(node.left.object)){return false}if(isArrayAppend(node.left)){return false}const{propertyNode}=extractPropertyAccess(node);if(isNumericKey(propertyNode)){return false}if(isKeyFromLiteralAllowlist(propertyNode)){return false}if(isForInOrObjectKeysKey(propertyNode)){return false}if(hasPrecedingValidation(propertyNode,node)){return false}return isDangerousPropertyAccess(propertyNode)};const isReflectResultAccess=objectNode=>{if(objectNode.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression){const callee=objectNode.callee;if(callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&callee.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&callee.object.name==="Reflect"){return true}}if(objectNode.type===eslint_devkit_1.AST_NODE_TYPES.ChainExpression){return isReflectResultAccess(objectNode.expression)}return false};const isHighRiskMemberAccess=node=>{if(!node.computed){return false}if(isReflectResultAccess(node.object)){return false}if(isTypedArrayObject(node.object)){return false}const{propertyNode}=extractPropertyAccess(node);if(isNumericKey(propertyNode)){return false}if(isForInOrObjectKeysKey(propertyNode)){return false}if(hasPrecedingValidation(propertyNode,node)){return false}return isDangerousPropertyAccess(propertyNode)};const isArrayAppend=member=>{if(member.object.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier)return false;const key=member.property;return key.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&key.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&key.object.name===member.object.name&&(0,eslint_devkit_1.propertyName)(key)==="length"};const isKeyFromLiteralAllowlist=node=>{if(node.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier)return false;const variable=(0,resolve_reference_1.resolvedReference)(sourceCode.getScope(node),node);if(!variable||variable.defs.length!==1)return false;const def=variable.defs[0];if(def.type!=="Variable")return false;const declaration=def.node.parent;const loop=declaration?.parent;if(loop?.type!==eslint_devkit_1.AST_NODE_TYPES.ForOfStatement||loop.left!==declaration)return false;let source=loop.right;if(source.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression&&source.callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&source.callee.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&source.callee.object.name==="Object"&&(0,eslint_devkit_1.propertyName)(source.callee)==="freeze"&&source.arguments[0]!==void 0){source=source.arguments[0]}if(source.type===eslint_devkit_1.AST_NODE_TYPES.Identifier){const listVar=(0,resolve_reference_1.resolvedReference)(sourceCode.getScope(source),source);if(!listVar||listVar.defs.length!==1)return false;const listDef=listVar.defs[0];if(listDef.type!=="Variable")return false;if(listDef.parent?.kind!=="const")return false;source=listDef.node.init}if(source.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression&&source.callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&source.callee.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&source.callee.object.name==="Object"&&(0,eslint_devkit_1.propertyName)(source.callee)==="freeze"&&source.arguments[0]!==void 0){source=source.arguments[0]}if(source.type!==eslint_devkit_1.AST_NODE_TYPES.ArrayExpression)return false;if(source.elements.length===0)return false;return source.elements.every(element=>{const text=element===null?null:(0,eslint_devkit_1.staticString)(element);return text!==null&&!dangerousProperties.includes(text)})};const isNumericKey=node=>{if(node.type===eslint_devkit_1.AST_NODE_TYPES.Literal&&typeof node.value==="number"){return true}if(node.type===eslint_devkit_1.AST_NODE_TYPES.UnaryExpression){const op=node.operator;if(op==="+"||op==="-"||op==="~")return true}if(node.type===eslint_devkit_1.AST_NODE_TYPES.UpdateExpression){return true}if(node.type===eslint_devkit_1.AST_NODE_TYPES.BinaryExpression){const op=node.operator;if(op==="|"||op==="&"||op==="^"||op==="<<"||op===">>"||op===">>>"||op==="*"||op==="/"||op==="%"||op==="-"||op==="**"){return true}if(op==="+"){const bin=node;return isNumericKey(bin.left)&&isNumericKey(bin.right)}}if(node.type===eslint_devkit_1.AST_NODE_TYPES.ConditionalExpression){const cond=node;return isNumericKey(cond.consequent)&&isNumericKey(cond.alternate)}if(node.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression){const callee=node.callee;if(callee.type===eslint_devkit_1.AST_NODE_TYPES.Identifier){const name=callee.name;if(name==="Number"||name==="parseInt"||name==="parseFloat")return true}if(callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&callee.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&callee.object.name==="Math"&&callee.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier){return true}}if(node.type===eslint_devkit_1.AST_NODE_TYPES.Identifier){return isNumericIdentifier(node)}return false};const numericVarCache=new WeakMap;const numericVarInProgress=new WeakSet;const isNumericIdentifier=node=>{if(isLoopCounterIdentifier(node))return true;const scope=context.sourceCode.getScope(node);const variable=(0,resolve_reference_1.resolvedReference)(scope,node);if(!variable||variable.defs.length===0)return false;const cached=numericVarCache.get(variable);if(cached!==void 0)return cached;if(numericVarInProgress.has(variable))return true;numericVarInProgress.add(variable);let result=false;const def=variable.defs[0];const declarator=def.node;if(declarator?.type===eslint_devkit_1.AST_NODE_TYPES.VariableDeclarator&&declarator.init&&declarator.parent?.type===eslint_devkit_1.AST_NODE_TYPES.VariableDeclaration){result=isNumericKey(declarator.init);if(result){for(const ref of variable.references){const written=ref.writeExpr;if(!written||written===declarator.init)continue;if(!isNumericKey(written)){result=false;break}}}}numericVarInProgress.delete(variable);numericVarCache.set(variable,result);return result};const isLoopCounterIdentifier=node=>{const scope=context.sourceCode.getScope(node);const variable=(0,resolve_reference_1.resolvedReference)(scope,node);if(!variable||variable.defs.length===0)return false;const def=variable.defs[0];const parent=def.node?.parent;const grand=parent?.parent;if(parent?.type===eslint_devkit_1.AST_NODE_TYPES.VariableDeclaration&&grand?.type===eslint_devkit_1.AST_NODE_TYPES.ForStatement&&grand.init===parent){const init=def.node.init;if(!init)return false;if(init.type===eslint_devkit_1.AST_NODE_TYPES.Literal&&typeof init.value==="number"){return true}}return false};const ELEMENT_FIRST_ITERATORS=new Set(["forEach","map","filter","find","findLast","some","every","flatMap"]);const isObjectKeysCallbackKey=(fn,name)=>{if(fn.type!==eslint_devkit_1.AST_NODE_TYPES.ArrowFunctionExpression&&fn.type!==eslint_devkit_1.AST_NODE_TYPES.FunctionExpression){return false}const first=fn.params[0];const bindsName=first?.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&first.name===name||first?.type===eslint_devkit_1.AST_NODE_TYPES.ArrayPattern&&first.elements[0]?.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&first.elements[0].name===name;if(!bindsName)return false;const call=fn.parent;if(call?.type!==eslint_devkit_1.AST_NODE_TYPES.CallExpression||call.arguments[0]!==fn||call.callee.type!==eslint_devkit_1.AST_NODE_TYPES.MemberExpression||call.callee.computed||call.callee.property.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier||!ELEMENT_FIRST_ITERATORS.has(call.callee.property.name)){return false}const source=call.callee.object;return source.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression&&source.callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&source.callee.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&source.callee.object.name==="Object"&&((0,eslint_devkit_1.propertyName)(source.callee)==="keys"||(0,eslint_devkit_1.propertyName)(source.callee)==="entries")};const isForInOrObjectKeysKey=node=>{if(node.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier)return false;const scope=context.sourceCode.getScope(node);const variable=(0,resolve_reference_1.resolvedReference)(scope,node);if(!variable||variable.defs.length===0)return false;const def=variable.defs[0];if(def.type==="Parameter"){return isObjectKeysCallbackKey(def.node,node.name)}const varDecl=def.node?.parent;const loopStmt=varDecl?.parent;if(!varDecl||varDecl.type!==eslint_devkit_1.AST_NODE_TYPES.VariableDeclaration)return false;if(loopStmt?.type===eslint_devkit_1.AST_NODE_TYPES.ForInStatement&&loopStmt.left===varDecl){return true}if(loopStmt?.type===eslint_devkit_1.AST_NODE_TYPES.ForOfStatement&&loopStmt.left===varDecl){const right=loopStmt.right;return right.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression&&right.callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&right.callee.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&right.callee.object.name==="Object"&&((0,eslint_devkit_1.propertyName)(right.callee)==="keys"||(0,eslint_devkit_1.propertyName)(right.callee)==="entries")}return false};const isTypedArrayObject=objectNode=>{if(objectNode.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier)return false;const varName=objectNode.name;let scope=context.sourceCode.getScope(objectNode);while(scope){const variable=scope.set.get(varName);if(variable){for(const def of variable.defs){const init=def.node.init;if(init?.type===eslint_devkit_1.AST_NODE_TYPES.NewExpression&&init.callee.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&TYPED_ARRAY_CTORS.has(init.callee.name)){return true}}break}if(!scope.upper)break;scope=scope.upper}return false};const determineRiskLevel=(pattern,isAssignment)=>{if(pattern?.riskLevel==="critical"||pattern&&isAssignment){return"CRITICAL"}if(pattern?.riskLevel==="high"||isAssignment){return"HIGH"}return"MEDIUM"};const checkAssignmentExpression=node=>{const step=globalPrototypeWrite(node);if(step!==null){for(let m=node.left;m.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression;m=m.object){handledMemberExpressions.add(m)}context.report({node,messageId:"globalPrototypeWrite",data:{step}});return}if(!isHighRiskAssignment(node)){return}if(node.left.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&node.left.computed&&keyComesFromConstAllowlist(node.left.property,node)){return}let me=node.left;handledMemberExpressions.add(me);while(me.object.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&me.object.computed){me=me.object;handledMemberExpressions.add(me)}const{object,property,isAssignment,pattern}=extractPropertyAccess(node);const riskLevel=determineRiskLevel(pattern,isAssignment);context.report({node,messageId:"objectInjection",data:{pattern:`${object}[${property}]`,riskLevel,vulnerability:pattern?.vulnerability||"object injection",safeAlternative:pattern?.safeAlternative||"Use Map or property whitelisting"}})};const constObjectLiteralOf=(name,from)=>{for(let scope=sourceCode.getScope(from);scope;scope=scope.upper){const variable=scope.set.get(name);if(!variable)continue;if(variable.defs.length!==1)return null;const def=variable.defs[0];if(def.type!=="Variable"||def.parent?.kind!=="const")return null;if(variable.references.some(ref=>ref.isWrite()&&ref.identifier!==def.name)){return null}const init=def.node.init;return init?.type===eslint_devkit_1.AST_NODE_TYPES.ObjectExpression?init:null}return null};const isReadFromConstObjectLiteral=node=>node.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&constObjectLiteralOf(node.object.name,node)!==null;const keyComesFromConstAllowlist=(property,from)=>{if(property.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier)return false;for(let scope=sourceCode.getScope(from);scope;scope=scope.upper){const variable=scope.set.get(property.name);if(!variable)continue;if(variable.defs.length!==1)return false;const def=variable.defs[0];if(def.type!=="Variable"||def.parent?.kind!=="const")return false;if(variable.references.some(ref=>ref.isWrite()&&ref.identifier!==def.name)){return false}const init=def.node.init;if(init?.type!==eslint_devkit_1.AST_NODE_TYPES.MemberExpression||!init.computed||init.object.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier){return false}const source=constObjectLiteralOf(init.object.name,init);if(!source)return false;return source.properties.every(p=>p.type===eslint_devkit_1.AST_NODE_TYPES.Property&&p.value.type===eslint_devkit_1.AST_NODE_TYPES.Literal&&typeof p.value.value==="string")}return false};const isInvokedRead=node=>{const parent=node.parent;if(parent===void 0)return false;if(parent.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression&&parent.callee===node){return true}if(parent.type!==eslint_devkit_1.AST_NODE_TYPES.VariableDeclarator||parent.init!==node||parent.id.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier){return false}const variable=context.sourceCode.getDeclaredVariables(parent).find(candidate=>candidate.name===parent.id.name);return variable?.references.some(reference=>{const referenceParent=reference.identifier.parent;return referenceParent?.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression&&referenceParent.callee===reference.identifier})??false};const isWriteTarget=node=>{let current=node;let parent=current.parent;while(parent!==void 0){if(parent.type===eslint_devkit_1.AST_NODE_TYPES.AssignmentExpression&&parent.left===current){return true}if(parent.type===eslint_devkit_1.AST_NODE_TYPES.UpdateExpression&&parent.argument===current){return true}if(parent.type===eslint_devkit_1.AST_NODE_TYPES.UnaryExpression&&parent.operator==="delete"){return true}if(parent.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&parent.object===current){current=parent;parent=current.parent;continue}return false}return false};const checkMemberExpression=node=>{if(!isWriteTarget(node)&&!isInvokedRead(node)){return}if(!isHighRiskMemberAccess(node)){return}if(isReadFromConstObjectLiteral(node)){return}if(handledMemberExpressions.has(node)){return}const parent=node.parent;if(parent?.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&parent.computed&&parent.object===node){return}if(parent&&parent.type===eslint_devkit_1.AST_NODE_TYPES.AssignmentExpression&&parent.left===node){return}const{object,property,isAssignment,pattern}=extractPropertyAccess(node);const riskLevel=determineRiskLevel(pattern,isAssignment);context.report({node,messageId:"objectInjection",data:{pattern:`${object}[${property}]`,riskLevel,vulnerability:pattern?.vulnerability||"object injection",safeAlternative:pattern?.safeAlternative||"Use Map or property whitelisting"}})};const checkObjectAssignSpread=node=>{if(node.callee.type!==eslint_devkit_1.AST_NODE_TYPES.MemberExpression)return;const callee=node.callee;const objectIsObject=callee.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&callee.object.name==="Object";const propIsAssign=(0,eslint_devkit_1.propertyName)(callee)==="assign";if(!objectIsObject||!propIsAssign)return;if(node.arguments[0]?.type===eslint_devkit_1.AST_NODE_TYPES.ObjectExpression)return;const sources=node.arguments.slice(1);const anyTaintedSource=sources.some(s=>s.type!==eslint_devkit_1.AST_NODE_TYPES.ObjectExpression&&s.type!==eslint_devkit_1.AST_NODE_TYPES.Literal);if(!anyTaintedSource)return;context.report({node,messageId:"objectInjection",data:{pattern:"Object.assign(target, untrustedSource)",riskLevel:"HIGH",vulnerability:"object injection via Object.assign spread",safeAlternative:"Validate or whitelist keys before merging: `for (const k of Object.keys(src)) if (!ALLOWED.has(k)) continue;`"}})};const checkMassAssignmentLoop=node=>{if(isInCodemodContext)return;const iterated=node.right;if(iterated.type!==eslint_devkit_1.AST_NODE_TYPES.CallExpression)return;const callee=iterated.callee;if(callee.type!==eslint_devkit_1.AST_NODE_TYPES.MemberExpression||callee.object.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier||callee.object.name!=="Object"||!(0,eslint_devkit_1.namesOneOf)((0,eslint_devkit_1.propertyName)(callee),["keys","entries"])){return}const source=iterated.arguments[0];if(source===void 0||!isUntrustedExpression(source))return;if(node.left.type!==eslint_devkit_1.AST_NODE_TYPES.VariableDeclaration)return;const bound=node.left.declarations[0]?.id;const keyName=bound?.type===eslint_devkit_1.AST_NODE_TYPES.Identifier?bound.name:bound?.type===eslint_devkit_1.AST_NODE_TYPES.ArrayPattern&&bound.elements[0]?.type===eslint_devkit_1.AST_NODE_TYPES.Identifier?bound.elements[0].name:null;if(keyName===null)return;const body=sourceCode.getText(node.body);if(/\b(includes|has|hasOwn|hasOwnProperty|indexOf)\s*\(/.test(body))return;let reported=false;const walk=n=>{if(reported)return;if(n.type===eslint_devkit_1.AST_NODE_TYPES.AssignmentExpression&&n.left.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&n.left.computed&&n.left.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&n.left.property.name===keyName){reported=true;context.report({node:n,messageId:"massAssignment",data:{key:keyName}});return}for(const key of Object.keys(n)){const child=n[key];if(key==="parent"||child===null||typeof child!=="object")continue;for(const c of Array.isArray(child)?child:[child]){if(c&&typeof c.type==="string")walk(c)}}};walk(node.body)};const isCopyLoopSourceOpaque=source=>{if(isUntrustedExpression(source))return true;if(source.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier)return false;const variable=(0,resolve_reference_1.resolvedReference)(sourceCode.getScope(source),source);if(!variable)return false;if(variable.defs.some(def2=>def2.type==="Parameter"))return true;if(variable.references.filter(ref=>ref.isWrite()).length>1)return false;const def=variable.defs[0];if(!def||def.type!=="Variable")return false;const init=def.node.init;return init?isUntrustedExpression(init):false};const checkPrototypePollutingCopyLoop=node=>{if(isInCodemodContext)return;const keyName=node.left.type===eslint_devkit_1.AST_NODE_TYPES.VariableDeclaration?node.left.declarations[0]?.id.type===eslint_devkit_1.AST_NODE_TYPES.Identifier?node.left.declarations[0].id.name:void 0:node.left.type===eslint_devkit_1.AST_NODE_TYPES.Identifier?node.left.name:void 0;if(!keyName)return;if(!isCopyLoopSourceOpaque(node.right))return;const bodyText=context.sourceCode.getTokens(node.body).map(token=>token.value).join("");if(/hasOwnProperty|hasOwn|__proto__|constructor|prototype|includes\(|allowlist|whitelist|Object\.keys/.test(bodyText)){return}armedLoops.add(node);openCopyLoops.push({keyName,reported:false})};const reportCopyLoopWrite=node=>{if(node.left.type!==eslint_devkit_1.AST_NODE_TYPES.MemberExpression||!node.left.computed||node.left.property.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier){return false}const propertyName=node.left.property.name;const loop=openCopyLoops.find(open=>open.keyName===propertyName&&!open.reported);if(!loop)return false;loop.reported=true;context.report({node,messageId:"objectInjection",data:{riskLevel:"HIGH",safeAlternative:'Guard the key before assigning: `if (k === "__proto__" || k === "constructor" || k === "prototype") continue;` \u2014 or copy with Object.create(null) / structuredClone.'}});return true};return{ForOfStatement:checkMassAssignmentLoop,ForInStatement:checkPrototypePollutingCopyLoop,"ForInStatement:exit":node=>{if(armedLoops.has(node))openCopyLoops.pop()},AssignmentExpression:node=>{if(isInCodemodContext)return;if(reportCopyLoopWrite(node))return;return checkAssignmentExpression(node)},MemberExpression:node=>{if(isInCodemodContext)return;return checkMemberExpression(node)},CallExpression:node=>{if(isInCodemodContext)return;return checkObjectAssignSpread(node)}}}});
1
+ "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.detectObjectInjection=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const eslint_devkit_3=require("@interlace/eslint-devkit");const resolve_reference_1=require("../../utils/resolve-reference");const fileUsesAstTooling=(0,eslint_devkit_3.createModuleEvidence)({packages:["@babel/types","@babel/traverse","recast","jscodeshift","eslint","estree-walker","ast-types","esrap","unist-util-visit"],scopes:["@typescript-eslint"]});const TYPED_ARRAY_CTORS=new Set(["Int8Array","Uint8Array","Uint8ClampedArray","Int16Array","Uint16Array","Int32Array","Uint32Array","Float32Array","Float64Array","BigInt64Array","BigUint64Array"]);const OBJECT_INJECTION_PATTERNS=[{pattern:"__proto__",dangerous:true,vulnerability:"prototype-pollution",safeAlternative:"Object.create(null) or Map",riskLevel:"critical"},{pattern:"prototype",dangerous:true,vulnerability:"prototype-pollution",safeAlternative:"Avoid prototype manipulation",riskLevel:"high"},{pattern:"constructor",dangerous:true,vulnerability:"method-injection",safeAlternative:"Validate property names against whitelist",riskLevel:"medium"}];exports.detectObjectInjection=(0,eslint_devkit_3.createRule)({name:"detect-object-injection",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-secure-coding/docs/rules/detect-object-injection.md",description:"Detects variable[key] as a left- or right-hand assignment operand",cwe:"CWE-915",confidence:"low"},messages:{objectInjection:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.WARNING,issueName:"Object injection",cwe:"CWE-915",description:"Object injection/Prototype pollution (incl. model/tool outputs)",severity:"{{riskLevel}}",fix:"{{safeAlternative}} \u2014 Not a finding when the key is a numeric index, a module constant, or guarded by Object.hasOwn / an allowlist",documentationLink:"https://portswigger.net/web-security/prototype-pollution"}),massAssignment:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Mass assignment",cwe:"CWE-915",description:"Every key of an untrusted object is copied onto this target, so the caller chooses which field is written \u2014 including one they should not control, such as isAdmin",severity:"HIGH",fix:"Copy an explicit allowlist of assignable fields instead of the caller's keys \u2014 Not a finding when the iterated object is module-built, or the body checks each key against an allowlist",documentationLink:"https://cwe.mitre.org/data/definitions/915.html"}),globalPrototypeWrite:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Global prototype pollution",cwe:"CWE-1321",description:"Assignment writes THROUGH {{step}}, so the property lands on Object.prototype and every object in the process inherits it",severity:"CRITICAL",fix:"Guard with Object.hasOwn, or build the target with Object.create(null) / a Map \u2014 Not a finding when the path is fixed at build time, or __proto__ / constructor / prototype are rejected first",documentationLink:"https://portswigger.net/web-security/prototype-pollution"})},schema:[{type:"object",properties:{allowLiterals:{type:"boolean",default:false,description:"Allow bracket notation with literal strings"},dangerousProperties:{type:"array",items:{type:"string"},default:["__proto__","prototype","constructor"],description:"Property NAMES treated as dangerous where the name is visible in the source \u2014 `obj['__proto__'] = v`. It cannot apply to a dynamic key (`obj[k] = v`), because there is no name to compare, and it does not gate the CWE-1321 traversal check, which is a fact about the language rather than a vocabulary. Set it to [] to stop reporting literal dangerous-property writes."}},additionalProperties:false}]},skipTestFiles:true,defaultOptions:[{allowLiterals:false,dangerousProperties:["__proto__","prototype","constructor"]}],create(context){const options=context.options[0]||{};const{allowLiterals:_allowLiterals=false,dangerousProperties=["__proto__","prototype","constructor"]}=options;const handledMemberExpressions=new WeakSet;const openCopyLoops=[];const armedLoops=new WeakSet;const sourceCode=context.sourceCode;const isInCodemodContext=(()=>{const filename=context.filename;if(/\/codemod[s]?\//i.test(filename))return true;if(/codemod\.[mc]?[jt]sx?$/i.test(filename))return true;return fileUsesAstTooling(sourceCode.ast)})();const isLiteralString=node=>{return(0,eslint_devkit_1.staticString)(node)!==null};const hasPrecedingValidation=(propertyNode,node)=>{if(propertyNode.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier){return false}const keyName=propertyNode.name;const isIncludesCall=testNode=>{return testNode.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression&&testNode.callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&(0,eslint_devkit_1.propertyName)(testNode.callee)==="includes"&&testNode.arguments.length>0&&testNode.arguments[0].type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&testNode.arguments[0].name===keyName};const isHasOwnPropertyCall=testNode=>{if(testNode.type!==eslint_devkit_1.AST_NODE_TYPES.CallExpression)return false;const callee=testNode.callee;const args=testNode.arguments;if(callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&(0,eslint_devkit_1.propertyName)(callee)==="call"&&args.length>=2&&args[1].type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&args[1].name===keyName){return true}if(callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&((0,eslint_devkit_1.propertyName)(callee)==="hasOwnProperty"||(0,eslint_devkit_1.propertyName)(callee)==="hasOwn")){const keyArg=(0,eslint_devkit_1.propertyName)(callee)==="hasOwn"?args[1]:args[0];if(keyArg?.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&keyArg.name===keyName){return true}}return false};const isInOperator=testNode=>{return testNode.type===eslint_devkit_1.AST_NODE_TYPES.BinaryExpression&&testNode.operator==="in"&&testNode.left.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&testNode.left.name===keyName};const hasValidation=testNode=>{if(testNode.type===eslint_devkit_1.AST_NODE_TYPES.UnaryExpression&&testNode.operator==="!"){return hasValidation(testNode.argument)}return isIncludesCall(testNode)||isHasOwnPropertyCall(testNode)||isInOperator(testNode)};const hasEarlyExit=consequent=>{if(consequent.type===eslint_devkit_1.AST_NODE_TYPES.BlockStatement){return consequent.body.some(stmt=>stmt.type===eslint_devkit_1.AST_NODE_TYPES.ThrowStatement||stmt.type===eslint_devkit_1.AST_NODE_TYPES.ReturnStatement)}return consequent.type===eslint_devkit_1.AST_NODE_TYPES.ThrowStatement||consequent.type===eslint_devkit_1.AST_NODE_TYPES.ReturnStatement};let current=node.parent;let foundFunctionBody=false;while(current&&!foundFunctionBody){if(current.type===eslint_devkit_1.AST_NODE_TYPES.IfStatement){if(hasValidation(current.test)){return true}}if(current.type===eslint_devkit_1.AST_NODE_TYPES.BlockStatement&&current.parent&&(current.parent.type===eslint_devkit_1.AST_NODE_TYPES.FunctionDeclaration||current.parent.type===eslint_devkit_1.AST_NODE_TYPES.FunctionExpression||current.parent.type===eslint_devkit_1.AST_NODE_TYPES.ArrowFunctionExpression)){foundFunctionBody=true;const blockBody=current.body;const nodeIndex=blockBody.findIndex(stmt=>{let check=node;while(check){if(check===stmt)return true;check=check.parent}return false});for(let i=0;i<nodeIndex;i++){const stmt=blockBody[i];if(stmt.type===eslint_devkit_1.AST_NODE_TYPES.IfStatement&&hasValidation(stmt.test)&&hasEarlyExit(stmt.consequent)){return true}}}current=current.parent}return false};const hasDisqualifyingLiteralAffix=node=>{if(node.type!==eslint_devkit_1.AST_NODE_TYPES.BinaryExpression||node.operator!=="+"){return false}const bin=node;const literalText=n=>{if(n.type!==eslint_devkit_1.AST_NODE_TYPES.Literal)return null;const v=n.value;if(typeof v!=="string"&&typeof v!=="number")return null;const s=String(v);return s.length>0?s:null};const prefix=literalText(bin.left);if(prefix!==null&&!dangerousProperties.some(d=>d.startsWith(prefix))){return true}const suffix=literalText(bin.right);if(suffix!==null&&!dangerousProperties.some(d=>d.endsWith(suffix))){return true}return false};const NUMERIC_RENDERING_CHARS=/[0-9NI]/;const hasNumericOperandInConcatenation=node=>{if(node.type!==eslint_devkit_1.AST_NODE_TYPES.BinaryExpression||node.operator!=="+"||dangerousProperties.some(name=>NUMERIC_RENDERING_CHARS.test(name))){return false}const anyNumericOperand=operand=>{if(operand.type===eslint_devkit_1.AST_NODE_TYPES.BinaryExpression&&operand.operator==="+"){const chain=operand;return anyNumericOperand(chain.left)||anyNumericOperand(chain.right)}return isNumericKey(operand)};const bin=node;return anyNumericOperand(bin.left)||anyNumericOperand(bin.right)};const hasVisibleNonConstantInitialiser=node=>{const scope=sourceCode.getScope(node);const variable=(0,resolve_reference_1.resolvedReference)(scope,node);if(!variable||variable.defs.length!==1){return false}const def=variable.defs[0];if(def.type!=="Variable"){return false}const init=def.node.init;if(!init){return false}return!(0,eslint_devkit_2.isStaticExpression)({node:init,scope:sourceCode.getScope(init)})};const chainRoot=node=>{let cur=node;while(cur.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression)cur=cur.object;return cur.type===eslint_devkit_1.AST_NODE_TYPES.Identifier?cur:null};const withoutTypeAnnotation=node=>{let current=node;while(current.type===eslint_devkit_1.AST_NODE_TYPES.TSAsExpression||current.type===eslint_devkit_1.AST_NODE_TYPES.TSTypeAssertion||current.type===eslint_devkit_1.AST_NODE_TYPES.TSSatisfiesExpression){current=current.expression}return current};const isLocallyConstructed=id=>{const variable=(0,resolve_reference_1.resolvedReference)(sourceCode.getScope(id),id);if(!variable||variable.defs.length!==1)return false;const def=variable.defs[0];if(def.type!=="Variable")return false;if(variable.references.filter(ref=>ref.isWrite()).length>1)return false;const rawInit=def.node.init;if(!rawInit)return false;const init=withoutTypeAnnotation(rawInit);return init.type===eslint_devkit_1.AST_NODE_TYPES.ObjectExpression||init.type===eslint_devkit_1.AST_NODE_TYPES.ArrayExpression||(0,eslint_devkit_2.isStaticExpression)({node:init,scope:sourceCode.getScope(init)})};const REQUEST_ROOTS=new Set(["req","request","ctx","context","event"]);const isUntrustedExpression=node=>{const root=chainRoot(node);if(root===null)return false;if(!REQUEST_ROOTS.has(root.name))return false;return!isLocallyConstructed(root)};const isSymbolKey=node=>{if(node.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&node.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&node.object.name==="Symbol"){return true}if(node.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier)return false;const variable=(0,resolve_reference_1.resolvedReference)(sourceCode.getScope(node),node);if(!variable||variable.defs.length!==1)return false;const def=variable.defs[0];if(def.type!=="Variable")return false;if(variable.references.filter(ref=>ref.isWrite()).length>1)return false;const init=def.node.init;if(init?.type!==eslint_devkit_1.AST_NODE_TYPES.CallExpression)return false;const callee=init.callee;return callee.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&callee.name==="Symbol"||callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&callee.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&callee.object.name==="Symbol"};const isImportedBinding=node=>{const root=chainRoot(node);if(root===null)return false;const variable=(0,resolve_reference_1.resolvedReference)(sourceCode.getScope(root),root);if(!variable||variable.defs.length!==1)return false;const def=variable.defs[0];if(def.type==="ImportBinding"){return true}if(def.type!=="Variable")return false;if(variable.references.filter(ref=>ref.isWrite()).length>1)return false;const init=def.node.init;return init?.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression&&init.callee.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&init.callee.name==="require"};const isDangerousPropertyAccess=propertyNode=>{if(isSymbolKey(propertyNode))return false;if(isImportedBinding(propertyNode))return false;{const root=chainRoot(propertyNode);if(root!==null&&isLocallyConstructed(root))return false}if(isNumericKey(propertyNode)||hasDisqualifyingLiteralAffix(propertyNode)||hasNumericOperandInConcatenation(propertyNode)){return false}if(propertyNode.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&!hasVisibleNonConstantInitialiser(propertyNode)){const name=propertyNode.name;if(/^[A-Z][A-Z0-9_]{2,}$/.test(name)){return false}if(/^[a-z]/.test(name)&&/(?:Code|Status|Version|Kind|Mode|Type|Stage|Level|Phase|Step|Flag|Num|Count)$/.test(name)){return false}}if(isLiteralString(propertyNode)){const propName=String(propertyNode.value);if(dangerousProperties.includes(propName)){return true}return false}return true};const isPrototypelessObject=objectNode=>{if(objectNode.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression&&objectNode.callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&objectNode.callee.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&objectNode.callee.object.name==="Object"&&(0,eslint_devkit_1.propertyName)(objectNode.callee)==="create"&&objectNode.arguments.length>0&&objectNode.arguments[0].type===eslint_devkit_1.AST_NODE_TYPES.Literal&&objectNode.arguments[0].value===null){return true}if(objectNode.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier){return false}const varName=objectNode.name;let current=objectNode;while(current){if(current.type===eslint_devkit_1.AST_NODE_TYPES.BlockStatement||current.type===eslint_devkit_1.AST_NODE_TYPES.Program){const statements=current.type===eslint_devkit_1.AST_NODE_TYPES.BlockStatement?current.body:current.body;for(const stmt of statements){if(stmt.type===eslint_devkit_1.AST_NODE_TYPES.VariableDeclaration){for(const decl of stmt.declarations){if(decl.id.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&decl.id.name===varName&&decl.init){if(decl.init.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression&&decl.init.callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&decl.init.callee.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&decl.init.callee.object.name==="Object"&&decl.init.callee.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&decl.init.callee.property.name==="create"&&decl.init.arguments.length>0&&decl.init.arguments[0].type===eslint_devkit_1.AST_NODE_TYPES.Literal&&decl.init.arguments[0].value===null){return true}if(decl.init.type===eslint_devkit_1.AST_NODE_TYPES.ArrayExpression&&decl.init.elements.length>0&&decl.init.elements[0]?.type===eslint_devkit_1.AST_NODE_TYPES.SpreadElement){return true}}}}}}current=current.parent}return false};const extractPropertyAccess=node=>{let object;let property;let propertyNode;let isAssignment=false;if(node.type===eslint_devkit_1.AST_NODE_TYPES.AssignmentExpression&&node.left.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression){object=sourceCode.getText(node.left.object);property=sourceCode.getText(node.left.property);propertyNode=node.left.property;isAssignment=true}else{const memberNode=node;object=sourceCode.getText(memberNode.object);property=sourceCode.getText(memberNode.property);propertyNode=memberNode.property;isAssignment=false}const pattern=OBJECT_INJECTION_PATTERNS.find(p=>new RegExp(p.pattern,"i").test(property)||dangerousProperties.includes(property.replace(/['"]/g,"")))||null;return{object,property,propertyNode,isAssignment,pattern}};const stepName=m=>{if(!m.computed&&m.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier)return m.property.name;if(m.computed&&m.property.type===eslint_devkit_1.AST_NODE_TYPES.Literal&&typeof m.property.value==="string"){return m.property.value}return null};const globalPrototypeWrite=node=>{if(node.left.type!==eslint_devkit_1.AST_NODE_TYPES.MemberExpression)return null;const steps=[];let cur=node.left.object;while(cur.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression){const name=stepName(cur);if(name===null)return null;steps.unshift(name);cur=cur.object}if(steps.includes("__proto__"))return"__proto__";for(let i=0;i<steps.length-1;i++){if(steps[i]==="constructor"&&steps[i+1]==="prototype")return"constructor.prototype"}return null};const isHighRiskAssignment=node=>{if(node.left.type!=="MemberExpression"){return false}if(!node.left.computed){return false}if(isPrototypelessObject(node.left.object)){return false}if(isTypedArrayObject(node.left.object)){return false}if(isArrayAppend(node.left)){return false}const{propertyNode}=extractPropertyAccess(node);if(isNumericKey(propertyNode)){return false}if(isKeyFromLiteralAllowlist(propertyNode)){return false}if(isForInOrObjectKeysKey(propertyNode)){return false}if(hasPrecedingValidation(propertyNode,node)){return false}return isDangerousPropertyAccess(propertyNode)};const isReflectResultAccess=objectNode=>{if(objectNode.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression){const callee=objectNode.callee;if(callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&callee.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&callee.object.name==="Reflect"){return true}}if(objectNode.type===eslint_devkit_1.AST_NODE_TYPES.ChainExpression){return isReflectResultAccess(objectNode.expression)}return false};const isHighRiskMemberAccess=node=>{if(!node.computed){return false}if(isReflectResultAccess(node.object)){return false}if(isTypedArrayObject(node.object)){return false}const{propertyNode}=extractPropertyAccess(node);if(isNumericKey(propertyNode)){return false}if(isForInOrObjectKeysKey(propertyNode)){return false}if(hasPrecedingValidation(propertyNode,node)){return false}return isDangerousPropertyAccess(propertyNode)};const isArrayAppend=member=>{if(member.object.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier)return false;const key=member.property;return key.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&key.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&key.object.name===member.object.name&&(0,eslint_devkit_1.propertyName)(key)==="length"};const isKeyFromLiteralAllowlist=node=>{if(node.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier)return false;const variable=(0,resolve_reference_1.resolvedReference)(sourceCode.getScope(node),node);if(!variable||variable.defs.length!==1)return false;const def=variable.defs[0];if(def.type!=="Variable")return false;const declaration=def.node.parent;const loop=declaration?.parent;if(loop?.type!==eslint_devkit_1.AST_NODE_TYPES.ForOfStatement||loop.left!==declaration)return false;let source=withoutTypeAnnotation(loop.right);if(source.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression&&source.callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&source.callee.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&source.callee.object.name==="Object"&&(0,eslint_devkit_1.propertyName)(source.callee)==="freeze"&&source.arguments[0]!==void 0){source=source.arguments[0]}if(source.type===eslint_devkit_1.AST_NODE_TYPES.Identifier){const listVar=(0,resolve_reference_1.resolvedReference)(sourceCode.getScope(source),source);if(!listVar||listVar.defs.length!==1)return false;const listDef=listVar.defs[0];if(listDef.type!=="Variable")return false;if(listDef.parent?.kind!=="const")return false;source=listDef.node.init}if(source.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression&&source.callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&source.callee.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&source.callee.object.name==="Object"&&(0,eslint_devkit_1.propertyName)(source.callee)==="freeze"&&source.arguments[0]!==void 0){source=source.arguments[0]}source=withoutTypeAnnotation(source);if(source.type!==eslint_devkit_1.AST_NODE_TYPES.ArrayExpression)return false;if(source.elements.length===0)return false;return source.elements.every(element=>{const text=element===null?null:(0,eslint_devkit_1.staticString)(element);return text!==null&&!dangerousProperties.includes(text)})};const isNumericKey=node=>{if(node.type===eslint_devkit_1.AST_NODE_TYPES.Literal&&typeof node.value==="number"){return true}if(node.type===eslint_devkit_1.AST_NODE_TYPES.UnaryExpression){const op=node.operator;if(op==="+"||op==="-"||op==="~")return true}if(node.type===eslint_devkit_1.AST_NODE_TYPES.UpdateExpression){return true}if(node.type===eslint_devkit_1.AST_NODE_TYPES.BinaryExpression){const op=node.operator;if(op==="|"||op==="&"||op==="^"||op==="<<"||op===">>"||op===">>>"||op==="*"||op==="/"||op==="%"||op==="-"||op==="**"){return true}if(op==="+"){const bin=node;return isNumericKey(bin.left)&&isNumericKey(bin.right)}}if(node.type===eslint_devkit_1.AST_NODE_TYPES.ConditionalExpression){const cond=node;return isNumericKey(cond.consequent)&&isNumericKey(cond.alternate)}if(node.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression){const callee=node.callee;if(callee.type===eslint_devkit_1.AST_NODE_TYPES.Identifier){const name=callee.name;if(name==="Number"||name==="parseInt"||name==="parseFloat")return true}if(callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&callee.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&callee.object.name==="Math"&&callee.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier){return true}}if(node.type===eslint_devkit_1.AST_NODE_TYPES.Identifier){return isNumericIdentifier(node)}return false};const numericVarCache=new WeakMap;const numericVarInProgress=new WeakSet;const isNumericIdentifier=node=>{if(isLoopCounterIdentifier(node))return true;const scope=context.sourceCode.getScope(node);const variable=(0,resolve_reference_1.resolvedReference)(scope,node);if(!variable||variable.defs.length===0)return false;const cached=numericVarCache.get(variable);if(cached!==void 0)return cached;if(numericVarInProgress.has(variable))return true;numericVarInProgress.add(variable);let result=false;const def=variable.defs[0];const declarator=def.node;if(declarator?.type===eslint_devkit_1.AST_NODE_TYPES.VariableDeclarator&&declarator.init&&declarator.parent?.type===eslint_devkit_1.AST_NODE_TYPES.VariableDeclaration){result=isNumericKey(declarator.init);if(result){for(const ref of variable.references){const written=ref.writeExpr;if(!written||written===declarator.init)continue;if(!isNumericKey(written)){result=false;break}}}}numericVarInProgress.delete(variable);numericVarCache.set(variable,result);return result};const isLoopCounterIdentifier=node=>{const scope=context.sourceCode.getScope(node);const variable=(0,resolve_reference_1.resolvedReference)(scope,node);if(!variable||variable.defs.length===0)return false;const def=variable.defs[0];const parent=def.node?.parent;const grand=parent?.parent;if(parent?.type===eslint_devkit_1.AST_NODE_TYPES.VariableDeclaration&&grand?.type===eslint_devkit_1.AST_NODE_TYPES.ForStatement&&grand.init===parent){const init=def.node.init;if(!init)return false;if(init.type===eslint_devkit_1.AST_NODE_TYPES.Literal&&typeof init.value==="number"){return true}}return false};const ELEMENT_FIRST_ITERATORS=new Set(["forEach","map","filter","find","findLast","some","every","flatMap"]);const isObjectKeysCallbackKey=(fn,name)=>{if(fn.type!==eslint_devkit_1.AST_NODE_TYPES.ArrowFunctionExpression&&fn.type!==eslint_devkit_1.AST_NODE_TYPES.FunctionExpression){return false}const first=fn.params[0];const bindsName=first?.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&first.name===name||first?.type===eslint_devkit_1.AST_NODE_TYPES.ArrayPattern&&first.elements[0]?.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&first.elements[0].name===name;if(!bindsName)return false;const call=fn.parent;if(call?.type!==eslint_devkit_1.AST_NODE_TYPES.CallExpression||call.arguments[0]!==fn||call.callee.type!==eslint_devkit_1.AST_NODE_TYPES.MemberExpression||call.callee.computed||call.callee.property.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier||!ELEMENT_FIRST_ITERATORS.has(call.callee.property.name)){return false}const source=call.callee.object;return source.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression&&source.callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&source.callee.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&source.callee.object.name==="Object"&&((0,eslint_devkit_1.propertyName)(source.callee)==="keys"||(0,eslint_devkit_1.propertyName)(source.callee)==="entries")};const isForInOrObjectKeysKey=node=>{if(node.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier)return false;const scope=context.sourceCode.getScope(node);const variable=(0,resolve_reference_1.resolvedReference)(scope,node);if(!variable||variable.defs.length===0)return false;const def=variable.defs[0];if(def.type==="Parameter"){return isObjectKeysCallbackKey(def.node,node.name)}const varDecl=def.node?.parent;const loopStmt=varDecl?.parent;if(!varDecl||varDecl.type!==eslint_devkit_1.AST_NODE_TYPES.VariableDeclaration)return false;if(loopStmt?.type===eslint_devkit_1.AST_NODE_TYPES.ForInStatement&&loopStmt.left===varDecl){return true}if(loopStmt?.type===eslint_devkit_1.AST_NODE_TYPES.ForOfStatement&&loopStmt.left===varDecl){const right=loopStmt.right;return right.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression&&right.callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&right.callee.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&right.callee.object.name==="Object"&&((0,eslint_devkit_1.propertyName)(right.callee)==="keys"||(0,eslint_devkit_1.propertyName)(right.callee)==="entries")}return false};const isTypedArrayObject=objectNode=>{if(objectNode.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier)return false;const varName=objectNode.name;let scope=context.sourceCode.getScope(objectNode);while(scope){const variable=scope.set.get(varName);if(variable){for(const def of variable.defs){const init=def.node.init;if(init?.type===eslint_devkit_1.AST_NODE_TYPES.NewExpression&&init.callee.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&TYPED_ARRAY_CTORS.has(init.callee.name)){return true}}break}if(!scope.upper)break;scope=scope.upper}return false};const determineRiskLevel=(pattern,isAssignment)=>{if(pattern?.riskLevel==="critical"||pattern&&isAssignment){return"CRITICAL"}if(pattern?.riskLevel==="high"||isAssignment){return"HIGH"}return"MEDIUM"};const checkAssignmentExpression=node=>{const step=globalPrototypeWrite(node);if(step!==null){for(let m=node.left;m.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression;m=m.object){handledMemberExpressions.add(m)}context.report({node,messageId:"globalPrototypeWrite",data:{step}});return}if(!isHighRiskAssignment(node)){return}if(node.left.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&node.left.computed&&keyComesFromConstAllowlist(node.left.property,node)){return}let me=node.left;handledMemberExpressions.add(me);while(me.object.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&me.object.computed){me=me.object;handledMemberExpressions.add(me)}const{object,property,isAssignment,pattern}=extractPropertyAccess(node);const riskLevel=determineRiskLevel(pattern,isAssignment);context.report({node,messageId:"objectInjection",data:{pattern:`${object}[${property}]`,riskLevel,vulnerability:pattern?.vulnerability||"object injection",safeAlternative:pattern?.safeAlternative||"Use Map or property whitelisting"}})};const constObjectLiteralOf=(name,from)=>{for(let scope=sourceCode.getScope(from);scope;scope=scope.upper){const variable=scope.set.get(name);if(!variable)continue;if(variable.defs.length!==1)return null;const def=variable.defs[0];if(def.type!=="Variable"||def.parent?.kind!=="const")return null;if(variable.references.some(ref=>ref.isWrite()&&ref.identifier!==def.name)){return null}const init=def.node.init;return init?.type===eslint_devkit_1.AST_NODE_TYPES.ObjectExpression?init:null}return null};const isReadFromConstObjectLiteral=node=>node.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&constObjectLiteralOf(node.object.name,node)!==null;const keyComesFromConstAllowlist=(property,from)=>{if(property.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier)return false;for(let scope=sourceCode.getScope(from);scope;scope=scope.upper){const variable=scope.set.get(property.name);if(!variable)continue;if(variable.defs.length!==1)return false;const def=variable.defs[0];if(def.type!=="Variable"||def.parent?.kind!=="const")return false;if(variable.references.some(ref=>ref.isWrite()&&ref.identifier!==def.name)){return false}const init=def.node.init;if(init?.type!==eslint_devkit_1.AST_NODE_TYPES.MemberExpression||!init.computed||init.object.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier){return false}const source=constObjectLiteralOf(init.object.name,init);if(!source)return false;return source.properties.every(p=>p.type===eslint_devkit_1.AST_NODE_TYPES.Property&&p.value.type===eslint_devkit_1.AST_NODE_TYPES.Literal&&typeof p.value.value==="string")}return false};const isInvokedRead=node=>{const parent=node.parent;if(parent===void 0)return false;if(parent.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression&&parent.callee===node){return true}if(parent.type!==eslint_devkit_1.AST_NODE_TYPES.VariableDeclarator||parent.init!==node||parent.id.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier){return false}const variable=context.sourceCode.getDeclaredVariables(parent).find(candidate=>candidate.name===parent.id.name);return variable?.references.some(reference=>{const referenceParent=reference.identifier.parent;return referenceParent?.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression&&referenceParent.callee===reference.identifier})??false};const isWriteTarget=node=>{let current=node;let parent=current.parent;while(parent!==void 0){if(parent.type===eslint_devkit_1.AST_NODE_TYPES.AssignmentExpression&&parent.left===current){return true}if(parent.type===eslint_devkit_1.AST_NODE_TYPES.UpdateExpression&&parent.argument===current){return true}if(parent.type===eslint_devkit_1.AST_NODE_TYPES.UnaryExpression&&parent.operator==="delete"){return true}if(parent.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&parent.object===current){current=parent;parent=current.parent;continue}return false}return false};const checkMemberExpression=node=>{if(!isWriteTarget(node)&&!isInvokedRead(node)){return}if(!isHighRiskMemberAccess(node)){return}if(isReadFromConstObjectLiteral(node)){return}if(handledMemberExpressions.has(node)){return}const parent=node.parent;if(parent?.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&parent.computed&&parent.object===node){return}if(parent&&parent.type===eslint_devkit_1.AST_NODE_TYPES.AssignmentExpression&&parent.left===node){return}const{object,property,isAssignment,pattern}=extractPropertyAccess(node);const riskLevel=determineRiskLevel(pattern,isAssignment);context.report({node,messageId:"objectInjection",data:{pattern:`${object}[${property}]`,riskLevel,vulnerability:pattern?.vulnerability||"object injection",safeAlternative:pattern?.safeAlternative||"Use Map or property whitelisting"}})};const checkObjectAssignSpread=node=>{if(node.callee.type!==eslint_devkit_1.AST_NODE_TYPES.MemberExpression)return;const callee=node.callee;const objectIsObject=callee.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&callee.object.name==="Object";const propIsAssign=(0,eslint_devkit_1.propertyName)(callee)==="assign";if(!objectIsObject||!propIsAssign)return;if(node.arguments[0]?.type===eslint_devkit_1.AST_NODE_TYPES.ObjectExpression)return;if(node.arguments[0]&&isPrototypelessObject(node.arguments[0]))return;const sources=node.arguments.slice(1);const anyTaintedSource=sources.some(s=>s.type!==eslint_devkit_1.AST_NODE_TYPES.ObjectExpression&&s.type!==eslint_devkit_1.AST_NODE_TYPES.Literal);if(!anyTaintedSource)return;context.report({node,messageId:"objectInjection",data:{pattern:"Object.assign(target, untrustedSource)",riskLevel:"HIGH",vulnerability:"object injection via Object.assign spread",safeAlternative:"Validate or whitelist keys before merging: `for (const k of Object.keys(src)) if (!ALLOWED.has(k)) continue;`"}})};const checkMassAssignmentLoop=node=>{if(isInCodemodContext)return;const iterated=node.right;if(iterated.type!==eslint_devkit_1.AST_NODE_TYPES.CallExpression)return;const callee=iterated.callee;if(callee.type!==eslint_devkit_1.AST_NODE_TYPES.MemberExpression||callee.object.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier||callee.object.name!=="Object"||!(0,eslint_devkit_1.namesOneOf)((0,eslint_devkit_1.propertyName)(callee),["keys","entries"])){return}const source=iterated.arguments[0];if(source===void 0||!isCopyLoopSourceOpaque(source))return;if(node.left.type!==eslint_devkit_1.AST_NODE_TYPES.VariableDeclaration)return;const bound=node.left.declarations[0]?.id;const keyName=bound?.type===eslint_devkit_1.AST_NODE_TYPES.Identifier?bound.name:bound?.type===eslint_devkit_1.AST_NODE_TYPES.ArrayPattern&&bound.elements[0]?.type===eslint_devkit_1.AST_NODE_TYPES.Identifier?bound.elements[0].name:null;if(keyName===null)return;const body=sourceCode.getTokens(node.body).map(token=>token.value).join("");if(/\b(includes|has|hasOwn|hasOwnProperty|indexOf)\s*\(/.test(body))return;if(/__proto__|constructor|prototype/.test(body))return;let reported=false;const walk=n=>{if(reported)return;if(n.type===eslint_devkit_1.AST_NODE_TYPES.AssignmentExpression&&n.left.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&n.left.computed&&n.left.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&n.left.property.name===keyName){reported=true;context.report({node:n,messageId:"massAssignment",data:{key:keyName}});return}for(const key of Object.keys(n)){const child=n[key];if(key==="parent"||child===null||typeof child!=="object")continue;for(const c of Array.isArray(child)?child:[child]){if(c&&typeof c.type==="string")walk(c)}}};walk(node.body)};const isCopyLoopSourceOpaque=source=>{if(isUntrustedExpression(source))return true;if(source.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier)return false;const variable=(0,resolve_reference_1.resolvedReference)(sourceCode.getScope(source),source);if(!variable)return false;if(variable.defs.some(def2=>def2.type==="Parameter"))return true;if(variable.references.filter(ref=>ref.isWrite()).length>1)return false;const def=variable.defs[0];if(!def||def.type!=="Variable")return false;const init=def.node.init;return init?isUntrustedExpression(init):false};const checkPrototypePollutingCopyLoop=node=>{if(isInCodemodContext)return;const keyName=node.left.type===eslint_devkit_1.AST_NODE_TYPES.VariableDeclaration?node.left.declarations[0]?.id.type===eslint_devkit_1.AST_NODE_TYPES.Identifier?node.left.declarations[0].id.name:void 0:node.left.type===eslint_devkit_1.AST_NODE_TYPES.Identifier?node.left.name:void 0;if(!keyName)return;if(!isCopyLoopSourceOpaque(node.right))return;const bodyText=context.sourceCode.getTokens(node.body).map(token=>token.value).join("");if(/hasOwnProperty|hasOwn|__proto__|constructor|prototype|includes\(|allowlist|whitelist|Object\.keys/.test(bodyText)){return}armedLoops.add(node);openCopyLoops.push({keyName,reported:false})};const reportCopyLoopWrite=node=>{if(node.left.type!==eslint_devkit_1.AST_NODE_TYPES.MemberExpression||!node.left.computed||node.left.property.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier){return false}const propertyName=node.left.property.name;const loop=openCopyLoops.find(open=>open.keyName===propertyName&&!open.reported);if(!loop)return false;loop.reported=true;context.report({node,messageId:"objectInjection",data:{riskLevel:"HIGH",safeAlternative:'Guard the key before assigning: `if (k === "__proto__" || k === "constructor" || k === "prototype") continue;` \u2014 or copy with Object.create(null) / structuredClone.'}});return true};return{ForOfStatement:checkMassAssignmentLoop,ForInStatement:checkPrototypePollutingCopyLoop,"ForInStatement:exit":node=>{if(armedLoops.has(node))openCopyLoops.pop()},AssignmentExpression:node=>{if(isInCodemodContext)return;if(reportCopyLoopWrite(node))return;return checkAssignmentExpression(node)},MemberExpression:node=>{if(isInCodemodContext)return;return checkMemberExpression(node)},CallExpression:node=>{if(isInCodemodContext)return;return checkObjectAssignSpread(node)}}}});
@@ -1 +1 @@
1
- "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noInsecureComparison=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const fileUsesAstTooling=(0,eslint_devkit_2.createModuleEvidence)({packages:["@babel/types","@babel/traverse","@babel/generator","@babel/parser","recast","jscodeshift","estree-walker","unist-util-visit","@typescript-eslint/utils","@typescript-eslint/typescript-estree","typescript","ts-morph","eslint"]});exports.noInsecureComparison=(0,eslint_devkit_2.createRule)({name:"no-insecure-comparison",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-secure-coding/docs/rules/no-insecure-comparison.md",description:"Detects insecure comparison operators (==, !=) that can lead to type coercion vulnerabilities",cwe:"CWE-697",cvss:5.3},hasSuggestions:true,messages:{insecureComparison:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Insecure Comparison",cwe:"CWE-697",description:"Insecure comparison operator ({{operator}}) detected - can lead to type coercion vulnerabilities",severity:"HIGH",fix:"Use strict equality ({{strictOperator}}) instead: {{example}} \u2014 Not a finding if the comparison is against null, which tests null and undefined together on purpose",documentationLink:"https://cwe.mitre.org/data/definitions/697.html"}),useStrictEquality:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Use Strict Equality",description:"Use strict equality operator",severity:"LOW",fix:"Replace == with === and != with !== \u2014 Not a finding if the comparison is the idiomatic `x == null` nullish test",documentationLink:"https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Strict_equality"}),useTimingSafeEqual:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Use A Constant-Time Comparison",description:"Compare secrets in constant time, not with an operator that short-circuits",severity:"LOW",fix:"Rewrite as crypto.timingSafeEqual(Buffer.from(a), Buffer.from(b)) \u2014 Not a finding if neither side is a secret the caller can guess one character at a time",documentationLink:"https://nodejs.org/api/crypto.html#cryptotimingsafeequala-b"}),timingUnsafeComparison:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Timing Attack Risk",cwe:"CWE-208",description:"Secret comparison with {{operator}} can leak timing information",severity:"HIGH",fix:"Use crypto.timingSafeEqual(Buffer.from(a), Buffer.from(b)) \u2014 Not a finding if the compared value is public, such as an id or a status",documentationLink:"https://nodejs.org/api/crypto.html#cryptotimingsafeequala-b"})},schema:[{type:"object",properties:{allowInTests:{type:"boolean",default:false,description:"Allow insecure comparison in test files"},ignorePatterns:{type:"array",items:{type:"string"},default:[],description:"Additional patterns to ignore"},reportLooseEquality:{type:"boolean",default:true,description:"Report `==` between non-secret operands. Turn off to keep only the secret-comparison findings and leave generic type coercion to eqeqeq."}},additionalProperties:false}]},defaultOptions:[{allowInTests:false,ignorePatterns:[],reportLooseEquality:true}],create(context,[options={}]){const{allowInTests=false,ignorePatterns=[],reportLooseEquality=true}=options;const filename=context.filename;const isTestFile=allowInTests&&(0,eslint_devkit_1.isTestFilePath)(filename);const sourceCode=context.sourceCode;const isCodemodFile=(()=>{if(/\/codemod[s]?\//i.test(filename))return true;if(/codemod\.[mc]?[jt]sx?$/i.test(filename))return true;return fileUsesAstTooling(sourceCode.ast)})();function matchesIgnorePattern(text,patterns){return patterns.some(pattern=>{try{const regex=new RegExp(pattern,"i");return regex.test(text)}catch{return text.toLowerCase().includes(pattern.toLowerCase())}})}function isNullLiteral(node){return node.type==="Literal"&&node.raw==="null"}function isStringTyped(node,seen=new Set){if(node.type===eslint_devkit_1.AST_NODE_TYPES.Literal)return typeof node.value==="string";if(node.type===eslint_devkit_1.AST_NODE_TYPES.TemplateLiteral)return true;if(node.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier)return false;if(seen.has(node.name))return false;seen.add(node.name);for(let scope=sourceCode.getScope(node);scope;scope=scope.upper){const variable=scope.variables.find(v=>v.name===node.name);if(!variable)continue;const writes=variable.references.filter(ref=>ref.isWrite());if(writes.length===0)return false;return writes.every(ref=>{const written=ref.writeExpr;return written!=null&&isStringTyped(written,seen)})}return false}function checkBinaryExpression(node){if(isTestFile){return}if(isCodemodFile){return}const secretKeywords=new Set(["secret","secrets","token","tokens","password","passwd","pwd","apikey","api_key","secretkey","secret_key","privatekey","private_key","signature","hmac","digest","checksum","nonce","otp","passwordhash","password_hash","hashedpassword","hashed_password","credential","credentials"]);const nameSegments=name=>{const parts=name.replace(/([a-z0-9])([A-Z])/g,"$1 $2").split(/[^A-Za-z0-9]+/).filter(Boolean).map(p=>p.toLowerCase());const pairs=[];for(let i=0;i+1<parts.length;i+=1){pairs.push(parts[i]+parts[i+1],`${parts[i]}_${parts[i+1]}`)}return[...parts,...pairs,parts.join(""),parts.join("_"),name.toLowerCase()]};const scopeAtNode=sourceCode.getScope(node);const destructuringKeys=(pattern,target)=>{const keys=[];const walkPattern=n=>{if(n.type==="ObjectPattern"){for(const property of n.properties){if(property.type!=="Property")continue;if(property.value===target&&!property.computed&&property.key.type==="Identifier"){keys.push(property.key.name)}walkPattern(property.value)}}else if(n.type==="ArrayPattern"){for(const element of n.elements)if(element)walkPattern(element)}else if(n.type==="AssignmentPattern"){walkPattern(n.left)}};walkPattern(pattern);return keys};const namesIn=expr=>{const out=[];const visited=new Set;const walk=n=>{if(visited.has(n))return;visited.add(n);if(n.type==="Identifier"){out.push(n.name);resolveIdentifier(n)}else if(n.type==="MemberExpression"){walk(n.object);const key=(0,eslint_devkit_1.propertyName)(n);if(key!==null)out.push(key);else walk(n.property)}else if(n.type==="CallExpression"){walk(n.callee)}else if(n.type==="ConditionalExpression"){walk(n.consequent);walk(n.alternate)}else if(n.type==="TSAsExpression"||n.type==="TSSatisfiesExpression"||n.type==="TSNonNullExpression"){walk(n.expression)}};function resolveIdentifier(identifier){for(let scope=scopeAtNode;scope;scope=scope.upper){const variable=scope.variables.find(v=>v.name===identifier.name);if(!variable)continue;const writes=variable.references.filter(ref=>ref.isWrite());if(writes.length===1&&writes[0].writeExpr)walk(writes[0].writeExpr);for(const def of variable.defs){if(def.type!=="Variable")continue;out.push(...destructuringKeys(def.node.id,def.name))}return}}walk(expr);return out};const isPotentialSecret=expr=>namesIn(expr).flatMap(nameSegments).some(segment=>secretKeywords.has(segment));if((node.operator==="==="||node.operator==="!==")&&(isPotentialSecret(node.left)||isPotentialSecret(node.right))){const isLengthComparison=expr=>{return expr.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&(0,eslint_devkit_1.propertyName)(expr)==="length"};if(isLengthComparison(node.left)||isLengthComparison(node.right)){return}const isNonSecretLiteral=expr=>expr.type===eslint_devkit_1.AST_NODE_TYPES.Literal&&(typeof expr.value==="boolean"||expr.value===null)||expr.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&expr.name==="undefined";if(isNonSecretLiteral(node.left)||isNonSecretLiteral(node.right)){return}const leftText=sourceCode.getText(node.left);const rightText=sourceCode.getText(node.right);const example=`crypto.timingSafeEqual(Buffer.from(${leftText}), Buffer.from(${rightText}))`;context.report({node,messageId:"timingUnsafeComparison",data:{operator:node.operator,strictOperator:node.operator,example},suggest:[{messageId:"useTimingSafeEqual",fix:fixer=>fixer.replaceText(node,example)}]});return}if(node.operator==="=="||node.operator==="!="){const text=sourceCode.getText(node);if(matchesIgnorePattern(text,ignorePatterns)){return}if(isNullLiteral(node.left)||isNullLiteral(node.right)){return}if(isStringTyped(node.left)&&isStringTyped(node.right)){return}const comparesSecret=isPotentialSecret(node.left)||isPotentialSecret(node.right);if(!reportLooseEquality&&!comparesSecret){return}const strictOperator=node.operator==="=="?"===":"!==";const leftText=sourceCode.getText(node.left);const rightText=sourceCode.getText(node.right);const example=`${leftText} ${strictOperator} ${rightText}`;context.report({node,messageId:"insecureComparison",data:{operator:node.operator,strictOperator,example},suggest:[{messageId:"useStrictEquality",fix:fixer=>{return fixer.replaceText(node,example)}}]})}}return{BinaryExpression:checkBinaryExpression}}});
1
+ "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noInsecureComparison=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const fileUsesAstTooling=(0,eslint_devkit_2.createModuleEvidence)({packages:["@babel/types","@babel/traverse","@babel/generator","@babel/parser","recast","jscodeshift","estree-walker","unist-util-visit","@typescript-eslint/utils","@typescript-eslint/typescript-estree","typescript","ts-morph","eslint"]});exports.noInsecureComparison=(0,eslint_devkit_2.createRule)({name:"no-insecure-comparison",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-secure-coding/docs/rules/no-insecure-comparison.md",description:"Detects insecure comparison operators (==, !=) that can lead to type coercion vulnerabilities",cwe:"CWE-697",cvss:5.3},hasSuggestions:true,messages:{insecureComparison:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Insecure Comparison",cwe:"CWE-697",description:"Insecure comparison operator ({{operator}}) detected - can lead to type coercion vulnerabilities",severity:"HIGH",fix:"Use strict equality ({{strictOperator}}) instead: {{example}} \u2014 Not a finding if the comparison is against null, which tests null and undefined together on purpose",documentationLink:"https://cwe.mitre.org/data/definitions/697.html"}),useStrictEquality:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Use Strict Equality",description:"Use strict equality operator",severity:"LOW",fix:"Replace == with === and != with !== \u2014 Not a finding if the comparison is the idiomatic `x == null` nullish test",documentationLink:"https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Strict_equality"}),useTimingSafeEqual:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Use A Constant-Time Comparison",description:"Compare secrets in constant time, not with an operator that short-circuits",severity:"LOW",fix:"Rewrite as crypto.timingSafeEqual(Buffer.from(a), Buffer.from(b)) \u2014 Not a finding if neither side is a secret the caller can guess one character at a time",documentationLink:"https://nodejs.org/api/crypto.html#cryptotimingsafeequala-b"}),timingUnsafeComparison:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Timing Attack Risk",cwe:"CWE-208",description:"Secret comparison with {{operator}} can leak timing information",severity:"HIGH",fix:"Use crypto.timingSafeEqual(Buffer.from(a), Buffer.from(b)) \u2014 Not a finding if the compared value is public, such as an id or a status",documentationLink:"https://nodejs.org/api/crypto.html#cryptotimingsafeequala-b"})},schema:[{type:"object",properties:{allowInTests:{type:"boolean",default:false,description:"Allow insecure comparison in test files"},ignorePatterns:{type:"array",items:{type:"string"},default:[],description:"Additional patterns to ignore"},reportLooseEquality:{type:"boolean",default:true,description:"Report `==` between non-secret operands. Turn off to keep only the secret-comparison findings and leave generic type coercion to eqeqeq."}},additionalProperties:false}]},defaultOptions:[{allowInTests:false,ignorePatterns:[],reportLooseEquality:true}],create(context,[options={}]){const{allowInTests=false,ignorePatterns=[],reportLooseEquality=true}=options;const filename=context.filename;const isTestFile=allowInTests&&(0,eslint_devkit_1.isTestFilePath)(filename);const sourceCode=context.sourceCode;const isCodemodFile=(()=>{if(/\/codemod[s]?\//i.test(filename))return true;if(/codemod\.[mc]?[jt]sx?$/i.test(filename))return true;return fileUsesAstTooling(sourceCode.ast)})();function matchesIgnorePattern(text,patterns){return patterns.some(pattern=>{try{const regex=new RegExp(pattern,"i");return regex.test(text)}catch{return text.toLowerCase().includes(pattern.toLowerCase())}})}function isNullLiteral(node){return node.type==="Literal"&&node.raw==="null"}function isStringTyped(node,seen=new Set){if(node.type===eslint_devkit_1.AST_NODE_TYPES.Literal)return typeof node.value==="string";if(node.type===eslint_devkit_1.AST_NODE_TYPES.TemplateLiteral)return true;if(node.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier)return false;if(seen.has(node.name))return false;seen.add(node.name);for(let scope=sourceCode.getScope(node);scope;scope=scope.upper){const variable=scope.variables.find(v=>v.name===node.name);if(!variable)continue;const writes=variable.references.filter(ref=>ref.isWrite());if(writes.length===0)return false;return writes.every(ref=>{const written=ref.writeExpr;return written!=null&&isStringTyped(written,seen)})}return false}function checkBinaryExpression(node){if(isTestFile){return}if(isCodemodFile){return}const secretKeywords=new Set(["secret","secrets","token","tokens","password","passwd","pwd","apikey","api_key","secretkey","secret_key","privatekey","private_key","signature","hmac","digest","checksum","nonce","otp","passwordhash","password_hash","hashedpassword","hashed_password","credential","credentials"]);const nameSegments=name=>{const parts=name.replace(/([a-z0-9])([A-Z])/g,"$1 $2").split(/[^A-Za-z0-9]+/).filter(Boolean).map(p=>p.toLowerCase());const pairs=[];for(let i=0;i+1<parts.length;i+=1){pairs.push(parts[i]+parts[i+1],`${parts[i]}_${parts[i+1]}`)}return[...parts,...pairs,parts.join(""),parts.join("_"),name.toLowerCase()]};const scopeAtNode=sourceCode.getScope(node);const destructuringKeys=(pattern,target)=>{const keys=[];const walkPattern=n=>{if(n.type==="ObjectPattern"){for(const property of n.properties){if(property.type!=="Property")continue;if(property.value===target&&!property.computed&&property.key.type==="Identifier"){keys.push(property.key.name)}walkPattern(property.value)}}else if(n.type==="ArrayPattern"){for(const element of n.elements)if(element)walkPattern(element)}else if(n.type==="AssignmentPattern"){walkPattern(n.left)}};walkPattern(pattern);return keys};const namesIn=expr=>{const out=[];const visited=new Set;const walk=n=>{if(visited.has(n))return;visited.add(n);if(n.type==="Identifier"){out.push(n.name);resolveIdentifier(n)}else if(n.type==="MemberExpression"){walk(n.object);const key=(0,eslint_devkit_1.propertyName)(n);if(key!==null)out.push(key);else walk(n.property)}else if(n.type==="CallExpression"){walk(n.callee)}else if(n.type==="ConditionalExpression"){walk(n.consequent);walk(n.alternate)}else if(n.type==="TSAsExpression"||n.type==="TSSatisfiesExpression"||n.type==="TSNonNullExpression"){walk(n.expression)}};function resolveIdentifier(identifier){for(let scope=scopeAtNode;scope;scope=scope.upper){const variable=scope.variables.find(v=>v.name===identifier.name);if(!variable)continue;const writes=variable.references.filter(ref=>ref.isWrite());const isObjectDestructured=variable.defs.some(def=>def.type==="Variable"&&def.node.id.type===eslint_devkit_1.AST_NODE_TYPES.ObjectPattern);if(!isObjectDestructured&&writes.length===1&&writes[0].writeExpr){walk(writes[0].writeExpr)}for(const def of variable.defs){if(def.type!=="Variable")continue;out.push(...destructuringKeys(def.node.id,def.name))}return}}walk(expr);return out};const isPotentialSecret=expr=>namesIn(expr).flatMap(nameSegments).some(segment=>secretKeywords.has(segment));if((node.operator==="==="||node.operator==="!==")&&(isPotentialSecret(node.left)||isPotentialSecret(node.right))){const isLengthComparison=expr=>{return expr.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&(0,eslint_devkit_1.propertyName)(expr)==="length"};if(isLengthComparison(node.left)||isLengthComparison(node.right)){return}const isNonSecretLiteral=expr=>expr.type===eslint_devkit_1.AST_NODE_TYPES.Literal||expr.type===eslint_devkit_1.AST_NODE_TYPES.TemplateLiteral&&expr.expressions.length===0||expr.type===eslint_devkit_1.AST_NODE_TYPES.UnaryExpression&&expr.argument.type===eslint_devkit_1.AST_NODE_TYPES.Literal||expr.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&expr.name==="undefined";if(isNonSecretLiteral(node.left)||isNonSecretLiteral(node.right)){return}const leftText=sourceCode.getText(node.left);const rightText=sourceCode.getText(node.right);const example=`crypto.timingSafeEqual(Buffer.from(${leftText}), Buffer.from(${rightText}))`;context.report({node,messageId:"timingUnsafeComparison",data:{operator:node.operator,strictOperator:node.operator,example},suggest:[{messageId:"useTimingSafeEqual",fix:fixer=>fixer.replaceText(node,example)}]});return}if(node.operator==="=="||node.operator==="!="){const text=sourceCode.getText(node);if(matchesIgnorePattern(text,ignorePatterns)){return}if(isNullLiteral(node.left)||isNullLiteral(node.right)){return}if(isStringTyped(node.left)&&isStringTyped(node.right)){return}const comparesSecret=isPotentialSecret(node.left)||isPotentialSecret(node.right);if(!reportLooseEquality&&!comparesSecret){return}const strictOperator=node.operator==="=="?"===":"!==";const leftText=sourceCode.getText(node.left);const rightText=sourceCode.getText(node.right);const example=`${leftText} ${strictOperator} ${rightText}`;context.report({node,messageId:"insecureComparison",data:{operator:node.operator,strictOperator,example},suggest:[{messageId:"useStrictEquality",fix:fixer=>{return fixer.replaceText(node,example)}}]})}}return{BinaryExpression:checkBinaryExpression}}});
@@ -1 +1 @@
1
- "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noUncheckedLoopCondition=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const eslint_devkit_3=require("@interlace/eslint-devkit");exports.noUncheckedLoopCondition=(0,eslint_devkit_1.createRule)({name:"no-unchecked-loop-condition",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-secure-coding/docs/rules/no-unchecked-loop-condition.md",description:"Detects unchecked loop conditions that could cause DoS",cwe:"CWE-400"},messages:{uncheckedLoopCondition:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Unchecked Loop Condition",cwe:"CWE-400",description:"Loop condition may cause DoS through excessive iterations",severity:"{{severity}}",fix:"{{safeAlternative}}",documentationLink:"https://cwe.mitre.org/data/definitions/400.html"}),infiniteLoop:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Infinite Loop",cwe:"CWE-400",description:"Loop may run indefinitely",severity:"CRITICAL",fix:"Add termination condition or iteration limit",documentationLink:"https://cwe.mitre.org/data/definitions/400.html"}),userControlledLoopBound:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"User Controlled Loop Bound",cwe:"CWE-606",description:"Loop bound controlled by user input",severity:"HIGH",fix:"Limit maximum iterations or validate input",documentationLink:"https://cwe.mitre.org/data/definitions/606.html"}),missingLoopTermination:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Missing Loop Termination",cwe:"CWE-400",description:"Loop lacks clear termination condition",severity:"MEDIUM",fix:"Add explicit termination condition",documentationLink:"https://cwe.mitre.org/data/definitions/400.html"}),largeLoopBound:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Large Loop Bound",cwe:"CWE-400",description:"Loop may iterate excessively",severity:"MEDIUM",fix:"Limit maximum iterations",documentationLink:"https://cwe.mitre.org/data/definitions/400.html"}),unsafeRecursion:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Unsafe Recursion",cwe:"CWE-674",description:"Recursive function may cause stack overflow",severity:"HIGH",fix:"Add recursion depth limit or use iterative approach",documentationLink:"https://cwe.mitre.org/data/definitions/674.html"})},schema:[{type:"object",properties:{maxStaticIterations:{type:"number",minimum:100,default:1e4,description:"Literal iteration count above which a loop is reported"},userInputVariables:{type:"array",items:{type:"string"},default:["req","request","body","query","params","input","data"],description:"Variable names treated as user-controlled input"},allowWhileTrueWithBreak:{type:"boolean",default:true,description:"Allow `while (true)` when the body contains a `break`"},maxRecursionDepth:{type:"number",minimum:1,default:10,description:"Recursion depth above which a call is reported"},trustedSanitizers:{type:"array",items:{type:"string"},default:[],description:"Additional function names to consider as loop protectors"},trustedAnnotations:{type:"array",items:{type:"string"},default:[],description:"Additional JSDoc annotations to consider as safe markers"},strictMode:{type:"boolean",default:false,description:"Disable all false positive detection (strict mode)"}},additionalProperties:false}]},defaultOptions:[{maxStaticIterations:1e4,userInputVariables:["req","request","body","query","params","input","data"],allowWhileTrueWithBreak:true,maxRecursionDepth:10,trustedSanitizers:[],trustedAnnotations:[],strictMode:false}],create(context){const options=context.options[0]||{};const{maxStaticIterations=1e4,userInputVariables=["req","request","body","query","params","input","data"],allowWhileTrueWithBreak=true,maxRecursionDepth=10,trustedSanitizers=[],trustedAnnotations=[],strictMode=false}=options;const sourceCode=context.sourceCode;const filename=context.filename;const safetyChecker=(0,eslint_devkit_3.createSafetyChecker)({trustedSanitizers,trustedAnnotations,trustedOrmPatterns:[],strictMode});const functionCalls=new Map;const reportedRecursion=new Set;const currentFunctionStack=[];const taintedVariables=new Set;const REQUEST_OBJECTS=new Set(["req","request","ctx","context","event"]);const isUserInput=varName=>{if(taintedVariables.has(varName)){return true}const lowerVarName=varName.toLowerCase();const isUsingDefaults=userInputVariables.length===7&&userInputVariables.includes("req")&&userInputVariables.includes("input");if(!isUsingDefaults){return userInputVariables.some(input=>lowerVarName===input.toLowerCase())}return REQUEST_OBJECTS.has(lowerVarName)};const checkIfCollectionIsValidated=(forOfNode,collection)=>{const guarded=collection;const validates=test=>{let sawArrayCheck=false;let sawLengthComparison=false;const walk=node=>{if(node.type==="CallExpression"&&node.callee.type==="MemberExpression"&&node.callee.object.type==="Identifier"&&node.callee.object.name==="Array"&&(0,eslint_devkit_1.propertyName)(node.callee)==="isArray"&&node.arguments.some(a=>a.type!=="SpreadElement"&&samePath(a,guarded))){sawArrayCheck=true}if(node.type==="BinaryExpression"&&["<","<=",">",">=","===","==","!==","!="].includes(node.operator)){for(const side of[node.left,node.right]){if(side.type==="MemberExpression"&&(0,eslint_devkit_1.propertyName)(side)==="length"&&samePath(side.object,guarded)){sawLengthComparison=true}}}const walkIfNode=value=>{if(value&&typeof value==="object"&&"type"in value)walk(value)};for(const key of["left","right","argument","expression","test","object","callee"]){walkIfNode(node[key])}const args=node.arguments;if(Array.isArray(args)){for(const a of args)walkIfNode(a)}};walk(test);return sawArrayCheck&&sawLengthComparison};for(let current=forOfNode.parent;current;current=current.parent){if(current.type==="IfStatement"&&validates(current.test))return true;if(current.type==="FunctionDeclaration"||current.type==="FunctionExpression"||current.type==="ArrowFunctionExpression"){break}}for(let current=forOfNode;current;current=current.parent){const parent=current.parent;if(parent?.type==="BlockStatement"||parent?.type==="Program"){const body=parent.body;const index=body.indexOf(current);for(const statement of body.slice(0,index)){if(statement.type==="IfStatement"&&validates(statement.test))return true}}if(current.type==="FunctionDeclaration"||current.type==="FunctionExpression"||current.type==="ArrowFunctionExpression"){break}}return false};const resolveVariable=node=>{const scope=sourceCode.getScope(node);for(let current=scope;current;current=current.upper){const variable=current.variables.find(v=>v.name===node.name);if(variable)return variable}return null};const samePath=(left,right)=>{const a=(0,eslint_devkit_3.unwrapTypeSyntax)(left);const b=(0,eslint_devkit_3.unwrapTypeSyntax)(right);if(a.type==="Identifier"&&b.type==="Identifier"){const va=resolveVariable(a);const vb=resolveVariable(b);return va||vb?va===vb:a.name===b.name}if(a.type==="MemberExpression"&&b.type==="MemberExpression"){return(0,eslint_devkit_1.propertyName)(a)===(0,eslint_devkit_1.propertyName)(b)&&samePath(a.object,b.object)}return false};const isClamped=node=>{const expression=(0,eslint_devkit_3.unwrapTypeSyntax)(node);if(expression.type==="CallExpression"&&expression.callee.type==="MemberExpression"&&!expression.callee.computed&&expression.callee.object.type==="Identifier"&&expression.callee.object.name==="Math"&&expression.callee.property.type==="Identifier"&&["min","max"].includes(expression.callee.property.name)){return true}if(expression.type==="BinaryExpression"||expression.type==="LogicalExpression"){return isClamped(expression.left)||isClamped(expression.right)}if(expression.type==="ConditionalExpression"){return isClamped(expression.consequent)&&isClamped(expression.alternate)}return false};const involvesUserInput=expression=>{const checkExpression=raw=>{const node=(0,eslint_devkit_3.unwrapTypeSyntax)(raw);if(node.type==="MemberExpression"){if((0,eslint_devkit_1.propertyName)(node)==="length"){return false}const objectText=sourceCode.getText(node.object);if(isUserInput(objectText)){return true}return checkExpression(node.object)}if(node.type==="Identifier"){return isUserInput(node.name)}if(node.type==="CallExpression"){return checkExpression(node.callee)||node.arguments.filter(arg=>arg.type!=="SpreadElement").some(arg=>checkExpression(arg))}if(node.type==="LogicalExpression"){return node.operator==="&&"?checkExpression(node.right):checkExpression(node.left)||checkExpression(node.right)}if(node.type==="BinaryExpression"){return checkExpression(node.left)||checkExpression(node.right)}if(node.type==="UpdateExpression"){return checkExpression(node.argument)}if(node.type==="UnaryExpression"){return checkExpression(node.argument)}return false};return checkExpression(expression)};const hasBreakStatement=loopBody=>{let hasBreak=false;const visited=new Set;const checkNode=(node,depth=0)=>{if(depth>10||visited.has(node)){return}visited.add(node);if(node.type==="BreakStatement"){hasBreak=true;return}for(const key in node){const child=node[key];if(child&&typeof child==="object"){if("type"in child){checkNode(child,depth+1)}else if(Array.isArray(child)){child.forEach(item=>{if(item&&typeof item==="object"&&"type"in item){checkNode(item,depth+1)}})}}}};checkNode(loopBody);return hasBreak};const isUnconditionalSelfCall=call=>{const BRANCHING=new Set(["IfStatement","ConditionalExpression","LogicalExpression","SwitchStatement","SwitchCase","ForStatement","ForInStatement","ForOfStatement","WhileStatement","DoWhileStatement","TryStatement","CatchClause"]);let child=call;for(let current=call.parent;current;child=current,current=current.parent){if(BRANCHING.has(current.type))return false;if(current.type==="BlockStatement"){const index=current.body.indexOf(child);const preceding=current.body.slice(0,index);if(preceding.some(statement=>statement.type==="IfStatement"&&exits(statement))){return false}}if(current.type==="FunctionDeclaration"||current.type==="FunctionExpression"||current.type==="ArrowFunctionExpression"){return true}}return false};const exits=node=>{if(node.type==="ReturnStatement"||node.type==="ThrowStatement")return true;for(const key in node){const child=node[key];if(key==="parent"||!child||typeof child!=="object")continue;if("type"in child){if(exits(child))return true}else if(Array.isArray(child)){for(const item of child){if(item&&typeof item==="object"&&"type"in item&&exits(item))return true}}}return false};const estimateIterations=loop=>{const test=loop.test;if(test&&test.type==="BinaryExpression"){if(test.operator==="<"||test.operator==="<="||test.operator===">"||test.operator===">="){const right=test.right;if(right.type==="Literal"&&typeof right.value==="number"){return Math.abs(right.value)}}}return null};return{VariableDeclaration(node){for(const declarator of node.declarations){if(declarator.id.type==="Identifier"&&declarator.init){const varName=declarator.id.name;const hasUserInput=involvesUserInput(declarator.init);const isSanitized=isClamped(declarator.init);if(hasUserInput&&!isSanitized){taintedVariables.add(varName)}}}},FunctionDeclaration(node){if(node.id){currentFunctionStack.push(node.id.name)}},"FunctionDeclaration:exit"(node){if(node.id&&currentFunctionStack[currentFunctionStack.length-1]===node.id.name){currentFunctionStack.pop()}},CallExpression(node){const callee=node.callee;if(callee.type==="Identifier"){const functionName=callee.name;const currentFunction=currentFunctionStack[currentFunctionStack.length-1];if(currentFunction&&functionName===currentFunction){const callCount=(functionCalls.get(functionName)||0)+1;functionCalls.set(functionName,callCount);if(!reportedRecursion.has(functionName)){if(callCount>maxRecursionDepth||isUnconditionalSelfCall(node)){if(safetyChecker.isSafe(node,context)){return}reportedRecursion.add(functionName);context.report({node,messageId:"unsafeRecursion",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}}}},WhileStatement(node){const test=node.test;if(test.type==="Literal"&&test.value===true){const hasBreak=hasBreakStatement(node.body);if(allowWhileTrueWithBreak&&hasBreak){return}context.report({node,messageId:"infiniteLoop",data:{filePath:filename,line:String(node.loc?.start.line??0)}});return}if(involvesUserInput(test)){if(safetyChecker.isSafe(node,context)){return}context.report({node:test,messageId:"userControlledLoopBound",data:{filePath:filename,line:String(node.loc?.start.line??0)}});return}},ForStatement(node){if(!node.test&&!node.update){if(safetyChecker.isSafe(node,context)){return}context.report({node,messageId:"infiniteLoop",data:{filePath:filename,line:String(node.loc?.start.line??0)}});return}if(!node.test){if(safetyChecker.isSafe(node,context)){return}context.report({node,messageId:"missingLoopTermination",data:{filePath:filename,line:String(node.loc?.start.line??0)}});return}if(involvesUserInput(node.test)){if(safetyChecker.isSafe(node,context)){return}context.report({node:node.test,messageId:"userControlledLoopBound",data:{filePath:filename,line:String(node.loc?.start.line??0)}});return}const estimatedIterations=estimateIterations(node);if(estimatedIterations&&estimatedIterations>maxStaticIterations){if(safetyChecker.isSafe(node,context)){return}context.report({node:node.test,messageId:"largeLoopBound",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}},DoWhileStatement(node){const test=node.test;if(involvesUserInput(test)){if(safetyChecker.isSafe(node,context)){return}context.report({node:test,messageId:"userControlledLoopBound",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}},ForInStatement(node){const right=node.right;if(involvesUserInput(right)){if(safetyChecker.isSafe(node,context)){return}context.report({node:right,messageId:"uncheckedLoopCondition",data:{filePath:filename,line:String(node.loc?.start.line??0),severity:"MEDIUM",safeAlternative:"Limit collection size or add iteration timeout"}})}},ForOfStatement(node){const right=node.right;if(involvesUserInput(right)){const isValidated=checkIfCollectionIsValidated(node,right);if(isValidated){return}if(safetyChecker.isSafe(node,context)){return}context.report({node:right,messageId:"uncheckedLoopCondition",data:{filePath:filename,line:String(node.loc?.start.line??0),severity:"MEDIUM",safeAlternative:"Limit collection size before iteration"}})}}}}});
1
+ "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noUncheckedLoopCondition=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const eslint_devkit_3=require("@interlace/eslint-devkit");exports.noUncheckedLoopCondition=(0,eslint_devkit_1.createRule)({name:"no-unchecked-loop-condition",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-secure-coding/docs/rules/no-unchecked-loop-condition.md",description:"Detects unchecked loop conditions that could cause DoS",cwe:"CWE-400"},messages:{uncheckedLoopCondition:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Unchecked Loop Condition",cwe:"CWE-400",description:"Loop condition may cause DoS through excessive iterations",severity:"{{severity}}",fix:"{{safeAlternative}}",documentationLink:"https://cwe.mitre.org/data/definitions/400.html"}),infiniteLoop:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Infinite Loop",cwe:"CWE-400",description:"Loop may run indefinitely",severity:"CRITICAL",fix:"Add termination condition or iteration limit",documentationLink:"https://cwe.mitre.org/data/definitions/400.html"}),userControlledLoopBound:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"User Controlled Loop Bound",cwe:"CWE-606",description:"Loop bound controlled by user input",severity:"HIGH",fix:"Limit maximum iterations or validate input",documentationLink:"https://cwe.mitre.org/data/definitions/606.html"}),missingLoopTermination:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Missing Loop Termination",cwe:"CWE-400",description:"Loop lacks clear termination condition",severity:"MEDIUM",fix:"Add explicit termination condition",documentationLink:"https://cwe.mitre.org/data/definitions/400.html"}),largeLoopBound:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Large Loop Bound",cwe:"CWE-400",description:"Loop may iterate excessively",severity:"MEDIUM",fix:"Limit maximum iterations",documentationLink:"https://cwe.mitre.org/data/definitions/400.html"}),unsafeRecursion:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Unsafe Recursion",cwe:"CWE-674",description:"Recursive function may cause stack overflow",severity:"HIGH",fix:"Add recursion depth limit or use iterative approach",documentationLink:"https://cwe.mitre.org/data/definitions/674.html"})},schema:[{type:"object",properties:{maxStaticIterations:{type:"number",minimum:100,default:1e4,description:"Literal iteration count above which a loop is reported"},userInputVariables:{type:"array",items:{type:"string"},default:["req","request","body","query","params","input","data"],description:"Variable names treated as user-controlled input"},allowWhileTrueWithBreak:{type:"boolean",default:true,description:"Allow `while (true)` when the body contains a `break`"},maxRecursionDepth:{type:"number",minimum:1,default:10,description:"Recursion depth above which a call is reported"},trustedSanitizers:{type:"array",items:{type:"string"},default:[],description:"Additional function names to consider as loop protectors"},trustedAnnotations:{type:"array",items:{type:"string"},default:[],description:"Additional JSDoc annotations to consider as safe markers"},strictMode:{type:"boolean",default:false,description:"Disable all false positive detection (strict mode)"}},additionalProperties:false}]},defaultOptions:[{maxStaticIterations:1e4,userInputVariables:["req","request","body","query","params","input","data"],allowWhileTrueWithBreak:true,maxRecursionDepth:10,trustedSanitizers:[],trustedAnnotations:[],strictMode:false}],create(context){const options=context.options[0]||{};const{maxStaticIterations=1e4,userInputVariables=["req","request","body","query","params","input","data"],allowWhileTrueWithBreak=true,maxRecursionDepth=10,trustedSanitizers=[],trustedAnnotations=[],strictMode=false}=options;const sourceCode=context.sourceCode;const filename=context.filename;const safetyChecker=(0,eslint_devkit_3.createSafetyChecker)({trustedSanitizers,trustedAnnotations,trustedOrmPatterns:[],strictMode});const functionCalls=new Map;const reportedRecursion=new Set;const currentFunctionStack=[];const taintedVariables=new Set;const REQUEST_OBJECTS=new Set(["req","request","ctx","context","event"]);const isUserInput=varName=>{if(taintedVariables.has(varName)){return true}const lowerVarName=varName.toLowerCase();const isUsingDefaults=userInputVariables.length===7&&userInputVariables.includes("req")&&userInputVariables.includes("input");if(!isUsingDefaults){return userInputVariables.some(input=>lowerVarName===input.toLowerCase())}return REQUEST_OBJECTS.has(lowerVarName)};const checkIfCollectionIsValidated=(forOfNode,collection)=>{const guarded=collection;const validates=test=>{let sawArrayCheck=false;let sawLengthComparison=false;const walk=node=>{if(node.type==="CallExpression"&&node.callee.type==="MemberExpression"&&node.callee.object.type==="Identifier"&&node.callee.object.name==="Array"&&(0,eslint_devkit_1.propertyName)(node.callee)==="isArray"&&node.arguments.some(a=>a.type!=="SpreadElement"&&samePath(a,guarded))){sawArrayCheck=true}if(node.type==="BinaryExpression"&&["<","<=",">",">=","===","==","!==","!="].includes(node.operator)){for(const side of[node.left,node.right]){if(side.type==="MemberExpression"&&(0,eslint_devkit_1.propertyName)(side)==="length"&&samePath(side.object,guarded)){sawLengthComparison=true}}}const walkIfNode=value=>{if(value&&typeof value==="object"&&"type"in value)walk(value)};for(const key of["left","right","argument","expression","test","object","callee"]){walkIfNode(node[key])}const args=node.arguments;if(Array.isArray(args)){for(const a of args)walkIfNode(a)}};walk(test);return sawArrayCheck&&sawLengthComparison};for(let current=forOfNode.parent;current;current=current.parent){if(current.type==="IfStatement"&&validates(current.test))return true;if(current.type==="FunctionDeclaration"||current.type==="FunctionExpression"||current.type==="ArrowFunctionExpression"){break}}for(let current=forOfNode;current;current=current.parent){const parent=current.parent;if(parent?.type==="BlockStatement"||parent?.type==="Program"){const body=parent.body;const index=body.indexOf(current);for(const statement of body.slice(0,index)){if(statement.type==="IfStatement"&&validates(statement.test))return true}}if(current.type==="FunctionDeclaration"||current.type==="FunctionExpression"||current.type==="ArrowFunctionExpression"){break}}return false};const resolveVariable=node=>{const scope=sourceCode.getScope(node);for(let current=scope;current;current=current.upper){const variable=current.variables.find(v=>v.name===node.name);if(variable)return variable}return null};const samePath=(left,right)=>{const a=(0,eslint_devkit_3.unwrapTypeSyntax)(left);const b=(0,eslint_devkit_3.unwrapTypeSyntax)(right);if(a.type==="Identifier"&&b.type==="Identifier"){const va=resolveVariable(a);const vb=resolveVariable(b);return va||vb?va===vb:a.name===b.name}if(a.type==="MemberExpression"&&b.type==="MemberExpression"){return(0,eslint_devkit_1.propertyName)(a)===(0,eslint_devkit_1.propertyName)(b)&&samePath(a.object,b.object)}return false};const isClamped=node=>{const expression=(0,eslint_devkit_3.unwrapTypeSyntax)(node);if(expression.type==="CallExpression"&&expression.callee.type==="MemberExpression"&&!expression.callee.computed&&expression.callee.object.type==="Identifier"&&expression.callee.object.name==="Math"&&expression.callee.property.type==="Identifier"&&["min","max"].includes(expression.callee.property.name)){return true}if(expression.type==="BinaryExpression"||expression.type==="LogicalExpression"){return isClamped(expression.left)||isClamped(expression.right)}if(expression.type==="ConditionalExpression"){return isClamped(expression.consequent)&&isClamped(expression.alternate)}return false};const involvesUserInput=expression=>{const checkExpression=raw=>{const node=(0,eslint_devkit_3.unwrapTypeSyntax)(raw);if(node.type==="MemberExpression"){if((0,eslint_devkit_1.propertyName)(node)==="length"){return false}const objectText=sourceCode.getText(node.object);if(isUserInput(objectText)){return true}return checkExpression(node.object)}if(node.type==="Identifier"){return isUserInput(node.name)}if(node.type==="CallExpression"){return checkExpression(node.callee)||node.arguments.filter(arg=>arg.type!=="SpreadElement").some(arg=>checkExpression(arg))}if(node.type==="LogicalExpression"){return node.operator==="&&"?checkExpression(node.right):checkExpression(node.left)||checkExpression(node.right)}if(node.type==="BinaryExpression"){return checkExpression(node.left)||checkExpression(node.right)}if(node.type==="UpdateExpression"){return checkExpression(node.argument)}if(node.type==="UnaryExpression"){return checkExpression(node.argument)}return false};return checkExpression(expression)};const hasBreakStatement=loopBody=>{let hasBreak=false;const visited=new Set;const checkNode=(node,depth=0)=>{if(depth>10||visited.has(node)){return}visited.add(node);if(node.type==="BreakStatement"){hasBreak=true;return}for(const key in node){const child=node[key];if(child&&typeof child==="object"){if("type"in child){checkNode(child,depth+1)}else if(Array.isArray(child)){child.forEach(item=>{if(item&&typeof item==="object"&&"type"in item){checkNode(item,depth+1)}})}}}};checkNode(loopBody);return hasBreak};const hasLoopExit=loopBody=>{let found=false;const innerLabels=new Set;const walk=(node,insideNestedBreakable)=>{if(found)return;switch(node.type){case"FunctionDeclaration":case"FunctionExpression":case"ArrowFunctionExpression":return;case"BreakStatement":if(node.label===null){if(!insideNestedBreakable)found=true}else if(!innerLabels.has(node.label.name)){found=true}return;case"ReturnStatement":case"ThrowStatement":found=true;return;default:break}if(node.type==="LabeledStatement")innerLabels.add(node.label.name);const breakable=insideNestedBreakable||node.type==="ForStatement"||node.type==="ForInStatement"||node.type==="ForOfStatement"||node.type==="WhileStatement"||node.type==="DoWhileStatement"||node.type==="SwitchStatement";for(const key of Object.keys(node)){if(key==="parent")continue;const child=node[key];if(child===null||typeof child!=="object")continue;if(Array.isArray(child)){for(const item of child){if(item!==null&&typeof item==="object"&&"type"in item){walk(item,breakable)}}}else if("type"in child){walk(child,breakable)}}};walk(loopBody,false);return found};const isUnconditionalSelfCall=call=>{const BRANCHING=new Set(["IfStatement","ConditionalExpression","LogicalExpression","SwitchStatement","SwitchCase","ForStatement","ForInStatement","ForOfStatement","WhileStatement","DoWhileStatement","TryStatement","CatchClause"]);let child=call;for(let current=call.parent;current;child=current,current=current.parent){if(BRANCHING.has(current.type))return false;if(current.type==="BlockStatement"){const index=current.body.indexOf(child);const preceding=current.body.slice(0,index);if(preceding.some(statement=>statement.type==="IfStatement"&&exits(statement))){return false}}if(current.type==="FunctionDeclaration"||current.type==="FunctionExpression"||current.type==="ArrowFunctionExpression"){return true}}return false};const exits=node=>{if(node.type==="ReturnStatement"||node.type==="ThrowStatement")return true;for(const key in node){const child=node[key];if(key==="parent"||!child||typeof child!=="object")continue;if("type"in child){if(exits(child))return true}else if(Array.isArray(child)){for(const item of child){if(item&&typeof item==="object"&&"type"in item&&exits(item))return true}}}return false};const estimateIterations=loop=>{const test=loop.test;if(test&&test.type==="BinaryExpression"){if(test.operator==="<"||test.operator==="<="||test.operator===">"||test.operator===">="){const right=test.right;if(right.type==="Literal"&&typeof right.value==="number"){return Math.abs(right.value)}}}return null};return{VariableDeclaration(node){for(const declarator of node.declarations){if(declarator.id.type==="Identifier"&&declarator.init){const varName=declarator.id.name;const hasUserInput=involvesUserInput(declarator.init);const isSanitized=isClamped(declarator.init);if(hasUserInput&&!isSanitized){taintedVariables.add(varName)}}}},FunctionDeclaration(node){if(node.id){currentFunctionStack.push(node.id.name)}},"FunctionDeclaration:exit"(node){if(node.id&&currentFunctionStack[currentFunctionStack.length-1]===node.id.name){currentFunctionStack.pop()}},CallExpression(node){const callee=node.callee;if(callee.type==="Identifier"){const functionName=callee.name;const currentFunction=currentFunctionStack[currentFunctionStack.length-1];if(currentFunction&&functionName===currentFunction){const callCount=(functionCalls.get(functionName)||0)+1;functionCalls.set(functionName,callCount);if(!reportedRecursion.has(functionName)){if(callCount>maxRecursionDepth||isUnconditionalSelfCall(node)){if(safetyChecker.isSafe(node,context)){return}reportedRecursion.add(functionName);context.report({node,messageId:"unsafeRecursion",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}}}},WhileStatement(node){const test=node.test;if(test.type==="Literal"&&test.value===true){const hasBreak=hasBreakStatement(node.body);if(allowWhileTrueWithBreak&&hasBreak){return}context.report({node,messageId:"infiniteLoop",data:{filePath:filename,line:String(node.loc?.start.line??0)}});return}if(involvesUserInput(test)){if(safetyChecker.isSafe(node,context)){return}context.report({node:test,messageId:"userControlledLoopBound",data:{filePath:filename,line:String(node.loc?.start.line??0)}});return}},ForStatement(node){if(!node.test&&!node.update){if(safetyChecker.isSafe(node,context)){return}if(allowWhileTrueWithBreak&&hasLoopExit(node.body)){return}context.report({node,messageId:"infiniteLoop",data:{filePath:filename,line:String(node.loc?.start.line??0)}});return}if(!node.test){if(safetyChecker.isSafe(node,context)){return}context.report({node,messageId:"missingLoopTermination",data:{filePath:filename,line:String(node.loc?.start.line??0)}});return}if(involvesUserInput(node.test)){if(safetyChecker.isSafe(node,context)){return}context.report({node:node.test,messageId:"userControlledLoopBound",data:{filePath:filename,line:String(node.loc?.start.line??0)}});return}const estimatedIterations=estimateIterations(node);if(estimatedIterations&&estimatedIterations>maxStaticIterations){if(safetyChecker.isSafe(node,context)){return}context.report({node:node.test,messageId:"largeLoopBound",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}},DoWhileStatement(node){const test=node.test;if(involvesUserInput(test)){if(safetyChecker.isSafe(node,context)){return}context.report({node:test,messageId:"userControlledLoopBound",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}},ForInStatement(node){const right=node.right;if(involvesUserInput(right)){if(safetyChecker.isSafe(node,context)){return}context.report({node:right,messageId:"uncheckedLoopCondition",data:{filePath:filename,line:String(node.loc?.start.line??0),severity:"MEDIUM",safeAlternative:"Limit collection size or add iteration timeout"}})}},ForOfStatement(node){const right=node.right;if(involvesUserInput(right)){const isValidated=checkIfCollectionIsValidated(node,right);if(isValidated){return}if(safetyChecker.isSafe(node,context)){return}context.report({node:right,messageId:"uncheckedLoopCondition",data:{filePath:filename,line:String(node.loc?.start.line??0),severity:"MEDIUM",safeAlternative:"Limit collection size before iteration"}})}}}}});