eslint-plugin-secure-coding 4.0.0 → 4.2.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +2 -0
- package/package.json +3 -2
- package/src/index.js +1 -1
- package/src/rules/detect-object-injection/index.js +1 -1
- package/src/rules/no-bidi-characters/index.js +1 -0
- package/src/rules/no-directive-injection/index.js +1 -1
- package/src/rules/no-electron-security-issues/index.js +1 -1
- package/src/rules/no-format-string-injection/index.js +1 -1
- package/src/rules/no-graphql-injection/index.js +1 -1
- package/src/rules/no-insecure-comparison/index.js +1 -1
- package/src/rules/no-missing-authentication/index.js +1 -1
- package/src/rules/no-unsafe-regex-construction/index.js +1 -1
package/README.md
CHANGED
|
@@ -123,6 +123,7 @@ See the [ESLint Version Support Policy](../../docs/ESLINT_VERSION_SUPPORT.md)
|
|
|
123
123
|
| [detect-non-literal-regexp](https://eslint.interlace.tools/docs/security/plugin-secure-coding/rules/detect-non-literal-regexp?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-secure-coding) | CWE-400 | | | Detects RegExp(variable), which might allow an attacker to DOS your server with a long-running regular expr… | 🟢 | | | | | |
|
|
124
124
|
| [detect-object-injection](https://eslint.interlace.tools/docs/security/plugin-secure-coding/rules/detect-object-injection?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-secure-coding) | CWE-915 | | | Detects variable[key] as a left- or right-hand assignment operand (prototype pollution) | 🟡 | | | | | |
|
|
125
125
|
| [detect-weak-password-validation](https://eslint.interlace.tools/docs/security/plugin-secure-coding/rules/detect-weak-password-validation?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-secure-coding) | CWE-521 | A07:2021 | | Detects weak password length requirements (less than 8 characters) in validation code. | 🟢 | | | | | |
|
|
126
|
+
| [no-bidi-characters](https://eslint.interlace.tools/docs/security/plugin-secure-coding/rules/no-bidi-characters?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-secure-coding) | CWE-1007 | | | Disallows Unicode bidirectional control characters, which let source render differently than it compiles (T… | 🟢 | | | | | |
|
|
126
127
|
| [no-directive-injection](https://eslint.interlace.tools/docs/security/plugin-secure-coding/rules/no-directive-injection?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-secure-coding) | CWE-94 | | | Detects directive injection vulnerabilities in template systems | 🟢 | | | | | |
|
|
127
128
|
| [no-electron-security-issues](https://eslint.interlace.tools/docs/security/plugin-secure-coding/rules/no-electron-security-issues?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-secure-coding) | CWE-16 | | | Detects Electron security vulnerabilities and insecure configurations | 🟢 | | | | | |
|
|
128
129
|
| [no-fail-open-auth](https://eslint.interlace.tools/docs/security/plugin-secure-coding/rules/no-fail-open-auth?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-secure-coding) | CWE-636 | A10:2025 | | Detects authentication and authorization checks whose catch block fails open | 🟢 | 💼 | | | | |
|
|
@@ -142,6 +143,7 @@ See the [ESLint Version Support Policy](../../docs/ESLINT_VERSION_SUPPORT.md)
|
|
|
142
143
|
| [no-redos-vulnerable-regex](https://eslint.interlace.tools/docs/security/plugin-secure-coding/rules/no-redos-vulnerable-regex?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-secure-coding) | CWE-400 | | | ESLint Rule: no-redos-vulnerable-regex | 🟢 | 💼 | | | | |
|
|
143
144
|
| [no-sensitive-data-exposure](https://eslint.interlace.tools/docs/security/plugin-secure-coding/rules/no-sensitive-data-exposure?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-secure-coding) | CWE-532 | | | ESLint Rule: no-sensitive-data-exposure | 🟢 | | ⚠️ | | | |
|
|
144
145
|
| [no-sql-injection](https://eslint.interlace.tools/docs/security/plugin-secure-coding/rules/no-sql-injection?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-secure-coding) | CWE-89 | A03:2021 | | Detects SQL statements built from attacker-controlled input in files that import no SQL driver | 🟢 | 💼 | | | | |
|
|
146
|
+
| [no-template-injection](https://eslint.interlace.tools/docs/security/plugin-secure-coding/rules/no-template-injection?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-secure-coding) | CWE-94 | A03:2021 | | Disallow dynamic strings as template arguments to server-side template engines (CWE-94) | 🟢 | 💼 | | | | |
|
|
145
147
|
| [no-unchecked-loop-condition](https://eslint.interlace.tools/docs/security/plugin-secure-coding/rules/no-unchecked-loop-condition?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-secure-coding) | CWE-400 | | | Detects unchecked loop conditions that could cause DoS | 🟢 | | | | | |
|
|
146
148
|
| [no-unlimited-resource-allocation](https://eslint.interlace.tools/docs/security/plugin-secure-coding/rules/no-unlimited-resource-allocation?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-secure-coding) | CWE-770 | | | Detects unlimited resource allocation that could cause DoS | 🟢 | | ⚠️ | | | |
|
|
147
149
|
| [no-unsafe-deserialization](https://eslint.interlace.tools/docs/security/plugin-secure-coding/rules/no-unsafe-deserialization?utm_source=github&utm_medium=referral&utm_campaign=eslint-plugin-secure-coding) | CWE-502 | | | Detects unsafe deserialization of untrusted data | 🟢 | | ⚠️ | | | |
|
package/package.json
CHANGED
|
@@ -1,11 +1,12 @@
|
|
|
1
1
|
{
|
|
2
2
|
"name": "eslint-plugin-secure-coding",
|
|
3
|
-
"version": "4.
|
|
3
|
+
"version": "4.2.0",
|
|
4
4
|
"description": "ESLint plugin for secure coding — detects LDAP, XPath, XXE, GraphQL and template injection, unsafe deserialization, ReDoS, missing authentication, and PII in logs.",
|
|
5
5
|
"type": "commonjs",
|
|
6
6
|
"main": "./src/index.js",
|
|
7
7
|
"types": "./src/index.d.ts",
|
|
8
8
|
"exports": {
|
|
9
|
+
"./package.json": "./package.json",
|
|
9
10
|
".": {
|
|
10
11
|
"types": "./src/index.d.ts",
|
|
11
12
|
"default": "./src/index.js"
|
|
@@ -77,7 +78,7 @@
|
|
|
77
78
|
"node": ">=18.0.0"
|
|
78
79
|
},
|
|
79
80
|
"dependencies": {
|
|
80
|
-
"@interlace/eslint-devkit": "^1.
|
|
81
|
+
"@interlace/eslint-devkit": "^1.15.0",
|
|
81
82
|
"scslre": "^0.3.0",
|
|
82
83
|
"@eslint-community/regexpp": "^4.10.0"
|
|
83
84
|
},
|
package/src/index.js
CHANGED
|
@@ -1 +1 @@
|
|
|
1
|
-
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.configs=exports.plugin=exports.rules=void 0;exports.rules={get"no-graphql-injection"(){return require("./rules/no-graphql-injection").noGraphqlInjection},get"no-xxe-injection"(){return require("./rules/no-xxe-injection").noXxeInjection},get"no-xpath-injection"(){return require("./rules/no-xpath-injection").noXpathInjection},get"no-ldap-injection"(){return require("./rules/no-ldap-injection").noLdapInjection},get"no-directive-injection"(){return require("./rules/no-directive-injection").noDirectiveInjection},get"no-format-string-injection"(){return require("./rules/no-format-string-injection").noFormatStringInjection},get"no-template-injection"(){return require("./rules/no-template-injection").noTemplateInjection},get"no-sql-injection"(){return require("./rules/no-sql-injection").noSqlInjection},get"no-log-injection"(){return require("./rules/no-log-injection").noLogInjection},get"no-fail-open-auth"(){return require("./rules/no-fail-open-auth").noFailOpenAuth},get"no-homoglyph-identifiers"(){return require("./rules/no-homoglyph-identifiers").noHomoglyphIdentifiers},get"detect-non-literal-regexp"(){return require("./rules/detect-non-literal-regexp").detectNonLiteralRegexp},get"no-redos-vulnerable-regex"(){return require("./rules/no-redos-vulnerable-regex").noRedosVulnerableRegex},get"no-unsafe-regex-construction"(){return require("./rules/no-unsafe-regex-construction").noUnsafeRegexConstruction},get"detect-object-injection"(){return require("./rules/detect-object-injection").detectObjectInjection},get"no-unsafe-deserialization"(){return require("./rules/no-unsafe-deserialization").noUnsafeDeserialization},get"no-insecure-comparison"(){return require("./rules/no-insecure-comparison").noInsecureComparison},get"no-improper-sanitization"(){return require("./rules/no-improper-sanitization").noImproperSanitization},get"no-improper-type-validation"(){return require("./rules/no-improper-type-validation").noImproperTypeValidation},get"no-missing-authentication"(){return require("./rules/no-missing-authentication").noMissingAuthentication},get"no-privilege-escalation"(){return require("./rules/no-privilege-escalation").noPrivilegeEscalation},get"no-weak-password-recovery"(){return require("./rules/no-weak-password-recovery").noWeakPasswordRecovery},get"require-backend-authorization"(){return require("./rules/require-backend-authorization").requireBackendAuthorization},get"no-hardcoded-credentials"(){return require("./rules/no-hardcoded-credentials").noHardcodedCredentials},get"no-sensitive-data-exposure"(){return require("./rules/no-sensitive-data-exposure").noSensitiveDataExposure},get"no-pii-in-logs"(){return require("./rules/no-pii-in-logs").noPiiInLogs},get"no-unlimited-resource-allocation"(){return require("./rules/no-unlimited-resource-allocation").noUnlimitedResourceAllocation},get"no-unchecked-loop-condition"(){return require("./rules/no-unchecked-loop-condition").noUncheckedLoopCondition},get"detect-weak-password-validation"(){return require("./rules/detect-weak-password-validation").detectWeakPasswordValidation},get"no-electron-security-issues"(){return require("./rules/no-electron-security-issues").noElectronSecurityIssues},get"no-hardcoded-session-tokens"(){return require("./rules/no-hardcoded-session-tokens").noHardcodedSessionTokens},get"require-secure-defaults"(){return require("./rules/require-secure-defaults").requireSecureDefaults}};exports.plugin={meta:{name:"eslint-plugin-secure-coding",version:"4.
|
|
1
|
+
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.configs=exports.plugin=exports.rules=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");exports.rules={get"no-graphql-injection"(){return require("./rules/no-graphql-injection").noGraphqlInjection},get"no-xxe-injection"(){return require("./rules/no-xxe-injection").noXxeInjection},get"no-xpath-injection"(){return require("./rules/no-xpath-injection").noXpathInjection},get"no-ldap-injection"(){return require("./rules/no-ldap-injection").noLdapInjection},get"no-directive-injection"(){return require("./rules/no-directive-injection").noDirectiveInjection},get"no-format-string-injection"(){return require("./rules/no-format-string-injection").noFormatStringInjection},get"no-template-injection"(){return require("./rules/no-template-injection").noTemplateInjection},get"no-sql-injection"(){return require("./rules/no-sql-injection").noSqlInjection},get"no-log-injection"(){return require("./rules/no-log-injection").noLogInjection},get"no-fail-open-auth"(){return require("./rules/no-fail-open-auth").noFailOpenAuth},get"no-homoglyph-identifiers"(){return require("./rules/no-homoglyph-identifiers").noHomoglyphIdentifiers},get"detect-non-literal-regexp"(){return require("./rules/detect-non-literal-regexp").detectNonLiteralRegexp},get"no-redos-vulnerable-regex"(){return require("./rules/no-redos-vulnerable-regex").noRedosVulnerableRegex},get"no-unsafe-regex-construction"(){return require("./rules/no-unsafe-regex-construction").noUnsafeRegexConstruction},get"detect-object-injection"(){return require("./rules/detect-object-injection").detectObjectInjection},get"no-unsafe-deserialization"(){return require("./rules/no-unsafe-deserialization").noUnsafeDeserialization},get"no-insecure-comparison"(){return require("./rules/no-insecure-comparison").noInsecureComparison},get"no-improper-sanitization"(){return require("./rules/no-improper-sanitization").noImproperSanitization},get"no-improper-type-validation"(){return require("./rules/no-improper-type-validation").noImproperTypeValidation},get"no-missing-authentication"(){return require("./rules/no-missing-authentication").noMissingAuthentication},get"no-privilege-escalation"(){return require("./rules/no-privilege-escalation").noPrivilegeEscalation},get"no-weak-password-recovery"(){return require("./rules/no-weak-password-recovery").noWeakPasswordRecovery},get"require-backend-authorization"(){return require("./rules/require-backend-authorization").requireBackendAuthorization},get"no-hardcoded-credentials"(){return require("./rules/no-hardcoded-credentials").noHardcodedCredentials},get"no-sensitive-data-exposure"(){return require("./rules/no-sensitive-data-exposure").noSensitiveDataExposure},get"no-pii-in-logs"(){return require("./rules/no-pii-in-logs").noPiiInLogs},get"no-unlimited-resource-allocation"(){return require("./rules/no-unlimited-resource-allocation").noUnlimitedResourceAllocation},get"no-unchecked-loop-condition"(){return require("./rules/no-unchecked-loop-condition").noUncheckedLoopCondition},get"detect-weak-password-validation"(){return require("./rules/detect-weak-password-validation").detectWeakPasswordValidation},get"no-electron-security-issues"(){return require("./rules/no-electron-security-issues").noElectronSecurityIssues},get"no-hardcoded-session-tokens"(){return require("./rules/no-hardcoded-session-tokens").noHardcodedSessionTokens},get"require-secure-defaults"(){return require("./rules/require-secure-defaults").requireSecureDefaults},get"no-bidi-characters"(){return require("./rules/no-bidi-characters").noBidiCharacters}};(0,eslint_devkit_1.withCanonicalDocsUrls)("plugin-secure-coding",exports.rules);exports.plugin={meta:{name:"eslint-plugin-secure-coding",version:"4.2.0"},rules:exports.rules};const recommendedRules={"secure-coding/no-graphql-injection":"warn","secure-coding/no-xxe-injection":"error","secure-coding/no-xpath-injection":"error","secure-coding/no-ldap-injection":"error","secure-coding/no-sql-injection":"error","secure-coding/no-log-injection":"error","secure-coding/no-fail-open-auth":"error","secure-coding/no-homoglyph-identifiers":"error","secure-coding/no-unsafe-deserialization":"warn","secure-coding/no-redos-vulnerable-regex":"error","secure-coding/no-unsafe-regex-construction":"error","secure-coding/no-hardcoded-credentials":"error","secure-coding/no-template-injection":"error","secure-coding/no-improper-sanitization":"error","secure-coding/no-privilege-escalation":"warn","secure-coding/no-weak-password-recovery":"warn","secure-coding/no-sensitive-data-exposure":"warn","secure-coding/no-unlimited-resource-allocation":"warn"};exports.configs={flagship:{plugins:{"secure-coding":exports.plugin},rules:{"secure-coding/no-hardcoded-credentials":"error","secure-coding/no-redos-vulnerable-regex":"error"}},recommended:{plugins:{"secure-coding":exports.plugin},rules:recommendedRules},"recommended-strict":{plugins:{"secure-coding":exports.plugin},rules:Object.fromEntries(Object.keys(recommendedRules).map(rule=>[rule,"error"]))},strict:{plugins:{"secure-coding":exports.plugin},rules:Object.fromEntries(Object.keys(exports.rules).map(ruleName=>[`secure-coding/${ruleName}`,"error"]))},"owasp-top-10":{plugins:{"secure-coding":exports.plugin},rules:{"secure-coding/no-privilege-escalation":"warn","secure-coding/no-hardcoded-credentials":"error","secure-coding/no-sensitive-data-exposure":"warn","secure-coding/no-graphql-injection":"error","secure-coding/no-xxe-injection":"error","secure-coding/no-xpath-injection":"error","secure-coding/no-ldap-injection":"error","secure-coding/no-weak-password-recovery":"error","secure-coding/no-improper-type-validation":"error","secure-coding/no-unsafe-deserialization":"error"}}};exports.default=exports.plugin;
|
|
@@ -1 +1 @@
|
|
|
1
|
-
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.detectObjectInjection=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const eslint_devkit_3=require("@interlace/eslint-devkit");const fileUsesAstTooling=(0,eslint_devkit_3.createModuleEvidence)({packages:["@babel/types","@babel/traverse","recast","jscodeshift","eslint","estree-walker","ast-types","esrap","unist-util-visit"],scopes:["@typescript-eslint"]});const TYPED_ARRAY_CTORS=new Set(["Int8Array","Uint8Array","Uint8ClampedArray","Int16Array","Uint16Array","Int32Array","Uint32Array","Float32Array","Float64Array","BigInt64Array","BigUint64Array"]);const OBJECT_INJECTION_PATTERNS=[{pattern:"__proto__",dangerous:true,vulnerability:"prototype-pollution",safeAlternative:"Object.create(null) or Map",example:{bad:'obj[userInput] = value; // if userInput is "__proto__"',good:"const map = new Map(); map.set(userInput, value);"},effort:"15-20 minutes",riskLevel:"critical"},{pattern:"prototype",dangerous:true,vulnerability:"prototype-pollution",safeAlternative:"Avoid prototype manipulation",example:{bad:'obj[userInput] = value; // if userInput is "prototype"',good:"if (!obj.hasOwnProperty(userInput)) obj[userInput] = value;"},effort:"10-15 minutes",riskLevel:"high"},{pattern:"constructor",dangerous:true,vulnerability:"method-injection",safeAlternative:"Validate property names against whitelist",example:{bad:'obj[userInput] = value; // if userInput is "constructor"',good:"const ALLOWED_KEYS = ['name', 'age', 'email']; if (ALLOWED_KEYS.includes(userInput)) obj[userInput] = value;"},effort:"10-15 minutes",riskLevel:"medium"}];exports.detectObjectInjection=(0,eslint_devkit_3.createRule)({name:"detect-object-injection",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-secure-coding/docs/rules/detect-object-injection.md",description:"Detects variable[key] as a left- or right-hand assignment operand",cwe:"CWE-915",confidence:"low"},hasSuggestions:true,messages:{objectInjection:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.WARNING,issueName:"Object injection",cwe:"CWE-915",description:"Object injection/Prototype pollution (incl. model/tool outputs)",severity:"{{riskLevel}}",fix:"{{safeAlternative}}",documentationLink:"https://portswigger.net/web-security/prototype-pollution"}),useMapInstead:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Use Map",description:"Use Map instead of plain objects",severity:"LOW",fix:"const map = new Map(); map.set(key, value);",documentationLink:"https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Map"}),useHasOwnProperty:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Use hasOwnProperty",description:"Check hasOwnProperty to avoid prototype properties",severity:"LOW",fix:"if (obj.hasOwnProperty(key)) { obj[key] = value; }",documentationLink:"https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/hasOwnProperty"}),whitelistKeys:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Whitelist Keys",description:"Whitelist allowed property names",severity:"LOW",fix:'const ALLOWED = ["name", "email"]; if (ALLOWED.includes(key)) obj[key] = value; // reject model/tool-supplied unknown keys',documentationLink:"https://portswigger.net/web-security/prototype-pollution"}),useObjectCreate:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Use Object.create(null)",description:"Create clean objects without prototypes",severity:"LOW",fix:"const obj = Object.create(null);",documentationLink:"https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/create"}),freezePrototypes:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Freeze Prototypes",description:"Freeze Object.prototype to prevent pollution",severity:"LOW",fix:"Object.freeze(Object.prototype);",documentationLink:"https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/freeze"}),strategyValidate:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Validate Input",description:"Add input validation before property access",severity:"LOW",fix:"Validate key against allowed values before access",documentationLink:"https://portswigger.net/web-security/prototype-pollution"}),strategyWhitelist:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Whitelist Properties",description:"Whitelist allowed property names only",severity:"LOW",fix:"Define allowed keys and validate against them",documentationLink:"https://portswigger.net/web-security/prototype-pollution"}),strategyFreeze:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Freeze Prototypes",description:"Freeze prototypes to prevent pollution",severity:"LOW",fix:"Object.freeze(Object.prototype) at app startup",documentationLink:"https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/freeze"})},schema:[{type:"object",properties:{allowLiterals:{type:"boolean",default:false,description:"Allow bracket notation with literal strings"},additionalMethods:{type:"array",items:{type:"string"},default:[],description:"Additional object methods to check for injection"},dangerousProperties:{type:"array",items:{type:"string"},default:["__proto__","prototype","constructor"],description:"Properties to consider dangerous"},strategy:{type:"string",enum:["validate","whitelist","freeze","auto"],default:"auto",description:"Strategy for fixing object injection (auto = smart detection)"}},additionalProperties:false}]},defaultOptions:[{allowLiterals:false,additionalMethods:[],dangerousProperties:["__proto__","prototype","constructor"],strategy:"auto"}],create(context){const options=context.options[0]||{};const{allowLiterals:_allowLiterals=false,dangerousProperties=["__proto__","prototype","constructor"]}=options;const handledMemberExpressions=new WeakSet;const sourceCode=context.sourceCode;const isInCodemodContext=(()=>{const filename=context.filename;if(/\/codemod[s]?\//i.test(filename))return true;if(/codemod\.[mc]?[jt]sx?$/i.test(filename))return true;return fileUsesAstTooling(sourceCode.ast)})();const isTestFile=(()=>{const f=context.filename;return/\.test\.[mc]?[jt]sx?$/.test(f)||/\.spec\.[mc]?[jt]sx?$/.test(f)||/\/__tests__\//.test(f)||/\/test\//.test(f)||/\.fixture\.[mc]?[jt]sx?$/.test(f)})();const isLiteralString=node=>{return node.type===eslint_devkit_1.AST_NODE_TYPES.Literal&&typeof node.value==="string"};const hasPrecedingValidation=(propertyNode,node)=>{if(propertyNode.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier){return false}const keyName=propertyNode.name;const isIncludesCall=testNode=>{if(testNode.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression&&testNode.callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&testNode.callee.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&testNode.callee.property.name==="includes"&&testNode.arguments.length>0&&testNode.arguments[0].type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&testNode.arguments[0].name===keyName){return true}if(testNode.type===eslint_devkit_1.AST_NODE_TYPES.UnaryExpression&&testNode.operator==="!"&&testNode.argument.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression){return isIncludesCall(testNode.argument)}return false};const isHasOwnPropertyCall=testNode=>{if(testNode.type!==eslint_devkit_1.AST_NODE_TYPES.CallExpression)return false;const callee=testNode.callee;const args=testNode.arguments;if(callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&callee.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&callee.property.name==="call"&&args.length>=2&&args[1].type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&args[1].name===keyName){return true}if(callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&callee.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&(callee.property.name==="hasOwnProperty"||callee.property.name==="hasOwn")){const keyArg=callee.property.name==="hasOwn"?args[1]:args[0];if(keyArg?.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&keyArg.name===keyName){return true}}return false};const isInOperator=testNode=>{return testNode.type===eslint_devkit_1.AST_NODE_TYPES.BinaryExpression&&testNode.operator==="in"&&testNode.left.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&testNode.left.name===keyName};const hasValidation=testNode=>{return isIncludesCall(testNode)||isHasOwnPropertyCall(testNode)||isInOperator(testNode)};const hasEarlyExit=consequent=>{if(consequent.type===eslint_devkit_1.AST_NODE_TYPES.BlockStatement){return consequent.body.some(stmt=>stmt.type===eslint_devkit_1.AST_NODE_TYPES.ThrowStatement||stmt.type===eslint_devkit_1.AST_NODE_TYPES.ReturnStatement)}return consequent.type===eslint_devkit_1.AST_NODE_TYPES.ThrowStatement||consequent.type===eslint_devkit_1.AST_NODE_TYPES.ReturnStatement};let current=node.parent;let foundFunctionBody=false;while(current&&!foundFunctionBody){if(current.type===eslint_devkit_1.AST_NODE_TYPES.IfStatement){if(hasValidation(current.test)){return true}}if(current.type===eslint_devkit_1.AST_NODE_TYPES.BlockStatement&¤t.parent&&(current.parent.type===eslint_devkit_1.AST_NODE_TYPES.FunctionDeclaration||current.parent.type===eslint_devkit_1.AST_NODE_TYPES.FunctionExpression||current.parent.type===eslint_devkit_1.AST_NODE_TYPES.ArrowFunctionExpression)){foundFunctionBody=true;const blockBody=current.body;const nodeIndex=blockBody.findIndex(stmt=>{let check=node;while(check){if(check===stmt)return true;check=check.parent}return false});for(let i=0;i<nodeIndex;i++){const stmt=blockBody[i];if(stmt.type===eslint_devkit_1.AST_NODE_TYPES.IfStatement&&hasValidation(stmt.test)&&hasEarlyExit(stmt.consequent)){return true}}}current=current.parent}return false};const hasDisqualifyingLiteralAffix=node=>{if(node.type!==eslint_devkit_1.AST_NODE_TYPES.BinaryExpression||node.operator!=="+"){return false}const bin=node;const literalText=n=>{if(n.type!==eslint_devkit_1.AST_NODE_TYPES.Literal)return null;const v=n.value;if(typeof v!=="string"&&typeof v!=="number")return null;const s=String(v);return s.length>0?s:null};const prefix=literalText(bin.left);if(prefix!==null&&!dangerousProperties.some(d=>d.startsWith(prefix))){return true}const suffix=literalText(bin.right);if(suffix!==null&&!dangerousProperties.some(d=>d.endsWith(suffix))){return true}return false};const isDangerousPropertyAccess=propertyNode=>{if(isNumericKey(propertyNode)||hasDisqualifyingLiteralAffix(propertyNode)){return false}if(propertyNode.type===eslint_devkit_1.AST_NODE_TYPES.Identifier){const name=propertyNode.name;if(/^[A-Z][A-Z0-9_]{2,}$/.test(name)){return false}if(/^[a-z]/.test(name)&&/(?:Code|Status|Version|Kind|Mode|Type|Stage|Level|Phase|Step|Flag|Num|Count)$/.test(name)){return false}}if(isLiteralString(propertyNode)){const propName=String(propertyNode.value);if(dangerousProperties.includes(propName)){return true}return false}return true};const isPrototypelessObject=objectNode=>{if(objectNode.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier){return false}const varName=objectNode.name;let current=objectNode;while(current){if(current.type===eslint_devkit_1.AST_NODE_TYPES.BlockStatement||current.type===eslint_devkit_1.AST_NODE_TYPES.Program){const statements=current.type===eslint_devkit_1.AST_NODE_TYPES.BlockStatement?current.body:current.body;for(const stmt of statements){if(stmt.type===eslint_devkit_1.AST_NODE_TYPES.VariableDeclaration){for(const decl of stmt.declarations){if(decl.id.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&decl.id.name===varName&&decl.init){if(decl.init.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression&&decl.init.callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&decl.init.callee.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&decl.init.callee.object.name==="Object"&&decl.init.callee.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&decl.init.callee.property.name==="create"&&decl.init.arguments.length>0&&decl.init.arguments[0].type===eslint_devkit_1.AST_NODE_TYPES.Literal&&decl.init.arguments[0].value===null){return true}if(decl.init.type===eslint_devkit_1.AST_NODE_TYPES.ArrayExpression&&decl.init.elements.length>0&&decl.init.elements[0]?.type===eslint_devkit_1.AST_NODE_TYPES.SpreadElement){return true}}}}}}current=current.parent}return false};const extractPropertyAccess=node=>{let object;let property;let propertyNode;let isAssignment=false;if(node.type===eslint_devkit_1.AST_NODE_TYPES.AssignmentExpression&&node.left.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression){object=sourceCode.getText(node.left.object);property=sourceCode.getText(node.left.property);propertyNode=node.left.property;isAssignment=true}else{const memberNode=node;object=sourceCode.getText(memberNode.object);property=sourceCode.getText(memberNode.property);propertyNode=memberNode.property;isAssignment=false}const pattern=OBJECT_INJECTION_PATTERNS.find(p=>new RegExp(p.pattern,"i").test(property)||dangerousProperties.includes(property.replace(/['"]/g,"")))||null;return{object,property,propertyNode,isAssignment,pattern}};const isHighRiskAssignment=node=>{if(node.left.type!=="MemberExpression"){return false}if(!node.left.computed){return false}if(isPrototypelessObject(node.left.object)){return false}if(isTypedArrayObject(node.left.object)){return false}const{propertyNode}=extractPropertyAccess(node);if(isNumericKey(propertyNode)){return false}if(isForInOrObjectKeysKey(propertyNode)){return false}if(hasPrecedingValidation(propertyNode,node)){return false}return isDangerousPropertyAccess(propertyNode)};const isReflectResultAccess=objectNode=>{if(objectNode.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression){const callee=objectNode.callee;if(callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&callee.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&callee.object.name==="Reflect"){return true}}if(objectNode.type===eslint_devkit_1.AST_NODE_TYPES.ChainExpression){return isReflectResultAccess(objectNode.expression)}return false};const isHighRiskMemberAccess=node=>{if(!node.computed){return false}if(isReflectResultAccess(node.object)){return false}if(isTypedArrayObject(node.object)){return false}const{propertyNode}=extractPropertyAccess(node);if(isNumericKey(propertyNode)){return false}if(isForInOrObjectKeysKey(propertyNode)){return false}if(hasPrecedingValidation(propertyNode,node)){return false}return isDangerousPropertyAccess(propertyNode)};const isNumericKey=node=>{if(node.type===eslint_devkit_1.AST_NODE_TYPES.Literal&&typeof node.value==="number"){return true}if(node.type===eslint_devkit_1.AST_NODE_TYPES.UnaryExpression){const op=node.operator;if(op==="+"||op==="-"||op==="~")return true}if(node.type===eslint_devkit_1.AST_NODE_TYPES.UpdateExpression){return true}if(node.type===eslint_devkit_1.AST_NODE_TYPES.BinaryExpression){const op=node.operator;if(op==="|"||op==="&"||op==="^"||op==="<<"||op===">>"||op===">>>"||op==="*"||op==="/"||op==="%"||op==="-"||op==="**"){return true}if(op==="+"){const bin=node;return isNumericKey(bin.left)&&isNumericKey(bin.right)}}if(node.type===eslint_devkit_1.AST_NODE_TYPES.ConditionalExpression){const cond=node;return isNumericKey(cond.consequent)&&isNumericKey(cond.alternate)}if(node.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression){const callee=node.callee;if(callee.type===eslint_devkit_1.AST_NODE_TYPES.Identifier){const name=callee.name;if(name==="Number"||name==="parseInt"||name==="parseFloat")return true}if(callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&callee.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&callee.object.name==="Math"&&callee.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier){return true}}if(node.type===eslint_devkit_1.AST_NODE_TYPES.Identifier){return isNumericIdentifier(node)}return false};const numericVarCache=new WeakMap;const numericVarInProgress=new WeakSet;const isNumericIdentifier=node=>{if(isLoopCounterIdentifier(node))return true;const scope=context.sourceCode.getScope(node);const variable=scope.references.find(r=>r.identifier===node)?.resolved;if(!variable||variable.defs.length===0)return false;const cached=numericVarCache.get(variable);if(cached!==void 0)return cached;if(numericVarInProgress.has(variable))return true;numericVarInProgress.add(variable);let result=false;const def=variable.defs[0];const declarator=def.node;if(declarator?.type===eslint_devkit_1.AST_NODE_TYPES.VariableDeclarator&&declarator.init&&declarator.parent?.type===eslint_devkit_1.AST_NODE_TYPES.VariableDeclaration){result=isNumericKey(declarator.init);if(result){for(const ref of variable.references){const written=ref.writeExpr;if(!written||written===declarator.init)continue;if(!isNumericKey(written)){result=false;break}}}}numericVarInProgress.delete(variable);numericVarCache.set(variable,result);return result};const isLoopCounterIdentifier=node=>{const scope=context.sourceCode.getScope(node);const variable=scope.references.find(r=>r.identifier===node)?.resolved;if(!variable||variable.defs.length===0)return false;const def=variable.defs[0];const parent=def.node?.parent;const grand=parent?.parent;if(parent?.type===eslint_devkit_1.AST_NODE_TYPES.VariableDeclaration&&grand?.type===eslint_devkit_1.AST_NODE_TYPES.ForStatement&&grand.init===parent){const init=def.node.init;if(!init)return false;if(init.type===eslint_devkit_1.AST_NODE_TYPES.Literal&&typeof init.value==="number"){return true}}return false};const isForInOrObjectKeysKey=node=>{if(node.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier)return false;const scope=context.sourceCode.getScope(node);const variable=scope.references.find(r=>r.identifier===node)?.resolved;if(!variable||variable.defs.length===0)return false;const def=variable.defs[0];const varDecl=def.node?.parent;const loopStmt=varDecl?.parent;if(!varDecl||varDecl.type!==eslint_devkit_1.AST_NODE_TYPES.VariableDeclaration)return false;if(loopStmt?.type===eslint_devkit_1.AST_NODE_TYPES.ForInStatement&&loopStmt.left===varDecl){return true}if(loopStmt?.type===eslint_devkit_1.AST_NODE_TYPES.ForOfStatement&&loopStmt.left===varDecl){const right=loopStmt.right;return right.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression&&right.callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&!right.callee.computed&&right.callee.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&right.callee.object.name==="Object"&&right.callee.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&(right.callee.property.name==="keys"||right.callee.property.name==="entries")}return false};const isTypedArrayObject=objectNode=>{if(objectNode.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier)return false;const varName=objectNode.name;let scope=context.sourceCode.getScope(objectNode);while(scope){const variable=scope.variables.find(v=>v.name===varName);if(variable){for(const def of variable.defs){const init=def.node.init;if(init?.type===eslint_devkit_1.AST_NODE_TYPES.NewExpression&&init.callee.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&TYPED_ARRAY_CTORS.has(init.callee.name)){return true}}break}if(!scope.upper)break;scope=scope.upper}return false};const determineRiskLevel=(pattern,isAssignment)=>{if(pattern?.riskLevel==="critical"||pattern&&isAssignment){return"CRITICAL"}if(pattern?.riskLevel==="high"||isAssignment){return"HIGH"}return"MEDIUM"};const checkAssignmentExpression=node=>{if(!isHighRiskAssignment(node)){return}let me=node.left;handledMemberExpressions.add(me);while(me.object.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&me.object.computed){me=me.object;handledMemberExpressions.add(me)}const{object,property,isAssignment,pattern}=extractPropertyAccess(node);const riskLevel=determineRiskLevel(pattern,isAssignment);context.report({node,messageId:"objectInjection",data:{pattern:`${object}[${property}]`,riskLevel,vulnerability:pattern?.vulnerability||"object injection",safeAlternative:pattern?.safeAlternative||"Use Map or property whitelisting"},suggest:[{messageId:"useMapInstead",fix:()=>null},{messageId:"useHasOwnProperty",fix:()=>null},{messageId:"whitelistKeys",fix:()=>null},{messageId:"useObjectCreate",fix:()=>null},{messageId:"freezePrototypes",fix:()=>null}]})};const checkMemberExpression=node=>{if(!isHighRiskMemberAccess(node)){return}if(handledMemberExpressions.has(node)){return}const parent=node.parent;if(parent?.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&parent.computed&&parent.object===node){return}if(parent&&parent.type===eslint_devkit_1.AST_NODE_TYPES.AssignmentExpression&&parent.left===node){return}const{object,property,isAssignment,pattern}=extractPropertyAccess(node);const riskLevel=determineRiskLevel(pattern,isAssignment);context.report({node,messageId:"objectInjection",data:{pattern:`${object}[${property}]`,riskLevel,vulnerability:pattern?.vulnerability||"object injection",safeAlternative:pattern?.safeAlternative||"Use Map or property whitelisting"}})};const checkObjectAssignSpread=node=>{if(node.callee.type!==eslint_devkit_1.AST_NODE_TYPES.MemberExpression)return;const callee=node.callee;const objectIsObject=callee.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&callee.object.name==="Object";const propIsAssign=!callee.computed&&callee.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&callee.property.name==="assign";if(!objectIsObject||!propIsAssign)return;if(node.arguments[0]?.type===eslint_devkit_1.AST_NODE_TYPES.ObjectExpression)return;const sources=node.arguments.slice(1);const anyTaintedSource=sources.some(s=>s.type!==eslint_devkit_1.AST_NODE_TYPES.ObjectExpression&&s.type!==eslint_devkit_1.AST_NODE_TYPES.Literal);if(!anyTaintedSource)return;context.report({node,messageId:"objectInjection",data:{pattern:"Object.assign(target, untrustedSource)",riskLevel:"HIGH",vulnerability:"object injection via Object.assign spread",safeAlternative:"Validate or whitelist keys before merging: `for (const k of Object.keys(src)) if (!ALLOWED.has(k)) continue;`"}})};return{AssignmentExpression:node=>{if(isInCodemodContext||isTestFile)return;return checkAssignmentExpression(node)},MemberExpression:node=>{if(isInCodemodContext||isTestFile)return;return checkMemberExpression(node)},CallExpression:node=>{if(isInCodemodContext||isTestFile)return;return checkObjectAssignSpread(node)}}}});
|
|
1
|
+
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.detectObjectInjection=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const eslint_devkit_3=require("@interlace/eslint-devkit");const fileUsesAstTooling=(0,eslint_devkit_3.createModuleEvidence)({packages:["@babel/types","@babel/traverse","recast","jscodeshift","eslint","estree-walker","ast-types","esrap","unist-util-visit"],scopes:["@typescript-eslint"]});const TYPED_ARRAY_CTORS=new Set(["Int8Array","Uint8Array","Uint8ClampedArray","Int16Array","Uint16Array","Int32Array","Uint32Array","Float32Array","Float64Array","BigInt64Array","BigUint64Array"]);const OBJECT_INJECTION_PATTERNS=[{pattern:"__proto__",dangerous:true,vulnerability:"prototype-pollution",safeAlternative:"Object.create(null) or Map",example:{bad:'obj[userInput] = value; // if userInput is "__proto__"',good:"const map = new Map(); map.set(userInput, value);"},effort:"15-20 minutes",riskLevel:"critical"},{pattern:"prototype",dangerous:true,vulnerability:"prototype-pollution",safeAlternative:"Avoid prototype manipulation",example:{bad:'obj[userInput] = value; // if userInput is "prototype"',good:"if (!obj.hasOwnProperty(userInput)) obj[userInput] = value;"},effort:"10-15 minutes",riskLevel:"high"},{pattern:"constructor",dangerous:true,vulnerability:"method-injection",safeAlternative:"Validate property names against whitelist",example:{bad:'obj[userInput] = value; // if userInput is "constructor"',good:"const ALLOWED_KEYS = ['name', 'age', 'email']; if (ALLOWED_KEYS.includes(userInput)) obj[userInput] = value;"},effort:"10-15 minutes",riskLevel:"medium"}];exports.detectObjectInjection=(0,eslint_devkit_3.createRule)({name:"detect-object-injection",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-secure-coding/docs/rules/detect-object-injection.md",description:"Detects variable[key] as a left- or right-hand assignment operand",cwe:"CWE-915",confidence:"low"},hasSuggestions:true,messages:{objectInjection:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.WARNING,issueName:"Object injection",cwe:"CWE-915",description:"Object injection/Prototype pollution (incl. model/tool outputs)",severity:"{{riskLevel}}",fix:"{{safeAlternative}}",documentationLink:"https://portswigger.net/web-security/prototype-pollution"}),useMapInstead:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Use Map",description:"Use Map instead of plain objects",severity:"LOW",fix:"const map = new Map(); map.set(key, value);",documentationLink:"https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Map"}),useHasOwnProperty:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Use hasOwnProperty",description:"Check hasOwnProperty to avoid prototype properties",severity:"LOW",fix:"if (obj.hasOwnProperty(key)) { obj[key] = value; }",documentationLink:"https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/hasOwnProperty"}),whitelistKeys:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Whitelist Keys",description:"Whitelist allowed property names",severity:"LOW",fix:'const ALLOWED = ["name", "email"]; if (ALLOWED.includes(key)) obj[key] = value; // reject model/tool-supplied unknown keys',documentationLink:"https://portswigger.net/web-security/prototype-pollution"}),useObjectCreate:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Use Object.create(null)",description:"Create clean objects without prototypes",severity:"LOW",fix:"const obj = Object.create(null);",documentationLink:"https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/create"}),freezePrototypes:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Freeze Prototypes",description:"Freeze Object.prototype to prevent pollution",severity:"LOW",fix:"Object.freeze(Object.prototype);",documentationLink:"https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/freeze"}),strategyValidate:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Validate Input",description:"Add input validation before property access",severity:"LOW",fix:"Validate key against allowed values before access",documentationLink:"https://portswigger.net/web-security/prototype-pollution"}),strategyWhitelist:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Whitelist Properties",description:"Whitelist allowed property names only",severity:"LOW",fix:"Define allowed keys and validate against them",documentationLink:"https://portswigger.net/web-security/prototype-pollution"}),strategyFreeze:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Freeze Prototypes",description:"Freeze prototypes to prevent pollution",severity:"LOW",fix:"Object.freeze(Object.prototype) at app startup",documentationLink:"https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/freeze"})},schema:[{type:"object",properties:{allowLiterals:{type:"boolean",default:false,description:"Allow bracket notation with literal strings"},additionalMethods:{type:"array",items:{type:"string"},default:[],description:"Additional object methods to check for injection"},dangerousProperties:{type:"array",items:{type:"string"},default:["__proto__","prototype","constructor"],description:"Properties to consider dangerous"},strategy:{type:"string",enum:["validate","whitelist","freeze","auto"],default:"auto",description:"Strategy for fixing object injection (auto = smart detection)"}},additionalProperties:false}]},defaultOptions:[{allowLiterals:false,additionalMethods:[],dangerousProperties:["__proto__","prototype","constructor"],strategy:"auto"}],create(context){const options=context.options[0]||{};const{allowLiterals:_allowLiterals=false,dangerousProperties=["__proto__","prototype","constructor"]}=options;const handledMemberExpressions=new WeakSet;const openCopyLoops=[];const armedLoops=new WeakSet;const sourceCode=context.sourceCode;const isInCodemodContext=(()=>{const filename=context.filename;if(/\/codemod[s]?\//i.test(filename))return true;if(/codemod\.[mc]?[jt]sx?$/i.test(filename))return true;return fileUsesAstTooling(sourceCode.ast)})();const isTestFile=(()=>{const f=context.filename;return/\.test\.[mc]?[jt]sx?$/.test(f)||/\.spec\.[mc]?[jt]sx?$/.test(f)||/\/__tests__\//.test(f)||/\/test\//.test(f)||/\.fixture\.[mc]?[jt]sx?$/.test(f)})();const isLiteralString=node=>{return node.type===eslint_devkit_1.AST_NODE_TYPES.Literal&&typeof node.value==="string"};const hasPrecedingValidation=(propertyNode,node)=>{if(propertyNode.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier){return false}const keyName=propertyNode.name;const isIncludesCall=testNode=>{if(testNode.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression&&testNode.callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&testNode.callee.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&testNode.callee.property.name==="includes"&&testNode.arguments.length>0&&testNode.arguments[0].type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&testNode.arguments[0].name===keyName){return true}if(testNode.type===eslint_devkit_1.AST_NODE_TYPES.UnaryExpression&&testNode.operator==="!"&&testNode.argument.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression){return isIncludesCall(testNode.argument)}return false};const isHasOwnPropertyCall=testNode=>{if(testNode.type!==eslint_devkit_1.AST_NODE_TYPES.CallExpression)return false;const callee=testNode.callee;const args=testNode.arguments;if(callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&callee.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&callee.property.name==="call"&&args.length>=2&&args[1].type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&args[1].name===keyName){return true}if(callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&callee.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&(callee.property.name==="hasOwnProperty"||callee.property.name==="hasOwn")){const keyArg=callee.property.name==="hasOwn"?args[1]:args[0];if(keyArg?.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&keyArg.name===keyName){return true}}return false};const isInOperator=testNode=>{return testNode.type===eslint_devkit_1.AST_NODE_TYPES.BinaryExpression&&testNode.operator==="in"&&testNode.left.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&testNode.left.name===keyName};const hasValidation=testNode=>{return isIncludesCall(testNode)||isHasOwnPropertyCall(testNode)||isInOperator(testNode)};const hasEarlyExit=consequent=>{if(consequent.type===eslint_devkit_1.AST_NODE_TYPES.BlockStatement){return consequent.body.some(stmt=>stmt.type===eslint_devkit_1.AST_NODE_TYPES.ThrowStatement||stmt.type===eslint_devkit_1.AST_NODE_TYPES.ReturnStatement)}return consequent.type===eslint_devkit_1.AST_NODE_TYPES.ThrowStatement||consequent.type===eslint_devkit_1.AST_NODE_TYPES.ReturnStatement};let current=node.parent;let foundFunctionBody=false;while(current&&!foundFunctionBody){if(current.type===eslint_devkit_1.AST_NODE_TYPES.IfStatement){if(hasValidation(current.test)){return true}}if(current.type===eslint_devkit_1.AST_NODE_TYPES.BlockStatement&¤t.parent&&(current.parent.type===eslint_devkit_1.AST_NODE_TYPES.FunctionDeclaration||current.parent.type===eslint_devkit_1.AST_NODE_TYPES.FunctionExpression||current.parent.type===eslint_devkit_1.AST_NODE_TYPES.ArrowFunctionExpression)){foundFunctionBody=true;const blockBody=current.body;const nodeIndex=blockBody.findIndex(stmt=>{let check=node;while(check){if(check===stmt)return true;check=check.parent}return false});for(let i=0;i<nodeIndex;i++){const stmt=blockBody[i];if(stmt.type===eslint_devkit_1.AST_NODE_TYPES.IfStatement&&hasValidation(stmt.test)&&hasEarlyExit(stmt.consequent)){return true}}}current=current.parent}return false};const hasDisqualifyingLiteralAffix=node=>{if(node.type!==eslint_devkit_1.AST_NODE_TYPES.BinaryExpression||node.operator!=="+"){return false}const bin=node;const literalText=n=>{if(n.type!==eslint_devkit_1.AST_NODE_TYPES.Literal)return null;const v=n.value;if(typeof v!=="string"&&typeof v!=="number")return null;const s=String(v);return s.length>0?s:null};const prefix=literalText(bin.left);if(prefix!==null&&!dangerousProperties.some(d=>d.startsWith(prefix))){return true}const suffix=literalText(bin.right);if(suffix!==null&&!dangerousProperties.some(d=>d.endsWith(suffix))){return true}return false};const isDangerousPropertyAccess=propertyNode=>{if(isNumericKey(propertyNode)||hasDisqualifyingLiteralAffix(propertyNode)){return false}if(propertyNode.type===eslint_devkit_1.AST_NODE_TYPES.Identifier){const name=propertyNode.name;if(/^[A-Z][A-Z0-9_]{2,}$/.test(name)){return false}if(/^[a-z]/.test(name)&&/(?:Code|Status|Version|Kind|Mode|Type|Stage|Level|Phase|Step|Flag|Num|Count)$/.test(name)){return false}}if(isLiteralString(propertyNode)){const propName=String(propertyNode.value);if(dangerousProperties.includes(propName)){return true}return false}return true};const isPrototypelessObject=objectNode=>{if(objectNode.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier){return false}const varName=objectNode.name;let current=objectNode;while(current){if(current.type===eslint_devkit_1.AST_NODE_TYPES.BlockStatement||current.type===eslint_devkit_1.AST_NODE_TYPES.Program){const statements=current.type===eslint_devkit_1.AST_NODE_TYPES.BlockStatement?current.body:current.body;for(const stmt of statements){if(stmt.type===eslint_devkit_1.AST_NODE_TYPES.VariableDeclaration){for(const decl of stmt.declarations){if(decl.id.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&decl.id.name===varName&&decl.init){if(decl.init.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression&&decl.init.callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&decl.init.callee.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&decl.init.callee.object.name==="Object"&&decl.init.callee.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&decl.init.callee.property.name==="create"&&decl.init.arguments.length>0&&decl.init.arguments[0].type===eslint_devkit_1.AST_NODE_TYPES.Literal&&decl.init.arguments[0].value===null){return true}if(decl.init.type===eslint_devkit_1.AST_NODE_TYPES.ArrayExpression&&decl.init.elements.length>0&&decl.init.elements[0]?.type===eslint_devkit_1.AST_NODE_TYPES.SpreadElement){return true}}}}}}current=current.parent}return false};const extractPropertyAccess=node=>{let object;let property;let propertyNode;let isAssignment=false;if(node.type===eslint_devkit_1.AST_NODE_TYPES.AssignmentExpression&&node.left.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression){object=sourceCode.getText(node.left.object);property=sourceCode.getText(node.left.property);propertyNode=node.left.property;isAssignment=true}else{const memberNode=node;object=sourceCode.getText(memberNode.object);property=sourceCode.getText(memberNode.property);propertyNode=memberNode.property;isAssignment=false}const pattern=OBJECT_INJECTION_PATTERNS.find(p=>new RegExp(p.pattern,"i").test(property)||dangerousProperties.includes(property.replace(/['"]/g,"")))||null;return{object,property,propertyNode,isAssignment,pattern}};const isHighRiskAssignment=node=>{if(node.left.type!=="MemberExpression"){return false}if(!node.left.computed){return false}if(isPrototypelessObject(node.left.object)){return false}if(isTypedArrayObject(node.left.object)){return false}const{propertyNode}=extractPropertyAccess(node);if(isNumericKey(propertyNode)){return false}if(isForInOrObjectKeysKey(propertyNode)){return false}if(hasPrecedingValidation(propertyNode,node)){return false}return isDangerousPropertyAccess(propertyNode)};const isReflectResultAccess=objectNode=>{if(objectNode.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression){const callee=objectNode.callee;if(callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&callee.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&callee.object.name==="Reflect"){return true}}if(objectNode.type===eslint_devkit_1.AST_NODE_TYPES.ChainExpression){return isReflectResultAccess(objectNode.expression)}return false};const isHighRiskMemberAccess=node=>{if(!node.computed){return false}if(isReflectResultAccess(node.object)){return false}if(isTypedArrayObject(node.object)){return false}const{propertyNode}=extractPropertyAccess(node);if(isNumericKey(propertyNode)){return false}if(isForInOrObjectKeysKey(propertyNode)){return false}if(hasPrecedingValidation(propertyNode,node)){return false}return isDangerousPropertyAccess(propertyNode)};const isNumericKey=node=>{if(node.type===eslint_devkit_1.AST_NODE_TYPES.Literal&&typeof node.value==="number"){return true}if(node.type===eslint_devkit_1.AST_NODE_TYPES.UnaryExpression){const op=node.operator;if(op==="+"||op==="-"||op==="~")return true}if(node.type===eslint_devkit_1.AST_NODE_TYPES.UpdateExpression){return true}if(node.type===eslint_devkit_1.AST_NODE_TYPES.BinaryExpression){const op=node.operator;if(op==="|"||op==="&"||op==="^"||op==="<<"||op===">>"||op===">>>"||op==="*"||op==="/"||op==="%"||op==="-"||op==="**"){return true}if(op==="+"){const bin=node;return isNumericKey(bin.left)&&isNumericKey(bin.right)}}if(node.type===eslint_devkit_1.AST_NODE_TYPES.ConditionalExpression){const cond=node;return isNumericKey(cond.consequent)&&isNumericKey(cond.alternate)}if(node.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression){const callee=node.callee;if(callee.type===eslint_devkit_1.AST_NODE_TYPES.Identifier){const name=callee.name;if(name==="Number"||name==="parseInt"||name==="parseFloat")return true}if(callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&callee.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&callee.object.name==="Math"&&callee.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier){return true}}if(node.type===eslint_devkit_1.AST_NODE_TYPES.Identifier){return isNumericIdentifier(node)}return false};const numericVarCache=new WeakMap;const numericVarInProgress=new WeakSet;const isNumericIdentifier=node=>{if(isLoopCounterIdentifier(node))return true;const scope=context.sourceCode.getScope(node);const variable=scope.references.find(r=>r.identifier===node)?.resolved;if(!variable||variable.defs.length===0)return false;const cached=numericVarCache.get(variable);if(cached!==void 0)return cached;if(numericVarInProgress.has(variable))return true;numericVarInProgress.add(variable);let result=false;const def=variable.defs[0];const declarator=def.node;if(declarator?.type===eslint_devkit_1.AST_NODE_TYPES.VariableDeclarator&&declarator.init&&declarator.parent?.type===eslint_devkit_1.AST_NODE_TYPES.VariableDeclaration){result=isNumericKey(declarator.init);if(result){for(const ref of variable.references){const written=ref.writeExpr;if(!written||written===declarator.init)continue;if(!isNumericKey(written)){result=false;break}}}}numericVarInProgress.delete(variable);numericVarCache.set(variable,result);return result};const isLoopCounterIdentifier=node=>{const scope=context.sourceCode.getScope(node);const variable=scope.references.find(r=>r.identifier===node)?.resolved;if(!variable||variable.defs.length===0)return false;const def=variable.defs[0];const parent=def.node?.parent;const grand=parent?.parent;if(parent?.type===eslint_devkit_1.AST_NODE_TYPES.VariableDeclaration&&grand?.type===eslint_devkit_1.AST_NODE_TYPES.ForStatement&&grand.init===parent){const init=def.node.init;if(!init)return false;if(init.type===eslint_devkit_1.AST_NODE_TYPES.Literal&&typeof init.value==="number"){return true}}return false};const isForInOrObjectKeysKey=node=>{if(node.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier)return false;const scope=context.sourceCode.getScope(node);const variable=scope.references.find(r=>r.identifier===node)?.resolved;if(!variable||variable.defs.length===0)return false;const def=variable.defs[0];const varDecl=def.node?.parent;const loopStmt=varDecl?.parent;if(!varDecl||varDecl.type!==eslint_devkit_1.AST_NODE_TYPES.VariableDeclaration)return false;if(loopStmt?.type===eslint_devkit_1.AST_NODE_TYPES.ForInStatement&&loopStmt.left===varDecl){return true}if(loopStmt?.type===eslint_devkit_1.AST_NODE_TYPES.ForOfStatement&&loopStmt.left===varDecl){const right=loopStmt.right;return right.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression&&right.callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&!right.callee.computed&&right.callee.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&right.callee.object.name==="Object"&&right.callee.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&(right.callee.property.name==="keys"||right.callee.property.name==="entries")}return false};const isTypedArrayObject=objectNode=>{if(objectNode.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier)return false;const varName=objectNode.name;let scope=context.sourceCode.getScope(objectNode);while(scope){const variable=scope.variables.find(v=>v.name===varName);if(variable){for(const def of variable.defs){const init=def.node.init;if(init?.type===eslint_devkit_1.AST_NODE_TYPES.NewExpression&&init.callee.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&TYPED_ARRAY_CTORS.has(init.callee.name)){return true}}break}if(!scope.upper)break;scope=scope.upper}return false};const determineRiskLevel=(pattern,isAssignment)=>{if(pattern?.riskLevel==="critical"||pattern&&isAssignment){return"CRITICAL"}if(pattern?.riskLevel==="high"||isAssignment){return"HIGH"}return"MEDIUM"};const checkAssignmentExpression=node=>{if(!isHighRiskAssignment(node)){return}if(node.left.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&node.left.computed&&keyComesFromConstAllowlist(node.left.property,node)){return}let me=node.left;handledMemberExpressions.add(me);while(me.object.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&me.object.computed){me=me.object;handledMemberExpressions.add(me)}const{object,property,isAssignment,pattern}=extractPropertyAccess(node);const riskLevel=determineRiskLevel(pattern,isAssignment);context.report({node,messageId:"objectInjection",data:{pattern:`${object}[${property}]`,riskLevel,vulnerability:pattern?.vulnerability||"object injection",safeAlternative:pattern?.safeAlternative||"Use Map or property whitelisting"},suggest:[{messageId:"useMapInstead",fix:()=>null},{messageId:"useHasOwnProperty",fix:()=>null},{messageId:"whitelistKeys",fix:()=>null},{messageId:"useObjectCreate",fix:()=>null},{messageId:"freezePrototypes",fix:()=>null}]})};const constObjectLiteralOf=(name,from)=>{for(let scope=sourceCode.getScope(from);scope;scope=scope.upper){const variable=scope.variables.find(v=>v.name===name);if(!variable)continue;if(variable.defs.length!==1)return null;const def=variable.defs[0];if(def.type!=="Variable"||def.parent?.kind!=="const")return null;if(variable.references.some(ref=>ref.isWrite()&&ref.identifier!==def.name)){return null}const init=def.node.init;return init?.type===eslint_devkit_1.AST_NODE_TYPES.ObjectExpression?init:null}return null};const isReadFromConstObjectLiteral=node=>node.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&constObjectLiteralOf(node.object.name,node)!==null;const keyComesFromConstAllowlist=(property,from)=>{if(property.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier)return false;for(let scope=sourceCode.getScope(from);scope;scope=scope.upper){const variable=scope.variables.find(v=>v.name===property.name);if(!variable)continue;if(variable.defs.length!==1)return false;const def=variable.defs[0];if(def.type!=="Variable"||def.parent?.kind!=="const")return false;if(variable.references.some(ref=>ref.isWrite()&&ref.identifier!==def.name)){return false}const init=def.node.init;if(init?.type!==eslint_devkit_1.AST_NODE_TYPES.MemberExpression||!init.computed||init.object.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier){return false}const source=constObjectLiteralOf(init.object.name,init);if(!source)return false;return source.properties.every(p=>p.type===eslint_devkit_1.AST_NODE_TYPES.Property&&p.value.type===eslint_devkit_1.AST_NODE_TYPES.Literal&&typeof p.value.value==="string")}return false};const checkMemberExpression=node=>{if(!isHighRiskMemberAccess(node)){return}if(isReadFromConstObjectLiteral(node)){return}if(handledMemberExpressions.has(node)){return}const parent=node.parent;if(parent?.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&parent.computed&&parent.object===node){return}if(parent&&parent.type===eslint_devkit_1.AST_NODE_TYPES.AssignmentExpression&&parent.left===node){return}const{object,property,isAssignment,pattern}=extractPropertyAccess(node);const riskLevel=determineRiskLevel(pattern,isAssignment);context.report({node,messageId:"objectInjection",data:{pattern:`${object}[${property}]`,riskLevel,vulnerability:pattern?.vulnerability||"object injection",safeAlternative:pattern?.safeAlternative||"Use Map or property whitelisting"}})};const checkObjectAssignSpread=node=>{if(node.callee.type!==eslint_devkit_1.AST_NODE_TYPES.MemberExpression)return;const callee=node.callee;const objectIsObject=callee.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&callee.object.name==="Object";const propIsAssign=!callee.computed&&callee.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&callee.property.name==="assign";if(!objectIsObject||!propIsAssign)return;if(node.arguments[0]?.type===eslint_devkit_1.AST_NODE_TYPES.ObjectExpression)return;const sources=node.arguments.slice(1);const anyTaintedSource=sources.some(s=>s.type!==eslint_devkit_1.AST_NODE_TYPES.ObjectExpression&&s.type!==eslint_devkit_1.AST_NODE_TYPES.Literal);if(!anyTaintedSource)return;context.report({node,messageId:"objectInjection",data:{pattern:"Object.assign(target, untrustedSource)",riskLevel:"HIGH",vulnerability:"object injection via Object.assign spread",safeAlternative:"Validate or whitelist keys before merging: `for (const k of Object.keys(src)) if (!ALLOWED.has(k)) continue;`"}})};const checkPrototypePollutingCopyLoop=node=>{if(isInCodemodContext||isTestFile)return;const keyName=node.left.type===eslint_devkit_1.AST_NODE_TYPES.VariableDeclaration?node.left.declarations[0]?.id.type===eslint_devkit_1.AST_NODE_TYPES.Identifier?node.left.declarations[0].id.name:void 0:node.left.type===eslint_devkit_1.AST_NODE_TYPES.Identifier?node.left.name:void 0;if(!keyName)return;if(node.right.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier)return;const sourceName=node.right.name;let isParameter=false;for(let scope=context.sourceCode.getScope(node);scope;scope=scope.upper){const variable=scope.variables.find(v=>v.name===sourceName);if(!variable)continue;isParameter=variable.defs.some(def=>def.type==="Parameter");break}if(!isParameter)return;const bodyText=context.sourceCode.getTokens(node.body).map(token=>token.value).join("");if(/hasOwnProperty|hasOwn|__proto__|constructor|prototype|includes\(|allowlist|whitelist|Object\.keys/.test(bodyText)){return}armedLoops.add(node);openCopyLoops.push({keyName,reported:false})};const reportCopyLoopWrite=node=>{if(node.left.type!==eslint_devkit_1.AST_NODE_TYPES.MemberExpression||!node.left.computed||node.left.property.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier){return false}const propertyName=node.left.property.name;const loop=openCopyLoops.find(open=>open.keyName===propertyName&&!open.reported);if(!loop)return false;loop.reported=true;context.report({node,messageId:"objectInjection",data:{riskLevel:"HIGH",safeAlternative:'Guard the key before assigning: `if (k === "__proto__" || k === "constructor" || k === "prototype") continue;` \u2014 or copy with Object.create(null) / structuredClone.'}});return true};return{ForInStatement:checkPrototypePollutingCopyLoop,"ForInStatement:exit":node=>{if(armedLoops.has(node))openCopyLoops.pop()},AssignmentExpression:node=>{if(isInCodemodContext||isTestFile)return;if(reportCopyLoopWrite(node))return;return checkAssignmentExpression(node)},MemberExpression:node=>{if(isInCodemodContext||isTestFile)return;return checkMemberExpression(node)},CallExpression:node=>{if(isInCodemodContext||isTestFile)return;return checkObjectAssignSpread(node)}}}});
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noBidiCharacters=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const BIDI_CHARACTERS=new Map([["\u202A","U+202A LEFT-TO-RIGHT EMBEDDING"],["\u202B","U+202B RIGHT-TO-LEFT EMBEDDING"],["\u202C","U+202C POP DIRECTIONAL FORMATTING"],["\u202D","U+202D LEFT-TO-RIGHT OVERRIDE"],["\u202E","U+202E RIGHT-TO-LEFT OVERRIDE"],["\u2066","U+2066 LEFT-TO-RIGHT ISOLATE"],["\u2067","U+2067 RIGHT-TO-LEFT ISOLATE"],["\u2068","U+2068 FIRST STRONG ISOLATE"],["\u2069","U+2069 POP DIRECTIONAL ISOLATE"]]);const DIRECTIONAL_MARKS=new Map([["\u200E","U+200E LEFT-TO-RIGHT MARK"],["\u200F","U+200F RIGHT-TO-LEFT MARK"]]);const codePointFromLabel=label=>{const match=/^U\+([0-9a-fA-F]{4,6})$/.exec(label.trim());if(!match)return void 0;const codePoint=Number.parseInt(match[1],16);if(codePoint>1114111)return void 0;return String.fromCodePoint(codePoint)};exports.noBidiCharacters=(0,eslint_devkit_1.createRule)({name:"no-bidi-characters",meta:{type:"problem",docs:{url:"https://eslint.interlace.tools/docs/security/plugin-secure-coding/rules/no-bidi-characters",description:"Disallows Unicode bidirectional control characters, which let source render differently than it compiles (Trojan Source, CWE-1007)",cwe:"CWE-1007",cvss:8.8},hasSuggestions:true,messages:{bidiCharacter:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Bidirectional control character \u2014 Trojan Source (CWE-1007)",cwe:"CWE-1007",description:"{{characterName}} found in source. Bidi controls change how code is DISPLAYED without changing how it is COMPILED, so a reviewer can approve one program while the compiler builds another.",severity:"HIGH",fix:"Remove the character. If the string genuinely needs bidirectional text, use the escape sequence (\\u202E) so it is visible in review.",documentationLink:"https://trojansource.codes/"}),removeBidiCharacter:"Remove {{characterName}}"},schema:[{type:"object",properties:{additionalCharacters:{type:"array",items:{type:"string"}},allowDirectionalMarks:{type:"boolean",default:false}},additionalProperties:false}]},defaultOptions:[{}],create(context,[options={}]){const{additionalCharacters=[],allowDirectionalMarks=false}=options;const dangerous=new Map(BIDI_CHARACTERS);if(!allowDirectionalMarks){for(const[char,name]of DIRECTIONAL_MARKS)dangerous.set(char,name)}for(const label of additionalCharacters){const char=codePointFromLabel(label);if(char)dangerous.set(char,label.trim())}return{Program(node){const{sourceCode}=context;const text=sourceCode.getText();for(let index=0;index<text.length;){const codePoint=text.codePointAt(index);const width=codePoint>65535?2:1;const characterName=dangerous.get(text.slice(index,index+width));if(!characterName){index+=width;continue}const range=[index,index+width];context.report({node,loc:{start:sourceCode.getLocFromIndex(index),end:sourceCode.getLocFromIndex(index+width)},messageId:"bidiCharacter",data:{characterName},suggest:[{messageId:"removeBidiCharacter",data:{characterName},fix:fixer=>fixer.removeRange(range)}]});index+=width}}}}});
|
|
@@ -1 +1 @@
|
|
|
1
|
-
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noDirectiveInjection=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const eslint_devkit_3=require("@interlace/eslint-devkit");const DANGEROUS_TAGS=new Set(["script","iframe","object","embed","base"]);const DANGEROUS_ATTRS=new Set(["srcdoc","formaction","xlink:href"]);const TAG_OPTIONS=new Set(["ADD_TAGS","ALLOWED_TAGS"]);const ATTR_OPTIONS=new Set(["ADD_ATTR","ALLOWED_ATTR"]);function staticStringArray(node){if(node.type!=="ArrayExpression")return null;const out=[];for(const element of node.elements){if(element?.type==="Literal"&&typeof element.value==="string"){out.push(element.value)}}return out}function findUnsafeSanitizerConfig(node){const callee=node.callee;if(callee.type!=="MemberExpression")return null;if(callee.property.type!=="Identifier"||callee.property.name!=="sanitize")return null;if(callee.object.type!=="Identifier")return null;if(!callee.object.name.toLowerCase().includes("purify"))return null;const config=node.arguments[1];if(!config||config.type!=="ObjectExpression")return null;for(const property of config.properties){if(property.type!=="Property")continue;if(property.computed)continue;const option=property.key.type==="Identifier"?property.key.name:property.key.type==="Literal"&&typeof property.key.value==="string"?property.key.value:null;if(option===null)continue;if(property.shorthand)continue;const values=staticStringArray(property.value);if(!values)continue;if(TAG_OPTIONS.has(option)){const bad=values.find(v=>DANGEROUS_TAGS.has(v.toLowerCase()));if(bad)return{node:property,option,allowed:`<${bad}>`}}if(ATTR_OPTIONS.has(option)){const bad=values.find(v=>v.toLowerCase().startsWith("on")||DANGEROUS_ATTRS.has(v.toLowerCase()));if(bad)return{node:property,option,allowed:`the "${bad}" attribute`}}}return null}exports.noDirectiveInjection=(0,eslint_devkit_1.createRule)({name:"no-directive-injection",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-secure-coding/docs/rules/no-directive-injection.md",description:"Detects directive injection vulnerabilities in templates",cwe:"CWE-96"},messages:{directiveInjection:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Directive Injection",cwe:"CWE-96",description:"User input injected into directive or template",severity:"{{severity}}",fix:"{{safeAlternative}}",documentationLink:"https://cwe.mitre.org/data/definitions/96.html"}),unsafeDirectiveName:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Unsafe Directive Name",cwe:"CWE-96",description:"Directive name controlled by user input",severity:"CRITICAL",fix:"Use hardcoded directive names or validate against whitelist",documentationLink:"https://cwe.mitre.org/data/definitions/96.html"}),dynamicDirectiveCreation:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Dynamic Directive Creation",cwe:"CWE-96",description:"Dynamic creation of directives from user input",severity:"HIGH",fix:"Validate directive names against trusted list",documentationLink:"https://cwe.mitre.org/data/definitions/96.html"}),templateInjection:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Template Injection",cwe:"CWE-96",description:"User input injected into template content",severity:"HIGH",fix:"Sanitize template input or use safe rendering",documentationLink:"https://cwe.mitre.org/data/definitions/96.html"}),unsafeComponentBinding:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Unsafe Component Binding",cwe:"CWE-96",description:"Dynamic component binding with user input",severity:"HIGH",fix:"Use component whitelist or validate component names",documentationLink:"https://cwe.mitre.org/data/definitions/96.html"}),userControlledTemplate:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"User Controlled Template",cwe:"CWE-96",description:"Template content controlled by user input",severity:"CRITICAL",fix:"Sanitize template input before compilation",documentationLink:"https://cwe.mitre.org/data/definitions/96.html"}),dangerousInnerHTML:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Dangerous innerHTML",cwe:"CWE-96",description:"innerHTML set with user-controlled content",severity:"HIGH",fix:"Use textContent or sanitize HTML content",documentationLink:"https://developer.mozilla.org/en-US/docs/Web/API/Element/innerHTML"}),untrustedDirectiveSource:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Untrusted Directive Source",cwe:"CWE-96",description:"Directive loaded from untrusted source",severity:"MEDIUM",fix:"Load directives from trusted, verified sources",documentationLink:"https://cwe.mitre.org/data/definitions/96.html"}),useTrustedDirectives:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Use Trusted Directives",description:"Use only trusted, verified directives",severity:"LOW",fix:"Maintain whitelist of allowed directives",documentationLink:"https://cwe.mitre.org/data/definitions/96.html"}),unsafeSanitizerConfig:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Sanitizer configured to allow {{allowed}}",cwe:"CWE-96",description:"DOMPurify was configured with {{option}} re-enabling {{allowed}}, which is exactly what the sanitizer removes by default. The call returns markup that can execute script, so the sanitization provides no protection.",severity:"HIGH",fix:"Drop {{allowed}} from {{option}}. If the markup genuinely needs it, render it outside the sanitized region rather than widening the allow-list.",documentationLink:"https://github.com/cure53/DOMPurify#can-i-configure-dompurify"}),sanitizeTemplateInput:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Sanitize Template Input",description:"Sanitize user input before template processing",severity:"LOW",fix:"Use DOMPurify or equivalent sanitization",documentationLink:"https://github.com/cure53/DOMPurify"}),validateDirectiveNames:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Validate Directive Names",description:"Validate directive names against whitelist",severity:"LOW",fix:"Check directive names before dynamic creation",documentationLink:"https://cwe.mitre.org/data/definitions/96.html"}),strategyTemplateSanitization:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Template Sanitization Strategy",description:"Implement template input sanitization",severity:"LOW",fix:"Sanitize all user input before template processing",documentationLink:"https://owasp.org/www-community/xss-filter-evasion-cheatsheet"}),strategyContentSecurity:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Content Security Strategy",description:"Use CSP to restrict directive execution",severity:"LOW",fix:"Implement strict CSP with script-src restrictions",documentationLink:"https://developer.mozilla.org/en-US/docs/Web/HTTP/CSP"}),strategyInputValidation:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Input Validation Strategy",description:"Validate all template inputs",severity:"LOW",fix:"Use schema validation for template inputs",documentationLink:"https://joi.dev/"})},schema:[{type:"object",properties:{trustedDirectives:{type:"array",items:{type:"string"},default:["ngIf","ngFor","ngClass","v-if","v-for","v-bind","v-on"],description:"Template directives treated as safe"},userInputVariables:{type:"array",items:{type:"string"},default:["req","request","body","query","params","input","data","userInput"],description:"Variable names treated as user-controlled input"},frameworks:{type:"array",items:{type:"string"},default:["angular","vue","react","svelte"],description:"Template frameworks to analyse"},allowDynamicInComponents:{type:"boolean",default:false,description:"Allow dynamic directives inside component code"},trustedSanitizers:{type:"array",items:{type:"string"},default:[],description:"Additional function names to consider as template sanitizers"},trustedAnnotations:{type:"array",items:{type:"string"},default:[],description:"Additional JSDoc annotations to consider as safe markers"},strictMode:{type:"boolean",default:false,description:"Disable all false positive detection (strict mode)"}},additionalProperties:false}]},defaultOptions:[{trustedDirectives:["ngIf","ngFor","ngClass","v-if","v-for","v-bind","v-on"],userInputVariables:["req","request","body","query","params","input","data","userInput"],frameworks:["angular","vue","react","svelte"],allowDynamicInComponents:false,trustedSanitizers:[],trustedAnnotations:[],strictMode:false}],create(context){const options=context.options[0]||{};const{userInputVariables=["req","request","body","query","params","input","data","userInput"],trustedSanitizers=[],trustedAnnotations=[],strictMode=false}=options;const sourceCode=context.sourceCode;const filename=context.filename;const safetyChecker=(0,eslint_devkit_3.createSafetyChecker)({trustedSanitizers,trustedAnnotations,trustedOrmPatterns:[],strictMode});const isUserInput=varName=>{return userInputVariables.some(input=>varName.includes(input))||varName.startsWith("user")};return{JSXAttribute(node){const attrName=node.name;const attrValue=node.value;if(attrName.type==="JSXIdentifier"&&attrName.name==="dangerouslySetInnerHTML"){if(attrValue&&attrValue.type==="JSXExpressionContainer"){const expression=attrValue.expression;const expressionText=sourceCode.getText(expression);if(userInputVariables.some(input=>expressionText.includes(input))){if(safetyChecker.isSafe(node,context)){return}context.report({node:attrValue,messageId:"dangerousInnerHTML",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}}const isNamespaceDirective=attrName.type==="JSXNamespacedName"&&(attrName.namespace.name==="v"||attrName.namespace.name==="ng")||attrName.type==="JSXIdentifier"&&(attrName.name.startsWith("ng:")||attrName.name.startsWith("v:"));if(isNamespaceDirective&&attrValue){if(attrValue.type==="JSXExpressionContainer"){const expression=attrValue.expression;if(expression.type==="Identifier"&&isUserInput(expression.name)){if(safetyChecker.isSafe(node,context)){return}context.report({node:attrValue,messageId:"directiveInjection",data:{filePath:filename,line:String(node.loc?.start.line??0),severity:"HIGH",safeAlternative:"Use hardcoded directive values or validate user input"}})}}}if(attrName.type==="JSXIdentifier"){const attrNameStr=attrName.name;if(attrNameStr==="is"&&attrValue){if(attrValue.type==="JSXExpressionContainer"){const expression=attrValue.expression;if(expression.type==="Identifier"&&isUserInput(expression.name)){if(safetyChecker.isSafe(node,context)){return}context.report({node:attrValue,messageId:"unsafeComponentBinding",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}}}},AssignmentExpression(node){const left=node.left;const right=node.right;if(left.type==="MemberExpression"&&left.property.type==="Identifier"&&left.property.name==="innerHTML"){const rightText=sourceCode.getText(right);if(userInputVariables.some(input=>rightText.includes(input))){if(safetyChecker.isSafe(node,context)){return}context.report({node:right,messageId:"dangerousInnerHTML",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}},CallExpression(node){const callee=node.callee;const unsafeConfig=findUnsafeSanitizerConfig(node);if(unsafeConfig){context.report({node:unsafeConfig.node,messageId:"unsafeSanitizerConfig",data:{option:unsafeConfig.option,allowed:unsafeConfig.allowed}})}if(callee.type==="MemberExpression"&&callee.property.type==="Identifier"){const methodName=callee.property.name;const objectName=callee.object.type==="Identifier"?callee.object.name:"";if(["compile","template","$compile","$interpolate"].includes(methodName)||objectName==="Handlebars"&&methodName==="compile"||objectName==="_"&&methodName==="template"||objectName==="ejs"&&methodName==="render"||objectName==="pug"&&methodName==="render"||objectName==="mustache"&&methodName==="render"){const args=node.arguments;if(args.length>0){const templateArg=args[0];if(templateArg.type==="Identifier"&&isUserInput(templateArg.name)){if(safetyChecker.isSafe(node,context)){return}context.report({node:templateArg,messageId:"userControlledTemplate",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}}if(objectName==="Vue"&&methodName==="directive"){const args=node.arguments;if(args.length>=2){const directiveName=args[0];if(directiveName.type==="Identifier"&&isUserInput(directiveName.name)){if(safetyChecker.isSafe(node,context)){return}context.report({node:directiveName,messageId:"unsafeDirectiveName",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}}}if(callee.type==="Identifier"&&callee.name==="directive"){const args=node.arguments;if(args.length>=2){const directiveName=args[0];if(directiveName.type==="Identifier"&&isUserInput(directiveName.name)){if(safetyChecker.isSafe(node,context)){return}context.report({node:directiveName,messageId:"dynamicDirectiveCreation",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}}},TemplateLiteral(node){let current=node;let isInDangerousContext=false;while(current){if(current.type==="JSXExpressionContainer"){if(current.parent?.type==="JSXAttribute"&¤t.parent.name.type==="JSXIdentifier"&¤t.parent.name.name==="dangerouslySetInnerHTML"){isInDangerousContext=true;break}}else if(current.type==="AssignmentExpression"){const left=current.left;if(left.type==="MemberExpression"&&left.property.type==="Identifier"&&left.property.name==="innerHTML"){isInDangerousContext=true;break}}current=current.parent}if(isInDangerousContext){const hasUserInput=node.expressions.some(expr=>expr.type==="Identifier"&&isUserInput(expr.name)||expr.type==="MemberExpression"&&expr.object.type==="Identifier"&&isUserInput(expr.object.name));if(hasUserInput){if(safetyChecker.isSafe(node,context)){return}context.report({node,messageId:"templateInjection",data:{filePath:filename,line:String(node.loc?.start.line??0),severity:"HIGH",safeAlternative:"Sanitize template input before insertion"}})}}}}}});
|
|
1
|
+
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noDirectiveInjection=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const eslint_devkit_3=require("@interlace/eslint-devkit");const DANGEROUS_TAGS=new Set(["script","iframe","object","embed","base"]);const DANGEROUS_ATTRS=new Set(["srcdoc","formaction","xlink:href"]);const TAG_OPTIONS=new Set(["ADD_TAGS","ALLOWED_TAGS"]);const ATTR_OPTIONS=new Set(["ADD_ATTR","ALLOWED_ATTR"]);function staticStringArray(node){if(node.type!=="ArrayExpression")return null;const out=[];for(const element of node.elements){if(element?.type==="Literal"&&typeof element.value==="string"){out.push(element.value)}}return out}function findUnsafeSanitizerConfig(node){const callee=node.callee;if(callee.type!=="MemberExpression")return null;if(callee.property.type!=="Identifier"||callee.property.name!=="sanitize")return null;if(callee.object.type!=="Identifier")return null;if(!callee.object.name.toLowerCase().includes("purify"))return null;const config=node.arguments[1];if(!config||config.type!=="ObjectExpression")return null;for(const property of config.properties){if(property.type!=="Property")continue;if(property.computed)continue;const option=property.key.type==="Identifier"?property.key.name:property.key.type==="Literal"&&typeof property.key.value==="string"?property.key.value:null;if(option===null)continue;if(property.shorthand)continue;const values=staticStringArray(property.value);if(!values)continue;if(TAG_OPTIONS.has(option)){const bad=values.find(v=>DANGEROUS_TAGS.has(v.toLowerCase()));if(bad)return{node:property,option,allowed:`<${bad}>`}}if(ATTR_OPTIONS.has(option)){const bad=values.find(v=>v.toLowerCase().startsWith("on")||DANGEROUS_ATTRS.has(v.toLowerCase()));if(bad)return{node:property,option,allowed:`the "${bad}" attribute`}}}return null}exports.noDirectiveInjection=(0,eslint_devkit_1.createRule)({name:"no-directive-injection",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-secure-coding/docs/rules/no-directive-injection.md",description:"Detects directive injection vulnerabilities in templates",cwe:"CWE-96"},messages:{directiveInjection:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Directive Injection",cwe:"CWE-96",description:"User input injected into directive or template",severity:"{{severity}}",fix:"{{safeAlternative}}",documentationLink:"https://cwe.mitre.org/data/definitions/96.html"}),unsafeDirectiveName:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Unsafe Directive Name",cwe:"CWE-96",description:"Directive name controlled by user input",severity:"CRITICAL",fix:"Use hardcoded directive names or validate against whitelist",documentationLink:"https://cwe.mitre.org/data/definitions/96.html"}),dynamicDirectiveCreation:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Dynamic Directive Creation",cwe:"CWE-96",description:"Dynamic creation of directives from user input",severity:"HIGH",fix:"Validate directive names against trusted list",documentationLink:"https://cwe.mitre.org/data/definitions/96.html"}),templateInjection:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Template Injection",cwe:"CWE-96",description:"User input injected into template content",severity:"HIGH",fix:"Sanitize template input or use safe rendering",documentationLink:"https://cwe.mitre.org/data/definitions/96.html"}),unsafeComponentBinding:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Unsafe Component Binding",cwe:"CWE-96",description:"Dynamic component binding with user input",severity:"HIGH",fix:"Use component whitelist or validate component names",documentationLink:"https://cwe.mitre.org/data/definitions/96.html"}),userControlledTemplate:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"User Controlled Template",cwe:"CWE-96",description:"Template content controlled by user input",severity:"CRITICAL",fix:"Sanitize template input before compilation",documentationLink:"https://cwe.mitre.org/data/definitions/96.html"}),dangerousInnerHTML:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Dangerous innerHTML",cwe:"CWE-96",description:"innerHTML set with user-controlled content",severity:"HIGH",fix:"Use textContent or sanitize HTML content",documentationLink:"https://developer.mozilla.org/en-US/docs/Web/API/Element/innerHTML"}),untrustedDirectiveSource:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Untrusted Directive Source",cwe:"CWE-96",description:"Directive loaded from untrusted source",severity:"MEDIUM",fix:"Load directives from trusted, verified sources",documentationLink:"https://cwe.mitre.org/data/definitions/96.html"}),useTrustedDirectives:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Use Trusted Directives",description:"Use only trusted, verified directives",severity:"LOW",fix:"Maintain whitelist of allowed directives",documentationLink:"https://cwe.mitre.org/data/definitions/96.html"}),unsafeSanitizerConfig:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Sanitizer configured to allow {{allowed}}",cwe:"CWE-96",description:"DOMPurify was configured with {{option}} re-enabling {{allowed}}, which is exactly what the sanitizer removes by default. The call returns markup that can execute script, so the sanitization provides no protection.",severity:"HIGH",fix:"Drop {{allowed}} from {{option}}. If the markup genuinely needs it, render it outside the sanitized region rather than widening the allow-list.",documentationLink:"https://github.com/cure53/DOMPurify#can-i-configure-dompurify"}),sanitizeTemplateInput:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Sanitize Template Input",description:"Sanitize user input before template processing",severity:"LOW",fix:"Use DOMPurify or equivalent sanitization",documentationLink:"https://github.com/cure53/DOMPurify"}),validateDirectiveNames:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Validate Directive Names",description:"Validate directive names against whitelist",severity:"LOW",fix:"Check directive names before dynamic creation",documentationLink:"https://cwe.mitre.org/data/definitions/96.html"}),strategyTemplateSanitization:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Template Sanitization Strategy",description:"Implement template input sanitization",severity:"LOW",fix:"Sanitize all user input before template processing",documentationLink:"https://owasp.org/www-community/xss-filter-evasion-cheatsheet"}),strategyContentSecurity:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Content Security Strategy",description:"Use CSP to restrict directive execution",severity:"LOW",fix:"Implement strict CSP with script-src restrictions",documentationLink:"https://developer.mozilla.org/en-US/docs/Web/HTTP/CSP"}),strategyInputValidation:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Input Validation Strategy",description:"Validate all template inputs",severity:"LOW",fix:"Use schema validation for template inputs",documentationLink:"https://joi.dev/"})},schema:[{type:"object",properties:{trustedDirectives:{type:"array",items:{type:"string"},default:["ngIf","ngFor","ngClass","v-if","v-for","v-bind","v-on"],description:"Template directives treated as safe"},userInputVariables:{type:"array",items:{type:"string"},default:["req","request","body","query","params","input","data","userInput"],description:"Variable names treated as user-controlled input"},frameworks:{type:"array",items:{type:"string"},default:["angular","vue","react","svelte"],description:"Template frameworks to analyse"},allowDynamicInComponents:{type:"boolean",default:false,description:"Allow dynamic directives inside component code"},trustedSanitizers:{type:"array",items:{type:"string"},default:[],description:"Additional function names to consider as template sanitizers"},trustedAnnotations:{type:"array",items:{type:"string"},default:[],description:"Additional JSDoc annotations to consider as safe markers"},strictMode:{type:"boolean",default:false,description:"Disable all false positive detection (strict mode)"}},additionalProperties:false}]},defaultOptions:[{trustedDirectives:["ngIf","ngFor","ngClass","v-if","v-for","v-bind","v-on"],userInputVariables:["req","request","body","query","params","input","data","userInput"],frameworks:["angular","vue","react","svelte"],allowDynamicInComponents:false,trustedSanitizers:[],trustedAnnotations:[],strictMode:false}],create(context){const options=context.options[0]||{};const{userInputVariables=["req","request","body","query","params","input","data","userInput"],trustedSanitizers=[],trustedAnnotations=[],strictMode=false}=options;const sourceCode=context.sourceCode;const filename=context.filename;const safetyChecker=(0,eslint_devkit_3.createSafetyChecker)({trustedSanitizers,trustedAnnotations,trustedOrmPatterns:[],strictMode});const isUserInput=varName=>{return userInputVariables.some(input=>varName.includes(input))||varName.startsWith("user")};return{JSXAttribute(node){const attrName=node.name;const attrValue=node.value;if(attrName.type==="JSXIdentifier"&&attrName.name==="dangerouslySetInnerHTML"){if(attrValue&&attrValue.type==="JSXExpressionContainer"){const expression=attrValue.expression;const expressionText=sourceCode.getText(expression);if(userInputVariables.some(input=>expressionText.includes(input))){if(safetyChecker.isSafe(node,context)){return}context.report({node:attrValue,messageId:"dangerousInnerHTML",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}}const isNamespaceDirective=attrName.type==="JSXNamespacedName"&&(attrName.namespace.name==="v"||attrName.namespace.name==="ng")||attrName.type==="JSXIdentifier"&&(attrName.name.startsWith("ng:")||attrName.name.startsWith("v:"));if(isNamespaceDirective&&attrValue){if(attrValue.type==="JSXExpressionContainer"){const expression=attrValue.expression;if(expression.type==="Identifier"&&isUserInput(expression.name)){if(safetyChecker.isSafe(node,context)){return}context.report({node:attrValue,messageId:"directiveInjection",data:{filePath:filename,line:String(node.loc?.start.line??0),severity:"HIGH",safeAlternative:"Use hardcoded directive values or validate user input"}})}}}if(attrName.type==="JSXIdentifier"){const attrNameStr=attrName.name;if(attrNameStr==="is"&&attrValue){if(attrValue.type==="JSXExpressionContainer"){const expression=attrValue.expression;if(expression.type==="Identifier"&&isUserInput(expression.name)){if(safetyChecker.isSafe(node,context)){return}context.report({node:attrValue,messageId:"unsafeComponentBinding",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}}}},AssignmentExpression(node){const left=node.left;const right=node.right;if(left.type==="MemberExpression"&&left.property.type==="Identifier"&&left.property.name==="innerHTML"){const isSanitizedValue=right.type==="CallExpression"&&right.callee.type==="MemberExpression"&&right.callee.property.type==="Identifier"&&right.callee.property.name==="sanitize"&&findUnsafeSanitizerConfig(right)===null;if(isSanitizedValue){return}const rightText=sourceCode.getText(right);if(userInputVariables.some(input=>rightText.includes(input))){if(safetyChecker.isSafe(node,context)){return}context.report({node:right,messageId:"dangerousInnerHTML",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}},CallExpression(node){const callee=node.callee;const unsafeConfig=findUnsafeSanitizerConfig(node);if(unsafeConfig){context.report({node:unsafeConfig.node,messageId:"unsafeSanitizerConfig",data:{option:unsafeConfig.option,allowed:unsafeConfig.allowed}})}if(callee.type==="MemberExpression"&&callee.property.type==="Identifier"){const methodName=callee.property.name;const objectName=callee.object.type==="Identifier"?callee.object.name:"";if(["compile","template","$compile","$interpolate"].includes(methodName)||objectName==="Handlebars"&&methodName==="compile"||objectName==="_"&&methodName==="template"||objectName==="ejs"&&methodName==="render"||objectName==="pug"&&methodName==="render"||objectName==="mustache"&&methodName==="render"){const args=node.arguments;if(args.length>0){const templateArg=args[0];if(templateArg.type==="Identifier"&&isUserInput(templateArg.name)){if(safetyChecker.isSafe(node,context)){return}context.report({node:templateArg,messageId:"userControlledTemplate",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}}if(objectName==="Vue"&&methodName==="directive"){const args=node.arguments;if(args.length>=2){const directiveName=args[0];if(directiveName.type==="Identifier"&&isUserInput(directiveName.name)){if(safetyChecker.isSafe(node,context)){return}context.report({node:directiveName,messageId:"unsafeDirectiveName",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}}}if(callee.type==="Identifier"&&callee.name==="directive"){const args=node.arguments;if(args.length>=2){const directiveName=args[0];if(directiveName.type==="Identifier"&&isUserInput(directiveName.name)){if(safetyChecker.isSafe(node,context)){return}context.report({node:directiveName,messageId:"dynamicDirectiveCreation",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}}},TemplateLiteral(node){let current=node;let isInDangerousContext=false;while(current){if(current.type==="JSXExpressionContainer"){if(current.parent?.type==="JSXAttribute"&¤t.parent.name.type==="JSXIdentifier"&¤t.parent.name.name==="dangerouslySetInnerHTML"){isInDangerousContext=true;break}}else if(current.type==="AssignmentExpression"){const left=current.left;if(left.type==="MemberExpression"&&left.property.type==="Identifier"&&left.property.name==="innerHTML"){isInDangerousContext=true;break}}current=current.parent}if(isInDangerousContext){const hasUserInput=node.expressions.some(expr=>expr.type==="Identifier"&&isUserInput(expr.name)||expr.type==="MemberExpression"&&expr.object.type==="Identifier"&&isUserInput(expr.object.name));if(hasUserInput){if(safetyChecker.isSafe(node,context)){return}context.report({node,messageId:"templateInjection",data:{filePath:filename,line:String(node.loc?.start.line??0),severity:"HIGH",safeAlternative:"Sanitize template input before insertion"}})}}}}}});
|
|
@@ -1 +1 @@
|
|
|
1
|
-
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noElectronSecurityIssues=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const eslint_devkit_3=require("@interlace/eslint-devkit");exports.noElectronSecurityIssues=(0,eslint_devkit_1.createRule)({name:"no-electron-security-issues",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-secure-coding/docs/rules/no-electron-security-issues.md",description:"Detects Electron security vulnerabilities and insecure configurations",cwe:"CWE-16"},messages:{electronSecurityIssue:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Electron Security Issue",cwe:"CWE-16",description:"Electron security vulnerability detected",severity:"{{severity}}",fix:"{{safeAlternative}}",documentationLink:"https://electronjs.org/docs/tutorial/security"}),nodeIntegrationEnabled:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Node Integration Enabled",cwe:"CWE-16",description:"nodeIntegration enabled allows Node.js access in renderer",severity:"CRITICAL",fix:"Set nodeIntegration: false and use secure preload scripts",documentationLink:"https://electronjs.org/docs/tutorial/security#2-do-not-enable-nodejs-integration-for-remote-content"}),contextIsolationDisabled:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Context Isolation Disabled",cwe:"CWE-16",description:"contextIsolation disabled removes security boundary",severity:"CRITICAL",fix:"Enable contextIsolation and use preload scripts",documentationLink:"https://electronjs.org/docs/tutorial/context-isolation"}),webSecurityDisabled:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Web Security Disabled",cwe:"CWE-16",description:"webSecurity disabled removes CORS and security protections",severity:"HIGH",fix:"Keep webSecurity enabled",documentationLink:"https://electronjs.org/docs/tutorial/security#6-define-a-content-security-policy"}),insecureContentEnabled:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Insecure Content Enabled",cwe:"CWE-16",description:"allowRunningInsecureContent allows mixed content",severity:"MEDIUM",fix:"Set allowRunningInsecureContent: false",documentationLink:"https://electronjs.org/docs/tutorial/security#5-do-not-disable-websecurity"}),unsafePreloadScript:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Unsafe Preload Script",cwe:"CWE-16",description:"Preload script may expose sensitive APIs",severity:"HIGH",fix:"Use minimal, secure preload scripts",documentationLink:"https://electronjs.org/docs/tutorial/security#3-enable-context-isolation-for-remote-content"}),directNodeAccess:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Direct Node Access",cwe:"CWE-16",description:"Direct access to Node.js APIs in renderer process",severity:"HIGH",fix:"Access Node.js APIs only through secure IPC channels",documentationLink:"https://electronjs.org/docs/tutorial/security#3-enable-context-isolation-for-remote-content"}),insecureIpcPattern:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Insecure IPC Pattern",cwe:"CWE-16",description:"IPC communication lacks proper validation",severity:"MEDIUM",fix:"Validate IPC messages and restrict channels",documentationLink:"https://electronjs.org/docs/tutorial/security#7-do-not-use-the-ipc-transport-for-sensitive-data"}),missingSandbox:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Missing Sandbox",cwe:"CWE-16",description:"BrowserWindow not sandboxed",severity:"MEDIUM",fix:"Enable sandbox for untrusted content",documentationLink:"https://electronjs.org/docs/tutorial/sandbox"}),enableSecurityFeatures:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Enable Security Features",description:"Enable Electron security features",severity:"LOW",fix:"Set contextIsolation: true, nodeIntegration: false",documentationLink:"https://electronjs.org/docs/tutorial/security"}),useContextIsolation:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Use Context Isolation",description:"Use context isolation for security",severity:"LOW",fix:"Enable contextIsolation in BrowserWindow options",documentationLink:"https://electronjs.org/docs/tutorial/context-isolation"}),securePreloadScripts:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Secure Preload Scripts",description:"Use secure preload scripts",severity:"LOW",fix:"Limit APIs exposed in preload scripts",documentationLink:"https://electronjs.org/docs/tutorial/security#3-enable-context-isolation-for-remote-content"}),strategySecureDefaults:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Secure Defaults Strategy",description:"Use secure defaults for Electron applications",severity:"LOW",fix:"Start with secure configuration and relax only when necessary",documentationLink:"https://electronjs.org/docs/tutorial/security"}),strategyProcessSeparation:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Process Separation Strategy",description:"Separate main and renderer processes properly",severity:"LOW",fix:"Keep Node.js APIs in main process, use IPC for communication",documentationLink:"https://electronjs.org/docs/tutorial/application-architecture"}),strategyInputValidation:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Input Validation Strategy",description:"Validate all inputs in Electron applications",severity:"LOW",fix:"Validate IPC messages and user inputs",documentationLink:"https://electronjs.org/docs/tutorial/security#7-do-not-use-the-ipc-transport-for-sensitive-data"})},schema:[{type:"object",properties:{allowInDev:{type:"boolean",default:false,description:"Allow insecure settings in development"},safePreloadPatterns:{type:"array",items:{type:"string"},default:["contextBridge","ipcRenderer"],description:"Preload-script APIs treated as safe"},allowedIpcChannels:{type:"array",items:{type:"string"},default:[],description:"IPC channel names allowed without validation"},trustedSanitizers:{type:"array",items:{type:"string"},default:[],description:"Additional function names to consider as safe"},trustedAnnotations:{type:"array",items:{type:"string"},default:[],description:"Additional JSDoc annotations to consider as safe markers"},strictMode:{type:"boolean",default:false,description:"Disable all false positive detection (strict mode)"}},additionalProperties:false}]},defaultOptions:[{allowInDev:false,safePreloadPatterns:["contextBridge","ipcRenderer"],allowedIpcChannels:[],trustedSanitizers:[],trustedAnnotations:[],strictMode:false}],create(context){const options=context.options[0]||{};const{allowedIpcChannels=[],trustedSanitizers=[],trustedAnnotations=[],strictMode=false}=options;const filename=context.filename;const safetyChecker=(0,eslint_devkit_3.createSafetyChecker)({trustedSanitizers,trustedAnnotations,trustedOrmPatterns:[],strictMode});const isBrowserWindowCreation=node=>{return node.callee.type==="Identifier"&&node.callee.name==="BrowserWindow"};const checkBrowserWindowOptions=optionsNode=>{for(const prop of optionsNode.properties){if(prop.type==="Property"&&prop.key.type==="Identifier"){const key=prop.key.name;const value=prop.value;if(["nodeIntegration","contextIsolation","webSecurity","allowRunningInsecureContent","sandbox"].includes(key)){if(value.type==="Literal"){const isInsecure=key==="nodeIntegration"&&value.value===true||key==="contextIsolation"&&value.value===false||key==="webSecurity"&&value.value===false||key==="allowRunningInsecureContent"&&value.value===true||key==="sandbox"&&value.value===false;if(isInsecure){if(safetyChecker.isSafe(prop,context)){continue}const messageId=key==="nodeIntegration"?"nodeIntegrationEnabled":key==="contextIsolation"?"contextIsolationDisabled":key==="webSecurity"?"webSecurityDisabled":key==="allowRunningInsecureContent"?"insecureContentEnabled":"missingSandbox";context.report({node:prop,messageId,data:{filePath:filename,line:String(prop.loc?.start.line??0)}})}}}}}};const isIpcCall=node=>{const callee=node.callee;if(callee.type==="MemberExpression"&&callee.object.type==="Identifier"&&["ipcMain","ipcRenderer"].includes(callee.object.name)&&callee.property.type==="Identifier"){return["send","invoke","handle","on","once"].includes(callee.property.name)}return false};const checkIpcCall=node=>{const args=node.arguments;if(args.length===0){return}const channelArg=args[0];if(channelArg.type==="Literal"&&typeof channelArg.value==="string"){const channel=channelArg.value;if(allowedIpcChannels.length>0&&!allowedIpcChannels.includes(channel)){if(safetyChecker.isSafe(node,context)){return}context.report({node:channelArg,messageId:"insecureIpcPattern",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}};const isRendererFile=()=>{const fileName=filename.toLowerCase();return fileName.includes("renderer")||fileName.includes("preload")||fileName.includes("ui")||fileName.includes("view")};const isNodeApiCall=node=>{const callee=node.callee;if(callee.type==="Identifier"&&callee.name==="require"){const arg=node.arguments[0];if(arg?.type==="Literal"&&typeof arg.value==="string"){const moduleName=arg.value;return["fs","child_process","os","path","crypto","http","https"].includes(moduleName)}}if(callee.type==="MemberExpression"&&callee.object.type==="Identifier"&&["process","global","__dirname","__filename"].includes(callee.object.name)){return true}return false};return{NewExpression(node){try{if(isBrowserWindowCreation(node)){const args=node.arguments;if(args.length>0&&args[0]?.type==="ObjectExpression"){checkBrowserWindowOptions(args[0])}}}catch{return}},CallExpression(node){try{if(isIpcCall(node)){checkIpcCall(node)}if(isRendererFile()&&isNodeApiCall(node)){if(safetyChecker.isSafe(node,context)){return}context.report({node,messageId:"directNodeAccess",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}catch{return}},AssignmentExpression(node){try{if(node.left.type==="MemberExpression"&&node.left.property.type==="Identifier"&&node.left.property.name==="preload"){if(node.right.type==="Literal"&&typeof node.right.value==="string"){const preloadPath=node.right.value;if(preloadPath.includes("node_modules")||preloadPath.includes("http")||preloadPath.includes("remote")){if(safetyChecker.isSafe(node,context)){return}context.report({node:node.right,messageId:"unsafePreloadScript",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}}}catch{return}},Property(node){try{if(node.key.type==="Identifier"&&node.key.name==="webPreferences"){if(node.value.type==="ObjectExpression"){checkBrowserWindowOptions(node.value)}}}catch{return}}}}});
|
|
1
|
+
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noElectronSecurityIssues=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const eslint_devkit_3=require("@interlace/eslint-devkit");exports.noElectronSecurityIssues=(0,eslint_devkit_1.createRule)({name:"no-electron-security-issues",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-secure-coding/docs/rules/no-electron-security-issues.md",description:"Detects Electron security vulnerabilities and insecure configurations",cwe:"CWE-16"},messages:{electronSecurityIssue:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Electron Security Issue",cwe:"CWE-16",description:"Electron security vulnerability detected",severity:"{{severity}}",fix:"{{safeAlternative}}",documentationLink:"https://electronjs.org/docs/tutorial/security"}),nodeIntegrationEnabled:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Node Integration Enabled",cwe:"CWE-16",description:"nodeIntegration enabled allows Node.js access in renderer",severity:"CRITICAL",fix:"Set nodeIntegration: false and use secure preload scripts",documentationLink:"https://electronjs.org/docs/tutorial/security#2-do-not-enable-nodejs-integration-for-remote-content"}),contextIsolationDisabled:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Context Isolation Disabled",cwe:"CWE-16",description:"contextIsolation disabled removes security boundary",severity:"CRITICAL",fix:"Enable contextIsolation and use preload scripts",documentationLink:"https://electronjs.org/docs/tutorial/context-isolation"}),webSecurityDisabled:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Web Security Disabled",cwe:"CWE-16",description:"webSecurity disabled removes CORS and security protections",severity:"HIGH",fix:"Keep webSecurity enabled",documentationLink:"https://electronjs.org/docs/tutorial/security#6-define-a-content-security-policy"}),insecureContentEnabled:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Insecure Content Enabled",cwe:"CWE-16",description:"allowRunningInsecureContent allows mixed content",severity:"MEDIUM",fix:"Set allowRunningInsecureContent: false",documentationLink:"https://electronjs.org/docs/tutorial/security#5-do-not-disable-websecurity"}),unsafePreloadScript:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Unsafe Preload Script",cwe:"CWE-16",description:"Preload script may expose sensitive APIs",severity:"HIGH",fix:"Use minimal, secure preload scripts",documentationLink:"https://electronjs.org/docs/tutorial/security#3-enable-context-isolation-for-remote-content"}),directNodeAccess:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Direct Node Access",cwe:"CWE-16",description:"Direct access to Node.js APIs in renderer process",severity:"HIGH",fix:"Access Node.js APIs only through secure IPC channels",documentationLink:"https://electronjs.org/docs/tutorial/security#3-enable-context-isolation-for-remote-content"}),insecureIpcPattern:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Insecure IPC Pattern",cwe:"CWE-16",description:"IPC communication lacks proper validation",severity:"MEDIUM",fix:"Validate IPC messages and restrict channels",documentationLink:"https://electronjs.org/docs/tutorial/security#7-do-not-use-the-ipc-transport-for-sensitive-data"}),missingSandbox:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Missing Sandbox",cwe:"CWE-16",description:"BrowserWindow not sandboxed",severity:"MEDIUM",fix:"Enable sandbox for untrusted content",documentationLink:"https://electronjs.org/docs/tutorial/sandbox"}),enableSecurityFeatures:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Enable Security Features",description:"Enable Electron security features",severity:"LOW",fix:"Set contextIsolation: true, nodeIntegration: false",documentationLink:"https://electronjs.org/docs/tutorial/security"}),useContextIsolation:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Use Context Isolation",description:"Use context isolation for security",severity:"LOW",fix:"Enable contextIsolation in BrowserWindow options",documentationLink:"https://electronjs.org/docs/tutorial/context-isolation"}),securePreloadScripts:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Secure Preload Scripts",description:"Use secure preload scripts",severity:"LOW",fix:"Limit APIs exposed in preload scripts",documentationLink:"https://electronjs.org/docs/tutorial/security#3-enable-context-isolation-for-remote-content"}),strategySecureDefaults:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Secure Defaults Strategy",description:"Use secure defaults for Electron applications",severity:"LOW",fix:"Start with secure configuration and relax only when necessary",documentationLink:"https://electronjs.org/docs/tutorial/security"}),strategyProcessSeparation:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Process Separation Strategy",description:"Separate main and renderer processes properly",severity:"LOW",fix:"Keep Node.js APIs in main process, use IPC for communication",documentationLink:"https://electronjs.org/docs/tutorial/application-architecture"}),strategyInputValidation:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Input Validation Strategy",description:"Validate all inputs in Electron applications",severity:"LOW",fix:"Validate IPC messages and user inputs",documentationLink:"https://electronjs.org/docs/tutorial/security#7-do-not-use-the-ipc-transport-for-sensitive-data"})},schema:[{type:"object",properties:{allowInDev:{type:"boolean",default:false,description:"Allow insecure settings in development"},safePreloadPatterns:{type:"array",items:{type:"string"},default:["contextBridge","ipcRenderer"],description:"Preload-script APIs treated as safe"},allowedIpcChannels:{type:"array",items:{type:"string"},default:[],description:"IPC channel names allowed without validation"},trustedSanitizers:{type:"array",items:{type:"string"},default:[],description:"Additional function names to consider as safe"},trustedAnnotations:{type:"array",items:{type:"string"},default:[],description:"Additional JSDoc annotations to consider as safe markers"},strictMode:{type:"boolean",default:false,description:"Disable all false positive detection (strict mode)"}},additionalProperties:false}]},defaultOptions:[{allowInDev:false,safePreloadPatterns:["contextBridge","ipcRenderer"],allowedIpcChannels:[],trustedSanitizers:[],trustedAnnotations:[],strictMode:false}],create(context){const options=context.options[0]||{};const{allowedIpcChannels=[],trustedSanitizers=[],trustedAnnotations=[],strictMode=false}=options;const filename=context.filename;const safetyChecker=(0,eslint_devkit_3.createSafetyChecker)({trustedSanitizers,trustedAnnotations,trustedOrmPatterns:[],strictMode});const isBrowserWindowCreation=node=>{return node.callee.type==="Identifier"&&node.callee.name==="BrowserWindow"};const checkBrowserWindowOptions=optionsNode=>{for(const prop of optionsNode.properties){if(prop.type==="Property"&&prop.key.type==="Identifier"){const key=prop.key.name;const value=prop.value;if(["nodeIntegration","contextIsolation","webSecurity","allowRunningInsecureContent","sandbox"].includes(key)){if(value.type==="Literal"){const isInsecure=key==="nodeIntegration"&&value.value===true||key==="contextIsolation"&&value.value===false||key==="webSecurity"&&value.value===false||key==="allowRunningInsecureContent"&&value.value===true||key==="sandbox"&&value.value===false;if(isInsecure){if(safetyChecker.isSafe(prop,context)){continue}const messageId=key==="nodeIntegration"?"nodeIntegrationEnabled":key==="contextIsolation"?"contextIsolationDisabled":key==="webSecurity"?"webSecurityDisabled":key==="allowRunningInsecureContent"?"insecureContentEnabled":"missingSandbox";context.report({node:prop,messageId,data:{filePath:filename,line:String(prop.loc?.start.line??0)}})}}}}}};const isIpcCall=node=>{const callee=node.callee;if(callee.type==="MemberExpression"&&callee.object.type==="Identifier"&&["ipcMain","ipcRenderer"].includes(callee.object.name)&&callee.property.type==="Identifier"){return["send","invoke","handle","on","once"].includes(callee.property.name)}return false};const checkIpcCall=node=>{const args=node.arguments;if(args.length===0){return}const channelArg=args[0];if(channelArg.type==="Literal"&&typeof channelArg.value==="string"){const channel=channelArg.value;if(allowedIpcChannels.length>0&&!allowedIpcChannels.includes(channel)){if(safetyChecker.isSafe(node,context)){return}context.report({node:channelArg,messageId:"insecureIpcPattern",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}};const isRendererFile=()=>{const segments=filename.toLowerCase().split(/[\\/]/).filter(Boolean);if(segments.length===0)return false;const base=segments[segments.length-1].replace(/\.[cm]?[jt]sx?$/,"");const dirs=segments.slice(0,-1);return base==="renderer"||base==="preload"||base.startsWith("renderer.")||base.startsWith("preload.")||dirs.includes("renderer")||dirs.includes("preload")||dirs.includes("ui")||dirs.includes("view")||dirs.includes("views")};const isNodeApiCall=node=>{const callee=node.callee;if(callee.type==="Identifier"&&callee.name==="require"){const arg=node.arguments[0];if(arg?.type==="Literal"&&typeof arg.value==="string"){const moduleName=arg.value;return["fs","child_process","os","path","crypto","http","https"].includes(moduleName)}}if(callee.type==="MemberExpression"&&callee.object.type==="Identifier"&&["process","global","__dirname","__filename"].includes(callee.object.name)){return true}return false};return{NewExpression(node){try{if(isBrowserWindowCreation(node)){const args=node.arguments;if(args.length>0&&args[0]?.type==="ObjectExpression"){checkBrowserWindowOptions(args[0])}}}catch{return}},CallExpression(node){try{if(isIpcCall(node)){checkIpcCall(node)}if(isRendererFile()&&isNodeApiCall(node)){if(safetyChecker.isSafe(node,context)){return}context.report({node,messageId:"directNodeAccess",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}catch{return}},AssignmentExpression(node){try{if(node.left.type==="MemberExpression"&&node.left.property.type==="Identifier"&&node.left.property.name==="preload"){if(node.right.type==="Literal"&&typeof node.right.value==="string"){const preloadPath=node.right.value;if(preloadPath.includes("node_modules")||preloadPath.includes("http")||preloadPath.includes("remote")){if(safetyChecker.isSafe(node,context)){return}context.report({node:node.right,messageId:"unsafePreloadScript",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}}}catch{return}},Property(node){try{if(node.key.type==="Identifier"&&node.key.name==="webPreferences"){if(node.value.type==="ObjectExpression"){checkBrowserWindowOptions(node.value)}}}catch{return}}}}});
|
|
@@ -1 +1 @@
|
|
|
1
|
-
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noFormatStringInjection=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");exports.noFormatStringInjection=(0,eslint_devkit_1.createRule)({name:"no-format-string-injection",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-secure-coding/docs/rules/no-format-string-injection.md",description:"Detects format string injection vulnerabilities",cwe:"CWE-134"},fixable:"code",hasSuggestions:true,messages:{formatStringInjection:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Format String Injection",cwe:"CWE-134",description:"Format string controlled by user input",severity:"{{severity}}",fix:"{{safeAlternative}}",documentationLink:"https://cwe.mitre.org/data/definitions/134.html"}),unsafeFormatSpecifier:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Unsafe Format Specifier",cwe:"CWE-134",description:"User input may contain format specifiers",severity:"MEDIUM",fix:"Escape or validate user input before formatting",documentationLink:"https://cwe.mitre.org/data/definitions/134.html"}),userControlledFormatString:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"User Controlled Format String",cwe:"CWE-134",description:"Format string parameter comes from user input",severity:"CRITICAL",fix:"Use hardcoded format strings or validate user formats",documentationLink:"https://cwe.mitre.org/data/definitions/134.html"}),missingFormatValidation:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Missing Format Validation",cwe:"CWE-134",description:"Format string not validated before use",severity:"HIGH",fix:"Validate format strings against allowed patterns",documentationLink:"https://cwe.mitre.org/data/definitions/134.html"}),escapeFormatString:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Escape Format String",description:"Escape format specifiers in user input",severity:"LOW",fix:"Replace % with %% in user input",documentationLink:"https://nodejs.org/api/util.html#utilformatformat-args"}),useSafeFormatting:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Use Safe Formatting",description:"Use safe string formatting methods",severity:"LOW",fix:"Use template literals or safe format libraries",documentationLink:"https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals"})},schema:[{type:"object",properties:{formatFunctions:{type:"array",items:{type:"string"},default:["util.format","console.log","console.error","console.warn","sprintf","printf","vsprintf"],description:"Functions whose first argument is a format string"},formatSpecifiers:{type:"array",items:{type:"string"},default:["%s","%d","%i","%f","%j","%o","%O","%c","%%"],description:"Format specifiers recognised in a format string"},userInputVariables:{type:"array",items:{type:"string"},default:["req","request","body","query","params","input","data","userInput"],description:"Variable names treated as user-controlled input"},safeFormatLibraries:{type:"array",items:{type:"string"},default:["mustache","handlebars","ejs","pug"],description:"Templating libraries that escape their own input"},trustedSanitizers:{type:"array",items:{type:"string"},default:[],description:"Additional function names to consider as format string sanitizers"},trustedAnnotations:{type:"array",items:{type:"string"},default:[],description:"Additional JSDoc annotations to consider as safe markers"},strictMode:{type:"boolean",default:false,description:"Disable all false positive detection (strict mode)"}},additionalProperties:false}]},defaultOptions:[{formatFunctions:["util.format","console.log","console.error","console.warn","sprintf","printf","vsprintf"],formatSpecifiers:["%s","%d","%i","%f","%j","%o","%O","%c","%%"],userInputVariables:["req","request","body","query","params","input","data","userInput"],safeFormatLibraries:["mustache","handlebars","ejs","pug"],trustedSanitizers:["validateFormat","sanitizeFormat","escapeFormat","cleanFormat","sanitizeFormatString","validate","sanitize","escape","clean"],trustedAnnotations:[],strictMode:false}],create(context){const defaultOptions={formatFunctions:["util.format","console.log","console.error","console.warn","sprintf","printf","vsprintf"],formatSpecifiers:["%s","%d","%i","%f","%j","%o","%O","%c","%%"],userInputVariables:["req","request","body","query","params","input","data","userInput"],safeFormatLibraries:["mustache","handlebars","ejs","pug"],trustedSanitizers:["validateFormat","sanitizeFormat","escapeFormat","cleanFormat","sanitizeFormatString","validate","sanitize","escape","clean"],trustedAnnotations:[],strictMode:false};const options={...defaultOptions,...context.options[0]};const{formatSpecifiers,userInputVariables,trustedSanitizers}=options;const filename=context.filename;const safetyChecker={isSafe:(safeNode,ruleCtx)=>{const comments=ruleCtx.sourceCode.getCommentsBefore(safeNode);for(const comment of comments){if(comment.type==="Block"&&comment.value.includes("@safe-format")){return true}}if(safeNode.type==="CallExpression"&&safeNode.arguments.length>0){const firstArg=safeNode.arguments[0];if(firstArg.type==="Identifier"&&validatedVariables.has(firstArg.name)){return true}}return false}};const isUserInput=varName=>{const lowerName=varName.toLowerCase();return userInputVariables.some(input=>lowerName.includes(input.toLowerCase()))||lowerName==="user"||lowerName.includes("userinput")||lowerName.includes("userdata")||lowerName.includes("userparam")||lowerName.includes("usermessage")||lowerName.includes("usertemplate")||lowerName.includes("userformat")||lowerName.includes("uservar")};const isUserInputNode=node=>{if(node.type==="Identifier"){return isUserInput(node.name)||dangerousVariables.has(node.name)}if(node.type==="MemberExpression"){if(node.object.type==="MemberExpression"&&node.object.object.type==="Identifier"&&node.object.object.name==="req"&&node.object.property.type==="Identifier"&&["query","body","params","param"].includes(node.object.property.name)){return true}if(node.object.type==="Identifier"&&node.object.name==="req"){return true}const fullName=getMemberExpressionName(node);return isUserInput(fullName)}return false};const getMemberExpressionName=node=>{if(node.object.type==="Identifier"){if(node.property.type==="Identifier"){return`${node.object.name}.${node.property.name}`}}else if(node.object.type==="MemberExpression"){const objectName=getMemberExpressionName(node.object);if(node.property.type==="Identifier"){return`${objectName}.${node.property.name}`}}return""};const containsFormatSpecifiers=text=>{return formatSpecifiers.some(specifier=>text.includes(specifier))};const isConsoleMethod=node=>{const callee=node.callee;return callee.type==="MemberExpression"&&callee.object.type==="Identifier"&&callee.object.name==="console"&&callee.property.type==="Identifier"&&["log","error","warn","info","debug"].includes(callee.property.name)};const isFormatFunctionCall=node=>{const callee=node.callee;if(callee.type==="MemberExpression"&&callee.object.type==="Identifier"&&callee.object.name==="util"&&callee.property.type==="Identifier"&&callee.property.name==="format"){return true}if(callee.type==="MemberExpression"&&callee.object.type==="Identifier"&&callee.object.name==="console"&&callee.property.type==="Identifier"&&["log","error","warn","info","debug"].includes(callee.property.name)){return true}if(callee.type==="Identifier"&&["sprintf","printf","vsprintf"].includes(callee.name)){return true}return false};const validatedVariables=new Set;const dangerousVariables=new Set;const isInputValidated=inputNode=>{if(inputNode.type==="Identifier"&&validatedVariables.has(inputNode.name)){return true}let current=inputNode;while(current){if(current.type==="CallExpression"&¤t.callee.type==="Identifier"&&trustedSanitizers.includes(current.callee.name)){return true}current=current.parent}return false};const hasFormatSpecifiers=node=>{if(typeof node.value!=="string"){return false}return containsFormatSpecifiers(node.value)};function containsFormatSpecifiersInExpression(expr){if(expr.left.type==="Literal"&&typeof expr.left.value==="string"&&containsFormatSpecifiers(expr.left.value)){return true}if(expr.right.type==="Literal"&&typeof expr.right.value==="string"&&containsFormatSpecifiers(expr.right.value)){return true}if(expr.left.type==="BinaryExpression"&&containsFormatSpecifiersInExpression(expr.left)){return true}if(expr.right.type==="BinaryExpression"&&containsFormatSpecifiersInExpression(expr.right)){return true}return false}function hasUserInputInExpression(expr){if(isUserInputNode(expr.left)){return true}if(isUserInputNode(expr.right)){return true}if(expr.left.type==="BinaryExpression"&&hasUserInputInExpression(expr.left)){return true}if(expr.right.type==="BinaryExpression"&&hasUserInputInExpression(expr.right)){return true}return false}return{CallExpression:function(node){if(!isFormatFunctionCall(node)){return}const args=node.arguments;if(args.length===0){return}const formatArg=args[0];const isFormatFromUserInput=isUserInputNode(formatArg)||formatArg.type==="Identifier"&&dangerousVariables.has(formatArg.name)||formatArg.type==="BinaryExpression"&&hasUserInputInExpression(formatArg);if(isFormatFromUserInput&&!isConsoleMethod(node)){if(safetyChecker.isSafe(node,context)){return}context.report({node:formatArg,messageId:"userControlledFormatString",data:{filePath:filename,line:String(node.loc?.start.line??0)}});return}if(formatArg.type==="TemplateLiteral"){const hasUserInput=formatArg.expressions.some(expr=>isUserInputNode(expr));if(hasUserInput){if(safetyChecker.isSafe(node,context)){return}context.report({node:formatArg,messageId:"formatStringInjection",data:{filePath:filename,line:String(node.loc?.start.line??0),severity:"HIGH",safeAlternative:"Use hardcoded format strings or validate template input"}});return}}else if(formatArg.type==="BinaryExpression"&&formatArg.operator==="+"){const hasUserInput=hasUserInputInExpression(formatArg);if(hasUserInput){if(safetyChecker.isSafe(node,context)){return}context.report({node:formatArg,messageId:"formatStringInjection",data:{filePath:filename,line:String(node.loc?.start.line??0),severity:"HIGH",safeAlternative:"Separate user input from format strings"}});return}}const fmtArg=args[0];const isFormatSafe=isInputValidated(fmtArg)||fmtArg.type==="Identifier"&&validatedVariables.has(fmtArg.name);if(!isFormatSafe){let hasUserInputInArgs=false;let hasSpecifiersInFormat=false;for(let i=1;i<args.length;i++){const arg=args[i];if(isUserInputNode(arg)&&!isInputValidated(arg)){hasUserInputInArgs=true;break}}const firstArg=args[0];if(firstArg.type==="Literal"&&typeof firstArg.value==="string"){if(containsFormatSpecifiers(firstArg.value)){hasSpecifiersInFormat=true}}else if(firstArg.type==="Identifier"){const varName=firstArg.name.toLowerCase();if(varName.includes("format")||varName.includes("template")||varName.includes("pattern")){hasSpecifiersInFormat=true}}if(!hasSpecifiersInFormat&&args.length===2&&isConsoleMethod(node)){}else if(hasSpecifiersInFormat&&hasUserInputInArgs){if(safetyChecker.isSafe(node,context)){return}const messageId=firstArg.type==="Literal"?"unsafeFormatSpecifier":"missingFormatValidation";context.report({node,messageId,data:{filePath:filename,line:String(node.loc?.start.line??0)},suggest:[{messageId:"escapeFormatString",fix:fixer=>{const arg=node.arguments.slice(1).find(a=>isUserInputNode(a));return fixer.insertTextAfter(arg,'.replace(/%/g, "%%")')}}]})}}},Literal:function(node){if(!hasFormatSpecifiers(node)){return}const text=node.value;let current=node;let isFromUserInput=false;while(current){if(current.type==="BinaryExpression"&¤t.operator==="+"&&(current.left===node||current.right===node)){const otherSide=current.left===node?current.right:current.left;if(otherSide.type==="Identifier"&&isUserInput(otherSide.name)){isFromUserInput=true;break}}if(current.type==="VariableDeclarator"&¤t.init===node.parent&¤t.id.type==="Identifier"){if(isUserInput(current.id.name)){isFromUserInput=true;break}}current=current.parent}if(!isFromUserInput){return}current=node;let isInDangerousContext=false;while(current){if(current.type==="CallExpression"&&isFormatFunctionCall(current)){const args=current.arguments;if(args.length>0&&args[0]===node){isInDangerousContext=true;break}}current=current.parent}if(isInDangerousContext&&containsFormatSpecifiers(text)){if(safetyChecker.isSafe(node,context)){return}context.report({node,messageId:"missingFormatValidation",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}},TemplateLiteral:function(node){let templateCurrent=node;let isFormatString=false;while(templateCurrent){if(templateCurrent.type==="CallExpression"&&isFormatFunctionCall(templateCurrent)){const args=templateCurrent.arguments;if(args.length>0&&args[0]===node){isFormatString=true;break}}templateCurrent=templateCurrent.parent}if(isFormatString){return}const hasUserInput=node.expressions.some(expr=>isUserInputNode(expr));if(hasUserInput){let assignCurrent=node;let isAssignedToVariable=false;while(assignCurrent){if(assignCurrent.type==="VariableDeclarator"){isAssignedToVariable=true;break}assignCurrent=assignCurrent.parent}if(isAssignedToVariable){if(safetyChecker.isSafe(node,context)){return}context.report({node,messageId:"formatStringInjection",data:{filePath:filename,line:String(node.loc?.start.line??0),severity:"HIGH",safeAlternative:"Extract user input from template and validate separately"}})}}},VariableDeclarator:function(node){if(!node.init||node.id.type!=="Identifier"){return}const varName=node.id.name;if(node.init.type==="CallExpression"&&node.init.callee.type==="Identifier"&&trustedSanitizers.includes(node.init.callee.name)){validatedVariables.add(varName)}if(isUserInputNode(node.init)||node.init.type==="BinaryExpression"&&hasUserInputInExpression(node.init)){dangerousVariables.add(varName)}const varNameLower=varName.toLowerCase();if(!varNameLower.includes("format")&&!varNameLower.includes("template")&&!varNameLower.includes("fmt")&&!varNameLower.includes("str")){return}if(node.init.type==="TemplateLiteral"){const hasSpecifiers=node.init.quasis.some(quasi=>containsFormatSpecifiers(quasi.value.raw));const hasUserInput=node.init.expressions.some(expr=>isUserInputNode(expr));if(hasSpecifiers&&hasUserInput){if(safetyChecker.isSafe(node,context)){return}context.report({node:node.init,messageId:"formatStringInjection",data:{filePath:filename,line:String(node.loc?.start.line??0),severity:"MEDIUM",safeAlternative:"Separate format string from user data"}})}}if(node.init.type==="BinaryExpression"&&node.init.operator==="+"){const hasSpecifiers=containsFormatSpecifiersInExpression(node.init);const hasUserInput=hasUserInputInExpression(node.init);if(hasSpecifiers&&hasUserInput){if(safetyChecker.isSafe(node,context)){return}context.report({node:node.init,messageId:"formatStringInjection",data:{filePath:filename,line:String(node.loc?.start.line??0),severity:"MEDIUM",safeAlternative:"Separate format string from user data"}})}}}}}});
|
|
1
|
+
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noFormatStringInjection=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");exports.noFormatStringInjection=(0,eslint_devkit_1.createRule)({name:"no-format-string-injection",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-secure-coding/docs/rules/no-format-string-injection.md",description:"Detects format string injection vulnerabilities",cwe:"CWE-134"},fixable:"code",hasSuggestions:true,messages:{formatStringInjection:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Format String Injection",cwe:"CWE-134",description:"Format string controlled by user input",severity:"{{severity}}",fix:"{{safeAlternative}}",documentationLink:"https://cwe.mitre.org/data/definitions/134.html"}),unsafeFormatSpecifier:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Unsafe Format Specifier",cwe:"CWE-134",description:"User input may contain format specifiers",severity:"MEDIUM",fix:"Escape or validate user input before formatting",documentationLink:"https://cwe.mitre.org/data/definitions/134.html"}),userControlledFormatString:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"User Controlled Format String",cwe:"CWE-134",description:"Format string parameter comes from user input",severity:"CRITICAL",fix:"Use hardcoded format strings or validate user formats",documentationLink:"https://cwe.mitre.org/data/definitions/134.html"}),missingFormatValidation:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Missing Format Validation",cwe:"CWE-134",description:"Format string not validated before use",severity:"HIGH",fix:"Validate format strings against allowed patterns",documentationLink:"https://cwe.mitre.org/data/definitions/134.html"}),escapeFormatString:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Escape Format String",description:"Escape format specifiers in user input",severity:"LOW",fix:"Replace % with %% in user input",documentationLink:"https://nodejs.org/api/util.html#utilformatformat-args"}),useSafeFormatting:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Use Safe Formatting",description:"Use safe string formatting methods",severity:"LOW",fix:"Use template literals or safe format libraries",documentationLink:"https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals"})},schema:[{type:"object",properties:{formatFunctions:{type:"array",items:{type:"string"},default:["util.format","console.log","console.error","console.warn","sprintf","printf","vsprintf"],description:"Functions whose first argument is a format string"},formatSpecifiers:{type:"array",items:{type:"string"},default:["%s","%d","%i","%f","%j","%o","%O","%c","%%"],description:"Format specifiers recognised in a format string"},userInputVariables:{type:"array",items:{type:"string"},default:["req","request","body","query","params","input","data","userInput"],description:"Variable names treated as user-controlled input"},safeFormatLibraries:{type:"array",items:{type:"string"},default:["mustache","handlebars","ejs","pug"],description:"Templating libraries that escape their own input"},trustedSanitizers:{type:"array",items:{type:"string"},default:[],description:"Additional function names to consider as format string sanitizers"},trustedAnnotations:{type:"array",items:{type:"string"},default:[],description:"Additional JSDoc annotations to consider as safe markers"},strictMode:{type:"boolean",default:false,description:"Disable all false positive detection (strict mode)"}},additionalProperties:false}]},defaultOptions:[{formatFunctions:["util.format","console.log","console.error","console.warn","sprintf","printf","vsprintf"],formatSpecifiers:["%s","%d","%i","%f","%j","%o","%O","%c","%%"],userInputVariables:["req","request","body","query","params","input","data","userInput"],safeFormatLibraries:["mustache","handlebars","ejs","pug"],trustedSanitizers:["validateFormat","sanitizeFormat","escapeFormat","cleanFormat","sanitizeFormatString","validate","sanitize","escape","clean"],trustedAnnotations:[],strictMode:false}],create(context){const defaultOptions={formatFunctions:["util.format","console.log","console.error","console.warn","sprintf","printf","vsprintf"],formatSpecifiers:["%s","%d","%i","%f","%j","%o","%O","%c","%%"],userInputVariables:["req","request","body","query","params","input","data","userInput"],safeFormatLibraries:["mustache","handlebars","ejs","pug"],trustedSanitizers:["validateFormat","sanitizeFormat","escapeFormat","cleanFormat","sanitizeFormatString","validate","sanitize","escape","clean"],trustedAnnotations:[],strictMode:false};const options={...defaultOptions,...context.options[0]};const{formatSpecifiers,userInputVariables,trustedSanitizers}=options;const filename=context.filename;const reportedTemplates=new WeakSet;const safetyChecker={isSafe:(safeNode,ruleCtx)=>{const comments=ruleCtx.sourceCode.getCommentsBefore(safeNode);for(const comment of comments){if(comment.type==="Block"&&comment.value.includes("@safe-format")){return true}}if(safeNode.type==="CallExpression"&&safeNode.arguments.length>0){const firstArg=safeNode.arguments[0];if(firstArg.type==="Identifier"&&validatedVariables.has(firstArg.name)){return true}}return false}};const isUserInput=varName=>{const lowerName=varName.toLowerCase();return userInputVariables.some(input=>lowerName.includes(input.toLowerCase()))||lowerName==="user"||lowerName.includes("userinput")||lowerName.includes("userdata")||lowerName.includes("userparam")||lowerName.includes("usermessage")||lowerName.includes("usertemplate")||lowerName.includes("userformat")||lowerName.includes("uservar")};const isUserInputNode=node=>{if(node.type==="Identifier"){return isUserInput(node.name)||dangerousVariables.has(node.name)}if(node.type==="MemberExpression"){if(node.object.type==="MemberExpression"&&node.object.object.type==="Identifier"&&node.object.object.name==="req"&&node.object.property.type==="Identifier"&&["query","body","params","param"].includes(node.object.property.name)){return true}if(node.object.type==="Identifier"&&node.object.name==="req"){return true}const fullName=getMemberExpressionName(node);return isUserInput(fullName)}return false};const getMemberExpressionName=node=>{if(node.object.type==="Identifier"){if(node.property.type==="Identifier"){return`${node.object.name}.${node.property.name}`}}else if(node.object.type==="MemberExpression"){const objectName=getMemberExpressionName(node.object);if(node.property.type==="Identifier"){return`${objectName}.${node.property.name}`}}return""};const containsFormatSpecifiers=text=>{return formatSpecifiers.some(specifier=>text.includes(specifier))};const isConsoleMethod=node=>{const callee=node.callee;return callee.type==="MemberExpression"&&callee.object.type==="Identifier"&&callee.object.name==="console"&&callee.property.type==="Identifier"&&["log","error","warn","info","debug"].includes(callee.property.name)};const isFormatFunctionCall=node=>{const callee=node.callee;if(callee.type==="MemberExpression"&&callee.object.type==="Identifier"&&callee.object.name==="util"&&callee.property.type==="Identifier"&&callee.property.name==="format"){return true}if(callee.type==="MemberExpression"&&callee.object.type==="Identifier"&&callee.object.name==="console"&&callee.property.type==="Identifier"&&["log","error","warn","info","debug"].includes(callee.property.name)){return true}if(callee.type==="Identifier"&&["sprintf","printf","vsprintf"].includes(callee.name)){return true}return false};const validatedVariables=new Set;const dangerousVariables=new Set;const isInputValidated=inputNode=>{if(inputNode.type==="Identifier"&&validatedVariables.has(inputNode.name)){return true}let current=inputNode;while(current){if(current.type==="CallExpression"&¤t.callee.type==="Identifier"&&trustedSanitizers.includes(current.callee.name)){return true}current=current.parent}return false};const hasFormatSpecifiers=node=>{if(typeof node.value!=="string"){return false}return containsFormatSpecifiers(node.value)};function containsFormatSpecifiersInExpression(expr){if(expr.left.type==="Literal"&&typeof expr.left.value==="string"&&containsFormatSpecifiers(expr.left.value)){return true}if(expr.right.type==="Literal"&&typeof expr.right.value==="string"&&containsFormatSpecifiers(expr.right.value)){return true}if(expr.left.type==="BinaryExpression"&&containsFormatSpecifiersInExpression(expr.left)){return true}if(expr.right.type==="BinaryExpression"&&containsFormatSpecifiersInExpression(expr.right)){return true}return false}function hasUserInputInExpression(expr){if(isUserInputNode(expr.left)){return true}if(isUserInputNode(expr.right)){return true}if(expr.left.type==="BinaryExpression"&&hasUserInputInExpression(expr.left)){return true}if(expr.right.type==="BinaryExpression"&&hasUserInputInExpression(expr.right)){return true}return false}return{CallExpression:function(node){if(!isFormatFunctionCall(node)){return}const args=node.arguments;if(args.length===0){return}const formatArg=args[0];const isFormatFromUserInput=isUserInputNode(formatArg)||formatArg.type==="Identifier"&&dangerousVariables.has(formatArg.name)||formatArg.type==="BinaryExpression"&&hasUserInputInExpression(formatArg);const consoleSubstitutes=isConsoleMethod(node)&&args.length>1;if(isFormatFromUserInput&&(!isConsoleMethod(node)||consoleSubstitutes)){if(safetyChecker.isSafe(node,context)){return}context.report({node:formatArg,messageId:"userControlledFormatString",data:{filePath:filename,line:String(node.loc?.start.line??0)}});return}if(formatArg.type==="TemplateLiteral"){const hasUserInput=formatArg.expressions.some(expr=>isUserInputNode(expr));if(hasUserInput){if(safetyChecker.isSafe(node,context)){return}context.report({node:formatArg,messageId:"formatStringInjection",data:{filePath:filename,line:String(node.loc?.start.line??0),severity:"HIGH",safeAlternative:"Use hardcoded format strings or validate template input"}});return}}else if(formatArg.type==="BinaryExpression"&&formatArg.operator==="+"){const hasUserInput=hasUserInputInExpression(formatArg);if(hasUserInput){if(safetyChecker.isSafe(node,context)){return}context.report({node:formatArg,messageId:"formatStringInjection",data:{filePath:filename,line:String(node.loc?.start.line??0),severity:"HIGH",safeAlternative:"Separate user input from format strings"}});return}}const fmtArg=args[0];const isFormatSafe=isInputValidated(fmtArg)||fmtArg.type==="Identifier"&&validatedVariables.has(fmtArg.name);if(!isFormatSafe){let hasUserInputInArgs=false;let hasSpecifiersInFormat=false;for(let i=1;i<args.length;i++){const arg=args[i];if(isUserInputNode(arg)&&!isInputValidated(arg)){hasUserInputInArgs=true;break}}const firstArg=args[0];if(firstArg.type==="Literal"&&typeof firstArg.value==="string"){if(containsFormatSpecifiers(firstArg.value)){hasSpecifiersInFormat=true}}else if(firstArg.type==="Identifier"){const varName=firstArg.name.toLowerCase();if(varName.includes("format")||varName.includes("template")||varName.includes("pattern")){hasSpecifiersInFormat=true}}if(!hasSpecifiersInFormat&&args.length===2&&isConsoleMethod(node)){}else if(hasSpecifiersInFormat&&hasUserInputInArgs){if(safetyChecker.isSafe(node,context)){return}const messageId=firstArg.type==="Literal"?"unsafeFormatSpecifier":"missingFormatValidation";context.report({node,messageId,data:{filePath:filename,line:String(node.loc?.start.line??0)},suggest:[{messageId:"escapeFormatString",fix:fixer=>{const arg=node.arguments.slice(1).find(a=>isUserInputNode(a));return fixer.insertTextAfter(arg,'.replace(/%/g, "%%")')}}]})}}},Literal:function(node){if(!hasFormatSpecifiers(node)){return}const text=node.value;let current=node;let isFromUserInput=false;while(current){if(current.type==="BinaryExpression"&¤t.operator==="+"&&(current.left===node||current.right===node)){const otherSide=current.left===node?current.right:current.left;if(otherSide.type==="Identifier"&&isUserInput(otherSide.name)){isFromUserInput=true;break}}if(current.type==="VariableDeclarator"&¤t.init===node.parent&¤t.id.type==="Identifier"){if(isUserInput(current.id.name)){isFromUserInput=true;break}}current=current.parent}if(!isFromUserInput){return}current=node;let isInDangerousContext=false;while(current){if(current.type==="CallExpression"&&isFormatFunctionCall(current)){const args=current.arguments;if(args.length>0&&args[0]===node){isInDangerousContext=true;break}}current=current.parent}if(isInDangerousContext&&containsFormatSpecifiers(text)){if(safetyChecker.isSafe(node,context)){return}context.report({node,messageId:"missingFormatValidation",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}},TemplateLiteral:function(node){let templateCurrent=node;let isFormatString=false;while(templateCurrent){if(templateCurrent.type==="CallExpression"&&isFormatFunctionCall(templateCurrent)){const args=templateCurrent.arguments;if(args.length>0&&args[0]===node){isFormatString=true;break}}templateCurrent=templateCurrent.parent}if(isFormatString){return}const hasUserInput=node.expressions.some(expr=>isUserInputNode(expr));if(hasUserInput){let assignCurrent=node;let isAssignedToVariable=false;while(assignCurrent){if(assignCurrent.type==="VariableDeclarator"){isAssignedToVariable=true;break}assignCurrent=assignCurrent.parent}const carriesFormatSpecifier=node.quasis.some(quasi=>{const raw=quasi.value.raw;return options.formatSpecifiers.some(spec=>raw.includes(spec))});if(isAssignedToVariable&&carriesFormatSpecifier){if(safetyChecker.isSafe(node,context)||reportedTemplates.has(node)){return}context.report({node,messageId:"formatStringInjection",data:{filePath:filename,line:String(node.loc?.start.line??0),severity:"HIGH",safeAlternative:"Extract user input from template and validate separately"}})}}},VariableDeclarator:function(node){if(!node.init||node.id.type!=="Identifier"){return}const varName=node.id.name;if(node.init.type==="CallExpression"&&node.init.callee.type==="Identifier"&&trustedSanitizers.includes(node.init.callee.name)){validatedVariables.add(varName)}if(isUserInputNode(node.init)||node.init.type==="BinaryExpression"&&hasUserInputInExpression(node.init)||node.init.type==="TemplateLiteral"&&node.init.expressions.some(expr=>isUserInputNode(expr))){dangerousVariables.add(varName)}const varNameLower=varName.toLowerCase();if(!varNameLower.includes("format")&&!varNameLower.includes("template")&&!varNameLower.includes("fmt")&&!varNameLower.includes("str")){return}if(node.init.type==="TemplateLiteral"){const hasSpecifiers=node.init.quasis.some(quasi=>containsFormatSpecifiers(quasi.value.raw));const hasUserInput=node.init.expressions.some(expr=>isUserInputNode(expr));if(hasSpecifiers&&hasUserInput){if(safetyChecker.isSafe(node,context)){return}reportedTemplates.add(node.init);context.report({node:node.init,messageId:"formatStringInjection",data:{filePath:filename,line:String(node.loc?.start.line??0),severity:"MEDIUM",safeAlternative:"Separate format string from user data"}})}}if(node.init.type==="BinaryExpression"&&node.init.operator==="+"){const hasSpecifiers=containsFormatSpecifiersInExpression(node.init);const hasUserInput=hasUserInputInExpression(node.init);if(hasSpecifiers&&hasUserInput){if(safetyChecker.isSafe(node,context)){return}context.report({node:node.init,messageId:"formatStringInjection",data:{filePath:filename,line:String(node.loc?.start.line??0),severity:"MEDIUM",safeAlternative:"Separate format string from user data"}})}}}}}});
|
|
@@ -1 +1 @@
|
|
|
1
|
-
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noGraphqlInjection=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const eslint_devkit_3=require("@interlace/eslint-devkit");exports.noGraphqlInjection=(0,eslint_devkit_1.createRule)({name:"no-graphql-injection",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-secure-coding/docs/rules/no-graphql-injection.md",description:"Detects GraphQL injection vulnerabilities and DoS attacks",cwe:"CWE-89"},hasSuggestions:true,messages:{graphqlInjection:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"GraphQL Injection",cwe:"CWE-89",description:"GraphQL injection vulnerability detected",severity:"{{severity}}",fix:"{{safeAlternative}}",documentationLink:"https://owasp.org/Top10/2025/A05_2025-Injection/"}),introspectionQuery:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Dangerous Introspection Query",cwe:"CWE-200",description:"Introspection query may leak schema information",severity:"HIGH",fix:"Disable introspection in production",documentationLink:"https://graphql.org/learn/introspection/"}),complexQueryDos:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Complex Query DoS Risk",cwe:"CWE-400",description:"Complex query may cause DoS",severity:"MEDIUM",fix:"Limit query depth and complexity",documentationLink:"https://graphql.org/learn/queries/"}),unsafeVariableInterpolation:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Unsafe Variable Interpolation",cwe:"CWE-89",description:"Unsafe interpolation in GraphQL query",severity:"HIGH",fix:"Use GraphQL variables instead of string interpolation",documentationLink:"https://graphql.org/learn/queries/#variables"}),missingInputValidation:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Missing Input Validation",cwe:"CWE-20",description:"GraphQL input not validated",severity:"MEDIUM",fix:"Validate all user inputs before GraphQL execution",documentationLink:"https://graphql.org/learn/validation/"}),useQueryBuilder:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Use Query Builder",description:"Use GraphQL query builders for safe construction",severity:"LOW",fix:"Use graphql-tag or similar libraries",documentationLink:"https://www.npmjs.com/package/graphql-tag"}),disableIntrospection:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Disable Introspection",description:"Disable GraphQL introspection in production",severity:"LOW",fix:"Set introspection: false in GraphQL config",documentationLink:"https://www.apollographql.com/docs/apollo-server/security/introspection/"}),limitQueryDepth:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Limit Query Depth",description:"Limit maximum query depth",severity:"LOW",fix:"Use depth limiting plugins or custom validation",documentationLink:"https://www.npmjs.com/package/graphql-depth-limit"}),strategyQueryBuilder:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Query Builder Strategy",description:"Use typed query builders for compile-time safety",severity:"LOW",fix:"Use GraphQL code generation tools",documentationLink:"https://graphql-code-generator.com/"}),strategyInputValidation:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Input Validation Strategy",description:"Validate all inputs at GraphQL resolver level",severity:"LOW",fix:"Implement custom scalars and input validation",documentationLink:"https://graphql.org/learn/schema/#scalar-types"}),strategyIntrospection:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Introspection Strategy",description:"Control introspection access based on environment",severity:"LOW",fix:"Enable introspection only for development/admin users",documentationLink:"https://www.apollographql.com/docs/apollo-server/security/introspection/"})},schema:[{type:"object",properties:{allowIntrospection:{type:"boolean",default:false,description:"Allow introspection queries"},maxQueryDepth:{type:"number",minimum:1,default:10,description:"Maximum query nesting depth before reporting a DoS risk"},trustedGraphqlLibraries:{type:"array",items:{type:"string"},default:["graphql","apollo-server","graphql-tools","graphql-tag"],description:"GraphQL libraries recognised as query builders"},validationFunctions:{type:"array",items:{type:"string"},default:["validate","sanitize","isValid","assertValid"],description:"Function names that count as query validation"},safeTemplateLiteralCallers:{type:"array",items:{type:"string"},default:[],description:"Additional callers where template literals are never GraphQL. Format: object.method or ClassName."},trustedSanitizers:{type:"array",items:{type:"string"},default:[],description:"Additional function names to consider as GraphQL sanitizers"},trustedAnnotations:{type:"array",items:{type:"string"},default:[],description:"Additional JSDoc annotations to consider as safe markers"},strictMode:{type:"boolean",default:false,description:"Disable all false positive detection (strict mode)"}},additionalProperties:false}]},defaultOptions:[{allowIntrospection:false,maxQueryDepth:10,trustedGraphqlLibraries:["graphql","apollo-server","graphql-tools","graphql-tag"],validationFunctions:["validate","sanitize","isValid","assertValid"],safeTemplateLiteralCallers:[],trustedSanitizers:[],trustedAnnotations:[],strictMode:false}],create(context){const options=context.options[0]||{};const{allowIntrospection=false,maxQueryDepth=10,trustedGraphqlLibraries=["graphql","apollo-server","graphql-tools","graphql-tag"],validationFunctions=["validate","sanitize","isValid","assertValid"],safeTemplateLiteralCallers=[],trustedSanitizers=[],trustedAnnotations=[],strictMode=false}=options;const filename=context.filename;const safetyChecker=(0,eslint_devkit_3.createSafetyChecker)({trustedSanitizers,trustedAnnotations,trustedOrmPatterns:[],strictMode});const isGraphqlRelated=node=>{const callee=node.callee;if(callee.type==="Identifier"){return trustedGraphqlLibraries.some(lib=>callee.name.toLowerCase().includes(lib.toLowerCase()))}if(callee.type==="MemberExpression"&&callee.object.type==="Identifier"){const objectName=callee.object.name;return trustedGraphqlLibraries.some(lib=>objectName.toLowerCase().includes(lib.toLowerCase()))}return false};const BUILTIN_SAFE_MEMBER_CALLERS=new Set(["console.log","console.warn","console.error","console.info","console.debug","console.trace","logger.log","logger.info","logger.warn","logger.error","logger.debug"]);const BUILTIN_SAFE_CONSTRUCTORS=new Set(["URL","Error","TypeError","RangeError"]);const safeMemberCallers=new Set(BUILTIN_SAFE_MEMBER_CALLERS);const safeConstructors=new Set(BUILTIN_SAFE_CONSTRUCTORS);for(const caller of safeTemplateLiteralCallers){if(caller.includes(".")){safeMemberCallers.add(caller)}else{safeConstructors.add(caller)}}const isInSafeCallerContext=node=>{let current=node.parent;while(current){if(current.type==="CallExpression"){const callee=current.callee;if(callee.type==="MemberExpression"&&callee.object.type==="Identifier"&&callee.property.type==="Identifier"){const key=`${callee.object.name}.${callee.property.name}`;if(safeMemberCallers.has(key))return true}break}if(current.type===eslint_devkit_1.AST_NODE_TYPES.NewExpression){if(current.callee.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&safeConstructors.has(current.callee.name)){return true}break}if(current.type===eslint_devkit_1.AST_NODE_TYPES.ArrowFunctionExpression||current.type===eslint_devkit_1.AST_NODE_TYPES.FunctionExpression||current.type===eslint_devkit_1.AST_NODE_TYPES.FunctionDeclaration){break}current=current.parent}return false};const isWordChar=ch=>{const code=ch.charCodeAt(0);return code>=65&&code<=90||code>=97&&code<=122||code>=48&&code<=57||code===95};const isWhitespace=ch=>ch===" "||ch==="\n"||ch===" "||ch==="\r";const GRAPHQL_OP_KEYWORDS=["query","mutation","subscription"];const GRAPHQL_SCHEMA_KEYWORDS=["type","interface","enum","scalar","input"];const isAtLineStart=(text,idx)=>{for(let i=idx-1;i>=0;i--){const ch=text[i];if(ch==="\n")return true;if(!isWhitespace(ch))return false}return true};const isStandaloneSelectionSet=text=>{const trimmed=text.trim();if(!trimmed.startsWith("{")||!trimmed.endsWith("}"))return false;if(/\{\{|\}\}/.test(trimmed))return false;if(/"[^"]*"\s*:/.test(trimmed))return false;let braceDepth=0;for(const ch of trimmed){if(ch==="{"){braceDepth++;if(braceDepth>=2)return true}else if(ch==="}"){braceDepth=Math.max(0,braceDepth-1)}}return false};const findKeywordAtBoundary=(text,keyword,startFrom=0)=>{let pos=startFrom;while(true){const idx=text.indexOf(keyword,pos);if(idx===-1)return-1;const beforeOk=idx===0||!isWordChar(text[idx-1]);const afterIdx=idx+keyword.length;const afterOk=afterIdx>=text.length||!isWordChar(text[afterIdx]);if(beforeOk&&afterOk)return idx;pos=idx+1}};const GRAPHQL_TAG_NAMES=new Set(["gql","graphql"]);const GRAPHQL_SCHEMA_BINDING=/typedef|schema|sdl/i;const hasGraphqlAttribution=node=>{let current=node;while(current.parent?.type===eslint_devkit_1.AST_NODE_TYPES.BinaryExpression){current=current.parent}const parent=current.parent;if(parent?.type===eslint_devkit_1.AST_NODE_TYPES.TaggedTemplateExpression){const tag=parent.tag;const tagName=tag.type===eslint_devkit_1.AST_NODE_TYPES.Identifier?tag.name:tag.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&tag.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier?tag.property.name:"";return GRAPHQL_TAG_NAMES.has(tagName.toLowerCase())}if(parent?.type===eslint_devkit_1.AST_NODE_TYPES.VariableDeclarator&&parent.id.type===eslint_devkit_1.AST_NODE_TYPES.Identifier){return GRAPHQL_SCHEMA_BINDING.test(parent.id.name)}if(parent?.type===eslint_devkit_1.AST_NODE_TYPES.Property&&parent.key.type===eslint_devkit_1.AST_NODE_TYPES.Identifier){return GRAPHQL_SCHEMA_BINDING.test(parent.key.name)}if(parent?.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression){return isGraphqlRelated(parent)}return false};const isGraphqlTemplate=node=>{const staticText=node.quasis.map(q=>(q.value.cooked??q.value.raw).toLowerCase()).join("");for(const keyword of GRAPHQL_OP_KEYWORDS){let pos=0;while(pos<staticText.length){const idx=findKeywordAtBoundary(staticText,keyword,pos);if(idx===-1)break;pos=idx+1;if(!isAtLineStart(staticText,idx))continue;let scan=idx+keyword.length;while(scan<staticText.length&&isWhitespace(staticText[scan]))scan++;while(scan<staticText.length&&isWordChar(staticText[scan]))scan++;while(scan<staticText.length&&isWhitespace(staticText[scan]))scan++;if(scan<staticText.length&&(staticText[scan]==="{"||staticText[scan]==="(")){return true}}}{let pos=0;while(pos<staticText.length){const idx=findKeywordAtBoundary(staticText,"fragment",pos);if(idx===-1)break;pos=idx+1;if(!isAtLineStart(staticText,idx))continue;let scan=idx+8;while(scan<staticText.length&&isWhitespace(staticText[scan]))scan++;const nameStart=scan;while(scan<staticText.length&&isWordChar(staticText[scan]))scan++;if(scan===nameStart)continue;while(scan<staticText.length&&isWhitespace(staticText[scan]))scan++;if(staticText.slice(scan,scan+2)==="on"&&(scan+2>=staticText.length||!isWordChar(staticText[scan+2]))){return true}}}if(hasGraphqlAttribution(node)&&staticText.includes("{"))for(const keyword of GRAPHQL_SCHEMA_KEYWORDS){let pos=0;while(pos<staticText.length){const idx=findKeywordAtBoundary(staticText,keyword,pos);if(idx===-1)break;pos=idx+1;if(!isAtLineStart(staticText,idx))continue;let scan=idx+keyword.length;if(scan>=staticText.length||!isWhitespace(staticText[scan]))continue;while(scan<staticText.length&&isWhitespace(staticText[scan]))scan++;if(scan<staticText.length&&isWordChar(staticText[scan])){return true}}}return isStandaloneSelectionSet(staticText)};const hasIntrospectionField=text=>{const lower=text.toLowerCase();return findKeywordAtBoundary(lower,"__schema")!==-1||findKeywordAtBoundary(lower,"__type")!==-1};const templateHasIntrospection=node=>{return node.quasis.some(q=>hasIntrospectionField(q.value.cooked??q.value.raw))};const templateQueryDepth=node=>{let depth=0;let braceCount=0;for(const q of node.quasis){const text=q.value.cooked??q.value.raw;for(const char of text){if(char==="{"){braceCount++;depth=Math.max(depth,braceCount)}else if(char==="}"){braceCount--}}}return depth};const containsGraphqlText=(text,attributed)=>{const lower=text.toLowerCase();for(const keyword of GRAPHQL_OP_KEYWORDS){const idx=findKeywordAtBoundary(lower,keyword);if(idx===-1)continue;if(!isAtLineStart(lower,idx))continue;let scan=idx+keyword.length;while(scan<lower.length&&isWhitespace(lower[scan]))scan++;while(scan<lower.length&&isWordChar(lower[scan]))scan++;while(scan<lower.length&&isWhitespace(lower[scan]))scan++;if(scan<lower.length&&(lower[scan]==="{"||lower[scan]==="("))return true}const fragIdx=findKeywordAtBoundary(lower,"fragment");if(fragIdx!==-1&&isAtLineStart(lower,fragIdx)){let scan=fragIdx+8;while(scan<lower.length&&isWhitespace(lower[scan]))scan++;const nameStart=scan;while(scan<lower.length&&isWordChar(lower[scan]))scan++;if(scan>nameStart){while(scan<lower.length&&isWhitespace(lower[scan]))scan++;if(lower.slice(scan,scan+2)==="on"&&(scan+2>=lower.length||!isWordChar(lower[scan+2])))return true}}if(attributed&&lower.includes("{"))for(const keyword of GRAPHQL_SCHEMA_KEYWORDS){const idx=findKeywordAtBoundary(lower,keyword);if(idx===-1)continue;if(!isAtLineStart(lower,idx))continue;let scan=idx+keyword.length;if(scan>=lower.length||!isWhitespace(lower[scan]))continue;while(scan<lower.length&&isWhitespace(lower[scan]))scan++;if(scan<lower.length&&isWordChar(lower[scan]))return true}return isStandaloneSelectionSet(text)};const concatenatedStaticText=node=>{if(node.type==="BinaryExpression"&&node.operator==="+"){return concatenatedStaticText(node.left)+concatenatedStaticText(node.right)}if(node.type==="Literal"&&typeof node.value==="string")return node.value;if(node.type==="TemplateLiteral"){return node.quasis.map(q=>q.value.cooked??q.value.raw).join("")}return""};const isInputValidated=inputNode=>{let current=inputNode;while(current){if(current.type==="CallExpression"&¤t.callee.type==="Identifier"&&validationFunctions.includes(current.callee.name)){return true}current=current.parent}return false};return{TemplateLiteral(node){if(isInSafeCallerContext(node)){return}if(!isGraphqlTemplate(node)){return}if(!allowIntrospection&&templateHasIntrospection(node)){if(safetyChecker.isSafe(node,context)){return}context.report({node,messageId:"introspectionQuery",data:{filePath:filename,line:String(node.loc?.start.line??0)}});return}if(node.expressions.length>0){const allExpressionsSafe=node.expressions.every(expr=>isInputValidated(expr)||safetyChecker.isSafe(expr,context));if(!allExpressionsSafe){context.report({node,messageId:"unsafeVariableInterpolation",data:{filePath:filename,line:String(node.loc?.start.line??0)},suggest:[{messageId:"useQueryBuilder",fix:()=>null}]})}}const depth=templateQueryDepth(node);if(depth>maxQueryDepth){context.report({node,messageId:"complexQueryDos",data:{filePath:filename,line:String(node.loc?.start.line??0)},suggest:[{messageId:"limitQueryDepth",fix:()=>null}]})}},Literal(node){if(typeof node.value!=="string"){return}const queryText=node.value;if(!containsGraphqlText(queryText,hasGraphqlAttribution(node))){return}if(!allowIntrospection&&hasIntrospectionField(queryText)){if(safetyChecker.isSafe(node,context)){return}context.report({node,messageId:"introspectionQuery",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}let depth=0;let bc=0;for(const ch of queryText){if(ch==="{"){bc++;depth=Math.max(depth,bc)}else if(ch==="}"){bc--}}if(depth>maxQueryDepth){context.report({node,messageId:"complexQueryDos",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}},BinaryExpression(node){if(node.operator!=="+"){return}const fullText=concatenatedStaticText(node);if(!containsGraphqlText(fullText,hasGraphqlAttribution(node))){return}if(safetyChecker.isSafe(node,context)){return}context.report({node,messageId:"graphqlInjection",data:{filePath:filename,line:String(node.loc?.start.line??0),severity:"HIGH",safeAlternative:"Use GraphQL variables or query builders instead of string concatenation"}})},CallExpression(node){if(!isGraphqlRelated(node)){return}const callee=node.callee;if(callee.type==="MemberExpression"&&callee.property.type==="Identifier"&&["execute","executeQuery","query","mutate","subscribe"].includes(callee.property.name)){for(const arg of node.arguments){if(arg.type==="Identifier"&&!isInputValidated(arg)){if(safetyChecker.isSafe(arg,context)){continue}context.report({node:arg,messageId:"missingInputValidation",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}}}}}});
|
|
1
|
+
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noGraphqlInjection=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const eslint_devkit_3=require("@interlace/eslint-devkit");exports.noGraphqlInjection=(0,eslint_devkit_1.createRule)({name:"no-graphql-injection",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-secure-coding/docs/rules/no-graphql-injection.md",description:"Detects GraphQL injection vulnerabilities and DoS attacks",cwe:"CWE-89"},hasSuggestions:true,messages:{graphqlInjection:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"GraphQL Injection",cwe:"CWE-89",description:"GraphQL injection vulnerability detected",severity:"{{severity}}",fix:"{{safeAlternative}}",documentationLink:"https://owasp.org/Top10/2025/A05_2025-Injection/"}),introspectionQuery:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Dangerous Introspection Query",cwe:"CWE-200",description:"Introspection query may leak schema information",severity:"HIGH",fix:"Disable introspection in production",documentationLink:"https://graphql.org/learn/introspection/"}),complexQueryDos:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Complex Query DoS Risk",cwe:"CWE-400",description:"Complex query may cause DoS",severity:"MEDIUM",fix:"Limit query depth and complexity",documentationLink:"https://graphql.org/learn/queries/"}),unsafeVariableInterpolation:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Unsafe Variable Interpolation",cwe:"CWE-89",description:"Unsafe interpolation in GraphQL query",severity:"HIGH",fix:"Use GraphQL variables instead of string interpolation",documentationLink:"https://graphql.org/learn/queries/#variables"}),missingInputValidation:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Missing Input Validation",cwe:"CWE-20",description:"GraphQL input not validated",severity:"MEDIUM",fix:"Validate all user inputs before GraphQL execution",documentationLink:"https://graphql.org/learn/validation/"}),useQueryBuilder:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Use Query Builder",description:"Use GraphQL query builders for safe construction",severity:"LOW",fix:"Use graphql-tag or similar libraries",documentationLink:"https://www.npmjs.com/package/graphql-tag"}),disableIntrospection:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Disable Introspection",description:"Disable GraphQL introspection in production",severity:"LOW",fix:"Set introspection: false in GraphQL config",documentationLink:"https://www.apollographql.com/docs/apollo-server/security/introspection/"}),limitQueryDepth:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Limit Query Depth",description:"Limit maximum query depth",severity:"LOW",fix:"Use depth limiting plugins or custom validation",documentationLink:"https://www.npmjs.com/package/graphql-depth-limit"}),strategyQueryBuilder:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Query Builder Strategy",description:"Use typed query builders for compile-time safety",severity:"LOW",fix:"Use GraphQL code generation tools",documentationLink:"https://graphql-code-generator.com/"}),strategyInputValidation:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Input Validation Strategy",description:"Validate all inputs at GraphQL resolver level",severity:"LOW",fix:"Implement custom scalars and input validation",documentationLink:"https://graphql.org/learn/schema/#scalar-types"}),strategyIntrospection:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Introspection Strategy",description:"Control introspection access based on environment",severity:"LOW",fix:"Enable introspection only for development/admin users",documentationLink:"https://www.apollographql.com/docs/apollo-server/security/introspection/"})},schema:[{type:"object",properties:{allowIntrospection:{type:"boolean",default:false,description:"Allow introspection queries"},maxQueryDepth:{type:"number",minimum:1,default:10,description:"Maximum query nesting depth before reporting a DoS risk"},trustedGraphqlLibraries:{type:"array",items:{type:"string"},default:["graphql","apollo-server","graphql-tools","graphql-tag"],description:"GraphQL libraries recognised as query builders"},validationFunctions:{type:"array",items:{type:"string"},default:["validate","sanitize","isValid","assertValid"],description:"Function names that count as query validation"},safeTemplateLiteralCallers:{type:"array",items:{type:"string"},default:[],description:"Additional callers where template literals are never GraphQL. Format: object.method or ClassName."},trustedSanitizers:{type:"array",items:{type:"string"},default:[],description:"Additional function names to consider as GraphQL sanitizers"},trustedAnnotations:{type:"array",items:{type:"string"},default:[],description:"Additional JSDoc annotations to consider as safe markers"},strictMode:{type:"boolean",default:false,description:"Disable all false positive detection (strict mode)"}},additionalProperties:false}]},defaultOptions:[{allowIntrospection:false,maxQueryDepth:10,trustedGraphqlLibraries:["graphql","apollo-server","graphql-tools","graphql-tag"],validationFunctions:["validate","sanitize","isValid","assertValid"],safeTemplateLiteralCallers:[],trustedSanitizers:[],trustedAnnotations:[],strictMode:false}],create(context){const options=context.options[0]||{};const{allowIntrospection=false,maxQueryDepth=10,trustedGraphqlLibraries=["graphql","apollo-server","graphql-tools","graphql-tag"],validationFunctions=["validate","sanitize","isValid","assertValid"],safeTemplateLiteralCallers=[],trustedSanitizers=[],trustedAnnotations=[],strictMode=false}=options;const filename=context.filename;const safetyChecker=(0,eslint_devkit_3.createSafetyChecker)({trustedSanitizers,trustedAnnotations,trustedOrmPatterns:[],strictMode});const isGraphqlRelated=node=>{const callee=node.callee;if(callee.type==="Identifier"){return trustedGraphqlLibraries.some(lib=>callee.name.toLowerCase().includes(lib.toLowerCase()))}if(callee.type==="MemberExpression"&&callee.object.type==="Identifier"){const objectName=callee.object.name;return trustedGraphqlLibraries.some(lib=>objectName.toLowerCase().includes(lib.toLowerCase()))}return false};const BUILTIN_SAFE_MEMBER_CALLERS=new Set(["console.log","console.warn","console.error","console.info","console.debug","console.trace","logger.log","logger.info","logger.warn","logger.error","logger.debug"]);const BUILTIN_SAFE_CONSTRUCTORS=new Set(["URL","Error","TypeError","RangeError"]);const safeMemberCallers=new Set(BUILTIN_SAFE_MEMBER_CALLERS);const safeConstructors=new Set(BUILTIN_SAFE_CONSTRUCTORS);for(const caller of safeTemplateLiteralCallers){if(caller.includes(".")){safeMemberCallers.add(caller)}else{safeConstructors.add(caller)}}const isInSafeCallerContext=node=>{let current=node.parent;while(current){if(current.type==="CallExpression"){const callee=current.callee;if(callee.type==="MemberExpression"&&callee.object.type==="Identifier"&&callee.property.type==="Identifier"){const key=`${callee.object.name}.${callee.property.name}`;if(safeMemberCallers.has(key))return true}break}if(current.type===eslint_devkit_1.AST_NODE_TYPES.NewExpression){if(current.callee.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&safeConstructors.has(current.callee.name)){return true}break}if(current.type===eslint_devkit_1.AST_NODE_TYPES.ArrowFunctionExpression||current.type===eslint_devkit_1.AST_NODE_TYPES.FunctionExpression||current.type===eslint_devkit_1.AST_NODE_TYPES.FunctionDeclaration){break}current=current.parent}return false};const isWordChar=ch=>{const code=ch.charCodeAt(0);return code>=65&&code<=90||code>=97&&code<=122||code>=48&&code<=57||code===95};const isWhitespace=ch=>ch===" "||ch==="\n"||ch===" "||ch==="\r";const GRAPHQL_OP_KEYWORDS=["query","mutation","subscription"];const GRAPHQL_SCHEMA_KEYWORDS=["type","interface","enum","scalar","input"];const isAtLineStart=(text,idx)=>{for(let i=idx-1;i>=0;i--){const ch=text[i];if(ch==="\n")return true;if(!isWhitespace(ch))return false}return true};const isStandaloneSelectionSet=text=>{const trimmed=text.trim();if(!trimmed.startsWith("{")||!trimmed.endsWith("}"))return false;if(/\{\{|\}\}/.test(trimmed))return false;if(/"[^"]*"\s*:/.test(trimmed))return false;let braceDepth=0;for(const ch of trimmed){if(ch==="{"){braceDepth++;if(braceDepth>=2)return true}else if(ch==="}"){braceDepth=Math.max(0,braceDepth-1)}}return false};const findKeywordAtBoundary=(text,keyword,startFrom=0)=>{let pos=startFrom;while(true){const idx=text.indexOf(keyword,pos);if(idx===-1)return-1;const beforeOk=idx===0||!isWordChar(text[idx-1]);const afterIdx=idx+keyword.length;const afterOk=afterIdx>=text.length||!isWordChar(text[afterIdx]);if(beforeOk&&afterOk)return idx;pos=idx+1}};const GRAPHQL_TAG_NAMES=new Set(["gql","graphql"]);const GRAPHQL_SCHEMA_BINDING=/typedef|schema|sdl/i;const hasGraphqlAttribution=node=>{let current=node;while(current.parent?.type===eslint_devkit_1.AST_NODE_TYPES.BinaryExpression){current=current.parent}const parent=current.parent;if(parent?.type===eslint_devkit_1.AST_NODE_TYPES.TaggedTemplateExpression){const tag=parent.tag;const tagName=tag.type===eslint_devkit_1.AST_NODE_TYPES.Identifier?tag.name:tag.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&tag.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier?tag.property.name:"";return GRAPHQL_TAG_NAMES.has(tagName.toLowerCase())}if(parent?.type===eslint_devkit_1.AST_NODE_TYPES.VariableDeclarator&&parent.id.type===eslint_devkit_1.AST_NODE_TYPES.Identifier){return GRAPHQL_SCHEMA_BINDING.test(parent.id.name)}if(parent?.type===eslint_devkit_1.AST_NODE_TYPES.Property&&parent.key.type===eslint_devkit_1.AST_NODE_TYPES.Identifier){return GRAPHQL_SCHEMA_BINDING.test(parent.key.name)}if(parent?.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression){return isGraphqlRelated(parent)}return false};const isGraphqlTemplate=node=>{const staticText=node.quasis.map(q=>(q.value.cooked??q.value.raw).toLowerCase()).join("");for(const keyword of GRAPHQL_OP_KEYWORDS){let pos=0;while(pos<staticText.length){const idx=findKeywordAtBoundary(staticText,keyword,pos);if(idx===-1)break;pos=idx+1;if(!isAtLineStart(staticText,idx))continue;let scan=idx+keyword.length;while(scan<staticText.length&&isWhitespace(staticText[scan]))scan++;while(scan<staticText.length&&isWordChar(staticText[scan]))scan++;while(scan<staticText.length&&isWhitespace(staticText[scan]))scan++;if(scan<staticText.length&&staticText[scan]==="("){return true}if(scan<staticText.length&&staticText[scan]==="{"){let probe=scan+1;while(probe<staticText.length&&isWhitespace(staticText[probe]))probe++;if(probe<staticText.length&&isWordChar(staticText[probe])){return true}continue}}}{let pos=0;while(pos<staticText.length){const idx=findKeywordAtBoundary(staticText,"fragment",pos);if(idx===-1)break;pos=idx+1;if(!isAtLineStart(staticText,idx))continue;let scan=idx+8;while(scan<staticText.length&&isWhitespace(staticText[scan]))scan++;const nameStart=scan;while(scan<staticText.length&&isWordChar(staticText[scan]))scan++;if(scan===nameStart)continue;while(scan<staticText.length&&isWhitespace(staticText[scan]))scan++;if(staticText.slice(scan,scan+2)==="on"&&(scan+2>=staticText.length||!isWordChar(staticText[scan+2]))){return true}}}if(hasGraphqlAttribution(node)&&staticText.includes("{"))for(const keyword of GRAPHQL_SCHEMA_KEYWORDS){let pos=0;while(pos<staticText.length){const idx=findKeywordAtBoundary(staticText,keyword,pos);if(idx===-1)break;pos=idx+1;if(!isAtLineStart(staticText,idx))continue;let scan=idx+keyword.length;if(scan>=staticText.length||!isWhitespace(staticText[scan]))continue;while(scan<staticText.length&&isWhitespace(staticText[scan]))scan++;if(scan<staticText.length&&isWordChar(staticText[scan])){return true}}}return isStandaloneSelectionSet(staticText)};const hasIntrospectionField=text=>{const lower=text.toLowerCase();return findKeywordAtBoundary(lower,"__schema")!==-1||findKeywordAtBoundary(lower,"__type")!==-1};const templateHasIntrospection=node=>{return node.quasis.some(q=>hasIntrospectionField(q.value.cooked??q.value.raw))};const templateQueryDepth=node=>{let depth=0;let braceCount=0;for(const q of node.quasis){const text=q.value.cooked??q.value.raw;for(const char of text){if(char==="{"){braceCount++;depth=Math.max(depth,braceCount)}else if(char==="}"){braceCount--}}}return depth};const containsGraphqlText=(text,attributed)=>{const lower=text.toLowerCase();for(const keyword of GRAPHQL_OP_KEYWORDS){const idx=findKeywordAtBoundary(lower,keyword);if(idx===-1)continue;if(!isAtLineStart(lower,idx))continue;let scan=idx+keyword.length;while(scan<lower.length&&isWhitespace(lower[scan]))scan++;while(scan<lower.length&&isWordChar(lower[scan]))scan++;while(scan<lower.length&&isWhitespace(lower[scan]))scan++;if(scan<lower.length&&lower[scan]==="(")return true;if(scan<lower.length&&lower[scan]==="{"){if(attributed)return true;let probe=scan+1;while(probe<lower.length&&isWhitespace(lower[probe]))probe++;if(probe<lower.length&&isWordChar(lower[probe]))return true}}const fragIdx=findKeywordAtBoundary(lower,"fragment");if(fragIdx!==-1&&isAtLineStart(lower,fragIdx)){let scan=fragIdx+8;while(scan<lower.length&&isWhitespace(lower[scan]))scan++;const nameStart=scan;while(scan<lower.length&&isWordChar(lower[scan]))scan++;if(scan>nameStart){while(scan<lower.length&&isWhitespace(lower[scan]))scan++;if(lower.slice(scan,scan+2)==="on"&&(scan+2>=lower.length||!isWordChar(lower[scan+2])))return true}}if(attributed&&lower.includes("{"))for(const keyword of GRAPHQL_SCHEMA_KEYWORDS){const idx=findKeywordAtBoundary(lower,keyword);if(idx===-1)continue;if(!isAtLineStart(lower,idx))continue;let scan=idx+keyword.length;if(scan>=lower.length||!isWhitespace(lower[scan]))continue;while(scan<lower.length&&isWhitespace(lower[scan]))scan++;if(scan<lower.length&&isWordChar(lower[scan]))return true}return isStandaloneSelectionSet(text)};const concatenatedStaticText=node=>{if(node.type==="BinaryExpression"&&node.operator==="+"){return concatenatedStaticText(node.left)+concatenatedStaticText(node.right)}if(node.type==="Literal"&&typeof node.value==="string")return node.value;if(node.type==="TemplateLiteral"){return node.quasis.map(q=>q.value.cooked??q.value.raw).join("")}return""};const isInputValidated=inputNode=>{let current=inputNode;while(current){if(current.type==="CallExpression"&¤t.callee.type==="Identifier"&&validationFunctions.includes(current.callee.name)){return true}current=current.parent}return false};return{TemplateLiteral(node){if(isInSafeCallerContext(node)){return}if(!isGraphqlTemplate(node)){return}if(!allowIntrospection&&templateHasIntrospection(node)){if(safetyChecker.isSafe(node,context)){return}context.report({node,messageId:"introspectionQuery",data:{filePath:filename,line:String(node.loc?.start.line??0)}});return}if(node.expressions.length>0){const allExpressionsSafe=node.expressions.every(expr=>isInputValidated(expr)||safetyChecker.isSafe(expr,context));if(!allExpressionsSafe){context.report({node,messageId:"unsafeVariableInterpolation",data:{filePath:filename,line:String(node.loc?.start.line??0)},suggest:[{messageId:"useQueryBuilder",fix:()=>null}]})}}const depth=templateQueryDepth(node);if(depth>maxQueryDepth){context.report({node,messageId:"complexQueryDos",data:{filePath:filename,line:String(node.loc?.start.line??0)},suggest:[{messageId:"limitQueryDepth",fix:()=>null}]})}},Literal(node){if(typeof node.value!=="string"){return}const queryText=node.value;if(!containsGraphqlText(queryText,hasGraphqlAttribution(node))){return}if(!allowIntrospection&&hasIntrospectionField(queryText)){if(safetyChecker.isSafe(node,context)){return}context.report({node,messageId:"introspectionQuery",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}let depth=0;let bc=0;for(const ch of queryText){if(ch==="{"){bc++;depth=Math.max(depth,bc)}else if(ch==="}"){bc--}}if(depth>maxQueryDepth){context.report({node,messageId:"complexQueryDos",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}},BinaryExpression(node){if(node.operator!=="+"){return}const fullText=concatenatedStaticText(node);if(!containsGraphqlText(fullText,hasGraphqlAttribution(node))){return}if(safetyChecker.isSafe(node,context)){return}context.report({node,messageId:"graphqlInjection",data:{filePath:filename,line:String(node.loc?.start.line??0),severity:"HIGH",safeAlternative:"Use GraphQL variables or query builders instead of string concatenation"}})},CallExpression(node){if(!isGraphqlRelated(node)){return}const callee=node.callee;if(callee.type==="MemberExpression"&&callee.property.type==="Identifier"&&["execute","executeQuery","query","mutate","subscribe"].includes(callee.property.name)){for(const arg of node.arguments){if(arg.type==="Identifier"&&!isInputValidated(arg)){if(safetyChecker.isSafe(arg,context)){continue}context.report({node:arg,messageId:"missingInputValidation",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}}}}}});
|
|
@@ -1 +1 @@
|
|
|
1
|
-
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noInsecureComparison=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const fileUsesAstTooling=(0,eslint_devkit_2.createModuleEvidence)({packages:["@babel/types","@babel/traverse","@babel/generator","@babel/parser","recast","jscodeshift","estree-walker","unist-util-visit","@typescript-eslint/utils","@typescript-eslint/typescript-estree","typescript","ts-morph","eslint"]});exports.noInsecureComparison=(0,eslint_devkit_2.createRule)({name:"no-insecure-comparison",meta:{type:"problem",deprecated:true,replacedBy:["node-security/no-timing-unsafe-compare"],docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-secure-coding/docs/rules/no-insecure-comparison.md",description:"Detects insecure comparison operators (==, !=) that can lead to type coercion vulnerabilities",cwe:"CWE-697",cvss:5.3},hasSuggestions:true,messages:{insecureComparison:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Insecure Comparison",cwe:"CWE-697",description:"Insecure comparison operator ({{operator}}) detected - can lead to type coercion vulnerabilities",severity:"HIGH",fix:"Use strict equality ({{strictOperator}}) instead: {{example}}",documentationLink:"https://cwe.mitre.org/data/definitions/697.html"}),useStrictEquality:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Use Strict Equality",description:"Use strict equality operator",severity:"LOW",fix:"Replace == with === and != with !==",documentationLink:"https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Strict_equality"}),timingUnsafeComparison:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Timing Attack Risk",cwe:"CWE-208",description:"Secret comparison with {{operator}} can leak timing information",severity:"HIGH",fix:"Use crypto.timingSafeEqual(Buffer.from(a), Buffer.from(b))",documentationLink:"https://nodejs.org/api/crypto.html#cryptotimingsafeequala-b"})},schema:[{type:"object",properties:{allowInTests:{type:"boolean",default:false,description:"Allow insecure comparison in test files"},ignorePatterns:{type:"array",items:{type:"string"},default:[],description:"Additional patterns to ignore"}},additionalProperties:false}]},defaultOptions:[{allowInTests:false,ignorePatterns:[]}],create(context,[options={}]){const{allowInTests=false,ignorePatterns=[]}=options;const filename=context.filename;const isTestFile=allowInTests&&/\.(test|spec)\.(ts|tsx|js|jsx)$/.test(filename);const sourceCode=context.sourceCode;const isCodemodFile=(()=>{if(/\/codemod[s]?\//i.test(filename))return true;if(/codemod\.[mc]?[jt]sx?$/i.test(filename))return true;return fileUsesAstTooling(sourceCode.ast)})();function matchesIgnorePattern(text,patterns){return patterns.some(pattern=>{try{const regex=new RegExp(pattern,"i");return regex.test(text)}catch{return text.toLowerCase().includes(pattern.toLowerCase())}})}function isNullLiteral(node){return node.type==="Literal"&&node.raw==="null"}function checkBinaryExpression(node){if(isTestFile){return}if(isCodemodFile){return}const secretKeywords=new Set(["secret","secrets","token","tokens","password","passwd","pwd","apikey","api_key","secretkey","secret_key","privatekey","private_key","signature","hmac","digest","checksum","nonce","otp","passwordhash","password_hash","hashedpassword","hashed_password"]);const nameSegments=name=>{const parts=name.replace(/([a-z0-9])([A-Z])/g,"$1 $2").split(/[^A-Za-z0-9]+/).filter(Boolean).map(p=>p.toLowerCase());return[...parts,parts.join(""),parts.join("_"),name.toLowerCase()]};const namesIn=expr=>{const out=[];const walk=n=>{if(n.type==="Identifier")out.push(n.name);else if(n.type==="MemberExpression"){walk(n.object);if(!n.computed&&n.property.type==="Identifier")out.push(n.property.name);else walk(n.property)}else if(n.type==="CallExpression"){walk(n.callee)}};walk(expr);return out};const isSecurityContext=(()=>{let current=node;while(current){if((current.type==="FunctionDeclaration"||current.type==="FunctionExpression"||current.type==="ArrowFunctionExpression")&&"id"in current&¤t.id?.name){if(/security|auth|crypto|hash|token|secret|insecure|verify|validate/i.test(current.id.name)){return true}}if(current.type==="MethodDefinition"&¤t.key.type==="Identifier"){if(/security|auth|crypto|hash|token|secret|insecure|verify|validate/i.test(current.key.name)){return true}}current=current.parent}return false})();const isPotentialSecret=expr=>{const segments=namesIn(expr).flatMap(nameSegments);if(segments.some(segment=>secretKeywords.has(segment)))return true;if(isSecurityContext){const contextKeywords=new Set(["provided","expected","actual","input","value","data"]);return segments.some(segment=>contextKeywords.has(segment))}return false};if((node.operator==="==="||node.operator==="!==")&&(isPotentialSecret(node.left)||isPotentialSecret(node.right))){const isLengthComparison=expr=>{return expr.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&expr.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&expr.property.name==="length"};if(isLengthComparison(node.left)||isLengthComparison(node.right)){return}const leftText=sourceCode.getText(node.left);const rightText=sourceCode.getText(node.right);const example=`crypto.timingSafeEqual(Buffer.from(${leftText}), Buffer.from(${rightText}))`;context.report({node,messageId:"timingUnsafeComparison",data:{operator:node.operator,strictOperator:node.operator,example},suggest:[{messageId:"useStrictEquality",fix:fixer=>fixer.replaceText(node,example)}]});return}if(node.operator==="=="||node.operator==="!="){const text=sourceCode.getText(node);if(matchesIgnorePattern(text,ignorePatterns)){return}if(isNullLiteral(node.left)||isNullLiteral(node.right)){return}const strictOperator=node.operator==="=="?"===":"!==";const leftText=sourceCode.getText(node.left);const rightText=sourceCode.getText(node.right);const example=`${leftText} ${strictOperator} ${rightText}`;context.report({node,messageId:"insecureComparison",data:{operator:node.operator,strictOperator,example},suggest:[{messageId:"useStrictEquality",fix:fixer=>{return fixer.replaceText(node,example)}}]})}}return{BinaryExpression:checkBinaryExpression}}});
|
|
1
|
+
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noInsecureComparison=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const fileUsesAstTooling=(0,eslint_devkit_2.createModuleEvidence)({packages:["@babel/types","@babel/traverse","@babel/generator","@babel/parser","recast","jscodeshift","estree-walker","unist-util-visit","@typescript-eslint/utils","@typescript-eslint/typescript-estree","typescript","ts-morph","eslint"]});exports.noInsecureComparison=(0,eslint_devkit_2.createRule)({name:"no-insecure-comparison",meta:{type:"problem",deprecated:true,replacedBy:["node-security/no-timing-unsafe-compare"],docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-secure-coding/docs/rules/no-insecure-comparison.md",description:"Detects insecure comparison operators (==, !=) that can lead to type coercion vulnerabilities",cwe:"CWE-697",cvss:5.3},hasSuggestions:true,messages:{insecureComparison:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Insecure Comparison",cwe:"CWE-697",description:"Insecure comparison operator ({{operator}}) detected - can lead to type coercion vulnerabilities",severity:"HIGH",fix:"Use strict equality ({{strictOperator}}) instead: {{example}}",documentationLink:"https://cwe.mitre.org/data/definitions/697.html"}),useStrictEquality:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Use Strict Equality",description:"Use strict equality operator",severity:"LOW",fix:"Replace == with === and != with !==",documentationLink:"https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Strict_equality"}),timingUnsafeComparison:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Timing Attack Risk",cwe:"CWE-208",description:"Secret comparison with {{operator}} can leak timing information",severity:"HIGH",fix:"Use crypto.timingSafeEqual(Buffer.from(a), Buffer.from(b))",documentationLink:"https://nodejs.org/api/crypto.html#cryptotimingsafeequala-b"})},schema:[{type:"object",properties:{allowInTests:{type:"boolean",default:false,description:"Allow insecure comparison in test files"},ignorePatterns:{type:"array",items:{type:"string"},default:[],description:"Additional patterns to ignore"}},additionalProperties:false}]},defaultOptions:[{allowInTests:false,ignorePatterns:[]}],create(context,[options={}]){const{allowInTests=false,ignorePatterns=[]}=options;const filename=context.filename;const isTestFile=allowInTests&&/\.(test|spec)\.(ts|tsx|js|jsx)$/.test(filename);const sourceCode=context.sourceCode;const isCodemodFile=(()=>{if(/\/codemod[s]?\//i.test(filename))return true;if(/codemod\.[mc]?[jt]sx?$/i.test(filename))return true;return fileUsesAstTooling(sourceCode.ast)})();function matchesIgnorePattern(text,patterns){return patterns.some(pattern=>{try{const regex=new RegExp(pattern,"i");return regex.test(text)}catch{return text.toLowerCase().includes(pattern.toLowerCase())}})}function isNullLiteral(node){return node.type==="Literal"&&node.raw==="null"}function checkBinaryExpression(node){if(isTestFile){return}if(isCodemodFile){return}const secretKeywords=new Set(["secret","secrets","token","tokens","password","passwd","pwd","apikey","api_key","secretkey","secret_key","privatekey","private_key","signature","hmac","digest","checksum","nonce","otp","passwordhash","password_hash","hashedpassword","hashed_password"]);const nameSegments=name=>{const parts=name.replace(/([a-z0-9])([A-Z])/g,"$1 $2").split(/[^A-Za-z0-9]+/).filter(Boolean).map(p=>p.toLowerCase());return[...parts,parts.join(""),parts.join("_"),name.toLowerCase()]};const namesIn=expr=>{const out=[];const walk=n=>{if(n.type==="Identifier")out.push(n.name);else if(n.type==="MemberExpression"){walk(n.object);if(!n.computed&&n.property.type==="Identifier")out.push(n.property.name);else walk(n.property)}else if(n.type==="CallExpression"){walk(n.callee)}};walk(expr);return out};const isSecurityContext=(()=>{let current=node;while(current){if((current.type==="FunctionDeclaration"||current.type==="FunctionExpression"||current.type==="ArrowFunctionExpression")&&"id"in current&¤t.id?.name){if(/security|auth|crypto|hash|token|secret|insecure|verify|validate/i.test(current.id.name)){return true}}if(current.type==="MethodDefinition"&¤t.key.type==="Identifier"){if(/security|auth|crypto|hash|token|secret|insecure|verify|validate/i.test(current.key.name)){return true}}current=current.parent}return false})();const isPotentialSecret=expr=>{const segments=namesIn(expr).flatMap(nameSegments);if(segments.some(segment=>secretKeywords.has(segment)))return true;if(isSecurityContext){const contextKeywords=new Set(["provided","expected","actual","input","value","data"]);return segments.some(segment=>contextKeywords.has(segment))}return false};if((node.operator==="==="||node.operator==="!==")&&(isPotentialSecret(node.left)||isPotentialSecret(node.right))){const isLengthComparison=expr=>{return expr.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&expr.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&expr.property.name==="length"};if(isLengthComparison(node.left)||isLengthComparison(node.right)){return}const isNonSecretLiteral=expr=>expr.type===eslint_devkit_1.AST_NODE_TYPES.Literal&&(typeof expr.value==="boolean"||expr.value===null)||expr.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&expr.name==="undefined";if(isNonSecretLiteral(node.left)||isNonSecretLiteral(node.right)){return}const leftText=sourceCode.getText(node.left);const rightText=sourceCode.getText(node.right);const example=`crypto.timingSafeEqual(Buffer.from(${leftText}), Buffer.from(${rightText}))`;context.report({node,messageId:"timingUnsafeComparison",data:{operator:node.operator,strictOperator:node.operator,example},suggest:[{messageId:"useStrictEquality",fix:fixer=>fixer.replaceText(node,example)}]});return}if(node.operator==="=="||node.operator==="!="){const text=sourceCode.getText(node);if(matchesIgnorePattern(text,ignorePatterns)){return}if(isNullLiteral(node.left)||isNullLiteral(node.right)){return}const strictOperator=node.operator==="=="?"===":"!==";const leftText=sourceCode.getText(node.left);const rightText=sourceCode.getText(node.right);const example=`${leftText} ${strictOperator} ${rightText}`;context.report({node,messageId:"insecureComparison",data:{operator:node.operator,strictOperator,example},suggest:[{messageId:"useStrictEquality",fix:fixer=>{return fixer.replaceText(node,example)}}]})}}return{BinaryExpression:checkBinaryExpression}}});
|
|
@@ -1 +1 @@
|
|
|
1
|
-
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noMissingAuthentication=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const DEFAULT_AUTH_MIDDLEWARE_PATTERNS=["authenticate","auth","requireAuth","isAuthenticated","verifyToken","checkAuth","ensureAuthenticated","passport.authenticate","jwt","session"];const DEFAULT_ROUTE_HANDLER_PATTERNS=["get","post","put","delete","patch","all","use"];function isInsideAuthMiddleware(node,sourceCode,authPatterns){let current=node;while(current){if(current.parent&¤t.parent.type==="CallExpression"){const callExpr=current.parent;const isArgument=callExpr.arguments.some(arg=>arg===current);if(!isArgument){current=current.parent;continue}const callee=callExpr.callee;if(callee.type==="Identifier"){const calleeName=callee.name.toLowerCase();if(authPatterns.some(pattern=>calleeName.includes(pattern.toLowerCase()))){return true}}if(callee.type==="MemberExpression"&&callee.property.type==="Identifier"){const propertyName=callee.property.name.toLowerCase();if(propertyName==="use"||propertyName==="all"){for(const arg of callExpr.arguments){const argText=sourceCode.getText(arg);if(authPatterns.some(pattern=>argText.toLowerCase().includes(pattern.toLowerCase()))){return true}}}}}if("parent"in current&¤t.parent){current=current.parent}else{break}}return false}function matchesIgnorePattern(text,patterns){return patterns.some(pattern=>{try{const regex=new RegExp(pattern,"i");return regex.test(text)}catch{return text.toLowerCase().includes(pattern.toLowerCase())}})}exports.noMissingAuthentication=(0,eslint_devkit_2.createRule)({name:"no-missing-authentication",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-secure-coding/docs/rules/no-missing-authentication.md",description:"Detects missing authentication checks in route handlers",cwe:"CWE-287",cvss:9.8},hasSuggestions:true,messages:{missingAuthentication:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Missing Authentication",cwe:"CWE-287",description:"Route handler missing authentication check: {{route}}",severity:"CRITICAL",fix:"Add authentication middleware: app.{{method}}('{{path}}', authenticate(), handler)",documentationLink:"https://cwe.mitre.org/data/definitions/287.html"}),addAuthentication:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Add Authentication",description:"Add authentication middleware before route handler",severity:"LOW",fix:'app.get("/path", authenticate(), handler)',documentationLink:"https://cwe.mitre.org/data/definitions/287.html"})},schema:[{type:"object",properties:{allowInTests:{type:"boolean",default:false,description:"Allow missing authentication in test files"},authMiddlewarePatterns:{type:"array",items:{type:"string"},default:DEFAULT_AUTH_MIDDLEWARE_PATTERNS,description:"Authentication middleware patterns to recognize"},routeHandlerPatterns:{type:"array",items:{type:"string"},default:DEFAULT_ROUTE_HANDLER_PATTERNS,description:"Route handler patterns to check"},ignorePatterns:{type:"array",items:{type:"string"},default:[],description:"Additional patterns to ignore"},testFilePattern:{type:"string",default:"\\.(test|spec)\\.(ts|tsx|js|jsx)$",description:"Test file pattern regex string"}},additionalProperties:false}]},defaultOptions:[{allowInTests:false,testFilePattern:"\\.(test|spec)\\.(ts|tsx|js|jsx)$",authMiddlewarePatterns:DEFAULT_AUTH_MIDDLEWARE_PATTERNS,routeHandlerPatterns:DEFAULT_ROUTE_HANDLER_PATTERNS,ignorePatterns:
|
|
1
|
+
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noMissingAuthentication=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const DEFAULT_AUTH_MIDDLEWARE_PATTERNS=["authenticate","auth","requireAuth","isAuthenticated","verifyToken","checkAuth","ensureAuthenticated","passport.authenticate","jwt","session"];const DEFAULT_PUBLIC_ROUTE_PATTERNS=["login","logout","signin","sign-in","signup","sign-up","register","forgot-password","reset-password","password-reset","verify-email","health","healthz","readyz","livez","status","metrics","ping","favicon","webhook","/public/","oauth","callback"];const DEFAULT_ROUTE_HANDLER_PATTERNS=["get","post","put","delete","patch","all","use"];function isInsideAuthMiddleware(node,sourceCode,authPatterns){let current=node;while(current){if(current.parent&¤t.parent.type==="CallExpression"){const callExpr=current.parent;const isArgument=callExpr.arguments.some(arg=>arg===current);if(!isArgument){current=current.parent;continue}const callee=callExpr.callee;if(callee.type==="Identifier"){const calleeName=callee.name.toLowerCase();if(authPatterns.some(pattern=>calleeName.includes(pattern.toLowerCase()))){return true}}if(callee.type==="MemberExpression"&&callee.property.type==="Identifier"){const propertyName=callee.property.name.toLowerCase();if(propertyName==="use"||propertyName==="all"){for(const arg of callExpr.arguments){const argText=sourceCode.getText(arg);if(authPatterns.some(pattern=>argText.toLowerCase().includes(pattern.toLowerCase()))){return true}}}}}if("parent"in current&¤t.parent){current=current.parent}else{break}}return false}function matchesIgnorePattern(text,patterns){return patterns.some(pattern=>{try{const regex=new RegExp(pattern,"i");return regex.test(text)}catch{return text.toLowerCase().includes(pattern.toLowerCase())}})}exports.noMissingAuthentication=(0,eslint_devkit_2.createRule)({name:"no-missing-authentication",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-secure-coding/docs/rules/no-missing-authentication.md",description:"Detects missing authentication checks in route handlers",cwe:"CWE-287",cvss:9.8},hasSuggestions:true,messages:{missingAuthentication:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Missing Authentication",cwe:"CWE-287",description:"Route handler missing authentication check: {{route}}",severity:"CRITICAL",fix:"Add authentication middleware: app.{{method}}('{{path}}', authenticate(), handler)",documentationLink:"https://cwe.mitre.org/data/definitions/287.html"}),addAuthentication:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Add Authentication",description:"Add authentication middleware before route handler",severity:"LOW",fix:'app.get("/path", authenticate(), handler)',documentationLink:"https://cwe.mitre.org/data/definitions/287.html"})},schema:[{type:"object",properties:{allowInTests:{type:"boolean",default:false,description:"Allow missing authentication in test files"},authMiddlewarePatterns:{type:"array",items:{type:"string"},default:DEFAULT_AUTH_MIDDLEWARE_PATTERNS,description:"Authentication middleware patterns to recognize"},routeHandlerPatterns:{type:"array",items:{type:"string"},default:DEFAULT_ROUTE_HANDLER_PATTERNS,description:"Route handler patterns to check"},ignorePatterns:{type:"array",items:{type:"string"},default:[],description:"Additional patterns to ignore"},testFilePattern:{type:"string",default:"\\.(test|spec)\\.(ts|tsx|js|jsx)$",description:"Test file pattern regex string"}},additionalProperties:false}]},defaultOptions:[{allowInTests:false,testFilePattern:"\\.(test|spec)\\.(ts|tsx|js|jsx)$",authMiddlewarePatterns:DEFAULT_AUTH_MIDDLEWARE_PATTERNS,routeHandlerPatterns:DEFAULT_ROUTE_HANDLER_PATTERNS,ignorePatterns:DEFAULT_PUBLIC_ROUTE_PATTERNS}],create(context,[options={}]){const{allowInTests=false,testFilePattern="\\.(test|spec)\\.(ts|tsx|js|jsx)$",authMiddlewarePatterns=DEFAULT_AUTH_MIDDLEWARE_PATTERNS,routeHandlerPatterns=DEFAULT_ROUTE_HANDLER_PATTERNS,ignorePatterns=DEFAULT_PUBLIC_ROUTE_PATTERNS}=options;const filename=context.filename;const testFileRegex=new RegExp(testFilePattern);const isTestFile=allowInTests&&testFileRegex.test(filename);const sourceCode=context.sourceCode;function findVariableDeclaration(identifier){const varName=identifier.name;let current=identifier;while(current){if(current.type==="Program"||current.type==="FunctionDeclaration"||current.type==="FunctionExpression"||current.type==="ArrowFunctionExpression"){const scopeBody=current.type==="Program"?current.body:current.body.type==="BlockStatement"?current.body.body:[];for(const stmt of scopeBody){if(stmt.type==="VariableDeclaration"){for(const declarator of stmt.declarations){if(declarator.id.type==="Identifier"&&declarator.id.name===varName){return declarator}}}}}if("parent"in current&¤t.parent){current=current.parent}else{break}}return null}function isIdentifierFromAuthMiddleware(identifier){const declarator=findVariableDeclaration(identifier);if(!declarator||!declarator.init){return false}if(declarator.init.type==="CallExpression"&&declarator.init.callee.type==="Identifier"){const calleeName=declarator.init.callee.name.toLowerCase();return authMiddlewarePatterns.some(pattern=>calleeName.includes(pattern.toLowerCase()))}return false}function checkCallExpression(node){if(isTestFile){return}if(node.callee.type==="MemberExpression"){const property=node.callee.property;const object=node.callee.object;if(object.type!=="Identifier"){return}const objectName=object.name.toLowerCase();const routerLikeNames=["app","router","server","route","express","fastify","koa","hapi"];const looksLikeRouter=routerLikeNames.some(name=>objectName.includes(name));if(!looksLikeRouter){return}if(property.type==="Identifier"){const methodName=property.name.toLowerCase();if(routeHandlerPatterns.includes(methodName)){if(methodName==="use"){const first=node.arguments[0];const mountsAPath=first!==void 0&&first.type==="Literal"&&typeof first.value==="string";if(!mountsAPath){return}}let routePath="unknown";if(node.arguments.length>0&&node.arguments[0].type==="Literal"){routePath=String(node.arguments[0].value)}else if(node.arguments.length>0){const pathText=sourceCode.getText(node.arguments[0]);routePath=pathText}const text=sourceCode.getText(node);if(matchesIgnorePattern(routePath,ignorePatterns)){return}if(matchesIgnorePattern(text,ignorePatterns)){return}let hasAuth=false;for(const arg of node.arguments){const argText=sourceCode.getText(arg);if(authMiddlewarePatterns.some(pattern=>argText.toLowerCase().includes(pattern.toLowerCase()))){hasAuth=true;break}if(arg.type==="Identifier"&&isIdentifierFromAuthMiddleware(arg)){hasAuth=true;break}}if(!hasAuth&&node.arguments.length>0){const lastArg=node.arguments[node.arguments.length-1];if(lastArg.type==="ArrowFunctionExpression"||lastArg.type==="FunctionExpression"){if(isInsideAuthMiddleware(lastArg,sourceCode,authMiddlewarePatterns)){hasAuth=true}}}if(!hasAuth){context.report({node:node.callee,messageId:"missingAuthentication",data:{route:`${methodName}(${routePath})`,method:methodName,path:routePath},suggest:[{messageId:"addAuthentication",fix:_fixer=>null}]})}}}}}return{CallExpression:checkCallExpression}}});
|
|
@@ -1 +1 @@
|
|
|
1
|
-
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noUnsafeRegexConstruction=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const DEFAULT_TRUSTED_ESCAPING_FUNCTIONS=["escapeRegex","escapeRegExp","escapeStringRegexp","regexpEscape","escape","sanitize"];const INLINE_ESCAPE_SUFFIX='.replace(/[.*+?^${}()|[\\]\\\\]/g, "\\\\$&")';function taintSource(node,depth=0){if(depth>6)return null;if(node.type==="TemplateLiteral"){for(const expression of node.expressions){const found=taintSource(expression,depth+1);if(found!==null)return found}return null}if(node.type==="BinaryExpression"&&node.operator==="+"){return taintSource(node.left,depth+1)??taintSource(node.right,depth+1)}if(node.type==="AwaitExpression"){return taintSource(node.argument,depth+1)}if(node.type==="MemberExpression"){let root=node;const properties=[];while(root.type==="MemberExpression"){if(root.property.type==="Identifier")properties.unshift(root.property.name);root=root.object}if(root.type==="Identifier"){if(REQUEST_ROOTS.has(root.name)&&properties.some(p=>REQUEST_PROPERTIES.has(p))){return`${root.name}.${properties.join(".")}`}if(root.name==="process"&&properties[0]==="argv"){return"process.argv"}}return null}if(node.type==="CallExpression"){const callee=node.callee;if(callee.type==="MemberExpression"&&callee.property.type==="Identifier"){if(READER_METHODS.has(callee.property.name)){return callee.property.name}}if(callee.type==="Identifier"&&READER_METHODS.has(callee.name)){return callee.name}for(const arg of node.arguments){if(arg.type==="SpreadElement")continue;const found=taintSource(arg,depth+1);if(found!==null)return found}return null}return null}const REQUEST_ROOTS=new Set(["req","request","ctx","event","message"]);const REQUEST_PROPERTIES=new Set(["query","params","body","headers","url","path","cookies","data"]);const READER_METHODS=new Set(["readFile","readFileSync","text","json","arrayBuffer","formData","blob"]);function isEscaped(node,trustedFunctions,sourceCode){if(node.type==="CallExpression"&&node.callee.type==="Identifier"){const functionName=node.callee.name;if(trustedFunctions.includes(functionName)){return true}}let current=node;let depth=0;const maxDepth=5;while(depth<maxDepth){const parent=sourceCode.getNodeByRangeIndex?.(current.range[0]-1)||current.parent;if(!parent)break;if(parent.type==="CallExpression"&&parent.callee.type==="Identifier"){const functionName=parent.callee.name;if(trustedFunctions.includes(functionName)){return true}}current=parent;depth++}return false}function hasDynamicFlags(node){if(node.arguments.length>1){const flagsNode=node.arguments[1];return!(flagsNode.type==="Literal"&&typeof flagsNode.value==="string")}return false}function extractPattern(node,sourceCode,trustedFunctions){const patternNode=node.arguments.length>0?node.arguments[0]:null;if(!patternNode){return{patternNode:null,isUserInput:false,taintedBy:null,isEscaped:false}}const taintedBy=taintSource(patternNode);const isUserInputValue=taintedBy!==null;const allTrustedFunctions=[...new Set([...DEFAULT_TRUSTED_ESCAPING_FUNCTIONS,"RegExp.escape",...trustedFunctions])];const isEscapedValue=isEscaped(patternNode,allTrustedFunctions,sourceCode);return{patternNode,isUserInput:isUserInputValue,taintedBy,isEscaped:isEscapedValue}}exports.noUnsafeRegexConstruction=(0,eslint_devkit_2.createRule)({name:"no-unsafe-regex-construction",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-secure-coding/docs/rules/no-unsafe-regex-construction.md",description:"Detects unsafe regex construction patterns (user input without escaping, dynamic flags)",cwe:"CWE-400",cvss:7.5},hasSuggestions:true,messages:{unsafeRegexConstruction:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Unsafe regex construction",cwe:"CWE-400",description:"{{issue}}: {{details}}",severity:"HIGH",fix:"{{fix}}",documentationLink:"https://owasp.org/www-community/attacks/Regular_expression_Denial_of_Service_-_ReDoS"}),escapeUserInput:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Escape User Input",description:"Escape user input for regex",severity:"LOW",fix:'input.replace(/[.*+?^${}()|[\\]\\\\]/g, "\\\\$&")',documentationLink:"https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Regular_Expressions#escaping"}),validatePattern:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Validate Pattern",description:"Validate pattern against whitelist",severity:"LOW",fix:"Validate pattern before creating RegExp",documentationLink:"https://owasp.org/www-community/attacks/Regular_expression_Denial_of_Service_-_ReDoS"}),useSafeLibrary:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Use safe-regex",description:"Use safe-regex library for validation",severity:"LOW",fix:"if (safeRegex(pattern)) { new RegExp(pattern) }",documentationLink:"https://github.com/substack/safe-regex"}),avoidDynamicFlags:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Use Static Flags",description:"Use static flags instead of dynamic",severity:"LOW",fix:'new RegExp(pattern, "gi") with static flags',documentationLink:"https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp"})},schema:[{type:"object",properties:{allowLiterals:{type:"boolean",default:true,description:"Allow literal string patterns"},trustedEscapingFunctions:{type:"array",items:{type:"string"},default:[...DEFAULT_TRUSTED_ESCAPING_FUNCTIONS],description:"Trusted functions that escape input"},maxPatternLength:{type:"number",default:100,minimum:1,description:"Maximum pattern length for dynamic regex"}},additionalProperties:false}]},defaultOptions:[{allowLiterals:true,trustedEscapingFunctions:[...DEFAULT_TRUSTED_ESCAPING_FUNCTIONS],maxPatternLength:100}],create(context,[options={}]){const{allowLiterals=true,maxPatternLength=100,trustedEscapingFunctions=[...DEFAULT_TRUSTED_ESCAPING_FUNCTIONS]}=options;const sourceCode=context.sourceCode;function checkRegExpCall(node){const isRegExpCall=node.type==="CallExpression"&&node.callee.type==="Identifier"&&node.callee.name==="RegExp"||node.type==="NewExpression"&&node.callee.type==="Identifier"&&node.callee.name==="RegExp";if(!isRegExpCall){return}const{patternNode,isUserInput:isUserInputValue,isEscaped:isEscapedValue}=extractPattern(node,sourceCode,trustedEscapingFunctions);if(!patternNode){return}if(patternNode.type==="Literal"&&typeof patternNode.value==="string"){const patternLength=patternNode.value.length;if(patternLength>maxPatternLength){context.report({node:patternNode,messageId:"unsafeRegexConstruction",data:{issue:"Pattern too long",details:`Pattern length (${patternLength}) exceeds maximum (${maxPatternLength})`,fix:"Split into smaller patterns or validate length"},suggest:[{messageId:"validatePattern",fix:()=>null}]});return}if(!allowLiterals){context.report({node:patternNode,messageId:"unsafeRegexConstruction",data:{issue:"Literal regex pattern",details:"Literal regex patterns should be avoided for security. Use variables instead.",fix:"Use a variable or RegExp constructor with a string variable"},suggest:[{messageId:"validatePattern",fix:()=>null}]});return}}if(isUserInputValue&&!isEscapedValue){const patternText=context.sourceCode.getText(patternNode);context.report({node:patternNode,messageId:"unsafeRegexConstruction",data:{issue:"User input in regex without escaping",details:"User input in regex pattern can lead to ReDoS or injection attacks",fix:"Escape special characters before using in regex"},suggest:[{messageId:"escapeUserInput",fix:fixer=>fixer.replaceText(patternNode,`(${patternText})${INLINE_ESCAPE_SUFFIX}`)},{messageId:"validatePattern",fix:()=>null},{messageId:"useSafeLibrary",fix:()=>null}]})}if(hasDynamicFlags(node)){context.report({node,messageId:"unsafeRegexConstruction",data:{issue:"Dynamic regex flags",details:"Dynamic flags can lead to unexpected behavior or security issues",fix:"Use static flags instead of dynamic flags"},suggest:[{messageId:"avoidDynamicFlags",fix:()=>null}]})}}return{CallExpression:checkRegExpCall,NewExpression:checkRegExpCall}}});
|
|
1
|
+
"use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noUnsafeRegexConstruction=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const DEFAULT_TRUSTED_ESCAPING_FUNCTIONS=["escapeRegex","escapeRegExp","escapeStringRegexp","regexpEscape","escape","sanitize"];const INLINE_ESCAPE_SUFFIX='.replace(/[.*+?^${}()|[\\]\\\\]/g, "\\\\$&")';function taintSource(node,depth=0){if(depth>6)return null;if(node.type==="TemplateLiteral"){for(const expression of node.expressions){const found=taintSource(expression,depth+1);if(found!==null)return found}return null}if(node.type==="BinaryExpression"&&node.operator==="+"){return taintSource(node.left,depth+1)??taintSource(node.right,depth+1)}if(node.type==="AwaitExpression"){return taintSource(node.argument,depth+1)}if(node.type==="MemberExpression"){let root=node;const properties=[];while(root.type==="MemberExpression"){if(root.property.type==="Identifier")properties.unshift(root.property.name);root=root.object}if(root.type==="Identifier"){if(REQUEST_ROOTS.has(root.name)&&properties.some(p=>REQUEST_PROPERTIES.has(p))){return`${root.name}.${properties.join(".")}`}if(root.name==="process"&&properties[0]==="argv"){return"process.argv"}}return null}if(node.type==="CallExpression"){const callee=node.callee;if(callee.type==="MemberExpression"&&callee.property.type==="Identifier"){if(READER_METHODS.has(callee.property.name)){return callee.property.name}}if(callee.type==="Identifier"&&READER_METHODS.has(callee.name)){return callee.name}for(const arg of node.arguments){if(arg.type==="SpreadElement")continue;const found=taintSource(arg,depth+1);if(found!==null)return found}return null}return null}const REQUEST_ROOTS=new Set(["req","request","ctx","event","message"]);const REQUEST_PROPERTIES=new Set(["query","params","body","headers","url","path","cookies","data"]);const READER_METHODS=new Set(["readFile","readFileSync","text","json","arrayBuffer","formData","blob"]);function isEscaped(node,trustedFunctions,sourceCode){if(node.type==="CallExpression"&&node.callee.type==="Identifier"){const functionName=node.callee.name;if(trustedFunctions.includes(functionName)){return true}}let current=node;let depth=0;const maxDepth=5;while(depth<maxDepth){const parent=sourceCode.getNodeByRangeIndex?.(current.range[0]-1)||current.parent;if(!parent)break;if(parent.type==="CallExpression"&&parent.callee.type==="Identifier"){const functionName=parent.callee.name;if(trustedFunctions.includes(functionName)){return true}}current=parent;depth++}return false}function isRegexClone(node){if(node.type==="MemberExpression"&&!node.computed&&node.property.type==="Identifier"&&node.property.name==="source"){return true}if(node.type==="BinaryExpression"&&node.operator==="+"){return isRegexClone(node.left)||isRegexClone(node.right)}return false}function hasDynamicFlags(node){if(node.arguments.length>1){const flagsNode=node.arguments[1];return!(flagsNode.type==="Literal"&&typeof flagsNode.value==="string")}return false}function extractPattern(node,sourceCode,trustedFunctions){const patternNode=node.arguments.length>0?node.arguments[0]:null;if(!patternNode){return{patternNode:null,isUserInput:false,taintedBy:null,isEscaped:false}}const taintedBy=taintSource(patternNode);const isUserInputValue=taintedBy!==null;const allTrustedFunctions=[...new Set([...DEFAULT_TRUSTED_ESCAPING_FUNCTIONS,"RegExp.escape",...trustedFunctions])];const isEscapedValue=isEscaped(patternNode,allTrustedFunctions,sourceCode);return{patternNode,isUserInput:isUserInputValue,taintedBy,isEscaped:isEscapedValue}}exports.noUnsafeRegexConstruction=(0,eslint_devkit_2.createRule)({name:"no-unsafe-regex-construction",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-secure-coding/docs/rules/no-unsafe-regex-construction.md",description:"Detects unsafe regex construction patterns (user input without escaping, dynamic flags)",cwe:"CWE-400",cvss:7.5},hasSuggestions:true,messages:{unsafeRegexConstruction:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.SECURITY,issueName:"Unsafe regex construction",cwe:"CWE-400",description:"{{issue}}: {{details}}",severity:"HIGH",fix:"{{fix}}",documentationLink:"https://owasp.org/www-community/attacks/Regular_expression_Denial_of_Service_-_ReDoS"}),escapeUserInput:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Escape User Input",description:"Escape user input for regex",severity:"LOW",fix:'input.replace(/[.*+?^${}()|[\\]\\\\]/g, "\\\\$&")',documentationLink:"https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Regular_Expressions#escaping"}),validatePattern:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Validate Pattern",description:"Validate pattern against whitelist",severity:"LOW",fix:"Validate pattern before creating RegExp",documentationLink:"https://owasp.org/www-community/attacks/Regular_expression_Denial_of_Service_-_ReDoS"}),useSafeLibrary:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Use safe-regex",description:"Use safe-regex library for validation",severity:"LOW",fix:"if (safeRegex(pattern)) { new RegExp(pattern) }",documentationLink:"https://github.com/substack/safe-regex"}),avoidDynamicFlags:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Use Static Flags",description:"Use static flags instead of dynamic",severity:"LOW",fix:'new RegExp(pattern, "gi") with static flags',documentationLink:"https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp"})},schema:[{type:"object",properties:{allowLiterals:{type:"boolean",default:true,description:"Allow literal string patterns"},trustedEscapingFunctions:{type:"array",items:{type:"string"},default:[...DEFAULT_TRUSTED_ESCAPING_FUNCTIONS],description:"Trusted functions that escape input"},maxPatternLength:{type:"number",default:100,minimum:1,description:"Maximum pattern length for dynamic regex"}},additionalProperties:false}]},defaultOptions:[{allowLiterals:true,trustedEscapingFunctions:[...DEFAULT_TRUSTED_ESCAPING_FUNCTIONS],maxPatternLength:100}],create(context,[options={}]){const{allowLiterals=true,maxPatternLength=100,trustedEscapingFunctions=[...DEFAULT_TRUSTED_ESCAPING_FUNCTIONS]}=options;const sourceCode=context.sourceCode;function checkRegExpCall(node){const isRegExpCall=node.type==="CallExpression"&&node.callee.type==="Identifier"&&node.callee.name==="RegExp"||node.type==="NewExpression"&&node.callee.type==="Identifier"&&node.callee.name==="RegExp";if(!isRegExpCall){return}const{patternNode,isUserInput:isUserInputValue,isEscaped:isEscapedValue}=extractPattern(node,sourceCode,trustedEscapingFunctions);if(!patternNode){return}if(patternNode.type==="Literal"&&typeof patternNode.value==="string"){const patternLength=patternNode.value.length;if(patternLength>maxPatternLength){context.report({node:patternNode,messageId:"unsafeRegexConstruction",data:{issue:"Pattern too long",details:`Pattern length (${patternLength}) exceeds maximum (${maxPatternLength})`,fix:"Split into smaller patterns or validate length"},suggest:[{messageId:"validatePattern",fix:()=>null}]});return}if(!allowLiterals){context.report({node:patternNode,messageId:"unsafeRegexConstruction",data:{issue:"Literal regex pattern",details:"Literal regex patterns should be avoided for security. Use variables instead.",fix:"Use a variable or RegExp constructor with a string variable"},suggest:[{messageId:"validatePattern",fix:()=>null}]});return}}if(isUserInputValue&&!isEscapedValue){const patternText=context.sourceCode.getText(patternNode);context.report({node:patternNode,messageId:"unsafeRegexConstruction",data:{issue:"User input in regex without escaping",details:"User input in regex pattern can lead to ReDoS or injection attacks",fix:"Escape special characters before using in regex"},suggest:[{messageId:"escapeUserInput",fix:fixer=>fixer.replaceText(patternNode,`(${patternText})${INLINE_ESCAPE_SUFFIX}`)},{messageId:"validatePattern",fix:()=>null},{messageId:"useSafeLibrary",fix:()=>null}]})}if(hasDynamicFlags(node)&&!isRegexClone(patternNode)){context.report({node,messageId:"unsafeRegexConstruction",data:{issue:"Dynamic regex flags",details:"Dynamic flags can lead to unexpected behavior or security issues",fix:"Use static flags instead of dynamic flags"},suggest:[{messageId:"avoidDynamicFlags",fix:()=>null}]})}}return{CallExpression:checkRegExpCall,NewExpression:checkRegExpCall}}});
|