eslint-plugin-secure-coding 3.4.4 → 3.5.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/README.md CHANGED
@@ -96,7 +96,7 @@ The competitor's entropy-only detection catches the high-entropy API-key shape b
96
96
  ## 📦 Compatibility
97
97
  | Package | Version |
98
98
  | :--- | :--- |
99
- | ESLint | `^8.0.0 \|\| ^9.0.0 \|\| ^10.0.0` |
99
+ | ESLint | `^8.40.0 \|\| ^9.0.0 \|\| ^10.0.0` |
100
100
  | Node.js | `>=18.0.0` |
101
101
 
102
102
  See the [ESLint Version Support Policy](../../docs/ESLINT_VERSION_SUPPORT.md) — current ecosystem share data, the 20% gate, and the forward-looking exception that covers v10.
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "eslint-plugin-secure-coding",
3
- "version": "3.4.4",
3
+ "version": "3.5.0",
4
4
  "description": "ESLint plugin for secure coding — detects LDAP, XPath, XXE, GraphQL and template injection, unsafe deserialization, ReDoS, missing authentication, and PII in logs.",
5
5
  "type": "commonjs",
6
6
  "main": "./src/index.js",
@@ -77,12 +77,12 @@
77
77
  "node": ">=18.0.0"
78
78
  },
79
79
  "dependencies": {
80
- "@interlace/eslint-devkit": "^1.10.0",
80
+ "@interlace/eslint-devkit": "^1.11.0",
81
81
  "scslre": "^0.3.0",
82
82
  "@eslint-community/regexpp": "^4.10.0"
83
83
  },
84
84
  "peerDependencies": {
85
- "eslint": "^8.0.0 || ^9.0.0 || ^10.0.0"
85
+ "eslint": "^8.40.0 || ^9.0.0 || ^10.0.0"
86
86
  },
87
87
  "funding": {
88
88
  "type": "github",
package/src/index.js CHANGED
@@ -1 +1 @@
1
- "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.configs=exports.plugin=exports.rules=void 0;exports.rules={get"no-graphql-injection"(){return require("./rules/no-graphql-injection").noGraphqlInjection},get"no-xxe-injection"(){return require("./rules/no-xxe-injection").noXxeInjection},get"no-xpath-injection"(){return require("./rules/no-xpath-injection").noXpathInjection},get"no-ldap-injection"(){return require("./rules/no-ldap-injection").noLdapInjection},get"no-directive-injection"(){return require("./rules/no-directive-injection").noDirectiveInjection},get"no-format-string-injection"(){return require("./rules/no-format-string-injection").noFormatStringInjection},get"no-template-injection"(){return require("./rules/no-template-injection").noTemplateInjection},get"detect-non-literal-regexp"(){return require("./rules/detect-non-literal-regexp").detectNonLiteralRegexp},get"no-redos-vulnerable-regex"(){return require("./rules/no-redos-vulnerable-regex").noRedosVulnerableRegex},get"no-unsafe-regex-construction"(){return require("./rules/no-unsafe-regex-construction").noUnsafeRegexConstruction},get"detect-object-injection"(){return require("./rules/detect-object-injection").detectObjectInjection},get"no-unsafe-deserialization"(){return require("./rules/no-unsafe-deserialization").noUnsafeDeserialization},get"no-insecure-comparison"(){return require("./rules/no-insecure-comparison").noInsecureComparison},get"no-improper-sanitization"(){return require("./rules/no-improper-sanitization").noImproperSanitization},get"no-improper-type-validation"(){return require("./rules/no-improper-type-validation").noImproperTypeValidation},get"no-missing-authentication"(){return require("./rules/no-missing-authentication").noMissingAuthentication},get"no-privilege-escalation"(){return require("./rules/no-privilege-escalation").noPrivilegeEscalation},get"no-weak-password-recovery"(){return require("./rules/no-weak-password-recovery").noWeakPasswordRecovery},get"require-backend-authorization"(){return require("./rules/require-backend-authorization").requireBackendAuthorization},get"no-hardcoded-credentials"(){return require("./rules/no-hardcoded-credentials").noHardcodedCredentials},get"no-sensitive-data-exposure"(){return require("./rules/no-sensitive-data-exposure").noSensitiveDataExposure},get"no-pii-in-logs"(){return require("./rules/no-pii-in-logs").noPiiInLogs},get"no-unlimited-resource-allocation"(){return require("./rules/no-unlimited-resource-allocation").noUnlimitedResourceAllocation},get"no-unchecked-loop-condition"(){return require("./rules/no-unchecked-loop-condition").noUncheckedLoopCondition},get"detect-weak-password-validation"(){return require("./rules/detect-weak-password-validation").detectWeakPasswordValidation},get"no-electron-security-issues"(){return require("./rules/no-electron-security-issues").noElectronSecurityIssues},get"no-hardcoded-session-tokens"(){return require("./rules/no-hardcoded-session-tokens").noHardcodedSessionTokens},get"require-secure-defaults"(){return require("./rules/require-secure-defaults").requireSecureDefaults}};exports.plugin={meta:{name:"eslint-plugin-secure-coding",version:"3.4.4"},rules:exports.rules};const recommendedRules={"secure-coding/no-graphql-injection":"warn","secure-coding/no-xxe-injection":"error","secure-coding/no-xpath-injection":"error","secure-coding/no-ldap-injection":"error","secure-coding/no-unsafe-deserialization":"warn","secure-coding/detect-non-literal-regexp":"warn","secure-coding/no-redos-vulnerable-regex":"error","secure-coding/no-unsafe-regex-construction":"error","secure-coding/detect-object-injection":"warn","secure-coding/no-hardcoded-credentials":"error","secure-coding/no-template-injection":"error","secure-coding/no-improper-sanitization":"error","secure-coding/no-privilege-escalation":"warn","secure-coding/no-weak-password-recovery":"warn","secure-coding/no-sensitive-data-exposure":"warn","secure-coding/no-unlimited-resource-allocation":"warn","secure-coding/no-unchecked-loop-condition":"warn"};exports.configs={flagship:{plugins:{"secure-coding":exports.plugin},rules:{"secure-coding/no-hardcoded-credentials":"error","secure-coding/no-redos-vulnerable-regex":"error"}},recommended:{plugins:{"secure-coding":exports.plugin},rules:recommendedRules},"recommended-strict":{plugins:{"secure-coding":exports.plugin},rules:Object.fromEntries(Object.keys(recommendedRules).map(rule=>[rule,"error"]))},strict:{plugins:{"secure-coding":exports.plugin},rules:Object.fromEntries(Object.keys(exports.rules).map(ruleName=>[`secure-coding/${ruleName}`,"error"]))},"owasp-top-10":{plugins:{"secure-coding":exports.plugin},rules:{"secure-coding/no-privilege-escalation":"warn","secure-coding/no-hardcoded-credentials":"error","secure-coding/no-sensitive-data-exposure":"warn","secure-coding/no-graphql-injection":"error","secure-coding/no-xxe-injection":"error","secure-coding/no-xpath-injection":"error","secure-coding/no-ldap-injection":"error","secure-coding/no-weak-password-recovery":"error","secure-coding/no-improper-type-validation":"error","secure-coding/no-unsafe-deserialization":"error"}}};exports.default=exports.plugin;
1
+ "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.configs=exports.plugin=exports.rules=void 0;exports.rules={get"no-graphql-injection"(){return require("./rules/no-graphql-injection").noGraphqlInjection},get"no-xxe-injection"(){return require("./rules/no-xxe-injection").noXxeInjection},get"no-xpath-injection"(){return require("./rules/no-xpath-injection").noXpathInjection},get"no-ldap-injection"(){return require("./rules/no-ldap-injection").noLdapInjection},get"no-directive-injection"(){return require("./rules/no-directive-injection").noDirectiveInjection},get"no-format-string-injection"(){return require("./rules/no-format-string-injection").noFormatStringInjection},get"no-template-injection"(){return require("./rules/no-template-injection").noTemplateInjection},get"detect-non-literal-regexp"(){return require("./rules/detect-non-literal-regexp").detectNonLiteralRegexp},get"no-redos-vulnerable-regex"(){return require("./rules/no-redos-vulnerable-regex").noRedosVulnerableRegex},get"no-unsafe-regex-construction"(){return require("./rules/no-unsafe-regex-construction").noUnsafeRegexConstruction},get"detect-object-injection"(){return require("./rules/detect-object-injection").detectObjectInjection},get"no-unsafe-deserialization"(){return require("./rules/no-unsafe-deserialization").noUnsafeDeserialization},get"no-insecure-comparison"(){return require("./rules/no-insecure-comparison").noInsecureComparison},get"no-improper-sanitization"(){return require("./rules/no-improper-sanitization").noImproperSanitization},get"no-improper-type-validation"(){return require("./rules/no-improper-type-validation").noImproperTypeValidation},get"no-missing-authentication"(){return require("./rules/no-missing-authentication").noMissingAuthentication},get"no-privilege-escalation"(){return require("./rules/no-privilege-escalation").noPrivilegeEscalation},get"no-weak-password-recovery"(){return require("./rules/no-weak-password-recovery").noWeakPasswordRecovery},get"require-backend-authorization"(){return require("./rules/require-backend-authorization").requireBackendAuthorization},get"no-hardcoded-credentials"(){return require("./rules/no-hardcoded-credentials").noHardcodedCredentials},get"no-sensitive-data-exposure"(){return require("./rules/no-sensitive-data-exposure").noSensitiveDataExposure},get"no-pii-in-logs"(){return require("./rules/no-pii-in-logs").noPiiInLogs},get"no-unlimited-resource-allocation"(){return require("./rules/no-unlimited-resource-allocation").noUnlimitedResourceAllocation},get"no-unchecked-loop-condition"(){return require("./rules/no-unchecked-loop-condition").noUncheckedLoopCondition},get"detect-weak-password-validation"(){return require("./rules/detect-weak-password-validation").detectWeakPasswordValidation},get"no-electron-security-issues"(){return require("./rules/no-electron-security-issues").noElectronSecurityIssues},get"no-hardcoded-session-tokens"(){return require("./rules/no-hardcoded-session-tokens").noHardcodedSessionTokens},get"require-secure-defaults"(){return require("./rules/require-secure-defaults").requireSecureDefaults}};exports.plugin={meta:{name:"eslint-plugin-secure-coding",version:"3.5.0"},rules:exports.rules};const recommendedRules={"secure-coding/no-graphql-injection":"warn","secure-coding/no-xxe-injection":"error","secure-coding/no-xpath-injection":"error","secure-coding/no-ldap-injection":"error","secure-coding/no-unsafe-deserialization":"warn","secure-coding/detect-non-literal-regexp":"warn","secure-coding/no-redos-vulnerable-regex":"error","secure-coding/no-unsafe-regex-construction":"error","secure-coding/no-hardcoded-credentials":"error","secure-coding/no-template-injection":"error","secure-coding/no-improper-sanitization":"error","secure-coding/no-privilege-escalation":"warn","secure-coding/no-weak-password-recovery":"warn","secure-coding/no-sensitive-data-exposure":"warn","secure-coding/no-unlimited-resource-allocation":"warn","secure-coding/no-unchecked-loop-condition":"warn"};exports.configs={flagship:{plugins:{"secure-coding":exports.plugin},rules:{"secure-coding/no-hardcoded-credentials":"error","secure-coding/no-redos-vulnerable-regex":"error"}},recommended:{plugins:{"secure-coding":exports.plugin},rules:recommendedRules},"recommended-strict":{plugins:{"secure-coding":exports.plugin},rules:Object.fromEntries(Object.keys(recommendedRules).map(rule=>[rule,"error"]))},strict:{plugins:{"secure-coding":exports.plugin},rules:Object.fromEntries(Object.keys(exports.rules).map(ruleName=>[`secure-coding/${ruleName}`,"error"]))},"owasp-top-10":{plugins:{"secure-coding":exports.plugin},rules:{"secure-coding/no-privilege-escalation":"warn","secure-coding/no-hardcoded-credentials":"error","secure-coding/no-sensitive-data-exposure":"warn","secure-coding/no-graphql-injection":"error","secure-coding/no-xxe-injection":"error","secure-coding/no-xpath-injection":"error","secure-coding/no-ldap-injection":"error","secure-coding/no-weak-password-recovery":"error","secure-coding/no-improper-type-validation":"error","secure-coding/no-unsafe-deserialization":"error"}}};exports.default=exports.plugin;
@@ -1 +1 @@
1
- "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.detectNonLiteralRegexp=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const isRegExpLiteral=node=>{return node.type==="Literal"&&Object.prototype.hasOwnProperty.call(node,"regex")};const REGEXP_PATTERNS=[{pattern:"new RegExp\\(.*\\)",dangerous:true,vulnerability:"redos",safeAlternative:"Pre-defined RegExp constants",example:{bad:"new RegExp(userInput)",good:"const PATTERNS = { email: /^[a-zA-Z0-9]+$/ }; PATTERNS[userChoice]"},effort:"10-15 minutes",riskLevel:"high"},{pattern:"RegExp\\(.*\\)",dangerous:true,vulnerability:"redos",safeAlternative:"Static RegExp literals or validated patterns",example:{bad:"RegExp(userPattern)",good:"const safePattern = userPattern.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\$&'); new RegExp(`^${safePattern}$`)"},effort:"15-20 minutes",riskLevel:"high"},{pattern:"/.*\\*\\*.*|.*\\+\\+.*|.*\\?\\?/",dangerous:true,vulnerability:"redos",safeAlternative:"Avoid nested quantifiers, use atomic groups",example:{bad:"/(a+)+b/",good:"/(?>a+)b/"},effort:"20-30 minutes",riskLevel:"critical"}];exports.detectNonLiteralRegexp=(0,eslint_devkit_2.createRule)({name:"detect-non-literal-regexp",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-secure-coding/docs/rules/detect-non-literal-regexp.md",description:"Detects RegExp(variable), which might allow an attacker to DOS your server with a long-running regular expression",cwe:"CWE-400"},messages:{regexpReDoS:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.WARNING,issueName:"ReDoS vulnerability",cwe:"CWE-400",description:"ReDoS vulnerability detected",severity:"{{riskLevel}}",fix:"{{safeAlternative}}",documentationLink:"https://owasp.org/www-community/attacks/Regular_expression_Denial_of_Service_-_ReDoS"}),useStaticRegex:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Use Static Regex",description:"Use pre-defined RegExp constants",severity:"LOW",fix:"const PATTERN = /^[a-z]+$/; // Define at module level",documentationLink:"https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp"}),validateInput:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Validate Input",description:"Validate and escape user input",severity:"LOW",fix:"Validate input length and characters before RegExp",documentationLink:"https://owasp.org/www-community/attacks/Regular_expression_Denial_of_Service_-_ReDoS"}),useRegexLibrary:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Use Safe Library",description:"Use safe-regex library or re2",severity:"LOW",fix:'import { isSafe } from "safe-regex"; if (isSafe(pattern)) ...',documentationLink:"https://github.com/substack/safe-regex"}),addTimeout:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Add Timeout",description:"Add timeout to regex operations",severity:"LOW",fix:"Use timeout wrapper for regex operations",documentationLink:"https://owasp.org/www-community/attacks/Regular_expression_Denial_of_Service_-_ReDoS"}),escapeUserInput:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Escape Input",description:"Escape special regex characters",severity:"LOW",fix:'input.replace(/[.*+?^${}()|[\\]\\\\]/g, "\\\\$&")',documentationLink:"https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Regular_Expressions#escaping"})},schema:[{type:"object",properties:{allowLiterals:{type:"boolean",default:false,description:"Allow literal string regex patterns"},additionalPatterns:{type:"array",items:{type:"string"},default:[],description:"Additional RegExp creation patterns to check"},maxPatternLength:{type:"number",default:100,minimum:1,description:"Maximum allowed pattern length for dynamic regex"}},additionalProperties:false}]},defaultOptions:[{allowLiterals:false,additionalPatterns:[],maxPatternLength:100}],create(context){const options=context.options[0]||{};const{allowLiterals=false,maxPatternLength=100}=options;const isLiteralString=node=>{if(node.type==="Literal"&&typeof node.value==="string"){return true}if(node.type==="TemplateLiteral"&&node.expressions.length===0){return true}return false};const hasReDoSPatterns=pattern=>{const nestedQuantifierPatterns=[/\([^)]*[+*]\)[+*]/,/\([^)]*[+*]\)\{[0-9,]+\}/];for(const dangerousPattern of nestedQuantifierPatterns){if(dangerousPattern.test(pattern)){return true}}return false};const extractPattern=node=>{const sourceCode=context.sourceCode;let constructor="RegExp";if(node.type==="NewExpression"&&node.callee.type==="Identifier"){constructor=`new ${node.callee.name}`}const patternNode=node.arguments.length>0?node.arguments[0]:null;const pattern=patternNode?sourceCode.getText(patternNode):"";const isDynamic=patternNode?!isLiteralString(patternNode):false;const length=patternNode&&isLiteralString(patternNode)?String(patternNode.value).length:pattern.length;return{pattern,patternNode,constructor,isDynamic,length}};const detectVulnerability=(pattern,isDynamic)=>{if(isDynamic){for(const vuln of REGEXP_PATTERNS){if(new RegExp(vuln.pattern,"i").test(pattern)){return vuln}}return{pattern:"dynamic",dangerous:true,vulnerability:"redos",safeAlternative:"Pre-defined RegExp constants",example:{bad:pattern,good:"const PATTERNS = { email: /^[a-zA-Z0-9]+$/ }; PATTERNS[type]"},effort:"10-15 minutes",riskLevel:"high"}}if(hasReDoSPatterns(pattern)){return{pattern:"redos-literal",dangerous:true,vulnerability:"redos",safeAlternative:"Restructure regex to avoid nested quantifiers",example:{bad:pattern,good:pattern.replace(/(a+)\+/g,"$1")},effort:"20-30 minutes",riskLevel:"high"}}return null};const generateRefactoringSteps=vulnerability=>{if(vulnerability.pattern==="dynamic"){return[" 1. Create a whitelist of allowed regex patterns"," 2. Use object lookup: PATTERNS[userChoice]"," 3. If dynamic needed: escape input with regex escaping function"," 4. Add pattern length validation"," 5. Consider using a safe regex library"].join("\n")}if(vulnerability.pattern==="redos-literal"){return[" 1. Identify nested quantifiers (*+, ++, ?+)"," 2. Restructure regex to avoid exponential backtracking"," 3. Use atomic groups if supported: (?>...)"," 4. Test regex performance with long inputs"," 5. Consider alternatives like string methods"].join("\n")}return[" 1. Avoid nested quantifiers and backreferences"," 2. Use possessive quantifiers: *+, ++, ?+"," 3. Restructure regex to be more specific"," 4. Test with potentially malicious inputs"," 5. Consider safe-regex library validation"].join("\n")};const determineRiskLevel=(vulnerability,pattern)=>{if(vulnerability.riskLevel==="critical"||hasReDoSPatterns(pattern)){return"CRITICAL"}return"HIGH"};const checkRegExpCall=node=>{const isRegExpCall=node.callee.type==="Identifier"&&node.callee.name==="RegExp";const isNewRegExp=node.type==="NewExpression"&&node.callee.type==="Identifier"&&node.callee.name==="RegExp";if(!isRegExpCall&&!isNewRegExp){return}const{pattern,patternNode,isDynamic,length}=extractPattern(node);if(allowLiterals&&patternNode&&isLiteralString(patternNode)&&length<=maxPatternLength){if(!hasReDoSPatterns(pattern)){return}}const vulnerability=detectVulnerability(pattern,isDynamic);const effectiveVulnerability=vulnerability;if(!effectiveVulnerability){return}const riskLevel=determineRiskLevel(effectiveVulnerability,pattern);const steps=generateRefactoringSteps(effectiveVulnerability);context.report({node,messageId:"regexpReDoS",data:{pattern:pattern.substring(0,30)+(pattern.length>30?"...":""),riskLevel,vulnerability:effectiveVulnerability.vulnerability,safeAlternative:effectiveVulnerability.safeAlternative,steps,effort:effectiveVulnerability.effort},suggest:[{messageId:"useStaticRegex",fix:()=>null},{messageId:"validateInput",fix:()=>null},{messageId:"useRegexLibrary",fix:()=>null},{messageId:"addTimeout",fix:()=>null},{messageId:"escapeUserInput",fix:()=>null}]})};const checkLiteralRegExp=node=>{if(!isRegExpLiteral(node)){return}const pattern=node.regex.pattern;if(hasReDoSPatterns(pattern)){const vulnerability=detectVulnerability(pattern,false);const riskLevel=determineRiskLevel(vulnerability,pattern);const steps=generateRefactoringSteps(vulnerability);context.report({node,messageId:"regexpReDoS",data:{pattern:pattern.substring(0,30)+(pattern.length>30?"...":""),riskLevel,vulnerability:vulnerability.vulnerability,safeAlternative:vulnerability.safeAlternative,steps,effort:vulnerability.effort}})}};return{CallExpression:checkRegExpCall,NewExpression:checkRegExpCall,Literal:checkLiteralRegExp}}});
1
+ "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.detectNonLiteralRegexp=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const isRegExpLiteral=node=>{return node.type==="Literal"&&Object.prototype.hasOwnProperty.call(node,"regex")};const REGEXP_PATTERNS=[{pattern:"new RegExp\\(.*\\)",dangerous:true,vulnerability:"redos",safeAlternative:"Pre-defined RegExp constants",example:{bad:"new RegExp(userInput)",good:"const PATTERNS = { email: /^[a-zA-Z0-9]+$/ }; PATTERNS[userChoice]"},effort:"10-15 minutes",riskLevel:"high"},{pattern:"RegExp\\(.*\\)",dangerous:true,vulnerability:"redos",safeAlternative:"Static RegExp literals or validated patterns",example:{bad:"RegExp(userPattern)",good:"const safePattern = userPattern.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\$&'); new RegExp(`^${safePattern}$`)"},effort:"15-20 minutes",riskLevel:"high"},{pattern:"/.*\\*\\*.*|.*\\+\\+.*|.*\\?\\?/",dangerous:true,vulnerability:"redos",safeAlternative:"Avoid nested quantifiers, use atomic groups",example:{bad:"/(a+)+b/",good:"/(?>a+)b/"},effort:"20-30 minutes",riskLevel:"critical"}];exports.detectNonLiteralRegexp=(0,eslint_devkit_2.createRule)({name:"detect-non-literal-regexp",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-secure-coding/docs/rules/detect-non-literal-regexp.md",description:"Detects RegExp(variable), which might allow an attacker to DOS your server with a long-running regular expression",cwe:"CWE-400"},hasSuggestions:true,messages:{regexpReDoS:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.WARNING,issueName:"ReDoS vulnerability",cwe:"CWE-400",description:"ReDoS vulnerability detected",severity:"{{riskLevel}}",fix:"{{safeAlternative}}",documentationLink:"https://owasp.org/www-community/attacks/Regular_expression_Denial_of_Service_-_ReDoS"}),useStaticRegex:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Use Static Regex",description:"Use pre-defined RegExp constants",severity:"LOW",fix:"const PATTERN = /^[a-z]+$/; // Define at module level",documentationLink:"https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp"}),validateInput:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Validate Input",description:"Validate and escape user input",severity:"LOW",fix:"Validate input length and characters before RegExp",documentationLink:"https://owasp.org/www-community/attacks/Regular_expression_Denial_of_Service_-_ReDoS"}),useRegexLibrary:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Use Safe Library",description:"Use safe-regex library or re2",severity:"LOW",fix:'import { isSafe } from "safe-regex"; if (isSafe(pattern)) ...',documentationLink:"https://github.com/substack/safe-regex"}),addTimeout:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Add Timeout",description:"Add timeout to regex operations",severity:"LOW",fix:"Use timeout wrapper for regex operations",documentationLink:"https://owasp.org/www-community/attacks/Regular_expression_Denial_of_Service_-_ReDoS"}),escapeUserInput:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Escape Input",description:"Escape special regex characters",severity:"LOW",fix:'input.replace(/[.*+?^${}()|[\\]\\\\]/g, "\\\\$&")',documentationLink:"https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Regular_Expressions#escaping"})},schema:[{type:"object",properties:{allowLiterals:{type:"boolean",default:false,description:"Allow literal string regex patterns"},additionalPatterns:{type:"array",items:{type:"string"},default:[],description:"Additional RegExp creation patterns to check"},maxPatternLength:{type:"number",default:100,minimum:1,description:"Maximum allowed pattern length for dynamic regex"}},additionalProperties:false}]},defaultOptions:[{allowLiterals:false,additionalPatterns:[],maxPatternLength:100}],create(context){const options=context.options[0]||{};const{allowLiterals=false,maxPatternLength=100}=options;const isLiteralString=node=>{if(node.type==="Literal"&&typeof node.value==="string"){return true}if(node.type==="TemplateLiteral"&&node.expressions.length===0){return true}return false};const hasReDoSPatterns=pattern=>{const nestedQuantifierPatterns=[/\([^)]*[+*]\)[+*]/,/\([^)]*[+*]\)\{[0-9,]+\}/];for(const dangerousPattern of nestedQuantifierPatterns){if(dangerousPattern.test(pattern)){return true}}return false};const extractPattern=node=>{const sourceCode=context.sourceCode;let constructor="RegExp";if(node.type==="NewExpression"&&node.callee.type==="Identifier"){constructor=`new ${node.callee.name}`}const patternNode=node.arguments.length>0?node.arguments[0]:null;const pattern=patternNode?sourceCode.getText(patternNode):"";const isDynamic=patternNode?!isLiteralString(patternNode):false;const length=patternNode&&isLiteralString(patternNode)?String(patternNode.value).length:pattern.length;return{pattern,patternNode,constructor,isDynamic,length}};const detectVulnerability=(pattern,isDynamic)=>{if(isDynamic){for(const vuln of REGEXP_PATTERNS){if(new RegExp(vuln.pattern,"i").test(pattern)){return vuln}}return{pattern:"dynamic",dangerous:true,vulnerability:"redos",safeAlternative:"Pre-defined RegExp constants",example:{bad:pattern,good:"const PATTERNS = { email: /^[a-zA-Z0-9]+$/ }; PATTERNS[type]"},effort:"10-15 minutes",riskLevel:"high"}}if(hasReDoSPatterns(pattern)){return{pattern:"redos-literal",dangerous:true,vulnerability:"redos",safeAlternative:"Restructure regex to avoid nested quantifiers",example:{bad:pattern,good:pattern.replace(/(a+)\+/g,"$1")},effort:"20-30 minutes",riskLevel:"high"}}return null};const generateRefactoringSteps=vulnerability=>{if(vulnerability.pattern==="dynamic"){return[" 1. Create a whitelist of allowed regex patterns"," 2. Use object lookup: PATTERNS[userChoice]"," 3. If dynamic needed: escape input with regex escaping function"," 4. Add pattern length validation"," 5. Consider using a safe regex library"].join("\n")}if(vulnerability.pattern==="redos-literal"){return[" 1. Identify nested quantifiers (*+, ++, ?+)"," 2. Restructure regex to avoid exponential backtracking"," 3. Use atomic groups if supported: (?>...)"," 4. Test regex performance with long inputs"," 5. Consider alternatives like string methods"].join("\n")}return[" 1. Avoid nested quantifiers and backreferences"," 2. Use possessive quantifiers: *+, ++, ?+"," 3. Restructure regex to be more specific"," 4. Test with potentially malicious inputs"," 5. Consider safe-regex library validation"].join("\n")};const determineRiskLevel=(vulnerability,pattern)=>{if(vulnerability.riskLevel==="critical"||hasReDoSPatterns(pattern)){return"CRITICAL"}return"HIGH"};const checkRegExpCall=node=>{const isRegExpCall=node.callee.type==="Identifier"&&node.callee.name==="RegExp";const isNewRegExp=node.type==="NewExpression"&&node.callee.type==="Identifier"&&node.callee.name==="RegExp";if(!isRegExpCall&&!isNewRegExp){return}const{pattern,patternNode,isDynamic,length}=extractPattern(node);if(allowLiterals&&patternNode&&isLiteralString(patternNode)&&length<=maxPatternLength){if(!hasReDoSPatterns(pattern)){return}}const vulnerability=detectVulnerability(pattern,isDynamic);const effectiveVulnerability=vulnerability;if(!effectiveVulnerability){return}const riskLevel=determineRiskLevel(effectiveVulnerability,pattern);const steps=generateRefactoringSteps(effectiveVulnerability);context.report({node,messageId:"regexpReDoS",data:{pattern:pattern.substring(0,30)+(pattern.length>30?"...":""),riskLevel,vulnerability:effectiveVulnerability.vulnerability,safeAlternative:effectiveVulnerability.safeAlternative,steps,effort:effectiveVulnerability.effort},suggest:[{messageId:"useStaticRegex",fix:()=>null},{messageId:"validateInput",fix:()=>null},{messageId:"useRegexLibrary",fix:()=>null},{messageId:"addTimeout",fix:()=>null},{messageId:"escapeUserInput",fix:()=>null}]})};const checkLiteralRegExp=node=>{if(!isRegExpLiteral(node)){return}const pattern=node.regex.pattern;if(hasReDoSPatterns(pattern)){const vulnerability=detectVulnerability(pattern,false);const riskLevel=determineRiskLevel(vulnerability,pattern);const steps=generateRefactoringSteps(vulnerability);context.report({node,messageId:"regexpReDoS",data:{pattern:pattern.substring(0,30)+(pattern.length>30?"...":""),riskLevel,vulnerability:vulnerability.vulnerability,safeAlternative:vulnerability.safeAlternative,steps,effort:vulnerability.effort}})}};return{CallExpression:checkRegExpCall,NewExpression:checkRegExpCall,Literal:checkLiteralRegExp}}});
@@ -1 +1 @@
1
- "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.detectObjectInjection=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const eslint_devkit_3=require("@interlace/eslint-devkit");const TYPED_ARRAY_CTORS=new Set(["Int8Array","Uint8Array","Uint8ClampedArray","Int16Array","Uint16Array","Int32Array","Uint32Array","Float32Array","Float64Array","BigInt64Array","BigUint64Array"]);const OBJECT_INJECTION_PATTERNS=[{pattern:"__proto__",dangerous:true,vulnerability:"prototype-pollution",safeAlternative:"Object.create(null) or Map",example:{bad:'obj[userInput] = value; // if userInput is "__proto__"',good:"const map = new Map(); map.set(userInput, value);"},effort:"15-20 minutes",riskLevel:"critical"},{pattern:"prototype",dangerous:true,vulnerability:"prototype-pollution",safeAlternative:"Avoid prototype manipulation",example:{bad:'obj[userInput] = value; // if userInput is "prototype"',good:"if (!obj.hasOwnProperty(userInput)) obj[userInput] = value;"},effort:"10-15 minutes",riskLevel:"high"},{pattern:"constructor",dangerous:true,vulnerability:"method-injection",safeAlternative:"Validate property names against whitelist",example:{bad:'obj[userInput] = value; // if userInput is "constructor"',good:"const ALLOWED_KEYS = ['name', 'age', 'email']; if (ALLOWED_KEYS.includes(userInput)) obj[userInput] = value;"},effort:"10-15 minutes",riskLevel:"medium"}];exports.detectObjectInjection=(0,eslint_devkit_3.createRule)({name:"detect-object-injection",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-secure-coding/docs/rules/detect-object-injection.md",description:"Detects variable[key] as a left- or right-hand assignment operand",cwe:"CWE-915",confidence:"low"},messages:{objectInjection:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.WARNING,issueName:"Object injection",cwe:"CWE-915",description:"Object injection/Prototype pollution (incl. model/tool outputs)",severity:"{{riskLevel}}",fix:"{{safeAlternative}}",documentationLink:"https://portswigger.net/web-security/prototype-pollution"}),useMapInstead:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Use Map",description:"Use Map instead of plain objects",severity:"LOW",fix:"const map = new Map(); map.set(key, value);",documentationLink:"https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Map"}),useHasOwnProperty:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Use hasOwnProperty",description:"Check hasOwnProperty to avoid prototype properties",severity:"LOW",fix:"if (obj.hasOwnProperty(key)) { obj[key] = value; }",documentationLink:"https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/hasOwnProperty"}),whitelistKeys:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Whitelist Keys",description:"Whitelist allowed property names",severity:"LOW",fix:'const ALLOWED = ["name", "email"]; if (ALLOWED.includes(key)) obj[key] = value; // reject model/tool-supplied unknown keys',documentationLink:"https://portswigger.net/web-security/prototype-pollution"}),useObjectCreate:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Use Object.create(null)",description:"Create clean objects without prototypes",severity:"LOW",fix:"const obj = Object.create(null);",documentationLink:"https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/create"}),freezePrototypes:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Freeze Prototypes",description:"Freeze Object.prototype to prevent pollution",severity:"LOW",fix:"Object.freeze(Object.prototype);",documentationLink:"https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/freeze"}),strategyValidate:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Validate Input",description:"Add input validation before property access",severity:"LOW",fix:"Validate key against allowed values before access",documentationLink:"https://portswigger.net/web-security/prototype-pollution"}),strategyWhitelist:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Whitelist Properties",description:"Whitelist allowed property names only",severity:"LOW",fix:"Define allowed keys and validate against them",documentationLink:"https://portswigger.net/web-security/prototype-pollution"}),strategyFreeze:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Freeze Prototypes",description:"Freeze prototypes to prevent pollution",severity:"LOW",fix:"Object.freeze(Object.prototype) at app startup",documentationLink:"https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/freeze"})},schema:[{type:"object",properties:{allowLiterals:{type:"boolean",default:false,description:"Allow bracket notation with literal strings"},additionalMethods:{type:"array",items:{type:"string"},default:[],description:"Additional object methods to check for injection"},dangerousProperties:{type:"array",items:{type:"string"},default:["__proto__","prototype","constructor"],description:"Properties to consider dangerous"},strategy:{type:"string",enum:["validate","whitelist","freeze","auto"],default:"auto",description:"Strategy for fixing object injection (auto = smart detection)"}},additionalProperties:false}]},defaultOptions:[{allowLiterals:false,additionalMethods:[],dangerousProperties:["__proto__","prototype","constructor"],strategy:"auto"}],create(context){const options=context.options[0]||{};const{allowLiterals:_allowLiterals=false,dangerousProperties=["__proto__","prototype","constructor"]}=options;const handledMemberExpressions=new WeakSet;const sourceCode=context.sourceCode;const isInCodemodContext=(()=>{const filename=context.filename;if(/\/codemod[s]?\//i.test(filename))return true;if(/codemod\.[mc]?[jt]sx?$/i.test(filename))return true;const imports=sourceCode.ast.body.filter(n=>n.type===eslint_devkit_1.AST_NODE_TYPES.ImportDeclaration);return imports.some(i=>{const src=String(i.source.value);return src==="@babel/types"||src==="@babel/traverse"||src==="recast"||src==="jscodeshift"||src==="eslint"||src==="estree-walker"||src==="ast-types"||src==="esrap"||src==="unist-util-visit"||src.startsWith("@typescript-eslint/")})})();const isTestFile=(()=>{const f=context.filename;return/\.test\.[mc]?[jt]sx?$/.test(f)||/\.spec\.[mc]?[jt]sx?$/.test(f)||/\/__tests__\//.test(f)||/\/test\//.test(f)||/\.fixture\.[mc]?[jt]sx?$/.test(f)})();const isLiteralString=node=>{return node.type===eslint_devkit_1.AST_NODE_TYPES.Literal&&typeof node.value==="string"};const hasPrecedingValidation=(propertyNode,node)=>{if(propertyNode.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier){return false}const keyName=propertyNode.name;const isIncludesCall=testNode=>{if(testNode.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression&&testNode.callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&testNode.callee.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&testNode.callee.property.name==="includes"&&testNode.arguments.length>0&&testNode.arguments[0].type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&testNode.arguments[0].name===keyName){return true}if(testNode.type===eslint_devkit_1.AST_NODE_TYPES.UnaryExpression&&testNode.operator==="!"&&testNode.argument.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression){return isIncludesCall(testNode.argument)}return false};const isHasOwnPropertyCall=testNode=>{if(testNode.type!==eslint_devkit_1.AST_NODE_TYPES.CallExpression)return false;const callee=testNode.callee;const args=testNode.arguments;if(callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&callee.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&callee.property.name==="call"&&args.length>=2&&args[1].type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&args[1].name===keyName){return true}if(callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&callee.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&(callee.property.name==="hasOwnProperty"||callee.property.name==="hasOwn")){const keyArg=callee.property.name==="hasOwn"?args[1]:args[0];if(keyArg?.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&keyArg.name===keyName){return true}}return false};const isInOperator=testNode=>{return testNode.type===eslint_devkit_1.AST_NODE_TYPES.BinaryExpression&&testNode.operator==="in"&&testNode.left.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&testNode.left.name===keyName};const hasValidation=testNode=>{return isIncludesCall(testNode)||isHasOwnPropertyCall(testNode)||isInOperator(testNode)};const hasEarlyExit=consequent=>{if(consequent.type===eslint_devkit_1.AST_NODE_TYPES.BlockStatement){return consequent.body.some(stmt=>stmt.type===eslint_devkit_1.AST_NODE_TYPES.ThrowStatement||stmt.type===eslint_devkit_1.AST_NODE_TYPES.ReturnStatement)}return consequent.type===eslint_devkit_1.AST_NODE_TYPES.ThrowStatement||consequent.type===eslint_devkit_1.AST_NODE_TYPES.ReturnStatement};let current=node.parent;let foundFunctionBody=false;while(current&&!foundFunctionBody){if(current.type===eslint_devkit_1.AST_NODE_TYPES.IfStatement){if(hasValidation(current.test)){return true}}if(current.type===eslint_devkit_1.AST_NODE_TYPES.BlockStatement&&current.parent&&(current.parent.type===eslint_devkit_1.AST_NODE_TYPES.FunctionDeclaration||current.parent.type===eslint_devkit_1.AST_NODE_TYPES.FunctionExpression||current.parent.type===eslint_devkit_1.AST_NODE_TYPES.ArrowFunctionExpression)){foundFunctionBody=true;const blockBody=current.body;const nodeIndex=blockBody.findIndex(stmt=>{let check=node;while(check){if(check===stmt)return true;check=check.parent}return false});for(let i=0;i<nodeIndex;i++){const stmt=blockBody[i];if(stmt.type===eslint_devkit_1.AST_NODE_TYPES.IfStatement&&hasValidation(stmt.test)&&hasEarlyExit(stmt.consequent)){return true}}}current=current.parent}return false};const isDangerousPropertyAccess=propertyNode=>{if(propertyNode.type===eslint_devkit_1.AST_NODE_TYPES.Identifier){const name=propertyNode.name;const numericIndexNames=new Set(["i","j","k","index","idx","n","len"]);if(numericIndexNames.has(name)){return false}}if(propertyNode.type===eslint_devkit_1.AST_NODE_TYPES.Identifier){const name=propertyNode.name;if(/^[A-Z][A-Z0-9_]{2,}$/.test(name)){return false}if(/^[a-z]/.test(name)&&/(?:Code|Status|Version|Kind|Mode|Type|Stage|Level|Phase|Step|Flag|Num|Count)$/.test(name)){return false}}if(isLiteralString(propertyNode)){const propName=String(propertyNode.value);if(dangerousProperties.includes(propName)){return true}return false}return true};const isPrototypelessObject=objectNode=>{if(objectNode.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier){return false}const varName=objectNode.name;let current=objectNode;while(current){if(current.type===eslint_devkit_1.AST_NODE_TYPES.BlockStatement||current.type===eslint_devkit_1.AST_NODE_TYPES.Program){const statements=current.type===eslint_devkit_1.AST_NODE_TYPES.BlockStatement?current.body:current.body;for(const stmt of statements){if(stmt.type===eslint_devkit_1.AST_NODE_TYPES.VariableDeclaration){for(const decl of stmt.declarations){if(decl.id.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&decl.id.name===varName&&decl.init){if(decl.init.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression&&decl.init.callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&decl.init.callee.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&decl.init.callee.object.name==="Object"&&decl.init.callee.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&decl.init.callee.property.name==="create"&&decl.init.arguments.length>0&&decl.init.arguments[0].type===eslint_devkit_1.AST_NODE_TYPES.Literal&&decl.init.arguments[0].value===null){return true}if(decl.init.type===eslint_devkit_1.AST_NODE_TYPES.ArrayExpression&&decl.init.elements.length>0&&decl.init.elements[0]?.type===eslint_devkit_1.AST_NODE_TYPES.SpreadElement){return true}}}}}}current=current.parent}return false};const extractPropertyAccess=node=>{let object;let property;let propertyNode;let isAssignment=false;if(node.type===eslint_devkit_1.AST_NODE_TYPES.AssignmentExpression&&node.left.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression){object=sourceCode.getText(node.left.object);property=sourceCode.getText(node.left.property);propertyNode=node.left.property;isAssignment=true}else{const memberNode=node;object=sourceCode.getText(memberNode.object);property=sourceCode.getText(memberNode.property);propertyNode=memberNode.property;isAssignment=false}const pattern=OBJECT_INJECTION_PATTERNS.find(p=>new RegExp(p.pattern,"i").test(property)||dangerousProperties.includes(property.replace(/['"]/g,"")))||null;return{object,property,propertyNode,isAssignment,pattern}};const isHighRiskAssignment=node=>{if(node.left.type!=="MemberExpression"){return false}if(!node.left.computed){return false}if(isPrototypelessObject(node.left.object)){return false}if(isTypedArrayObject(node.left.object)){return false}const{propertyNode}=extractPropertyAccess(node);if(isNumericKey(propertyNode)){return false}if(isForInOrObjectKeysKey(propertyNode)){return false}if(hasPrecedingValidation(propertyNode,node)){return false}return isDangerousPropertyAccess(propertyNode)};const isReflectResultAccess=objectNode=>{if(objectNode.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression){const callee=objectNode.callee;if(callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&callee.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&callee.object.name==="Reflect"){return true}}if(objectNode.type===eslint_devkit_1.AST_NODE_TYPES.ChainExpression){return isReflectResultAccess(objectNode.expression)}return false};const isHighRiskMemberAccess=node=>{if(!node.computed){return false}if(isReflectResultAccess(node.object)){return false}if(isTypedArrayObject(node.object)){return false}const{propertyNode}=extractPropertyAccess(node);if(isNumericKey(propertyNode)){return false}if(isForInOrObjectKeysKey(propertyNode)){return false}if(hasPrecedingValidation(propertyNode,node)){return false}return isDangerousPropertyAccess(propertyNode)};const isNumericKey=node=>{if(node.type===eslint_devkit_1.AST_NODE_TYPES.Literal&&typeof node.value==="number"){return true}if(node.type===eslint_devkit_1.AST_NODE_TYPES.UnaryExpression&&node.operator==="+"){return true}if(node.type===eslint_devkit_1.AST_NODE_TYPES.BinaryExpression){const op=node.operator;if(op==="|"||op==="&"||op==="^"||op==="<<"||op===">>"||op===">>>"||op==="*"||op==="/"||op==="%"||op==="-"){return true}}if(node.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression){const callee=node.callee;if(callee.type===eslint_devkit_1.AST_NODE_TYPES.Identifier){const name=callee.name;if(name==="Number"||name==="parseInt"||name==="parseFloat")return true}}if(node.type===eslint_devkit_1.AST_NODE_TYPES.Identifier){return isLoopCounterIdentifier(node)}return false};const isLoopCounterIdentifier=node=>{const scope=context.sourceCode.getScope(node);const variable=scope.references.find(r=>r.identifier===node)?.resolved;if(!variable||variable.defs.length===0)return false;const def=variable.defs[0];const parent=def.node?.parent;const grand=parent?.parent;if(parent?.type===eslint_devkit_1.AST_NODE_TYPES.VariableDeclaration&&grand?.type===eslint_devkit_1.AST_NODE_TYPES.ForStatement&&grand.init===parent){const init=def.node.init;if(!init)return false;if(init.type===eslint_devkit_1.AST_NODE_TYPES.Literal&&typeof init.value==="number"){return true}}return false};const isForInOrObjectKeysKey=node=>{if(node.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier)return false;const scope=context.sourceCode.getScope(node);const variable=scope.references.find(r=>r.identifier===node)?.resolved;if(!variable||variable.defs.length===0)return false;const def=variable.defs[0];const varDecl=def.node?.parent;const loopStmt=varDecl?.parent;if(!varDecl||varDecl.type!==eslint_devkit_1.AST_NODE_TYPES.VariableDeclaration)return false;if(loopStmt?.type===eslint_devkit_1.AST_NODE_TYPES.ForInStatement&&loopStmt.left===varDecl){return true}if(loopStmt?.type===eslint_devkit_1.AST_NODE_TYPES.ForOfStatement&&loopStmt.left===varDecl){const right=loopStmt.right;return right.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression&&right.callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&!right.callee.computed&&right.callee.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&right.callee.object.name==="Object"&&right.callee.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&(right.callee.property.name==="keys"||right.callee.property.name==="entries")}return false};const isTypedArrayObject=objectNode=>{if(objectNode.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier)return false;const varName=objectNode.name;let scope=context.sourceCode.getScope(objectNode);while(scope){const variable=scope.variables.find(v=>v.name===varName);if(variable){for(const def of variable.defs){const init=def.node.init;if(init?.type===eslint_devkit_1.AST_NODE_TYPES.NewExpression&&init.callee.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&TYPED_ARRAY_CTORS.has(init.callee.name)){return true}}break}if(!scope.upper)break;scope=scope.upper}return false};const determineRiskLevel=(pattern,isAssignment)=>{if(pattern?.riskLevel==="critical"||pattern&&isAssignment){return"CRITICAL"}if(pattern?.riskLevel==="high"||isAssignment){return"HIGH"}return"MEDIUM"};const checkAssignmentExpression=node=>{if(!isHighRiskAssignment(node)){return}let me=node.left;handledMemberExpressions.add(me);while(me.object.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&me.object.computed){me=me.object;handledMemberExpressions.add(me)}const{object,property,isAssignment,pattern}=extractPropertyAccess(node);const riskLevel=determineRiskLevel(pattern,isAssignment);context.report({node,messageId:"objectInjection",data:{pattern:`${object}[${property}]`,riskLevel,vulnerability:pattern?.vulnerability||"object injection",safeAlternative:pattern?.safeAlternative||"Use Map or property whitelisting"},suggest:[{messageId:"useMapInstead",fix:()=>null},{messageId:"useHasOwnProperty",fix:()=>null},{messageId:"whitelistKeys",fix:()=>null},{messageId:"useObjectCreate",fix:()=>null},{messageId:"freezePrototypes",fix:()=>null}]})};const checkMemberExpression=node=>{if(!isHighRiskMemberAccess(node)){return}if(handledMemberExpressions.has(node)){return}const parent=node.parent;if(parent?.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&parent.computed&&parent.object===node){return}if(parent&&parent.type===eslint_devkit_1.AST_NODE_TYPES.AssignmentExpression&&parent.left===node){return}const{object,property,isAssignment,pattern}=extractPropertyAccess(node);const riskLevel=determineRiskLevel(pattern,isAssignment);context.report({node,messageId:"objectInjection",data:{pattern:`${object}[${property}]`,riskLevel,vulnerability:pattern?.vulnerability||"object injection",safeAlternative:pattern?.safeAlternative||"Use Map or property whitelisting"}})};const checkObjectAssignSpread=node=>{if(node.callee.type!==eslint_devkit_1.AST_NODE_TYPES.MemberExpression)return;const callee=node.callee;const objectIsObject=callee.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&callee.object.name==="Object";const propIsAssign=!callee.computed&&callee.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&callee.property.name==="assign";if(!objectIsObject||!propIsAssign)return;if(node.arguments[0]?.type===eslint_devkit_1.AST_NODE_TYPES.ObjectExpression)return;const sources=node.arguments.slice(1);const anyTaintedSource=sources.some(s=>s.type!==eslint_devkit_1.AST_NODE_TYPES.ObjectExpression&&s.type!==eslint_devkit_1.AST_NODE_TYPES.Literal);if(!anyTaintedSource)return;context.report({node,messageId:"objectInjection",data:{pattern:"Object.assign(target, untrustedSource)",riskLevel:"HIGH",vulnerability:"object injection via Object.assign spread",safeAlternative:"Validate or whitelist keys before merging: `for (const k of Object.keys(src)) if (!ALLOWED.has(k)) continue;`"}})};return{AssignmentExpression:node=>{if(isInCodemodContext||isTestFile)return;return checkAssignmentExpression(node)},MemberExpression:node=>{if(isInCodemodContext||isTestFile)return;return checkMemberExpression(node)},CallExpression:node=>{if(isInCodemodContext||isTestFile)return;return checkObjectAssignSpread(node)}}}});
1
+ "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.detectObjectInjection=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const eslint_devkit_3=require("@interlace/eslint-devkit");const TYPED_ARRAY_CTORS=new Set(["Int8Array","Uint8Array","Uint8ClampedArray","Int16Array","Uint16Array","Int32Array","Uint32Array","Float32Array","Float64Array","BigInt64Array","BigUint64Array"]);const OBJECT_INJECTION_PATTERNS=[{pattern:"__proto__",dangerous:true,vulnerability:"prototype-pollution",safeAlternative:"Object.create(null) or Map",example:{bad:'obj[userInput] = value; // if userInput is "__proto__"',good:"const map = new Map(); map.set(userInput, value);"},effort:"15-20 minutes",riskLevel:"critical"},{pattern:"prototype",dangerous:true,vulnerability:"prototype-pollution",safeAlternative:"Avoid prototype manipulation",example:{bad:'obj[userInput] = value; // if userInput is "prototype"',good:"if (!obj.hasOwnProperty(userInput)) obj[userInput] = value;"},effort:"10-15 minutes",riskLevel:"high"},{pattern:"constructor",dangerous:true,vulnerability:"method-injection",safeAlternative:"Validate property names against whitelist",example:{bad:'obj[userInput] = value; // if userInput is "constructor"',good:"const ALLOWED_KEYS = ['name', 'age', 'email']; if (ALLOWED_KEYS.includes(userInput)) obj[userInput] = value;"},effort:"10-15 minutes",riskLevel:"medium"}];exports.detectObjectInjection=(0,eslint_devkit_3.createRule)({name:"detect-object-injection",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-secure-coding/docs/rules/detect-object-injection.md",description:"Detects variable[key] as a left- or right-hand assignment operand",cwe:"CWE-915",confidence:"low"},hasSuggestions:true,messages:{objectInjection:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.WARNING,issueName:"Object injection",cwe:"CWE-915",description:"Object injection/Prototype pollution (incl. model/tool outputs)",severity:"{{riskLevel}}",fix:"{{safeAlternative}}",documentationLink:"https://portswigger.net/web-security/prototype-pollution"}),useMapInstead:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Use Map",description:"Use Map instead of plain objects",severity:"LOW",fix:"const map = new Map(); map.set(key, value);",documentationLink:"https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Map"}),useHasOwnProperty:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Use hasOwnProperty",description:"Check hasOwnProperty to avoid prototype properties",severity:"LOW",fix:"if (obj.hasOwnProperty(key)) { obj[key] = value; }",documentationLink:"https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/hasOwnProperty"}),whitelistKeys:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Whitelist Keys",description:"Whitelist allowed property names",severity:"LOW",fix:'const ALLOWED = ["name", "email"]; if (ALLOWED.includes(key)) obj[key] = value; // reject model/tool-supplied unknown keys',documentationLink:"https://portswigger.net/web-security/prototype-pollution"}),useObjectCreate:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Use Object.create(null)",description:"Create clean objects without prototypes",severity:"LOW",fix:"const obj = Object.create(null);",documentationLink:"https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/create"}),freezePrototypes:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Freeze Prototypes",description:"Freeze Object.prototype to prevent pollution",severity:"LOW",fix:"Object.freeze(Object.prototype);",documentationLink:"https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/freeze"}),strategyValidate:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Validate Input",description:"Add input validation before property access",severity:"LOW",fix:"Validate key against allowed values before access",documentationLink:"https://portswigger.net/web-security/prototype-pollution"}),strategyWhitelist:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Whitelist Properties",description:"Whitelist allowed property names only",severity:"LOW",fix:"Define allowed keys and validate against them",documentationLink:"https://portswigger.net/web-security/prototype-pollution"}),strategyFreeze:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Freeze Prototypes",description:"Freeze prototypes to prevent pollution",severity:"LOW",fix:"Object.freeze(Object.prototype) at app startup",documentationLink:"https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/freeze"})},schema:[{type:"object",properties:{allowLiterals:{type:"boolean",default:false,description:"Allow bracket notation with literal strings"},additionalMethods:{type:"array",items:{type:"string"},default:[],description:"Additional object methods to check for injection"},dangerousProperties:{type:"array",items:{type:"string"},default:["__proto__","prototype","constructor"],description:"Properties to consider dangerous"},strategy:{type:"string",enum:["validate","whitelist","freeze","auto"],default:"auto",description:"Strategy for fixing object injection (auto = smart detection)"}},additionalProperties:false}]},defaultOptions:[{allowLiterals:false,additionalMethods:[],dangerousProperties:["__proto__","prototype","constructor"],strategy:"auto"}],create(context){const options=context.options[0]||{};const{allowLiterals:_allowLiterals=false,dangerousProperties=["__proto__","prototype","constructor"]}=options;const handledMemberExpressions=new WeakSet;const sourceCode=context.sourceCode;const isInCodemodContext=(()=>{const filename=context.filename;if(/\/codemod[s]?\//i.test(filename))return true;if(/codemod\.[mc]?[jt]sx?$/i.test(filename))return true;const imports=sourceCode.ast.body.filter(n=>n.type===eslint_devkit_1.AST_NODE_TYPES.ImportDeclaration);return imports.some(i=>{const src=String(i.source.value);return src==="@babel/types"||src==="@babel/traverse"||src==="recast"||src==="jscodeshift"||src==="eslint"||src==="estree-walker"||src==="ast-types"||src==="esrap"||src==="unist-util-visit"||src.startsWith("@typescript-eslint/")})})();const isTestFile=(()=>{const f=context.filename;return/\.test\.[mc]?[jt]sx?$/.test(f)||/\.spec\.[mc]?[jt]sx?$/.test(f)||/\/__tests__\//.test(f)||/\/test\//.test(f)||/\.fixture\.[mc]?[jt]sx?$/.test(f)})();const isLiteralString=node=>{return node.type===eslint_devkit_1.AST_NODE_TYPES.Literal&&typeof node.value==="string"};const hasPrecedingValidation=(propertyNode,node)=>{if(propertyNode.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier){return false}const keyName=propertyNode.name;const isIncludesCall=testNode=>{if(testNode.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression&&testNode.callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&testNode.callee.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&testNode.callee.property.name==="includes"&&testNode.arguments.length>0&&testNode.arguments[0].type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&testNode.arguments[0].name===keyName){return true}if(testNode.type===eslint_devkit_1.AST_NODE_TYPES.UnaryExpression&&testNode.operator==="!"&&testNode.argument.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression){return isIncludesCall(testNode.argument)}return false};const isHasOwnPropertyCall=testNode=>{if(testNode.type!==eslint_devkit_1.AST_NODE_TYPES.CallExpression)return false;const callee=testNode.callee;const args=testNode.arguments;if(callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&callee.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&callee.property.name==="call"&&args.length>=2&&args[1].type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&args[1].name===keyName){return true}if(callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&callee.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&(callee.property.name==="hasOwnProperty"||callee.property.name==="hasOwn")){const keyArg=callee.property.name==="hasOwn"?args[1]:args[0];if(keyArg?.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&keyArg.name===keyName){return true}}return false};const isInOperator=testNode=>{return testNode.type===eslint_devkit_1.AST_NODE_TYPES.BinaryExpression&&testNode.operator==="in"&&testNode.left.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&testNode.left.name===keyName};const hasValidation=testNode=>{return isIncludesCall(testNode)||isHasOwnPropertyCall(testNode)||isInOperator(testNode)};const hasEarlyExit=consequent=>{if(consequent.type===eslint_devkit_1.AST_NODE_TYPES.BlockStatement){return consequent.body.some(stmt=>stmt.type===eslint_devkit_1.AST_NODE_TYPES.ThrowStatement||stmt.type===eslint_devkit_1.AST_NODE_TYPES.ReturnStatement)}return consequent.type===eslint_devkit_1.AST_NODE_TYPES.ThrowStatement||consequent.type===eslint_devkit_1.AST_NODE_TYPES.ReturnStatement};let current=node.parent;let foundFunctionBody=false;while(current&&!foundFunctionBody){if(current.type===eslint_devkit_1.AST_NODE_TYPES.IfStatement){if(hasValidation(current.test)){return true}}if(current.type===eslint_devkit_1.AST_NODE_TYPES.BlockStatement&&current.parent&&(current.parent.type===eslint_devkit_1.AST_NODE_TYPES.FunctionDeclaration||current.parent.type===eslint_devkit_1.AST_NODE_TYPES.FunctionExpression||current.parent.type===eslint_devkit_1.AST_NODE_TYPES.ArrowFunctionExpression)){foundFunctionBody=true;const blockBody=current.body;const nodeIndex=blockBody.findIndex(stmt=>{let check=node;while(check){if(check===stmt)return true;check=check.parent}return false});for(let i=0;i<nodeIndex;i++){const stmt=blockBody[i];if(stmt.type===eslint_devkit_1.AST_NODE_TYPES.IfStatement&&hasValidation(stmt.test)&&hasEarlyExit(stmt.consequent)){return true}}}current=current.parent}return false};const hasDisqualifyingLiteralAffix=node=>{if(node.type!==eslint_devkit_1.AST_NODE_TYPES.BinaryExpression||node.operator!=="+"){return false}const bin=node;const literalText=n=>{if(n.type!==eslint_devkit_1.AST_NODE_TYPES.Literal)return null;const v=n.value;if(typeof v!=="string"&&typeof v!=="number")return null;const s=String(v);return s.length>0?s:null};const prefix=literalText(bin.left);if(prefix!==null&&!dangerousProperties.some(d=>d.startsWith(prefix))){return true}const suffix=literalText(bin.right);if(suffix!==null&&!dangerousProperties.some(d=>d.endsWith(suffix))){return true}return false};const isDangerousPropertyAccess=propertyNode=>{if(isNumericKey(propertyNode)||hasDisqualifyingLiteralAffix(propertyNode)){return false}if(propertyNode.type===eslint_devkit_1.AST_NODE_TYPES.Identifier){const name=propertyNode.name;if(/^[A-Z][A-Z0-9_]{2,}$/.test(name)){return false}if(/^[a-z]/.test(name)&&/(?:Code|Status|Version|Kind|Mode|Type|Stage|Level|Phase|Step|Flag|Num|Count)$/.test(name)){return false}}if(isLiteralString(propertyNode)){const propName=String(propertyNode.value);if(dangerousProperties.includes(propName)){return true}return false}return true};const isPrototypelessObject=objectNode=>{if(objectNode.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier){return false}const varName=objectNode.name;let current=objectNode;while(current){if(current.type===eslint_devkit_1.AST_NODE_TYPES.BlockStatement||current.type===eslint_devkit_1.AST_NODE_TYPES.Program){const statements=current.type===eslint_devkit_1.AST_NODE_TYPES.BlockStatement?current.body:current.body;for(const stmt of statements){if(stmt.type===eslint_devkit_1.AST_NODE_TYPES.VariableDeclaration){for(const decl of stmt.declarations){if(decl.id.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&decl.id.name===varName&&decl.init){if(decl.init.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression&&decl.init.callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&decl.init.callee.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&decl.init.callee.object.name==="Object"&&decl.init.callee.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&decl.init.callee.property.name==="create"&&decl.init.arguments.length>0&&decl.init.arguments[0].type===eslint_devkit_1.AST_NODE_TYPES.Literal&&decl.init.arguments[0].value===null){return true}if(decl.init.type===eslint_devkit_1.AST_NODE_TYPES.ArrayExpression&&decl.init.elements.length>0&&decl.init.elements[0]?.type===eslint_devkit_1.AST_NODE_TYPES.SpreadElement){return true}}}}}}current=current.parent}return false};const extractPropertyAccess=node=>{let object;let property;let propertyNode;let isAssignment=false;if(node.type===eslint_devkit_1.AST_NODE_TYPES.AssignmentExpression&&node.left.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression){object=sourceCode.getText(node.left.object);property=sourceCode.getText(node.left.property);propertyNode=node.left.property;isAssignment=true}else{const memberNode=node;object=sourceCode.getText(memberNode.object);property=sourceCode.getText(memberNode.property);propertyNode=memberNode.property;isAssignment=false}const pattern=OBJECT_INJECTION_PATTERNS.find(p=>new RegExp(p.pattern,"i").test(property)||dangerousProperties.includes(property.replace(/['"]/g,"")))||null;return{object,property,propertyNode,isAssignment,pattern}};const isHighRiskAssignment=node=>{if(node.left.type!=="MemberExpression"){return false}if(!node.left.computed){return false}if(isPrototypelessObject(node.left.object)){return false}if(isTypedArrayObject(node.left.object)){return false}const{propertyNode}=extractPropertyAccess(node);if(isNumericKey(propertyNode)){return false}if(isForInOrObjectKeysKey(propertyNode)){return false}if(hasPrecedingValidation(propertyNode,node)){return false}return isDangerousPropertyAccess(propertyNode)};const isReflectResultAccess=objectNode=>{if(objectNode.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression){const callee=objectNode.callee;if(callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&callee.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&callee.object.name==="Reflect"){return true}}if(objectNode.type===eslint_devkit_1.AST_NODE_TYPES.ChainExpression){return isReflectResultAccess(objectNode.expression)}return false};const isHighRiskMemberAccess=node=>{if(!node.computed){return false}if(isReflectResultAccess(node.object)){return false}if(isTypedArrayObject(node.object)){return false}const{propertyNode}=extractPropertyAccess(node);if(isNumericKey(propertyNode)){return false}if(isForInOrObjectKeysKey(propertyNode)){return false}if(hasPrecedingValidation(propertyNode,node)){return false}return isDangerousPropertyAccess(propertyNode)};const isNumericKey=node=>{if(node.type===eslint_devkit_1.AST_NODE_TYPES.Literal&&typeof node.value==="number"){return true}if(node.type===eslint_devkit_1.AST_NODE_TYPES.UnaryExpression){const op=node.operator;if(op==="+"||op==="-"||op==="~")return true}if(node.type===eslint_devkit_1.AST_NODE_TYPES.UpdateExpression){return true}if(node.type===eslint_devkit_1.AST_NODE_TYPES.BinaryExpression){const op=node.operator;if(op==="|"||op==="&"||op==="^"||op==="<<"||op===">>"||op===">>>"||op==="*"||op==="/"||op==="%"||op==="-"||op==="**"){return true}if(op==="+"){const bin=node;return isNumericKey(bin.left)&&isNumericKey(bin.right)}}if(node.type===eslint_devkit_1.AST_NODE_TYPES.ConditionalExpression){const cond=node;return isNumericKey(cond.consequent)&&isNumericKey(cond.alternate)}if(node.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression){const callee=node.callee;if(callee.type===eslint_devkit_1.AST_NODE_TYPES.Identifier){const name=callee.name;if(name==="Number"||name==="parseInt"||name==="parseFloat")return true}if(callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&callee.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&callee.object.name==="Math"&&callee.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier){return true}}if(node.type===eslint_devkit_1.AST_NODE_TYPES.Identifier){return isNumericIdentifier(node)}return false};const numericVarCache=new WeakMap;const numericVarInProgress=new WeakSet;const isNumericIdentifier=node=>{if(isLoopCounterIdentifier(node))return true;const scope=context.sourceCode.getScope(node);const variable=scope.references.find(r=>r.identifier===node)?.resolved;if(!variable||variable.defs.length===0)return false;const cached=numericVarCache.get(variable);if(cached!==void 0)return cached;if(numericVarInProgress.has(variable))return true;numericVarInProgress.add(variable);let result=false;const def=variable.defs[0];const declarator=def.node;if(declarator?.type===eslint_devkit_1.AST_NODE_TYPES.VariableDeclarator&&declarator.init&&declarator.parent?.type===eslint_devkit_1.AST_NODE_TYPES.VariableDeclaration){result=isNumericKey(declarator.init);if(result){for(const ref of variable.references){const written=ref.writeExpr;if(!written||written===declarator.init)continue;if(!isNumericKey(written)){result=false;break}}}}numericVarInProgress.delete(variable);numericVarCache.set(variable,result);return result};const isLoopCounterIdentifier=node=>{const scope=context.sourceCode.getScope(node);const variable=scope.references.find(r=>r.identifier===node)?.resolved;if(!variable||variable.defs.length===0)return false;const def=variable.defs[0];const parent=def.node?.parent;const grand=parent?.parent;if(parent?.type===eslint_devkit_1.AST_NODE_TYPES.VariableDeclaration&&grand?.type===eslint_devkit_1.AST_NODE_TYPES.ForStatement&&grand.init===parent){const init=def.node.init;if(!init)return false;if(init.type===eslint_devkit_1.AST_NODE_TYPES.Literal&&typeof init.value==="number"){return true}}return false};const isForInOrObjectKeysKey=node=>{if(node.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier)return false;const scope=context.sourceCode.getScope(node);const variable=scope.references.find(r=>r.identifier===node)?.resolved;if(!variable||variable.defs.length===0)return false;const def=variable.defs[0];const varDecl=def.node?.parent;const loopStmt=varDecl?.parent;if(!varDecl||varDecl.type!==eslint_devkit_1.AST_NODE_TYPES.VariableDeclaration)return false;if(loopStmt?.type===eslint_devkit_1.AST_NODE_TYPES.ForInStatement&&loopStmt.left===varDecl){return true}if(loopStmt?.type===eslint_devkit_1.AST_NODE_TYPES.ForOfStatement&&loopStmt.left===varDecl){const right=loopStmt.right;return right.type===eslint_devkit_1.AST_NODE_TYPES.CallExpression&&right.callee.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&!right.callee.computed&&right.callee.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&right.callee.object.name==="Object"&&right.callee.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&(right.callee.property.name==="keys"||right.callee.property.name==="entries")}return false};const isTypedArrayObject=objectNode=>{if(objectNode.type!==eslint_devkit_1.AST_NODE_TYPES.Identifier)return false;const varName=objectNode.name;let scope=context.sourceCode.getScope(objectNode);while(scope){const variable=scope.variables.find(v=>v.name===varName);if(variable){for(const def of variable.defs){const init=def.node.init;if(init?.type===eslint_devkit_1.AST_NODE_TYPES.NewExpression&&init.callee.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&TYPED_ARRAY_CTORS.has(init.callee.name)){return true}}break}if(!scope.upper)break;scope=scope.upper}return false};const determineRiskLevel=(pattern,isAssignment)=>{if(pattern?.riskLevel==="critical"||pattern&&isAssignment){return"CRITICAL"}if(pattern?.riskLevel==="high"||isAssignment){return"HIGH"}return"MEDIUM"};const checkAssignmentExpression=node=>{if(!isHighRiskAssignment(node)){return}let me=node.left;handledMemberExpressions.add(me);while(me.object.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&me.object.computed){me=me.object;handledMemberExpressions.add(me)}const{object,property,isAssignment,pattern}=extractPropertyAccess(node);const riskLevel=determineRiskLevel(pattern,isAssignment);context.report({node,messageId:"objectInjection",data:{pattern:`${object}[${property}]`,riskLevel,vulnerability:pattern?.vulnerability||"object injection",safeAlternative:pattern?.safeAlternative||"Use Map or property whitelisting"},suggest:[{messageId:"useMapInstead",fix:()=>null},{messageId:"useHasOwnProperty",fix:()=>null},{messageId:"whitelistKeys",fix:()=>null},{messageId:"useObjectCreate",fix:()=>null},{messageId:"freezePrototypes",fix:()=>null}]})};const checkMemberExpression=node=>{if(!isHighRiskMemberAccess(node)){return}if(handledMemberExpressions.has(node)){return}const parent=node.parent;if(parent?.type===eslint_devkit_1.AST_NODE_TYPES.MemberExpression&&parent.computed&&parent.object===node){return}if(parent&&parent.type===eslint_devkit_1.AST_NODE_TYPES.AssignmentExpression&&parent.left===node){return}const{object,property,isAssignment,pattern}=extractPropertyAccess(node);const riskLevel=determineRiskLevel(pattern,isAssignment);context.report({node,messageId:"objectInjection",data:{pattern:`${object}[${property}]`,riskLevel,vulnerability:pattern?.vulnerability||"object injection",safeAlternative:pattern?.safeAlternative||"Use Map or property whitelisting"}})};const checkObjectAssignSpread=node=>{if(node.callee.type!==eslint_devkit_1.AST_NODE_TYPES.MemberExpression)return;const callee=node.callee;const objectIsObject=callee.object.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&callee.object.name==="Object";const propIsAssign=!callee.computed&&callee.property.type===eslint_devkit_1.AST_NODE_TYPES.Identifier&&callee.property.name==="assign";if(!objectIsObject||!propIsAssign)return;if(node.arguments[0]?.type===eslint_devkit_1.AST_NODE_TYPES.ObjectExpression)return;const sources=node.arguments.slice(1);const anyTaintedSource=sources.some(s=>s.type!==eslint_devkit_1.AST_NODE_TYPES.ObjectExpression&&s.type!==eslint_devkit_1.AST_NODE_TYPES.Literal);if(!anyTaintedSource)return;context.report({node,messageId:"objectInjection",data:{pattern:"Object.assign(target, untrustedSource)",riskLevel:"HIGH",vulnerability:"object injection via Object.assign spread",safeAlternative:"Validate or whitelist keys before merging: `for (const k of Object.keys(src)) if (!ALLOWED.has(k)) continue;`"}})};return{AssignmentExpression:node=>{if(isInCodemodContext||isTestFile)return;return checkAssignmentExpression(node)},MemberExpression:node=>{if(isInCodemodContext||isTestFile)return;return checkMemberExpression(node)},CallExpression:node=>{if(isInCodemodContext||isTestFile)return;return checkObjectAssignSpread(node)}}}});
@@ -1 +1 @@
1
- "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noDirectiveInjection=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const eslint_devkit_3=require("@interlace/eslint-devkit");exports.noDirectiveInjection=(0,eslint_devkit_1.createRule)({name:"no-directive-injection",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-secure-coding/docs/rules/no-directive-injection.md",description:"Detects directive injection vulnerabilities in templates",cwe:"CWE-96"},hasSuggestions:true,messages:{directiveInjection:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Directive Injection",cwe:"CWE-96",description:"User input injected into directive or template",severity:"{{severity}}",fix:"{{safeAlternative}}",documentationLink:"https://cwe.mitre.org/data/definitions/96.html"}),unsafeDirectiveName:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Unsafe Directive Name",cwe:"CWE-96",description:"Directive name controlled by user input",severity:"CRITICAL",fix:"Use hardcoded directive names or validate against whitelist",documentationLink:"https://cwe.mitre.org/data/definitions/96.html"}),dynamicDirectiveCreation:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Dynamic Directive Creation",cwe:"CWE-96",description:"Dynamic creation of directives from user input",severity:"HIGH",fix:"Validate directive names against trusted list",documentationLink:"https://cwe.mitre.org/data/definitions/96.html"}),templateInjection:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Template Injection",cwe:"CWE-96",description:"User input injected into template content",severity:"HIGH",fix:"Sanitize template input or use safe rendering",documentationLink:"https://cwe.mitre.org/data/definitions/96.html"}),unsafeComponentBinding:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Unsafe Component Binding",cwe:"CWE-96",description:"Dynamic component binding with user input",severity:"HIGH",fix:"Use component whitelist or validate component names",documentationLink:"https://cwe.mitre.org/data/definitions/96.html"}),userControlledTemplate:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"User Controlled Template",cwe:"CWE-96",description:"Template content controlled by user input",severity:"CRITICAL",fix:"Sanitize template input before compilation",documentationLink:"https://cwe.mitre.org/data/definitions/96.html"}),dangerousInnerHTML:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Dangerous innerHTML",cwe:"CWE-96",description:"innerHTML set with user-controlled content",severity:"HIGH",fix:"Use textContent or sanitize HTML content",documentationLink:"https://developer.mozilla.org/en-US/docs/Web/API/Element/innerHTML"}),untrustedDirectiveSource:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Untrusted Directive Source",cwe:"CWE-96",description:"Directive loaded from untrusted source",severity:"MEDIUM",fix:"Load directives from trusted, verified sources",documentationLink:"https://cwe.mitre.org/data/definitions/96.html"}),useTrustedDirectives:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Use Trusted Directives",description:"Use only trusted, verified directives",severity:"LOW",fix:"Maintain whitelist of allowed directives",documentationLink:"https://cwe.mitre.org/data/definitions/96.html"}),sanitizeTemplateInput:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Sanitize Template Input",description:"Sanitize user input before template processing",severity:"LOW",fix:"Use DOMPurify or equivalent sanitization",documentationLink:"https://github.com/cure53/DOMPurify"}),validateDirectiveNames:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Validate Directive Names",description:"Validate directive names against whitelist",severity:"LOW",fix:"Check directive names before dynamic creation",documentationLink:"https://cwe.mitre.org/data/definitions/96.html"}),strategyTemplateSanitization:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Template Sanitization Strategy",description:"Implement template input sanitization",severity:"LOW",fix:"Sanitize all user input before template processing",documentationLink:"https://owasp.org/www-community/xss-filter-evasion-cheatsheet"}),strategyContentSecurity:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Content Security Strategy",description:"Use CSP to restrict directive execution",severity:"LOW",fix:"Implement strict CSP with script-src restrictions",documentationLink:"https://developer.mozilla.org/en-US/docs/Web/HTTP/CSP"}),strategyInputValidation:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Input Validation Strategy",description:"Validate all template inputs",severity:"LOW",fix:"Use schema validation for template inputs",documentationLink:"https://joi.dev/"})},schema:[{type:"object",properties:{trustedDirectives:{type:"array",items:{type:"string"},default:["ngIf","ngFor","ngClass","v-if","v-for","v-bind","v-on"],description:"Template directives treated as safe"},userInputVariables:{type:"array",items:{type:"string"},default:["req","request","body","query","params","input","data","userInput"],description:"Variable names treated as user-controlled input"},frameworks:{type:"array",items:{type:"string"},default:["angular","vue","react","svelte"],description:"Template frameworks to analyse"},allowDynamicInComponents:{type:"boolean",default:false,description:"Allow dynamic directives inside component code"},trustedSanitizers:{type:"array",items:{type:"string"},default:[],description:"Additional function names to consider as template sanitizers"},trustedAnnotations:{type:"array",items:{type:"string"},default:[],description:"Additional JSDoc annotations to consider as safe markers"},strictMode:{type:"boolean",default:false,description:"Disable all false positive detection (strict mode)"}},additionalProperties:false}]},defaultOptions:[{trustedDirectives:["ngIf","ngFor","ngClass","v-if","v-for","v-bind","v-on"],userInputVariables:["req","request","body","query","params","input","data","userInput"],frameworks:["angular","vue","react","svelte"],allowDynamicInComponents:false,trustedSanitizers:[],trustedAnnotations:[],strictMode:false}],create(context){const options=context.options[0]||{};const{userInputVariables=["req","request","body","query","params","input","data","userInput"],trustedSanitizers=[],trustedAnnotations=[],strictMode=false}=options;const sourceCode=context.sourceCode;const filename=context.filename;const safetyChecker=(0,eslint_devkit_3.createSafetyChecker)({trustedSanitizers,trustedAnnotations,trustedOrmPatterns:[],strictMode});const isUserInput=varName=>{return userInputVariables.some(input=>varName.includes(input))||varName.startsWith("user")};return{JSXAttribute(node){const attrName=node.name;const attrValue=node.value;if(attrName.type==="JSXIdentifier"&&attrName.name==="dangerouslySetInnerHTML"){if(attrValue&&attrValue.type==="JSXExpressionContainer"){const expression=attrValue.expression;const expressionText=sourceCode.getText(expression);if(userInputVariables.some(input=>expressionText.includes(input))){if(safetyChecker.isSafe(node,context)){return}context.report({node:attrValue,messageId:"dangerousInnerHTML",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}}const isNamespaceDirective=attrName.type==="JSXNamespacedName"&&(attrName.namespace.name==="v"||attrName.namespace.name==="ng")||attrName.type==="JSXIdentifier"&&(attrName.name.startsWith("ng:")||attrName.name.startsWith("v:"));if(isNamespaceDirective&&attrValue){if(attrValue.type==="JSXExpressionContainer"){const expression=attrValue.expression;if(expression.type==="Identifier"&&isUserInput(expression.name)){if(safetyChecker.isSafe(node,context)){return}context.report({node:attrValue,messageId:"directiveInjection",data:{filePath:filename,line:String(node.loc?.start.line??0),severity:"HIGH",safeAlternative:"Use hardcoded directive values or validate user input"}})}}}if(attrName.type==="JSXIdentifier"){const attrNameStr=attrName.name;if(attrNameStr==="is"&&attrValue){if(attrValue.type==="JSXExpressionContainer"){const expression=attrValue.expression;if(expression.type==="Identifier"&&isUserInput(expression.name)){if(safetyChecker.isSafe(node,context)){return}context.report({node:attrValue,messageId:"unsafeComponentBinding",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}}}},AssignmentExpression(node){const left=node.left;const right=node.right;if(left.type==="MemberExpression"&&left.property.type==="Identifier"&&left.property.name==="innerHTML"){const rightText=sourceCode.getText(right);if(userInputVariables.some(input=>rightText.includes(input))){if(safetyChecker.isSafe(node,context)){return}context.report({node:right,messageId:"dangerousInnerHTML",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}},CallExpression(node){const callee=node.callee;if(callee.type==="MemberExpression"&&callee.property.type==="Identifier"){const methodName=callee.property.name;const objectName=callee.object.type==="Identifier"?callee.object.name:"";if(["compile","template","$compile","$interpolate"].includes(methodName)||objectName==="Handlebars"&&methodName==="compile"||objectName==="_"&&methodName==="template"||objectName==="ejs"&&methodName==="render"||objectName==="pug"&&methodName==="render"||objectName==="mustache"&&methodName==="render"){const args=node.arguments;if(args.length>0){const templateArg=args[0];if(templateArg.type==="Identifier"&&isUserInput(templateArg.name)){if(safetyChecker.isSafe(node,context)){return}context.report({node:templateArg,messageId:"userControlledTemplate",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}}if(objectName==="Vue"&&methodName==="directive"){const args=node.arguments;if(args.length>=2){const directiveName=args[0];if(directiveName.type==="Identifier"&&isUserInput(directiveName.name)){if(safetyChecker.isSafe(node,context)){return}context.report({node:directiveName,messageId:"unsafeDirectiveName",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}}}if(callee.type==="Identifier"&&callee.name==="directive"){const args=node.arguments;if(args.length>=2){const directiveName=args[0];if(directiveName.type==="Identifier"&&isUserInput(directiveName.name)){if(safetyChecker.isSafe(node,context)){return}context.report({node:directiveName,messageId:"dynamicDirectiveCreation",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}}},TemplateLiteral(node){let current=node;let isInDangerousContext=false;while(current){if(current.type==="JSXExpressionContainer"){if(current.parent?.type==="JSXAttribute"&&current.parent.name.type==="JSXIdentifier"&&current.parent.name.name==="dangerouslySetInnerHTML"){isInDangerousContext=true;break}}else if(current.type==="AssignmentExpression"){const left=current.left;if(left.type==="MemberExpression"&&left.property.type==="Identifier"&&left.property.name==="innerHTML"){isInDangerousContext=true;break}}current=current.parent}if(isInDangerousContext){const hasUserInput=node.expressions.some(expr=>expr.type==="Identifier"&&isUserInput(expr.name)||expr.type==="MemberExpression"&&expr.object.type==="Identifier"&&isUserInput(expr.object.name));if(hasUserInput){if(safetyChecker.isSafe(node,context)){return}context.report({node,messageId:"templateInjection",data:{filePath:filename,line:String(node.loc?.start.line??0),severity:"HIGH",safeAlternative:"Sanitize template input before insertion"}})}}}}}});
1
+ "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noDirectiveInjection=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const eslint_devkit_3=require("@interlace/eslint-devkit");exports.noDirectiveInjection=(0,eslint_devkit_1.createRule)({name:"no-directive-injection",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-secure-coding/docs/rules/no-directive-injection.md",description:"Detects directive injection vulnerabilities in templates",cwe:"CWE-96"},messages:{directiveInjection:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Directive Injection",cwe:"CWE-96",description:"User input injected into directive or template",severity:"{{severity}}",fix:"{{safeAlternative}}",documentationLink:"https://cwe.mitre.org/data/definitions/96.html"}),unsafeDirectiveName:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Unsafe Directive Name",cwe:"CWE-96",description:"Directive name controlled by user input",severity:"CRITICAL",fix:"Use hardcoded directive names or validate against whitelist",documentationLink:"https://cwe.mitre.org/data/definitions/96.html"}),dynamicDirectiveCreation:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Dynamic Directive Creation",cwe:"CWE-96",description:"Dynamic creation of directives from user input",severity:"HIGH",fix:"Validate directive names against trusted list",documentationLink:"https://cwe.mitre.org/data/definitions/96.html"}),templateInjection:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Template Injection",cwe:"CWE-96",description:"User input injected into template content",severity:"HIGH",fix:"Sanitize template input or use safe rendering",documentationLink:"https://cwe.mitre.org/data/definitions/96.html"}),unsafeComponentBinding:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Unsafe Component Binding",cwe:"CWE-96",description:"Dynamic component binding with user input",severity:"HIGH",fix:"Use component whitelist or validate component names",documentationLink:"https://cwe.mitre.org/data/definitions/96.html"}),userControlledTemplate:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"User Controlled Template",cwe:"CWE-96",description:"Template content controlled by user input",severity:"CRITICAL",fix:"Sanitize template input before compilation",documentationLink:"https://cwe.mitre.org/data/definitions/96.html"}),dangerousInnerHTML:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Dangerous innerHTML",cwe:"CWE-96",description:"innerHTML set with user-controlled content",severity:"HIGH",fix:"Use textContent or sanitize HTML content",documentationLink:"https://developer.mozilla.org/en-US/docs/Web/API/Element/innerHTML"}),untrustedDirectiveSource:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Untrusted Directive Source",cwe:"CWE-96",description:"Directive loaded from untrusted source",severity:"MEDIUM",fix:"Load directives from trusted, verified sources",documentationLink:"https://cwe.mitre.org/data/definitions/96.html"}),useTrustedDirectives:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Use Trusted Directives",description:"Use only trusted, verified directives",severity:"LOW",fix:"Maintain whitelist of allowed directives",documentationLink:"https://cwe.mitre.org/data/definitions/96.html"}),sanitizeTemplateInput:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Sanitize Template Input",description:"Sanitize user input before template processing",severity:"LOW",fix:"Use DOMPurify or equivalent sanitization",documentationLink:"https://github.com/cure53/DOMPurify"}),validateDirectiveNames:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Validate Directive Names",description:"Validate directive names against whitelist",severity:"LOW",fix:"Check directive names before dynamic creation",documentationLink:"https://cwe.mitre.org/data/definitions/96.html"}),strategyTemplateSanitization:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Template Sanitization Strategy",description:"Implement template input sanitization",severity:"LOW",fix:"Sanitize all user input before template processing",documentationLink:"https://owasp.org/www-community/xss-filter-evasion-cheatsheet"}),strategyContentSecurity:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Content Security Strategy",description:"Use CSP to restrict directive execution",severity:"LOW",fix:"Implement strict CSP with script-src restrictions",documentationLink:"https://developer.mozilla.org/en-US/docs/Web/HTTP/CSP"}),strategyInputValidation:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Input Validation Strategy",description:"Validate all template inputs",severity:"LOW",fix:"Use schema validation for template inputs",documentationLink:"https://joi.dev/"})},schema:[{type:"object",properties:{trustedDirectives:{type:"array",items:{type:"string"},default:["ngIf","ngFor","ngClass","v-if","v-for","v-bind","v-on"],description:"Template directives treated as safe"},userInputVariables:{type:"array",items:{type:"string"},default:["req","request","body","query","params","input","data","userInput"],description:"Variable names treated as user-controlled input"},frameworks:{type:"array",items:{type:"string"},default:["angular","vue","react","svelte"],description:"Template frameworks to analyse"},allowDynamicInComponents:{type:"boolean",default:false,description:"Allow dynamic directives inside component code"},trustedSanitizers:{type:"array",items:{type:"string"},default:[],description:"Additional function names to consider as template sanitizers"},trustedAnnotations:{type:"array",items:{type:"string"},default:[],description:"Additional JSDoc annotations to consider as safe markers"},strictMode:{type:"boolean",default:false,description:"Disable all false positive detection (strict mode)"}},additionalProperties:false}]},defaultOptions:[{trustedDirectives:["ngIf","ngFor","ngClass","v-if","v-for","v-bind","v-on"],userInputVariables:["req","request","body","query","params","input","data","userInput"],frameworks:["angular","vue","react","svelte"],allowDynamicInComponents:false,trustedSanitizers:[],trustedAnnotations:[],strictMode:false}],create(context){const options=context.options[0]||{};const{userInputVariables=["req","request","body","query","params","input","data","userInput"],trustedSanitizers=[],trustedAnnotations=[],strictMode=false}=options;const sourceCode=context.sourceCode;const filename=context.filename;const safetyChecker=(0,eslint_devkit_3.createSafetyChecker)({trustedSanitizers,trustedAnnotations,trustedOrmPatterns:[],strictMode});const isUserInput=varName=>{return userInputVariables.some(input=>varName.includes(input))||varName.startsWith("user")};return{JSXAttribute(node){const attrName=node.name;const attrValue=node.value;if(attrName.type==="JSXIdentifier"&&attrName.name==="dangerouslySetInnerHTML"){if(attrValue&&attrValue.type==="JSXExpressionContainer"){const expression=attrValue.expression;const expressionText=sourceCode.getText(expression);if(userInputVariables.some(input=>expressionText.includes(input))){if(safetyChecker.isSafe(node,context)){return}context.report({node:attrValue,messageId:"dangerousInnerHTML",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}}const isNamespaceDirective=attrName.type==="JSXNamespacedName"&&(attrName.namespace.name==="v"||attrName.namespace.name==="ng")||attrName.type==="JSXIdentifier"&&(attrName.name.startsWith("ng:")||attrName.name.startsWith("v:"));if(isNamespaceDirective&&attrValue){if(attrValue.type==="JSXExpressionContainer"){const expression=attrValue.expression;if(expression.type==="Identifier"&&isUserInput(expression.name)){if(safetyChecker.isSafe(node,context)){return}context.report({node:attrValue,messageId:"directiveInjection",data:{filePath:filename,line:String(node.loc?.start.line??0),severity:"HIGH",safeAlternative:"Use hardcoded directive values or validate user input"}})}}}if(attrName.type==="JSXIdentifier"){const attrNameStr=attrName.name;if(attrNameStr==="is"&&attrValue){if(attrValue.type==="JSXExpressionContainer"){const expression=attrValue.expression;if(expression.type==="Identifier"&&isUserInput(expression.name)){if(safetyChecker.isSafe(node,context)){return}context.report({node:attrValue,messageId:"unsafeComponentBinding",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}}}},AssignmentExpression(node){const left=node.left;const right=node.right;if(left.type==="MemberExpression"&&left.property.type==="Identifier"&&left.property.name==="innerHTML"){const rightText=sourceCode.getText(right);if(userInputVariables.some(input=>rightText.includes(input))){if(safetyChecker.isSafe(node,context)){return}context.report({node:right,messageId:"dangerousInnerHTML",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}},CallExpression(node){const callee=node.callee;if(callee.type==="MemberExpression"&&callee.property.type==="Identifier"){const methodName=callee.property.name;const objectName=callee.object.type==="Identifier"?callee.object.name:"";if(["compile","template","$compile","$interpolate"].includes(methodName)||objectName==="Handlebars"&&methodName==="compile"||objectName==="_"&&methodName==="template"||objectName==="ejs"&&methodName==="render"||objectName==="pug"&&methodName==="render"||objectName==="mustache"&&methodName==="render"){const args=node.arguments;if(args.length>0){const templateArg=args[0];if(templateArg.type==="Identifier"&&isUserInput(templateArg.name)){if(safetyChecker.isSafe(node,context)){return}context.report({node:templateArg,messageId:"userControlledTemplate",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}}if(objectName==="Vue"&&methodName==="directive"){const args=node.arguments;if(args.length>=2){const directiveName=args[0];if(directiveName.type==="Identifier"&&isUserInput(directiveName.name)){if(safetyChecker.isSafe(node,context)){return}context.report({node:directiveName,messageId:"unsafeDirectiveName",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}}}if(callee.type==="Identifier"&&callee.name==="directive"){const args=node.arguments;if(args.length>=2){const directiveName=args[0];if(directiveName.type==="Identifier"&&isUserInput(directiveName.name)){if(safetyChecker.isSafe(node,context)){return}context.report({node:directiveName,messageId:"dynamicDirectiveCreation",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}}},TemplateLiteral(node){let current=node;let isInDangerousContext=false;while(current){if(current.type==="JSXExpressionContainer"){if(current.parent?.type==="JSXAttribute"&&current.parent.name.type==="JSXIdentifier"&&current.parent.name.name==="dangerouslySetInnerHTML"){isInDangerousContext=true;break}}else if(current.type==="AssignmentExpression"){const left=current.left;if(left.type==="MemberExpression"&&left.property.type==="Identifier"&&left.property.name==="innerHTML"){isInDangerousContext=true;break}}current=current.parent}if(isInDangerousContext){const hasUserInput=node.expressions.some(expr=>expr.type==="Identifier"&&isUserInput(expr.name)||expr.type==="MemberExpression"&&expr.object.type==="Identifier"&&isUserInput(expr.object.name));if(hasUserInput){if(safetyChecker.isSafe(node,context)){return}context.report({node,messageId:"templateInjection",data:{filePath:filename,line:String(node.loc?.start.line??0),severity:"HIGH",safeAlternative:"Sanitize template input before insertion"}})}}}}}});
@@ -1 +1 @@
1
- "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noElectronSecurityIssues=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const eslint_devkit_3=require("@interlace/eslint-devkit");exports.noElectronSecurityIssues=(0,eslint_devkit_1.createRule)({name:"no-electron-security-issues",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-secure-coding/docs/rules/no-electron-security-issues.md",description:"Detects Electron security vulnerabilities and insecure configurations",cwe:"CWE-16"},hasSuggestions:true,messages:{electronSecurityIssue:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Electron Security Issue",cwe:"CWE-16",description:"Electron security vulnerability detected",severity:"{{severity}}",fix:"{{safeAlternative}}",documentationLink:"https://electronjs.org/docs/tutorial/security"}),nodeIntegrationEnabled:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Node Integration Enabled",cwe:"CWE-16",description:"nodeIntegration enabled allows Node.js access in renderer",severity:"CRITICAL",fix:"Set nodeIntegration: false and use secure preload scripts",documentationLink:"https://electronjs.org/docs/tutorial/security#2-do-not-enable-nodejs-integration-for-remote-content"}),contextIsolationDisabled:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Context Isolation Disabled",cwe:"CWE-16",description:"contextIsolation disabled removes security boundary",severity:"CRITICAL",fix:"Enable contextIsolation and use preload scripts",documentationLink:"https://electronjs.org/docs/tutorial/context-isolation"}),webSecurityDisabled:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Web Security Disabled",cwe:"CWE-16",description:"webSecurity disabled removes CORS and security protections",severity:"HIGH",fix:"Keep webSecurity enabled",documentationLink:"https://electronjs.org/docs/tutorial/security#6-define-a-content-security-policy"}),insecureContentEnabled:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Insecure Content Enabled",cwe:"CWE-16",description:"allowRunningInsecureContent allows mixed content",severity:"MEDIUM",fix:"Set allowRunningInsecureContent: false",documentationLink:"https://electronjs.org/docs/tutorial/security#5-do-not-disable-websecurity"}),unsafePreloadScript:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Unsafe Preload Script",cwe:"CWE-16",description:"Preload script may expose sensitive APIs",severity:"HIGH",fix:"Use minimal, secure preload scripts",documentationLink:"https://electronjs.org/docs/tutorial/security#3-enable-context-isolation-for-remote-content"}),directNodeAccess:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Direct Node Access",cwe:"CWE-16",description:"Direct access to Node.js APIs in renderer process",severity:"HIGH",fix:"Access Node.js APIs only through secure IPC channels",documentationLink:"https://electronjs.org/docs/tutorial/security#3-enable-context-isolation-for-remote-content"}),insecureIpcPattern:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Insecure IPC Pattern",cwe:"CWE-16",description:"IPC communication lacks proper validation",severity:"MEDIUM",fix:"Validate IPC messages and restrict channels",documentationLink:"https://electronjs.org/docs/tutorial/security#7-do-not-use-the-ipc-transport-for-sensitive-data"}),missingSandbox:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Missing Sandbox",cwe:"CWE-16",description:"BrowserWindow not sandboxed",severity:"MEDIUM",fix:"Enable sandbox for untrusted content",documentationLink:"https://electronjs.org/docs/tutorial/sandbox"}),enableSecurityFeatures:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Enable Security Features",description:"Enable Electron security features",severity:"LOW",fix:"Set contextIsolation: true, nodeIntegration: false",documentationLink:"https://electronjs.org/docs/tutorial/security"}),useContextIsolation:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Use Context Isolation",description:"Use context isolation for security",severity:"LOW",fix:"Enable contextIsolation in BrowserWindow options",documentationLink:"https://electronjs.org/docs/tutorial/context-isolation"}),securePreloadScripts:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Secure Preload Scripts",description:"Use secure preload scripts",severity:"LOW",fix:"Limit APIs exposed in preload scripts",documentationLink:"https://electronjs.org/docs/tutorial/security#3-enable-context-isolation-for-remote-content"}),strategySecureDefaults:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Secure Defaults Strategy",description:"Use secure defaults for Electron applications",severity:"LOW",fix:"Start with secure configuration and relax only when necessary",documentationLink:"https://electronjs.org/docs/tutorial/security"}),strategyProcessSeparation:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Process Separation Strategy",description:"Separate main and renderer processes properly",severity:"LOW",fix:"Keep Node.js APIs in main process, use IPC for communication",documentationLink:"https://electronjs.org/docs/tutorial/application-architecture"}),strategyInputValidation:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Input Validation Strategy",description:"Validate all inputs in Electron applications",severity:"LOW",fix:"Validate IPC messages and user inputs",documentationLink:"https://electronjs.org/docs/tutorial/security#7-do-not-use-the-ipc-transport-for-sensitive-data"})},schema:[{type:"object",properties:{allowInDev:{type:"boolean",default:false,description:"Allow insecure settings in development"},safePreloadPatterns:{type:"array",items:{type:"string"},default:["contextBridge","ipcRenderer"],description:"Preload-script APIs treated as safe"},allowedIpcChannels:{type:"array",items:{type:"string"},default:[],description:"IPC channel names allowed without validation"},trustedSanitizers:{type:"array",items:{type:"string"},default:[],description:"Additional function names to consider as safe"},trustedAnnotations:{type:"array",items:{type:"string"},default:[],description:"Additional JSDoc annotations to consider as safe markers"},strictMode:{type:"boolean",default:false,description:"Disable all false positive detection (strict mode)"}},additionalProperties:false}]},defaultOptions:[{allowInDev:false,safePreloadPatterns:["contextBridge","ipcRenderer"],allowedIpcChannels:[],trustedSanitizers:[],trustedAnnotations:[],strictMode:false}],create(context){const options=context.options[0]||{};const{allowedIpcChannels=[],trustedSanitizers=[],trustedAnnotations=[],strictMode=false}=options;const filename=context.filename;const safetyChecker=(0,eslint_devkit_3.createSafetyChecker)({trustedSanitizers,trustedAnnotations,trustedOrmPatterns:[],strictMode});const isBrowserWindowCreation=node=>{return node.callee.type==="Identifier"&&node.callee.name==="BrowserWindow"};const checkBrowserWindowOptions=optionsNode=>{for(const prop of optionsNode.properties){if(prop.type==="Property"&&prop.key.type==="Identifier"){const key=prop.key.name;const value=prop.value;if(["nodeIntegration","contextIsolation","webSecurity","allowRunningInsecureContent","sandbox"].includes(key)){if(value.type==="Literal"){const isInsecure=key==="nodeIntegration"&&value.value===true||key==="contextIsolation"&&value.value===false||key==="webSecurity"&&value.value===false||key==="allowRunningInsecureContent"&&value.value===true||key==="sandbox"&&value.value===false;if(isInsecure){if(safetyChecker.isSafe(prop,context)){continue}const messageId=key==="nodeIntegration"?"nodeIntegrationEnabled":key==="contextIsolation"?"contextIsolationDisabled":key==="webSecurity"?"webSecurityDisabled":key==="allowRunningInsecureContent"?"insecureContentEnabled":"missingSandbox";context.report({node:prop,messageId,data:{filePath:filename,line:String(prop.loc?.start.line??0)}})}}}}}};const isIpcCall=node=>{const callee=node.callee;if(callee.type==="MemberExpression"&&callee.object.type==="Identifier"&&["ipcMain","ipcRenderer"].includes(callee.object.name)&&callee.property.type==="Identifier"){return["send","invoke","handle","on","once"].includes(callee.property.name)}return false};const checkIpcCall=node=>{const args=node.arguments;if(args.length===0){return}const channelArg=args[0];if(channelArg.type==="Literal"&&typeof channelArg.value==="string"){const channel=channelArg.value;if(allowedIpcChannels.length>0&&!allowedIpcChannels.includes(channel)){if(safetyChecker.isSafe(node,context)){return}context.report({node:channelArg,messageId:"insecureIpcPattern",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}};const isRendererFile=()=>{const fileName=filename.toLowerCase();return fileName.includes("renderer")||fileName.includes("preload")||fileName.includes("ui")||fileName.includes("view")};const isNodeApiCall=node=>{const callee=node.callee;if(callee.type==="Identifier"&&callee.name==="require"){const arg=node.arguments[0];if(arg?.type==="Literal"&&typeof arg.value==="string"){const moduleName=arg.value;return["fs","child_process","os","path","crypto","http","https"].includes(moduleName)}}if(callee.type==="MemberExpression"&&callee.object.type==="Identifier"&&["process","global","__dirname","__filename"].includes(callee.object.name)){return true}return false};return{NewExpression(node){try{if(isBrowserWindowCreation(node)){const args=node.arguments;if(args.length>0&&args[0]?.type==="ObjectExpression"){checkBrowserWindowOptions(args[0])}}}catch{return}},CallExpression(node){try{if(isIpcCall(node)){checkIpcCall(node)}if(isRendererFile()&&isNodeApiCall(node)){if(safetyChecker.isSafe(node,context)){return}context.report({node,messageId:"directNodeAccess",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}catch{return}},AssignmentExpression(node){try{if(node.left.type==="MemberExpression"&&node.left.property.type==="Identifier"&&node.left.property.name==="preload"){if(node.right.type==="Literal"&&typeof node.right.value==="string"){const preloadPath=node.right.value;if(preloadPath.includes("node_modules")||preloadPath.includes("http")||preloadPath.includes("remote")){if(safetyChecker.isSafe(node,context)){return}context.report({node:node.right,messageId:"unsafePreloadScript",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}}}catch{return}},Property(node){try{if(node.key.type==="Identifier"&&node.key.name==="webPreferences"){if(node.value.type==="ObjectExpression"){checkBrowserWindowOptions(node.value)}}}catch{return}}}}});
1
+ "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noElectronSecurityIssues=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const eslint_devkit_3=require("@interlace/eslint-devkit");exports.noElectronSecurityIssues=(0,eslint_devkit_1.createRule)({name:"no-electron-security-issues",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-secure-coding/docs/rules/no-electron-security-issues.md",description:"Detects Electron security vulnerabilities and insecure configurations",cwe:"CWE-16"},messages:{electronSecurityIssue:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Electron Security Issue",cwe:"CWE-16",description:"Electron security vulnerability detected",severity:"{{severity}}",fix:"{{safeAlternative}}",documentationLink:"https://electronjs.org/docs/tutorial/security"}),nodeIntegrationEnabled:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Node Integration Enabled",cwe:"CWE-16",description:"nodeIntegration enabled allows Node.js access in renderer",severity:"CRITICAL",fix:"Set nodeIntegration: false and use secure preload scripts",documentationLink:"https://electronjs.org/docs/tutorial/security#2-do-not-enable-nodejs-integration-for-remote-content"}),contextIsolationDisabled:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Context Isolation Disabled",cwe:"CWE-16",description:"contextIsolation disabled removes security boundary",severity:"CRITICAL",fix:"Enable contextIsolation and use preload scripts",documentationLink:"https://electronjs.org/docs/tutorial/context-isolation"}),webSecurityDisabled:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Web Security Disabled",cwe:"CWE-16",description:"webSecurity disabled removes CORS and security protections",severity:"HIGH",fix:"Keep webSecurity enabled",documentationLink:"https://electronjs.org/docs/tutorial/security#6-define-a-content-security-policy"}),insecureContentEnabled:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Insecure Content Enabled",cwe:"CWE-16",description:"allowRunningInsecureContent allows mixed content",severity:"MEDIUM",fix:"Set allowRunningInsecureContent: false",documentationLink:"https://electronjs.org/docs/tutorial/security#5-do-not-disable-websecurity"}),unsafePreloadScript:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Unsafe Preload Script",cwe:"CWE-16",description:"Preload script may expose sensitive APIs",severity:"HIGH",fix:"Use minimal, secure preload scripts",documentationLink:"https://electronjs.org/docs/tutorial/security#3-enable-context-isolation-for-remote-content"}),directNodeAccess:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Direct Node Access",cwe:"CWE-16",description:"Direct access to Node.js APIs in renderer process",severity:"HIGH",fix:"Access Node.js APIs only through secure IPC channels",documentationLink:"https://electronjs.org/docs/tutorial/security#3-enable-context-isolation-for-remote-content"}),insecureIpcPattern:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Insecure IPC Pattern",cwe:"CWE-16",description:"IPC communication lacks proper validation",severity:"MEDIUM",fix:"Validate IPC messages and restrict channels",documentationLink:"https://electronjs.org/docs/tutorial/security#7-do-not-use-the-ipc-transport-for-sensitive-data"}),missingSandbox:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Missing Sandbox",cwe:"CWE-16",description:"BrowserWindow not sandboxed",severity:"MEDIUM",fix:"Enable sandbox for untrusted content",documentationLink:"https://electronjs.org/docs/tutorial/sandbox"}),enableSecurityFeatures:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Enable Security Features",description:"Enable Electron security features",severity:"LOW",fix:"Set contextIsolation: true, nodeIntegration: false",documentationLink:"https://electronjs.org/docs/tutorial/security"}),useContextIsolation:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Use Context Isolation",description:"Use context isolation for security",severity:"LOW",fix:"Enable contextIsolation in BrowserWindow options",documentationLink:"https://electronjs.org/docs/tutorial/context-isolation"}),securePreloadScripts:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Secure Preload Scripts",description:"Use secure preload scripts",severity:"LOW",fix:"Limit APIs exposed in preload scripts",documentationLink:"https://electronjs.org/docs/tutorial/security#3-enable-context-isolation-for-remote-content"}),strategySecureDefaults:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Secure Defaults Strategy",description:"Use secure defaults for Electron applications",severity:"LOW",fix:"Start with secure configuration and relax only when necessary",documentationLink:"https://electronjs.org/docs/tutorial/security"}),strategyProcessSeparation:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Process Separation Strategy",description:"Separate main and renderer processes properly",severity:"LOW",fix:"Keep Node.js APIs in main process, use IPC for communication",documentationLink:"https://electronjs.org/docs/tutorial/application-architecture"}),strategyInputValidation:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Input Validation Strategy",description:"Validate all inputs in Electron applications",severity:"LOW",fix:"Validate IPC messages and user inputs",documentationLink:"https://electronjs.org/docs/tutorial/security#7-do-not-use-the-ipc-transport-for-sensitive-data"})},schema:[{type:"object",properties:{allowInDev:{type:"boolean",default:false,description:"Allow insecure settings in development"},safePreloadPatterns:{type:"array",items:{type:"string"},default:["contextBridge","ipcRenderer"],description:"Preload-script APIs treated as safe"},allowedIpcChannels:{type:"array",items:{type:"string"},default:[],description:"IPC channel names allowed without validation"},trustedSanitizers:{type:"array",items:{type:"string"},default:[],description:"Additional function names to consider as safe"},trustedAnnotations:{type:"array",items:{type:"string"},default:[],description:"Additional JSDoc annotations to consider as safe markers"},strictMode:{type:"boolean",default:false,description:"Disable all false positive detection (strict mode)"}},additionalProperties:false}]},defaultOptions:[{allowInDev:false,safePreloadPatterns:["contextBridge","ipcRenderer"],allowedIpcChannels:[],trustedSanitizers:[],trustedAnnotations:[],strictMode:false}],create(context){const options=context.options[0]||{};const{allowedIpcChannels=[],trustedSanitizers=[],trustedAnnotations=[],strictMode=false}=options;const filename=context.filename;const safetyChecker=(0,eslint_devkit_3.createSafetyChecker)({trustedSanitizers,trustedAnnotations,trustedOrmPatterns:[],strictMode});const isBrowserWindowCreation=node=>{return node.callee.type==="Identifier"&&node.callee.name==="BrowserWindow"};const checkBrowserWindowOptions=optionsNode=>{for(const prop of optionsNode.properties){if(prop.type==="Property"&&prop.key.type==="Identifier"){const key=prop.key.name;const value=prop.value;if(["nodeIntegration","contextIsolation","webSecurity","allowRunningInsecureContent","sandbox"].includes(key)){if(value.type==="Literal"){const isInsecure=key==="nodeIntegration"&&value.value===true||key==="contextIsolation"&&value.value===false||key==="webSecurity"&&value.value===false||key==="allowRunningInsecureContent"&&value.value===true||key==="sandbox"&&value.value===false;if(isInsecure){if(safetyChecker.isSafe(prop,context)){continue}const messageId=key==="nodeIntegration"?"nodeIntegrationEnabled":key==="contextIsolation"?"contextIsolationDisabled":key==="webSecurity"?"webSecurityDisabled":key==="allowRunningInsecureContent"?"insecureContentEnabled":"missingSandbox";context.report({node:prop,messageId,data:{filePath:filename,line:String(prop.loc?.start.line??0)}})}}}}}};const isIpcCall=node=>{const callee=node.callee;if(callee.type==="MemberExpression"&&callee.object.type==="Identifier"&&["ipcMain","ipcRenderer"].includes(callee.object.name)&&callee.property.type==="Identifier"){return["send","invoke","handle","on","once"].includes(callee.property.name)}return false};const checkIpcCall=node=>{const args=node.arguments;if(args.length===0){return}const channelArg=args[0];if(channelArg.type==="Literal"&&typeof channelArg.value==="string"){const channel=channelArg.value;if(allowedIpcChannels.length>0&&!allowedIpcChannels.includes(channel)){if(safetyChecker.isSafe(node,context)){return}context.report({node:channelArg,messageId:"insecureIpcPattern",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}};const isRendererFile=()=>{const fileName=filename.toLowerCase();return fileName.includes("renderer")||fileName.includes("preload")||fileName.includes("ui")||fileName.includes("view")};const isNodeApiCall=node=>{const callee=node.callee;if(callee.type==="Identifier"&&callee.name==="require"){const arg=node.arguments[0];if(arg?.type==="Literal"&&typeof arg.value==="string"){const moduleName=arg.value;return["fs","child_process","os","path","crypto","http","https"].includes(moduleName)}}if(callee.type==="MemberExpression"&&callee.object.type==="Identifier"&&["process","global","__dirname","__filename"].includes(callee.object.name)){return true}return false};return{NewExpression(node){try{if(isBrowserWindowCreation(node)){const args=node.arguments;if(args.length>0&&args[0]?.type==="ObjectExpression"){checkBrowserWindowOptions(args[0])}}}catch{return}},CallExpression(node){try{if(isIpcCall(node)){checkIpcCall(node)}if(isRendererFile()&&isNodeApiCall(node)){if(safetyChecker.isSafe(node,context)){return}context.report({node,messageId:"directNodeAccess",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}catch{return}},AssignmentExpression(node){try{if(node.left.type==="MemberExpression"&&node.left.property.type==="Identifier"&&node.left.property.name==="preload"){if(node.right.type==="Literal"&&typeof node.right.value==="string"){const preloadPath=node.right.value;if(preloadPath.includes("node_modules")||preloadPath.includes("http")||preloadPath.includes("remote")){if(safetyChecker.isSafe(node,context)){return}context.report({node:node.right,messageId:"unsafePreloadScript",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}}}catch{return}},Property(node){try{if(node.key.type==="Identifier"&&node.key.name==="webPreferences"){if(node.value.type==="ObjectExpression"){checkBrowserWindowOptions(node.value)}}}catch{return}}}}});
@@ -1 +1 @@
1
- "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noImproperSanitization=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const eslint_devkit_3=require("@interlace/eslint-devkit");exports.noImproperSanitization=(0,eslint_devkit_1.createRule)({name:"no-improper-sanitization",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-secure-coding/docs/rules/no-improper-sanitization.md",description:"Detects improper sanitization of user input",cwe:"CWE-116"},hasSuggestions:true,messages:{improperSanitization:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Improper Sanitization",cwe:"CWE-116",description:"User input sanitization is insufficient or incorrect",severity:"{{severity}}",fix:"{{safeAlternative}}",documentationLink:"https://cwe.mitre.org/data/definitions/116.html"}),insufficientXssProtection:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Insufficient XSS Protection",cwe:"CWE-79",description:"XSS protection is incomplete or missing",severity:"HIGH",fix:"Use comprehensive XSS prevention or trusted sanitization library",documentationLink:"https://owasp.org/www-community/attacks/xss/"}),incompleteHtmlEscaping:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Incomplete HTML Escaping",cwe:"CWE-116",description:"HTML escaping misses dangerous characters",severity:"MEDIUM",fix:`Escape all HTML special characters: & < > " '`,documentationLink:"https://cheatsheetseries.owasp.org/cheatsheets/Cross_Site_Scripting_Prevention_Cheat_Sheet.html"}),unsafeReplaceSanitization:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Unsafe Replace Sanitization",cwe:"CWE-116",description:"Simple replace() calls are insufficient for sanitization",severity:"MEDIUM",fix:"Use comprehensive sanitization libraries",documentationLink:"https://cwe.mitre.org/data/definitions/116.html"}),missingContextEncoding:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Missing Context Encoding",cwe:"CWE-116",description:"Output encoding missing for specific context",severity:"MEDIUM",fix:"Encode output according to usage context (HTML, URL, SQL, etc.)",documentationLink:"https://cheatsheetseries.owasp.org/cheatsheets/Cross_Site_Scripting_Prevention_Cheat_Sheet.html"}),dangerousSanitizerUsage:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Dangerous Sanitizer Usage",cwe:"CWE-94",description:"Custom sanitizer may be incomplete or bypassable",severity:"LOW",fix:"Use well-tested sanitization libraries",documentationLink:"https://cwe.mitre.org/data/definitions/94.html"}),sqlInjectionSanitization:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"SQL Injection Sanitization",cwe:"CWE-89",description:"SQL input sanitization is insufficient",severity:"HIGH",fix:"Use parameterized queries instead of sanitization",documentationLink:"https://owasp.org/www-community/attacks/SQL_Injection"}),commandInjectionSanitization:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Command Injection Sanitization",cwe:"CWE-78",description:"Command input sanitization is insufficient",severity:"CRITICAL",fix:"Avoid shell commands with user input, use safe APIs",documentationLink:"https://owasp.org/www-community/attacks/Command_Injection"}),useProperSanitization:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Use Proper Sanitization",description:"Use proper sanitization methods for each context",severity:"LOW",fix:"HTML: DOMPurify, URL: encodeURIComponent, SQL: parameterized queries",documentationLink:"https://cheatsheetseries.owasp.org/cheatsheets/Input_Validation_Cheat_Sheet.html"}),validateSanitization:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Validate Sanitization",description:"Validate that sanitization is effective",severity:"LOW",fix:"Test sanitization with malicious inputs",documentationLink:"https://cwe.mitre.org/data/definitions/116.html"}),implementContextAware:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Implement Context Aware Sanitization",description:"Use different sanitization for different contexts",severity:"LOW",fix:`HTML context: escape <>&"' , URL context: encodeURIComponent`,documentationLink:"https://cheatsheetseries.owasp.org/cheatsheets/Cross_Site_Scripting_Prevention_Cheat_Sheet.html"}),strategyDefenseInDepth:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Defense in Depth Strategy",description:"Implement multiple layers of input validation",severity:"LOW",fix:"Validate input, sanitize output, use CSP, implement rate limiting",documentationLink:"https://owasp.org/www-community/controls/Defense_in_depth"}),strategyInputValidation:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Input Validation Strategy",description:"Validate input at multiple layers",severity:"LOW",fix:"Client-side, server-side, and database-level validation",documentationLink:"https://cheatsheetseries.owasp.org/cheatsheets/Input_Validation_Cheat_Sheet.html"}),strategyOutputEncoding:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Output Encoding Strategy",description:"Encode output according to context",severity:"LOW",fix:"Use appropriate encoding for HTML, JavaScript, CSS, URL contexts",documentationLink:"https://cheatsheetseries.owasp.org/cheatsheets/Cross_Site_Scripting_Prevention_Cheat_Sheet.html"})},schema:[{type:"object",properties:{safeSanitizers:{type:"array",items:{type:"string"},default:["DOMPurify.sanitize","he.encode","encodeURIComponent","encodeURI","escape"],description:"Sanitizer calls treated as sufficient"},dangerousChars:{type:"array",items:{type:"string"},default:["<",">",'"',"'","&","`","$","{","}","|",";","(",")"],description:"Characters a sanitizer is expected to handle"},contexts:{type:"array",items:{type:"string"},default:["html","url","sql","command","javascript","css"],description:"Output contexts checked for a context-appropriate sanitizer"},trustedLibraries:{type:"array",items:{type:"string"},default:["DOMPurify","he","validator","express-validator"],description:"Libraries whose sanitizers are trusted"},trustedSanitizers:{type:"array",items:{type:"string"},default:[],description:"Additional function names to consider as sanitizers"},trustedAnnotations:{type:"array",items:{type:"string"},default:[],description:"Additional JSDoc annotations to consider as safe markers"},strictMode:{type:"boolean",default:false,description:"Disable all false positive detection (strict mode)"}},additionalProperties:false}]},defaultOptions:[{safeSanitizers:["DOMPurify.sanitize","he.encode","encodeURIComponent","encodeURI","escape"],dangerousChars:["<",">",'"',"'","&","`","$","{","}","|",";","(",")"],contexts:["html","url","sql","command","javascript","css"],trustedLibraries:["DOMPurify","he","validator","express-validator"],trustedSanitizers:[],trustedAnnotations:[],strictMode:false}],create(context){const options=context.options[0]||{};const{safeSanitizers=["DOMPurify.sanitize","he.encode","encodeURIComponent","encodeURI","escape"],dangerousChars=["<",">",'"',"'","&","`","$","{","}","|",";","(",")"],trustedSanitizers=[],trustedAnnotations=[],strictMode=false}=options;const sourceCode=context.sourceCode;const filename=context.filename;const safetyChecker=(0,eslint_devkit_3.createSafetyChecker)({trustedSanitizers,trustedAnnotations,trustedOrmPatterns:[],strictMode});const isSafeSanitizer=callText=>{return safeSanitizers.some(sanitizer=>callText.includes(sanitizer))};const isIncompleteReplaceSanitization=callExpression=>{const callText=sourceCode.getText(callExpression);const escapesOnlyTags=/replace\(\s*\/[<>]/.test(callText);if(escapesOnlyTags){const hasQuoteEscaping=/&quot;|&#x27;|&#039;/.test(callText);const hasAmpersandEscaping=/&amp;/.test(callText);return!(hasQuoteEscaping&&hasAmpersandEscaping)}return false};const needsContextEncoding=outputNode=>{let current=outputNode;while(current){const text=sourceCode.getText(current).toLowerCase();if(text.includes("innerhtml")||text.includes("outerhtml")){return"html"}if(text.includes("href")||text.includes("src")||text.includes("url")){return"url"}if(text.includes("sql")||text.includes("query")||text.includes("execute")){return"sql"}if(text.includes("exec")||text.includes("spawn")||text.includes("command")){return"command"}current=current.parent}return null};return{CallExpression(node){const callee=node.callee;if(callee.type==="MemberExpression"&&callee.property.type==="Identifier"&&callee.property.name==="replace"){if(isIncompleteReplaceSanitization(node)){if(safetyChecker.isSafe(node,context)){return}context.report({node,messageId:"incompleteHtmlEscaping",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}if(callee.type==="Identifier"){const functionName=callee.name;if(functionName.toLowerCase().includes("sanitize")||functionName.toLowerCase().includes("escape")||functionName.toLowerCase().includes("clean")){if(!safeSanitizers.some(safe=>functionName.includes(safe))){const args=node.arguments;let hasUserInput=false;for(const arg of args){const argText=sourceCode.getText(arg).toLowerCase();if(argText.includes("req.")||argText.includes("body")||argText.includes("query")||argText.includes("params")||argText.includes("input")||argText.includes("data")){hasUserInput=true;break}}if(hasUserInput){if(safetyChecker.isSafe(node,context)){return}context.report({node,messageId:"dangerousSanitizerUsage",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}}}},AssignmentExpression(node){const left=node.left;const right=node.right;if(left.type==="MemberExpression"&&left.property.type==="Identifier"){const propertyName=left.property.name.toLowerCase();if(["innerhtml","outerhtml","innertext","textcontent"].includes(propertyName)){const encodingContext=needsContextEncoding(node);if(encodingContext==="html"&&propertyName==="innerhtml"){const rightText=sourceCode.getText(right);if(!isSafeSanitizer(rightText)){const hasUserInput=rightText.includes("req.")||rightText.includes("body")||rightText.includes("query")||rightText.includes("input");if(hasUserInput){if(safetyChecker.isSafe(node,context)){return}context.report({node:right,messageId:"insufficientXssProtection",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}}}}},Literal(node){if(typeof node.value!=="string"){return}const directParent=node.parent;if(directParent?.type==="AssignmentExpression"&&directParent.right===node&&directParent.left.type==="MemberExpression"){const left=directParent.left;if(left.property.type==="Identifier"&&["innerHTML","outerHTML"].includes(left.property.name)){const literalValue=node.value;const hasDangerousMarkup=/<script[\s>]|<\/script>|\son\w+\s*=|javascript:/i.test(literalValue);if(!hasDangerousMarkup){return}}}const text=node.value;let current=node;let isInDangerousContext=false;while(current){if(current.type==="AssignmentExpression"){const left=current.left;if(left.type==="MemberExpression"&&left.property.type==="Identifier"&&["innerHTML","outerHTML"].includes(left.property.name)){isInDangerousContext=true;break}}else if(current.type==="CallExpression"){const callee=current.callee;if(callee.type==="MemberExpression"&&callee.property.type==="Identifier"&&["write","send","json"].includes(callee.property.name)){isInDangerousContext=true;break}}current=current.parent}if(isInDangerousContext){const hasDangerousChars=dangerousChars.some(char=>text.includes(char));const hasEscaping=text.includes("&lt;")||text.includes("&gt;")||text.includes("&quot;")||text.includes("&#x27;")||text.includes("&amp;");if(hasDangerousChars&&!hasEscaping){if(safetyChecker.isSafe(node,context)){return}context.report({node,messageId:"unsafeReplaceSanitization",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}}}}});
1
+ "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noImproperSanitization=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const eslint_devkit_3=require("@interlace/eslint-devkit");exports.noImproperSanitization=(0,eslint_devkit_1.createRule)({name:"no-improper-sanitization",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-secure-coding/docs/rules/no-improper-sanitization.md",description:"Detects improper sanitization of user input",cwe:"CWE-116"},messages:{improperSanitization:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Improper Sanitization",cwe:"CWE-116",description:"User input sanitization is insufficient or incorrect",severity:"{{severity}}",fix:"{{safeAlternative}}",documentationLink:"https://cwe.mitre.org/data/definitions/116.html"}),insufficientXssProtection:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Insufficient XSS Protection",cwe:"CWE-79",description:"XSS protection is incomplete or missing",severity:"HIGH",fix:"Use comprehensive XSS prevention or trusted sanitization library",documentationLink:"https://owasp.org/www-community/attacks/xss/"}),incompleteHtmlEscaping:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Incomplete HTML Escaping",cwe:"CWE-116",description:"HTML escaping misses dangerous characters",severity:"MEDIUM",fix:`Escape all HTML special characters: & < > " '`,documentationLink:"https://cheatsheetseries.owasp.org/cheatsheets/Cross_Site_Scripting_Prevention_Cheat_Sheet.html"}),unsafeReplaceSanitization:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Unsafe Replace Sanitization",cwe:"CWE-116",description:"Simple replace() calls are insufficient for sanitization",severity:"MEDIUM",fix:"Use comprehensive sanitization libraries",documentationLink:"https://cwe.mitre.org/data/definitions/116.html"}),missingContextEncoding:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Missing Context Encoding",cwe:"CWE-116",description:"Output encoding missing for specific context",severity:"MEDIUM",fix:"Encode output according to usage context (HTML, URL, SQL, etc.)",documentationLink:"https://cheatsheetseries.owasp.org/cheatsheets/Cross_Site_Scripting_Prevention_Cheat_Sheet.html"}),sqlInjectionSanitization:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"SQL Injection Sanitization",cwe:"CWE-89",description:"SQL input sanitization is insufficient",severity:"HIGH",fix:"Use parameterized queries instead of sanitization",documentationLink:"https://owasp.org/www-community/attacks/SQL_Injection"}),commandInjectionSanitization:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Command Injection Sanitization",cwe:"CWE-78",description:"Command input sanitization is insufficient",severity:"CRITICAL",fix:"Avoid shell commands with user input, use safe APIs",documentationLink:"https://owasp.org/www-community/attacks/Command_Injection"}),useProperSanitization:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Use Proper Sanitization",description:"Use proper sanitization methods for each context",severity:"LOW",fix:"HTML: DOMPurify, URL: encodeURIComponent, SQL: parameterized queries",documentationLink:"https://cheatsheetseries.owasp.org/cheatsheets/Input_Validation_Cheat_Sheet.html"}),validateSanitization:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Validate Sanitization",description:"Validate that sanitization is effective",severity:"LOW",fix:"Test sanitization with malicious inputs",documentationLink:"https://cwe.mitre.org/data/definitions/116.html"}),implementContextAware:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Implement Context Aware Sanitization",description:"Use different sanitization for different contexts",severity:"LOW",fix:`HTML context: escape <>&"' , URL context: encodeURIComponent`,documentationLink:"https://cheatsheetseries.owasp.org/cheatsheets/Cross_Site_Scripting_Prevention_Cheat_Sheet.html"}),strategyDefenseInDepth:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Defense in Depth Strategy",description:"Implement multiple layers of input validation",severity:"LOW",fix:"Validate input, sanitize output, use CSP, implement rate limiting",documentationLink:"https://owasp.org/www-community/controls/Defense_in_depth"}),strategyInputValidation:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Input Validation Strategy",description:"Validate input at multiple layers",severity:"LOW",fix:"Client-side, server-side, and database-level validation",documentationLink:"https://cheatsheetseries.owasp.org/cheatsheets/Input_Validation_Cheat_Sheet.html"}),strategyOutputEncoding:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Output Encoding Strategy",description:"Encode output according to context",severity:"LOW",fix:"Use appropriate encoding for HTML, JavaScript, CSS, URL contexts",documentationLink:"https://cheatsheetseries.owasp.org/cheatsheets/Cross_Site_Scripting_Prevention_Cheat_Sheet.html"})},schema:[{type:"object",properties:{safeSanitizers:{type:"array",items:{type:"string"},default:["DOMPurify.sanitize","he.encode","encodeURIComponent","encodeURI","escape"],description:"Sanitizer calls treated as sufficient"},dangerousChars:{type:"array",items:{type:"string"},default:["<",">",'"',"'","&","`","$","{","}","|",";","(",")"],description:"Characters a sanitizer is expected to handle"},contexts:{type:"array",items:{type:"string"},default:["html","url","sql","command","javascript","css"],description:"Output contexts checked for a context-appropriate sanitizer"},trustedLibraries:{type:"array",items:{type:"string"},default:["DOMPurify","he","validator","express-validator"],description:"Libraries whose sanitizers are trusted"},trustedSanitizers:{type:"array",items:{type:"string"},default:[],description:"Additional function names to consider as sanitizers"},trustedAnnotations:{type:"array",items:{type:"string"},default:[],description:"Additional JSDoc annotations to consider as safe markers"},strictMode:{type:"boolean",default:false,description:"Disable all false positive detection (strict mode)"}},additionalProperties:false}]},defaultOptions:[{safeSanitizers:["DOMPurify.sanitize","he.encode","encodeURIComponent","encodeURI","escape"],dangerousChars:["<",">",'"',"'","&","`","$","{","}","|",";","(",")"],contexts:["html","url","sql","command","javascript","css"],trustedLibraries:["DOMPurify","he","validator","express-validator"],trustedSanitizers:[],trustedAnnotations:[],strictMode:false}],create(context){const options=context.options[0]||{};const{safeSanitizers=["DOMPurify.sanitize","he.encode","encodeURIComponent","encodeURI","escape"],dangerousChars=["<",">",'"',"'","&","`","$","{","}","|",";","(",")"],trustedSanitizers=[],trustedAnnotations=[],strictMode=false}=options;const sourceCode=context.sourceCode;const filename=context.filename;const safetyChecker=(0,eslint_devkit_3.createSafetyChecker)({trustedSanitizers,trustedAnnotations,trustedOrmPatterns:[],strictMode});const isSafeSanitizer=callText=>{return safeSanitizers.some(sanitizer=>callText.includes(sanitizer))};const isIncompleteReplaceSanitization=callExpression=>{const callText=sourceCode.getText(callExpression);const escapesOnlyTags=/replace\(\s*\/[<>]/.test(callText);if(escapesOnlyTags){const hasQuoteEscaping=/&quot;|&#x27;|&#039;/.test(callText);const hasAmpersandEscaping=/&amp;/.test(callText);return!(hasQuoteEscaping&&hasAmpersandEscaping)}return false};const needsContextEncoding=outputNode=>{let current=outputNode;while(current){const text=sourceCode.getText(current).toLowerCase();if(text.includes("innerhtml")||text.includes("outerhtml")){return"html"}if(text.includes("href")||text.includes("src")||text.includes("url")){return"url"}if(text.includes("sql")||text.includes("query")||text.includes("execute")){return"sql"}if(text.includes("exec")||text.includes("spawn")||text.includes("command")){return"command"}current=current.parent}return null};return{CallExpression(node){const callee=node.callee;if(callee.type==="MemberExpression"&&callee.property.type==="Identifier"&&callee.property.name==="replace"){if(isIncompleteReplaceSanitization(node)){if(safetyChecker.isSafe(node,context)){return}context.report({node,messageId:"incompleteHtmlEscaping",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}},AssignmentExpression(node){const left=node.left;const right=node.right;if(left.type==="MemberExpression"&&left.property.type==="Identifier"){const propertyName=left.property.name.toLowerCase();if(["innerhtml","outerhtml","innertext","textcontent"].includes(propertyName)){const encodingContext=needsContextEncoding(node);if(encodingContext==="html"&&propertyName==="innerhtml"){const rightText=sourceCode.getText(right);if(!isSafeSanitizer(rightText)){const hasUserInput=rightText.includes("req.")||rightText.includes("body")||rightText.includes("query")||rightText.includes("input");if(hasUserInput){if(safetyChecker.isSafe(node,context)){return}context.report({node:right,messageId:"insufficientXssProtection",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}}}}},Literal(node){if(typeof node.value!=="string"){return}const directParent=node.parent;if(directParent?.type==="AssignmentExpression"&&directParent.right===node&&directParent.left.type==="MemberExpression"){const left=directParent.left;if(left.property.type==="Identifier"&&["innerHTML","outerHTML"].includes(left.property.name)){const literalValue=node.value;const hasDangerousMarkup=/<script[\s>]|<\/script>|\son\w+\s*=|javascript:/i.test(literalValue);if(!hasDangerousMarkup){return}}}const text=node.value;let current=node;let isInDangerousContext=false;while(current){if(current.type==="AssignmentExpression"){const left=current.left;if(left.type==="MemberExpression"&&left.property.type==="Identifier"&&["innerHTML","outerHTML"].includes(left.property.name)){isInDangerousContext=true;break}}else if(current.type==="CallExpression"){const callee=current.callee;if(callee.type==="MemberExpression"&&callee.property.type==="Identifier"&&["write","send","json"].includes(callee.property.name)){isInDangerousContext=true;break}}current=current.parent}if(isInDangerousContext){const enclosingArgument=literal=>{let current2=literal;let parent=current2.parent;for(;;){if(parent?.type==="BinaryExpression"&&parent.operator==="+"){current2=parent}else if(parent?.type==="ArrayExpression"){current2=parent}else if(parent?.type==="Property"||parent?.type==="ObjectExpression"&&current2.type==="Property"){current2=parent}else if(parent?.type==="MemberExpression"&&parent.object===current2&&parent.property.type==="Identifier"&&parent.property.name==="join"){current2=parent}else if(parent?.type==="CallExpression"&&parent.callee===current2){current2=parent}else{break}parent=current2.parent}if(parent?.type==="CallExpression"&&parent.arguments.includes(current2)){return current2}return void 0};const sanitizerNames=new Set([...safeSanitizers,...trustedSanitizers,"escapeHtml","escapeHTML","htmlEscape"]);const calleeName=callee=>{if(callee.type==="Identifier")return callee.name;if(callee.type==="MemberExpression"&&callee.object.type==="Identifier"&&callee.property.type==="Identifier"){return`${callee.object.name}.${callee.property.name}`}return void 0};const isSafeText=expr=>{if(expr.type==="Literal")return typeof expr.value==="string";if(expr.type==="TemplateLiteral")return expr.expressions.length===0;if(expr.type==="BinaryExpression"&&expr.operator==="+"){return isSafeText(expr.left)&&isSafeText(expr.right)}if(expr.type==="ObjectExpression"){return expr.properties.every(property=>property.type==="Property"&&isSafeText(property.value))}if(expr.type==="CallExpression"){const callee=expr.callee;if(callee.type==="MemberExpression"&&callee.property.type==="Identifier"&&callee.property.name==="join"&&callee.object.type==="ArrayExpression"){return callee.object.elements.every(element=>element!==null&&isSafeText(element))}const name=calleeName(callee);return name!==void 0&&sanitizerNames.has(name)}return false};const argument=enclosingArgument(node);const isBareLiteral=argument!==void 0&&isSafeText(argument);const hasDangerousMarkup=/<script[\s>]|<\/script>|\son\w+\s*=|javascript:/i.test(text);if(isBareLiteral&&!hasDangerousMarkup){return}const hasDangerousChars=dangerousChars.some(char=>text.includes(char));const hasEscaping=text.includes("&lt;")||text.includes("&gt;")||text.includes("&quot;")||text.includes("&#x27;")||text.includes("&amp;");if(hasDangerousChars&&!hasEscaping){if(safetyChecker.isSafe(node,context)){return}context.report({node,messageId:"unsafeReplaceSanitization",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}}}}});
@@ -1 +1 @@
1
- "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noUncheckedLoopCondition=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const eslint_devkit_3=require("@interlace/eslint-devkit");exports.noUncheckedLoopCondition=(0,eslint_devkit_1.createRule)({name:"no-unchecked-loop-condition",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-secure-coding/docs/rules/no-unchecked-loop-condition.md",description:"Detects unchecked loop conditions that could cause DoS",cwe:"CWE-400"},hasSuggestions:true,messages:{uncheckedLoopCondition:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Unchecked Loop Condition",cwe:"CWE-400",description:"Loop condition may cause DoS through excessive iterations",severity:"{{severity}}",fix:"{{safeAlternative}}",documentationLink:"https://cwe.mitre.org/data/definitions/400.html"}),infiniteLoop:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Infinite Loop",cwe:"CWE-400",description:"Loop may run indefinitely",severity:"CRITICAL",fix:"Add termination condition or iteration limit",documentationLink:"https://cwe.mitre.org/data/definitions/400.html"}),userControlledLoopBound:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"User Controlled Loop Bound",cwe:"CWE-606",description:"Loop bound controlled by user input",severity:"HIGH",fix:"Limit maximum iterations or validate input",documentationLink:"https://cwe.mitre.org/data/definitions/606.html"}),missingLoopTermination:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Missing Loop Termination",cwe:"CWE-400",description:"Loop lacks clear termination condition",severity:"MEDIUM",fix:"Add explicit termination condition",documentationLink:"https://cwe.mitre.org/data/definitions/400.html"}),largeLoopBound:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Large Loop Bound",cwe:"CWE-400",description:"Loop may iterate excessively",severity:"MEDIUM",fix:"Limit maximum iterations",documentationLink:"https://cwe.mitre.org/data/definitions/400.html"}),unsafeRecursion:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Unsafe Recursion",cwe:"CWE-674",description:"Recursive function may cause stack overflow",severity:"HIGH",fix:"Add recursion depth limit or use iterative approach",documentationLink:"https://cwe.mitre.org/data/definitions/674.html"}),limitLoopIterations:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Limit Loop Iterations",description:"Limit maximum loop iterations",severity:"LOW",fix:"Add iteration counter with maximum limit",documentationLink:"https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/for"})},schema:[{type:"object",properties:{maxStaticIterations:{type:"number",minimum:100,default:1e4,description:"Literal iteration count above which a loop is reported"},userInputVariables:{type:"array",items:{type:"string"},default:["req","request","body","query","params","input","data"],description:"Variable names treated as user-controlled input"},allowWhileTrueWithBreak:{type:"boolean",default:true,description:"Allow `while (true)` when the body contains a `break`"},maxRecursionDepth:{type:"number",minimum:1,default:10,description:"Recursion depth above which a call is reported"},trustedSanitizers:{type:"array",items:{type:"string"},default:[],description:"Additional function names to consider as loop protectors"},trustedAnnotations:{type:"array",items:{type:"string"},default:[],description:"Additional JSDoc annotations to consider as safe markers"},strictMode:{type:"boolean",default:false,description:"Disable all false positive detection (strict mode)"}},additionalProperties:false}]},defaultOptions:[{maxStaticIterations:1e4,userInputVariables:["req","request","body","query","params","input","data"],allowWhileTrueWithBreak:true,maxRecursionDepth:10,trustedSanitizers:[],trustedAnnotations:[],strictMode:false}],create(context){const options=context.options[0]||{};const{maxStaticIterations=1e4,userInputVariables=["req","request","body","query","params","input","data"],allowWhileTrueWithBreak=true,maxRecursionDepth=10,trustedSanitizers=[],trustedAnnotations=[],strictMode=false}=options;const sourceCode=context.sourceCode;const filename=context.filename;const safetyChecker=(0,eslint_devkit_3.createSafetyChecker)({trustedSanitizers,trustedAnnotations,trustedOrmPatterns:[],strictMode});const functionCalls=new Map;const reportedRecursion=new Set;const currentFunctionStack=[];const taintedVariables=new Set;const isUserInput=varName=>{if(taintedVariables.has(varName)){return true}const lowerVarName=varName.toLowerCase();const isUsingDefaults=userInputVariables.length===7&&userInputVariables.includes("req")&&userInputVariables.includes("input");if(!isUsingDefaults){return userInputVariables.some(input=>lowerVarName===input.toLowerCase())}return userInputVariables.some(input=>lowerVarName.includes(input.toLowerCase())||lowerVarName===input.toLowerCase()||lowerVarName.includes("input")||lowerVarName.includes("data"))};const checkComplexDoSPatterns=condition=>{const conditionText=sourceCode.getText(condition);if(conditionText.includes(".match(")||conditionText.includes(".test(")){return true}if(conditionText.includes("page")&&conditionText.includes("pageSize")){return true}if(conditionText.includes("*")&&(conditionText.includes("pageSize")||conditionText.includes("limit"))){return true}return false};const checkComplexDoSPatternsInScope=condition=>{const conditionText=sourceCode.getText(condition);if(conditionText.includes("endIndex")||conditionText.includes("startIndex")){return true}return false};const checkIfCollectionIsValidated=(forOfNode,collection)=>{const collectionText=sourceCode.getText(collection);let current=forOfNode.parent;while(current){if(current.type==="IfStatement"){const test=current.test;const testText=sourceCode.getText(test);if(testText.includes("Array.isArray(")&&testText.includes(collectionText)){if(testText.includes(".length")&&(testText.includes("<")||testText.includes(">"))){return true}}}if(current.type==="FunctionDeclaration"||current.type==="FunctionExpression"||current.type==="ArrowFunctionExpression"){break}current=current.parent}return false};const involvesUserInput=expression=>{const expressionText=sourceCode.getText(expression).toLowerCase();if(userInputVariables.some(input=>expressionText.includes(input.toLowerCase()))){return true}const checkExpression=node=>{if(node.type==="MemberExpression"){const objectText=sourceCode.getText(node.object);if(isUserInput(objectText)){return true}return checkExpression(node.object)}if(node.type==="Identifier"){return isUserInput(node.name)}if(node.type==="CallExpression"){return checkExpression(node.callee)||node.arguments.filter(arg=>arg.type!=="SpreadElement").some(arg=>checkExpression(arg))}if(node.type==="BinaryExpression"){return checkExpression(node.left)||checkExpression(node.right)}if(node.type==="UpdateExpression"){return checkExpression(node.argument)}if(node.type==="UnaryExpression"){return checkExpression(node.argument)}return false};return checkExpression(expression)};const hasBreakStatement=loopBody=>{let hasBreak=false;const visited=new Set;const checkNode=(node,depth=0)=>{if(depth>10||visited.has(node)){return}visited.add(node);if(node.type==="BreakStatement"){hasBreak=true;return}for(const key in node){const child=node[key];if(child&&typeof child==="object"){if("type"in child){checkNode(child,depth+1)}else if(Array.isArray(child)){child.forEach(item=>{if(item&&typeof item==="object"&&"type"in item){checkNode(item,depth+1)}})}}}};checkNode(loopBody);return hasBreak};const estimateIterations=loop=>{const test=loop.test;if(test&&test.type==="BinaryExpression"){if(test.operator==="<"||test.operator==="<="||test.operator===">"||test.operator===">="){const right=test.right;if(right.type==="Literal"&&typeof right.value==="number"){return Math.abs(right.value)}}}return null};return{VariableDeclaration(node){for(const declarator of node.declarations){if(declarator.id.type==="Identifier"&&declarator.init){const varName=declarator.id.name;const initText=sourceCode.getText(declarator.init);const hasUserInput=userInputVariables.some(input=>initText.toLowerCase().includes(input.toLowerCase()));const isSanitized=initText.includes("Math.min(")||initText.includes("Math.max(")||initText.includes("parseInt(")||initText.includes("parseFloat(")||initText.includes("&&")&&initText.includes(".length");if(hasUserInput&&!isSanitized){taintedVariables.add(varName)}}}},FunctionDeclaration(node){if(node.id){currentFunctionStack.push(node.id.name)}},"FunctionDeclaration:exit"(node){if(node.id&&currentFunctionStack[currentFunctionStack.length-1]===node.id.name){currentFunctionStack.pop()}},CallExpression(node){const callee=node.callee;if(callee.type==="Identifier"){const functionName=callee.name;const currentFunction=currentFunctionStack[currentFunctionStack.length-1];if(currentFunction&&functionName===currentFunction){const callCount=(functionCalls.get(functionName)||0)+1;functionCalls.set(functionName,callCount);if((callCount>maxRecursionDepth||callCount>=1)&&!reportedRecursion.has(functionName)){const isTreeTraversal=currentFunction==="traverseObject";if(callCount>maxRecursionDepth||currentFunction==="recursiveFunc"||isTreeTraversal){if(safetyChecker.isSafe(node,context)){return}reportedRecursion.add(functionName);context.report({node,messageId:"unsafeRecursion",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}}}},WhileStatement(node){const test=node.test;if(test.type==="Literal"&&test.value===true){const hasBreak=hasBreakStatement(node.body);if(allowWhileTrueWithBreak&&hasBreak){return}context.report({node,messageId:"infiniteLoop",data:{filePath:filename,line:String(node.loc?.start.line??0)},suggest:[{messageId:"limitLoopIterations",fix:()=>null}]});return}if(involvesUserInput(test)){if(safetyChecker.isSafe(node,context)){return}context.report({node:test,messageId:"userControlledLoopBound",data:{filePath:filename,line:String(node.loc?.start.line??0)}});return}if(checkComplexDoSPatterns(test)){if(safetyChecker.isSafe(node,context)){return}context.report({node:test,messageId:"userControlledLoopBound",data:{filePath:filename,line:String(node.loc?.start.line??0)}});return}if(test.type==="Identifier"){const varName=test.name;if(varName.toLowerCase().includes("continue")||varName.toLowerCase().includes("running")||varName.toLowerCase().includes("active")||varName.toLowerCase().includes("enabled")){if(safetyChecker.isSafe(node,context)){return}context.report({node:test,messageId:"infiniteLoop",data:{filePath:filename,line:String(node.loc?.start.line??0)}});return}}},ForStatement(node){if(!node.test&&!node.update){if(safetyChecker.isSafe(node,context)){return}context.report({node,messageId:"infiniteLoop",data:{filePath:filename,line:String(node.loc?.start.line??0)}});return}if(!node.test){if(safetyChecker.isSafe(node,context)){return}context.report({node,messageId:"missingLoopTermination",data:{filePath:filename,line:String(node.loc?.start.line??0)}});return}if(involvesUserInput(node.test)){if(safetyChecker.isSafe(node,context)){return}context.report({node:node.test,messageId:"userControlledLoopBound",data:{filePath:filename,line:String(node.loc?.start.line??0)}});return}if(checkComplexDoSPatterns(node.test)||checkComplexDoSPatternsInScope(node.test)){if(safetyChecker.isSafe(node,context)){return}context.report({node:node.test,messageId:"userControlledLoopBound",data:{filePath:filename,line:String(node.loc?.start.line??0)}});return}const estimatedIterations=estimateIterations(node);if(estimatedIterations&&estimatedIterations>maxStaticIterations){if(safetyChecker.isSafe(node,context)){return}context.report({node:node.test,messageId:"largeLoopBound",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}},DoWhileStatement(node){const test=node.test;if(involvesUserInput(test)){if(safetyChecker.isSafe(node,context)){return}context.report({node:test,messageId:"userControlledLoopBound",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}},ForInStatement(node){const right=node.right;if(involvesUserInput(right)){if(safetyChecker.isSafe(node,context)){return}context.report({node:right,messageId:"uncheckedLoopCondition",data:{filePath:filename,line:String(node.loc?.start.line??0),severity:"MEDIUM",safeAlternative:"Limit collection size or add iteration timeout"}})}},ForOfStatement(node){const right=node.right;if(involvesUserInput(right)){const isValidated=checkIfCollectionIsValidated(node,right);if(isValidated){return}if(safetyChecker.isSafe(node,context)){return}context.report({node:right,messageId:"uncheckedLoopCondition",data:{filePath:filename,line:String(node.loc?.start.line??0),severity:"MEDIUM",safeAlternative:"Limit collection size before iteration"}})}}}}});
1
+ "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noUncheckedLoopCondition=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const eslint_devkit_3=require("@interlace/eslint-devkit");exports.noUncheckedLoopCondition=(0,eslint_devkit_1.createRule)({name:"no-unchecked-loop-condition",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-secure-coding/docs/rules/no-unchecked-loop-condition.md",description:"Detects unchecked loop conditions that could cause DoS",cwe:"CWE-400"},hasSuggestions:true,messages:{uncheckedLoopCondition:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Unchecked Loop Condition",cwe:"CWE-400",description:"Loop condition may cause DoS through excessive iterations",severity:"{{severity}}",fix:"{{safeAlternative}}",documentationLink:"https://cwe.mitre.org/data/definitions/400.html"}),infiniteLoop:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Infinite Loop",cwe:"CWE-400",description:"Loop may run indefinitely",severity:"CRITICAL",fix:"Add termination condition or iteration limit",documentationLink:"https://cwe.mitre.org/data/definitions/400.html"}),userControlledLoopBound:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"User Controlled Loop Bound",cwe:"CWE-606",description:"Loop bound controlled by user input",severity:"HIGH",fix:"Limit maximum iterations or validate input",documentationLink:"https://cwe.mitre.org/data/definitions/606.html"}),missingLoopTermination:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Missing Loop Termination",cwe:"CWE-400",description:"Loop lacks clear termination condition",severity:"MEDIUM",fix:"Add explicit termination condition",documentationLink:"https://cwe.mitre.org/data/definitions/400.html"}),largeLoopBound:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Large Loop Bound",cwe:"CWE-400",description:"Loop may iterate excessively",severity:"MEDIUM",fix:"Limit maximum iterations",documentationLink:"https://cwe.mitre.org/data/definitions/400.html"}),unsafeRecursion:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Unsafe Recursion",cwe:"CWE-674",description:"Recursive function may cause stack overflow",severity:"HIGH",fix:"Add recursion depth limit or use iterative approach",documentationLink:"https://cwe.mitre.org/data/definitions/674.html"}),limitLoopIterations:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Limit Loop Iterations",description:"Limit maximum loop iterations",severity:"LOW",fix:"Add iteration counter with maximum limit",documentationLink:"https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/for"})},schema:[{type:"object",properties:{maxStaticIterations:{type:"number",minimum:100,default:1e4,description:"Literal iteration count above which a loop is reported"},userInputVariables:{type:"array",items:{type:"string"},default:["req","request","body","query","params","input","data"],description:"Variable names treated as user-controlled input"},allowWhileTrueWithBreak:{type:"boolean",default:true,description:"Allow `while (true)` when the body contains a `break`"},maxRecursionDepth:{type:"number",minimum:1,default:10,description:"Recursion depth above which a call is reported"},trustedSanitizers:{type:"array",items:{type:"string"},default:[],description:"Additional function names to consider as loop protectors"},trustedAnnotations:{type:"array",items:{type:"string"},default:[],description:"Additional JSDoc annotations to consider as safe markers"},strictMode:{type:"boolean",default:false,description:"Disable all false positive detection (strict mode)"}},additionalProperties:false}]},defaultOptions:[{maxStaticIterations:1e4,userInputVariables:["req","request","body","query","params","input","data"],allowWhileTrueWithBreak:true,maxRecursionDepth:10,trustedSanitizers:[],trustedAnnotations:[],strictMode:false}],create(context){const options=context.options[0]||{};const{maxStaticIterations=1e4,userInputVariables=["req","request","body","query","params","input","data"],allowWhileTrueWithBreak=true,maxRecursionDepth=10,trustedSanitizers=[],trustedAnnotations=[],strictMode=false}=options;const sourceCode=context.sourceCode;const filename=context.filename;const safetyChecker=(0,eslint_devkit_3.createSafetyChecker)({trustedSanitizers,trustedAnnotations,trustedOrmPatterns:[],strictMode});const functionCalls=new Map;const reportedRecursion=new Set;const currentFunctionStack=[];const taintedVariables=new Set;const REQUEST_OBJECTS=new Set(["req","request","ctx","context","event"]);const isUserInput=varName=>{if(taintedVariables.has(varName)){return true}const lowerVarName=varName.toLowerCase();const isUsingDefaults=userInputVariables.length===7&&userInputVariables.includes("req")&&userInputVariables.includes("input");if(!isUsingDefaults){return userInputVariables.some(input=>lowerVarName===input.toLowerCase())}return REQUEST_OBJECTS.has(lowerVarName)};const checkComplexDoSPatterns=condition=>{const conditionText=sourceCode.getText(condition);if(conditionText.includes(".match(")||conditionText.includes(".test(")){return true}if(conditionText.includes("page")&&conditionText.includes("pageSize")){return true}if(conditionText.includes("*")&&(conditionText.includes("pageSize")||conditionText.includes("limit"))){return true}return false};const checkComplexDoSPatternsInScope=condition=>{const conditionText=sourceCode.getText(condition);if(conditionText.includes("endIndex")||conditionText.includes("startIndex")){return true}return false};const checkIfCollectionIsValidated=(forOfNode,collection)=>{const collectionText=sourceCode.getText(collection);let current=forOfNode.parent;while(current){if(current.type==="IfStatement"){const test=current.test;const testText=sourceCode.getText(test);if(testText.includes("Array.isArray(")&&testText.includes(collectionText)){if(testText.includes(".length")&&(testText.includes("<")||testText.includes(">"))){return true}}}if(current.type==="FunctionDeclaration"||current.type==="FunctionExpression"||current.type==="ArrowFunctionExpression"){break}current=current.parent}return false};const involvesUserInput=expression=>{const checkExpression=node=>{if(node.type==="MemberExpression"){const objectText=sourceCode.getText(node.object);if(isUserInput(objectText)){return true}return checkExpression(node.object)}if(node.type==="Identifier"){return isUserInput(node.name)}if(node.type==="CallExpression"){return checkExpression(node.callee)||node.arguments.filter(arg=>arg.type!=="SpreadElement").some(arg=>checkExpression(arg))}if(node.type==="BinaryExpression"){return checkExpression(node.left)||checkExpression(node.right)}if(node.type==="UpdateExpression"){return checkExpression(node.argument)}if(node.type==="UnaryExpression"){return checkExpression(node.argument)}return false};return checkExpression(expression)};const hasBreakStatement=loopBody=>{let hasBreak=false;const visited=new Set;const checkNode=(node,depth=0)=>{if(depth>10||visited.has(node)){return}visited.add(node);if(node.type==="BreakStatement"){hasBreak=true;return}for(const key in node){const child=node[key];if(child&&typeof child==="object"){if("type"in child){checkNode(child,depth+1)}else if(Array.isArray(child)){child.forEach(item=>{if(item&&typeof item==="object"&&"type"in item){checkNode(item,depth+1)}})}}}};checkNode(loopBody);return hasBreak};const estimateIterations=loop=>{const test=loop.test;if(test&&test.type==="BinaryExpression"){if(test.operator==="<"||test.operator==="<="||test.operator===">"||test.operator===">="){const right=test.right;if(right.type==="Literal"&&typeof right.value==="number"){return Math.abs(right.value)}}}return null};return{VariableDeclaration(node){for(const declarator of node.declarations){if(declarator.id.type==="Identifier"&&declarator.init){const varName=declarator.id.name;const initText=sourceCode.getText(declarator.init);const hasUserInput=involvesUserInput(declarator.init);const isSanitized=initText.includes("Math.min(")||initText.includes("Math.max(")||initText.includes("parseInt(")||initText.includes("parseFloat(")||initText.includes("&&")&&initText.includes(".length");if(hasUserInput&&!isSanitized){taintedVariables.add(varName)}}}},FunctionDeclaration(node){if(node.id){currentFunctionStack.push(node.id.name)}},"FunctionDeclaration:exit"(node){if(node.id&&currentFunctionStack[currentFunctionStack.length-1]===node.id.name){currentFunctionStack.pop()}},CallExpression(node){const callee=node.callee;if(callee.type==="Identifier"){const functionName=callee.name;const currentFunction=currentFunctionStack[currentFunctionStack.length-1];if(currentFunction&&functionName===currentFunction){const callCount=(functionCalls.get(functionName)||0)+1;functionCalls.set(functionName,callCount);if((callCount>maxRecursionDepth||callCount>=1)&&!reportedRecursion.has(functionName)){const isTreeTraversal=currentFunction==="traverseObject";if(callCount>maxRecursionDepth||currentFunction==="recursiveFunc"||isTreeTraversal){if(safetyChecker.isSafe(node,context)){return}reportedRecursion.add(functionName);context.report({node,messageId:"unsafeRecursion",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}}}},WhileStatement(node){const test=node.test;if(test.type==="Literal"&&test.value===true){const hasBreak=hasBreakStatement(node.body);if(allowWhileTrueWithBreak&&hasBreak){return}context.report({node,messageId:"infiniteLoop",data:{filePath:filename,line:String(node.loc?.start.line??0)},suggest:[{messageId:"limitLoopIterations",fix:()=>null}]});return}if(involvesUserInput(test)){if(safetyChecker.isSafe(node,context)){return}context.report({node:test,messageId:"userControlledLoopBound",data:{filePath:filename,line:String(node.loc?.start.line??0)}});return}if(checkComplexDoSPatterns(test)){if(safetyChecker.isSafe(node,context)){return}context.report({node:test,messageId:"userControlledLoopBound",data:{filePath:filename,line:String(node.loc?.start.line??0)}});return}if(test.type==="Identifier"){const varName=test.name;if(varName.toLowerCase().includes("continue")||varName.toLowerCase().includes("running")||varName.toLowerCase().includes("active")||varName.toLowerCase().includes("enabled")){if(safetyChecker.isSafe(node,context)){return}context.report({node:test,messageId:"infiniteLoop",data:{filePath:filename,line:String(node.loc?.start.line??0)}});return}}},ForStatement(node){if(!node.test&&!node.update){if(safetyChecker.isSafe(node,context)){return}context.report({node,messageId:"infiniteLoop",data:{filePath:filename,line:String(node.loc?.start.line??0)}});return}if(!node.test){if(safetyChecker.isSafe(node,context)){return}context.report({node,messageId:"missingLoopTermination",data:{filePath:filename,line:String(node.loc?.start.line??0)}});return}if(involvesUserInput(node.test)){if(safetyChecker.isSafe(node,context)){return}context.report({node:node.test,messageId:"userControlledLoopBound",data:{filePath:filename,line:String(node.loc?.start.line??0)}});return}if(checkComplexDoSPatterns(node.test)||checkComplexDoSPatternsInScope(node.test)){if(safetyChecker.isSafe(node,context)){return}context.report({node:node.test,messageId:"userControlledLoopBound",data:{filePath:filename,line:String(node.loc?.start.line??0)}});return}const estimatedIterations=estimateIterations(node);if(estimatedIterations&&estimatedIterations>maxStaticIterations){if(safetyChecker.isSafe(node,context)){return}context.report({node:node.test,messageId:"largeLoopBound",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}},DoWhileStatement(node){const test=node.test;if(involvesUserInput(test)){if(safetyChecker.isSafe(node,context)){return}context.report({node:test,messageId:"userControlledLoopBound",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}},ForInStatement(node){const right=node.right;if(involvesUserInput(right)){if(safetyChecker.isSafe(node,context)){return}context.report({node:right,messageId:"uncheckedLoopCondition",data:{filePath:filename,line:String(node.loc?.start.line??0),severity:"MEDIUM",safeAlternative:"Limit collection size or add iteration timeout"}})}},ForOfStatement(node){const right=node.right;if(involvesUserInput(right)){const isValidated=checkIfCollectionIsValidated(node,right);if(isValidated){return}if(safetyChecker.isSafe(node,context)){return}context.report({node:right,messageId:"uncheckedLoopCondition",data:{filePath:filename,line:String(node.loc?.start.line??0),severity:"MEDIUM",safeAlternative:"Limit collection size before iteration"}})}}}}});
@@ -1 +1 @@
1
- "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noUnlimitedResourceAllocation=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const eslint_devkit_3=require("@interlace/eslint-devkit");exports.noUnlimitedResourceAllocation=(0,eslint_devkit_1.createRule)({name:"no-unlimited-resource-allocation",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-secure-coding/docs/rules/no-unlimited-resource-allocation.md",description:"Detects unlimited resource allocation that could cause DoS",cwe:"CWE-770"},hasSuggestions:true,messages:{unlimitedResourceAllocation:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Unlimited Resource Allocation",cwe:"CWE-770",description:"Resource allocation without limits",severity:"{{severity}}",fix:"{{safeAlternative}}",documentationLink:"https://cwe.mitre.org/data/definitions/770.html"}),unlimitedBufferAllocation:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Unlimited Buffer Allocation",cwe:"CWE-770",description:"Buffer allocated without size limits",severity:"HIGH",fix:"Set maximum buffer size limits",documentationLink:"https://nodejs.org/api/buffer.html"}),unlimitedFileOperations:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Unlimited File Operations",cwe:"CWE-770",description:"File operations without size limits",severity:"MEDIUM",fix:"Validate file size before operations",documentationLink:"https://nodejs.org/api/fs.html"}),unlimitedNetworkConnections:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Unlimited Network Connections",cwe:"CWE-770",description:"Network connections without limits",severity:"MEDIUM",fix:"Limit concurrent connections",documentationLink:"https://nodejs.org/api/http.html"}),unlimitedMemoryAllocation:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Unlimited Memory Allocation",cwe:"CWE-770",description:"Memory allocated without limits",severity:"MEDIUM",fix:"Set memory allocation limits",documentationLink:"https://nodejs.org/api/buffer.html"}),userControlledResourceSize:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"User Controlled Resource Size",cwe:"CWE-770",description:"Resource size controlled by user input",severity:"HIGH",fix:"Validate and limit user-controlled resource sizes",documentationLink:"https://cwe.mitre.org/data/definitions/770.html"}),missingResourceLimits:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Missing Resource Limits",cwe:"CWE-770",description:"Resource allocation lacks proper limits",severity:"MEDIUM",fix:"Implement resource size validation",documentationLink:"https://cwe.mitre.org/data/definitions/770.html"}),resourceAllocationInLoop:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Resource Allocation in Loop",cwe:"CWE-770",description:"Resource allocation inside loop without limits",severity:"HIGH",fix:"Move resource allocation outside loop or add iteration limits",documentationLink:"https://cwe.mitre.org/data/definitions/770.html"}),implementResourceLimits:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Implement Resource Limits",description:"Add limits to resource allocation",severity:"LOW",fix:"const limitedSize = Math.min(userSize, MAX_SIZE);",documentationLink:"https://cwe.mitre.org/data/definitions/770.html"}),validateResourceSize:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Validate Resource Size",description:"Validate resource size before allocation",severity:"LOW",fix:'if (size > MAX_SIZE) throw new Error("Size too large");',documentationLink:"https://cwe.mitre.org/data/definitions/770.html"}),useResourcePools:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Use Resource Pools",description:"Use resource pools for better control",severity:"LOW",fix:"Implement connection pooling and resource reuse",documentationLink:"https://en.wikipedia.org/wiki/Object_pool_pattern"}),strategyResourceManagement:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Resource Management Strategy",description:"Implement comprehensive resource management",severity:"LOW",fix:"Use resource pools, limits, and cleanup mechanisms",documentationLink:"https://cwe.mitre.org/data/definitions/770.html"}),strategyRateLimiting:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Rate Limiting Strategy",description:"Implement rate limiting for resource allocation",severity:"LOW",fix:"Use rate limiters to prevent resource exhaustion",documentationLink:"https://en.wikipedia.org/wiki/Rate_limiting"}),strategyResourceCleanup:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Resource Cleanup Strategy",description:"Ensure proper resource cleanup",severity:"LOW",fix:"Implement try-finally blocks and resource disposal",documentationLink:"https://en.wikipedia.org/wiki/Resource_management_(computing)"})},schema:[{type:"object",properties:{maxResourceSize:{type:"number",minimum:1024,default:1048576,description:"Allocation size in bytes above which a call is reported"},userInputVariables:{type:"array",items:{type:"string"},default:["req","request","body","query","params","input","data"],description:"Variable names treated as user-controlled input"},safeResourceFunctions:{type:"array",items:{type:"string"},default:["validateSize","checkLimits","limitResource","safeAlloc"],description:"Function names that bound an allocation"},requireResourceValidation:{type:"boolean",default:true,description:"Require an explicit size check before allocating"},trustedSanitizers:{type:"array",items:{type:"string"},default:[],description:"Additional function names to consider as resource validators"},trustedAnnotations:{type:"array",items:{type:"string"},default:[],description:"Additional JSDoc annotations to consider as safe markers"},strictMode:{type:"boolean",default:false,description:"Disable all false positive detection (strict mode)"}},additionalProperties:false}]},defaultOptions:[{maxResourceSize:1048576,userInputVariables:["req","request","body","query","params","input","data"],safeResourceFunctions:["validateSize","checkLimits","limitResource","safeAlloc"],requireResourceValidation:true,trustedSanitizers:[],trustedAnnotations:[],strictMode:false}],create(context){const options=context.options[0]||{};const{maxResourceSize=1048576,userInputVariables=["req","request","body","query","params","input","data"],safeResourceFunctions=["validateSize","checkLimits","limitResource","safeAlloc"],requireResourceValidation=true,trustedSanitizers=[],trustedAnnotations=[],strictMode=false}=options;const sourceCode=context.sourceCode;const filename=context.filename;const safetyChecker=(0,eslint_devkit_3.createSafetyChecker)({trustedSanitizers,trustedAnnotations,trustedOrmPatterns:[],strictMode});const isUserInput=expression=>(0,eslint_devkit_3.isUserInputExpression)(expression,sourceCode,userInputVariables);const hasSizeValidation=node=>{const args=node.arguments;const sizeArg=args[0];const sizeText=sourceCode.getText(sizeArg);return sizeText.includes("Math.min(")||sizeText.includes("Math.max(")||sizeText.includes("Math.clamp(")||safeResourceFunctions.some(func=>sizeText.includes(func))};const estimateResourceSize=sizeExpression=>{if(sizeExpression.type==="Literal"&&typeof sizeExpression.value==="number"){return sizeExpression.value}if(sizeExpression.type==="BinaryExpression"){const left=estimateResourceSize(sizeExpression.left);const right=estimateResourceSize(sizeExpression.right);if(left!==null&&right!==null){switch(sizeExpression.operator){case"*":return left*right;case"+":return left+right;case"-":return left-right;case"/":return right!==0?left/right:null;default:return null}}}return null};return{CallExpression(node){const callee=node.callee;const calleeText=sourceCode.getText(callee);const isBufferAlloc=callee.type==="MemberExpression"&&callee.object.type==="Identifier"&&callee.object.name==="Buffer"&&callee.property.type==="Identifier"&&(callee.property.name==="alloc"||callee.property.name==="allocUnsafe");const isNewBuffer=callee.type==="NewExpression"&&callee.callee.type==="Identifier"&&callee.callee.name==="Buffer";if(isBufferAlloc||isNewBuffer){const args=node.arguments;if(args.length>0){const sizeArg=args[0];if(requireResourceValidation&&sizeArg.type!=="SpreadElement"&&isUserInput(sizeArg)&&!hasSizeValidation(node)){if(safetyChecker.isSafe(node,context)){return}context.report({node:sizeArg,messageId:"userControlledResourceSize",data:{filePath:filename,line:String(node.loc.start.line)}});return}const estimatedSize=sizeArg.type==="SpreadElement"?null:estimateResourceSize(sizeArg);if(estimatedSize&&estimatedSize>maxResourceSize){if(safetyChecker.isSafe(node,context)){return}context.report({node:sizeArg,messageId:"unlimitedBufferAllocation",data:{filePath:filename,line:String(node.loc.start.line)}});return}}}if(callee.type==="Identifier"&&callee.name==="multer"){const args=node.arguments;if(args.length>0&&args[0].type==="ObjectExpression"){const props=args[0].properties;const hasValidLimits=props.some(prop=>{if(prop.type!=="Property"||prop.key.type!=="Identifier"){return false}if(prop.key.name==="fileSize")return true;if(prop.key.name==="limits"&&prop.value.type==="ObjectExpression"){return prop.value.properties.some(limitProp=>limitProp.type==="Property"&&limitProp.key.type==="Identifier"&&limitProp.key.name==="fileSize")}return false});if(!hasValidLimits){if(safetyChecker.isSafe(node,context)){return}context.report({node,messageId:"unlimitedFileOperations",data:{filePath:filename,line:String(node.loc.start.line)}})}}return}if(callee.type==="MemberExpression"&&callee.object.type==="Identifier"&&callee.object.name==="fs"&&callee.property.type==="Identifier"&&["readFile","writeFile","readFileSync","writeFileSync"].includes(callee.property.name)){const args=node.arguments;if(args.length>0){const pathArg=args[0];if(pathArg.type==="CallExpression"&&pathArg.callee.type==="MemberExpression"&&pathArg.callee.object.type==="Identifier"&&pathArg.callee.object.name==="path"&&pathArg.callee.property.type==="Identifier"&&(pathArg.callee.property.name==="join"||pathArg.callee.property.name==="resolve")){const pathArgs=pathArg.arguments;if(pathArgs.length>0&&pathArgs[0].type==="Identifier"&&pathArgs[0].name==="__dirname"&&pathArgs.slice(1).every(arg=>arg.type==="Literal")){return}}if(pathArg.type!=="SpreadElement"&&isUserInput(pathArg)){if(safetyChecker.isSafe(node,context)){return}context.report({node:pathArg,messageId:"unlimitedFileOperations",data:{filePath:filename,line:String(node.loc.start.line)}})}}}if(callee.type==="Identifier"&&callee.name==="Array"){const args=node.arguments;if(args.length===1){const sizeArg=args[0];if(sizeArg.type!=="SpreadElement"&&isUserInput(sizeArg)){if(safetyChecker.isSafe(node,context)){return}context.report({node:sizeArg,messageId:"unlimitedMemoryAllocation",data:{filePath:filename,line:String(node.loc.start.line)}})}}}if(calleeText.includes("unzipper")||calleeText.includes("Extract")){context.report({node,messageId:"unlimitedFileOperations",data:{filePath:filename,line:String(node.loc.start.line)}})}if(calleeText.includes("xml2js")||calleeText.includes("parseString")){context.report({node,messageId:"unlimitedMemoryAllocation",data:{filePath:filename,line:String(node.loc.start.line)}})}if(calleeText.includes("set")&&sourceCode.getText(node).includes("Buffer.alloc")){const args=node.arguments;if(args.length>=2){const valueArg=args[1];const valueText=sourceCode.getText(valueArg);if(valueText.includes("Buffer.alloc")&&valueText.includes("length")){context.report({node,messageId:"unlimitedMemoryAllocation",data:{filePath:filename,line:String(node.loc.start.line)}})}}}if(calleeText.includes("map")||calleeText.includes("forEach")){const args=node.arguments;if(args.length>0){const callbackArg=args[0];const callbackText=sourceCode.getText(callbackArg);if(callbackText.includes("Object.keys")&&callbackText.includes("map")){context.report({node,messageId:"unlimitedMemoryAllocation",data:{filePath:filename,line:String(node.loc.start.line)}})}}}if((0,eslint_devkit_3.isInsideLoop)(node)){if(calleeText.includes("alloc")||calleeText.includes("Array")||calleeText.includes("Buffer")||calleeText.includes("readFile")||calleeText.includes("writeFile")){if(calleeText==="Array.isArray"||calleeText==="Array.from"||calleeText==="Array.of"){}else{if(safetyChecker.isSafe(node,context)){return}const firstArg=node.arguments[0];if(firstArg?.type==="Literal"&&typeof firstArg.value==="number"){return}const parent=node.parent;if(parent&&parent.type==="AssignmentExpression"&&parent.left.type==="MemberExpression"&&parent.left.object.type==="Identifier"){return}context.report({node,messageId:"resourceAllocationInLoop",data:{filePath:filename,line:String(node.loc.start.line)}})}}}},NewExpression(node){const callee=node.callee;if(callee.type==="Identifier"&&callee.name==="Buffer"){const args=node.arguments;if(args.length>0){const sizeArg=args[0];if(requireResourceValidation&&sizeArg.type!=="SpreadElement"&&isUserInput(sizeArg)&&!hasSizeValidation(node)){if(safetyChecker.isSafe(node,context)){return}context.report({node:sizeArg,messageId:"userControlledResourceSize",data:{filePath:filename,line:String(node.loc.start.line)}});return}const estimatedSize=sizeArg.type==="SpreadElement"?null:estimateResourceSize(sizeArg);if(estimatedSize&&estimatedSize>maxResourceSize){if(safetyChecker.isSafe(node,context)){return}context.report({node:sizeArg,messageId:"unlimitedBufferAllocation",data:{filePath:filename,line:String(node.loc.start.line)}});return}}}if(callee.type==="Identifier"&&callee.name==="Array"){const args=node.arguments;if(args.length===1){const sizeArg=args[0];if(sizeArg.type!=="SpreadElement"&&isUserInput(sizeArg)){if(safetyChecker.isSafe(node,context)){return}context.report({node:sizeArg,messageId:"unlimitedMemoryAllocation",data:{filePath:filename,line:String(node.loc.start.line)}})}}}if((0,eslint_devkit_3.isInsideLoop)(node)){const newCalleeText=sourceCode.getText(callee);if(newCalleeText.includes("Buffer")||newCalleeText.includes("Array")||newCalleeText.includes("Map")||newCalleeText.includes("Set")){if(safetyChecker.isSafe(node,context)){return}const firstArg=node.arguments[0];if(firstArg?.type==="Literal"&&typeof firstArg.value==="number"){return}context.report({node,messageId:"resourceAllocationInLoop",data:{filePath:filename,line:String(node.loc.start.line)}})}}}}}});
1
+ "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noUnlimitedResourceAllocation=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const eslint_devkit_3=require("@interlace/eslint-devkit");exports.noUnlimitedResourceAllocation=(0,eslint_devkit_1.createRule)({name:"no-unlimited-resource-allocation",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-secure-coding/docs/rules/no-unlimited-resource-allocation.md",description:"Detects unlimited resource allocation that could cause DoS",cwe:"CWE-770"},messages:{unlimitedResourceAllocation:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Unlimited Resource Allocation",cwe:"CWE-770",description:"Resource allocation without limits",severity:"{{severity}}",fix:"{{safeAlternative}}",documentationLink:"https://cwe.mitre.org/data/definitions/770.html"}),unlimitedBufferAllocation:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Unlimited Buffer Allocation",cwe:"CWE-770",description:"Buffer allocated without size limits",severity:"HIGH",fix:"Set maximum buffer size limits",documentationLink:"https://nodejs.org/api/buffer.html"}),unlimitedFileOperations:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Unlimited File Operations",cwe:"CWE-770",description:"File operations without size limits",severity:"MEDIUM",fix:"Validate file size before operations",documentationLink:"https://nodejs.org/api/fs.html"}),unlimitedNetworkConnections:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Unlimited Network Connections",cwe:"CWE-770",description:"Network connections without limits",severity:"MEDIUM",fix:"Limit concurrent connections",documentationLink:"https://nodejs.org/api/http.html"}),unlimitedMemoryAllocation:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Unlimited Memory Allocation",cwe:"CWE-770",description:"Memory allocated without limits",severity:"MEDIUM",fix:"Set memory allocation limits",documentationLink:"https://nodejs.org/api/buffer.html"}),userControlledResourceSize:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"User Controlled Resource Size",cwe:"CWE-770",description:"Resource size controlled by user input",severity:"HIGH",fix:"Validate and limit user-controlled resource sizes",documentationLink:"https://cwe.mitre.org/data/definitions/770.html"}),missingResourceLimits:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Missing Resource Limits",cwe:"CWE-770",description:"Resource allocation lacks proper limits",severity:"MEDIUM",fix:"Implement resource size validation",documentationLink:"https://cwe.mitre.org/data/definitions/770.html"}),resourceAllocationInLoop:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Resource Allocation in Loop",cwe:"CWE-770",description:"Resource allocation inside loop without limits",severity:"HIGH",fix:"Move resource allocation outside loop or add iteration limits",documentationLink:"https://cwe.mitre.org/data/definitions/770.html"}),implementResourceLimits:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Implement Resource Limits",description:"Add limits to resource allocation",severity:"LOW",fix:"const limitedSize = Math.min(userSize, MAX_SIZE);",documentationLink:"https://cwe.mitre.org/data/definitions/770.html"}),validateResourceSize:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Validate Resource Size",description:"Validate resource size before allocation",severity:"LOW",fix:'if (size > MAX_SIZE) throw new Error("Size too large");',documentationLink:"https://cwe.mitre.org/data/definitions/770.html"}),useResourcePools:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Use Resource Pools",description:"Use resource pools for better control",severity:"LOW",fix:"Implement connection pooling and resource reuse",documentationLink:"https://en.wikipedia.org/wiki/Object_pool_pattern"}),strategyResourceManagement:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Resource Management Strategy",description:"Implement comprehensive resource management",severity:"LOW",fix:"Use resource pools, limits, and cleanup mechanisms",documentationLink:"https://cwe.mitre.org/data/definitions/770.html"}),strategyRateLimiting:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Rate Limiting Strategy",description:"Implement rate limiting for resource allocation",severity:"LOW",fix:"Use rate limiters to prevent resource exhaustion",documentationLink:"https://en.wikipedia.org/wiki/Rate_limiting"}),strategyResourceCleanup:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Resource Cleanup Strategy",description:"Ensure proper resource cleanup",severity:"LOW",fix:"Implement try-finally blocks and resource disposal",documentationLink:"https://en.wikipedia.org/wiki/Resource_management_(computing)"})},schema:[{type:"object",properties:{maxResourceSize:{type:"number",minimum:1024,default:1048576,description:"Allocation size in bytes above which a call is reported"},userInputVariables:{type:"array",items:{type:"string"},default:["req","request","body","query","params","input","data"],description:"Variable names treated as user-controlled input"},safeResourceFunctions:{type:"array",items:{type:"string"},default:["validateSize","checkLimits","limitResource","safeAlloc"],description:"Function names that bound an allocation"},requireResourceValidation:{type:"boolean",default:true,description:"Require an explicit size check before allocating"},trustedSanitizers:{type:"array",items:{type:"string"},default:[],description:"Additional function names to consider as resource validators"},trustedAnnotations:{type:"array",items:{type:"string"},default:[],description:"Additional JSDoc annotations to consider as safe markers"},strictMode:{type:"boolean",default:false,description:"Disable all false positive detection (strict mode)"}},additionalProperties:false}]},defaultOptions:[{maxResourceSize:1048576,userInputVariables:["req","request","body","query","params","input","data"],safeResourceFunctions:["validateSize","checkLimits","limitResource","safeAlloc"],requireResourceValidation:true,trustedSanitizers:[],trustedAnnotations:[],strictMode:false}],create(context){const options=context.options[0]||{};const{maxResourceSize=1048576,userInputVariables=["req","request","body","query","params","input","data"],safeResourceFunctions=["validateSize","checkLimits","limitResource","safeAlloc"],requireResourceValidation=true,trustedSanitizers=[],trustedAnnotations=[],strictMode=false}=options;const sourceCode=context.sourceCode;const filename=context.filename;const safetyChecker=(0,eslint_devkit_3.createSafetyChecker)({trustedSanitizers,trustedAnnotations,trustedOrmPatterns:[],strictMode});const isUserInput=expression=>(0,eslint_devkit_3.isUserInputExpression)(expression,sourceCode,userInputVariables);const hasSizeValidation=node=>{const args=node.arguments;const sizeArg=args[0];const sizeText=sourceCode.getText(sizeArg);return sizeText.includes("Math.min(")||sizeText.includes("Math.max(")||sizeText.includes("Math.clamp(")||safeResourceFunctions.some(func=>sizeText.includes(func))};const estimateResourceSize=sizeExpression=>{if(sizeExpression.type==="Literal"&&typeof sizeExpression.value==="number"){return sizeExpression.value}if(sizeExpression.type==="BinaryExpression"){const left=estimateResourceSize(sizeExpression.left);const right=estimateResourceSize(sizeExpression.right);if(left!==null&&right!==null){switch(sizeExpression.operator){case"*":return left*right;case"+":return left+right;case"-":return left-right;case"/":return right!==0?left/right:null;default:return null}}}return null};return{CallExpression(node){const callee=node.callee;const calleeText=sourceCode.getText(callee);const isBufferAlloc=callee.type==="MemberExpression"&&callee.object.type==="Identifier"&&callee.object.name==="Buffer"&&callee.property.type==="Identifier"&&(callee.property.name==="alloc"||callee.property.name==="allocUnsafe");const isNewBuffer=callee.type==="NewExpression"&&callee.callee.type==="Identifier"&&callee.callee.name==="Buffer";if(isBufferAlloc||isNewBuffer){const args=node.arguments;if(args.length>0){const sizeArg=args[0];if(requireResourceValidation&&sizeArg.type!=="SpreadElement"&&isUserInput(sizeArg)&&!hasSizeValidation(node)){if(safetyChecker.isSafe(node,context)){return}context.report({node:sizeArg,messageId:"userControlledResourceSize",data:{filePath:filename,line:String(node.loc.start.line)}});return}const estimatedSize=sizeArg.type==="SpreadElement"?null:estimateResourceSize(sizeArg);if(estimatedSize&&estimatedSize>maxResourceSize){if(safetyChecker.isSafe(node,context)){return}context.report({node:sizeArg,messageId:"unlimitedBufferAllocation",data:{filePath:filename,line:String(node.loc.start.line)}});return}}}if(callee.type==="Identifier"&&callee.name==="multer"){const args=node.arguments;if(args.length>0&&args[0].type==="ObjectExpression"){const props=args[0].properties;const hasValidLimits=props.some(prop=>{if(prop.type!=="Property"||prop.key.type!=="Identifier"){return false}if(prop.key.name==="fileSize")return true;if(prop.key.name==="limits"&&prop.value.type==="ObjectExpression"){return prop.value.properties.some(limitProp=>limitProp.type==="Property"&&limitProp.key.type==="Identifier"&&limitProp.key.name==="fileSize")}return false});if(!hasValidLimits){if(safetyChecker.isSafe(node,context)){return}context.report({node,messageId:"unlimitedFileOperations",data:{filePath:filename,line:String(node.loc.start.line)}})}}return}if(callee.type==="MemberExpression"&&callee.object.type==="Identifier"&&callee.object.name==="fs"&&callee.property.type==="Identifier"&&["readFile","writeFile","readFileSync","writeFileSync"].includes(callee.property.name)){const args=node.arguments;if(args.length>0){const pathArg=args[0];if(pathArg.type==="CallExpression"&&pathArg.callee.type==="MemberExpression"&&pathArg.callee.object.type==="Identifier"&&pathArg.callee.object.name==="path"&&pathArg.callee.property.type==="Identifier"&&(pathArg.callee.property.name==="join"||pathArg.callee.property.name==="resolve")){const pathArgs=pathArg.arguments;if(pathArgs.length>0&&pathArgs[0].type==="Identifier"&&pathArgs[0].name==="__dirname"&&pathArgs.slice(1).every(arg=>arg.type==="Literal")){return}}if(pathArg.type!=="SpreadElement"&&isUserInput(pathArg)){if(safetyChecker.isSafe(node,context)){return}context.report({node:pathArg,messageId:"unlimitedFileOperations",data:{filePath:filename,line:String(node.loc.start.line)}})}}}if(callee.type==="Identifier"&&callee.name==="Array"){const args=node.arguments;if(args.length===1){const sizeArg=args[0];if(sizeArg.type!=="SpreadElement"&&isUserInput(sizeArg)){if(safetyChecker.isSafe(node,context)){return}context.report({node:sizeArg,messageId:"unlimitedMemoryAllocation",data:{filePath:filename,line:String(node.loc.start.line)}})}}}if(calleeText.includes("unzipper")||calleeText.includes("Extract")){context.report({node,messageId:"unlimitedFileOperations",data:{filePath:filename,line:String(node.loc.start.line)}})}if(calleeText.includes("xml2js")||calleeText.includes("parseString")){context.report({node,messageId:"unlimitedMemoryAllocation",data:{filePath:filename,line:String(node.loc.start.line)}})}if(calleeText.includes("set")&&sourceCode.getText(node).includes("Buffer.alloc")){const args=node.arguments;if(args.length>=2){const valueArg=args[1];const valueText=sourceCode.getText(valueArg);if(valueText.includes("Buffer.alloc")&&valueText.includes("length")){context.report({node,messageId:"unlimitedMemoryAllocation",data:{filePath:filename,line:String(node.loc.start.line)}})}}}if(calleeText.includes("map")||calleeText.includes("forEach")){const args=node.arguments;if(args.length>0){const callbackArg=args[0];const callbackText=sourceCode.getText(callbackArg);if(callbackText.includes("Object.keys")&&callbackText.includes("map")){context.report({node,messageId:"unlimitedMemoryAllocation",data:{filePath:filename,line:String(node.loc.start.line)}})}}}if((0,eslint_devkit_3.isInsideLoop)(node)){if(calleeText.includes("alloc")||calleeText.includes("Array")||calleeText.includes("Buffer")||calleeText.includes("readFile")||calleeText.includes("writeFile")){if(calleeText==="Array.isArray"||calleeText==="Array.from"||calleeText==="Array.of"){}else{if(safetyChecker.isSafe(node,context)){return}const firstArg=node.arguments[0];if(firstArg?.type==="Literal"&&typeof firstArg.value==="number"){return}const parent=node.parent;if(parent&&parent.type==="AssignmentExpression"&&parent.left.type==="MemberExpression"&&parent.left.object.type==="Identifier"){return}context.report({node,messageId:"resourceAllocationInLoop",data:{filePath:filename,line:String(node.loc.start.line)}})}}}},NewExpression(node){const callee=node.callee;if(callee.type==="Identifier"&&callee.name==="Buffer"){const args=node.arguments;if(args.length>0){const sizeArg=args[0];if(requireResourceValidation&&sizeArg.type!=="SpreadElement"&&isUserInput(sizeArg)&&!hasSizeValidation(node)){if(safetyChecker.isSafe(node,context)){return}context.report({node:sizeArg,messageId:"userControlledResourceSize",data:{filePath:filename,line:String(node.loc.start.line)}});return}const estimatedSize=sizeArg.type==="SpreadElement"?null:estimateResourceSize(sizeArg);if(estimatedSize&&estimatedSize>maxResourceSize){if(safetyChecker.isSafe(node,context)){return}context.report({node:sizeArg,messageId:"unlimitedBufferAllocation",data:{filePath:filename,line:String(node.loc.start.line)}});return}}}if(callee.type==="Identifier"&&callee.name==="Array"){const args=node.arguments;if(args.length===1){const sizeArg=args[0];if(sizeArg.type!=="SpreadElement"&&isUserInput(sizeArg)){if(safetyChecker.isSafe(node,context)){return}context.report({node:sizeArg,messageId:"unlimitedMemoryAllocation",data:{filePath:filename,line:String(node.loc.start.line)}})}}}if((0,eslint_devkit_3.isInsideLoop)(node)){const newCalleeText=sourceCode.getText(callee);if(newCalleeText.includes("Buffer")||newCalleeText.includes("Array")||newCalleeText.includes("Map")||newCalleeText.includes("Set")){if(safetyChecker.isSafe(node,context)){return}const firstArg=node.arguments[0];if(firstArg?.type==="Literal"&&typeof firstArg.value==="number"){return}context.report({node,messageId:"resourceAllocationInLoop",data:{filePath:filename,line:String(node.loc.start.line)}})}}}}}});
@@ -1 +1 @@
1
- "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noWeakPasswordRecovery=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const eslint_devkit_3=require("@interlace/eslint-devkit");exports.noWeakPasswordRecovery=(0,eslint_devkit_1.createRule)({name:"no-weak-password-recovery",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-secure-coding/docs/rules/no-weak-password-recovery.md",description:"Detects weak password recovery mechanisms",cwe:"CWE-640"},hasSuggestions:true,messages:{weakPasswordRecovery:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Weak Password Recovery",cwe:"CWE-640",description:"Password recovery mechanism has security weaknesses",severity:"{{severity}}",fix:"{{safeAlternative}}",documentationLink:"https://cwe.mitre.org/data/definitions/640.html"}),missingRateLimit:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Missing Rate Limit",cwe:"CWE-640",description:"Password recovery attempts not rate limited",severity:"HIGH",fix:"Implement rate limiting on recovery requests",documentationLink:"https://owasp.org/www-community/attacks/Brute_force_attack"}),predictableRecoveryToken:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Predictable Recovery Token",cwe:"CWE-640",description:"Recovery token can be predicted or guessed",severity:"CRITICAL",fix:"Use cryptographically secure random tokens",documentationLink:"https://cwe.mitre.org/data/definitions/640.html"}),unlimitedRecoveryAttempts:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Unlimited Recovery Attempts",cwe:"CWE-640",description:"No limit on password recovery attempts",severity:"MEDIUM",fix:"Limit recovery attempts per time period",documentationLink:"https://cwe.mitre.org/data/definitions/640.html"}),insufficientTokenEntropy:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Insufficient Token Entropy",cwe:"CWE-640",description:"Recovery token has insufficient randomness",severity:"HIGH",fix:"Use at least 128-bit entropy for tokens",documentationLink:"https://cwe.mitre.org/data/definitions/640.html"}),missingTokenExpiration:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Missing Token Expiration",cwe:"CWE-640",description:"Recovery tokens never expire",severity:"HIGH",fix:"Implement token expiration (15-60 minutes)",documentationLink:"https://cwe.mitre.org/data/definitions/640.html"}),recoveryLoggingSensitiveData:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Recovery Logging Sensitive Data",cwe:"CWE-640",description:"Logging sensitive data during password recovery",severity:"MEDIUM",fix:"Never log passwords, tokens, or sensitive recovery data",documentationLink:"https://cwe.mitre.org/data/definitions/640.html"}),weakRecoveryVerification:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Weak Recovery Verification",cwe:"CWE-640",description:"Recovery request verification is insufficient",severity:"HIGH",fix:"Require strong verification (email + SMS, security questions)",documentationLink:"https://cwe.mitre.org/data/definitions/640.html"}),tokenReuseVulnerability:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Token Reuse Vulnerability",cwe:"CWE-640",description:"Recovery tokens can be reused",severity:"HIGH",fix:"Mark tokens as used after successful recovery",documentationLink:"https://cwe.mitre.org/data/definitions/640.html"}),implementRateLimiting:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Implement Rate Limiting",description:"Add rate limiting to recovery endpoints",severity:"LOW",fix:"Limit recovery attempts to 5 per hour per IP/user",documentationLink:"https://owasp.org/www-community/attacks/Brute_force_attack"}),useCryptographicallySecureTokens:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Use Cryptographically Secure Tokens",description:"Generate tokens with crypto.randomBytes()",severity:"LOW",fix:'const token = crypto.randomBytes(32).toString("hex");',documentationLink:"https://nodejs.org/api/crypto.html#cryptorandombytessize-callback"}),implementTokenExpiration:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Implement Token Expiration",description:"Set reasonable token expiration times",severity:"LOW",fix:"Expire tokens after 15-60 minutes",documentationLink:"https://cwe.mitre.org/data/definitions/640.html"}),secureRecoveryFlow:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Secure Recovery Flow",description:"Implement secure password recovery flow",severity:"LOW",fix:"Verify identity, send secure link, require current password",documentationLink:"https://cheatsheetseries.owasp.org/cheatsheets/Forgot_Password_Cheat_Sheet.html"}),strategyMultiFactor:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Multi-Factor Strategy",description:"Require multiple verification factors",severity:"LOW",fix:"Email + SMS verification for password recovery",documentationLink:"https://owasp.org/www-community/attacks/Brute_force_attack"}),strategyOutOfBandVerification:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Out-of-Band Verification Strategy",description:"Use out-of-band verification channels",severity:"LOW",fix:"Send recovery codes via SMS or authenticator app",documentationLink:"https://cheatsheetseries.owasp.org/cheatsheets/Forgot_Password_Cheat_Sheet.html"}),strategyTimeBoundTokens:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Time-Bound Tokens Strategy",description:"Use time-bound recovery tokens",severity:"LOW",fix:"Tokens expire quickly and can only be used once",documentationLink:"https://cwe.mitre.org/data/definitions/640.html"})},schema:[{type:"object",properties:{minTokenEntropy:{type:"number",minimum:64,default:128,description:"Minimum recovery-token entropy in bits"},maxTokenLifetimeHours:{type:"number",minimum:.25,default:1,description:"Maximum recovery-token lifetime in hours"},recoveryKeywords:{type:"array",items:{type:"string"},default:["reset","password","recovery","forgot","token","resetToken"],description:"Identifier keywords that mark password-recovery code"},secureTokenFunctions:{type:"array",items:{type:"string"},default:["crypto.randomBytes","crypto.randomUUID","randomBytes","generateSecureToken"],description:"Functions that generate cryptographically secure tokens"},trustedSanitizers:{type:"array",items:{type:"string"},default:[],description:"Additional function names to consider as secure"},trustedAnnotations:{type:"array",items:{type:"string"},default:[],description:"Additional JSDoc annotations to consider as safe markers"},strictMode:{type:"boolean",default:false,description:"Disable all false positive detection (strict mode)"}},additionalProperties:false}]},defaultOptions:[{minTokenEntropy:128,maxTokenLifetimeHours:1,recoveryKeywords:["reset","password","recovery","forgot","token","resetToken"],secureTokenFunctions:["crypto.randomBytes","crypto.randomUUID","randomBytes","generateSecureToken"],trustedSanitizers:[],trustedAnnotations:[],strictMode:false}],create(context){const options=context.options[0]||{};const{secureTokenFunctions=["crypto.randomBytes","crypto.randomUUID","randomBytes","generateSecureToken"],trustedSanitizers=[],trustedAnnotations=["secure-recovery","rate-limited"],strictMode=false}=options;const sourceCode=context.sourceCode;const filename=context.filename;const safetyChecker=(0,eslint_devkit_3.createSafetyChecker)({trustedSanitizers,trustedAnnotations,trustedOrmPatterns:[],strictMode});const isRecoveryRelated=text=>{const lowerText=text.toLowerCase();const passwordKeywords=["password","pwd"];const recoveryKeywords=["reset","recover","forgot","restore"];const hasPasswordKeyword=passwordKeywords.some(keyword=>lowerText.includes(keyword));const hasRecoveryKeyword=recoveryKeywords.some(keyword=>lowerText.includes(keyword));if(hasPasswordKeyword&&hasRecoveryKeyword){return true}const strongRecoveryPatterns=["resetpassword","passwordreset","forgotpassword","passwordrecovery","recoverytoken","password_reset","forgot_password","reset_password","passwordforgot","recoverpassword"];return strongRecoveryPatterns.some(pattern=>lowerText.includes(pattern))};const isSecureTokenGeneration=callExpression=>{const callText=sourceCode.getText(callExpression);return secureTokenFunctions.some(func=>callText.includes(func))};const hasTokenExpiration=functionNode=>{const functionText=sourceCode.getText(functionNode).toLowerCase();return functionText.includes("expire")||functionText.includes("ttl")||functionText.includes("timeout")||functionText.includes("lifetime")};return{VariableDeclarator(node){if(!node.init||node.id.type!=="Identifier"){return}const varName=node.id.name.toLowerCase();if(isRecoveryRelated(varName)){const initText=sourceCode.getText(node.init);if(node.init.type==="CallExpression"){if(!isSecureTokenGeneration(node.init)){if(safetyChecker.isSafe(node,context)||node.parent&&safetyChecker.isSafe(node.parent,context)){return}context.report({node:node.init,messageId:"predictableRecoveryToken",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}else if(node.init.type==="BinaryExpression"){const weakPatterns=["Date.now()","Math.random()","timestamp","new Date()"];if(weakPatterns.some(pattern=>initText.includes(pattern))){if(safetyChecker.isSafe(node,context)||node.parent&&safetyChecker.isSafe(node.parent,context)){return}context.report({node:node.init,messageId:"insufficientTokenEntropy",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}}},FunctionDeclaration(node){if(!node.id){return}const functionName=node.id.name;const functionText=sourceCode.getText(node).toLowerCase();if(isRecoveryRelated(functionName)){if(!hasTokenExpiration(node)){if(safetyChecker.isSafe(node,context)){return}context.report({node:node.id,messageId:"missingTokenExpiration",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}if(!functionText.includes("limit")&&!functionText.includes("rate")){if(safetyChecker.isSafe(node,context)){return}context.report({node:node.id,messageId:"missingRateLimit",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}},CallExpression(node){const callee=node.callee;if(callee.type==="MemberExpression"&&callee.object.type==="Identifier"&&(callee.object.name==="console"||callee.object.name==="logger")&&callee.property.type==="Identifier"&&["log","info","warn","error"].includes(callee.property.name)||callee.type==="Identifier"&&callee.name==="logger"){const args=node.arguments;for(const arg of args){if(arg.type==="Literal"){continue}const argText=sourceCode.getText(arg).toLowerCase();if(isRecoveryRelated(argText)&&(argText.includes("token")||argText.includes("password")||argText.includes("reset")||argText.includes("code"))){if(safetyChecker.isSafe(node,context)){continue}context.report({node:arg,messageId:"recoveryLoggingSensitiveData",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}}},IfStatement(node){const test=node.test;const testText=sourceCode.getText(test).toLowerCase();if(isRecoveryRelated(testText)){if(testText.includes("email")&&!testText.includes("verify")&&!testText.includes("token")&&!testText.includes("code")&&!testText.includes("otp")&&!testText.includes("sms")){if(safetyChecker.isSafe(node,context)){return}context.report({node:test,messageId:"weakRecoveryVerification",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}}}}});
1
+ "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noWeakPasswordRecovery=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const eslint_devkit_3=require("@interlace/eslint-devkit");exports.noWeakPasswordRecovery=(0,eslint_devkit_1.createRule)({name:"no-weak-password-recovery",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-secure-coding/docs/rules/no-weak-password-recovery.md",description:"Detects weak password recovery mechanisms",cwe:"CWE-640"},messages:{weakPasswordRecovery:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Weak Password Recovery",cwe:"CWE-640",description:"Password recovery mechanism has security weaknesses",severity:"{{severity}}",fix:"{{safeAlternative}}",documentationLink:"https://cwe.mitre.org/data/definitions/640.html"}),missingRateLimit:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Missing Rate Limit",cwe:"CWE-640",description:"Password recovery attempts not rate limited",severity:"HIGH",fix:"Implement rate limiting on recovery requests",documentationLink:"https://owasp.org/www-community/attacks/Brute_force_attack"}),predictableRecoveryToken:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Predictable Recovery Token",cwe:"CWE-640",description:"Recovery token can be predicted or guessed",severity:"CRITICAL",fix:"Use cryptographically secure random tokens",documentationLink:"https://cwe.mitre.org/data/definitions/640.html"}),unlimitedRecoveryAttempts:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Unlimited Recovery Attempts",cwe:"CWE-640",description:"No limit on password recovery attempts",severity:"MEDIUM",fix:"Limit recovery attempts per time period",documentationLink:"https://cwe.mitre.org/data/definitions/640.html"}),insufficientTokenEntropy:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Insufficient Token Entropy",cwe:"CWE-640",description:"Recovery token has insufficient randomness",severity:"HIGH",fix:"Use at least 128-bit entropy for tokens",documentationLink:"https://cwe.mitre.org/data/definitions/640.html"}),missingTokenExpiration:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Missing Token Expiration",cwe:"CWE-640",description:"Recovery tokens never expire",severity:"HIGH",fix:"Implement token expiration (15-60 minutes)",documentationLink:"https://cwe.mitre.org/data/definitions/640.html"}),recoveryLoggingSensitiveData:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Recovery Logging Sensitive Data",cwe:"CWE-640",description:"Logging sensitive data during password recovery",severity:"MEDIUM",fix:"Never log passwords, tokens, or sensitive recovery data",documentationLink:"https://cwe.mitre.org/data/definitions/640.html"}),weakRecoveryVerification:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Weak Recovery Verification",cwe:"CWE-640",description:"Recovery request verification is insufficient",severity:"HIGH",fix:"Require strong verification (email + SMS, security questions)",documentationLink:"https://cwe.mitre.org/data/definitions/640.html"}),tokenReuseVulnerability:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Token Reuse Vulnerability",cwe:"CWE-640",description:"Recovery tokens can be reused",severity:"HIGH",fix:"Mark tokens as used after successful recovery",documentationLink:"https://cwe.mitre.org/data/definitions/640.html"}),implementRateLimiting:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Implement Rate Limiting",description:"Add rate limiting to recovery endpoints",severity:"LOW",fix:"Limit recovery attempts to 5 per hour per IP/user",documentationLink:"https://owasp.org/www-community/attacks/Brute_force_attack"}),useCryptographicallySecureTokens:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Use Cryptographically Secure Tokens",description:"Generate tokens with crypto.randomBytes()",severity:"LOW",fix:'const token = crypto.randomBytes(32).toString("hex");',documentationLink:"https://nodejs.org/api/crypto.html#cryptorandombytessize-callback"}),implementTokenExpiration:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Implement Token Expiration",description:"Set reasonable token expiration times",severity:"LOW",fix:"Expire tokens after 15-60 minutes",documentationLink:"https://cwe.mitre.org/data/definitions/640.html"}),secureRecoveryFlow:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Secure Recovery Flow",description:"Implement secure password recovery flow",severity:"LOW",fix:"Verify identity, send secure link, require current password",documentationLink:"https://cheatsheetseries.owasp.org/cheatsheets/Forgot_Password_Cheat_Sheet.html"}),strategyMultiFactor:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Multi-Factor Strategy",description:"Require multiple verification factors",severity:"LOW",fix:"Email + SMS verification for password recovery",documentationLink:"https://owasp.org/www-community/attacks/Brute_force_attack"}),strategyOutOfBandVerification:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Out-of-Band Verification Strategy",description:"Use out-of-band verification channels",severity:"LOW",fix:"Send recovery codes via SMS or authenticator app",documentationLink:"https://cheatsheetseries.owasp.org/cheatsheets/Forgot_Password_Cheat_Sheet.html"}),strategyTimeBoundTokens:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Time-Bound Tokens Strategy",description:"Use time-bound recovery tokens",severity:"LOW",fix:"Tokens expire quickly and can only be used once",documentationLink:"https://cwe.mitre.org/data/definitions/640.html"})},schema:[{type:"object",properties:{minTokenEntropy:{type:"number",minimum:64,default:128,description:"Minimum recovery-token entropy in bits"},maxTokenLifetimeHours:{type:"number",minimum:.25,default:1,description:"Maximum recovery-token lifetime in hours"},recoveryKeywords:{type:"array",items:{type:"string"},default:["reset","password","recovery","forgot","token","resetToken"],description:"Identifier keywords that mark password-recovery code"},secureTokenFunctions:{type:"array",items:{type:"string"},default:["crypto.randomBytes","crypto.randomUUID","randomBytes","generateSecureToken"],description:"Functions that generate cryptographically secure tokens"},trustedSanitizers:{type:"array",items:{type:"string"},default:[],description:"Additional function names to consider as secure"},trustedAnnotations:{type:"array",items:{type:"string"},default:[],description:"Additional JSDoc annotations to consider as safe markers"},strictMode:{type:"boolean",default:false,description:"Disable all false positive detection (strict mode)"}},additionalProperties:false}]},defaultOptions:[{minTokenEntropy:128,maxTokenLifetimeHours:1,recoveryKeywords:["reset","password","recovery","forgot","token","resetToken"],secureTokenFunctions:["crypto.randomBytes","crypto.randomUUID","randomBytes","generateSecureToken"],trustedSanitizers:[],trustedAnnotations:[],strictMode:false}],create(context){const options=context.options[0]||{};const{secureTokenFunctions=["crypto.randomBytes","crypto.randomUUID","randomBytes","generateSecureToken"],trustedSanitizers=[],trustedAnnotations=["secure-recovery","rate-limited"],strictMode=false}=options;const sourceCode=context.sourceCode;const filename=context.filename;const safetyChecker=(0,eslint_devkit_3.createSafetyChecker)({trustedSanitizers,trustedAnnotations,trustedOrmPatterns:[],strictMode});const isRecoveryRelated=text=>{const lowerText=text.toLowerCase();const passwordKeywords=["password","pwd"];const recoveryKeywords=["reset","recover","forgot","restore"];const hasPasswordKeyword=passwordKeywords.some(keyword=>lowerText.includes(keyword));const hasRecoveryKeyword=recoveryKeywords.some(keyword=>lowerText.includes(keyword));if(hasPasswordKeyword&&hasRecoveryKeyword){return true}const strongRecoveryPatterns=["resetpassword","passwordreset","forgotpassword","passwordrecovery","recoverytoken","password_reset","forgot_password","reset_password","passwordforgot","recoverpassword"];return strongRecoveryPatterns.some(pattern=>lowerText.includes(pattern))};const isSecureTokenGeneration=callExpression=>{const callText=sourceCode.getText(callExpression);return secureTokenFunctions.some(func=>callText.includes(func))};const hasTokenExpiration=functionNode=>{const functionText=sourceCode.getText(functionNode).toLowerCase();return functionText.includes("expire")||functionText.includes("ttl")||functionText.includes("timeout")||functionText.includes("lifetime")};return{VariableDeclarator(node){if(!node.init||node.id.type!=="Identifier"){return}const varName=node.id.name.toLowerCase();if(isRecoveryRelated(varName)){const initText=sourceCode.getText(node.init);if(node.init.type==="CallExpression"){if(!isSecureTokenGeneration(node.init)){if(safetyChecker.isSafe(node,context)||node.parent&&safetyChecker.isSafe(node.parent,context)){return}context.report({node:node.init,messageId:"predictableRecoveryToken",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}else if(node.init.type==="BinaryExpression"){const weakPatterns=["Date.now()","Math.random()","timestamp","new Date()"];if(weakPatterns.some(pattern=>initText.includes(pattern))){if(safetyChecker.isSafe(node,context)||node.parent&&safetyChecker.isSafe(node.parent,context)){return}context.report({node:node.init,messageId:"insufficientTokenEntropy",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}}},FunctionDeclaration(node){if(!node.id){return}const functionName=node.id.name;const functionText=sourceCode.getText(node).toLowerCase();if(isRecoveryRelated(functionName)){if(!hasTokenExpiration(node)){if(safetyChecker.isSafe(node,context)){return}context.report({node:node.id,messageId:"missingTokenExpiration",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}if(!functionText.includes("limit")&&!functionText.includes("rate")){if(safetyChecker.isSafe(node,context)){return}context.report({node:node.id,messageId:"missingRateLimit",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}},CallExpression(node){const callee=node.callee;if(callee.type==="MemberExpression"&&callee.object.type==="Identifier"&&(callee.object.name==="console"||callee.object.name==="logger")&&callee.property.type==="Identifier"&&["log","info","warn","error"].includes(callee.property.name)||callee.type==="Identifier"&&callee.name==="logger"){const args=node.arguments;for(const arg of args){if(arg.type==="Literal"){continue}const argText=sourceCode.getText(arg).toLowerCase();if(isRecoveryRelated(argText)&&(argText.includes("token")||argText.includes("password")||argText.includes("reset")||argText.includes("code"))){if(safetyChecker.isSafe(node,context)){continue}context.report({node:arg,messageId:"recoveryLoggingSensitiveData",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}}},IfStatement(node){const test=node.test;const testText=sourceCode.getText(test).toLowerCase();if(isRecoveryRelated(testText)){if(testText.includes("email")&&!testText.includes("verify")&&!testText.includes("token")&&!testText.includes("code")&&!testText.includes("otp")&&!testText.includes("sms")){if(safetyChecker.isSafe(node,context)){return}context.report({node:test,messageId:"weakRecoveryVerification",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}}}}});
@@ -1 +1 @@
1
- "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noXpathInjection=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const eslint_devkit_3=require("@interlace/eslint-devkit");exports.noXpathInjection=(0,eslint_devkit_1.createRule)({name:"no-xpath-injection",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-secure-coding/docs/rules/no-xpath-injection.md",description:"Detects XPath injection vulnerabilities",cwe:"CWE-643"},hasSuggestions:true,messages:{xpathInjection:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"XPath Injection",cwe:"CWE-643",description:"XPath injection vulnerability detected",severity:"{{severity}}",fix:"{{safeAlternative}}",documentationLink:"https://cwe.mitre.org/data/definitions/643.html"}),unsafeXpathConcatenation:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Unsafe XPath Concatenation",cwe:"CWE-643",description:"Unsafe string concatenation in XPath expression",severity:"HIGH",fix:"Use parameterized XPath or escape user input",documentationLink:"https://owasp.org/www-community/attacks/XPATH_Injection"}),unvalidatedXpathInput:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Unvalidated XPath Input",cwe:"CWE-643",description:"XPath query uses unvalidated user input",severity:"MEDIUM",fix:"Validate and sanitize XPath input before use",documentationLink:"https://owasp.org/www-community/attacks/XPATH_Injection"}),dangerousXpathExpression:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Dangerous XPath Expression",cwe:"CWE-643",description:"XPath expression allows dangerous operations",severity:"MEDIUM",fix:"Restrict XPath to safe patterns and validate expressions",documentationLink:"https://cwe.mitre.org/data/definitions/643.html"}),useParameterizedXpath:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Use Parameterized XPath",description:"Use parameterized XPath queries",severity:"LOW",fix:"Construct XPath with proper escaping and validation",documentationLink:"https://owasp.org/www-community/attacks/XPATH_Injection"}),escapeXpathInput:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Escape XPath Input",description:"Escape special characters in XPath input",severity:"LOW",fix:"Use xpath.escape() or equivalent escaping function",documentationLink:"https://www.npmjs.com/package/xpath-escape"}),validateXpathQueries:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Validate XPath Queries",description:"Validate XPath queries against allowed patterns",severity:"LOW",fix:"Whitelist allowed XPath operations and validate syntax",documentationLink:"https://owasp.org/www-community/attacks/XPATH_Injection"}),strategyParameterizedQueries:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Parameterized Queries Strategy",description:"Use parameterized XPath construction",severity:"LOW",fix:"Build XPath queries programmatically with escaped parameters",documentationLink:"https://owasp.org/www-community/attacks/XPATH_Injection"}),strategyInputValidation:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Input Validation Strategy",description:"Validate XPath input at application boundary",severity:"LOW",fix:"Validate XPath syntax and restrict to safe operations",documentationLink:"https://cwe.mitre.org/data/definitions/643.html"}),strategySafeConstruction:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Safe Construction Strategy",description:"Use safe XPath construction libraries",severity:"LOW",fix:"Use libraries that provide safe XPath building",documentationLink:"https://www.npmjs.com/package/xpath-builder"})},schema:[{type:"object",properties:{xpathFunctions:{type:"array",items:{type:"string"},default:["evaluate","selectSingleNode","selectNodes","xpath","select"],description:"XPath evaluation methods treated as query sinks"},safeXpathConstructors:{type:"array",items:{type:"string"},default:["buildXPath","createXPath","safeXPath","xpathBuilder"],description:"Builders that produce a parameterized XPath expression"},xpathValidationFunctions:{type:"array",items:{type:"string"},default:["validateXPath","escapeXPath","sanitizeXPath","cleanXPath"],description:"Function names that escape or validate XPath input"},trustedSanitizers:{type:"array",items:{type:"string"},default:[],description:"Additional function names to consider as XPath sanitizers"},trustedAnnotations:{type:"array",items:{type:"string"},default:[],description:"Additional JSDoc annotations to consider as safe markers"},strictMode:{type:"boolean",default:false,description:"Disable all false positive detection (strict mode)"}},additionalProperties:false}]},defaultOptions:[{xpathFunctions:["evaluate","selectSingleNode","selectNodes","xpath","select"],safeXpathConstructors:["buildXPath","createXPath","safeXPath","xpathBuilder"],xpathValidationFunctions:["validateXPath","escapeXPath","sanitizeXPath","cleanXPath"],trustedSanitizers:[],trustedAnnotations:["@xpath-safe"],strictMode:false}],create(context){const options=context.options[0]||{};const{xpathFunctions=["evaluate","selectSingleNode","selectNodes","xpath","select"],xpathValidationFunctions=["validateXPath","escapeXPath","sanitizeXPath","cleanXPath"],trustedSanitizers=[],trustedAnnotations=[],strictMode=false}=options;const sourceCode=context.sourceCode;const filename=context.filename;const safetyChecker=(0,eslint_devkit_3.createSafetyChecker)({trustedSanitizers,trustedAnnotations,trustedOrmPatterns:[],strictMode});const validatedVariables=new Set;const isXpathOperation=node=>{const callee=node.callee;if(callee.type==="MemberExpression"&&callee.property.type==="Identifier"&&xpathFunctions.includes(callee.property.name)){return true}if(callee.type==="Identifier"&&xpathFunctions.includes(callee.name)){return true}return false};const containsDangerousXpath=xpathText=>{const dangerousPatterns=[/\.\./,/\/\*/,/\[.*\*\]/,/\/\//,/text\(\)/,/comment\(\)/,/processing-instruction\(\)/];return dangerousPatterns.some(pattern=>pattern.test(xpathText))};const containsXpathInterpolation=text=>{return/\$\{[^}]+\}/.test(text)||/'[^']*\+[^+]*'/.test(text)||/"[^"]*\+[^+]*"/.test(text)};const isUntrustedXpathInput=inputNode=>{if(inputNode.type==="MemberExpression"){if(inputNode.object.type==="MemberExpression"&&inputNode.object.object.type==="Identifier"&&inputNode.object.object.name==="req"&&inputNode.object.property.type==="Identifier"&&["query","body","params","param"].includes(inputNode.object.property.name)){return true}if(inputNode.object.type==="Identifier"&&inputNode.object.name==="req"){return true}}if(inputNode.type!=="Identifier"){return false}const varName=inputNode.name.toLowerCase();if(["req","request","query","params","input","user","search"].some(keyword=>varName.includes(keyword))){return true}let current=inputNode;while(current){if(current.type==="FunctionDeclaration"||current.type==="FunctionExpression"||current.type==="ArrowFunctionExpression"){const func=current;return func.params.some(param=>{if(param.type==="Identifier"){return param.name===inputNode.name}return false})}current=current.parent}return false};const isXpathInputValidated=inputNode=>{let current=inputNode;while(current){if(current.type==="CallExpression"&&current.callee.type==="Identifier"&&xpathValidationFunctions.includes(current.callee.name)){return true}current=current.parent}return false};const hasSafeAnnotationOnStatement=node=>{let current=node;while(current){if(current.type==="VariableDeclaration"||current.type==="ExpressionStatement"||current.type==="FunctionDeclaration"){const comments=sourceCode.getCommentsBefore(current);for(const comment of comments){if(comment.type==="Block"&&comment.value.includes("@xpath-safe")){return true}}}current=current.parent}return false};return{CallExpression(node){if(!isXpathOperation(node)){return}const args=node.arguments;if(args.length===0){return}const xpathArg=args[0];if(xpathArg.type==="Literal"&&typeof xpathArg.value==="string"){const xpathText=xpathArg.value;if(containsDangerousXpath(xpathText)){if((0,eslint_devkit_3.hasSafeAnnotation)(xpathArg,context,trustedAnnotations)||hasSafeAnnotationOnStatement(node)){return}context.report({node:xpathArg,messageId:"dangerousXpathExpression",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}else if(xpathArg.type==="Identifier"){if(isUntrustedXpathInput(xpathArg)&&!isXpathInputValidated(xpathArg)&&!(xpathArg.type==="Identifier"&&validatedVariables.has(xpathArg.name))){if((0,eslint_devkit_3.hasSafeAnnotation)(xpathArg,context,trustedAnnotations)||safetyChecker.isSafe(xpathArg,context)||hasSafeAnnotationOnStatement(node)){return}context.report({node:xpathArg,messageId:"unvalidatedXpathInput",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}},TemplateLiteral(node){const fullText=sourceCode.getText(node);if(/https?:\/\//.test(fullText)||/^[`'"]\s*\/api\//.test(fullText)){return}if(/^[`'"]\s*\/home\//.test(fullText)||/^[`'"]\s*\/usr\//.test(fullText)||/^[`'"]\s*\/tmp\//.test(fullText)){return}if(/\[data-[\w-]+/.test(fullText)||/\[class=/.test(fullText)||/\[id=/.test(fullText)){return}if(/\?.*=/.test(fullText)&&!/\[@/.test(fullText)){return}const hasXpathSyntax=/\/\/\w+/.test(fullText)||/\[@\w+/.test(fullText)||/\[contains\(/.test(fullText)||/\[text\(\)/.test(fullText)||/\/child::/.test(fullText)||/\/descendant::/.test(fullText);if(!hasXpathSyntax){return}if(containsXpathInterpolation(fullText)){const hasUntrustedInterpolation=node.expressions.some(expr=>isUntrustedXpathInput(expr)&&!isXpathInputValidated(expr)&&!(expr.type==="Identifier"&&validatedVariables.has(expr.name)));if(hasUntrustedInterpolation){if(hasSafeAnnotationOnStatement(node)){return}context.report({node,messageId:"unsafeXpathConcatenation",data:{filePath:filename,line:String(node.loc?.start.line??0)},suggest:[{messageId:"useParameterizedXpath",fix:()=>null}]})}}if(containsDangerousXpath(fullText)){if(hasSafeAnnotationOnStatement(node)){return}context.report({node,messageId:"dangerousXpathExpression",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}},BinaryExpression(node){if(node.operator!=="+"){return}const fullText=sourceCode.getText(node);if(!fullText.includes("/")&&!fullText.includes("[")){return}const leftUntrusted=isUntrustedXpathInput(node.left)&&!isXpathInputValidated(node.left)&&!(node.left.type==="Identifier"&&validatedVariables.has(node.left.name));const rightUntrusted=isUntrustedXpathInput(node.right)&&!isXpathInputValidated(node.right)&&!(node.right.type==="Identifier"&&validatedVariables.has(node.right.name));if(leftUntrusted||rightUntrusted){if(safetyChecker.isSafe(node,context)||hasSafeAnnotationOnStatement(node)){return}context.report({node,messageId:"xpathInjection",data:{filePath:filename,line:String(node.loc?.start.line??0),severity:"HIGH",safeAlternative:"Use parameterized XPath construction with input validation"}})}},VariableDeclarator(node){if(!node.init||node.id.type!=="Identifier"){return}const varName=node.id.name;if(node.init.type==="CallExpression"&&node.init.callee.type==="Identifier"&&(xpathValidationFunctions.includes(node.init.callee.name)||trustedSanitizers.includes(node.init.callee.name))){validatedVariables.add(varName)}const varNameLower=varName.toLowerCase();if(!varNameLower.includes("xpath")&&!varNameLower.includes("query")&&!varNameLower.includes("path")){return}if(node.init.type==="Literal"&&typeof node.init.value==="string"){if(containsDangerousXpath(node.init.value)){if(safetyChecker.isSafe(node.init,context)||hasSafeAnnotationOnStatement(node)){return}context.report({node:node.init,messageId:"dangerousXpathExpression",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}else if(isUntrustedXpathInput(node.init)){context.report({node:node.init,messageId:"xpathInjection",data:{filePath:filename,line:String(node.loc?.start.line??0),severity:"MEDIUM",safeAlternative:"Use safe XPath construction methods"}})}}}}});
1
+ "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noXpathInjection=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const eslint_devkit_3=require("@interlace/eslint-devkit");function literalTextOf(node){if(node.type==="Literal")return typeof node.value==="string"?node.value:"";if(node.type==="TemplateLiteral")return node.quasis.map(q=>q.value.raw).join(" ");if(node.type==="BinaryExpression"&&node.operator==="+"){return`${literalTextOf(node.left)} ${literalTextOf(node.right)}`}return""}const XPATH_SYNTAX=/\/\/|\[@|::|\btext\(\)|\bnode\(\)|\bcontains\(|\bstarts-with\(|\blocal-name\(|\bposition\(\)|\/[A-Za-z_*][\w.-]*\[/;exports.noXpathInjection=(0,eslint_devkit_1.createRule)({name:"no-xpath-injection",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-secure-coding/docs/rules/no-xpath-injection.md",description:"Detects XPath injection vulnerabilities",cwe:"CWE-643"},hasSuggestions:true,messages:{xpathInjection:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"XPath Injection",cwe:"CWE-643",description:"XPath injection vulnerability detected",severity:"{{severity}}",fix:"{{safeAlternative}}",documentationLink:"https://cwe.mitre.org/data/definitions/643.html"}),unsafeXpathConcatenation:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Unsafe XPath Concatenation",cwe:"CWE-643",description:"Unsafe string concatenation in XPath expression",severity:"HIGH",fix:"Use parameterized XPath or escape user input",documentationLink:"https://owasp.org/www-community/attacks/XPATH_Injection"}),unvalidatedXpathInput:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Unvalidated XPath Input",cwe:"CWE-643",description:"XPath query uses unvalidated user input",severity:"MEDIUM",fix:"Validate and sanitize XPath input before use",documentationLink:"https://owasp.org/www-community/attacks/XPATH_Injection"}),dangerousXpathExpression:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Dangerous XPath Expression",cwe:"CWE-643",description:"XPath expression allows dangerous operations",severity:"MEDIUM",fix:"Restrict XPath to safe patterns and validate expressions",documentationLink:"https://cwe.mitre.org/data/definitions/643.html"}),useParameterizedXpath:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Use Parameterized XPath",description:"Use parameterized XPath queries",severity:"LOW",fix:"Construct XPath with proper escaping and validation",documentationLink:"https://owasp.org/www-community/attacks/XPATH_Injection"}),escapeXpathInput:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Escape XPath Input",description:"Escape special characters in XPath input",severity:"LOW",fix:"Use xpath.escape() or equivalent escaping function",documentationLink:"https://www.npmjs.com/package/xpath-escape"}),validateXpathQueries:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.INFO,issueName:"Validate XPath Queries",description:"Validate XPath queries against allowed patterns",severity:"LOW",fix:"Whitelist allowed XPath operations and validate syntax",documentationLink:"https://owasp.org/www-community/attacks/XPATH_Injection"}),strategyParameterizedQueries:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Parameterized Queries Strategy",description:"Use parameterized XPath construction",severity:"LOW",fix:"Build XPath queries programmatically with escaped parameters",documentationLink:"https://owasp.org/www-community/attacks/XPATH_Injection"}),strategyInputValidation:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Input Validation Strategy",description:"Validate XPath input at application boundary",severity:"LOW",fix:"Validate XPath syntax and restrict to safe operations",documentationLink:"https://cwe.mitre.org/data/definitions/643.html"}),strategySafeConstruction:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.STRATEGY,issueName:"Safe Construction Strategy",description:"Use safe XPath construction libraries",severity:"LOW",fix:"Use libraries that provide safe XPath building",documentationLink:"https://www.npmjs.com/package/xpath-builder"})},schema:[{type:"object",properties:{xpathFunctions:{type:"array",items:{type:"string"},default:["evaluate","selectSingleNode","selectNodes","xpath","select"],description:"XPath evaluation methods treated as query sinks"},safeXpathConstructors:{type:"array",items:{type:"string"},default:["buildXPath","createXPath","safeXPath","xpathBuilder"],description:"Builders that produce a parameterized XPath expression"},xpathValidationFunctions:{type:"array",items:{type:"string"},default:["validateXPath","escapeXPath","sanitizeXPath","cleanXPath"],description:"Function names that escape or validate XPath input"},trustedSanitizers:{type:"array",items:{type:"string"},default:[],description:"Additional function names to consider as XPath sanitizers"},trustedAnnotations:{type:"array",items:{type:"string"},default:[],description:"Additional JSDoc annotations to consider as safe markers"},strictMode:{type:"boolean",default:false,description:"Disable all false positive detection (strict mode)"}},additionalProperties:false}]},defaultOptions:[{xpathFunctions:["evaluate","selectSingleNode","selectNodes","xpath","select"],safeXpathConstructors:["buildXPath","createXPath","safeXPath","xpathBuilder"],xpathValidationFunctions:["validateXPath","escapeXPath","sanitizeXPath","cleanXPath"],trustedSanitizers:[],trustedAnnotations:["@xpath-safe"],strictMode:false}],create(context){const options=context.options[0]||{};const{xpathFunctions=["evaluate","selectSingleNode","selectNodes","xpath","select"],xpathValidationFunctions=["validateXPath","escapeXPath","sanitizeXPath","cleanXPath"],trustedSanitizers=[],trustedAnnotations=[],strictMode=false}=options;const sourceCode=context.sourceCode;const filename=context.filename;const safetyChecker=(0,eslint_devkit_3.createSafetyChecker)({trustedSanitizers,trustedAnnotations,trustedOrmPatterns:[],strictMode});const validatedVariables=new Set;const isXpathOperation=node=>{const callee=node.callee;if(callee.type==="MemberExpression"&&callee.property.type==="Identifier"&&xpathFunctions.includes(callee.property.name)){return true}if(callee.type==="Identifier"&&xpathFunctions.includes(callee.name)){return true}return false};const containsDangerousXpath=xpathText=>{const dangerousPatterns=[/\.\./,/\/\*/,/\[.*\*\]/,/\/\//,/text\(\)/,/comment\(\)/,/processing-instruction\(\)/];return dangerousPatterns.some(pattern=>pattern.test(xpathText))};const isUntrustedXpathInput=inputNode=>{if(inputNode.type==="MemberExpression"){if(inputNode.object.type==="MemberExpression"&&inputNode.object.object.type==="Identifier"&&inputNode.object.object.name==="req"&&inputNode.object.property.type==="Identifier"&&["query","body","params","param"].includes(inputNode.object.property.name)){return true}if(inputNode.object.type==="Identifier"&&inputNode.object.name==="req"){return true}}if(inputNode.type!=="Identifier"){return false}const varName=inputNode.name.toLowerCase();if(["req","request","query","params","input","user","search"].some(keyword=>varName.includes(keyword))){return true}let current=inputNode;while(current){if(current.type==="FunctionDeclaration"||current.type==="FunctionExpression"||current.type==="ArrowFunctionExpression"){const func=current;return func.params.some(param=>{if(param.type==="Identifier"){return param.name===inputNode.name}return false})}current=current.parent}return false};const isXpathInputValidated=inputNode=>{let current=inputNode;while(current){if(current.type==="CallExpression"&&current.callee.type==="Identifier"&&xpathValidationFunctions.includes(current.callee.name)){return true}current=current.parent}return false};const hasSafeAnnotationOnStatement=node=>{let current=node;while(current){if(current.type==="VariableDeclaration"||current.type==="ExpressionStatement"||current.type==="FunctionDeclaration"){const comments=sourceCode.getCommentsBefore(current);for(const comment of comments){if(comment.type==="Block"&&comment.value.includes("@xpath-safe")){return true}}}current=current.parent}return false};return{CallExpression(node){if(!isXpathOperation(node)){return}const args=node.arguments;if(args.length===0){return}const xpathArg=args[0];if(xpathArg.type==="Literal"&&typeof xpathArg.value==="string"){const xpathText=xpathArg.value;if(containsDangerousXpath(xpathText)){if((0,eslint_devkit_3.hasSafeAnnotation)(xpathArg,context,trustedAnnotations)||hasSafeAnnotationOnStatement(node)){return}context.report({node:xpathArg,messageId:"dangerousXpathExpression",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}else if(xpathArg.type==="Identifier"){if(isUntrustedXpathInput(xpathArg)&&!isXpathInputValidated(xpathArg)&&!(xpathArg.type==="Identifier"&&validatedVariables.has(xpathArg.name))){if((0,eslint_devkit_3.hasSafeAnnotation)(xpathArg,context,trustedAnnotations)||safetyChecker.isSafe(xpathArg,context)||hasSafeAnnotationOnStatement(node)){return}context.report({node:xpathArg,messageId:"unvalidatedXpathInput",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}},TemplateLiteral(node){const staticText=literalTextOf(node);if(/https?:\/\//.test(staticText)||/^\s*\/api\//.test(staticText)){return}if(/^\s*\/home\//.test(staticText)||/^\s*\/usr\//.test(staticText)||/^\s*\/tmp\//.test(staticText)){return}if(/\[data-[\w-]+/.test(staticText)||/\[class=/.test(staticText)||/\[id=/.test(staticText)){return}if(/\?.*=/.test(staticText)&&!/\[@/.test(staticText)){return}if(!XPATH_SYNTAX.test(staticText)){return}if(node.expressions.length>0){const hasUntrustedInterpolation=node.expressions.some(expr=>isUntrustedXpathInput(expr)&&!isXpathInputValidated(expr)&&!(expr.type==="Identifier"&&validatedVariables.has(expr.name)));if(hasUntrustedInterpolation){if(hasSafeAnnotationOnStatement(node)){return}context.report({node,messageId:"unsafeXpathConcatenation",data:{filePath:filename,line:String(node.loc?.start.line??0)},suggest:[{messageId:"useParameterizedXpath",fix:()=>null}]})}}if(containsDangerousXpath(staticText)){if(hasSafeAnnotationOnStatement(node)){return}context.report({node,messageId:"dangerousXpathExpression",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}},BinaryExpression(node){if(node.operator!=="+"){return}if(!XPATH_SYNTAX.test(literalTextOf(node))){return}const leftUntrusted=isUntrustedXpathInput(node.left)&&!isXpathInputValidated(node.left)&&!(node.left.type==="Identifier"&&validatedVariables.has(node.left.name));const rightUntrusted=isUntrustedXpathInput(node.right)&&!isXpathInputValidated(node.right)&&!(node.right.type==="Identifier"&&validatedVariables.has(node.right.name));if(leftUntrusted||rightUntrusted){if(safetyChecker.isSafe(node,context)||hasSafeAnnotationOnStatement(node)){return}context.report({node,messageId:"xpathInjection",data:{filePath:filename,line:String(node.loc?.start.line??0),severity:"HIGH",safeAlternative:"Use parameterized XPath construction with input validation"}})}},VariableDeclarator(node){if(!node.init||node.id.type!=="Identifier"){return}const varName=node.id.name;if(node.init.type==="CallExpression"&&node.init.callee.type==="Identifier"&&(xpathValidationFunctions.includes(node.init.callee.name)||trustedSanitizers.includes(node.init.callee.name))){validatedVariables.add(varName)}const varNameLower=varName.toLowerCase();if(!varNameLower.includes("xpath")&&!varNameLower.includes("query")&&!varNameLower.includes("path")){return}if(node.init.type==="Literal"&&typeof node.init.value==="string"){if(containsDangerousXpath(node.init.value)){if(safetyChecker.isSafe(node.init,context)||hasSafeAnnotationOnStatement(node)){return}context.report({node:node.init,messageId:"dangerousXpathExpression",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}}else if(isUntrustedXpathInput(node.init)){context.report({node:node.init,messageId:"xpathInjection",data:{filePath:filename,line:String(node.loc?.start.line??0),severity:"MEDIUM",safeAlternative:"Use safe XPath construction methods"}})}}}}});
@@ -1 +1 @@
1
- "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noXxeInjection=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const isXmlParsingCall=node=>{const callee=node.callee;if(callee.type==="MemberExpression"&&callee.property.type==="Identifier"&&["parse","parseFromString","parseString","parseXmlString","parseXML"].includes(callee.property.name)){return true}if(callee.type==="Identifier"&&["DOMParser","XMLHttpRequest","ActiveXObject"].includes(callee.name)){return true}return false};const hasDangerousParserOptions=optionsNode=>{if(optionsNode.type!=="ObjectExpression"){return false}for(const prop of optionsNode.properties){if(prop.type==="Property"&&prop.key.type==="Identifier"&&["resolveExternals","expandEntityReferences","noent"].includes(prop.key.name)){if(prop.value.type==="Literal"&&prop.value.value===true){return true}}}return false};const containsDangerousEntities=xmlText=>{return/<!ENTITY/i.test(xmlText)&&/SYSTEM\s+["']/i.test(xmlText)};exports.noXxeInjection=(0,eslint_devkit_1.createRule)({name:"no-xxe-injection",meta:{type:"problem",docs:{description:"Detect XML External Entity (XXE) injection vulnerabilities",url:"https://cwe.mitre.org/data/definitions/611.html",cwe:"CWE-611",cvss:9.1},messages:{xxeInjection:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"XXE Injection",cwe:"CWE-611",description:"XML contains dangerous entity declarations",severity:"CRITICAL",fix:"Remove SYSTEM/PUBLIC entity declarations or use safe XML parser",documentationLink:"https://owasp.org/www-community/vulnerabilities/XML_External_Entity_(XXE)_Processing"}),unsafeXmlParser:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Unsafe XML Parser",cwe:"CWE-611",description:"Using unsafe XML parser without secure configuration",severity:"HIGH",fix:"Use libxmljs with noent: false or xmldom with entityResolver: null",documentationLink:"https://cheatsheetseries.owasp.org/cheatsheets/XML_External_Entity_Prevention_Cheat_Sheet.html"}),externalEntityEnabled:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"External Entity Processing",cwe:"CWE-611",description:"External entity processing is enabled",severity:"CRITICAL",fix:"Disable external entity processing",documentationLink:"https://cwe.mitre.org/data/definitions/611.html"}),untrustedXmlSource:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Untrusted XML Source",cwe:"CWE-611",description:"XML from untrusted source without validation",severity:"HIGH",fix:"Validate and sanitize XML input before parsing",documentationLink:"https://cheatsheetseries.owasp.org/cheatsheets/XML_External_Entity_Prevention_Cheat_Sheet.html"})},schema:[{type:"object",properties:{safeParserOptions:{type:"array",items:{type:"string"}},xmlValidationFunctions:{type:"array",items:{type:"string"}}},additionalProperties:false}]},defaultOptions:[{safeParserOptions:["noent","resolveExternals","expandEntityReferences","entityResolver"],xmlValidationFunctions:["validateXml","sanitizeXml","cleanXml","parseXmlSafe"]}],create(context,[options]){const{safeParserOptions=["noent","resolveExternals","expandEntityReferences","entityResolver"],xmlValidationFunctions=["validateXml","sanitizeXml","cleanXml","parseXmlSafe"]}=options;const filename=context.filename;const hasSecureParserOptions=optionsNode=>{if(optionsNode.type!=="ObjectExpression"){return false}for(const prop of optionsNode.properties){if(prop.type==="Property"&&prop.key.type==="Identifier"&&safeParserOptions.includes(prop.key.name)){if(prop.value.type==="Literal"&&prop.value.value===false){return true}if(prop.value.type==="Literal"&&prop.value.value===null){return true}}}return false};const isXmlInputValidated=xmlSource=>{let current=xmlSource;while(current){if(current.type==="CallExpression"&&current.callee.type==="Identifier"&&xmlValidationFunctions.includes(current.callee.name)){return true}current=current.parent}return false};const isUntrustedXmlSource=xmlSource=>{if(xmlSource.type==="Identifier"){const varName=xmlSource.name.toLowerCase();if(["clean","safe","validated","sanitized","validatedxml","sanitizedxml"].some(safe=>varName.includes(safe))){return false}return["req","request","body","query","params","input","xml","data"].some(keyword=>varName.includes(keyword))}let current=xmlSource;while(current){if(current.type==="CallExpression"&&current.callee.type==="MemberExpression"&&current.callee.property.type==="Identifier"&&["readFileSync","readFile","createReadStream"].includes(current.callee.property.name)){return true}current=current.parent}return false};return{CallExpression(node){if(!isXmlParsingCall(node)){return}const args=node.arguments;if(args.length===0){return}const xmlInput=args[0];const isUntrusted=isUntrustedXmlSource(xmlInput);const isValidated=isXmlInputValidated(xmlInput);const hasSecureOptions=args.length>=2&&hasSecureParserOptions(args[1]);if(isUntrusted&&!isValidated&&!hasSecureOptions){context.report({node:xmlInput,messageId:"untrustedXmlSource",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}if(args.length>=2){const optionsArg=args[1];if(hasDangerousParserOptions(optionsArg)){context.report({node:optionsArg,messageId:"externalEntityEnabled",data:{filePath:filename,line:String(node.loc?.start.line??0)}});return}}},NewExpression(node){const callee=node.callee;if(callee.type!=="Identifier"||!["DOMParser","XMLHttpRequest","ActiveXObject"].includes(callee.name)){return}context.report({node,messageId:"unsafeXmlParser",data:{filePath:filename,line:String(node.loc?.start.line??0)}})},Literal(node){if(typeof node.value==="string"&&containsDangerousEntities(node.value)){context.report({node,messageId:"xxeInjection",data:{filePath:filename,line:String(node.loc?.start.line??0),safeAlternative:"Use sanitized XML or remove entity declarations"}})}}}}});
1
+ "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.noXxeInjection=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const eslint_devkit_3=require("@interlace/eslint-devkit");const XML_RECEIVER=/xml|^dom$|domparser|jsdom|libxml|^sax$|^expat$|^parser$/i;const isXmlReceiver=node=>{if(node.type===eslint_devkit_3.AST_NODE_TYPES.Identifier)return XML_RECEIVER.test(node.name);if(node.type===eslint_devkit_3.AST_NODE_TYPES.MemberExpression&&node.property.type===eslint_devkit_3.AST_NODE_TYPES.Identifier){return XML_RECEIVER.test(node.property.name)}if(node.type===eslint_devkit_3.AST_NODE_TYPES.NewExpression&&node.callee.type===eslint_devkit_3.AST_NODE_TYPES.Identifier){return XML_RECEIVER.test(node.callee.name)}return false};const isXmlParsingCall=node=>{const callee=node.callee;if(callee.type===eslint_devkit_3.AST_NODE_TYPES.MemberExpression&&callee.property.type===eslint_devkit_3.AST_NODE_TYPES.Identifier){const method=callee.property.name;if(["parseFromString","parseString","parseXmlString","parseXML"].includes(method)){return true}if(method==="parse"){return isXmlReceiver(callee.object)}}if(callee.type==="Identifier"&&["DOMParser","XMLHttpRequest","ActiveXObject"].includes(callee.name)){return true}return false};const hasDangerousParserOptions=optionsNode=>{if(optionsNode.type!=="ObjectExpression"){return false}for(const prop of optionsNode.properties){if(prop.type==="Property"&&prop.key.type==="Identifier"&&["resolveExternals","expandEntityReferences","noent"].includes(prop.key.name)){if(prop.value.type==="Literal"&&prop.value.value===true){return true}}}return false};const containsDangerousEntities=xmlText=>{return/<!ENTITY/i.test(xmlText)&&/SYSTEM\s+["']/i.test(xmlText)};exports.noXxeInjection=(0,eslint_devkit_1.createRule)({name:"no-xxe-injection",meta:{type:"problem",docs:{description:"Detect XML External Entity (XXE) injection vulnerabilities",url:"https://cwe.mitre.org/data/definitions/611.html",cwe:"CWE-611",cvss:9.1},messages:{xxeInjection:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"XXE Injection",cwe:"CWE-611",description:"XML contains dangerous entity declarations",severity:"CRITICAL",fix:"Remove SYSTEM/PUBLIC entity declarations or use safe XML parser",documentationLink:"https://owasp.org/www-community/vulnerabilities/XML_External_Entity_(XXE)_Processing"}),unsafeXmlParser:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Unsafe XML Parser",cwe:"CWE-611",description:"Using unsafe XML parser without secure configuration",severity:"HIGH",fix:"Use libxmljs with noent: false or xmldom with entityResolver: null",documentationLink:"https://cheatsheetseries.owasp.org/cheatsheets/XML_External_Entity_Prevention_Cheat_Sheet.html"}),externalEntityEnabled:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"External Entity Processing",cwe:"CWE-611",description:"External entity processing is enabled",severity:"CRITICAL",fix:"Disable external entity processing",documentationLink:"https://cwe.mitre.org/data/definitions/611.html"}),untrustedXmlSource:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.SECURITY,issueName:"Untrusted XML Source",cwe:"CWE-611",description:"XML from untrusted source without validation",severity:"HIGH",fix:"Validate and sanitize XML input before parsing",documentationLink:"https://cheatsheetseries.owasp.org/cheatsheets/XML_External_Entity_Prevention_Cheat_Sheet.html"})},schema:[{type:"object",properties:{safeParserOptions:{type:"array",items:{type:"string"}},xmlValidationFunctions:{type:"array",items:{type:"string"}}},additionalProperties:false}]},defaultOptions:[{safeParserOptions:["noent","resolveExternals","expandEntityReferences","entityResolver"],xmlValidationFunctions:["validateXml","sanitizeXml","cleanXml","parseXmlSafe"]}],create(context,[options]){const{safeParserOptions=["noent","resolveExternals","expandEntityReferences","entityResolver"],xmlValidationFunctions=["validateXml","sanitizeXml","cleanXml","parseXmlSafe"]}=options;const filename=context.filename;const hasSecureParserOptions=optionsNode=>{if(optionsNode.type!=="ObjectExpression"){return false}for(const prop of optionsNode.properties){if(prop.type==="Property"&&prop.key.type==="Identifier"&&safeParserOptions.includes(prop.key.name)){if(prop.value.type==="Literal"&&prop.value.value===false){return true}if(prop.value.type==="Literal"&&prop.value.value===null){return true}}}return false};const isXmlInputValidated=xmlSource=>{let current=xmlSource;while(current){if(current.type==="CallExpression"&&current.callee.type==="Identifier"&&xmlValidationFunctions.includes(current.callee.name)){return true}current=current.parent}return false};const isUntrustedXmlSource=xmlSource=>{if(xmlSource.type==="Identifier"){const varName=xmlSource.name.toLowerCase();if(["clean","safe","validated","sanitized","validatedxml","sanitizedxml"].some(safe=>varName.includes(safe))){return false}return["req","request","body","query","params","input","xml","data"].some(keyword=>varName.includes(keyword))}let current=xmlSource;while(current){if(current.type==="CallExpression"&&current.callee.type==="MemberExpression"&&current.callee.property.type==="Identifier"&&["readFileSync","readFile","createReadStream"].includes(current.callee.property.name)){return true}current=current.parent}return false};return{CallExpression(node){if(!isXmlParsingCall(node)){return}const args=node.arguments;if(args.length===0){return}const xmlInput=args[0];const isUntrusted=isUntrustedXmlSource(xmlInput);const isValidated=isXmlInputValidated(xmlInput);const hasSecureOptions=args.length>=2&&hasSecureParserOptions(args[1]);if(isUntrusted&&!isValidated&&!hasSecureOptions){context.report({node:xmlInput,messageId:"untrustedXmlSource",data:{filePath:filename,line:String(node.loc?.start.line??0)}})}if(args.length>=2){const optionsArg=args[1];if(hasDangerousParserOptions(optionsArg)){context.report({node:optionsArg,messageId:"externalEntityEnabled",data:{filePath:filename,line:String(node.loc?.start.line??0)}});return}}},NewExpression(node){const callee=node.callee;if(callee.type!=="Identifier"||!["DOMParser","XMLHttpRequest","ActiveXObject"].includes(callee.name)){return}context.report({node,messageId:"unsafeXmlParser",data:{filePath:filename,line:String(node.loc?.start.line??0)}})},Literal(node){if(typeof node.value==="string"&&containsDangerousEntities(node.value)){context.report({node,messageId:"xxeInjection",data:{filePath:filename,line:String(node.loc?.start.line??0),safeAlternative:"Use sanitized XML or remove entity declarations"}})}}}}});