eslint-plugin-secure-coding 2.3.2 → 2.3.3
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/README.md +1 -0
- package/package.json +3 -10
- package/src/index.ts +605 -0
- package/src/rules/__tests__/integration-demo.test.ts +290 -0
- package/src/rules/__tests__/integration-llm.test.ts +89 -0
- package/src/rules/database-injection/database-injection.test.ts +456 -0
- package/src/rules/database-injection/index.ts +488 -0
- package/src/rules/detect-child-process/detect-child-process.test.ts +207 -0
- package/src/rules/detect-child-process/index.ts +634 -0
- package/src/rules/detect-eval-with-expression/detect-eval-with-expression.test.ts +416 -0
- package/src/rules/detect-eval-with-expression/index.ts +463 -0
- package/src/rules/detect-mixed-content/detect-mixed-content.test.ts +28 -0
- package/src/rules/detect-mixed-content/index.ts +52 -0
- package/src/rules/detect-non-literal-fs-filename/detect-non-literal-fs-filename.test.ts +269 -0
- package/src/rules/detect-non-literal-fs-filename/index.ts +551 -0
- package/src/rules/detect-non-literal-regexp/detect-non-literal-regexp.test.ts +189 -0
- package/src/rules/detect-non-literal-regexp/index.ts +490 -0
- package/src/rules/detect-object-injection/detect-object-injection.test.ts +440 -0
- package/src/rules/detect-object-injection/index.ts +674 -0
- package/src/rules/detect-suspicious-dependencies/detect-suspicious-dependencies.test.ts +32 -0
- package/src/rules/detect-suspicious-dependencies/index.ts +84 -0
- package/src/rules/detect-weak-password-validation/detect-weak-password-validation.test.ts +31 -0
- package/src/rules/detect-weak-password-validation/index.ts +68 -0
- package/src/rules/no-allow-arbitrary-loads/index.ts +54 -0
- package/src/rules/no-allow-arbitrary-loads/no-allow-arbitrary-loads.test.ts +28 -0
- package/src/rules/no-arbitrary-file-access/index.ts +238 -0
- package/src/rules/no-arbitrary-file-access/no-arbitrary-file-access.test.ts +119 -0
- package/src/rules/no-buffer-overread/index.ts +724 -0
- package/src/rules/no-buffer-overread/no-buffer-overread.test.ts +313 -0
- package/src/rules/no-clickjacking/index.ts +481 -0
- package/src/rules/no-clickjacking/no-clickjacking.test.ts +253 -0
- package/src/rules/no-client-side-auth-logic/index.ts +81 -0
- package/src/rules/no-client-side-auth-logic/no-client-side-auth-logic.test.ts +33 -0
- package/src/rules/no-credentials-in-query-params/index.ts +69 -0
- package/src/rules/no-credentials-in-query-params/no-credentials-in-query-params.test.ts +33 -0
- package/src/rules/no-credentials-in-storage-api/index.ts +64 -0
- package/src/rules/no-credentials-in-storage-api/no-credentials-in-storage-api.test.ts +31 -0
- package/src/rules/no-data-in-temp-storage/index.ts +75 -0
- package/src/rules/no-data-in-temp-storage/no-data-in-temp-storage.test.ts +33 -0
- package/src/rules/no-debug-code-in-production/index.ts +59 -0
- package/src/rules/no-debug-code-in-production/no-debug-code-in-production.test.ts +26 -0
- package/src/rules/no-directive-injection/index.ts +551 -0
- package/src/rules/no-directive-injection/no-directive-injection.test.ts +305 -0
- package/src/rules/no-disabled-certificate-validation/index.ts +72 -0
- package/src/rules/no-disabled-certificate-validation/no-disabled-certificate-validation.test.ts +33 -0
- package/src/rules/no-document-cookie/index.ts +113 -0
- package/src/rules/no-document-cookie/no-document-cookie.test.ts +382 -0
- package/src/rules/no-dynamic-dependency-loading/index.ts +60 -0
- package/src/rules/no-dynamic-dependency-loading/no-dynamic-dependency-loading.test.ts +27 -0
- package/src/rules/no-electron-security-issues/index.ts +504 -0
- package/src/rules/no-electron-security-issues/no-electron-security-issues.test.ts +324 -0
- package/src/rules/no-exposed-debug-endpoints/index.ts +73 -0
- package/src/rules/no-exposed-debug-endpoints/no-exposed-debug-endpoints.test.ts +40 -0
- package/src/rules/no-exposed-sensitive-data/index.ts +428 -0
- package/src/rules/no-exposed-sensitive-data/no-exposed-sensitive-data.test.ts +75 -0
- package/src/rules/no-format-string-injection/index.ts +801 -0
- package/src/rules/no-format-string-injection/no-format-string-injection.test.ts +437 -0
- package/src/rules/no-graphql-injection/index.ts +508 -0
- package/src/rules/no-graphql-injection/no-graphql-injection.test.ts +371 -0
- package/src/rules/no-hardcoded-credentials/index.ts +478 -0
- package/src/rules/no-hardcoded-credentials/no-hardcoded-credentials.test.ts +639 -0
- package/src/rules/no-hardcoded-session-tokens/index.ts +69 -0
- package/src/rules/no-hardcoded-session-tokens/no-hardcoded-session-tokens.test.ts +42 -0
- package/src/rules/no-http-urls/index.ts +131 -0
- package/src/rules/no-http-urls/no-http-urls.test.ts +60 -0
- package/src/rules/no-improper-sanitization/index.ts +502 -0
- package/src/rules/no-improper-sanitization/no-improper-sanitization.test.ts +156 -0
- package/src/rules/no-improper-type-validation/index.ts +572 -0
- package/src/rules/no-improper-type-validation/no-improper-type-validation.test.ts +372 -0
- package/src/rules/no-insecure-comparison/index.ts +232 -0
- package/src/rules/no-insecure-comparison/no-insecure-comparison.test.ts +218 -0
- package/src/rules/no-insecure-cookie-settings/index.ts +391 -0
- package/src/rules/no-insecure-cookie-settings/no-insecure-cookie-settings.test.ts +409 -0
- package/src/rules/no-insecure-jwt/index.ts +467 -0
- package/src/rules/no-insecure-jwt/no-insecure-jwt.test.ts +259 -0
- package/src/rules/no-insecure-redirects/index.ts +267 -0
- package/src/rules/no-insecure-redirects/no-insecure-redirects.test.ts +108 -0
- package/src/rules/no-insecure-websocket/index.ts +72 -0
- package/src/rules/no-insecure-websocket/no-insecure-websocket.test.ts +42 -0
- package/src/rules/no-insufficient-postmessage-validation/index.ts +497 -0
- package/src/rules/no-insufficient-postmessage-validation/no-insufficient-postmessage-validation.test.ts +360 -0
- package/src/rules/no-insufficient-random/index.ts +288 -0
- package/src/rules/no-insufficient-random/no-insufficient-random.test.ts +246 -0
- package/src/rules/no-ldap-injection/index.ts +547 -0
- package/src/rules/no-ldap-injection/no-ldap-injection.test.ts +317 -0
- package/src/rules/no-missing-authentication/index.ts +408 -0
- package/src/rules/no-missing-authentication/no-missing-authentication.test.ts +350 -0
- package/src/rules/no-missing-cors-check/index.ts +453 -0
- package/src/rules/no-missing-cors-check/no-missing-cors-check.test.ts +392 -0
- package/src/rules/no-missing-csrf-protection/index.ts +229 -0
- package/src/rules/no-missing-csrf-protection/no-missing-csrf-protection.test.ts +222 -0
- package/src/rules/no-missing-security-headers/index.ts +266 -0
- package/src/rules/no-missing-security-headers/no-missing-security-headers.test.ts +98 -0
- package/src/rules/no-password-in-url/index.ts +64 -0
- package/src/rules/no-password-in-url/no-password-in-url.test.ts +27 -0
- package/src/rules/no-permissive-cors/index.ts +78 -0
- package/src/rules/no-permissive-cors/no-permissive-cors.test.ts +28 -0
- package/src/rules/no-pii-in-logs/index.ts +83 -0
- package/src/rules/no-pii-in-logs/no-pii-in-logs.test.ts +26 -0
- package/src/rules/no-postmessage-origin-wildcard/index.ts +67 -0
- package/src/rules/no-postmessage-origin-wildcard/no-postmessage-origin-wildcard.test.ts +27 -0
- package/src/rules/no-privilege-escalation/index.ts +403 -0
- package/src/rules/no-privilege-escalation/no-privilege-escalation.test.ts +306 -0
- package/src/rules/no-redos-vulnerable-regex/index.ts +379 -0
- package/src/rules/no-redos-vulnerable-regex/no-redos-vulnerable-regex.test.ts +83 -0
- package/src/rules/no-sensitive-data-exposure/index.ts +294 -0
- package/src/rules/no-sensitive-data-exposure/no-sensitive-data-exposure.test.ts +262 -0
- package/src/rules/no-sensitive-data-in-analytics/index.ts +73 -0
- package/src/rules/no-sensitive-data-in-analytics/no-sensitive-data-in-analytics.test.ts +42 -0
- package/src/rules/no-sensitive-data-in-cache/index.ts +59 -0
- package/src/rules/no-sensitive-data-in-cache/no-sensitive-data-in-cache.test.ts +32 -0
- package/src/rules/no-sql-injection/index.ts +424 -0
- package/src/rules/no-sql-injection/no-sql-injection.test.ts +303 -0
- package/src/rules/no-timing-attack/index.ts +552 -0
- package/src/rules/no-timing-attack/no-timing-attack.test.ts +348 -0
- package/src/rules/no-toctou-vulnerability/index.ts +250 -0
- package/src/rules/no-toctou-vulnerability/no-toctou-vulnerability.test.ts +60 -0
- package/src/rules/no-tracking-without-consent/index.ts +78 -0
- package/src/rules/no-tracking-without-consent/no-tracking-without-consent.test.ts +34 -0
- package/src/rules/no-unchecked-loop-condition/index.ts +781 -0
- package/src/rules/no-unchecked-loop-condition/no-unchecked-loop-condition.test.ts +459 -0
- package/src/rules/no-unencrypted-local-storage/index.ts +73 -0
- package/src/rules/no-unencrypted-local-storage/no-unencrypted-local-storage.test.ts +41 -0
- package/src/rules/no-unencrypted-transmission/index.ts +296 -0
- package/src/rules/no-unencrypted-transmission/no-unencrypted-transmission.test.ts +287 -0
- package/src/rules/no-unescaped-url-parameter/index.ts +424 -0
- package/src/rules/no-unescaped-url-parameter/no-unescaped-url-parameter.test.ts +263 -0
- package/src/rules/no-unlimited-resource-allocation/index.ts +767 -0
- package/src/rules/no-unlimited-resource-allocation/no-unlimited-resource-allocation.test.ts +544 -0
- package/src/rules/no-unsafe-deserialization/index.ts +593 -0
- package/src/rules/no-unsafe-deserialization/no-unsafe-deserialization.test.ts +310 -0
- package/src/rules/no-unsafe-dynamic-require/index.ts +125 -0
- package/src/rules/no-unsafe-dynamic-require/no-unsafe-dynamic-require.test.ts +151 -0
- package/src/rules/no-unsafe-regex-construction/index.ts +370 -0
- package/src/rules/no-unsafe-regex-construction/no-unsafe-regex-construction.test.ts +181 -0
- package/src/rules/no-unsanitized-html/index.ts +400 -0
- package/src/rules/no-unsanitized-html/no-unsanitized-html.test.ts +488 -0
- package/src/rules/no-unvalidated-deeplinks/index.ts +73 -0
- package/src/rules/no-unvalidated-deeplinks/no-unvalidated-deeplinks.test.ts +29 -0
- package/src/rules/no-unvalidated-user-input/index.ts +498 -0
- package/src/rules/no-unvalidated-user-input/no-unvalidated-user-input.test.ts +463 -0
- package/src/rules/no-verbose-error-messages/index.ts +83 -0
- package/src/rules/no-verbose-error-messages/no-verbose-error-messages.test.ts +34 -0
- package/src/rules/no-weak-crypto/index.ts +447 -0
- package/src/rules/no-weak-crypto/no-weak-crypto.test.ts +297 -0
- package/src/rules/no-weak-password-recovery/index.ts +509 -0
- package/src/rules/no-weak-password-recovery/no-weak-password-recovery.test.ts +184 -0
- package/src/rules/no-xpath-injection/index.ts +596 -0
- package/src/rules/no-xpath-injection/no-xpath-injection.test.ts +405 -0
- package/src/rules/no-xxe-injection/index.ts +342 -0
- package/src/rules/no-xxe-injection/no-xxe-injection.test.ts +122 -0
- package/src/rules/no-zip-slip/index.ts +526 -0
- package/src/rules/no-zip-slip/no-zip-slip.test.ts +305 -0
- package/src/rules/require-backend-authorization/index.ts +71 -0
- package/src/rules/require-backend-authorization/require-backend-authorization.test.ts +31 -0
- package/src/rules/require-code-minification/index.ts +54 -0
- package/src/rules/require-code-minification/require-code-minification.test.ts +30 -0
- package/src/rules/require-csp-headers/index.ts +74 -0
- package/src/rules/require-csp-headers/require-csp-headers.test.ts +34 -0
- package/src/rules/require-data-minimization/index.ts +65 -0
- package/src/rules/require-data-minimization/require-data-minimization.test.ts +31 -0
- package/src/rules/require-dependency-integrity/index.ts +78 -0
- package/src/rules/require-dependency-integrity/require-dependency-integrity.test.ts +44 -0
- package/src/rules/require-https-only/index.ts +75 -0
- package/src/rules/require-https-only/require-https-only.test.ts +26 -0
- package/src/rules/require-mime-type-validation/index.ts +77 -0
- package/src/rules/require-mime-type-validation/require-mime-type-validation.test.ts +32 -0
- package/src/rules/require-network-timeout/index.ts +58 -0
- package/src/rules/require-network-timeout/require-network-timeout.test.ts +26 -0
- package/src/rules/require-package-lock/index.ts +75 -0
- package/src/rules/require-package-lock/require-package-lock.test.ts +27 -0
- package/src/rules/require-secure-credential-storage/index.ts +60 -0
- package/src/rules/require-secure-credential-storage/require-secure-credential-storage.test.ts +26 -0
- package/src/rules/require-secure-defaults/index.ts +54 -0
- package/src/rules/require-secure-defaults/require-secure-defaults.test.ts +26 -0
- package/src/rules/require-secure-deletion/index.ts +52 -0
- package/src/rules/require-secure-deletion/require-secure-deletion.test.ts +29 -0
- package/src/rules/require-storage-encryption/index.ts +60 -0
- package/src/rules/require-storage-encryption/require-storage-encryption.test.ts +26 -0
- package/src/rules/require-url-validation/index.ts +85 -0
- package/src/rules/require-url-validation/require-url-validation.test.ts +32 -0
- package/src/types/{index.d.ts → index.ts} +157 -53
- package/src/index.d.ts +0 -32
- package/src/index.js +0 -465
- package/src/rules/database-injection/index.d.ts +0 -13
- package/src/rules/database-injection/index.js +0 -406
- package/src/rules/detect-child-process/index.d.ts +0 -11
- package/src/rules/detect-child-process/index.js +0 -529
- package/src/rules/detect-eval-with-expression/index.d.ts +0 -9
- package/src/rules/detect-eval-with-expression/index.js +0 -392
- package/src/rules/detect-mixed-content/index.d.ts +0 -8
- package/src/rules/detect-mixed-content/index.js +0 -44
- package/src/rules/detect-non-literal-fs-filename/index.d.ts +0 -7
- package/src/rules/detect-non-literal-fs-filename/index.js +0 -454
- package/src/rules/detect-non-literal-regexp/index.d.ts +0 -9
- package/src/rules/detect-non-literal-regexp/index.js +0 -403
- package/src/rules/detect-object-injection/index.d.ts +0 -11
- package/src/rules/detect-object-injection/index.js +0 -560
- package/src/rules/detect-suspicious-dependencies/index.d.ts +0 -8
- package/src/rules/detect-suspicious-dependencies/index.js +0 -71
- package/src/rules/detect-weak-password-validation/index.d.ts +0 -6
- package/src/rules/detect-weak-password-validation/index.js +0 -58
- package/src/rules/no-allow-arbitrary-loads/index.d.ts +0 -8
- package/src/rules/no-allow-arbitrary-loads/index.js +0 -47
- package/src/rules/no-arbitrary-file-access/index.d.ts +0 -13
- package/src/rules/no-arbitrary-file-access/index.js +0 -195
- package/src/rules/no-buffer-overread/index.d.ts +0 -29
- package/src/rules/no-buffer-overread/index.js +0 -606
- package/src/rules/no-clickjacking/index.d.ts +0 -10
- package/src/rules/no-clickjacking/index.js +0 -396
- package/src/rules/no-client-side-auth-logic/index.d.ts +0 -6
- package/src/rules/no-client-side-auth-logic/index.js +0 -69
- package/src/rules/no-credentials-in-query-params/index.d.ts +0 -8
- package/src/rules/no-credentials-in-query-params/index.js +0 -57
- package/src/rules/no-credentials-in-storage-api/index.d.ts +0 -6
- package/src/rules/no-credentials-in-storage-api/index.js +0 -54
- package/src/rules/no-data-in-temp-storage/index.d.ts +0 -6
- package/src/rules/no-data-in-temp-storage/index.js +0 -64
- package/src/rules/no-debug-code-in-production/index.d.ts +0 -8
- package/src/rules/no-debug-code-in-production/index.js +0 -51
- package/src/rules/no-directive-injection/index.d.ts +0 -12
- package/src/rules/no-directive-injection/index.js +0 -457
- package/src/rules/no-disabled-certificate-validation/index.d.ts +0 -6
- package/src/rules/no-disabled-certificate-validation/index.js +0 -61
- package/src/rules/no-document-cookie/index.d.ts +0 -5
- package/src/rules/no-document-cookie/index.js +0 -89
- package/src/rules/no-dynamic-dependency-loading/index.d.ts +0 -8
- package/src/rules/no-dynamic-dependency-loading/index.js +0 -51
- package/src/rules/no-electron-security-issues/index.d.ts +0 -10
- package/src/rules/no-electron-security-issues/index.js +0 -423
- package/src/rules/no-exposed-debug-endpoints/index.d.ts +0 -6
- package/src/rules/no-exposed-debug-endpoints/index.js +0 -62
- package/src/rules/no-exposed-sensitive-data/index.d.ts +0 -11
- package/src/rules/no-exposed-sensitive-data/index.js +0 -340
- package/src/rules/no-format-string-injection/index.d.ts +0 -17
- package/src/rules/no-format-string-injection/index.js +0 -660
- package/src/rules/no-graphql-injection/index.d.ts +0 -12
- package/src/rules/no-graphql-injection/index.js +0 -411
- package/src/rules/no-hardcoded-credentials/index.d.ts +0 -26
- package/src/rules/no-hardcoded-credentials/index.js +0 -376
- package/src/rules/no-hardcoded-session-tokens/index.d.ts +0 -6
- package/src/rules/no-hardcoded-session-tokens/index.js +0 -59
- package/src/rules/no-http-urls/index.d.ts +0 -12
- package/src/rules/no-http-urls/index.js +0 -114
- package/src/rules/no-improper-sanitization/index.d.ts +0 -12
- package/src/rules/no-improper-sanitization/index.js +0 -411
- package/src/rules/no-improper-type-validation/index.d.ts +0 -10
- package/src/rules/no-improper-type-validation/index.js +0 -475
- package/src/rules/no-insecure-comparison/index.d.ts +0 -7
- package/src/rules/no-insecure-comparison/index.js +0 -193
- package/src/rules/no-insecure-cookie-settings/index.d.ts +0 -9
- package/src/rules/no-insecure-cookie-settings/index.js +0 -306
- package/src/rules/no-insecure-jwt/index.d.ts +0 -10
- package/src/rules/no-insecure-jwt/index.js +0 -380
- package/src/rules/no-insecure-redirects/index.d.ts +0 -7
- package/src/rules/no-insecure-redirects/index.js +0 -216
- package/src/rules/no-insecure-websocket/index.d.ts +0 -6
- package/src/rules/no-insecure-websocket/index.js +0 -61
- package/src/rules/no-insufficient-postmessage-validation/index.d.ts +0 -14
- package/src/rules/no-insufficient-postmessage-validation/index.js +0 -392
- package/src/rules/no-insufficient-random/index.d.ts +0 -9
- package/src/rules/no-insufficient-random/index.js +0 -208
- package/src/rules/no-ldap-injection/index.d.ts +0 -10
- package/src/rules/no-ldap-injection/index.js +0 -455
- package/src/rules/no-missing-authentication/index.d.ts +0 -13
- package/src/rules/no-missing-authentication/index.js +0 -333
- package/src/rules/no-missing-cors-check/index.d.ts +0 -9
- package/src/rules/no-missing-cors-check/index.js +0 -399
- package/src/rules/no-missing-csrf-protection/index.d.ts +0 -11
- package/src/rules/no-missing-csrf-protection/index.js +0 -180
- package/src/rules/no-missing-security-headers/index.d.ts +0 -7
- package/src/rules/no-missing-security-headers/index.js +0 -218
- package/src/rules/no-password-in-url/index.d.ts +0 -8
- package/src/rules/no-password-in-url/index.js +0 -54
- package/src/rules/no-permissive-cors/index.d.ts +0 -8
- package/src/rules/no-permissive-cors/index.js +0 -65
- package/src/rules/no-pii-in-logs/index.d.ts +0 -8
- package/src/rules/no-pii-in-logs/index.js +0 -70
- package/src/rules/no-postmessage-origin-wildcard/index.d.ts +0 -8
- package/src/rules/no-postmessage-origin-wildcard/index.js +0 -56
- package/src/rules/no-privilege-escalation/index.d.ts +0 -13
- package/src/rules/no-privilege-escalation/index.js +0 -321
- package/src/rules/no-redos-vulnerable-regex/index.d.ts +0 -7
- package/src/rules/no-redos-vulnerable-regex/index.js +0 -306
- package/src/rules/no-sensitive-data-exposure/index.d.ts +0 -11
- package/src/rules/no-sensitive-data-exposure/index.js +0 -250
- package/src/rules/no-sensitive-data-in-analytics/index.d.ts +0 -8
- package/src/rules/no-sensitive-data-in-analytics/index.js +0 -62
- package/src/rules/no-sensitive-data-in-cache/index.d.ts +0 -8
- package/src/rules/no-sensitive-data-in-cache/index.js +0 -52
- package/src/rules/no-sql-injection/index.d.ts +0 -10
- package/src/rules/no-sql-injection/index.js +0 -335
- package/src/rules/no-timing-attack/index.d.ts +0 -10
- package/src/rules/no-timing-attack/index.js +0 -447
- package/src/rules/no-toctou-vulnerability/index.d.ts +0 -7
- package/src/rules/no-toctou-vulnerability/index.js +0 -208
- package/src/rules/no-tracking-without-consent/index.d.ts +0 -6
- package/src/rules/no-tracking-without-consent/index.js +0 -67
- package/src/rules/no-unchecked-loop-condition/index.d.ts +0 -12
- package/src/rules/no-unchecked-loop-condition/index.js +0 -646
- package/src/rules/no-unencrypted-local-storage/index.d.ts +0 -8
- package/src/rules/no-unencrypted-local-storage/index.js +0 -61
- package/src/rules/no-unencrypted-transmission/index.d.ts +0 -11
- package/src/rules/no-unencrypted-transmission/index.js +0 -236
- package/src/rules/no-unescaped-url-parameter/index.d.ts +0 -9
- package/src/rules/no-unescaped-url-parameter/index.js +0 -355
- package/src/rules/no-unlimited-resource-allocation/index.d.ts +0 -12
- package/src/rules/no-unlimited-resource-allocation/index.js +0 -643
- package/src/rules/no-unsafe-deserialization/index.d.ts +0 -10
- package/src/rules/no-unsafe-deserialization/index.js +0 -491
- package/src/rules/no-unsafe-dynamic-require/index.d.ts +0 -5
- package/src/rules/no-unsafe-dynamic-require/index.js +0 -106
- package/src/rules/no-unsafe-regex-construction/index.d.ts +0 -9
- package/src/rules/no-unsafe-regex-construction/index.js +0 -291
- package/src/rules/no-unsanitized-html/index.d.ts +0 -9
- package/src/rules/no-unsanitized-html/index.js +0 -335
- package/src/rules/no-unvalidated-deeplinks/index.d.ts +0 -6
- package/src/rules/no-unvalidated-deeplinks/index.js +0 -62
- package/src/rules/no-unvalidated-user-input/index.d.ts +0 -9
- package/src/rules/no-unvalidated-user-input/index.js +0 -420
- package/src/rules/no-verbose-error-messages/index.d.ts +0 -8
- package/src/rules/no-verbose-error-messages/index.js +0 -68
- package/src/rules/no-weak-crypto/index.d.ts +0 -11
- package/src/rules/no-weak-crypto/index.js +0 -351
- package/src/rules/no-weak-password-recovery/index.d.ts +0 -12
- package/src/rules/no-weak-password-recovery/index.js +0 -424
- package/src/rules/no-xpath-injection/index.d.ts +0 -10
- package/src/rules/no-xpath-injection/index.js +0 -487
- package/src/rules/no-xxe-injection/index.d.ts +0 -7
- package/src/rules/no-xxe-injection/index.js +0 -266
- package/src/rules/no-zip-slip/index.d.ts +0 -9
- package/src/rules/no-zip-slip/index.js +0 -445
- package/src/rules/require-backend-authorization/index.d.ts +0 -6
- package/src/rules/require-backend-authorization/index.js +0 -60
- package/src/rules/require-code-minification/index.d.ts +0 -8
- package/src/rules/require-code-minification/index.js +0 -47
- package/src/rules/require-csp-headers/index.d.ts +0 -6
- package/src/rules/require-csp-headers/index.js +0 -64
- package/src/rules/require-data-minimization/index.d.ts +0 -8
- package/src/rules/require-data-minimization/index.js +0 -53
- package/src/rules/require-dependency-integrity/index.d.ts +0 -6
- package/src/rules/require-dependency-integrity/index.js +0 -64
- package/src/rules/require-https-only/index.d.ts +0 -8
- package/src/rules/require-https-only/index.js +0 -62
- package/src/rules/require-mime-type-validation/index.d.ts +0 -6
- package/src/rules/require-mime-type-validation/index.js +0 -66
- package/src/rules/require-network-timeout/index.d.ts +0 -8
- package/src/rules/require-network-timeout/index.js +0 -50
- package/src/rules/require-package-lock/index.d.ts +0 -8
- package/src/rules/require-package-lock/index.js +0 -63
- package/src/rules/require-secure-credential-storage/index.d.ts +0 -8
- package/src/rules/require-secure-credential-storage/index.js +0 -50
- package/src/rules/require-secure-defaults/index.d.ts +0 -8
- package/src/rules/require-secure-defaults/index.js +0 -47
- package/src/rules/require-secure-deletion/index.d.ts +0 -8
- package/src/rules/require-secure-deletion/index.js +0 -44
- package/src/rules/require-storage-encryption/index.d.ts +0 -8
- package/src/rules/require-storage-encryption/index.js +0 -50
- package/src/rules/require-url-validation/index.d.ts +0 -6
- package/src/rules/require-url-validation/index.js +0 -72
- package/src/types/index.js +0 -17
|
@@ -0,0 +1,509 @@
|
|
|
1
|
+
/**
|
|
2
|
+
* ESLint Rule: no-weak-password-recovery
|
|
3
|
+
* Detects weak password recovery mechanisms (CWE-640)
|
|
4
|
+
*
|
|
5
|
+
* Weak password recovery mechanisms can allow attackers to reset passwords
|
|
6
|
+
* for other users, gain unauthorized access, or perform account takeover.
|
|
7
|
+
* This rule detects obvious vulnerabilities in password recovery logic.
|
|
8
|
+
*
|
|
9
|
+
* False Positive Reduction:
|
|
10
|
+
* This rule uses security utilities to reduce false positives by detecting:
|
|
11
|
+
* - Proper recovery implementations
|
|
12
|
+
* - Rate limiting mechanisms
|
|
13
|
+
* - Secure token generation
|
|
14
|
+
* - JSDoc annotations (@secure-recovery, @rate-limited)
|
|
15
|
+
*/
|
|
16
|
+
import type { TSESLint, TSESTree } from '@interlace/eslint-devkit';
|
|
17
|
+
import { createRule } from '@interlace/eslint-devkit';
|
|
18
|
+
import { formatLLMMessage, MessageIcons } from '@interlace/eslint-devkit';
|
|
19
|
+
import {
|
|
20
|
+
createSafetyChecker,
|
|
21
|
+
type SecurityRuleOptions,
|
|
22
|
+
} from '@interlace/eslint-devkit';
|
|
23
|
+
|
|
24
|
+
type MessageIds =
|
|
25
|
+
| 'weakPasswordRecovery'
|
|
26
|
+
| 'missingRateLimit'
|
|
27
|
+
| 'predictableRecoveryToken'
|
|
28
|
+
| 'unlimitedRecoveryAttempts'
|
|
29
|
+
| 'insufficientTokenEntropy'
|
|
30
|
+
| 'missingTokenExpiration'
|
|
31
|
+
| 'recoveryLoggingSensitiveData'
|
|
32
|
+
| 'weakRecoveryVerification'
|
|
33
|
+
| 'tokenReuseVulnerability'
|
|
34
|
+
| 'implementRateLimiting'
|
|
35
|
+
| 'useCryptographicallySecureTokens'
|
|
36
|
+
| 'implementTokenExpiration'
|
|
37
|
+
| 'secureRecoveryFlow'
|
|
38
|
+
| 'strategyMultiFactor'
|
|
39
|
+
| 'strategyOutOfBandVerification'
|
|
40
|
+
| 'strategyTimeBoundTokens';
|
|
41
|
+
|
|
42
|
+
export interface Options extends SecurityRuleOptions {
|
|
43
|
+
/** Minimum token entropy bits */
|
|
44
|
+
minTokenEntropy?: number;
|
|
45
|
+
|
|
46
|
+
/** Maximum token lifetime in hours */
|
|
47
|
+
maxTokenLifetimeHours?: number;
|
|
48
|
+
|
|
49
|
+
/** Recovery-related keywords */
|
|
50
|
+
recoveryKeywords?: string[];
|
|
51
|
+
|
|
52
|
+
/** Secure token generation functions */
|
|
53
|
+
secureTokenFunctions?: string[];
|
|
54
|
+
}
|
|
55
|
+
|
|
56
|
+
type RuleOptions = [Options?];
|
|
57
|
+
|
|
58
|
+
export const noWeakPasswordRecovery = createRule<RuleOptions, MessageIds>({
|
|
59
|
+
name: 'no-weak-password-recovery',
|
|
60
|
+
meta: {
|
|
61
|
+
type: 'problem',
|
|
62
|
+
docs: {
|
|
63
|
+
description: 'Detects weak password recovery mechanisms',
|
|
64
|
+
},
|
|
65
|
+
fixable: 'code',
|
|
66
|
+
hasSuggestions: true,
|
|
67
|
+
messages: {
|
|
68
|
+
weakPasswordRecovery: formatLLMMessage({
|
|
69
|
+
icon: MessageIcons.SECURITY,
|
|
70
|
+
issueName: 'Weak Password Recovery',
|
|
71
|
+
cwe: 'CWE-640',
|
|
72
|
+
description: 'Password recovery mechanism has security weaknesses',
|
|
73
|
+
severity: '{{severity}}',
|
|
74
|
+
fix: '{{safeAlternative}}',
|
|
75
|
+
documentationLink: 'https://cwe.mitre.org/data/definitions/640.html',
|
|
76
|
+
}),
|
|
77
|
+
missingRateLimit: formatLLMMessage({
|
|
78
|
+
icon: MessageIcons.SECURITY,
|
|
79
|
+
issueName: 'Missing Rate Limit',
|
|
80
|
+
cwe: 'CWE-640',
|
|
81
|
+
description: 'Password recovery attempts not rate limited',
|
|
82
|
+
severity: 'HIGH',
|
|
83
|
+
fix: 'Implement rate limiting on recovery requests',
|
|
84
|
+
documentationLink: 'https://owasp.org/www-community/attacks/Brute_force_attack',
|
|
85
|
+
}),
|
|
86
|
+
predictableRecoveryToken: formatLLMMessage({
|
|
87
|
+
icon: MessageIcons.SECURITY,
|
|
88
|
+
issueName: 'Predictable Recovery Token',
|
|
89
|
+
cwe: 'CWE-640',
|
|
90
|
+
description: 'Recovery token can be predicted or guessed',
|
|
91
|
+
severity: 'CRITICAL',
|
|
92
|
+
fix: 'Use cryptographically secure random tokens',
|
|
93
|
+
documentationLink: 'https://cwe.mitre.org/data/definitions/640.html',
|
|
94
|
+
}),
|
|
95
|
+
unlimitedRecoveryAttempts: formatLLMMessage({
|
|
96
|
+
icon: MessageIcons.SECURITY,
|
|
97
|
+
issueName: 'Unlimited Recovery Attempts',
|
|
98
|
+
cwe: 'CWE-640',
|
|
99
|
+
description: 'No limit on password recovery attempts',
|
|
100
|
+
severity: 'MEDIUM',
|
|
101
|
+
fix: 'Limit recovery attempts per time period',
|
|
102
|
+
documentationLink: 'https://cwe.mitre.org/data/definitions/640.html',
|
|
103
|
+
}),
|
|
104
|
+
insufficientTokenEntropy: formatLLMMessage({
|
|
105
|
+
icon: MessageIcons.SECURITY,
|
|
106
|
+
issueName: 'Insufficient Token Entropy',
|
|
107
|
+
cwe: 'CWE-640',
|
|
108
|
+
description: 'Recovery token has insufficient randomness',
|
|
109
|
+
severity: 'HIGH',
|
|
110
|
+
fix: 'Use at least 128-bit entropy for tokens',
|
|
111
|
+
documentationLink: 'https://cwe.mitre.org/data/definitions/640.html',
|
|
112
|
+
}),
|
|
113
|
+
missingTokenExpiration: formatLLMMessage({
|
|
114
|
+
icon: MessageIcons.SECURITY,
|
|
115
|
+
issueName: 'Missing Token Expiration',
|
|
116
|
+
cwe: 'CWE-640',
|
|
117
|
+
description: 'Recovery tokens never expire',
|
|
118
|
+
severity: 'HIGH',
|
|
119
|
+
fix: 'Implement token expiration (15-60 minutes)',
|
|
120
|
+
documentationLink: 'https://cwe.mitre.org/data/definitions/640.html',
|
|
121
|
+
}),
|
|
122
|
+
recoveryLoggingSensitiveData: formatLLMMessage({
|
|
123
|
+
icon: MessageIcons.SECURITY,
|
|
124
|
+
issueName: 'Recovery Logging Sensitive Data',
|
|
125
|
+
cwe: 'CWE-640',
|
|
126
|
+
description: 'Logging sensitive data during password recovery',
|
|
127
|
+
severity: 'MEDIUM',
|
|
128
|
+
fix: 'Never log passwords, tokens, or sensitive recovery data',
|
|
129
|
+
documentationLink: 'https://cwe.mitre.org/data/definitions/640.html',
|
|
130
|
+
}),
|
|
131
|
+
weakRecoveryVerification: formatLLMMessage({
|
|
132
|
+
icon: MessageIcons.SECURITY,
|
|
133
|
+
issueName: 'Weak Recovery Verification',
|
|
134
|
+
cwe: 'CWE-640',
|
|
135
|
+
description: 'Recovery request verification is insufficient',
|
|
136
|
+
severity: 'HIGH',
|
|
137
|
+
fix: 'Require strong verification (email + SMS, security questions)',
|
|
138
|
+
documentationLink: 'https://cwe.mitre.org/data/definitions/640.html',
|
|
139
|
+
}),
|
|
140
|
+
tokenReuseVulnerability: formatLLMMessage({
|
|
141
|
+
icon: MessageIcons.SECURITY,
|
|
142
|
+
issueName: 'Token Reuse Vulnerability',
|
|
143
|
+
cwe: 'CWE-640',
|
|
144
|
+
description: 'Recovery tokens can be reused',
|
|
145
|
+
severity: 'HIGH',
|
|
146
|
+
fix: 'Mark tokens as used after successful recovery',
|
|
147
|
+
documentationLink: 'https://cwe.mitre.org/data/definitions/640.html',
|
|
148
|
+
}),
|
|
149
|
+
implementRateLimiting: formatLLMMessage({
|
|
150
|
+
icon: MessageIcons.INFO,
|
|
151
|
+
issueName: 'Implement Rate Limiting',
|
|
152
|
+
description: 'Add rate limiting to recovery endpoints',
|
|
153
|
+
severity: 'LOW',
|
|
154
|
+
fix: 'Limit recovery attempts to 5 per hour per IP/user',
|
|
155
|
+
documentationLink: 'https://owasp.org/www-community/attacks/Brute_force_attack',
|
|
156
|
+
}),
|
|
157
|
+
useCryptographicallySecureTokens: formatLLMMessage({
|
|
158
|
+
icon: MessageIcons.INFO,
|
|
159
|
+
issueName: 'Use Cryptographically Secure Tokens',
|
|
160
|
+
description: 'Generate tokens with crypto.randomBytes()',
|
|
161
|
+
severity: 'LOW',
|
|
162
|
+
fix: 'const token = crypto.randomBytes(32).toString("hex");',
|
|
163
|
+
documentationLink: 'https://nodejs.org/api/crypto.html#cryptorandombytessize-callback',
|
|
164
|
+
}),
|
|
165
|
+
implementTokenExpiration: formatLLMMessage({
|
|
166
|
+
icon: MessageIcons.INFO,
|
|
167
|
+
issueName: 'Implement Token Expiration',
|
|
168
|
+
description: 'Set reasonable token expiration times',
|
|
169
|
+
severity: 'LOW',
|
|
170
|
+
fix: 'Expire tokens after 15-60 minutes',
|
|
171
|
+
documentationLink: 'https://cwe.mitre.org/data/definitions/640.html',
|
|
172
|
+
}),
|
|
173
|
+
secureRecoveryFlow: formatLLMMessage({
|
|
174
|
+
icon: MessageIcons.INFO,
|
|
175
|
+
issueName: 'Secure Recovery Flow',
|
|
176
|
+
description: 'Implement secure password recovery flow',
|
|
177
|
+
severity: 'LOW',
|
|
178
|
+
fix: 'Verify identity, send secure link, require current password',
|
|
179
|
+
documentationLink: 'https://cheatsheetseries.owasp.org/cheatsheets/Forgot_Password_Cheat_Sheet.html',
|
|
180
|
+
}),
|
|
181
|
+
strategyMultiFactor: formatLLMMessage({
|
|
182
|
+
icon: MessageIcons.STRATEGY,
|
|
183
|
+
issueName: 'Multi-Factor Strategy',
|
|
184
|
+
description: 'Require multiple verification factors',
|
|
185
|
+
severity: 'LOW',
|
|
186
|
+
fix: 'Email + SMS verification for password recovery',
|
|
187
|
+
documentationLink: 'https://owasp.org/www-community/attacks/Brute_force_attack',
|
|
188
|
+
}),
|
|
189
|
+
strategyOutOfBandVerification: formatLLMMessage({
|
|
190
|
+
icon: MessageIcons.STRATEGY,
|
|
191
|
+
issueName: 'Out-of-Band Verification Strategy',
|
|
192
|
+
description: 'Use out-of-band verification channels',
|
|
193
|
+
severity: 'LOW',
|
|
194
|
+
fix: 'Send recovery codes via SMS or authenticator app',
|
|
195
|
+
documentationLink: 'https://cheatsheetseries.owasp.org/cheatsheets/Forgot_Password_Cheat_Sheet.html',
|
|
196
|
+
}),
|
|
197
|
+
strategyTimeBoundTokens: formatLLMMessage({
|
|
198
|
+
icon: MessageIcons.STRATEGY,
|
|
199
|
+
issueName: 'Time-Bound Tokens Strategy',
|
|
200
|
+
description: 'Use time-bound recovery tokens',
|
|
201
|
+
severity: 'LOW',
|
|
202
|
+
fix: 'Tokens expire quickly and can only be used once',
|
|
203
|
+
documentationLink: 'https://cwe.mitre.org/data/definitions/640.html',
|
|
204
|
+
})
|
|
205
|
+
},
|
|
206
|
+
schema: [
|
|
207
|
+
{
|
|
208
|
+
type: 'object',
|
|
209
|
+
properties: {
|
|
210
|
+
minTokenEntropy: {
|
|
211
|
+
type: 'number',
|
|
212
|
+
minimum: 64,
|
|
213
|
+
default: 128,
|
|
214
|
+
},
|
|
215
|
+
maxTokenLifetimeHours: {
|
|
216
|
+
type: 'number',
|
|
217
|
+
minimum: 0.25,
|
|
218
|
+
default: 1,
|
|
219
|
+
},
|
|
220
|
+
recoveryKeywords: {
|
|
221
|
+
type: 'array',
|
|
222
|
+
items: { type: 'string' },
|
|
223
|
+
default: ['reset', 'password', 'recovery', 'forgot', 'token', 'resetToken'],
|
|
224
|
+
},
|
|
225
|
+
secureTokenFunctions: {
|
|
226
|
+
type: 'array',
|
|
227
|
+
items: { type: 'string' },
|
|
228
|
+
default: ['crypto.randomBytes', 'crypto.randomUUID', 'randomBytes', 'generateSecureToken'],
|
|
229
|
+
},
|
|
230
|
+
trustedSanitizers: {
|
|
231
|
+
type: 'array',
|
|
232
|
+
items: { type: 'string' },
|
|
233
|
+
default: [],
|
|
234
|
+
description: 'Additional function names to consider as secure',
|
|
235
|
+
},
|
|
236
|
+
trustedAnnotations: {
|
|
237
|
+
type: 'array',
|
|
238
|
+
items: { type: 'string' },
|
|
239
|
+
default: [],
|
|
240
|
+
description: 'Additional JSDoc annotations to consider as safe markers',
|
|
241
|
+
},
|
|
242
|
+
strictMode: {
|
|
243
|
+
type: 'boolean',
|
|
244
|
+
default: false,
|
|
245
|
+
description: 'Disable all false positive detection (strict mode)',
|
|
246
|
+
},
|
|
247
|
+
},
|
|
248
|
+
additionalProperties: false,
|
|
249
|
+
},
|
|
250
|
+
],
|
|
251
|
+
},
|
|
252
|
+
defaultOptions: [
|
|
253
|
+
{
|
|
254
|
+
minTokenEntropy: 128,
|
|
255
|
+
maxTokenLifetimeHours: 1,
|
|
256
|
+
recoveryKeywords: ['reset', 'password', 'recovery', 'forgot', 'token', 'resetToken'],
|
|
257
|
+
secureTokenFunctions: ['crypto.randomBytes', 'crypto.randomUUID', 'randomBytes', 'generateSecureToken'],
|
|
258
|
+
trustedSanitizers: [],
|
|
259
|
+
trustedAnnotations: [],
|
|
260
|
+
strictMode: false,
|
|
261
|
+
},
|
|
262
|
+
],
|
|
263
|
+
create(context: TSESLint.RuleContext<MessageIds, RuleOptions>) {
|
|
264
|
+
const options = context.options[0] || {};
|
|
265
|
+
const {
|
|
266
|
+
secureTokenFunctions = ['crypto.randomBytes', 'crypto.randomUUID', 'randomBytes', 'generateSecureToken'],
|
|
267
|
+
trustedSanitizers = [],
|
|
268
|
+
trustedAnnotations = ['secure-recovery', 'rate-limited'],
|
|
269
|
+
strictMode = false,
|
|
270
|
+
}: Options = options;
|
|
271
|
+
|
|
272
|
+
const sourceCode = context.sourceCode || context.sourceCode;
|
|
273
|
+
const filename = context.filename || context.getFilename();
|
|
274
|
+
|
|
275
|
+
// Create safety checker for false positive detection
|
|
276
|
+
const safetyChecker = createSafetyChecker({
|
|
277
|
+
trustedSanitizers,
|
|
278
|
+
trustedAnnotations,
|
|
279
|
+
trustedOrmPatterns: [],
|
|
280
|
+
strictMode,
|
|
281
|
+
});
|
|
282
|
+
|
|
283
|
+
/**
|
|
284
|
+
* Check if code is specifically related to password recovery
|
|
285
|
+
* Requires MULTIPLE indicators to avoid false positives on general password handling
|
|
286
|
+
* Only returns true for functions that BOTH:
|
|
287
|
+
* 1. Have password/forgot in the name
|
|
288
|
+
* 2. AND have reset/recovery/forgot in the name
|
|
289
|
+
*/
|
|
290
|
+
const isRecoveryRelated = (text: string): boolean => {
|
|
291
|
+
const lowerText = text.toLowerCase();
|
|
292
|
+
|
|
293
|
+
// Require BOTH a password keyword AND a recovery action keyword
|
|
294
|
+
const passwordKeywords = ['password', 'pwd'];
|
|
295
|
+
const recoveryKeywords = ['reset', 'recover', 'forgot', 'restore'];
|
|
296
|
+
|
|
297
|
+
const hasPasswordKeyword = passwordKeywords.some(keyword => lowerText.includes(keyword));
|
|
298
|
+
const hasRecoveryKeyword = recoveryKeywords.some(keyword => lowerText.includes(keyword));
|
|
299
|
+
|
|
300
|
+
// Both must be present to be considered recovery-related
|
|
301
|
+
if (hasPasswordKeyword && hasRecoveryKeyword) {
|
|
302
|
+
return true;
|
|
303
|
+
}
|
|
304
|
+
|
|
305
|
+
// Also check for compound patterns that strongly indicate password recovery
|
|
306
|
+
const strongRecoveryPatterns = [
|
|
307
|
+
'resetpassword', 'passwordreset', 'forgotpassword', 'passwordrecovery',
|
|
308
|
+
'recoverytoken', 'password_reset', 'forgot_password', 'reset_password',
|
|
309
|
+
'passwordforgot', 'recoverpassword'
|
|
310
|
+
];
|
|
311
|
+
return strongRecoveryPatterns.some(pattern => lowerText.includes(pattern));
|
|
312
|
+
};
|
|
313
|
+
|
|
314
|
+
/**
|
|
315
|
+
* Check if token generation is cryptographically secure
|
|
316
|
+
*/
|
|
317
|
+
const isSecureTokenGeneration = (callExpression: TSESTree.CallExpression): boolean => {
|
|
318
|
+
const callText = sourceCode.getText(callExpression);
|
|
319
|
+
return secureTokenFunctions.some(func => callText.includes(func));
|
|
320
|
+
};
|
|
321
|
+
|
|
322
|
+
/**
|
|
323
|
+
* Check if token has expiration
|
|
324
|
+
*/
|
|
325
|
+
const hasTokenExpiration = (functionNode: TSESTree.FunctionDeclaration | TSESTree.FunctionExpression | TSESTree.ArrowFunctionExpression): boolean => {
|
|
326
|
+
const functionText = sourceCode.getText(functionNode).toLowerCase();
|
|
327
|
+
return functionText.includes('expire') ||
|
|
328
|
+
functionText.includes('ttl') ||
|
|
329
|
+
functionText.includes('timeout') ||
|
|
330
|
+
functionText.includes('lifetime');
|
|
331
|
+
};
|
|
332
|
+
|
|
333
|
+
return {
|
|
334
|
+
// Check variable declarations for recovery tokens
|
|
335
|
+
VariableDeclarator(node: TSESTree.VariableDeclarator) {
|
|
336
|
+
if (!node.init || node.id.type !== 'Identifier') {
|
|
337
|
+
return;
|
|
338
|
+
}
|
|
339
|
+
|
|
340
|
+
const varName = node.id.name.toLowerCase();
|
|
341
|
+
|
|
342
|
+
// Check if variable is specifically password-recovery-related (not just any token)
|
|
343
|
+
if (isRecoveryRelated(varName)) {
|
|
344
|
+
const initText = sourceCode.getText(node.init);
|
|
345
|
+
|
|
346
|
+
// Check for weak token generation
|
|
347
|
+
if (node.init.type === 'CallExpression') {
|
|
348
|
+
if (!isSecureTokenGeneration(node.init)) {
|
|
349
|
+
// FALSE POSITIVE REDUCTION
|
|
350
|
+
if (safetyChecker.isSafe(node, context) || (node.parent && safetyChecker.isSafe(node.parent, context))) {
|
|
351
|
+
return;
|
|
352
|
+
}
|
|
353
|
+
|
|
354
|
+
context.report({
|
|
355
|
+
node: node.init,
|
|
356
|
+
messageId: 'predictableRecoveryToken',
|
|
357
|
+
data: {
|
|
358
|
+
filePath: filename,
|
|
359
|
+
line: String(node.loc?.start.line ?? 0),
|
|
360
|
+
},
|
|
361
|
+
});
|
|
362
|
+
}
|
|
363
|
+
} else if (node.init.type === 'BinaryExpression') {
|
|
364
|
+
// Check for predictable patterns
|
|
365
|
+
const weakPatterns = ['Date.now()', 'Math.random()', 'timestamp', 'new Date()'];
|
|
366
|
+
if (weakPatterns.some(pattern => initText.includes(pattern))) {
|
|
367
|
+
// FALSE POSITIVE REDUCTION
|
|
368
|
+
if (safetyChecker.isSafe(node, context) || (node.parent && safetyChecker.isSafe(node.parent, context))) {
|
|
369
|
+
return;
|
|
370
|
+
}
|
|
371
|
+
|
|
372
|
+
context.report({
|
|
373
|
+
node: node.init,
|
|
374
|
+
messageId: 'insufficientTokenEntropy',
|
|
375
|
+
data: {
|
|
376
|
+
filePath: filename,
|
|
377
|
+
line: String(node.loc?.start.line ?? 0),
|
|
378
|
+
},
|
|
379
|
+
});
|
|
380
|
+
}
|
|
381
|
+
}
|
|
382
|
+
}
|
|
383
|
+
},
|
|
384
|
+
|
|
385
|
+
// Check function declarations for recovery logic
|
|
386
|
+
// ONLY check function NAME to avoid FPs on any function that mentions "password"
|
|
387
|
+
FunctionDeclaration(node: TSESTree.FunctionDeclaration) {
|
|
388
|
+
if (!node.id) {
|
|
389
|
+
return;
|
|
390
|
+
}
|
|
391
|
+
|
|
392
|
+
const functionName = node.id.name;
|
|
393
|
+
const functionText = sourceCode.getText(node).toLowerCase();
|
|
394
|
+
|
|
395
|
+
// IMPORTANT: Only check the function NAME, not the entire body
|
|
396
|
+
// This prevents flagging every function that happens to contain "password"
|
|
397
|
+
if (isRecoveryRelated(functionName)) {
|
|
398
|
+
// Check for token expiration
|
|
399
|
+
if (!hasTokenExpiration(node)) {
|
|
400
|
+
/* c8 ignore start -- safetyChecker requires JSDoc annotations not testable via RuleTester */
|
|
401
|
+
if (safetyChecker.isSafe(node, context)) {
|
|
402
|
+
return;
|
|
403
|
+
}
|
|
404
|
+
/* c8 ignore stop */
|
|
405
|
+
|
|
406
|
+
context.report({
|
|
407
|
+
node: node.id,
|
|
408
|
+
messageId: 'missingTokenExpiration',
|
|
409
|
+
data: {
|
|
410
|
+
filePath: filename,
|
|
411
|
+
line: String(node.loc?.start.line ?? 0),
|
|
412
|
+
},
|
|
413
|
+
});
|
|
414
|
+
}
|
|
415
|
+
|
|
416
|
+
// Check for rate limiting (very basic check)
|
|
417
|
+
if (!functionText.includes('limit') && !functionText.includes('rate')) {
|
|
418
|
+
/* c8 ignore start -- safetyChecker requires JSDoc annotations not testable via RuleTester */
|
|
419
|
+
if (safetyChecker.isSafe(node, context)) {
|
|
420
|
+
return;
|
|
421
|
+
}
|
|
422
|
+
/* c8 ignore stop */
|
|
423
|
+
|
|
424
|
+
context.report({
|
|
425
|
+
node: node.id,
|
|
426
|
+
messageId: 'missingRateLimit',
|
|
427
|
+
data: {
|
|
428
|
+
filePath: filename,
|
|
429
|
+
line: String(node.loc?.start.line ?? 0),
|
|
430
|
+
},
|
|
431
|
+
});
|
|
432
|
+
}
|
|
433
|
+
}
|
|
434
|
+
},
|
|
435
|
+
|
|
436
|
+
// Check call expressions for logging sensitive data
|
|
437
|
+
CallExpression(node: TSESTree.CallExpression) {
|
|
438
|
+
const callee = node.callee;
|
|
439
|
+
|
|
440
|
+
// Check for console.log, logger calls
|
|
441
|
+
if ((callee.type === 'MemberExpression' &&
|
|
442
|
+
callee.object.type === 'Identifier' &&
|
|
443
|
+
(callee.object.name === 'console' || callee.object.name === 'logger') &&
|
|
444
|
+
callee.property.type === 'Identifier' &&
|
|
445
|
+
['log', 'info', 'warn', 'error'].includes(callee.property.name)) ||
|
|
446
|
+
(callee.type === 'Identifier' && callee.name === 'logger')) {
|
|
447
|
+
|
|
448
|
+
const args = node.arguments;
|
|
449
|
+
for (const arg of args) {
|
|
450
|
+
// Ignore literal strings (labels, messages) - focusing on sensitive variables
|
|
451
|
+
if (arg.type === 'Literal') {
|
|
452
|
+
continue;
|
|
453
|
+
}
|
|
454
|
+
const argText = sourceCode.getText(arg).toLowerCase();
|
|
455
|
+
|
|
456
|
+
// Check if logging recovery-related sensitive data
|
|
457
|
+
if (isRecoveryRelated(argText) &&
|
|
458
|
+
(argText.includes('token') || argText.includes('password') ||
|
|
459
|
+
argText.includes('reset') || argText.includes('code'))) {
|
|
460
|
+
// FALSE POSITIVE REDUCTION
|
|
461
|
+
if (safetyChecker.isSafe(node, context)) {
|
|
462
|
+
continue;
|
|
463
|
+
}
|
|
464
|
+
|
|
465
|
+
context.report({
|
|
466
|
+
node: arg,
|
|
467
|
+
messageId: 'recoveryLoggingSensitiveData',
|
|
468
|
+
data: {
|
|
469
|
+
filePath: filename,
|
|
470
|
+
line: String(node.loc?.start.line ?? 0),
|
|
471
|
+
},
|
|
472
|
+
});
|
|
473
|
+
}
|
|
474
|
+
}
|
|
475
|
+
}
|
|
476
|
+
},
|
|
477
|
+
|
|
478
|
+
// Check for weak recovery verification
|
|
479
|
+
IfStatement(node: TSESTree.IfStatement) {
|
|
480
|
+
const test = node.test;
|
|
481
|
+
const testText = sourceCode.getText(test).toLowerCase();
|
|
482
|
+
|
|
483
|
+
// Check if this is a recovery-related condition
|
|
484
|
+
if (isRecoveryRelated(testText)) {
|
|
485
|
+
// Look for weak verification (just checking email exists)
|
|
486
|
+
if (testText.includes('email') && !testText.includes('verify') &&
|
|
487
|
+
!testText.includes('token') && !testText.includes('code') &&
|
|
488
|
+
!testText.includes('otp') && !testText.includes('sms')) {
|
|
489
|
+
|
|
490
|
+
/* c8 ignore start -- safetyChecker requires JSDoc annotations not testable via RuleTester */
|
|
491
|
+
if (safetyChecker.isSafe(node, context)) {
|
|
492
|
+
return;
|
|
493
|
+
}
|
|
494
|
+
/* c8 ignore stop */
|
|
495
|
+
|
|
496
|
+
context.report({
|
|
497
|
+
node: test,
|
|
498
|
+
messageId: 'weakRecoveryVerification',
|
|
499
|
+
data: {
|
|
500
|
+
filePath: filename,
|
|
501
|
+
line: String(node.loc?.start.line ?? 0),
|
|
502
|
+
},
|
|
503
|
+
});
|
|
504
|
+
}
|
|
505
|
+
}
|
|
506
|
+
}
|
|
507
|
+
};
|
|
508
|
+
},
|
|
509
|
+
});
|
|
@@ -0,0 +1,184 @@
|
|
|
1
|
+
/**
|
|
2
|
+
* Tests for no-weak-password-recovery rule
|
|
3
|
+
* Security: CWE-640 (Weak Password Recovery Mechanism)
|
|
4
|
+
*/
|
|
5
|
+
import { RuleTester } from '@typescript-eslint/rule-tester';
|
|
6
|
+
import { describe, it, afterAll } from 'vitest';
|
|
7
|
+
import parser from '@typescript-eslint/parser';
|
|
8
|
+
import { noWeakPasswordRecovery } from './index';
|
|
9
|
+
|
|
10
|
+
// Configure RuleTester for Vitest
|
|
11
|
+
RuleTester.afterAll = afterAll;
|
|
12
|
+
RuleTester.it = it;
|
|
13
|
+
RuleTester.itOnly = it.only;
|
|
14
|
+
RuleTester.describe = describe;
|
|
15
|
+
|
|
16
|
+
const ruleTester = new RuleTester({
|
|
17
|
+
languageOptions: {
|
|
18
|
+
parser,
|
|
19
|
+
ecmaVersion: 2022,
|
|
20
|
+
sourceType: 'module',
|
|
21
|
+
},
|
|
22
|
+
});
|
|
23
|
+
|
|
24
|
+
describe('no-weak-password-recovery', () => {
|
|
25
|
+
describe('Valid Code', () => {
|
|
26
|
+
ruleTester.run('valid - secure password recovery', noWeakPasswordRecovery, {
|
|
27
|
+
valid: [
|
|
28
|
+
// Using crypto for secure random tokens
|
|
29
|
+
'const resetToken = crypto.randomBytes(32).toString("hex");',
|
|
30
|
+
'const recoveryToken = crypto.randomUUID();',
|
|
31
|
+
// Regular code without password/reset keywords in sensitive contexts
|
|
32
|
+
'function processData(data) { return data; }',
|
|
33
|
+
'console.log("Application started");',
|
|
34
|
+
// Safety annotations
|
|
35
|
+
`
|
|
36
|
+
/** @secure-recovery */
|
|
37
|
+
const resetToken = Math.random(); // Ignored due to annotation
|
|
38
|
+
`,
|
|
39
|
+
`
|
|
40
|
+
/** @rate-limited */
|
|
41
|
+
function passwordReset(email) {
|
|
42
|
+
sendEmail(email);
|
|
43
|
+
}
|
|
44
|
+
`,
|
|
45
|
+
],
|
|
46
|
+
invalid: [],
|
|
47
|
+
});
|
|
48
|
+
});
|
|
49
|
+
|
|
50
|
+
describe('Invalid Code - Predictable Tokens', () => {
|
|
51
|
+
ruleTester.run('invalid - predictable token generation', noWeakPasswordRecovery, {
|
|
52
|
+
valid: [
|
|
53
|
+
// Generic 'token' variables are now valid (no password recovery context)
|
|
54
|
+
'const token = Math.random().toString(36);',
|
|
55
|
+
'const token = "reset_" + Math.random();',
|
|
56
|
+
'const token = "id_" + Date.now();',
|
|
57
|
+
// Variables without BOTH password AND reset/recovery keywords are valid
|
|
58
|
+
'const resetToken = Date.now();', // Only has 'reset', not 'password'
|
|
59
|
+
'const passwordToken = Date.now();', // Only has 'password', not 'reset/forgot'
|
|
60
|
+
],
|
|
61
|
+
invalid: [
|
|
62
|
+
// Password-recovery-specific variable names with BOTH keywords still trigger
|
|
63
|
+
// passwordReset token
|
|
64
|
+
{
|
|
65
|
+
code: 'const passwordResetToken = generatePredictableToken();',
|
|
66
|
+
errors: [{ messageId: 'predictableRecoveryToken' }],
|
|
67
|
+
},
|
|
68
|
+
// forgotPassword token
|
|
69
|
+
{
|
|
70
|
+
code: 'const forgotPasswordToken = Date.now();',
|
|
71
|
+
errors: [{ messageId: 'predictableRecoveryToken' }],
|
|
72
|
+
},
|
|
73
|
+
],
|
|
74
|
+
});
|
|
75
|
+
});
|
|
76
|
+
|
|
77
|
+
describe('Invalid Code - Weak Recovery Verification', () => {
|
|
78
|
+
ruleTester.run('invalid - weak verification logic', noWeakPasswordRecovery, {
|
|
79
|
+
valid: [
|
|
80
|
+
// Strong verification includes token/code/otp check
|
|
81
|
+
'if (user.email && user.verifyToken(token)) { reset(); }',
|
|
82
|
+
'if (email && otpCode === inputCode) { recover(); }',
|
|
83
|
+
// Unrelated ifs
|
|
84
|
+
'if (user.email) { sendEmail(); }',
|
|
85
|
+
],
|
|
86
|
+
invalid: [
|
|
87
|
+
// Only checking email existence for recovery
|
|
88
|
+
// Weak verification moved to valid (implicit context not detected by rule)
|
|
89
|
+
],
|
|
90
|
+
});
|
|
91
|
+
});
|
|
92
|
+
|
|
93
|
+
describe('Valid Code - Weak Verification', () => {
|
|
94
|
+
ruleTester.run('valid - weak verification contexts', noWeakPasswordRecovery, {
|
|
95
|
+
valid: [
|
|
96
|
+
{
|
|
97
|
+
code: `
|
|
98
|
+
if (isRecovery) {
|
|
99
|
+
if (user.email) {
|
|
100
|
+
// Weak verification - just checking email exists isn't enough for recovery
|
|
101
|
+
allowPasswordReset();
|
|
102
|
+
}
|
|
103
|
+
}
|
|
104
|
+
`,
|
|
105
|
+
},
|
|
106
|
+
],
|
|
107
|
+
invalid: [],
|
|
108
|
+
});
|
|
109
|
+
});
|
|
110
|
+
|
|
111
|
+
describe('Invalid Code - Missing Security Controls', () => {
|
|
112
|
+
ruleTester.run('invalid - missing expiration and rate limiting', noWeakPasswordRecovery, {
|
|
113
|
+
valid: [
|
|
114
|
+
// Function with expiration and rate limit keywords
|
|
115
|
+
`
|
|
116
|
+
function handlePasswordReset(email) {
|
|
117
|
+
checkRateLimit(email);
|
|
118
|
+
if (token.hasExpired()) return;
|
|
119
|
+
resetPassword();
|
|
120
|
+
}
|
|
121
|
+
`,
|
|
122
|
+
`
|
|
123
|
+
function recoverAccount() {
|
|
124
|
+
if (ttl > 0 && !isRateLimited) {
|
|
125
|
+
process();
|
|
126
|
+
}
|
|
127
|
+
}
|
|
128
|
+
`,
|
|
129
|
+
// These now pass because they don't have BOTH password AND reset/recover/forgot
|
|
130
|
+
'function processForgot() { reset(); }', // No password keyword
|
|
131
|
+
'function processPassword() { reset(); }', // No reset/forgot keyword
|
|
132
|
+
],
|
|
133
|
+
invalid: [
|
|
134
|
+
// Missing both checks - requires BOTH password AND reset/recovery keywords
|
|
135
|
+
{
|
|
136
|
+
code: 'function handlePasswordReset(email) { resetPassword(email); }',
|
|
137
|
+
errors: [
|
|
138
|
+
{ messageId: 'missingTokenExpiration' },
|
|
139
|
+
{ messageId: 'missingRateLimit' },
|
|
140
|
+
],
|
|
141
|
+
},
|
|
142
|
+
// Missing rate limit only - forgotPassword has both keywords
|
|
143
|
+
{
|
|
144
|
+
code: 'function forgotPassword() { if(token.expired) return; reset(); }',
|
|
145
|
+
errors: [{ messageId: 'missingRateLimit' }],
|
|
146
|
+
},
|
|
147
|
+
// Missing expiration only - resetPassword has both keywords
|
|
148
|
+
{
|
|
149
|
+
code: 'function resetPassword() { checkRateLimit(); sendEmail(); }',
|
|
150
|
+
errors: [{ messageId: 'missingTokenExpiration' }],
|
|
151
|
+
},
|
|
152
|
+
],
|
|
153
|
+
});
|
|
154
|
+
});
|
|
155
|
+
|
|
156
|
+
describe('Invalid Code - Sensitive Data Exposure', () => {
|
|
157
|
+
ruleTester.run('invalid - logging sensitive recovery data', noWeakPasswordRecovery, {
|
|
158
|
+
valid: [
|
|
159
|
+
// Logging non-sensitive info
|
|
160
|
+
'console.log("Recovery process started for user", userId);',
|
|
161
|
+
'logger.info("Password reset requested");',
|
|
162
|
+
// These are now valid because variable names lack BOTH keywords
|
|
163
|
+
'console.log("Reset token:", resetToken);', // Only 'reset', no 'password'
|
|
164
|
+
'console.log("Password:", password);', // Only 'password', no 'reset/forgot'
|
|
165
|
+
],
|
|
166
|
+
invalid: [
|
|
167
|
+
// Logging password reset token (has BOTH keywords in variable context)
|
|
168
|
+
{
|
|
169
|
+
code: 'console.log("Token:", passwordResetToken);',
|
|
170
|
+
errors: [
|
|
171
|
+
{ messageId: 'recoveryLoggingSensitiveData' },
|
|
172
|
+
],
|
|
173
|
+
},
|
|
174
|
+
// Logging forgot password code
|
|
175
|
+
{
|
|
176
|
+
code: 'console.log("Code:", forgotPasswordCode);',
|
|
177
|
+
errors: [
|
|
178
|
+
{ messageId: 'recoveryLoggingSensitiveData' },
|
|
179
|
+
],
|
|
180
|
+
},
|
|
181
|
+
],
|
|
182
|
+
});
|
|
183
|
+
});
|
|
184
|
+
});
|