eslint-plugin-sdl-2 1.2.2 → 1.2.5
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/dist/_internal/ast-utils.d.ts.map +1 -1
- package/dist/_internal/ast-utils.js +9 -8
- package/dist/_internal/ast-utils.js.map +1 -1
- package/dist/_internal/create-rule.d.ts +3 -1
- package/dist/_internal/create-rule.d.ts.map +1 -1
- package/dist/_internal/create-rule.js +5 -1
- package/dist/_internal/create-rule.js.map +1 -1
- package/dist/_internal/domparser.d.ts.map +1 -1
- package/dist/_internal/domparser.js +8 -7
- package/dist/_internal/domparser.js.map +1 -1
- package/dist/_internal/electron-web-preferences.d.ts.map +1 -1
- package/dist/_internal/electron-web-preferences.js +12 -10
- package/dist/_internal/electron-web-preferences.js.map +1 -1
- package/dist/_internal/estree-utils.d.ts.map +1 -1
- package/dist/_internal/estree-utils.js +17 -15
- package/dist/_internal/estree-utils.js.map +1 -1
- package/dist/_internal/node-tls-config.d.ts.map +1 -1
- package/dist/_internal/node-tls-config.js +9 -8
- package/dist/_internal/node-tls-config.js.map +1 -1
- package/dist/_internal/rules-registry.d.ts.map +1 -1
- package/dist/_internal/rules-registry.js +142 -143
- package/dist/_internal/rules-registry.js.map +1 -1
- package/dist/_internal/script-element.d.ts.map +1 -1
- package/dist/_internal/script-element.js +6 -5
- package/dist/_internal/script-element.js.map +1 -1
- package/dist/_internal/worker-code-loading.d.ts.map +1 -1
- package/dist/_internal/worker-code-loading.js +18 -17
- package/dist/_internal/worker-code-loading.js.map +1 -1
- package/dist/plugin.cjs +579 -497
- package/dist/plugin.cjs.map +4 -4
- package/dist/plugin.d.ts.map +1 -1
- package/dist/plugin.js +38 -21
- package/dist/plugin.js.map +1 -1
- package/dist/rules/no-angular-bypass-security-trust-html.d.ts.map +1 -1
- package/dist/rules/no-angular-bypass-security-trust-html.js +4 -3
- package/dist/rules/no-angular-bypass-security-trust-html.js.map +1 -1
- package/dist/rules/no-angular-innerhtml-binding.js +1 -1
- package/dist/rules/no-angularjs-bypass-sce.d.ts.map +1 -1
- package/dist/rules/no-angularjs-bypass-sce.js +5 -4
- package/dist/rules/no-angularjs-bypass-sce.js.map +1 -1
- package/dist/rules/no-angularjs-enable-svg.d.ts.map +1 -1
- package/dist/rules/no-angularjs-enable-svg.js +2 -1
- package/dist/rules/no-angularjs-enable-svg.js.map +1 -1
- package/dist/rules/no-angularjs-ng-bind-html-without-sanitize.js +2 -2
- package/dist/rules/no-angularjs-sce-resource-url-wildcard.d.ts.map +1 -1
- package/dist/rules/no-angularjs-sce-resource-url-wildcard.js +8 -7
- package/dist/rules/no-angularjs-sce-resource-url-wildcard.js.map +1 -1
- package/dist/rules/no-child-process-exec.d.ts.map +1 -1
- package/dist/rules/no-child-process-exec.js +21 -17
- package/dist/rules/no-child-process-exec.js.map +1 -1
- package/dist/rules/no-child-process-shell-true.d.ts.map +1 -1
- package/dist/rules/no-child-process-shell-true.js +12 -10
- package/dist/rules/no-child-process-shell-true.js.map +1 -1
- package/dist/rules/no-document-domain.d.ts.map +1 -1
- package/dist/rules/no-document-domain.js +2 -1
- package/dist/rules/no-document-domain.js.map +1 -1
- package/dist/rules/no-document-execcommand-insert-html.d.ts.map +1 -1
- package/dist/rules/no-document-execcommand-insert-html.js +4 -3
- package/dist/rules/no-document-execcommand-insert-html.js.map +1 -1
- package/dist/rules/no-document-parse-html-unsafe.d.ts.map +1 -1
- package/dist/rules/no-document-parse-html-unsafe.js +6 -5
- package/dist/rules/no-document-parse-html-unsafe.js.map +1 -1
- package/dist/rules/no-document-write.d.ts.map +1 -1
- package/dist/rules/no-document-write.js +2 -1
- package/dist/rules/no-document-write.js.map +1 -1
- package/dist/rules/no-domparser-html-without-sanitization.d.ts.map +1 -1
- package/dist/rules/no-domparser-html-without-sanitization.js +3 -2
- package/dist/rules/no-domparser-html-without-sanitization.js.map +1 -1
- package/dist/rules/no-domparser-svg-without-sanitization.d.ts.map +1 -1
- package/dist/rules/no-domparser-svg-without-sanitization.js +3 -2
- package/dist/rules/no-domparser-svg-without-sanitization.js.map +1 -1
- package/dist/rules/no-dynamic-import-unsafe-url.js +1 -1
- package/dist/rules/no-electron-dangerous-blink-features.d.ts.map +1 -1
- package/dist/rules/no-electron-dangerous-blink-features.js +14 -11
- package/dist/rules/no-electron-dangerous-blink-features.js.map +1 -1
- package/dist/rules/no-electron-expose-raw-ipc-renderer.d.ts.map +1 -1
- package/dist/rules/no-electron-expose-raw-ipc-renderer.js +19 -18
- package/dist/rules/no-electron-expose-raw-ipc-renderer.js.map +1 -1
- package/dist/rules/no-electron-insecure-certificate-error-handler.d.ts.map +1 -1
- package/dist/rules/no-electron-insecure-certificate-error-handler.js +15 -9
- package/dist/rules/no-electron-insecure-certificate-error-handler.js.map +1 -1
- package/dist/rules/no-electron-insecure-certificate-verify-proc.d.ts.map +1 -1
- package/dist/rules/no-electron-insecure-certificate-verify-proc.js +12 -8
- package/dist/rules/no-electron-insecure-certificate-verify-proc.js.map +1 -1
- package/dist/rules/no-electron-insecure-permission-request-handler.d.ts.map +1 -1
- package/dist/rules/no-electron-insecure-permission-request-handler.js +12 -8
- package/dist/rules/no-electron-insecure-permission-request-handler.js.map +1 -1
- package/dist/rules/no-electron-permission-check-handler-allow-all.d.ts.map +1 -1
- package/dist/rules/no-electron-permission-check-handler-allow-all.js +8 -7
- package/dist/rules/no-electron-permission-check-handler-allow-all.js.map +1 -1
- package/dist/rules/no-electron-unchecked-ipc-sender.d.ts.map +1 -1
- package/dist/rules/no-electron-unchecked-ipc-sender.js +14 -10
- package/dist/rules/no-electron-unchecked-ipc-sender.js.map +1 -1
- package/dist/rules/no-electron-unrestricted-navigation.d.ts.map +1 -1
- package/dist/rules/no-electron-unrestricted-navigation.js +15 -11
- package/dist/rules/no-electron-unrestricted-navigation.js.map +1 -1
- package/dist/rules/no-electron-untrusted-open-external.d.ts.map +1 -1
- package/dist/rules/no-electron-untrusted-open-external.js +11 -9
- package/dist/rules/no-electron-untrusted-open-external.js.map +1 -1
- package/dist/rules/no-electron-webview-allowpopups.d.ts.map +1 -1
- package/dist/rules/no-electron-webview-allowpopups.js +7 -6
- package/dist/rules/no-electron-webview-allowpopups.js.map +1 -1
- package/dist/rules/no-electron-webview-insecure-webpreferences.d.ts.map +1 -1
- package/dist/rules/no-electron-webview-insecure-webpreferences.js +9 -8
- package/dist/rules/no-electron-webview-insecure-webpreferences.js.map +1 -1
- package/dist/rules/no-electron-webview-node-integration.d.ts.map +1 -1
- package/dist/rules/no-electron-webview-node-integration.js +9 -8
- package/dist/rules/no-electron-webview-node-integration.js.map +1 -1
- package/dist/rules/no-html-method.d.ts.map +1 -1
- package/dist/rules/no-html-method.js +3 -2
- package/dist/rules/no-html-method.js.map +1 -1
- package/dist/rules/no-http-request-to-insecure-protocol.d.ts.map +1 -1
- package/dist/rules/no-http-request-to-insecure-protocol.js +13 -10
- package/dist/rules/no-http-request-to-insecure-protocol.js.map +1 -1
- package/dist/rules/no-iframe-srcdoc.d.ts.map +1 -1
- package/dist/rules/no-iframe-srcdoc.js +13 -12
- package/dist/rules/no-iframe-srcdoc.js.map +1 -1
- package/dist/rules/no-inner-html.d.ts.map +1 -1
- package/dist/rules/no-inner-html.js +5 -4
- package/dist/rules/no-inner-html.js.map +1 -1
- package/dist/rules/no-insecure-random.d.ts.map +1 -1
- package/dist/rules/no-insecure-random.js +12 -10
- package/dist/rules/no-insecure-random.js.map +1 -1
- package/dist/rules/no-insecure-tls-agent-options.d.ts.map +1 -1
- package/dist/rules/no-insecure-tls-agent-options.js +10 -9
- package/dist/rules/no-insecure-tls-agent-options.js.map +1 -1
- package/dist/rules/no-insecure-url.d.ts.map +1 -1
- package/dist/rules/no-insecure-url.js +11 -10
- package/dist/rules/no-insecure-url.js.map +1 -1
- package/dist/rules/no-location-javascript-url.d.ts.map +1 -1
- package/dist/rules/no-location-javascript-url.js +11 -8
- package/dist/rules/no-location-javascript-url.js.map +1 -1
- package/dist/rules/no-message-event-without-origin-check.d.ts.map +1 -1
- package/dist/rules/no-message-event-without-origin-check.js +25 -29
- package/dist/rules/no-message-event-without-origin-check.js.map +1 -1
- package/dist/rules/no-node-tls-check-server-identity-bypass.d.ts.map +1 -1
- package/dist/rules/no-node-tls-check-server-identity-bypass.js +14 -13
- package/dist/rules/no-node-tls-check-server-identity-bypass.js.map +1 -1
- package/dist/rules/no-node-tls-legacy-protocol.d.ts.map +1 -1
- package/dist/rules/no-node-tls-legacy-protocol.js +6 -5
- package/dist/rules/no-node-tls-legacy-protocol.js.map +1 -1
- package/dist/rules/no-node-tls-reject-unauthorized-zero.d.ts.map +1 -1
- package/dist/rules/no-node-tls-reject-unauthorized-zero.js +11 -8
- package/dist/rules/no-node-tls-reject-unauthorized-zero.js.map +1 -1
- package/dist/rules/no-node-tls-security-level-zero.d.ts.map +1 -1
- package/dist/rules/no-node-tls-security-level-zero.js +6 -5
- package/dist/rules/no-node-tls-security-level-zero.js.map +1 -1
- package/dist/rules/no-node-vm-run-in-context.d.ts.map +1 -1
- package/dist/rules/no-node-vm-run-in-context.js +25 -21
- package/dist/rules/no-node-vm-run-in-context.js.map +1 -1
- package/dist/rules/no-node-vm-source-text-module.d.ts.map +1 -1
- package/dist/rules/no-node-vm-source-text-module.js +21 -17
- package/dist/rules/no-node-vm-source-text-module.js.map +1 -1
- package/dist/rules/no-node-worker-threads-eval.d.ts.map +1 -1
- package/dist/rules/no-node-worker-threads-eval.js +26 -21
- package/dist/rules/no-node-worker-threads-eval.js.map +1 -1
- package/dist/rules/no-nonnull-assertion-on-security-input.d.ts.map +1 -1
- package/dist/rules/no-nonnull-assertion-on-security-input.js +5 -4
- package/dist/rules/no-nonnull-assertion-on-security-input.js.map +1 -1
- package/dist/rules/no-postmessage-star-origin.d.ts.map +1 -1
- package/dist/rules/no-postmessage-star-origin.js +3 -2
- package/dist/rules/no-postmessage-star-origin.js.map +1 -1
- package/dist/rules/no-postmessage-without-origin-allowlist.d.ts.map +1 -1
- package/dist/rules/no-postmessage-without-origin-allowlist.js +10 -7
- package/dist/rules/no-postmessage-without-origin-allowlist.js.map +1 -1
- package/dist/rules/no-range-create-contextual-fragment.d.ts.map +1 -1
- package/dist/rules/no-range-create-contextual-fragment.js +8 -7
- package/dist/rules/no-range-create-contextual-fragment.js.map +1 -1
- package/dist/rules/no-script-src-data-url.d.ts.map +1 -1
- package/dist/rules/no-script-src-data-url.js +9 -8
- package/dist/rules/no-script-src-data-url.js.map +1 -1
- package/dist/rules/no-script-text.d.ts.map +1 -1
- package/dist/rules/no-script-text.js +2 -1
- package/dist/rules/no-script-text.js.map +1 -1
- package/dist/rules/no-service-worker-unsafe-script-url.d.ts.map +1 -1
- package/dist/rules/no-service-worker-unsafe-script-url.js +3 -2
- package/dist/rules/no-service-worker-unsafe-script-url.js.map +1 -1
- package/dist/rules/no-set-html-unsafe.d.ts.map +1 -1
- package/dist/rules/no-set-html-unsafe.js +3 -2
- package/dist/rules/no-set-html-unsafe.js.map +1 -1
- package/dist/rules/no-trusted-types-policy-pass-through.d.ts.map +1 -1
- package/dist/rules/no-trusted-types-policy-pass-through.js +19 -18
- package/dist/rules/no-trusted-types-policy-pass-through.js.map +1 -1
- package/dist/rules/no-unsafe-alloc.d.ts.map +1 -1
- package/dist/rules/no-unsafe-alloc.js +4 -3
- package/dist/rules/no-unsafe-alloc.js.map +1 -1
- package/dist/rules/no-unsafe-cast-to-trusted-types.d.ts.map +1 -1
- package/dist/rules/no-unsafe-cast-to-trusted-types.js +8 -7
- package/dist/rules/no-unsafe-cast-to-trusted-types.js.map +1 -1
- package/dist/rules/no-window-open-without-noopener.d.ts.map +1 -1
- package/dist/rules/no-window-open-without-noopener.js +10 -7
- package/dist/rules/no-window-open-without-noopener.js.map +1 -1
- package/dist/rules/no-worker-blob-url.d.ts.map +1 -1
- package/dist/rules/no-worker-blob-url.js +3 -2
- package/dist/rules/no-worker-blob-url.js.map +1 -1
- package/dist/rules/no-worker-data-url.d.ts.map +1 -1
- package/dist/rules/no-worker-data-url.js +3 -2
- package/dist/rules/no-worker-data-url.js.map +1 -1
- package/package.json +38 -39
|
@@ -1,24 +1,28 @@
|
|
|
1
|
+
import { AST_NODE_TYPES } from "@typescript-eslint/utils";
|
|
1
2
|
import { arrayAt } from "ts-extras";
|
|
2
3
|
import { createRule } from "../_internal/create-rule.js";
|
|
3
4
|
const getMemberPropertyName = (memberExpression) => {
|
|
4
5
|
if (!memberExpression.computed &&
|
|
5
|
-
memberExpression.property.type ===
|
|
6
|
+
memberExpression.property.type === AST_NODE_TYPES.Identifier) {
|
|
6
7
|
return memberExpression.property.name;
|
|
7
8
|
}
|
|
8
|
-
if (memberExpression.property.type ===
|
|
9
|
+
if (memberExpression.property.type === AST_NODE_TYPES.Literal &&
|
|
9
10
|
typeof memberExpression.property.value === "string") {
|
|
10
11
|
return memberExpression.property.value;
|
|
11
12
|
}
|
|
12
13
|
return undefined;
|
|
13
14
|
};
|
|
14
|
-
const isFunctionExpression = (expression) => expression.type ===
|
|
15
|
-
expression.type ===
|
|
15
|
+
const isFunctionExpression = (expression) => expression.type === AST_NODE_TYPES.ArrowFunctionExpression ||
|
|
16
|
+
expression.type === AST_NODE_TYPES.FunctionExpression;
|
|
16
17
|
const hasUnsafePermissionAllowPattern = (callbackNode, context, callbackParameterName) => {
|
|
17
18
|
const callbackSourceText = context.sourceCode.getText(callbackNode);
|
|
18
|
-
const escapedName = callbackParameterName.replaceAll("$",
|
|
19
|
+
const escapedName = callbackParameterName.replaceAll("$",
|
|
20
|
+
// eslint-disable-next-line unicorn/prefer-string-raw -- Replacement callback avoids `$` replacement-token semantics.
|
|
21
|
+
() => "\\$");
|
|
19
22
|
// eslint-disable-next-line security/detect-non-literal-regexp -- Callback identifier is escaped before interpolation for strict permission-allow detection.
|
|
20
23
|
const callbackPattern = new RegExp(String.raw `\b${escapedName}\s*\(\s*true\b`, "u");
|
|
21
24
|
return (callbackPattern.test(callbackSourceText) ||
|
|
25
|
+
// eslint-disable-next-line regexp/require-unicode-sets-regexp -- `/v` is not yet parseable in the current TypeScript-ESLint parser stack.
|
|
22
26
|
/\breturn\s+true\b/u.test(callbackSourceText));
|
|
23
27
|
};
|
|
24
28
|
/** Rule implementation. */
|
|
@@ -26,7 +30,7 @@ const rule = createRule({
|
|
|
26
30
|
create(context) {
|
|
27
31
|
return {
|
|
28
32
|
CallExpression(node) {
|
|
29
|
-
if (node.callee.type !==
|
|
33
|
+
if (node.callee.type !== AST_NODE_TYPES.MemberExpression) {
|
|
30
34
|
return;
|
|
31
35
|
}
|
|
32
36
|
if (getMemberPropertyName(node.callee) !==
|
|
@@ -35,12 +39,12 @@ const rule = createRule({
|
|
|
35
39
|
}
|
|
36
40
|
const [firstArgument] = node.arguments;
|
|
37
41
|
if (firstArgument === undefined ||
|
|
38
|
-
firstArgument.type ===
|
|
42
|
+
firstArgument.type === AST_NODE_TYPES.SpreadElement ||
|
|
39
43
|
!isFunctionExpression(firstArgument)) {
|
|
40
44
|
return;
|
|
41
45
|
}
|
|
42
46
|
const callbackParameter = arrayAt(firstArgument.params, -1);
|
|
43
|
-
if (callbackParameter?.type !==
|
|
47
|
+
if (callbackParameter?.type !== AST_NODE_TYPES.Identifier) {
|
|
44
48
|
return;
|
|
45
49
|
}
|
|
46
50
|
if (!hasUnsafePermissionAllowPattern(firstArgument, context, callbackParameter.name)) {
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"no-electron-insecure-permission-request-handler.js","sourceRoot":"","sources":["../../src/rules/no-electron-insecure-permission-request-handler.ts"],"names":[],"mappings":"AAGA,OAAO,EAAE,OAAO,EAAE,MAAM,WAAW,CAAC;AAEpC,OAAO,EAAE,UAAU,EAAE,MAAM,6BAA6B,CAAC;AAIzD,MAAM,qBAAqB,GAAG,CAC1B,gBAA2C,EACzB,EAAE;IACpB,IACI,CAAC,gBAAgB,CAAC,QAAQ;QAC1B,gBAAgB,CAAC,QAAQ,CAAC,IAAI,KAAK,
|
|
1
|
+
{"version":3,"file":"no-electron-insecure-permission-request-handler.js","sourceRoot":"","sources":["../../src/rules/no-electron-insecure-permission-request-handler.ts"],"names":[],"mappings":"AAGA,OAAO,EAAE,cAAc,EAAE,MAAM,0BAA0B,CAAC;AAC1D,OAAO,EAAE,OAAO,EAAE,MAAM,WAAW,CAAC;AAEpC,OAAO,EAAE,UAAU,EAAE,MAAM,6BAA6B,CAAC;AAIzD,MAAM,qBAAqB,GAAG,CAC1B,gBAA2C,EACzB,EAAE;IACpB,IACI,CAAC,gBAAgB,CAAC,QAAQ;QAC1B,gBAAgB,CAAC,QAAQ,CAAC,IAAI,KAAK,cAAc,CAAC,UAAU,EAC9D,CAAC;QACC,OAAO,gBAAgB,CAAC,QAAQ,CAAC,IAAI,CAAC;IAC1C,CAAC;IAED,IACI,gBAAgB,CAAC,QAAQ,CAAC,IAAI,KAAK,cAAc,CAAC,OAAO;QACzD,OAAO,gBAAgB,CAAC,QAAQ,CAAC,KAAK,KAAK,QAAQ,EACrD,CAAC;QACC,OAAO,gBAAgB,CAAC,QAAQ,CAAC,KAAK,CAAC;IAC3C,CAAC;IAED,OAAO,SAAS,CAAC;AACrB,CAAC,CAAC;AAEF,MAAM,oBAAoB,GAAG,CACzB,UAA2C,EAGb,EAAE,CAChC,UAAU,CAAC,IAAI,KAAK,cAAc,CAAC,uBAAuB;IAC1D,UAAU,CAAC,IAAI,KAAK,cAAc,CAAC,kBAAkB,CAAC;AAE1D,MAAM,+BAA+B,GAAG,CACpC,YAEiC,EACjC,OAAoD,EACpD,qBAA6B,EACtB,EAAE;IACT,MAAM,kBAAkB,GAAG,OAAO,CAAC,UAAU,CAAC,OAAO,CAAC,YAAY,CAAC,CAAC;IACpE,MAAM,WAAW,GAAG,qBAAqB,CAAC,UAAU,CAChD,GAAG;IACH,qHAAqH;IACrH,GAAG,EAAE,CAAC,KAAK,CACd,CAAC;IACF,4JAA4J;IAC5J,MAAM,eAAe,GAAG,IAAI,MAAM,CAC9B,MAAM,CAAC,GAAG,CAAA,KAAK,WAAW,gBAAgB,EAC1C,GAAG,CACN,CAAC;IAEF,OAAO,CACH,eAAe,CAAC,IAAI,CAAC,kBAAkB,CAAC;QACxC,0IAA0I;QAC1I,oBAAoB,CAAC,IAAI,CAAC,kBAAkB,CAAC,CAChD,CAAC;AACN,CAAC,CAAC;AAEF,2BAA2B;AAC3B,MAAM,IAAI,GAAkC,UAAU,CAAiB;IACnE,MAAM,CAAC,OAAO;QACV,OAAO;YACH,cAAc,CAAC,IAA6B;gBACxC,IAAI,IAAI,CAAC,MAAM,CAAC,IAAI,KAAK,cAAc,CAAC,gBAAgB,EAAE,CAAC;oBACvD,OAAO;gBACX,CAAC;gBAED,IACI,qBAAqB,CAAC,IAAI,CAAC,MAAM,CAAC;oBAClC,6BAA6B,EAC/B,CAAC;oBACC,OAAO;gBACX,CAAC;gBAED,MAAM,CAAC,aAAa,CAAC,GAAG,IAAI,CAAC,SAAS,CAAC;gBAEvC,IACI,aAAa,KAAK,SAAS;oBAC3B,aAAa,CAAC,IAAI,KAAK,cAAc,CAAC,aAAa;oBACnD,CAAC,oBAAoB,CAAC,aAAa,CAAC,EACtC,CAAC;oBACC,OAAO;gBACX,CAAC;gBAED,MAAM,iBAAiB,GAAG,OAAO,CAAC,aAAa,CAAC,MAAM,EAAE,CAAC,CAAC,CAAC,CAAC;gBAE5D,IAAI,iBAAiB,EAAE,IAAI,KAAK,cAAc,CAAC,UAAU,EAAE,CAAC;oBACxD,OAAO;gBACX,CAAC;gBAED,IACI,CAAC,+BAA+B,CAC5B,aAAa,EACb,OAAO,EACP,iBAAiB,CAAC,IAAI,CACzB,EACH,CAAC;oBACC,OAAO;gBACX,CAAC;gBAED,OAAO,CAAC,MAAM,CAAC;oBACX,SAAS,EAAE,SAAS;oBACpB,IAAI,EAAE,aAAa;iBACtB,CAAC,CAAC;YACP,CAAC;SACJ,CAAC;IACN,CAAC;IACD,IAAI,EAAE;QACF,UAAU,EAAE,KAAK;QACjB,IAAI,EAAE;YACF,WAAW,EACP,uFAAuF;YAC3F,MAAM,EAAE,KAAK;YACb,WAAW,EAAE,KAAK;YAClB,GAAG,EAAE,6GAA6G;SACrH;QACD,QAAQ,EAAE;YACN,OAAO,EACH,4EAA4E;SACnF;QACD,MAAM,EAAE,EAAE;QACV,IAAI,EAAE,SAAS;KAClB;IACD,IAAI,EAAE,iDAAiD;CAC1D,CAAC,CAAC;AAEH,eAAe,IAAI,CAAC;AACpB,iIAAiI"}
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"no-electron-permission-check-handler-allow-all.d.ts","sourceRoot":"","sources":["../../src/rules/no-electron-permission-check-handler-allow-all.ts"],"names":[],"mappings":"
|
|
1
|
+
{"version":3,"file":"no-electron-permission-check-handler-allow-all.d.ts","sourceRoot":"","sources":["../../src/rules/no-electron-permission-check-handler-allow-all.ts"],"names":[],"mappings":"AAMA,OAAO,EAAE,UAAU,EAAE,MAAM,6BAA6B,CAAC;AAqCzD,2BAA2B;AAC3B,QAAA,MAAM,IAAI,EAAE,UAAU,CAAC,OAAO,UAAU,CAkDtC,CAAC;AAEH,eAAe,IAAI,CAAC"}
|
|
@@ -1,18 +1,19 @@
|
|
|
1
|
+
import { AST_NODE_TYPES } from "@typescript-eslint/utils";
|
|
1
2
|
import { arrayFirst } from "ts-extras";
|
|
2
3
|
import { createRule } from "../_internal/create-rule.js";
|
|
3
4
|
import { getMemberPropertyName } from "../_internal/estree-utils.js";
|
|
4
|
-
const isFunctionExpression = (expression) => expression.type ===
|
|
5
|
-
expression.type ===
|
|
6
|
-
const isBooleanTrueLiteral = (expression) => expression?.type ===
|
|
5
|
+
const isFunctionExpression = (expression) => expression.type === AST_NODE_TYPES.ArrowFunctionExpression ||
|
|
6
|
+
expression.type === AST_NODE_TYPES.FunctionExpression;
|
|
7
|
+
const isBooleanTrueLiteral = (expression) => expression?.type === AST_NODE_TYPES.Literal && expression.value === true;
|
|
7
8
|
const isAllowAllPermissionCheckHandler = (callbackNode) => {
|
|
8
|
-
if (callbackNode.body.type !==
|
|
9
|
+
if (callbackNode.body.type !== AST_NODE_TYPES.BlockStatement) {
|
|
9
10
|
return isBooleanTrueLiteral(callbackNode.body);
|
|
10
11
|
}
|
|
11
12
|
if (callbackNode.body.body.length !== 1) {
|
|
12
13
|
return false;
|
|
13
14
|
}
|
|
14
15
|
const onlyStatement = arrayFirst(callbackNode.body.body);
|
|
15
|
-
return (onlyStatement?.type ===
|
|
16
|
+
return (onlyStatement?.type === AST_NODE_TYPES.ReturnStatement &&
|
|
16
17
|
isBooleanTrueLiteral(onlyStatement.argument));
|
|
17
18
|
};
|
|
18
19
|
/** Rule implementation. */
|
|
@@ -20,7 +21,7 @@ const rule = createRule({
|
|
|
20
21
|
create(context) {
|
|
21
22
|
return {
|
|
22
23
|
CallExpression(node) {
|
|
23
|
-
if (node.callee.type !==
|
|
24
|
+
if (node.callee.type !== AST_NODE_TYPES.MemberExpression) {
|
|
24
25
|
return;
|
|
25
26
|
}
|
|
26
27
|
if (getMemberPropertyName(node.callee) !==
|
|
@@ -29,7 +30,7 @@ const rule = createRule({
|
|
|
29
30
|
}
|
|
30
31
|
const [firstArgument] = node.arguments;
|
|
31
32
|
if (firstArgument === undefined ||
|
|
32
|
-
firstArgument.type ===
|
|
33
|
+
firstArgument.type === AST_NODE_TYPES.SpreadElement ||
|
|
33
34
|
!isFunctionExpression(firstArgument) ||
|
|
34
35
|
!isAllowAllPermissionCheckHandler(firstArgument)) {
|
|
35
36
|
return;
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"no-electron-permission-check-handler-allow-all.js","sourceRoot":"","sources":["../../src/rules/no-electron-permission-check-handler-allow-all.ts"],"names":[],"mappings":"AAGA,OAAO,EAAE,UAAU,EAAE,MAAM,WAAW,CAAC;AAEvC,OAAO,EAAE,UAAU,EAAE,MAAM,6BAA6B,CAAC;AACzD,OAAO,EAAE,qBAAqB,EAAE,MAAM,8BAA8B,CAAC;AAIrE,MAAM,oBAAoB,GAAG,CACzB,UAA2C,EAGb,EAAE,CAChC,UAAU,CAAC,IAAI,KAAK,
|
|
1
|
+
{"version":3,"file":"no-electron-permission-check-handler-allow-all.js","sourceRoot":"","sources":["../../src/rules/no-electron-permission-check-handler-allow-all.ts"],"names":[],"mappings":"AAGA,OAAO,EAAE,cAAc,EAAE,MAAM,0BAA0B,CAAC;AAC1D,OAAO,EAAE,UAAU,EAAE,MAAM,WAAW,CAAC;AAEvC,OAAO,EAAE,UAAU,EAAE,MAAM,6BAA6B,CAAC;AACzD,OAAO,EAAE,qBAAqB,EAAE,MAAM,8BAA8B,CAAC;AAIrE,MAAM,oBAAoB,GAAG,CACzB,UAA2C,EAGb,EAAE,CAChC,UAAU,CAAC,IAAI,KAAK,cAAc,CAAC,uBAAuB;IAC1D,UAAU,CAAC,IAAI,KAAK,cAAc,CAAC,kBAAkB,CAAC;AAE1D,MAAM,oBAAoB,GAAG,CACzB,UAAkD,EAC3C,EAAE,CACT,UAAU,EAAE,IAAI,KAAK,cAAc,CAAC,OAAO,IAAI,UAAU,CAAC,KAAK,KAAK,IAAI,CAAC;AAE7E,MAAM,gCAAgC,GAAG,CACrC,YAA4E,EACrE,EAAE;IACT,IAAI,YAAY,CAAC,IAAI,CAAC,IAAI,KAAK,cAAc,CAAC,cAAc,EAAE,CAAC;QAC3D,OAAO,oBAAoB,CAAC,YAAY,CAAC,IAAI,CAAC,CAAC;IACnD,CAAC;IAED,IAAI,YAAY,CAAC,IAAI,CAAC,IAAI,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;QACtC,OAAO,KAAK,CAAC;IACjB,CAAC;IAED,MAAM,aAAa,GAAG,UAAU,CAAC,YAAY,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IAEzD,OAAO,CACH,aAAa,EAAE,IAAI,KAAK,cAAc,CAAC,eAAe;QACtD,oBAAoB,CAAC,aAAa,CAAC,QAAQ,CAAC,CAC/C,CAAC;AACN,CAAC,CAAC;AAEF,2BAA2B;AAC3B,MAAM,IAAI,GAAkC,UAAU,CAAiB;IACnE,MAAM,CAAC,OAAO;QACV,OAAO;YACH,cAAc,CAAC,IAA6B;gBACxC,IAAI,IAAI,CAAC,MAAM,CAAC,IAAI,KAAK,cAAc,CAAC,gBAAgB,EAAE,CAAC;oBACvD,OAAO;gBACX,CAAC;gBAED,IACI,qBAAqB,CAAC,IAAI,CAAC,MAAM,CAAC;oBAClC,2BAA2B,EAC7B,CAAC;oBACC,OAAO;gBACX,CAAC;gBAED,MAAM,CAAC,aAAa,CAAC,GAAG,IAAI,CAAC,SAAS,CAAC;gBAEvC,IACI,aAAa,KAAK,SAAS;oBAC3B,aAAa,CAAC,IAAI,KAAK,cAAc,CAAC,aAAa;oBACnD,CAAC,oBAAoB,CAAC,aAAa,CAAC;oBACpC,CAAC,gCAAgC,CAAC,aAAa,CAAC,EAClD,CAAC;oBACC,OAAO;gBACX,CAAC;gBAED,OAAO,CAAC,MAAM,CAAC;oBACX,SAAS,EAAE,SAAS;oBACpB,IAAI,EAAE,aAAa;iBACtB,CAAC,CAAC;YACP,CAAC;SACJ,CAAC;IACN,CAAC;IACD,IAAI,EAAE;QACF,UAAU,EAAE,KAAK;QACjB,IAAI,EAAE;YACF,WAAW,EACP,kGAAkG;YACtG,MAAM,EAAE,KAAK;YACb,WAAW,EAAE,KAAK;YAClB,GAAG,EAAE,4GAA4G;SACpH;QACD,QAAQ,EAAE;YACN,OAAO,EACH,8EAA8E;SACrF;QACD,MAAM,EAAE,EAAE;QACV,IAAI,EAAE,SAAS;KAClB;IACD,IAAI,EAAE,gDAAgD;CACzD,CAAC,CAAC;AAEH,eAAe,IAAI,CAAC;AACpB,iIAAiI"}
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"no-electron-unchecked-ipc-sender.d.ts","sourceRoot":"","sources":["../../src/rules/no-electron-unchecked-ipc-sender.ts"],"names":[],"mappings":"
|
|
1
|
+
{"version":3,"file":"no-electron-unchecked-ipc-sender.d.ts","sourceRoot":"","sources":["../../src/rules/no-electron-unchecked-ipc-sender.ts"],"names":[],"mappings":"AAMA,OAAO,EAAE,UAAU,EAAE,MAAM,6BAA6B,CAAC;AA0FzD,2BAA2B;AAC3B,QAAA,MAAM,IAAI,EAAE,UAAU,CAAC,OAAO,UAAU,CA0DtC,CAAC;AAEH,eAAe,IAAI,CAAC"}
|
|
@@ -1,27 +1,28 @@
|
|
|
1
|
+
import { AST_NODE_TYPES } from "@typescript-eslint/utils";
|
|
1
2
|
import { arrayFirst } from "ts-extras";
|
|
2
3
|
import { createRule } from "../_internal/create-rule.js";
|
|
3
4
|
const getMemberPropertyName = (memberExpression) => {
|
|
4
5
|
if (!memberExpression.computed &&
|
|
5
|
-
memberExpression.property.type ===
|
|
6
|
+
memberExpression.property.type === AST_NODE_TYPES.Identifier) {
|
|
6
7
|
return memberExpression.property.name;
|
|
7
8
|
}
|
|
8
|
-
if (memberExpression.property.type ===
|
|
9
|
+
if (memberExpression.property.type === AST_NODE_TYPES.Literal &&
|
|
9
10
|
typeof memberExpression.property.value === "string") {
|
|
10
11
|
return memberExpression.property.value;
|
|
11
12
|
}
|
|
12
13
|
return undefined;
|
|
13
14
|
};
|
|
14
15
|
const isIpcMainObjectExpression = (expression) => {
|
|
15
|
-
if (expression.type ===
|
|
16
|
+
if (expression.type === AST_NODE_TYPES.Identifier) {
|
|
16
17
|
return expression.name === "ipcMain";
|
|
17
18
|
}
|
|
18
|
-
if (expression.type !==
|
|
19
|
+
if (expression.type !== AST_NODE_TYPES.MemberExpression) {
|
|
19
20
|
return false;
|
|
20
21
|
}
|
|
21
22
|
return getMemberPropertyName(expression) === "ipcMain";
|
|
22
23
|
};
|
|
23
24
|
const isIpcMainHandlerRegistration = (node) => {
|
|
24
|
-
if (node.callee.type !==
|
|
25
|
+
if (node.callee.type !== AST_NODE_TYPES.MemberExpression) {
|
|
25
26
|
return false;
|
|
26
27
|
}
|
|
27
28
|
const methodName = getMemberPropertyName(node.callee);
|
|
@@ -30,14 +31,17 @@ const isIpcMainHandlerRegistration = (node) => {
|
|
|
30
31
|
}
|
|
31
32
|
return isIpcMainObjectExpression(node.callee.object);
|
|
32
33
|
};
|
|
33
|
-
const isFunctionExpression = (expression) => expression.type ===
|
|
34
|
-
expression.type ===
|
|
34
|
+
const isFunctionExpression = (expression) => expression.type === AST_NODE_TYPES.ArrowFunctionExpression ||
|
|
35
|
+
expression.type === AST_NODE_TYPES.FunctionExpression;
|
|
35
36
|
const hasSenderValidationPattern = (callbackNode, context, eventParameterName) => {
|
|
36
37
|
const callbackSourceText = context.sourceCode.getText(callbackNode);
|
|
37
|
-
const escapedEventName = eventParameterName.replaceAll("$",
|
|
38
|
+
const escapedEventName = eventParameterName.replaceAll("$",
|
|
39
|
+
// eslint-disable-next-line etc-misc/no-unnecessary-template-literal -- String.raw preserves the intended regex-escape backslash.
|
|
40
|
+
() => String.raw `\$`);
|
|
38
41
|
// eslint-disable-next-line security/detect-non-literal-regexp -- Event parameter identifier is escaped before interpolation for sender-access detection.
|
|
39
42
|
const eventSenderPattern = new RegExp(String.raw `\b${escapedEventName}\s*\.\s*(?:sender|senderFrame)\b`, "u");
|
|
40
43
|
return (eventSenderPattern.test(callbackSourceText) ||
|
|
44
|
+
// eslint-disable-next-line regexp/require-unicode-sets-regexp -- `/v` is not yet parseable in the current TypeScript-ESLint parser stack.
|
|
41
45
|
/\b(?:allowlist|getURL|isTrusted|origin|validate|whitelist)\b/u.test(callbackSourceText));
|
|
42
46
|
};
|
|
43
47
|
/** Rule implementation. */
|
|
@@ -50,12 +54,12 @@ const rule = createRule({
|
|
|
50
54
|
}
|
|
51
55
|
const [, handlerNode] = node.arguments;
|
|
52
56
|
if (handlerNode === undefined ||
|
|
53
|
-
handlerNode.type ===
|
|
57
|
+
handlerNode.type === AST_NODE_TYPES.SpreadElement ||
|
|
54
58
|
!isFunctionExpression(handlerNode)) {
|
|
55
59
|
return;
|
|
56
60
|
}
|
|
57
61
|
const eventParameter = arrayFirst(handlerNode.params);
|
|
58
|
-
if (eventParameter?.type !==
|
|
62
|
+
if (eventParameter?.type !== AST_NODE_TYPES.Identifier) {
|
|
59
63
|
return;
|
|
60
64
|
}
|
|
61
65
|
if (hasSenderValidationPattern(handlerNode, context, eventParameter.name)) {
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"no-electron-unchecked-ipc-sender.js","sourceRoot":"","sources":["../../src/rules/no-electron-unchecked-ipc-sender.ts"],"names":[],"mappings":"AAGA,OAAO,EAAE,UAAU,EAAE,MAAM,WAAW,CAAC;AAEvC,OAAO,EAAE,UAAU,EAAE,MAAM,6BAA6B,CAAC;AAIzD,MAAM,qBAAqB,GAAG,CAC1B,gBAA2C,EACzB,EAAE;IACpB,IACI,CAAC,gBAAgB,CAAC,QAAQ;QAC1B,gBAAgB,CAAC,QAAQ,CAAC,IAAI,KAAK,
|
|
1
|
+
{"version":3,"file":"no-electron-unchecked-ipc-sender.js","sourceRoot":"","sources":["../../src/rules/no-electron-unchecked-ipc-sender.ts"],"names":[],"mappings":"AAGA,OAAO,EAAE,cAAc,EAAE,MAAM,0BAA0B,CAAC;AAC1D,OAAO,EAAE,UAAU,EAAE,MAAM,WAAW,CAAC;AAEvC,OAAO,EAAE,UAAU,EAAE,MAAM,6BAA6B,CAAC;AAIzD,MAAM,qBAAqB,GAAG,CAC1B,gBAA2C,EACzB,EAAE;IACpB,IACI,CAAC,gBAAgB,CAAC,QAAQ;QAC1B,gBAAgB,CAAC,QAAQ,CAAC,IAAI,KAAK,cAAc,CAAC,UAAU,EAC9D,CAAC;QACC,OAAO,gBAAgB,CAAC,QAAQ,CAAC,IAAI,CAAC;IAC1C,CAAC;IAED,IACI,gBAAgB,CAAC,QAAQ,CAAC,IAAI,KAAK,cAAc,CAAC,OAAO;QACzD,OAAO,gBAAgB,CAAC,QAAQ,CAAC,KAAK,KAAK,QAAQ,EACrD,CAAC;QACC,OAAO,gBAAgB,CAAC,QAAQ,CAAC,KAAK,CAAC;IAC3C,CAAC;IAED,OAAO,SAAS,CAAC;AACrB,CAAC,CAAC;AAEF,MAAM,yBAAyB,GAAG,CAC9B,UAA+B,EACxB,EAAE;IACT,IAAI,UAAU,CAAC,IAAI,KAAK,cAAc,CAAC,UAAU,EAAE,CAAC;QAChD,OAAO,UAAU,CAAC,IAAI,KAAK,SAAS,CAAC;IACzC,CAAC;IAED,IAAI,UAAU,CAAC,IAAI,KAAK,cAAc,CAAC,gBAAgB,EAAE,CAAC;QACtD,OAAO,KAAK,CAAC;IACjB,CAAC;IAED,OAAO,qBAAqB,CAAC,UAAU,CAAC,KAAK,SAAS,CAAC;AAC3D,CAAC,CAAC;AAEF,MAAM,4BAA4B,GAAG,CACjC,IAA6B,EACtB,EAAE;IACT,IAAI,IAAI,CAAC,MAAM,CAAC,IAAI,KAAK,cAAc,CAAC,gBAAgB,EAAE,CAAC;QACvD,OAAO,KAAK,CAAC;IACjB,CAAC;IAED,MAAM,UAAU,GAAG,qBAAqB,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC;IAEtD,IAAI,UAAU,KAAK,IAAI,IAAI,UAAU,KAAK,QAAQ,EAAE,CAAC;QACjD,OAAO,KAAK,CAAC;IACjB,CAAC;IAED,OAAO,yBAAyB,CAAC,IAAI,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC;AACzD,CAAC,CAAC;AAEF,MAAM,oBAAoB,GAAG,CACzB,UAA2C,EAGb,EAAE,CAChC,UAAU,CAAC,IAAI,KAAK,cAAc,CAAC,uBAAuB;IAC1D,UAAU,CAAC,IAAI,KAAK,cAAc,CAAC,kBAAkB,CAAC;AAE1D,MAAM,0BAA0B,GAAG,CAC/B,YAEiC,EACjC,OAAoD,EACpD,kBAA0B,EACnB,EAAE;IACT,MAAM,kBAAkB,GAAG,OAAO,CAAC,UAAU,CAAC,OAAO,CAAC,YAAY,CAAC,CAAC;IACpE,MAAM,gBAAgB,GAAG,kBAAkB,CAAC,UAAU,CAClD,GAAG;IACH,iIAAiI;IACjI,GAAG,EAAE,CAAC,MAAM,CAAC,GAAG,CAAA,IAAI,CACvB,CAAC;IACF,yJAAyJ;IACzJ,MAAM,kBAAkB,GAAG,IAAI,MAAM,CACjC,MAAM,CAAC,GAAG,CAAA,KAAK,gBAAgB,kCAAkC,EACjE,GAAG,CACN,CAAC;IAEF,OAAO,CACH,kBAAkB,CAAC,IAAI,CAAC,kBAAkB,CAAC;QAC3C,0IAA0I;QAC1I,+DAA+D,CAAC,IAAI,CAChE,kBAAkB,CACrB,CACJ,CAAC;AACN,CAAC,CAAC;AAEF,2BAA2B;AAC3B,MAAM,IAAI,GAAkC,UAAU,CAAiB;IACnE,MAAM,CAAC,OAAO;QACV,OAAO;YACH,cAAc,CAAC,IAA6B;gBACxC,IAAI,CAAC,4BAA4B,CAAC,IAAI,CAAC,EAAE,CAAC;oBACtC,OAAO;gBACX,CAAC;gBAED,MAAM,CAAC,EAAE,WAAW,CAAC,GAAG,IAAI,CAAC,SAAS,CAAC;gBAEvC,IACI,WAAW,KAAK,SAAS;oBACzB,WAAW,CAAC,IAAI,KAAK,cAAc,CAAC,aAAa;oBACjD,CAAC,oBAAoB,CAAC,WAAW,CAAC,EACpC,CAAC;oBACC,OAAO;gBACX,CAAC;gBAED,MAAM,cAAc,GAAG,UAAU,CAAC,WAAW,CAAC,MAAM,CAAC,CAAC;gBAEtD,IAAI,cAAc,EAAE,IAAI,KAAK,cAAc,CAAC,UAAU,EAAE,CAAC;oBACrD,OAAO;gBACX,CAAC;gBAED,IACI,0BAA0B,CACtB,WAAW,EACX,OAAO,EACP,cAAc,CAAC,IAAI,CACtB,EACH,CAAC;oBACC,OAAO;gBACX,CAAC;gBAED,OAAO,CAAC,MAAM,CAAC;oBACX,SAAS,EAAE,SAAS;oBACpB,IAAI,EAAE,WAAW;iBACpB,CAAC,CAAC;YACP,CAAC;SACJ,CAAC;IACN,CAAC;IACD,IAAI,EAAE;QACF,UAAU,EAAE,KAAK;QACjB,IAAI,EAAE;YACF,WAAW,EACP,+EAA+E;YACnF,MAAM,EAAE,KAAK;YACb,WAAW,EAAE,KAAK;YAClB,GAAG,EAAE,8FAA8F;SACtG;QACD,QAAQ,EAAE;YACN,OAAO,EACH,sFAAsF;SAC7F;QACD,MAAM,EAAE,EAAE;QACV,IAAI,EAAE,SAAS;KAClB;IACD,IAAI,EAAE,kCAAkC;CAC3C,CAAC,CAAC;AAEH,eAAe,IAAI,CAAC;AACpB,iIAAiI"}
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"no-electron-unrestricted-navigation.d.ts","sourceRoot":"","sources":["../../src/rules/no-electron-unrestricted-navigation.ts"],"names":[],"mappings":"
|
|
1
|
+
{"version":3,"file":"no-electron-unrestricted-navigation.d.ts","sourceRoot":"","sources":["../../src/rules/no-electron-unrestricted-navigation.ts"],"names":[],"mappings":"AAMA,OAAO,EAAE,UAAU,EAAE,MAAM,6BAA6B,CAAC;AAkEzD,2BAA2B;AAC3B,QAAA,MAAM,IAAI,EAAE,UAAU,CAAC,OAAO,UAAU,CAgGtC,CAAC;AAEH,eAAe,IAAI,CAAC"}
|
|
@@ -1,25 +1,29 @@
|
|
|
1
|
+
import { AST_NODE_TYPES } from "@typescript-eslint/utils";
|
|
1
2
|
import { arrayFirst } from "ts-extras";
|
|
2
3
|
import { createRule } from "../_internal/create-rule.js";
|
|
3
4
|
const getMemberPropertyName = (memberExpression) => {
|
|
4
5
|
if (!memberExpression.computed &&
|
|
5
|
-
memberExpression.property.type ===
|
|
6
|
+
memberExpression.property.type === AST_NODE_TYPES.Identifier) {
|
|
6
7
|
return memberExpression.property.name;
|
|
7
8
|
}
|
|
8
|
-
if (memberExpression.property.type ===
|
|
9
|
+
if (memberExpression.property.type === AST_NODE_TYPES.Literal &&
|
|
9
10
|
typeof memberExpression.property.value === "string") {
|
|
10
11
|
return memberExpression.property.value;
|
|
11
12
|
}
|
|
12
13
|
return undefined;
|
|
13
14
|
};
|
|
14
|
-
const isFunctionExpression = (expression) => expression.type ===
|
|
15
|
-
expression.type ===
|
|
15
|
+
const isFunctionExpression = (expression) => expression.type === AST_NODE_TYPES.ArrowFunctionExpression ||
|
|
16
|
+
expression.type === AST_NODE_TYPES.FunctionExpression;
|
|
16
17
|
const hasUnsafeAllowAction = (callbackNode, context) => {
|
|
17
18
|
const callbackSourceText = context.sourceCode.getText(callbackNode);
|
|
19
|
+
// eslint-disable-next-line regexp/require-unicode-sets-regexp -- `/v` is not yet parseable in the current TypeScript-ESLint parser stack.
|
|
18
20
|
return /\baction\s*:\s*["'`]allow["'`]/u.test(callbackSourceText);
|
|
19
21
|
};
|
|
20
22
|
const hasPreventDefaultCall = (callbackNode, context, eventParameterName) => {
|
|
21
23
|
const callbackSourceText = context.sourceCode.getText(callbackNode);
|
|
22
|
-
const escapedName = eventParameterName.replaceAll("$",
|
|
24
|
+
const escapedName = eventParameterName.replaceAll("$",
|
|
25
|
+
// eslint-disable-next-line unicorn/prefer-string-raw -- Replacement callback avoids `$` replacement-token semantics.
|
|
26
|
+
() => "\\$");
|
|
23
27
|
// eslint-disable-next-line security/detect-non-literal-regexp -- Event parameter identifier is escaped before interpolation for preventDefault-call detection.
|
|
24
28
|
const preventDefaultPattern = new RegExp(String.raw `\b${escapedName}\s*\.\s*preventDefault\s*\(`, "u");
|
|
25
29
|
return preventDefaultPattern.test(callbackSourceText);
|
|
@@ -29,14 +33,14 @@ const rule = createRule({
|
|
|
29
33
|
create(context) {
|
|
30
34
|
return {
|
|
31
35
|
CallExpression(node) {
|
|
32
|
-
if (node.callee.type !==
|
|
36
|
+
if (node.callee.type !== AST_NODE_TYPES.MemberExpression) {
|
|
33
37
|
return;
|
|
34
38
|
}
|
|
35
39
|
const methodName = getMemberPropertyName(node.callee);
|
|
36
40
|
if (methodName === "setWindowOpenHandler") {
|
|
37
41
|
const [firstArgument] = node.arguments;
|
|
38
42
|
if (firstArgument === undefined ||
|
|
39
|
-
firstArgument.type ===
|
|
43
|
+
firstArgument.type === AST_NODE_TYPES.SpreadElement ||
|
|
40
44
|
!isFunctionExpression(firstArgument)) {
|
|
41
45
|
return;
|
|
42
46
|
}
|
|
@@ -54,18 +58,18 @@ const rule = createRule({
|
|
|
54
58
|
}
|
|
55
59
|
const [firstArgument, secondArgument] = node.arguments;
|
|
56
60
|
if (firstArgument === undefined ||
|
|
57
|
-
firstArgument.type ===
|
|
61
|
+
firstArgument.type === AST_NODE_TYPES.SpreadElement ||
|
|
58
62
|
secondArgument === undefined ||
|
|
59
|
-
secondArgument.type ===
|
|
63
|
+
secondArgument.type === AST_NODE_TYPES.SpreadElement ||
|
|
60
64
|
!isFunctionExpression(secondArgument)) {
|
|
61
65
|
return;
|
|
62
66
|
}
|
|
63
|
-
if (firstArgument.type !==
|
|
67
|
+
if (firstArgument.type !== AST_NODE_TYPES.Literal ||
|
|
64
68
|
firstArgument.value !== "will-navigate") {
|
|
65
69
|
return;
|
|
66
70
|
}
|
|
67
71
|
const eventParameter = arrayFirst(secondArgument.params);
|
|
68
|
-
if (eventParameter?.type !==
|
|
72
|
+
if (eventParameter?.type !== AST_NODE_TYPES.Identifier) {
|
|
69
73
|
return;
|
|
70
74
|
}
|
|
71
75
|
if (hasPreventDefaultCall(secondArgument, context, eventParameter.name)) {
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"no-electron-unrestricted-navigation.js","sourceRoot":"","sources":["../../src/rules/no-electron-unrestricted-navigation.ts"],"names":[],"mappings":"AAGA,OAAO,EAAE,UAAU,EAAE,MAAM,WAAW,CAAC;AAEvC,OAAO,EAAE,UAAU,EAAE,MAAM,6BAA6B,CAAC;AAIzD,MAAM,qBAAqB,GAAG,CAC1B,gBAA2C,EACzB,EAAE;IACpB,IACI,CAAC,gBAAgB,CAAC,QAAQ;QAC1B,gBAAgB,CAAC,QAAQ,CAAC,IAAI,KAAK,
|
|
1
|
+
{"version":3,"file":"no-electron-unrestricted-navigation.js","sourceRoot":"","sources":["../../src/rules/no-electron-unrestricted-navigation.ts"],"names":[],"mappings":"AAGA,OAAO,EAAE,cAAc,EAAE,MAAM,0BAA0B,CAAC;AAC1D,OAAO,EAAE,UAAU,EAAE,MAAM,WAAW,CAAC;AAEvC,OAAO,EAAE,UAAU,EAAE,MAAM,6BAA6B,CAAC;AAIzD,MAAM,qBAAqB,GAAG,CAC1B,gBAA2C,EACzB,EAAE;IACpB,IACI,CAAC,gBAAgB,CAAC,QAAQ;QAC1B,gBAAgB,CAAC,QAAQ,CAAC,IAAI,KAAK,cAAc,CAAC,UAAU,EAC9D,CAAC;QACC,OAAO,gBAAgB,CAAC,QAAQ,CAAC,IAAI,CAAC;IAC1C,CAAC;IAED,IACI,gBAAgB,CAAC,QAAQ,CAAC,IAAI,KAAK,cAAc,CAAC,OAAO;QACzD,OAAO,gBAAgB,CAAC,QAAQ,CAAC,KAAK,KAAK,QAAQ,EACrD,CAAC;QACC,OAAO,gBAAgB,CAAC,QAAQ,CAAC,KAAK,CAAC;IAC3C,CAAC;IAED,OAAO,SAAS,CAAC;AACrB,CAAC,CAAC;AAEF,MAAM,oBAAoB,GAAG,CACzB,UAA2C,EAGb,EAAE,CAChC,UAAU,CAAC,IAAI,KAAK,cAAc,CAAC,uBAAuB;IAC1D,UAAU,CAAC,IAAI,KAAK,cAAc,CAAC,kBAAkB,CAAC;AAE1D,MAAM,oBAAoB,GAAG,CACzB,YAEiC,EACjC,OAAoD,EAC7C,EAAE;IACT,MAAM,kBAAkB,GAAG,OAAO,CAAC,UAAU,CAAC,OAAO,CAAC,YAAY,CAAC,CAAC;IAEpE,0IAA0I;IAC1I,OAAO,iCAAiC,CAAC,IAAI,CAAC,kBAAkB,CAAC,CAAC;AACtE,CAAC,CAAC;AAEF,MAAM,qBAAqB,GAAG,CAC1B,YAEiC,EACjC,OAAoD,EACpD,kBAA0B,EACnB,EAAE;IACT,MAAM,kBAAkB,GAAG,OAAO,CAAC,UAAU,CAAC,OAAO,CAAC,YAAY,CAAC,CAAC;IACpE,MAAM,WAAW,GAAG,kBAAkB,CAAC,UAAU,CAC7C,GAAG;IACH,qHAAqH;IACrH,GAAG,EAAE,CAAC,KAAK,CACd,CAAC;IACF,+JAA+J;IAC/J,MAAM,qBAAqB,GAAG,IAAI,MAAM,CACpC,MAAM,CAAC,GAAG,CAAA,KAAK,WAAW,6BAA6B,EACvD,GAAG,CACN,CAAC;IAEF,OAAO,qBAAqB,CAAC,IAAI,CAAC,kBAAkB,CAAC,CAAC;AAC1D,CAAC,CAAC;AAEF,2BAA2B;AAC3B,MAAM,IAAI,GAAkC,UAAU,CAAiB;IACnE,MAAM,CAAC,OAAO;QACV,OAAO;YACH,cAAc,CAAC,IAA6B;gBACxC,IAAI,IAAI,CAAC,MAAM,CAAC,IAAI,KAAK,cAAc,CAAC,gBAAgB,EAAE,CAAC;oBACvD,OAAO;gBACX,CAAC;gBAED,MAAM,UAAU,GAAG,qBAAqB,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC;gBAEtD,IAAI,UAAU,KAAK,sBAAsB,EAAE,CAAC;oBACxC,MAAM,CAAC,aAAa,CAAC,GAAG,IAAI,CAAC,SAAS,CAAC;oBAEvC,IACI,aAAa,KAAK,SAAS;wBAC3B,aAAa,CAAC,IAAI,KAAK,cAAc,CAAC,aAAa;wBACnD,CAAC,oBAAoB,CAAC,aAAa,CAAC,EACtC,CAAC;wBACC,OAAO;oBACX,CAAC;oBAED,IAAI,CAAC,oBAAoB,CAAC,aAAa,EAAE,OAAO,CAAC,EAAE,CAAC;wBAChD,OAAO;oBACX,CAAC;oBAED,OAAO,CAAC,MAAM,CAAC;wBACX,SAAS,EAAE,SAAS;wBACpB,IAAI,EAAE,aAAa;qBACtB,CAAC,CAAC;oBAEH,OAAO;gBACX,CAAC;gBAED,IAAI,UAAU,KAAK,IAAI,EAAE,CAAC;oBACtB,OAAO;gBACX,CAAC;gBAED,MAAM,CAAC,aAAa,EAAE,cAAc,CAAC,GAAG,IAAI,CAAC,SAAS,CAAC;gBAEvD,IACI,aAAa,KAAK,SAAS;oBAC3B,aAAa,CAAC,IAAI,KAAK,cAAc,CAAC,aAAa;oBACnD,cAAc,KAAK,SAAS;oBAC5B,cAAc,CAAC,IAAI,KAAK,cAAc,CAAC,aAAa;oBACpD,CAAC,oBAAoB,CAAC,cAAc,CAAC,EACvC,CAAC;oBACC,OAAO;gBACX,CAAC;gBAED,IACI,aAAa,CAAC,IAAI,KAAK,cAAc,CAAC,OAAO;oBAC7C,aAAa,CAAC,KAAK,KAAK,eAAe,EACzC,CAAC;oBACC,OAAO;gBACX,CAAC;gBAED,MAAM,cAAc,GAAG,UAAU,CAAC,cAAc,CAAC,MAAM,CAAC,CAAC;gBAEzD,IAAI,cAAc,EAAE,IAAI,KAAK,cAAc,CAAC,UAAU,EAAE,CAAC;oBACrD,OAAO;gBACX,CAAC;gBAED,IACI,qBAAqB,CACjB,cAAc,EACd,OAAO,EACP,cAAc,CAAC,IAAI,CACtB,EACH,CAAC;oBACC,OAAO;gBACX,CAAC;gBAED,OAAO,CAAC,MAAM,CAAC;oBACX,SAAS,EAAE,SAAS;oBACpB,IAAI,EAAE,cAAc;iBACvB,CAAC,CAAC;YACP,CAAC;SACJ,CAAC;IACN,CAAC;IACD,IAAI,EAAE;QACF,UAAU,EAAE,KAAK;QACjB,IAAI,EAAE;YACF,WAAW,EACP,6FAA6F;YACjG,MAAM,EAAE,KAAK;YACb,WAAW,EAAE,KAAK;YAClB,GAAG,EAAE,iGAAiG;SACzG;QACD,QAAQ,EAAE;YACN,OAAO,EACH,iGAAiG;SACxG;QACD,MAAM,EAAE,EAAE;QACV,IAAI,EAAE,SAAS;KAClB;IACD,IAAI,EAAE,qCAAqC;CAC9C,CAAC,CAAC;AAEH,eAAe,IAAI,CAAC;AACpB,iIAAiI"}
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"no-electron-untrusted-open-external.d.ts","sourceRoot":"","sources":["../../src/rules/no-electron-untrusted-open-external.ts"],"names":[],"mappings":"
|
|
1
|
+
{"version":3,"file":"no-electron-untrusted-open-external.d.ts","sourceRoot":"","sources":["../../src/rules/no-electron-untrusted-open-external.ts"],"names":[],"mappings":"AAMA,OAAO,EAAE,UAAU,EAAE,MAAM,6BAA6B,CAAC;AA8EzD,2BAA2B;AAC3B,QAAA,MAAM,IAAI,EAAE,UAAU,CAAC,OAAO,UAAU,CAkDtC,CAAC;AAEH,eAAe,IAAI,CAAC"}
|
|
@@ -1,3 +1,4 @@
|
|
|
1
|
+
import { AST_NODE_TYPES } from "@typescript-eslint/utils";
|
|
1
2
|
import { arrayFirst } from "ts-extras";
|
|
2
3
|
import { createRule } from "../_internal/create-rule.js";
|
|
3
4
|
const getStaticTemplateLiteralValue = (templateLiteral) => {
|
|
@@ -7,37 +8,38 @@ const getStaticTemplateLiteralValue = (templateLiteral) => {
|
|
|
7
8
|
return arrayFirst(templateLiteral.quasis)?.value.cooked ?? undefined;
|
|
8
9
|
};
|
|
9
10
|
const getStringValue = (node) => {
|
|
10
|
-
if (node.type ===
|
|
11
|
+
if (node.type === AST_NODE_TYPES.Literal &&
|
|
12
|
+
typeof node.value === "string") {
|
|
11
13
|
return node.value;
|
|
12
14
|
}
|
|
13
|
-
if (node.type ===
|
|
15
|
+
if (node.type === AST_NODE_TYPES.TemplateLiteral) {
|
|
14
16
|
return getStaticTemplateLiteralValue(node);
|
|
15
17
|
}
|
|
16
18
|
return undefined;
|
|
17
19
|
};
|
|
18
|
-
const isAllowedExternalProtocol = (value) => /^(?:https|mailto):/
|
|
20
|
+
const isAllowedExternalProtocol = (value) => /^(?:https|mailto):/iv.test(value.trim());
|
|
19
21
|
const getMemberPropertyName = (memberExpression) => {
|
|
20
22
|
if (!memberExpression.computed &&
|
|
21
|
-
memberExpression.property.type ===
|
|
23
|
+
memberExpression.property.type === AST_NODE_TYPES.Identifier) {
|
|
22
24
|
return memberExpression.property.name;
|
|
23
25
|
}
|
|
24
|
-
if (memberExpression.property.type ===
|
|
26
|
+
if (memberExpression.property.type === AST_NODE_TYPES.Literal &&
|
|
25
27
|
typeof memberExpression.property.value === "string") {
|
|
26
28
|
return memberExpression.property.value;
|
|
27
29
|
}
|
|
28
30
|
return undefined;
|
|
29
31
|
};
|
|
30
32
|
const isShellObjectExpression = (node) => {
|
|
31
|
-
if (node.type ===
|
|
33
|
+
if (node.type === AST_NODE_TYPES.Identifier) {
|
|
32
34
|
return node.name === "shell";
|
|
33
35
|
}
|
|
34
|
-
if (node.type !==
|
|
36
|
+
if (node.type !== AST_NODE_TYPES.MemberExpression) {
|
|
35
37
|
return false;
|
|
36
38
|
}
|
|
37
39
|
return getMemberPropertyName(node) === "shell";
|
|
38
40
|
};
|
|
39
41
|
const isShellOpenExternalCallee = (callee) => {
|
|
40
|
-
if (callee.type !==
|
|
42
|
+
if (callee.type !== AST_NODE_TYPES.MemberExpression) {
|
|
41
43
|
return false;
|
|
42
44
|
}
|
|
43
45
|
if (getMemberPropertyName(callee) !== "openExternal") {
|
|
@@ -55,7 +57,7 @@ const rule = createRule({
|
|
|
55
57
|
}
|
|
56
58
|
const [firstArgument] = node.arguments;
|
|
57
59
|
if (firstArgument === undefined ||
|
|
58
|
-
firstArgument.type ===
|
|
60
|
+
firstArgument.type === AST_NODE_TYPES.SpreadElement) {
|
|
59
61
|
return;
|
|
60
62
|
}
|
|
61
63
|
const firstArgumentValue = getStringValue(firstArgument);
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"no-electron-untrusted-open-external.js","sourceRoot":"","sources":["../../src/rules/no-electron-untrusted-open-external.ts"],"names":[],"mappings":"AAGA,OAAO,EAAE,UAAU,EAAE,MAAM,WAAW,CAAC;AAEvC,OAAO,EAAE,UAAU,EAAE,MAAM,6BAA6B,CAAC;AAIzD,MAAM,6BAA6B,GAAG,CAClC,eAAyC,EACvB,EAAE;IACpB,IAAI,eAAe,CAAC,WAAW,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;QACzC,OAAO,SAAS,CAAC;IACrB,CAAC;IAED,OAAO,UAAU,CAAC,eAAe,CAAC,MAAM,CAAC,EAAE,KAAK,CAAC,MAAM,IAAI,SAAS,CAAC;AACzE,CAAC,CAAC;AAEF,MAAM,cAAc,GAAG,CAAC,IAAyB,EAAsB,EAAE;IACrE,
|
|
1
|
+
{"version":3,"file":"no-electron-untrusted-open-external.js","sourceRoot":"","sources":["../../src/rules/no-electron-untrusted-open-external.ts"],"names":[],"mappings":"AAGA,OAAO,EAAE,cAAc,EAAE,MAAM,0BAA0B,CAAC;AAC1D,OAAO,EAAE,UAAU,EAAE,MAAM,WAAW,CAAC;AAEvC,OAAO,EAAE,UAAU,EAAE,MAAM,6BAA6B,CAAC;AAIzD,MAAM,6BAA6B,GAAG,CAClC,eAAyC,EACvB,EAAE;IACpB,IAAI,eAAe,CAAC,WAAW,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;QACzC,OAAO,SAAS,CAAC;IACrB,CAAC;IAED,OAAO,UAAU,CAAC,eAAe,CAAC,MAAM,CAAC,EAAE,KAAK,CAAC,MAAM,IAAI,SAAS,CAAC;AACzE,CAAC,CAAC;AAEF,MAAM,cAAc,GAAG,CAAC,IAAyB,EAAsB,EAAE;IACrE,IACI,IAAI,CAAC,IAAI,KAAK,cAAc,CAAC,OAAO;QACpC,OAAO,IAAI,CAAC,KAAK,KAAK,QAAQ,EAChC,CAAC;QACC,OAAO,IAAI,CAAC,KAAK,CAAC;IACtB,CAAC;IAED,IAAI,IAAI,CAAC,IAAI,KAAK,cAAc,CAAC,eAAe,EAAE,CAAC;QAC/C,OAAO,6BAA6B,CAAC,IAAI,CAAC,CAAC;IAC/C,CAAC;IAED,OAAO,SAAS,CAAC;AACrB,CAAC,CAAC;AAEF,MAAM,yBAAyB,GAAG,CAAC,KAAa,EAAW,EAAE,CACzD,sBAAsB,CAAC,IAAI,CAAC,KAAK,CAAC,IAAI,EAAE,CAAC,CAAC;AAE9C,MAAM,qBAAqB,GAAG,CAC1B,gBAA2C,EACzB,EAAE;IACpB,IACI,CAAC,gBAAgB,CAAC,QAAQ;QAC1B,gBAAgB,CAAC,QAAQ,CAAC,IAAI,KAAK,cAAc,CAAC,UAAU,EAC9D,CAAC;QACC,OAAO,gBAAgB,CAAC,QAAQ,CAAC,IAAI,CAAC;IAC1C,CAAC;IAED,IACI,gBAAgB,CAAC,QAAQ,CAAC,IAAI,KAAK,cAAc,CAAC,OAAO;QACzD,OAAO,gBAAgB,CAAC,QAAQ,CAAC,KAAK,KAAK,QAAQ,EACrD,CAAC;QACC,OAAO,gBAAgB,CAAC,QAAQ,CAAC,KAAK,CAAC;IAC3C,CAAC;IAED,OAAO,SAAS,CAAC;AACrB,CAAC,CAAC;AAEF,MAAM,uBAAuB,GAAG,CAAC,IAAyB,EAAW,EAAE;IACnE,IAAI,IAAI,CAAC,IAAI,KAAK,cAAc,CAAC,UAAU,EAAE,CAAC;QAC1C,OAAO,IAAI,CAAC,IAAI,KAAK,OAAO,CAAC;IACjC,CAAC;IAED,IAAI,IAAI,CAAC,IAAI,KAAK,cAAc,CAAC,gBAAgB,EAAE,CAAC;QAChD,OAAO,KAAK,CAAC;IACjB,CAAC;IAED,OAAO,qBAAqB,CAAC,IAAI,CAAC,KAAK,OAAO,CAAC;AACnD,CAAC,CAAC;AAEF,MAAM,yBAAyB,GAAG,CAC9B,MAAyC,EAClC,EAAE;IACT,IAAI,MAAM,CAAC,IAAI,KAAK,cAAc,CAAC,gBAAgB,EAAE,CAAC;QAClD,OAAO,KAAK,CAAC;IACjB,CAAC;IAED,IAAI,qBAAqB,CAAC,MAAM,CAAC,KAAK,cAAc,EAAE,CAAC;QACnD,OAAO,KAAK,CAAC;IACjB,CAAC;IAED,OAAO,uBAAuB,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC;AAClD,CAAC,CAAC;AAEF,2BAA2B;AAC3B,MAAM,IAAI,GAAkC,UAAU,CAAiB;IACnE,MAAM,CAAC,OAAO;QACV,OAAO;YACH,cAAc,CAAC,IAAI;gBACf,IAAI,CAAC,yBAAyB,CAAC,IAAI,CAAC,MAAM,CAAC,EAAE,CAAC;oBAC1C,OAAO;gBACX,CAAC;gBAED,MAAM,CAAC,aAAa,CAAC,GAAG,IAAI,CAAC,SAAS,CAAC;gBAEvC,IACI,aAAa,KAAK,SAAS;oBAC3B,aAAa,CAAC,IAAI,KAAK,cAAc,CAAC,aAAa,EACrD,CAAC;oBACC,OAAO;gBACX,CAAC;gBAED,MAAM,kBAAkB,GAAG,cAAc,CAAC,aAAa,CAAC,CAAC;gBAEzD,IACI,OAAO,kBAAkB,KAAK,QAAQ;oBACtC,yBAAyB,CAAC,kBAAkB,CAAC,EAC/C,CAAC;oBACC,OAAO;gBACX,CAAC;gBAED,OAAO,CAAC,MAAM,CAAC;oBACX,SAAS,EAAE,SAAS;oBACpB,IAAI,EAAE,aAAa;iBACtB,CAAC,CAAC;YACP,CAAC;SACJ,CAAC;IACN,CAAC;IACD,IAAI,EAAE;QACF,UAAU,EAAE,KAAK;QACjB,IAAI,EAAE;YACF,WAAW,EACP,uFAAuF;YAC3F,MAAM,EAAE,KAAK;YACb,WAAW,EAAE,KAAK;YAClB,GAAG,EAAE,iGAAiG;SACzG;QACD,QAAQ,EAAE;YACN,OAAO,EACH,mEAAmE;SAC1E;QACD,MAAM,EAAE,EAAE;QACV,IAAI,EAAE,SAAS;KAClB;IACD,IAAI,EAAE,qCAAqC;CAC9C,CAAC,CAAC;AAEH,eAAe,IAAI,CAAC;AACpB,iIAAiI"}
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"no-electron-webview-allowpopups.d.ts","sourceRoot":"","sources":["../../src/rules/no-electron-webview-allowpopups.ts"],"names":[],"mappings":"
|
|
1
|
+
{"version":3,"file":"no-electron-webview-allowpopups.d.ts","sourceRoot":"","sources":["../../src/rules/no-electron-webview-allowpopups.ts"],"names":[],"mappings":"AAKA,OAAO,EAAE,UAAU,EAAE,MAAM,6BAA6B,CAAC;AAuDzD,2BAA2B;AAC3B,QAAA,MAAM,IAAI,EAAE,UAAU,CAAC,OAAO,UAAU,CAiDtC,CAAC;AAEH,eAAe,IAAI,CAAC"}
|
|
@@ -1,12 +1,13 @@
|
|
|
1
|
+
import { AST_NODE_TYPES } from "@typescript-eslint/utils";
|
|
1
2
|
import { createRule } from "../_internal/create-rule.js";
|
|
2
3
|
const isJsxWebviewElement = (node) => {
|
|
3
|
-
if (node.name.type ===
|
|
4
|
+
if (node.name.type === AST_NODE_TYPES.JSXIdentifier) {
|
|
4
5
|
return node.name.name.toLowerCase() === "webview";
|
|
5
6
|
}
|
|
6
7
|
return false;
|
|
7
8
|
};
|
|
8
9
|
const getJsxAttributeName = (attributeNode) => {
|
|
9
|
-
if (attributeNode.name.type !==
|
|
10
|
+
if (attributeNode.name.type !== AST_NODE_TYPES.JSXIdentifier) {
|
|
10
11
|
return undefined;
|
|
11
12
|
}
|
|
12
13
|
return attributeNode.name.name.toLowerCase();
|
|
@@ -15,7 +16,7 @@ const isTruthyJsxAttributeValue = (attributeValue) => {
|
|
|
15
16
|
if (attributeValue === null) {
|
|
16
17
|
return true;
|
|
17
18
|
}
|
|
18
|
-
if (attributeValue.type ===
|
|
19
|
+
if (attributeValue.type === AST_NODE_TYPES.Literal) {
|
|
19
20
|
if (typeof attributeValue.value === "boolean") {
|
|
20
21
|
return attributeValue.value;
|
|
21
22
|
}
|
|
@@ -24,10 +25,10 @@ const isTruthyJsxAttributeValue = (attributeValue) => {
|
|
|
24
25
|
}
|
|
25
26
|
return false;
|
|
26
27
|
}
|
|
27
|
-
if (attributeValue.type !==
|
|
28
|
+
if (attributeValue.type !== AST_NODE_TYPES.JSXExpressionContainer) {
|
|
28
29
|
return false;
|
|
29
30
|
}
|
|
30
|
-
if (attributeValue.expression.type ===
|
|
31
|
+
if (attributeValue.expression.type === AST_NODE_TYPES.Literal &&
|
|
31
32
|
typeof attributeValue.expression.value === "boolean") {
|
|
32
33
|
return attributeValue.expression.value;
|
|
33
34
|
}
|
|
@@ -42,7 +43,7 @@ const rule = createRule({
|
|
|
42
43
|
return;
|
|
43
44
|
}
|
|
44
45
|
for (const attributeNode of node.attributes) {
|
|
45
|
-
if (attributeNode.type !==
|
|
46
|
+
if (attributeNode.type !== AST_NODE_TYPES.JSXAttribute) {
|
|
46
47
|
continue;
|
|
47
48
|
}
|
|
48
49
|
if (getJsxAttributeName(attributeNode) !== "allowpopups") {
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"no-electron-webview-allowpopups.js","sourceRoot":"","sources":["../../src/rules/no-electron-webview-allowpopups.ts"],"names":[],"mappings":"AAGA,OAAO,EAAE,UAAU,EAAE,MAAM,6BAA6B,CAAC;AAIzD,MAAM,mBAAmB,GAAG,CAAC,IAAgC,EAAW,EAAE;IACtE,IAAI,IAAI,CAAC,IAAI,CAAC,IAAI,KAAK,
|
|
1
|
+
{"version":3,"file":"no-electron-webview-allowpopups.js","sourceRoot":"","sources":["../../src/rules/no-electron-webview-allowpopups.ts"],"names":[],"mappings":"AAGA,OAAO,EAAE,cAAc,EAAE,MAAM,0BAA0B,CAAC;AAE1D,OAAO,EAAE,UAAU,EAAE,MAAM,6BAA6B,CAAC;AAIzD,MAAM,mBAAmB,GAAG,CAAC,IAAgC,EAAW,EAAE;IACtE,IAAI,IAAI,CAAC,IAAI,CAAC,IAAI,KAAK,cAAc,CAAC,aAAa,EAAE,CAAC;QAClD,OAAO,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,WAAW,EAAE,KAAK,SAAS,CAAC;IACtD,CAAC;IAED,OAAO,KAAK,CAAC;AACjB,CAAC,CAAC;AAEF,MAAM,mBAAmB,GAAG,CACxB,aAAoC,EAClB,EAAE;IACpB,IAAI,aAAa,CAAC,IAAI,CAAC,IAAI,KAAK,cAAc,CAAC,aAAa,EAAE,CAAC;QAC3D,OAAO,SAAS,CAAC;IACrB,CAAC;IAED,OAAO,aAAa,CAAC,IAAI,CAAC,IAAI,CAAC,WAAW,EAAE,CAAC;AACjD,CAAC,CAAC;AAEF,MAAM,yBAAyB,GAAG,CAC9B,cAA8C,EACvC,EAAE;IACT,IAAI,cAAc,KAAK,IAAI,EAAE,CAAC;QAC1B,OAAO,IAAI,CAAC;IAChB,CAAC;IAED,IAAI,cAAc,CAAC,IAAI,KAAK,cAAc,CAAC,OAAO,EAAE,CAAC;QACjD,IAAI,OAAO,cAAc,CAAC,KAAK,KAAK,SAAS,EAAE,CAAC;YAC5C,OAAO,cAAc,CAAC,KAAK,CAAC;QAChC,CAAC;QAED,IAAI,OAAO,cAAc,CAAC,KAAK,KAAK,QAAQ,EAAE,CAAC;YAC3C,OAAO,cAAc,CAAC,KAAK,CAAC,WAAW,EAAE,KAAK,OAAO,CAAC;QAC1D,CAAC;QAED,OAAO,KAAK,CAAC;IACjB,CAAC;IAED,IAAI,cAAc,CAAC,IAAI,KAAK,cAAc,CAAC,sBAAsB,EAAE,CAAC;QAChE,OAAO,KAAK,CAAC;IACjB,CAAC;IAED,IACI,cAAc,CAAC,UAAU,CAAC,IAAI,KAAK,cAAc,CAAC,OAAO;QACzD,OAAO,cAAc,CAAC,UAAU,CAAC,KAAK,KAAK,SAAS,EACtD,CAAC;QACC,OAAO,cAAc,CAAC,UAAU,CAAC,KAAK,CAAC;IAC3C,CAAC;IAED,OAAO,IAAI,CAAC;AAChB,CAAC,CAAC;AAEF,2BAA2B;AAC3B,MAAM,IAAI,GAAkC,UAAU,CAAiB;IACnE,MAAM,CAAC,OAAO;QACV,OAAO;YACH,iBAAiB,CAAC,IAAgC;gBAC9C,IAAI,CAAC,mBAAmB,CAAC,IAAI,CAAC,EAAE,CAAC;oBAC7B,OAAO;gBACX,CAAC;gBAED,KAAK,MAAM,aAAa,IAAI,IAAI,CAAC,UAAU,EAAE,CAAC;oBAC1C,IAAI,aAAa,CAAC,IAAI,KAAK,cAAc,CAAC,YAAY,EAAE,CAAC;wBACrD,SAAS;oBACb,CAAC;oBAED,IAAI,mBAAmB,CAAC,aAAa,CAAC,KAAK,aAAa,EAAE,CAAC;wBACvD,SAAS;oBACb,CAAC;oBAED,IAAI,CAAC,yBAAyB,CAAC,aAAa,CAAC,KAAK,CAAC,EAAE,CAAC;wBAClD,SAAS;oBACb,CAAC;oBAED,OAAO,CAAC,MAAM,CAAC;wBACX,GAAG,CAAC,KAAK;4BACL,OAAO,KAAK,CAAC,MAAM,CAAC,aAAa,CAAC,CAAC;wBACvC,CAAC;wBACD,SAAS,EAAE,SAAS;wBACpB,IAAI,EAAE,aAAa;qBACtB,CAAC,CAAC;gBACP,CAAC;YACL,CAAC;SACJ,CAAC;IACN,CAAC;IACD,IAAI,EAAE;QACF,UAAU,EAAE,KAAK;QACjB,IAAI,EAAE;YACF,WAAW,EACP,6DAA6D;YACjE,MAAM,EAAE,KAAK;YACb,WAAW,EAAE,KAAK;YAClB,GAAG,EAAE,6FAA6F;SACrG;QACD,OAAO,EAAE,MAAM;QACf,QAAQ,EAAE;YACN,OAAO,EAAE,yDAAyD;SACrE;QACD,MAAM,EAAE,EAAE;QACV,IAAI,EAAE,SAAS;KAClB;IACD,IAAI,EAAE,iCAAiC;CAC1C,CAAC,CAAC;AAEH,eAAe,IAAI,CAAC;AACpB,iIAAiI"}
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"no-electron-webview-insecure-webpreferences.d.ts","sourceRoot":"","sources":["../../src/rules/no-electron-webview-insecure-webpreferences.ts"],"names":[],"mappings":"
|
|
1
|
+
{"version":3,"file":"no-electron-webview-insecure-webpreferences.d.ts","sourceRoot":"","sources":["../../src/rules/no-electron-webview-insecure-webpreferences.ts"],"names":[],"mappings":"AAMA,OAAO,EAAE,UAAU,EAAE,MAAM,6BAA6B,CAAC;AA+CzD,2BAA2B;AAC3B,QAAA,MAAM,IAAI,EAAE,UAAU,CAAC,OAAO,UAAU,CA8DtC,CAAC;AAEH,eAAe,IAAI,CAAC"}
|
|
@@ -1,32 +1,33 @@
|
|
|
1
|
+
import { AST_NODE_TYPES } from "@typescript-eslint/utils";
|
|
1
2
|
import { arrayJoin, isEmpty } from "ts-extras";
|
|
2
3
|
import { createRule } from "../_internal/create-rule.js";
|
|
3
4
|
import { getStaticJsxAttributeStringValue } from "../_internal/estree-utils.js";
|
|
4
5
|
const UNSAFE_WEBPREFERENCES_PATTERNS = [
|
|
5
6
|
{
|
|
6
7
|
flagName: "allowRunningInsecureContent",
|
|
7
|
-
pattern: /\ballowrunninginsecurecontent\s*=\s*(?:1|on|true|yes)\b/
|
|
8
|
+
pattern: /\ballowrunninginsecurecontent\s*=\s*(?:1|on|true|yes)\b/iv,
|
|
8
9
|
},
|
|
9
10
|
{
|
|
10
11
|
flagName: "contextIsolation",
|
|
11
|
-
pattern: /\bcontextisolation\s*=\s*(?:0|false|no|off)\b/
|
|
12
|
+
pattern: /\bcontextisolation\s*=\s*(?:0|false|no|off)\b/iv,
|
|
12
13
|
},
|
|
13
14
|
{
|
|
14
15
|
flagName: "experimentalFeatures",
|
|
15
|
-
pattern: /\bexperimentalfeatures\s*=\s*(?:1|on|true|yes)\b/
|
|
16
|
+
pattern: /\bexperimentalfeatures\s*=\s*(?:1|on|true|yes)\b/iv,
|
|
16
17
|
},
|
|
17
18
|
{
|
|
18
19
|
flagName: "sandbox",
|
|
19
|
-
pattern: /\bsandbox\s*=\s*(?:0|false|no|off)\b/
|
|
20
|
+
pattern: /\bsandbox\s*=\s*(?:0|false|no|off)\b/iv,
|
|
20
21
|
},
|
|
21
22
|
{
|
|
22
23
|
flagName: "webSecurity",
|
|
23
|
-
pattern: /\bwebsecurity\s*=\s*(?:0|false|no|off)\b/
|
|
24
|
+
pattern: /\bwebsecurity\s*=\s*(?:0|false|no|off)\b/iv,
|
|
24
25
|
},
|
|
25
26
|
];
|
|
26
|
-
const isJsxWebviewElement = (node) => node.name.type ===
|
|
27
|
+
const isJsxWebviewElement = (node) => node.name.type === AST_NODE_TYPES.JSXIdentifier &&
|
|
27
28
|
node.name.name.toLowerCase() === "webview";
|
|
28
29
|
const getJsxAttributeName = (attributeNode) => {
|
|
29
|
-
if (attributeNode.name.type ===
|
|
30
|
+
if (attributeNode.name.type === AST_NODE_TYPES.JSXIdentifier) {
|
|
30
31
|
return attributeNode.name.name.toLowerCase();
|
|
31
32
|
}
|
|
32
33
|
return `${attributeNode.name.namespace.name}:${attributeNode.name.name.name}`.toLowerCase();
|
|
@@ -41,7 +42,7 @@ const rule = createRule({
|
|
|
41
42
|
return;
|
|
42
43
|
}
|
|
43
44
|
for (const attributeNode of node.attributes) {
|
|
44
|
-
if (attributeNode.type !==
|
|
45
|
+
if (attributeNode.type !== AST_NODE_TYPES.JSXAttribute) {
|
|
45
46
|
continue;
|
|
46
47
|
}
|
|
47
48
|
if (getJsxAttributeName(attributeNode) !== "webpreferences") {
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"no-electron-webview-insecure-webpreferences.js","sourceRoot":"","sources":["../../src/rules/no-electron-webview-insecure-webpreferences.ts"],"names":[],"mappings":"AAGA,OAAO,EAAE,SAAS,EAAE,OAAO,EAAE,MAAM,WAAW,CAAC;AAE/C,OAAO,EAAE,UAAU,EAAE,MAAM,6BAA6B,CAAC;AACzD,OAAO,EAAE,gCAAgC,EAAE,MAAM,8BAA8B,CAAC;AAIhF,MAAM,8BAA8B,GAAG;IACnC;QACI,QAAQ,EAAE,6BAA6B;QACvC,OAAO,EAAE,2DAA2D;KACvE;IACD;QACI,QAAQ,EAAE,kBAAkB;QAC5B,OAAO,EAAE,iDAAiD;KAC7D;IACD;QACI,QAAQ,EAAE,sBAAsB;QAChC,OAAO,EAAE,oDAAoD;KAChE;IACD;QACI,QAAQ,EAAE,SAAS;QACnB,OAAO,EAAE,wCAAwC;KACpD;IACD;QACI,QAAQ,EAAE,aAAa;QACvB,OAAO,EAAE,4CAA4C;KACxD;CACK,CAAC;AAEX,MAAM,mBAAmB,GAAG,CAAC,IAAgC,EAAW,EAAE,CACtE,IAAI,CAAC,IAAI,CAAC,IAAI,KAAK,
|
|
1
|
+
{"version":3,"file":"no-electron-webview-insecure-webpreferences.js","sourceRoot":"","sources":["../../src/rules/no-electron-webview-insecure-webpreferences.ts"],"names":[],"mappings":"AAGA,OAAO,EAAE,cAAc,EAAE,MAAM,0BAA0B,CAAC;AAC1D,OAAO,EAAE,SAAS,EAAE,OAAO,EAAE,MAAM,WAAW,CAAC;AAE/C,OAAO,EAAE,UAAU,EAAE,MAAM,6BAA6B,CAAC;AACzD,OAAO,EAAE,gCAAgC,EAAE,MAAM,8BAA8B,CAAC;AAIhF,MAAM,8BAA8B,GAAG;IACnC;QACI,QAAQ,EAAE,6BAA6B;QACvC,OAAO,EAAE,2DAA2D;KACvE;IACD;QACI,QAAQ,EAAE,kBAAkB;QAC5B,OAAO,EAAE,iDAAiD;KAC7D;IACD;QACI,QAAQ,EAAE,sBAAsB;QAChC,OAAO,EAAE,oDAAoD;KAChE;IACD;QACI,QAAQ,EAAE,SAAS;QACnB,OAAO,EAAE,wCAAwC;KACpD;IACD;QACI,QAAQ,EAAE,aAAa;QACvB,OAAO,EAAE,4CAA4C;KACxD;CACK,CAAC;AAEX,MAAM,mBAAmB,GAAG,CAAC,IAAgC,EAAW,EAAE,CACtE,IAAI,CAAC,IAAI,CAAC,IAAI,KAAK,cAAc,CAAC,aAAa;IAC/C,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,WAAW,EAAE,KAAK,SAAS,CAAC;AAE/C,MAAM,mBAAmB,GAAG,CAAC,aAAoC,EAAU,EAAE;IACzE,IAAI,aAAa,CAAC,IAAI,CAAC,IAAI,KAAK,cAAc,CAAC,aAAa,EAAE,CAAC;QAC3D,OAAO,aAAa,CAAC,IAAI,CAAC,IAAI,CAAC,WAAW,EAAE,CAAC;IACjD,CAAC;IAED,OAAO,GAAG,aAAa,CAAC,IAAI,CAAC,SAAS,CAAC,IAAI,IAAI,aAAa,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC,WAAW,EAAE,CAAC;AAChG,CAAC,CAAC;AAEF,MAAM,4BAA4B,GAAG,CACjC,cAAsB,EACL,EAAE,CACnB,8BAA8B,CAAC,OAAO,CAAC,CAAC,EAAE,QAAQ,EAAE,OAAO,EAAE,EAAE,EAAE,CAC7D,OAAO,CAAC,IAAI,CAAC,cAAc,CAAC,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,EAAE,CACjD,CAAC;AAEN,2BAA2B;AAC3B,MAAM,IAAI,GAAkC,UAAU,CAAiB;IACnE,MAAM,CAAC,OAAO;QACV,OAAO;YACH,iBAAiB,CAAC,IAAgC;gBAC9C,IAAI,CAAC,mBAAmB,CAAC,IAAI,CAAC,EAAE,CAAC;oBAC7B,OAAO;gBACX,CAAC;gBAED,KAAK,MAAM,aAAa,IAAI,IAAI,CAAC,UAAU,EAAE,CAAC;oBAC1C,IAAI,aAAa,CAAC,IAAI,KAAK,cAAc,CAAC,YAAY,EAAE,CAAC;wBACrD,SAAS;oBACb,CAAC;oBAED,IACI,mBAAmB,CAAC,aAAa,CAAC,KAAK,gBAAgB,EACzD,CAAC;wBACC,SAAS;oBACb,CAAC;oBAED,MAAM,WAAW,GAAG,gCAAgC,CAChD,aAAa,CAAC,KAAK,CACtB,CAAC;oBAEF,IAAI,OAAO,WAAW,KAAK,QAAQ,EAAE,CAAC;wBAClC,SAAS;oBACb,CAAC;oBAED,MAAM,WAAW,GACb,4BAA4B,CAAC,WAAW,CAAC,CAAC;oBAE9C,IAAI,OAAO,CAAC,WAAW,CAAC,EAAE,CAAC;wBACvB,SAAS;oBACb,CAAC;oBAED,OAAO,CAAC,MAAM,CAAC;wBACX,IAAI,EAAE;4BACF,KAAK,EAAE,SAAS,CAAC,WAAW,EAAE,IAAI,CAAC;yBACtC;wBACD,SAAS,EAAE,SAAS;wBACpB,IAAI,EAAE,aAAa;qBACtB,CAAC,CAAC;gBACP,CAAC;YACL,CAAC;SACJ,CAAC;IACN,CAAC;IACD,IAAI,EAAE;QACF,UAAU,EAAE,KAAK;QACjB,IAAI,EAAE;YACF,WAAW,EACP,+DAA+D;YACnE,MAAM,EAAE,KAAK;YACb,WAAW,EAAE,KAAK;YAClB,GAAG,EAAE,yGAAyG;SACjH;QACD,QAAQ,EAAE;YACN,OAAO,EACH,wEAAwE;SAC/E;QACD,MAAM,EAAE,EAAE;QACV,IAAI,EAAE,SAAS;KAClB;IACD,IAAI,EAAE,6CAA6C;CACtD,CAAC,CAAC;AAEH,eAAe,IAAI,CAAC;AACpB,iIAAiI"}
|
|
@@ -1 +1 @@
|
|
|
1
|
-
{"version":3,"file":"no-electron-webview-node-integration.d.ts","sourceRoot":"","sources":["../../src/rules/no-electron-webview-node-integration.ts"],"names":[],"mappings":"
|
|
1
|
+
{"version":3,"file":"no-electron-webview-node-integration.d.ts","sourceRoot":"","sources":["../../src/rules/no-electron-webview-node-integration.ts"],"names":[],"mappings":"AAKA,OAAO,EAAE,UAAU,EAAE,MAAM,6BAA6B,CAAC;AA2EzD,2BAA2B;AAC3B,QAAA,MAAM,IAAI,EAAE,UAAU,CAAC,OAAO,UAAU,CAmEtC,CAAC;AAEH,eAAe,IAAI,CAAC"}
|
|
@@ -1,8 +1,9 @@
|
|
|
1
|
+
import { AST_NODE_TYPES } from "@typescript-eslint/utils";
|
|
1
2
|
import { createRule } from "../_internal/create-rule.js";
|
|
2
|
-
const isJsxWebviewElement = (node) => node.name.type ===
|
|
3
|
+
const isJsxWebviewElement = (node) => node.name.type === AST_NODE_TYPES.JSXIdentifier &&
|
|
3
4
|
node.name.name.toLowerCase() === "webview";
|
|
4
5
|
const getJsxAttributeName = (attributeNode) => {
|
|
5
|
-
if (attributeNode.name.type ===
|
|
6
|
+
if (attributeNode.name.type === AST_NODE_TYPES.JSXIdentifier) {
|
|
6
7
|
return attributeNode.name.name.toLowerCase();
|
|
7
8
|
}
|
|
8
9
|
return `${attributeNode.name.namespace.name}:${attributeNode.name.name.name}`.toLowerCase();
|
|
@@ -16,7 +17,7 @@ const isTruthyJsxAttributeValue = (attributeValue) => {
|
|
|
16
17
|
if (attributeValue === null) {
|
|
17
18
|
return true;
|
|
18
19
|
}
|
|
19
|
-
if (attributeValue.type ===
|
|
20
|
+
if (attributeValue.type === AST_NODE_TYPES.Literal) {
|
|
20
21
|
if (typeof attributeValue.value === "boolean") {
|
|
21
22
|
return attributeValue.value;
|
|
22
23
|
}
|
|
@@ -25,10 +26,10 @@ const isTruthyJsxAttributeValue = (attributeValue) => {
|
|
|
25
26
|
}
|
|
26
27
|
return false;
|
|
27
28
|
}
|
|
28
|
-
if (attributeValue.type !==
|
|
29
|
+
if (attributeValue.type !== AST_NODE_TYPES.JSXExpressionContainer) {
|
|
29
30
|
return false;
|
|
30
31
|
}
|
|
31
|
-
if (attributeValue.expression.type ===
|
|
32
|
+
if (attributeValue.expression.type === AST_NODE_TYPES.Literal &&
|
|
32
33
|
typeof attributeValue.expression.value === "boolean") {
|
|
33
34
|
return attributeValue.expression.value;
|
|
34
35
|
}
|
|
@@ -38,9 +39,9 @@ const webPreferencesHasNodeIntegration = (attributeValue) => {
|
|
|
38
39
|
if (attributeValue === null) {
|
|
39
40
|
return false;
|
|
40
41
|
}
|
|
41
|
-
if (attributeValue.type ===
|
|
42
|
+
if (attributeValue.type === AST_NODE_TYPES.Literal &&
|
|
42
43
|
typeof attributeValue.value === "string") {
|
|
43
|
-
return /\bnodeintegration\b/
|
|
44
|
+
return /\bnodeintegration\b/iv.test(attributeValue.value);
|
|
44
45
|
}
|
|
45
46
|
return false;
|
|
46
47
|
};
|
|
@@ -53,7 +54,7 @@ const rule = createRule({
|
|
|
53
54
|
return;
|
|
54
55
|
}
|
|
55
56
|
for (const attributeNode of node.attributes) {
|
|
56
|
-
if (attributeNode.type !==
|
|
57
|
+
if (attributeNode.type !== AST_NODE_TYPES.JSXAttribute) {
|
|
57
58
|
continue;
|
|
58
59
|
}
|
|
59
60
|
const attributeName = getJsxAttributeName(attributeNode);
|