eslint-plugin-rxjs-x 1.0.0 → 1.0.2

package/dist/index.js

@@ -1,13 +1,11 @@
+import { AST_NODE_TYPES, ESLintUtils } from "@typescript-eslint/utils";
 import ts from "typescript";
 import * as tsutils from "ts-api-utils";
-import { AST_NODE_TYPES, ESLintUtils } from "@typescript-eslint/utils";
 import { getFunctionHeadLocation, isFunction } from "@typescript-eslint/utils/ast-utils";
 import decamelize from "decamelize";
-
 //#region package.json
 var name = "eslint-plugin-rxjs-x";
-var version = "1.0.0";
-
+var version = "1.0.2";
 //#endregion
 //#region src/configs/recommended.ts
 const createRecommendedConfig = (plugin) => ({
@@ -37,7 +35,6 @@ const baseConfig = { rules: {
 	"rxjs-x/prefer-root-operators": "error",
 	"rxjs-x/throw-error": "error"
 } };
-
 //#endregion
 //#region src/configs/strict.ts
 const createStrictConfig = (plugin) => ({
@@ -77,7 +74,6 @@ const createStrictConfig = (plugin) => ({
 		}]
 	}
 });
-
 //#endregion
 //#region src/etc/could-be-type.ts
 function couldBeType(type, name, qualified) {
@@ -92,7 +88,7 @@ function couldBeType(type, name, qualified) {
 function isType(symbol, name, qualified) {
 	if (!symbol) return false;
 	if (qualified && !qualified.name.test(qualified.typeChecker.getFullyQualifiedName(symbol))) return false;
-	return typeof name === "string" ? symbol.name === name : Boolean(symbol.name.match(name));
+	return typeof name === "string" ? symbol.name === name : name.test(symbol.name);
 }
 function couldImplement(type, name, qualified) {
 	const { symbol } = type;
@@ -117,20 +113,18 @@ function isMatchingNode(node, name, qualified) {
 		}
 	}
 	const text = expression.getText();
-	return typeof name === "string" ? text === name : Boolean(text.match(name));
+	return typeof name === "string" ? text === name : name.test(text);
 }
-
 //#endregion
 //#region src/etc/could-be-function.ts
 function couldBeFunction(type) {
 	return type.getCallSignatures().length > 0 || couldBeType(type, "Function") || couldBeType(type, "ArrowFunction") || couldBeType(type, ts.InternalSymbolName.Function);
 }
-
 //#endregion
 //#region src/etc/find-parent.ts
 function findParent(node, ...args) {
 	const [arg] = args;
-	const predicate = typeof arg === "function" ? arg : (type) => !args.includes(type) ? "continue" : "return";
+	const predicate = typeof arg === "function" ? arg : (type) => args.includes(type) ? "return" : "continue";
 	let parent = node.parent;
 	while (parent) {
 		switch (predicate(parent.type)) {
@@ -141,7 +135,6 @@ function findParent(node, ...args) {
 		parent = parent.parent;
 	}
 }
-
 //#endregion
 //#region src/etc/get-loc.ts
 function getLoc(node) {
@@ -159,7 +152,6 @@ function getLoc(node) {
 		}
 	};
 }
-
 //#endregion
 //#region src/etc/is.ts
 function hasTypeAnnotation(node) {
@@ -252,7 +244,6 @@ function isUnionType(node) {
 function isVariableDeclarator(node) {
 	return node.type === AST_NODE_TYPES.VariableDeclarator;
 }
-
 //#endregion
 //#region src/etc/get-type-services.ts
 function getTypeServices(context) {
@@ -284,10 +275,10 @@ function getTypeServices(context) {
 		couldBeSubscription: (node) => couldBeType$1(node, "Subscription"),
 		couldBeType: couldBeType$1,
 		couldReturnObservable: (node) => couldReturnType(node, "Observable"),
+		couldReturnSubject: (node) => couldReturnType(node, "Subject"),
 		couldReturnType
 	};
 }
-
 //#endregion
 //#region src/utils/create-regexp-for-words.ts
 function createRegExpForWords(config) {
@@ -297,13 +288,11 @@ function createRegExpForWords(config) {
 	const joined = config.map((word) => String.raw`(\b|_)${word}(\b|_)`).join("|");
 	return new RegExp(`(${joined})`, flags);
 }
-
 //#endregion
 //#region src/utils/escape-regexp.ts
 function escapeRegExp(text) {
-	return text.replace(/[-/\\^$*+?.()|[\]{}]/g, "\\$&");
+	return text.replaceAll(/[-/\\^$*+?.()|[\]{}]/g, String.raw`\$&`);
 }
-
 //#endregion
 //#region src/utils/find-is-last-operator-order-valid.ts
 /**
@@ -342,12 +331,10 @@ function findIsLastOperatorOrderValid(pipeCallExpression, operatorsRegExp, allow
 		operatorNode
 	};
 }
-
 //#endregion
 //#region src/utils/rule-creator.ts
 const REPO_URL = "https://github.com/JasonWeinzierl/eslint-plugin-rxjs-x";
 const ruleCreator = ESLintUtils.RuleCreator((name) => `${REPO_URL}/blob/v${version}/docs/rules/${name}.md`);
-
 //#endregion
 //#region src/rules/ban-observables.ts
 const banObservablesRule = ruleCreator({
@@ -368,11 +355,9 @@ and values that are either booleans or strings containing the explanation for th
 		const bans = [];
 		const [config] = context.options;
 		if (!config || !Object.keys(config).length) return {};
-		Object.entries(config).forEach(([key, value]) => {
-			if (value !== false) bans.push({
-				explanation: typeof value === "string" ? value : "",
-				regExp: new RegExp(`^${key}$`)
-			});
+		for (const [key, value] of Object.entries(config)) if (value !== false) bans.push({
+			explanation: typeof value === "string" ? value : "",
+			regExp: new RegExp(`^${key}$`)
 		});
 		function getFailure(name) {
 			for (let b = 0, length = bans.length; b < length; ++b) {
@@ -396,7 +381,6 @@ and values that are either booleans or strings containing the explanation for th
 		} };
 	}
 });
-
 //#endregion
 //#region src/rules/ban-operators.ts
 const banOperatorsRule = ruleCreator({
@@ -421,11 +405,9 @@ and values that are either booleans or strings containing the explanation for th
 		const bans = [];
 		const [config] = context.options;
 		if (!config || !Object.keys(config).length) return {};
-		Object.entries(config).forEach(([key, value]) => {
-			if (value !== false) bans.push({
-				name: key,
-				explanation: typeof value === "string" ? value : ""
-			});
+		for (const [key, value] of Object.entries(config)) if (value !== false) bans.push({
+			name: key,
+			explanation: typeof value === "string" ? value : ""
 		});
 		function checkNode(node) {
 			for (const ban of bans) if (couldBeType(node, ban.name, { name: /[/\\]rxjs[/\\]/ })) {
@@ -452,7 +434,6 @@ and values that are either booleans or strings containing the explanation for th
 		};
 	}
 });
-
 //#endregion
 //#region src/rules/finnish.ts
 const baseShouldBeFinnish = "Finnish notation should be used here.";
@@ -528,18 +509,14 @@ const finnishRule = ruleCreator({
 		const [config] = context.options;
 		const { strict } = config;
 		const names = [];
-		if (config.names) Object.entries(config.names).forEach(([key, validate]) => {
-			names.push({
-				regExp: new RegExp(key),
-				validate
-			});
+		if (config.names) for (const [key, validate] of Object.entries(config.names)) names.push({
+			regExp: new RegExp(key),
+			validate
 		});
 		const types = [];
-		if (config.types) Object.entries(config.types).forEach(([key, validate]) => {
-			types.push({
-				regExp: new RegExp(key),
-				validate
-			});
+		if (config.types) for (const [key, validate] of Object.entries(config.types)) types.push({
+			regExp: new RegExp(key),
+			validate
 		});
 		function checkNode(nameNode, typeNode, shouldMessage = "shouldBeFinnish") {
 			const tsNode = esTreeNodeToTSNodeMap.get(nameNode);
@@ -631,9 +608,7 @@ const finnishRule = ruleCreator({
 				if (node.override) return;
 				if (config.methods && node.kind === "method") checkNode(node.key, node);
 				if (config.properties && (node.kind === "get" || node.kind === "set")) checkNode(node.key, node);
-				if (config.parameters) node.value.params.forEach((param) => {
-					checkNode(param);
-				});
+				if (config.parameters) for (const param of node.value.params) checkNode(param);
 			},
 			"ObjectExpression > Property[computed=false] > Identifier": (node) => {
 				if (!config.objects) return;
@@ -660,9 +635,7 @@ const finnishRule = ruleCreator({
 			},
 			"TSMethodSignature[computed=false]": (node) => {
 				if (config.methods) checkNode(node.key, node);
-				if (config.parameters) node.params.forEach((param) => {
-					checkNode(param);
-				});
+				if (config.parameters) for (const param of node.params) checkNode(param);
 			},
 			"TSParameterProperty > Identifier": (node) => {
 				if (config.parameters || config.properties) checkNode(node);
@@ -677,7 +650,6 @@ const finnishRule = ruleCreator({
 		};
 	}
 });
-
 //#endregion
 //#region src/rules/just.ts
 const justRule = ruleCreator({
@@ -698,17 +670,14 @@ const justRule = ruleCreator({
 				fix: (fixer) => fixer.replaceTextRange(node.range, "of as just")
 			});
 			const [ofImport] = context.sourceCode.getDeclaredVariables(node);
-			ofImport.references.forEach((ref) => {
-				context.report({
-					messageId: "forbidden",
-					node: ref.identifier,
-					fix: (fixer) => fixer.replaceTextRange(ref.identifier.range, "just")
-				});
+			for (const ref of ofImport.references) context.report({
+				messageId: "forbidden",
+				node: ref.identifier,
+				fix: (fixer) => fixer.replaceTextRange(ref.identifier.range, "just")
 			});
 		} };
 	}
 });
-
 //#endregion
 //#region src/rules/no-async-subscribe.ts
 const noAsyncSubscribeRule = ruleCreator({
@@ -755,7 +724,6 @@ const noAsyncSubscribeRule = ruleCreator({
 		};
 	}
 });
-
 //#endregion
 //#region src/rules/no-connectable.ts
 const noConnectableRule = ruleCreator({
@@ -787,7 +755,6 @@ const noConnectableRule = ruleCreator({
 		};
 	}
 });
-
 //#endregion
 //#region src/rules/no-create.ts
 const noCreateRule = ruleCreator({
@@ -825,7 +792,6 @@ const noCreateRule = ruleCreator({
 		};
 	}
 });
-
 //#endregion
 //#region src/constants.ts
 const defaultObservable = String.raw`[Aa]ction(s|s\$|\$)$`;
@@ -877,7 +843,6 @@ const DEFAULT_VALID_POST_COMPLETION_OPERATORS = [
 	"throwIfEmpty",
 	"toArray"
 ];
-
 //#endregion
 //#region src/rules/no-cyclic-action.ts
 const noCyclicActionRule = ruleCreator({
@@ -946,7 +911,6 @@ The property can be specified as a regular expression string and is used to iden
 		};
 	}
 });
-
 //#endregion
 //#region src/rules/no-explicit-generics.ts
 const noExplicitGenericsRule = ruleCreator({
@@ -999,7 +963,6 @@ const noExplicitGenericsRule = ruleCreator({
 		};
 	}
 });
-
 //#endregion
 //#region src/rules/no-exposed-subjects.ts
 const defaultAllowedTypesRegExp = /^EventEmitter$/;
@@ -1027,12 +990,15 @@ const noExposedSubjectsRule = ruleCreator({
 	name: "no-exposed-subjects",
 	create: (context) => {
 		const [{ allowProtected }] = context.options;
-		const { couldBeSubject, couldBeType } = getTypeServices(context);
+		const { couldBeSubject, couldReturnSubject, couldBeType, couldReturnType } = getTypeServices(context);
 		const messageId = allowProtected ? "forbiddenAllowProtected" : "forbidden";
 		const accessibilityRexExp = allowProtected ? /^(private|protected)$/ : /^private$/;
 		function isSubject(node) {
 			return couldBeSubject(node) && !couldBeType(node, defaultAllowedTypesRegExp);
 		}
+		function isReturningSubject(node) {
+			return couldReturnSubject(node) && !couldReturnType(node, defaultAllowedTypesRegExp);
+		}
 		return {
 			[`PropertyDefinition[accessibility!=${accessibilityRexExp}]`]: (node) => {
 				if (isSubject(node)) {
@@ -1071,11 +1037,9 @@ const noExposedSubjectsRule = ruleCreator({
 				}
 			},
 			[`MethodDefinition[accessibility!=${accessibilityRexExp}][kind='method']`]: (node) => {
-				const returnType = node.value.returnType;
-				if (!returnType) return;
-				const typeAnnotation = returnType.typeAnnotation;
-				if (!typeAnnotation) return;
-				if (isSubject(typeAnnotation)) {
+				const functionExpression = node.value;
+				const typeAnnotation = functionExpression.returnType?.typeAnnotation;
+				if (typeAnnotation && isSubject(typeAnnotation) || isReturningSubject(functionExpression)) {
 					const key = node.key;
 					context.report({
 						messageId,
@@ -1087,7 +1051,6 @@ const noExposedSubjectsRule = ruleCreator({
 		};
 	}
 });
-
 //#endregion
 //#region src/rules/no-finnish.ts
 const noFinnishRule = ruleCreator({
@@ -1107,7 +1070,7 @@ const noFinnishRule = ruleCreator({
 		function checkNode(nameNode, typeNode) {
 			if (couldBeObservable(typeNode ?? nameNode) || couldReturnObservable(typeNode ?? nameNode)) {
 				const tsNode = esTreeNodeToTSNodeMap.get(nameNode);
-				if (/[$]+$/.test(tsNode.getText())) context.report({
+				if (/\$+$/.test(tsNode.getText())) context.report({
 					loc: getLoc(tsNode),
 					messageId: "forbidden"
 				});
@@ -1165,11 +1128,6 @@ const noFinnishRule = ruleCreator({
 		};
 	}
 });
-
-//#endregion
-//#region src/rules/no-floating-observables.ts
-const messageBase = "Observables must be subscribed to, returned, converted to a promise and awaited, or be explicitly marked as ignored with the `void` operator.";
-const messageBaseNoVoid = "Observables must be subscribed to, returned, or converted to a promise and awaited.";
 const noFloatingObservablesRule = ruleCreator({
 	meta: {
 		docs: {
@@ -1178,8 +1136,8 @@ const noFloatingObservablesRule = ruleCreator({
 			requiresTypeChecking: true
 		},
 		messages: {
-			forbidden: messageBase,
-			forbiddenNoVoid: messageBaseNoVoid
+			forbidden: "Observables must be subscribed to, returned, converted to a promise and awaited, or be explicitly marked as ignored with the `void` operator.",
+			forbiddenNoVoid: "Observables must be subscribed to, returned, or converted to a promise and awaited."
 		},
 		schema: [{
 			properties: { ignoreVoid: {
@@ -1221,21 +1179,18 @@ const noFloatingObservablesRule = ruleCreator({
 				checkNode(node.expression);
 			},
 			"ExpressionStatement > SequenceExpression": (node) => {
-				node.expressions.forEach((expression) => {
-					if (isCallExpression(expression)) checkNode(expression);
-				});
+				for (const expression of node.expressions) if (isCallExpression(expression)) checkNode(expression);
 			},
 			"ExpressionStatement > ArrayExpression": (node) => {
-				node.elements.forEach((expression) => {
-					if (!expression) return;
+				for (const expression of node.elements) {
+					if (!expression) continue;
 					if (isCallExpression(expression)) checkNode(expression);
 					else if (isUnaryExpression(expression)) checkVoid(expression);
-				});
+				}
 			}
 		};
 	}
 });
-
 //#endregion
 //#region src/rules/no-ignored-default-value.ts
 const noIgnoredDefaultValueRule = ruleCreator({
@@ -1320,7 +1275,6 @@ const noIgnoredDefaultValueRule = ruleCreator({
 		};
 	}
 });
-
 //#endregion
 //#region src/rules/no-ignored-error.ts
 const noIgnoredErrorRule = ruleCreator({
@@ -1366,7 +1320,6 @@ const noIgnoredErrorRule = ruleCreator({
 		} };
 	}
 });
-
 //#endregion
 //#region src/rules/no-ignored-notifier.ts
 const noIgnoredNotifierRule = ruleCreator({
@@ -1425,7 +1378,6 @@ const noIgnoredNotifierRule = ruleCreator({
 		};
 	}
 });
-
 //#endregion
 //#region src/rules/no-ignored-replay-buffer.ts
 const noIgnoredReplayBufferRule = ruleCreator({
@@ -1476,7 +1428,6 @@ const noIgnoredReplayBufferRule = ruleCreator({
 		};
 	}
 });
-
 //#endregion
 //#region src/rules/no-ignored-subscribe.ts
 const noIgnoredSubscribeRule = ruleCreator({
@@ -1501,7 +1452,6 @@ const noIgnoredSubscribeRule = ruleCreator({
 		} };
 	}
 });
-
 //#endregion
 //#region src/rules/no-ignored-subscription.ts
 const noIgnoredSubscriptionRule = ruleCreator({
@@ -1567,7 +1517,6 @@ The \`postCompleters\` property is an array containing the names of the operator
 		} };
 	}
 });
-
 //#endregion
 //#region src/rules/no-ignored-takewhile-value.ts
 const noIgnoredTakewhileValueRule = ruleCreator({
@@ -1608,7 +1557,6 @@ const noIgnoredTakewhileValueRule = ruleCreator({
 		};
 	}
 });
-
 //#endregion
 //#region src/rules/no-implicit-any-catch.ts
 function isParenthesised(sourceCode, node) {
@@ -1751,7 +1699,6 @@ const noImplicitAnyCatchRule = ruleCreator({
 		};
 	}
 });
-
 //#endregion
 //#region src/rules/no-index.ts
 const noIndexRule = ruleCreator({
@@ -1774,7 +1721,6 @@ const noIndexRule = ruleCreator({
 		} };
 	}
 });
-
 //#endregion
 //#region src/rules/no-internal.ts
 const noInternalRule = ruleCreator({
@@ -1829,7 +1775,6 @@ const noInternalRule = ruleCreator({
 		} };
 	}
 });
-
 //#endregion
 //#region src/rules/no-misused-observables.ts
 function parseChecksVoidReturn(checksVoidReturn) {
@@ -2093,7 +2038,7 @@ function getPropertyContextualType(checker, tsNode) {
 		if (!ts.isObjectLiteralExpression(obj)) return;
 		const objType = checker.getContextualType(obj);
 		if (objType == null) return;
-		const propertySymbol = tsutils.unionConstituents(objType).map((t) => checker.getPropertyOfType(t, tsNode.name.getText())).find((p) => p);
+		const propertySymbol = tsutils.unionConstituents(objType).map((t) => checker.getPropertyOfType(t, tsNode.name.getText())).find(Boolean);
 		if (propertySymbol == null) return;
 		return checker.getTypeOfSymbolAtLocation(propertySymbol, tsNode.name);
 	} else return;
@@ -2150,7 +2095,6 @@ function isPossiblyFunctionType(node) {
 		case AST_NODE_TYPES.TSVoidKeyword: return false;
 	}
 }
-
 //#endregion
 //#region src/rules/no-nested-subscribe.ts
 const noNestedSubscribeRule = ruleCreator({
@@ -2186,7 +2130,6 @@ const noNestedSubscribeRule = ruleCreator({
 		} };
 	}
 });
-
 //#endregion
 //#region src/rules/no-redundant-notify.ts
 const noRedundantNotifyRule = ruleCreator({
@@ -2240,7 +2183,6 @@ function isExpressionObserver(expressionStatement, couldBeType) {
 	const { object } = callExpression.callee;
 	return couldBeType(object, /^(Subject|Subscriber)$/);
 }
-
 //#endregion
 //#region src/rules/no-sharereplay.ts
 const noSharereplayRule = ruleCreator({
@@ -2276,7 +2218,6 @@ const noSharereplayRule = ruleCreator({
 		} };
 	}
 });
-
 //#endregion
 //#region src/rules/no-sharereplay-before-takeuntil.ts
 const noSharereplayBeforeTakeuntilRule = ruleCreator({
@@ -2332,7 +2273,6 @@ const noSharereplayBeforeTakeuntilRule = ruleCreator({
 		};
 	}
 });
-
 //#endregion
 //#region src/rules/no-subclass.ts
 const noSubclassRule = ruleCreator({
@@ -2366,7 +2306,6 @@ const noSubclassRule = ruleCreator({
 		} };
 	}
 });
-
 //#endregion
 //#region src/rules/no-subject-unsubscribe.ts
 const noSubjectUnsubscribeRule = ruleCreator({
@@ -2403,7 +2342,6 @@ const noSubjectUnsubscribeRule = ruleCreator({
 		};
 	}
 });
-
 //#endregion
 //#region src/rules/no-subject-value.ts
 const noSubjectValueRule = ruleCreator({
@@ -2429,7 +2367,6 @@ const noSubjectValueRule = ruleCreator({
 		} };
 	}
 });
-
 //#endregion
 //#region src/rules/no-subscribe-handlers.ts
 const noSubscribeHandlersRule = ruleCreator({
@@ -2454,7 +2391,6 @@ const noSubscribeHandlersRule = ruleCreator({
 		} };
 	}
 });
-
 //#endregion
 //#region src/rules/no-subscribe-in-pipe.ts
 const noSubscribeInPipeRule = ruleCreator({
@@ -2488,7 +2424,6 @@ const noSubscribeInPipeRule = ruleCreator({
 		} };
 	}
 });
-
 //#endregion
 //#region src/rules/no-topromise.ts
 const noTopromiseRule = ruleCreator({
@@ -2528,13 +2463,13 @@ const noTopromiseRule = ruleCreator({
 					const existingSpecifier = specifiers.find((node) => (isIdentifier(node.imported) ? node.imported.name : node.imported.value) === functionName);
 					if (existingSpecifier) functionName = existingSpecifier.local.name;
 					else {
-						const lastSpecifier = specifiers[specifiers.length - 1];
+						const lastSpecifier = specifiers.at(-1);
 						yield fixer.insertTextAfter(lastSpecifier, `, ${functionName}`);
 					}
 				} else if (importDeclarations.length) {
-					const lastImport = importDeclarations[importDeclarations.length - 1];
+					const lastImport = importDeclarations.at(-1);
 					const quote = getQuote(lastImport.source.raw) ?? "\"";
-					yield fixer.insertTextAfter(importDeclarations[importDeclarations.length - 1], `\nimport { ${functionName} } from ${quote}rxjs${quote};`);
+					yield fixer.insertTextAfter(lastImport, `\nimport { ${functionName} } from ${quote}rxjs${quote};`);
 				} else {
 					console.warn("No import declarations found. Unable to suggest a fix.");
 					return;
@@ -2569,7 +2504,6 @@ const noTopromiseRule = ruleCreator({
 		} };
 	}
 });
-
 //#endregion
 //#region src/rules/no-unbound-methods.ts
 const noUnboundMethodsRule = ruleCreator({
@@ -2598,11 +2532,11 @@ const noUnboundMethodsRule = ruleCreator({
 		const nodeMap = /* @__PURE__ */ new WeakMap();
 		const [{ allowTypes = [] }] = context.options;
 		function mapArguments(node) {
-			node.arguments.filter(isMemberExpression).forEach((arg) => {
+			for (const arg of node.arguments.filter(isMemberExpression)) {
 				const argType = getTypeAtLocation(arg);
-				if (allowTypes.some((t) => couldBeType(argType, t))) return;
+				if (allowTypes.some((t) => couldBeType(argType, t))) continue;
 				if (argType.getCallSignatures().length > 0) nodeMap.set(arg);
-			});
+			}
 		}
 		function isObservableOrSubscription(node, action) {
 			if (!isMemberExpression(node.callee)) return;
@@ -2611,7 +2545,7 @@ const noUnboundMethodsRule = ruleCreator({
 		return {
 			"CallExpression[callee.property.name='pipe']": (node) => {
 				isObservableOrSubscription(node, ({ arguments: args }) => {
-					args.filter(isCallExpression).forEach(mapArguments);
+					for (const node of args.filter(isCallExpression)) mapArguments(node);
 				});
 			},
 			"CallExpression[callee.property.name=/^(add|subscribe)$/]": (node) => {
@@ -2634,7 +2568,6 @@ const noUnboundMethodsRule = ruleCreator({
 		};
 	}
 });
-
 //#endregion
 //#region src/rules/no-unnecessary-collection.ts
 const noUnnecessaryCollectionRule = ruleCreator({
@@ -2704,7 +2637,6 @@ const noUnnecessaryCollectionRule = ruleCreator({
 		return callExpressionVisitors;
 	}
 });
-
 //#endregion
 //#region src/rules/no-unsafe-catch.ts
 const noUnsafeCatchRule = ruleCreator({
@@ -2728,7 +2660,7 @@ The property can be specified as a regular expression string and is used to iden
 	},
 	name: "no-unsafe-catch",
 	create: (context) => {
-		const invalidOperatorsRegExp = /^(catchError)$/;
+		const invalidOperatorsRegExp = /^catchError$/;
 		const [{ observable = defaultObservable }] = context.options;
 		const observableRegExp = new RegExp(observable);
 		const { couldBeObservable } = getTypeServices(context);
@@ -2738,13 +2670,9 @@ The property can be specified as a regular expression string and is used to iden
 		}
 		function checkNode(node) {
 			if (!node.arguments || !couldBeObservable(node)) return;
-			node.arguments.forEach((arg) => {
-				if (isCallExpression(arg) && isIdentifier(arg.callee)) {
-					if (invalidOperatorsRegExp.test(arg.callee.name) && isUnsafe(arg.arguments)) context.report({
-						messageId: "forbidden",
-						node: arg.callee
-					});
-				}
+			for (const arg of node.arguments) if (isCallExpression(arg) && isIdentifier(arg.callee) && invalidOperatorsRegExp.test(arg.callee.name) && isUnsafe(arg.arguments)) context.report({
+				messageId: "forbidden",
+				node: arg.callee
 			});
 		}
 		return {
@@ -2753,7 +2681,6 @@ The property can be specified as a regular expression string and is used to iden
 		};
 	}
 });
-
 //#endregion
 //#region src/rules/no-unsafe-first.ts
 const noUnsafeFirstRule = ruleCreator({
@@ -2777,20 +2704,16 @@ The property can be specified as a regular expression string and is used to iden
 	},
 	name: "no-unsafe-first",
 	create: (context) => {
-		const invalidOperatorsRegExp = /^(take|first)$/;
+		const invalidOperatorsRegExp = /^(?:take|first)$/;
 		const [{ observable = defaultObservable }] = context.options;
 		const observableRegExp = new RegExp(observable);
 		const { couldBeObservable } = getTypeServices(context);
 		const nodes = [];
 		function checkNode(node) {
 			if (!node.arguments || !couldBeObservable(node)) return;
-			node.arguments.forEach((arg) => {
-				if (isCallExpression(arg) && isIdentifier(arg.callee)) {
-					if (invalidOperatorsRegExp.test(arg.callee.name)) context.report({
-						messageId: "forbidden",
-						node: arg.callee
-					});
-				}
+			for (const arg of node.arguments) if (isCallExpression(arg) && isIdentifier(arg.callee) && invalidOperatorsRegExp.test(arg.callee.name)) context.report({
+				messageId: "forbidden",
+				node: arg.callee
 			});
 		}
 		return {
@@ -2809,7 +2732,6 @@ The property can be specified as a regular expression string and is used to iden
 		};
 	}
 });
-
 //#endregion
 //#region src/rules/no-unsafe-subject-next.ts
 const noUnsafeSubjectNext = ruleCreator({
@@ -2845,19 +2767,6 @@ const noUnsafeSubjectNext = ruleCreator({
 		} };
 	}
 });
-
-//#endregion
-//#region src/rules/no-unsafe-switchmap.ts
-const DEFAULT_DISALLOW = [
-	"add",
-	"create",
-	"delete",
-	"post",
-	"put",
-	"remove",
-	"set",
-	"update"
-];
 const noUnsafeSwitchmapRule = ruleCreator({
 	meta: {
 		docs: {
@@ -2903,14 +2812,23 @@ The \`observable\` property is used to identify the action observables from whic
 		}],
 		type: "problem",
 		defaultOptions: [{
-			disallow: DEFAULT_DISALLOW,
+			disallow: [
+				"add",
+				"create",
+				"delete",
+				"post",
+				"put",
+				"remove",
+				"set",
+				"update"
+			],
 			observable: defaultObservable
 		}]
 	},
 	name: "no-unsafe-switchmap",
 	create: (context) => {
-		let allowRegExp = void 0;
-		let disallowRegExp = void 0;
+		let allowRegExp;
+		let disallowRegExp;
 		const [config] = context.options;
 		if (config.allow) allowRegExp = createRegExpForWords(config.allow ?? []);
 		else disallowRegExp = createRegExpForWords(config.disallow ?? []);
@@ -2933,11 +2851,9 @@ The \`observable\` property is used to identify the action observables from whic
 				if (isCallExpression(arg) && isIdentifier(arg.callee) && arg.callee.name === "ofType") return shouldDisallow(arg.arguments);
 				return false;
 			})) return;
-			node.arguments.forEach((arg) => {
-				if (isCallExpression(arg) && isIdentifier(arg.callee) && arg.callee.name === "switchMap") context.report({
-					messageId: "forbidden",
-					node: arg.callee
-				});
+			for (const arg of node.arguments) if (isCallExpression(arg) && isIdentifier(arg.callee) && arg.callee.name === "switchMap") context.report({
+				messageId: "forbidden",
+				node: arg.callee
 			});
 		}
 		return {
@@ -2946,7 +2862,6 @@ The \`observable\` property is used to identify the action observables from whic
 		};
 	}
 });
-
 //#endregion
 //#region src/rules/no-unsafe-takeuntil.ts
 const noUnsafeTakeuntilRule = ruleCreator({
@@ -2999,7 +2914,6 @@ The \`allow\` property is an array containing the names of the operators that ar
 		};
 	}
 });
-
 //#endregion
 //#region src/rules/prefer-observer.ts
 const preferObserverRule = ruleCreator({
@@ -3043,9 +2957,9 @@ const preferObserverRule = ruleCreator({
 				if (errorArgText && errorArgText !== "undefined" && errorArgText !== "null") observer += ` error: ${errorArgText}${isValidArgText(completeArgText) ? "," : ""}`;
 				if (completeArgText && completeArgText !== "undefined" && completeArgText !== "null") observer += ` complete: ${completeArgText}`;
 				observer += " }";
-				yield fixer.replaceText(callExpression.arguments[0], observer);
-				const [, start] = callExpression.arguments[0].range;
-				const [, end] = callExpression.arguments[callExpression.arguments.length - 1].range;
+				yield fixer.replaceText(args[0], observer);
+				const [, start] = args[0].range;
+				const [, end] = args.at(-1).range;
 				yield fixer.removeRange([start, end]);
 			}
 			if (args.length > 1) context.report({
@@ -3083,7 +2997,6 @@ const preferObserverRule = ruleCreator({
 function isValidArgText(argText) {
 	return argText && argText !== "undefined" && argText !== "null";
 }
-
 //#endregion
 //#region src/rules/prefer-root-operators.ts
 const RENAMED_OPERATORS = {
@@ -3094,7 +3007,7 @@ const RENAMED_OPERATORS = {
 	race: "raceWith",
 	zip: "zipWith"
 };
-const DEPRECATED_OPERATORS = ["partition"];
+const DEPRECATED_OPERATORS = new Set(["partition"]);
 const preferRootOperatorsRule = ruleCreator({
 	meta: {
 		docs: {
@@ -3125,7 +3038,7 @@ const preferRootOperatorsRule = ruleCreator({
 			if (/^['"]rxjs\/operators/.test(rawLocation)) return `${quote}rxjs${quote}`;
 		}
 		function hasDeprecatedOperators(specifiers) {
-			return !!specifiers?.some((s) => DEPRECATED_OPERATORS.includes(getName(getOperatorNode(s))));
+			return !!specifiers?.some((s) => DEPRECATED_OPERATORS.has(getName(getOperatorNode(s))));
 		}
 		function getName(node) {
 			return isIdentifier(node) ? node.name : node.value;
@@ -3207,7 +3120,6 @@ const preferRootOperatorsRule = ruleCreator({
 		};
 	}
 });
-
 //#endregion
 //#region src/rules/suffix-subjects.ts
 const baseShouldHaveSuffix = "Subject identifiers must end with \"{{suffix}}\".";
@@ -3266,11 +3178,9 @@ const suffixSubjectsRule = ruleCreator({
 		const { couldBeType } = getTypeServices(context);
 		const [config] = context.options;
 		const types = [];
-		if (config.types) Object.entries(config.types).forEach(([key, validate]) => {
-			types.push({
-				regExp: new RegExp(key),
-				validate
-			});
+		if (config.types) for (const [key, validate] of Object.entries(config.types)) types.push({
+			regExp: new RegExp(key),
+			validate
 		});
 		const { suffix = "Subject" } = config;
 		const suffixRegex = new RegExp(String.raw`${escapeRegExp(suffix)}\$?$`, "i");
@@ -3334,9 +3244,7 @@ const suffixSubjectsRule = ruleCreator({
 			"TSAbstractMethodDefinition[computed=false]": (node) => {
 				if (node.override) return;
 				if (config.properties && (node.kind === "get" || node.kind === "set")) checkNode(node.key, node);
-				if (config.parameters) node.value.params.forEach((param) => {
-					checkNode(param);
-				});
+				if (config.parameters) for (const param of node.value.params) checkNode(param);
 			},
 			"ObjectExpression > Property[computed=false] > Identifier": (node) => {
 				if (!config.objects) return;
@@ -3378,7 +3286,6 @@ const suffixSubjectsRule = ruleCreator({
 		};
 	}
 });
-
 //#endregion
 //#region src/rules/throw-error.ts
 const throwErrorRule = ruleCreator({
@@ -3468,62 +3375,58 @@ const throwErrorRule = ruleCreator({
 		};
 	}
 });
-
-//#endregion
-//#region src/index.ts
-const allRules = {
-	"ban-observables": banObservablesRule,
-	"ban-operators": banOperatorsRule,
-	"finnish": finnishRule,
-	"just": justRule,
-	"no-async-subscribe": noAsyncSubscribeRule,
-	"no-connectable": noConnectableRule,
-	"no-create": noCreateRule,
-	"no-cyclic-action": noCyclicActionRule,
-	"no-explicit-generics": noExplicitGenericsRule,
-	"no-exposed-subjects": noExposedSubjectsRule,
-	"no-finnish": noFinnishRule,
-	"no-floating-observables": noFloatingObservablesRule,
-	"no-ignored-default-value": noIgnoredDefaultValueRule,
-	"no-ignored-error": noIgnoredErrorRule,
-	"no-ignored-notifier": noIgnoredNotifierRule,
-	"no-ignored-replay-buffer": noIgnoredReplayBufferRule,
-	"no-ignored-subscribe": noIgnoredSubscribeRule,
-	"no-ignored-subscription": noIgnoredSubscriptionRule,
-	"no-ignored-takewhile-value": noIgnoredTakewhileValueRule,
-	"no-implicit-any-catch": noImplicitAnyCatchRule,
-	"no-index": noIndexRule,
-	"no-internal": noInternalRule,
-	"no-misused-observables": noMisusedObservablesRule,
-	"no-nested-subscribe": noNestedSubscribeRule,
-	"no-redundant-notify": noRedundantNotifyRule,
-	"no-sharereplay": noSharereplayRule,
-	"no-sharereplay-before-takeuntil": noSharereplayBeforeTakeuntilRule,
-	"no-subclass": noSubclassRule,
-	"no-subject-unsubscribe": noSubjectUnsubscribeRule,
-	"no-subject-value": noSubjectValueRule,
-	"no-subscribe-handlers": noSubscribeHandlersRule,
-	"no-subscribe-in-pipe": noSubscribeInPipeRule,
-	"no-topromise": noTopromiseRule,
-	"no-unbound-methods": noUnboundMethodsRule,
-	"no-unnecessary-collection": noUnnecessaryCollectionRule,
-	"no-unsafe-catch": noUnsafeCatchRule,
-	"no-unsafe-first": noUnsafeFirstRule,
-	"no-unsafe-subject-next": noUnsafeSubjectNext,
-	"no-unsafe-switchmap": noUnsafeSwitchmapRule,
-	"no-unsafe-takeuntil": noUnsafeTakeuntilRule,
-	"prefer-observer": preferObserverRule,
-	"prefer-root-operators": preferRootOperatorsRule,
-	"suffix-subjects": suffixSubjectsRule,
-	"throw-error": throwErrorRule
-};
 const plugin = {
 	meta: {
 		name,
 		version,
 		namespace: "rxjs-x"
 	},
-	rules: allRules
+	rules: {
+		"ban-observables": banObservablesRule,
+		"ban-operators": banOperatorsRule,
+		"finnish": finnishRule,
+		"just": justRule,
+		"no-async-subscribe": noAsyncSubscribeRule,
+		"no-connectable": noConnectableRule,
+		"no-create": noCreateRule,
+		"no-cyclic-action": noCyclicActionRule,
+		"no-explicit-generics": noExplicitGenericsRule,
+		"no-exposed-subjects": noExposedSubjectsRule,
+		"no-finnish": noFinnishRule,
+		"no-floating-observables": noFloatingObservablesRule,
+		"no-ignored-default-value": noIgnoredDefaultValueRule,
+		"no-ignored-error": noIgnoredErrorRule,
+		"no-ignored-notifier": noIgnoredNotifierRule,
+		"no-ignored-replay-buffer": noIgnoredReplayBufferRule,
+		"no-ignored-subscribe": noIgnoredSubscribeRule,
+		"no-ignored-subscription": noIgnoredSubscriptionRule,
+		"no-ignored-takewhile-value": noIgnoredTakewhileValueRule,
+		"no-implicit-any-catch": noImplicitAnyCatchRule,
+		"no-index": noIndexRule,
+		"no-internal": noInternalRule,
+		"no-misused-observables": noMisusedObservablesRule,
+		"no-nested-subscribe": noNestedSubscribeRule,
+		"no-redundant-notify": noRedundantNotifyRule,
+		"no-sharereplay": noSharereplayRule,
+		"no-sharereplay-before-takeuntil": noSharereplayBeforeTakeuntilRule,
+		"no-subclass": noSubclassRule,
+		"no-subject-unsubscribe": noSubjectUnsubscribeRule,
+		"no-subject-value": noSubjectValueRule,
+		"no-subscribe-handlers": noSubscribeHandlersRule,
+		"no-subscribe-in-pipe": noSubscribeInPipeRule,
+		"no-topromise": noTopromiseRule,
+		"no-unbound-methods": noUnboundMethodsRule,
+		"no-unnecessary-collection": noUnnecessaryCollectionRule,
+		"no-unsafe-catch": noUnsafeCatchRule,
+		"no-unsafe-first": noUnsafeFirstRule,
+		"no-unsafe-subject-next": noUnsafeSubjectNext,
+		"no-unsafe-switchmap": noUnsafeSwitchmapRule,
+		"no-unsafe-takeuntil": noUnsafeTakeuntilRule,
+		"prefer-observer": preferObserverRule,
+		"prefer-root-operators": preferRootOperatorsRule,
+		"suffix-subjects": suffixSubjectsRule,
+		"throw-error": throwErrorRule
+	}
 };
 const rxjsX = {
 	...plugin,
@@ -3532,6 +3435,5 @@ const rxjsX = {
 		strict: createStrictConfig(plugin)
 	}
 };
-
 //#endregion
-export { rxjsX as default };
+export { rxjsX as default };

package/package.json

@@ -1,23 +1,7 @@
 {
   "name": "eslint-plugin-rxjs-x",
-  "type": "module",
-  "version": "1.0.0",
-  "packageManager": "yarn@4.12.0+sha512.f45ab632439a67f8bc759bf32ead036a1f413287b9042726b7cc4818b7b49e14e9423ba49b18f9e06ea4941c1ad062385b1d8760a8d5091a1a31e5f6219afca8",
+  "version": "1.0.2",
   "description": "Modern ESLint plugin for RxJS",
-  "author": "Jason Weinzierl <weinzierljason@gmail.com>",
-  "license": "MIT",
-  "homepage": "https://github.com/JasonWeinzierl/eslint-plugin-rxjs-x",
-  "repository": {
-    "type": "git",
-    "url": "git+https://github.com/JasonWeinzierl/eslint-plugin-rxjs-x.git"
-  },
-  "publishConfig": {
-    "provenance": true,
-    "registry": "https://registry.npmjs.org"
-  },
-  "bugs": {
-    "url": "https://github.com/JasonWeinzierl/eslint-plugin-rxjs-x/issues"
-  },
   "keywords": [
     "lint",
     "rules",
@@ -26,7 +10,18 @@
     "eslint-plugin",
     "rxjs"
   ],
+  "homepage": "https://github.com/JasonWeinzierl/eslint-plugin-rxjs-x",
+  "bugs": {
+    "url": "https://github.com/JasonWeinzierl/eslint-plugin-rxjs-x/issues"
+  },
+  "repository": {
+    "type": "git",
+    "url": "git+https://github.com/JasonWeinzierl/eslint-plugin-rxjs-x.git"
+  },
+  "license": "MIT",
+  "author": "Jason Weinzierl <weinzierljason@gmail.com>",
   "sideEffects": false,
+  "type": "module",
   "exports": {
     ".": {
       "types": "./dist/index.d.ts",
@@ -41,61 +36,71 @@
   ],
   "scripts": {
     "build": "tsdown",
+    "coverage": "vitest run --coverage",
+    "docs": "eslint-doc-generator",
     "lint": "yarn lint-js && yarn lint-docs && yarn lint-eslint-docs",
-    "lint-js": "eslint",
     "lint-docs": "markdownlint-cli2 \"**/*.md\" \"#node_modules\"",
     "lint-eslint-docs": "yarn build && eslint-doc-generator --check",
-    "docs": "eslint-doc-generator",
+    "lint-js": "eslint",
     "release": "bumpp && echo \"Create a new release in GitHub to trigger the publish workflow.\"",
     "test": "vitest",
-    "coverage": "vitest run --coverage",
     "typecheck": "tsc --noEmit"
   },
+  "resolutions": {
+    "rolldown": "^1.0.0-rc.12"
+  },
   "dependencies": {
-    "@typescript-eslint/utils": "^8.56.0",
+    "@typescript-eslint/utils": "^8.58.0",
     "decamelize": "^6.0.1",
-    "ts-api-utils": "^2.4.0"
-  },
-  "peerDependencies": {
-    "eslint": "^10.0.0",
-    "rxjs": "^7.2.0",
-    "typescript": ">=4.8.4 <6.0.0"
-  },
-  "peerDependenciesMeta": {
-    "rxjs": {
-      "optional": true
-    }
+    "ts-api-utils": "^2.5.0"
   },
   "devDependencies": {
     "@eslint/js": "^10.0.1",
-    "@stylistic/eslint-plugin": "^5.8.0",
+    "@stylistic/eslint-plugin": "^5.10.0",
     "@types/common-tags": "^1.8.4",
-    "@types/node": "~20.19.33",
-    "@typescript-eslint/rule-tester": "^8.56.0",
-    "@typescript/vfs": "^1.6.3",
-    "@vitest/coverage-v8": "^4.0.18",
-    "@vitest/eslint-plugin": "^1.6.9",
-    "bumpp": "^10.4.1",
+    "@types/node": "~20.19.37",
+    "@typescript-eslint/rule-tester": "^8.58.0",
+    "@typescript/vfs": "^1.6.4",
+    "@vitest/coverage-v8": "^4.1.2",
+    "@vitest/eslint-plugin": "^1.6.13",
+    "bumpp": "^11.0.1",
     "common-tags": "^1.8.2",
-    "eslint": "^10.0.0",
-    "eslint-config-flat-gitignore": "^2.1.0",
-    "eslint-doc-generator": "^3.1.0",
+    "eslint": "^10.1.0",
+    "eslint-config-flat-gitignore": "^2.3.0",
+    "eslint-doc-generator": "^3.3.2",
     "eslint-import-resolver-typescript": "^4.4.4",
     "eslint-plugin-eslint-plugin": "patch:eslint-plugin-eslint-plugin@npm%3A7.3.1#~/.yarn/patches/eslint-plugin-eslint-plugin-npm-7.3.1-6b766f9a07.patch",
-    "eslint-plugin-import-x": "^4.16.1",
+    "eslint-plugin-import-x": "^4.16.2",
     "eslint-plugin-n": "^17.24.0",
-    "markdownlint-cli2": "~0.21.0",
+    "eslint-plugin-package-json": "^0.91.1",
+    "eslint-plugin-perfectionist": "^5.7.0",
+    "eslint-plugin-regexp": "^3.1.0",
+    "eslint-plugin-unicorn": "^64.0.0",
+    "jsonc-eslint-parser": "^3.1.0",
+    "markdownlint-cli2": "~0.22.0",
     "rxjs": "^7.8.2",
-    "tsdown": "^0.20.3",
-    "typescript": "~5.9.3",
-    "typescript-eslint": "^8.56.0",
-    "vite": "npm:rolldown-vite@~7.3.1",
-    "vitest": "^4.0.18"
+    "tsdown": "^0.21.7",
+    "typescript": "~6.0.2",
+    "typescript-eslint": "^8.58.0",
+    "vite": "^8.0.3",
+    "vitest": "^4.1.2"
   },
-  "resolutions": {
-    "vite": "npm:rolldown-vite@~7.3.1"
+  "peerDependencies": {
+    "eslint": "^10.0.1",
+    "rxjs": "^7.2.0",
+    "typescript": ">=4.8.4 <6.1.0"
   },
+  "peerDependenciesMeta": {
+    "rxjs": {
+      "optional": true
+    }
+  },
+  "packageManager": "yarn@4.13.0+sha512.5c20ba010c99815433e5c8453112165e673f1c7948d8d2b267f4b5e52097538658388ebc9f9580656d9b75c5cc996f990f611f99304a2197d4c56d21eea370e7",
   "engines": {
     "node": "^20.19.0 || ^22.13.0 || >=24"
+  },
+  "publishConfig": {
+    "provenance": true,
+    "registry": "https://registry.npmjs.org"
   }
 }