eslint-plugin-rxjs-x 0.9.1 → 0.9.2

package/README.md

@@ -128,7 +128,7 @@ The package includes the following rules.
 | [no-async-subscribe](docs/rules/no-async-subscribe.md)                           | Disallow passing `async` functions to `subscribe`.                                                        | ✅ 🔒 |    |    | 💭 |    |
 | [no-compat](docs/rules/no-compat.md)                                             | Disallow the `rxjs-compat` package.                                                                       |      |    |    |    | ❌  |
 | [no-connectable](docs/rules/no-connectable.md)                                   | Disallow operators that return connectable observables.                                                   |      |    |    | 💭 |    |
-| [no-create](docs/rules/no-create.md)                                             | Disallow the static `Observable.create` function.                                                         | ✅ 🔒 |    |    | 💭 |    |
+| [no-create](docs/rules/no-create.md)                                             | Disallow the static `Observable.create` and `Subject.create` functions.                                   | ✅ 🔒 |    |    | 💭 |    |
 | [no-cyclic-action](docs/rules/no-cyclic-action.md)                               | Disallow cyclic actions in effects and epics.                                                             |      |    |    | 💭 |    |
 | [no-explicit-generics](docs/rules/no-explicit-generics.md)                       | Disallow unnecessary explicit generic type arguments.                                                     |      |    |    | 💭 |    |
 | [no-exposed-subjects](docs/rules/no-exposed-subjects.md)                         | Disallow public and protected subjects.                                                                   | 🔒   |    |    | 💭 |    |
@@ -142,7 +142,7 @@ The package includes the following rules.
 | [no-ignored-subscribe](docs/rules/no-ignored-subscribe.md)                       | Disallow calling `subscribe` without specifying arguments.                                                |      |    |    | 💭 |    |
 | [no-ignored-subscription](docs/rules/no-ignored-subscription.md)                 | Disallow ignoring the subscription returned by `subscribe`.                                               |      |    |    | 💭 |    |
 | [no-ignored-takewhile-value](docs/rules/no-ignored-takewhile-value.md)           | Disallow ignoring the value within `takeWhile`.                                                           | ✅ 🔒 |    |    |    |    |
-| [no-implicit-any-catch](docs/rules/no-implicit-any-catch.md)                     | Disallow implicit `any` error parameters in `catchError` operators.                                       | ✅ 🔒 | 🔧 | 💡 | 💭 |    |
+| [no-implicit-any-catch](docs/rules/no-implicit-any-catch.md)                     | Disallow implicit `any` error parameters in `catchError`, `subscribe`, and `tap`.                         | ✅ 🔒 | 🔧 | 💡 | 💭 |    |
 | [no-index](docs/rules/no-index.md)                                               | Disallow importing index modules.                                                                         | ✅ 🔒 |    |    |    |    |
 | [no-internal](docs/rules/no-internal.md)                                         | Disallow importing internal modules.                                                                      | ✅ 🔒 | 🔧 | 💡 |    |    |
 | [no-misused-observables](docs/rules/no-misused-observables.md)                   | Disallow Observables in places not designed to handle them.                                               | 🔒   |    |    | 💭 |    |
@@ -167,6 +167,6 @@ The package includes the following rules.
 | [prefer-observer](docs/rules/prefer-observer.md)                                 | Disallow passing separate handlers to `subscribe` and `tap`.                                              | ✅ 🔒 | 🔧 | 💡 | 💭 |    |
 | [prefer-root-operators](docs/rules/prefer-root-operators.md)                     | Disallow importing operators from `rxjs/operators`.                                                       | ✅ 🔒 | 🔧 | 💡 |    |    |
 | [suffix-subjects](docs/rules/suffix-subjects.md)                                 | Enforce the use of a suffix in subject identifiers.                                                       |      |    |    | 💭 |    |
-| [throw-error](docs/rules/throw-error.md)                                         | Enforce passing only `Error` values to `throwError` or `Subject.error`.                                   | ✅ 🔒 |    |    | 💭 |    |
+| [throw-error](docs/rules/throw-error.md)                                         | Enforce passing only `Error` values to `throwError` or `Subject.error`.                                   | ✅ 🔒 |    | 💡 | 💭 |    |
 
 <!-- end auto-generated rules list -->

package/dist/index.d.mts

@@ -50,8 +50,8 @@ declare const allRules: {
         description: "Disallow operators that return connectable observables.";
         requiresTypeChecking: true;
     }, TSESLint.RuleListener>;
-    'no-create': TSESLint.RuleModule<"forbidden", [], {
-        description: "Disallow the static `Observable.create` function.";
+    'no-create': TSESLint.RuleModule<"forbidden" | "forbiddenSubject", [], {
+        description: "Disallow the static `Observable.create` and `Subject.create` functions.";
         recommended: "recommended";
         requiresTypeChecking: true;
     }, TSESLint.RuleListener>;
@@ -120,10 +120,11 @@ declare const allRules: {
         description: "Disallow ignoring the value within `takeWhile`.";
         recommended: "recommended";
     }, TSESLint.RuleListener>;
-    'no-implicit-any-catch': TSESLint.RuleModule<"explicitAny" | "implicitAny" | "narrowed" | "suggestExplicitUnknown" | "suggestExplicitAny", readonly {
+    'no-implicit-any-catch': TSESLint.RuleModule<"explicitAny" | "implicitAny" | "narrowed" | "narrowedAllowError" | "suggestExplicitUnknown" | "suggestExplicitAny" | "suggestExplicitError", readonly {
         allowExplicitAny?: boolean;
+        allowExplicitError?: boolean;
     }[], {
-        description: "Disallow implicit `any` error parameters in `catchError` operators.";
+        description: "Disallow implicit `any` error parameters in `catchError`, `subscribe`, and `tap`.";
         recommended: {
             recommended: true;
             strict: [{
@@ -267,7 +268,7 @@ declare const allRules: {
         description: "Enforce the use of a suffix in subject identifiers.";
         requiresTypeChecking: true;
     }, TSESLint.RuleListener>;
-    'throw-error': TSESLint.RuleModule<"forbidden", readonly {
+    'throw-error': TSESLint.RuleModule<"forbidden" | "suggestErrorConstructor", readonly {
         allowThrowingAny?: boolean;
         allowThrowingUnknown?: boolean;
     }[], {

package/dist/index.d.ts

@@ -50,8 +50,8 @@ declare const allRules: {
         description: "Disallow operators that return connectable observables.";
         requiresTypeChecking: true;
     }, TSESLint.RuleListener>;
-    'no-create': TSESLint.RuleModule<"forbidden", [], {
-        description: "Disallow the static `Observable.create` function.";
+    'no-create': TSESLint.RuleModule<"forbidden" | "forbiddenSubject", [], {
+        description: "Disallow the static `Observable.create` and `Subject.create` functions.";
         recommended: "recommended";
         requiresTypeChecking: true;
     }, TSESLint.RuleListener>;
@@ -120,10 +120,11 @@ declare const allRules: {
         description: "Disallow ignoring the value within `takeWhile`.";
         recommended: "recommended";
     }, TSESLint.RuleListener>;
-    'no-implicit-any-catch': TSESLint.RuleModule<"explicitAny" | "implicitAny" | "narrowed" | "suggestExplicitUnknown" | "suggestExplicitAny", readonly {
+    'no-implicit-any-catch': TSESLint.RuleModule<"explicitAny" | "implicitAny" | "narrowed" | "narrowedAllowError" | "suggestExplicitUnknown" | "suggestExplicitAny" | "suggestExplicitError", readonly {
         allowExplicitAny?: boolean;
+        allowExplicitError?: boolean;
     }[], {
-        description: "Disallow implicit `any` error parameters in `catchError` operators.";
+        description: "Disallow implicit `any` error parameters in `catchError`, `subscribe`, and `tap`.";
         recommended: {
             recommended: true;
             strict: [{
@@ -267,7 +268,7 @@ declare const allRules: {
         description: "Enforce the use of a suffix in subject identifiers.";
         requiresTypeChecking: true;
     }, TSESLint.RuleListener>;
-    'throw-error': TSESLint.RuleModule<"forbidden", readonly {
+    'throw-error': TSESLint.RuleModule<"forbidden" | "suggestErrorConstructor", readonly {
         allowThrowingAny?: boolean;
         allowThrowingUnknown?: boolean;
     }[], {

package/dist/index.js

@@ -1,6 +1,6 @@
 "use strict";Object.defineProperty(exports, "__esModule", {value: true}); function _interopRequireWildcard(obj) { if (obj && obj.__esModule) { return obj; } else { var newObj = {}; if (obj != null) { for (var key in obj) { if (Object.prototype.hasOwnProperty.call(obj, key)) { newObj[key] = obj[key]; } } } newObj.default = obj; return newObj; } } function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }// package.json
 var name = "eslint-plugin-rxjs-x";
-var version = "0.9.1";
+var version = "0.9.2";
 
 // src/configs/recommended.ts
 var createRecommendedConfig = (plugin2) => ({
@@ -274,6 +274,9 @@ function isJSXExpressionContainer(node) {
 function isLiteral(node) {
   return node.type === _utils.AST_NODE_TYPES.Literal;
 }
+function isTemplateLiteral(node) {
+  return node.type === _utils.AST_NODE_TYPES.TemplateLiteral;
+}
 function isMemberExpression(node) {
   return node.type === _utils.AST_NODE_TYPES.MemberExpression;
 }
@@ -1103,19 +1106,20 @@ var noCreateRule = ruleCreator({
   defaultOptions: [],
   meta: {
     docs: {
-      description: "Disallow the static `Observable.create` function.",
+      description: "Disallow the static `Observable.create` and `Subject.create` functions.",
       recommended: "recommended",
       requiresTypeChecking: true
     },
     messages: {
-      forbidden: "Observable.create is forbidden; use new Observable."
+      forbidden: "Observable.create is forbidden; use new Observable.",
+      forbiddenSubject: "Subject.create is forbidden."
     },
     schema: [],
     type: "problem"
   },
   name: "no-create",
   create: (context) => {
-    const { couldBeObservable } = getTypeServices(context);
+    const { couldBeObservable, couldBeType: couldBeType2 } = getTypeServices(context);
     return {
       "CallExpression > MemberExpression[object.name='Observable'] > Identifier[name='create']": (node) => {
         const memberExpression = node.parent;
@@ -1125,6 +1129,15 @@ var noCreateRule = ruleCreator({
             node
           });
         }
+      },
+      "CallExpression > MemberExpression[object.name=/^(Subject|BehaviorSubject|AsyncSubject|ReplaySubject)$/] > Identifier[name='create']": (node) => {
+        const memberExpression = node.parent;
+        if (couldBeType2(memberExpression.object, /^(Subject|BehaviorSubject|AsyncSubject|ReplaySubject)$/)) {
+          context.report({
+            messageId: "forbiddenSubject",
+            node
+          });
+        }
       }
     };
   }
@@ -2090,7 +2103,7 @@ var noImplicitAnyCatchRule = ruleCreator({
   defaultOptions: defaultOptions8,
   meta: {
     docs: {
-      description: "Disallow implicit `any` error parameters in `catchError` operators.",
+      description: "Disallow implicit `any` error parameters in `catchError`, `subscribe`, and `tap`.",
       recommended: {
         recommended: true,
         strict: [{
@@ -2105,8 +2118,10 @@ var noImplicitAnyCatchRule = ruleCreator({
       explicitAny: "Explicit `any` in error callback.",
       implicitAny: "Implicit `any` in error callback.",
       narrowed: "Error type must be `unknown` or `any`.",
+      narrowedAllowError: "Error type must be `unknown`, `any`, or `Error`.",
       suggestExplicitUnknown: "Use `unknown` instead to explicitly and safely assert the type is correct.",
-      suggestExplicitAny: "Use `any` instead to explicitly opt out of type safety."
+      suggestExplicitAny: "Use `any` instead to explicitly opt out of type safety.",
+      suggestExplicitError: "Use `Error` instead."
     },
     schema: [
       {
@@ -2116,6 +2131,11 @@ var noImplicitAnyCatchRule = ruleCreator({
             type: "boolean",
             description: "Allow error variable to be explicitly typed as `any`.",
             default: true
+          },
+          allowExplicitError: {
+            type: "boolean",
+            description: "Allow narrowing error type to `Error`.",
+            default: false
           }
         },
         type: "object"
@@ -2126,7 +2146,7 @@ var noImplicitAnyCatchRule = ruleCreator({
   name: "no-implicit-any-catch",
   create: (context) => {
     const [config = {}] = context.options;
-    const { allowExplicitAny = true } = config;
+    const { allowExplicitAny = true, allowExplicitError = false } = config;
     const { couldBeObservable } = getTypeServices(context);
     const sourceCode = context.sourceCode;
     function createReplacerFix(typeAnnotation, replaceWith) {
@@ -2171,20 +2191,33 @@ var noImplicitAnyCatchRule = ruleCreator({
               ]
             });
           } else if (type !== _utils.AST_NODE_TYPES.TSUnknownKeyword) {
-            context.report({
-              messageId: "narrowed",
-              node: param,
-              suggest: [
-                {
-                  messageId: "suggestExplicitUnknown",
-                  fix: createReplacerFix(typeAnnotation, "unknown")
-                },
-                allowExplicitAny ? {
-                  messageId: "suggestExplicitAny",
-                  fix: createReplacerFix(typeAnnotation, "any")
-                } : null
-              ].filter((x) => !!x)
-            });
+            let isAllowedError = false;
+            if (allowExplicitError && type === _utils.AST_NODE_TYPES.TSTypeReference) {
+              const typeRef = typeAnnotation.typeAnnotation;
+              if (isIdentifier(typeRef.typeName)) {
+                isAllowedError = typeRef.typeName.name === "Error";
+              }
+            }
+            if (!isAllowedError) {
+              context.report({
+                messageId: allowExplicitError ? "narrowedAllowError" : "narrowed",
+                node: param,
+                suggest: [
+                  {
+                    messageId: "suggestExplicitUnknown",
+                    fix: createReplacerFix(typeAnnotation, "unknown")
+                  },
+                  allowExplicitAny ? {
+                    messageId: "suggestExplicitAny",
+                    fix: createReplacerFix(typeAnnotation, "any")
+                  } : null,
+                  allowExplicitError && !isAllowedError ? {
+                    messageId: "suggestExplicitError",
+                    fix: createReplacerFix(typeAnnotation, "Error")
+                  } : null
+                ].filter((x) => !!x)
+              });
+            }
           }
         } else {
           const hasRestParams = restParams.length > 0;
@@ -4317,7 +4350,8 @@ var throwErrorRule = ruleCreator({
       requiresTypeChecking: true
     },
     messages: {
-      forbidden: "Passing non-Error values is forbidden."
+      forbidden: "Passing non-Error values is forbidden.",
+      suggestErrorConstructor: "Wrap string in Error constructor."
     },
     schema: [
       {
@@ -4328,7 +4362,8 @@ var throwErrorRule = ruleCreator({
         type: "object"
       }
     ],
-    type: "problem"
+    type: "problem",
+    hasSuggestions: true
   },
   name: "throw-error",
   create: (context) => {
@@ -4356,9 +4391,22 @@ var throwErrorRule = ruleCreator({
       if (couldBeType(type, /^Error$/)) {
         return;
       }
+      const isString = isTemplateLiteral(reportNode) || isLiteral(reportNode) && typeof reportNode.value === "string";
       context.report({
         messageId: "forbidden",
-        node: reportNode
+        node: reportNode,
+        ...isString && {
+          suggest: [
+            {
+              messageId: "suggestErrorConstructor",
+              fix: (fixer) => {
+                const sourceCode = context.sourceCode;
+                const nodeText = sourceCode.getText(reportNode);
+                return fixer.replaceText(reportNode, `new Error(${nodeText})`);
+              }
+            }
+          ]
+        }
       });
     }
     function checkThrowError(node) {

package/dist/index.mjs

@@ -1,6 +1,6 @@
 // package.json
 var name = "eslint-plugin-rxjs-x";
-var version = "0.9.1";
+var version = "0.9.2";
 
 // src/configs/recommended.ts
 var createRecommendedConfig = (plugin2) => ({
@@ -274,6 +274,9 @@ function isJSXExpressionContainer(node) {
 function isLiteral(node) {
   return node.type === AST_NODE_TYPES.Literal;
 }
+function isTemplateLiteral(node) {
+  return node.type === AST_NODE_TYPES.TemplateLiteral;
+}
 function isMemberExpression(node) {
   return node.type === AST_NODE_TYPES.MemberExpression;
 }
@@ -1103,19 +1106,20 @@ var noCreateRule = ruleCreator({
   defaultOptions: [],
   meta: {
     docs: {
-      description: "Disallow the static `Observable.create` function.",
+      description: "Disallow the static `Observable.create` and `Subject.create` functions.",
       recommended: "recommended",
       requiresTypeChecking: true
     },
     messages: {
-      forbidden: "Observable.create is forbidden; use new Observable."
+      forbidden: "Observable.create is forbidden; use new Observable.",
+      forbiddenSubject: "Subject.create is forbidden."
     },
     schema: [],
     type: "problem"
   },
   name: "no-create",
   create: (context) => {
-    const { couldBeObservable } = getTypeServices(context);
+    const { couldBeObservable, couldBeType: couldBeType2 } = getTypeServices(context);
     return {
       "CallExpression > MemberExpression[object.name='Observable'] > Identifier[name='create']": (node) => {
         const memberExpression = node.parent;
@@ -1125,6 +1129,15 @@ var noCreateRule = ruleCreator({
             node
           });
         }
+      },
+      "CallExpression > MemberExpression[object.name=/^(Subject|BehaviorSubject|AsyncSubject|ReplaySubject)$/] > Identifier[name='create']": (node) => {
+        const memberExpression = node.parent;
+        if (couldBeType2(memberExpression.object, /^(Subject|BehaviorSubject|AsyncSubject|ReplaySubject)$/)) {
+          context.report({
+            messageId: "forbiddenSubject",
+            node
+          });
+        }
       }
     };
   }
@@ -2090,7 +2103,7 @@ var noImplicitAnyCatchRule = ruleCreator({
   defaultOptions: defaultOptions8,
   meta: {
     docs: {
-      description: "Disallow implicit `any` error parameters in `catchError` operators.",
+      description: "Disallow implicit `any` error parameters in `catchError`, `subscribe`, and `tap`.",
       recommended: {
         recommended: true,
         strict: [{
@@ -2105,8 +2118,10 @@ var noImplicitAnyCatchRule = ruleCreator({
       explicitAny: "Explicit `any` in error callback.",
       implicitAny: "Implicit `any` in error callback.",
       narrowed: "Error type must be `unknown` or `any`.",
+      narrowedAllowError: "Error type must be `unknown`, `any`, or `Error`.",
       suggestExplicitUnknown: "Use `unknown` instead to explicitly and safely assert the type is correct.",
-      suggestExplicitAny: "Use `any` instead to explicitly opt out of type safety."
+      suggestExplicitAny: "Use `any` instead to explicitly opt out of type safety.",
+      suggestExplicitError: "Use `Error` instead."
     },
     schema: [
       {
@@ -2116,6 +2131,11 @@ var noImplicitAnyCatchRule = ruleCreator({
             type: "boolean",
             description: "Allow error variable to be explicitly typed as `any`.",
             default: true
+          },
+          allowExplicitError: {
+            type: "boolean",
+            description: "Allow narrowing error type to `Error`.",
+            default: false
           }
         },
         type: "object"
@@ -2126,7 +2146,7 @@ var noImplicitAnyCatchRule = ruleCreator({
   name: "no-implicit-any-catch",
   create: (context) => {
     const [config = {}] = context.options;
-    const { allowExplicitAny = true } = config;
+    const { allowExplicitAny = true, allowExplicitError = false } = config;
     const { couldBeObservable } = getTypeServices(context);
     const sourceCode = context.sourceCode;
     function createReplacerFix(typeAnnotation, replaceWith) {
@@ -2171,20 +2191,33 @@ var noImplicitAnyCatchRule = ruleCreator({
               ]
             });
           } else if (type !== AST_NODE_TYPES4.TSUnknownKeyword) {
-            context.report({
-              messageId: "narrowed",
-              node: param,
-              suggest: [
-                {
-                  messageId: "suggestExplicitUnknown",
-                  fix: createReplacerFix(typeAnnotation, "unknown")
-                },
-                allowExplicitAny ? {
-                  messageId: "suggestExplicitAny",
-                  fix: createReplacerFix(typeAnnotation, "any")
-                } : null
-              ].filter((x) => !!x)
-            });
+            let isAllowedError = false;
+            if (allowExplicitError && type === AST_NODE_TYPES4.TSTypeReference) {
+              const typeRef = typeAnnotation.typeAnnotation;
+              if (isIdentifier(typeRef.typeName)) {
+                isAllowedError = typeRef.typeName.name === "Error";
+              }
+            }
+            if (!isAllowedError) {
+              context.report({
+                messageId: allowExplicitError ? "narrowedAllowError" : "narrowed",
+                node: param,
+                suggest: [
+                  {
+                    messageId: "suggestExplicitUnknown",
+                    fix: createReplacerFix(typeAnnotation, "unknown")
+                  },
+                  allowExplicitAny ? {
+                    messageId: "suggestExplicitAny",
+                    fix: createReplacerFix(typeAnnotation, "any")
+                  } : null,
+                  allowExplicitError && !isAllowedError ? {
+                    messageId: "suggestExplicitError",
+                    fix: createReplacerFix(typeAnnotation, "Error")
+                  } : null
+                ].filter((x) => !!x)
+              });
+            }
           }
         } else {
           const hasRestParams = restParams.length > 0;
@@ -4317,7 +4350,8 @@ var throwErrorRule = ruleCreator({
       requiresTypeChecking: true
     },
     messages: {
-      forbidden: "Passing non-Error values is forbidden."
+      forbidden: "Passing non-Error values is forbidden.",
+      suggestErrorConstructor: "Wrap string in Error constructor."
     },
     schema: [
       {
@@ -4328,7 +4362,8 @@ var throwErrorRule = ruleCreator({
         type: "object"
       }
     ],
-    type: "problem"
+    type: "problem",
+    hasSuggestions: true
   },
   name: "throw-error",
   create: (context) => {
@@ -4356,9 +4391,22 @@ var throwErrorRule = ruleCreator({
       if (couldBeType(type, /^Error$/)) {
         return;
       }
+      const isString = isTemplateLiteral(reportNode) || isLiteral(reportNode) && typeof reportNode.value === "string";
       context.report({
         messageId: "forbidden",
-        node: reportNode
+        node: reportNode,
+        ...isString && {
+          suggest: [
+            {
+              messageId: "suggestErrorConstructor",
+              fix: (fixer) => {
+                const sourceCode = context.sourceCode;
+                const nodeText = sourceCode.getText(reportNode);
+                return fixer.replaceText(reportNode, `new Error(${nodeText})`);
+              }
+            }
+          ]
+        }
       });
     }
     function checkThrowError(node) {

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "eslint-plugin-rxjs-x",
   "type": "commonjs",
-  "version": "0.9.1",
+  "version": "0.9.2",
   "packageManager": "yarn@4.12.0+sha512.f45ab632439a67f8bc759bf32ead036a1f413287b9042726b7cc4818b7b49e14e9423ba49b18f9e06ea4941c1ad062385b1d8760a8d5091a1a31e5f6219afca8",
   "description": "Modern ESLint plugin for RxJS",
   "author": "Jason Weinzierl <weinzierljason@gmail.com>",
@@ -84,7 +84,7 @@
     "@typescript/vfs": "^1.6.2",
     "@vitest/coverage-v8": "^3.2.4",
     "@vitest/eslint-plugin": "^1.4.0",
-    "bumpp": "^10.4.0",
+    "bumpp": "^10.4.1",
     "eslint": "^9.39.2",
     "eslint-config-flat-gitignore": "^2.1.0",
     "eslint-doc-generator": "^2.4.0",