eslint-plugin-rxjs-x 0.9.0 → 0.9.2

package/README.md

@@ -128,7 +128,7 @@ The package includes the following rules.
 | [no-async-subscribe](docs/rules/no-async-subscribe.md)                           | Disallow passing `async` functions to `subscribe`.                                                        | ✅ 🔒 |    |    | 💭 |    |
 | [no-compat](docs/rules/no-compat.md)                                             | Disallow the `rxjs-compat` package.                                                                       |      |    |    |    | ❌  |
 | [no-connectable](docs/rules/no-connectable.md)                                   | Disallow operators that return connectable observables.                                                   |      |    |    | 💭 |    |
-| [no-create](docs/rules/no-create.md)                                             | Disallow the static `Observable.create` function.                                                         | ✅ 🔒 |    |    | 💭 |    |
+| [no-create](docs/rules/no-create.md)                                             | Disallow the static `Observable.create` and `Subject.create` functions.                                   | ✅ 🔒 |    |    | 💭 |    |
 | [no-cyclic-action](docs/rules/no-cyclic-action.md)                               | Disallow cyclic actions in effects and epics.                                                             |      |    |    | 💭 |    |
 | [no-explicit-generics](docs/rules/no-explicit-generics.md)                       | Disallow unnecessary explicit generic type arguments.                                                     |      |    |    | 💭 |    |
 | [no-exposed-subjects](docs/rules/no-exposed-subjects.md)                         | Disallow public and protected subjects.                                                                   | 🔒   |    |    | 💭 |    |
@@ -142,7 +142,7 @@ The package includes the following rules.
 | [no-ignored-subscribe](docs/rules/no-ignored-subscribe.md)                       | Disallow calling `subscribe` without specifying arguments.                                                |      |    |    | 💭 |    |
 | [no-ignored-subscription](docs/rules/no-ignored-subscription.md)                 | Disallow ignoring the subscription returned by `subscribe`.                                               |      |    |    | 💭 |    |
 | [no-ignored-takewhile-value](docs/rules/no-ignored-takewhile-value.md)           | Disallow ignoring the value within `takeWhile`.                                                           | ✅ 🔒 |    |    |    |    |
-| [no-implicit-any-catch](docs/rules/no-implicit-any-catch.md)                     | Disallow implicit `any` error parameters in `catchError` operators.                                       | ✅ 🔒 | 🔧 | 💡 | 💭 |    |
+| [no-implicit-any-catch](docs/rules/no-implicit-any-catch.md)                     | Disallow implicit `any` error parameters in `catchError`, `subscribe`, and `tap`.                         | ✅ 🔒 | 🔧 | 💡 | 💭 |    |
 | [no-index](docs/rules/no-index.md)                                               | Disallow importing index modules.                                                                         | ✅ 🔒 |    |    |    |    |
 | [no-internal](docs/rules/no-internal.md)                                         | Disallow importing internal modules.                                                                      | ✅ 🔒 | 🔧 | 💡 |    |    |
 | [no-misused-observables](docs/rules/no-misused-observables.md)                   | Disallow Observables in places not designed to handle them.                                               | 🔒   |    |    | 💭 |    |
@@ -167,6 +167,6 @@ The package includes the following rules.
 | [prefer-observer](docs/rules/prefer-observer.md)                                 | Disallow passing separate handlers to `subscribe` and `tap`.                                              | ✅ 🔒 | 🔧 | 💡 | 💭 |    |
 | [prefer-root-operators](docs/rules/prefer-root-operators.md)                     | Disallow importing operators from `rxjs/operators`.                                                       | ✅ 🔒 | 🔧 | 💡 |    |    |
 | [suffix-subjects](docs/rules/suffix-subjects.md)                                 | Enforce the use of a suffix in subject identifiers.                                                       |      |    |    | 💭 |    |
-| [throw-error](docs/rules/throw-error.md)                                         | Enforce passing only `Error` values to `throwError` or `Subject.error`.                                   | ✅ 🔒 |    |    | 💭 |    |
+| [throw-error](docs/rules/throw-error.md)                                         | Enforce passing only `Error` values to `throwError` or `Subject.error`.                                   | ✅ 🔒 |    | 💡 | 💭 |    |
 
 <!-- end auto-generated rules list -->

package/dist/index.d.mts

@@ -18,12 +18,13 @@ declare const allRules: {
         description: "Disallow banned operators.";
         requiresTypeChecking: true;
     }, TSESLint.RuleListener>;
-    finnish: TSESLint.RuleModule<"shouldBeFinnish" | "shouldNotBeFinnish", readonly {
+    finnish: TSESLint.RuleModule<"shouldBeFinnish" | "shouldBeFinnishProperty" | "shouldNotBeFinnish", readonly {
         functions?: boolean;
         methods?: boolean;
         names?: Record<string, boolean>;
         parameters?: boolean;
         properties?: boolean;
+        objects?: boolean;
         strict?: boolean;
         types?: Record<string, boolean>;
         variables?: boolean;
@@ -49,8 +50,8 @@ declare const allRules: {
         description: "Disallow operators that return connectable observables.";
         requiresTypeChecking: true;
     }, TSESLint.RuleListener>;
-    'no-create': TSESLint.RuleModule<"forbidden", [], {
-        description: "Disallow the static `Observable.create` function.";
+    'no-create': TSESLint.RuleModule<"forbidden" | "forbiddenSubject", [], {
+        description: "Disallow the static `Observable.create` and `Subject.create` functions.";
         recommended: "recommended";
         requiresTypeChecking: true;
     }, TSESLint.RuleListener>;
@@ -119,10 +120,11 @@ declare const allRules: {
         description: "Disallow ignoring the value within `takeWhile`.";
         recommended: "recommended";
     }, TSESLint.RuleListener>;
-    'no-implicit-any-catch': TSESLint.RuleModule<"explicitAny" | "implicitAny" | "narrowed" | "suggestExplicitUnknown" | "suggestExplicitAny", readonly {
+    'no-implicit-any-catch': TSESLint.RuleModule<"explicitAny" | "implicitAny" | "narrowed" | "narrowedAllowError" | "suggestExplicitUnknown" | "suggestExplicitAny" | "suggestExplicitError", readonly {
         allowExplicitAny?: boolean;
+        allowExplicitError?: boolean;
     }[], {
-        description: "Disallow implicit `any` error parameters in `catchError` operators.";
+        description: "Disallow implicit `any` error parameters in `catchError`, `subscribe`, and `tap`.";
         recommended: {
             recommended: true;
             strict: [{
@@ -266,7 +268,7 @@ declare const allRules: {
         description: "Enforce the use of a suffix in subject identifiers.";
         requiresTypeChecking: true;
     }, TSESLint.RuleListener>;
-    'throw-error': TSESLint.RuleModule<"forbidden", readonly {
+    'throw-error': TSESLint.RuleModule<"forbidden" | "suggestErrorConstructor", readonly {
         allowThrowingAny?: boolean;
         allowThrowingUnknown?: boolean;
     }[], {

package/dist/index.d.ts

@@ -18,12 +18,13 @@ declare const allRules: {
         description: "Disallow banned operators.";
         requiresTypeChecking: true;
     }, TSESLint.RuleListener>;
-    finnish: TSESLint.RuleModule<"shouldBeFinnish" | "shouldNotBeFinnish", readonly {
+    finnish: TSESLint.RuleModule<"shouldBeFinnish" | "shouldBeFinnishProperty" | "shouldNotBeFinnish", readonly {
         functions?: boolean;
         methods?: boolean;
         names?: Record<string, boolean>;
         parameters?: boolean;
         properties?: boolean;
+        objects?: boolean;
         strict?: boolean;
         types?: Record<string, boolean>;
         variables?: boolean;
@@ -49,8 +50,8 @@ declare const allRules: {
         description: "Disallow operators that return connectable observables.";
         requiresTypeChecking: true;
     }, TSESLint.RuleListener>;
-    'no-create': TSESLint.RuleModule<"forbidden", [], {
-        description: "Disallow the static `Observable.create` function.";
+    'no-create': TSESLint.RuleModule<"forbidden" | "forbiddenSubject", [], {
+        description: "Disallow the static `Observable.create` and `Subject.create` functions.";
         recommended: "recommended";
         requiresTypeChecking: true;
     }, TSESLint.RuleListener>;
@@ -119,10 +120,11 @@ declare const allRules: {
         description: "Disallow ignoring the value within `takeWhile`.";
         recommended: "recommended";
     }, TSESLint.RuleListener>;
-    'no-implicit-any-catch': TSESLint.RuleModule<"explicitAny" | "implicitAny" | "narrowed" | "suggestExplicitUnknown" | "suggestExplicitAny", readonly {
+    'no-implicit-any-catch': TSESLint.RuleModule<"explicitAny" | "implicitAny" | "narrowed" | "narrowedAllowError" | "suggestExplicitUnknown" | "suggestExplicitAny" | "suggestExplicitError", readonly {
         allowExplicitAny?: boolean;
+        allowExplicitError?: boolean;
     }[], {
-        description: "Disallow implicit `any` error parameters in `catchError` operators.";
+        description: "Disallow implicit `any` error parameters in `catchError`, `subscribe`, and `tap`.";
         recommended: {
             recommended: true;
             strict: [{
@@ -266,7 +268,7 @@ declare const allRules: {
         description: "Enforce the use of a suffix in subject identifiers.";
         requiresTypeChecking: true;
     }, TSESLint.RuleListener>;
-    'throw-error': TSESLint.RuleModule<"forbidden", readonly {
+    'throw-error': TSESLint.RuleModule<"forbidden" | "suggestErrorConstructor", readonly {
         allowThrowingAny?: boolean;
         allowThrowingUnknown?: boolean;
     }[], {

package/dist/index.js

@@ -1,6 +1,6 @@
 "use strict";Object.defineProperty(exports, "__esModule", {value: true}); function _interopRequireWildcard(obj) { if (obj && obj.__esModule) { return obj; } else { var newObj = {}; if (obj != null) { for (var key in obj) { if (Object.prototype.hasOwnProperty.call(obj, key)) { newObj[key] = obj[key]; } } } newObj.default = obj; return newObj; } } function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }// package.json
 var name = "eslint-plugin-rxjs-x";
-var version = "0.9.0";
+var version = "0.9.2";
 
 // src/configs/recommended.ts
 var createRecommendedConfig = (plugin2) => ({
@@ -274,6 +274,9 @@ function isJSXExpressionContainer(node) {
 function isLiteral(node) {
   return node.type === _utils.AST_NODE_TYPES.Literal;
 }
+function isTemplateLiteral(node) {
+  return node.type === _utils.AST_NODE_TYPES.TemplateLiteral;
+}
 function isMemberExpression(node) {
   return node.type === _utils.AST_NODE_TYPES.MemberExpression;
 }
@@ -298,12 +301,21 @@ function isPropertyDefinition(node) {
 function isSpreadElement(node) {
   return node.type === _utils.AST_NODE_TYPES.SpreadElement;
 }
+function isTSAsExpression(node) {
+  return node.type === _utils.AST_NODE_TYPES.TSAsExpression;
+}
+function isTSSatisfiesExpression(node) {
+  return node.type === _utils.AST_NODE_TYPES.TSSatisfiesExpression;
+}
 function isUnaryExpression(node) {
   return node.type === _utils.AST_NODE_TYPES.UnaryExpression;
 }
 function isUnionType(node) {
   return node.type === _utils.AST_NODE_TYPES.TSUnionType;
 }
+function isVariableDeclarator(node) {
+  return node.type === _utils.AST_NODE_TYPES.VariableDeclarator;
+}
 
 // src/etc/get-type-services.ts
 function getTypeServices(context) {
@@ -583,6 +595,7 @@ var banOperatorsRule = ruleCreator({
 // src/rules/finnish.ts
 
 var defaultOptions3 = [];
+var baseShouldBeFinnish = "Finnish notation should be used here.";
 var finnishRule = ruleCreator({
   defaultOptions: defaultOptions3,
   meta: {
@@ -591,7 +604,8 @@ var finnishRule = ruleCreator({
       requiresTypeChecking: true
     },
     messages: {
-      shouldBeFinnish: "Finnish notation should be used here.",
+      shouldBeFinnish: baseShouldBeFinnish,
+      shouldBeFinnishProperty: `${baseShouldBeFinnish} Add a type annotation, assertion, or 'satisfies' to silence this rule.`,
       shouldNotBeFinnish: "Finnish notation should not be used here."
     },
     schema: [
@@ -601,7 +615,8 @@ var finnishRule = ruleCreator({
           methods: { type: "boolean", description: "Require for methods." },
           names: { type: "object", description: "Enforce for specific names. Keys are a RegExp, values are a boolean." },
           parameters: { type: "boolean", description: "Require for parameters." },
-          properties: { type: "boolean", description: "Require for properties." },
+          properties: { type: "boolean", description: 'Require for properties, except object literal keys (see "objects" option).' },
+          objects: { type: "boolean", description: "Require for object literal keys." },
           strict: { type: "boolean", description: "Disallow Finnish notation for non-Observables." },
           types: { type: "object", description: "Enforce for specific types. Keys are a RegExp, values are a boolean." },
           variables: { type: "boolean", description: "Require for variables." }
@@ -627,6 +642,7 @@ var finnishRule = ruleCreator({
       methods: true,
       parameters: true,
       properties: true,
+      objects: true,
       variables: true,
       ...config
     };
@@ -656,7 +672,7 @@ var finnishRule = ruleCreator({
         validate: false
       });
     }
-    function checkNode(nameNode, typeNode) {
+    function checkNode(nameNode, typeNode, shouldMessage = "shouldBeFinnish") {
       const tsNode = esTreeNodeToTSNodeMap.get(nameNode);
       const text = tsNode.getText();
       const hasFinnish = text.endsWith("$");
@@ -667,7 +683,7 @@ var finnishRule = ruleCreator({
       } : () => {
         context.report({
           loc: getLoc(tsNode),
-          messageId: "shouldBeFinnish"
+          messageId: shouldMessage
         });
       };
       const shouldNotBeFinnish = hasFinnish ? () => {
@@ -718,7 +734,7 @@ var finnishRule = ruleCreator({
         if (!found) {
           return;
         }
-        if (!validate.variables && found.type === _utils.AST_NODE_TYPES.VariableDeclarator) {
+        if (!validate.variables && isVariableDeclarator(found)) {
           return;
         }
         if (!validate.parameters) {
@@ -779,12 +795,29 @@ var finnishRule = ruleCreator({
         }
       },
       "ObjectExpression > Property[computed=false] > Identifier": (node) => {
-        if (validate.properties) {
-          const parent = node.parent;
-          if (node === parent.key && !isSourcesObjectAcceptingStaticObservableCreator(parent.parent.parent)) {
-            checkNode(node);
+        if (!validate.objects) {
+          return;
+        }
+        const found = findParent(
+          node,
+          "CallExpression",
+          "VariableDeclarator",
+          "TSSatisfiesExpression",
+          "TSAsExpression"
+        );
+        if (found) {
+          if (isCallExpression(found)) {
+            return;
+          } else if (isVariableDeclarator(found) && !!found.id.typeAnnotation) {
+            return;
+          } else if (isTSAsExpression(found) || isTSSatisfiesExpression(found)) {
+            return;
           }
         }
+        const parent = node.parent;
+        if (node === parent.key) {
+          checkNode(node, void 0, "shouldBeFinnishProperty");
+        }
       },
       "ObjectPattern > Property > Identifier": (node) => {
         const found = findParent(
@@ -797,7 +830,7 @@ var finnishRule = ruleCreator({
         if (!found) {
           return;
         }
-        if (!validate.variables && found.type === _utils.AST_NODE_TYPES.VariableDeclarator) {
+        if (!validate.variables && isVariableDeclarator(found)) {
           return;
         }
         if (!validate.parameters) {
@@ -1073,19 +1106,20 @@ var noCreateRule = ruleCreator({
   defaultOptions: [],
   meta: {
     docs: {
-      description: "Disallow the static `Observable.create` function.",
+      description: "Disallow the static `Observable.create` and `Subject.create` functions.",
       recommended: "recommended",
       requiresTypeChecking: true
     },
     messages: {
-      forbidden: "Observable.create is forbidden; use new Observable."
+      forbidden: "Observable.create is forbidden; use new Observable.",
+      forbiddenSubject: "Subject.create is forbidden."
     },
     schema: [],
     type: "problem"
   },
   name: "no-create",
   create: (context) => {
-    const { couldBeObservable } = getTypeServices(context);
+    const { couldBeObservable, couldBeType: couldBeType2 } = getTypeServices(context);
     return {
       "CallExpression > MemberExpression[object.name='Observable'] > Identifier[name='create']": (node) => {
         const memberExpression = node.parent;
@@ -1095,6 +1129,15 @@ var noCreateRule = ruleCreator({
             node
           });
         }
+      },
+      "CallExpression > MemberExpression[object.name=/^(Subject|BehaviorSubject|AsyncSubject|ReplaySubject)$/] > Identifier[name='create']": (node) => {
+        const memberExpression = node.parent;
+        if (couldBeType2(memberExpression.object, /^(Subject|BehaviorSubject|AsyncSubject|ReplaySubject)$/)) {
+          context.report({
+            messageId: "forbiddenSubject",
+            node
+          });
+        }
       }
     };
   }
@@ -2060,7 +2103,7 @@ var noImplicitAnyCatchRule = ruleCreator({
   defaultOptions: defaultOptions8,
   meta: {
     docs: {
-      description: "Disallow implicit `any` error parameters in `catchError` operators.",
+      description: "Disallow implicit `any` error parameters in `catchError`, `subscribe`, and `tap`.",
       recommended: {
         recommended: true,
         strict: [{
@@ -2075,8 +2118,10 @@ var noImplicitAnyCatchRule = ruleCreator({
       explicitAny: "Explicit `any` in error callback.",
       implicitAny: "Implicit `any` in error callback.",
       narrowed: "Error type must be `unknown` or `any`.",
+      narrowedAllowError: "Error type must be `unknown`, `any`, or `Error`.",
       suggestExplicitUnknown: "Use `unknown` instead to explicitly and safely assert the type is correct.",
-      suggestExplicitAny: "Use `any` instead to explicitly opt out of type safety."
+      suggestExplicitAny: "Use `any` instead to explicitly opt out of type safety.",
+      suggestExplicitError: "Use `Error` instead."
     },
     schema: [
       {
@@ -2086,6 +2131,11 @@ var noImplicitAnyCatchRule = ruleCreator({
             type: "boolean",
             description: "Allow error variable to be explicitly typed as `any`.",
             default: true
+          },
+          allowExplicitError: {
+            type: "boolean",
+            description: "Allow narrowing error type to `Error`.",
+            default: false
           }
         },
         type: "object"
@@ -2096,7 +2146,7 @@ var noImplicitAnyCatchRule = ruleCreator({
   name: "no-implicit-any-catch",
   create: (context) => {
     const [config = {}] = context.options;
-    const { allowExplicitAny = true } = config;
+    const { allowExplicitAny = true, allowExplicitError = false } = config;
     const { couldBeObservable } = getTypeServices(context);
     const sourceCode = context.sourceCode;
     function createReplacerFix(typeAnnotation, replaceWith) {
@@ -2141,20 +2191,33 @@ var noImplicitAnyCatchRule = ruleCreator({
               ]
             });
           } else if (type !== _utils.AST_NODE_TYPES.TSUnknownKeyword) {
-            context.report({
-              messageId: "narrowed",
-              node: param,
-              suggest: [
-                {
-                  messageId: "suggestExplicitUnknown",
-                  fix: createReplacerFix(typeAnnotation, "unknown")
-                },
-                allowExplicitAny ? {
-                  messageId: "suggestExplicitAny",
-                  fix: createReplacerFix(typeAnnotation, "any")
-                } : null
-              ].filter((x) => !!x)
-            });
+            let isAllowedError = false;
+            if (allowExplicitError && type === _utils.AST_NODE_TYPES.TSTypeReference) {
+              const typeRef = typeAnnotation.typeAnnotation;
+              if (isIdentifier(typeRef.typeName)) {
+                isAllowedError = typeRef.typeName.name === "Error";
+              }
+            }
+            if (!isAllowedError) {
+              context.report({
+                messageId: allowExplicitError ? "narrowedAllowError" : "narrowed",
+                node: param,
+                suggest: [
+                  {
+                    messageId: "suggestExplicitUnknown",
+                    fix: createReplacerFix(typeAnnotation, "unknown")
+                  },
+                  allowExplicitAny ? {
+                    messageId: "suggestExplicitAny",
+                    fix: createReplacerFix(typeAnnotation, "any")
+                  } : null,
+                  allowExplicitError && !isAllowedError ? {
+                    messageId: "suggestExplicitError",
+                    fix: createReplacerFix(typeAnnotation, "Error")
+                  } : null
+                ].filter((x) => !!x)
+              });
+            }
           }
         } else {
           const hasRestParams = restParams.length > 0;
@@ -4287,7 +4350,8 @@ var throwErrorRule = ruleCreator({
       requiresTypeChecking: true
     },
     messages: {
-      forbidden: "Passing non-Error values is forbidden."
+      forbidden: "Passing non-Error values is forbidden.",
+      suggestErrorConstructor: "Wrap string in Error constructor."
     },
     schema: [
       {
@@ -4298,7 +4362,8 @@ var throwErrorRule = ruleCreator({
         type: "object"
       }
     ],
-    type: "problem"
+    type: "problem",
+    hasSuggestions: true
   },
   name: "throw-error",
   create: (context) => {
@@ -4326,9 +4391,22 @@ var throwErrorRule = ruleCreator({
       if (couldBeType(type, /^Error$/)) {
         return;
       }
+      const isString = isTemplateLiteral(reportNode) || isLiteral(reportNode) && typeof reportNode.value === "string";
       context.report({
         messageId: "forbidden",
-        node: reportNode
+        node: reportNode,
+        ...isString && {
+          suggest: [
+            {
+              messageId: "suggestErrorConstructor",
+              fix: (fixer) => {
+                const sourceCode = context.sourceCode;
+                const nodeText = sourceCode.getText(reportNode);
+                return fixer.replaceText(reportNode, `new Error(${nodeText})`);
+              }
+            }
+          ]
+        }
       });
     }
     function checkThrowError(node) {

package/dist/index.mjs

@@ -1,6 +1,6 @@
 // package.json
 var name = "eslint-plugin-rxjs-x";
-var version = "0.9.0";
+var version = "0.9.2";
 
 // src/configs/recommended.ts
 var createRecommendedConfig = (plugin2) => ({
@@ -274,6 +274,9 @@ function isJSXExpressionContainer(node) {
 function isLiteral(node) {
   return node.type === AST_NODE_TYPES.Literal;
 }
+function isTemplateLiteral(node) {
+  return node.type === AST_NODE_TYPES.TemplateLiteral;
+}
 function isMemberExpression(node) {
   return node.type === AST_NODE_TYPES.MemberExpression;
 }
@@ -298,12 +301,21 @@ function isPropertyDefinition(node) {
 function isSpreadElement(node) {
   return node.type === AST_NODE_TYPES.SpreadElement;
 }
+function isTSAsExpression(node) {
+  return node.type === AST_NODE_TYPES.TSAsExpression;
+}
+function isTSSatisfiesExpression(node) {
+  return node.type === AST_NODE_TYPES.TSSatisfiesExpression;
+}
 function isUnaryExpression(node) {
   return node.type === AST_NODE_TYPES.UnaryExpression;
 }
 function isUnionType(node) {
   return node.type === AST_NODE_TYPES.TSUnionType;
 }
+function isVariableDeclarator(node) {
+  return node.type === AST_NODE_TYPES.VariableDeclarator;
+}
 
 // src/etc/get-type-services.ts
 function getTypeServices(context) {
@@ -581,8 +593,9 @@ var banOperatorsRule = ruleCreator({
 });
 
 // src/rules/finnish.ts
-import { AST_NODE_TYPES as AST_NODE_TYPES4, ESLintUtils as ESLintUtils3 } from "@typescript-eslint/utils";
+import { ESLintUtils as ESLintUtils3 } from "@typescript-eslint/utils";
 var defaultOptions3 = [];
+var baseShouldBeFinnish = "Finnish notation should be used here.";
 var finnishRule = ruleCreator({
   defaultOptions: defaultOptions3,
   meta: {
@@ -591,7 +604,8 @@ var finnishRule = ruleCreator({
       requiresTypeChecking: true
     },
     messages: {
-      shouldBeFinnish: "Finnish notation should be used here.",
+      shouldBeFinnish: baseShouldBeFinnish,
+      shouldBeFinnishProperty: `${baseShouldBeFinnish} Add a type annotation, assertion, or 'satisfies' to silence this rule.`,
       shouldNotBeFinnish: "Finnish notation should not be used here."
     },
     schema: [
@@ -601,7 +615,8 @@ var finnishRule = ruleCreator({
           methods: { type: "boolean", description: "Require for methods." },
           names: { type: "object", description: "Enforce for specific names. Keys are a RegExp, values are a boolean." },
           parameters: { type: "boolean", description: "Require for parameters." },
-          properties: { type: "boolean", description: "Require for properties." },
+          properties: { type: "boolean", description: 'Require for properties, except object literal keys (see "objects" option).' },
+          objects: { type: "boolean", description: "Require for object literal keys." },
           strict: { type: "boolean", description: "Disallow Finnish notation for non-Observables." },
           types: { type: "object", description: "Enforce for specific types. Keys are a RegExp, values are a boolean." },
           variables: { type: "boolean", description: "Require for variables." }
@@ -627,6 +642,7 @@ var finnishRule = ruleCreator({
       methods: true,
       parameters: true,
       properties: true,
+      objects: true,
       variables: true,
       ...config
     };
@@ -656,7 +672,7 @@ var finnishRule = ruleCreator({
         validate: false
       });
     }
-    function checkNode(nameNode, typeNode) {
+    function checkNode(nameNode, typeNode, shouldMessage = "shouldBeFinnish") {
       const tsNode = esTreeNodeToTSNodeMap.get(nameNode);
       const text = tsNode.getText();
       const hasFinnish = text.endsWith("$");
@@ -667,7 +683,7 @@ var finnishRule = ruleCreator({
       } : () => {
         context.report({
           loc: getLoc(tsNode),
-          messageId: "shouldBeFinnish"
+          messageId: shouldMessage
         });
       };
       const shouldNotBeFinnish = hasFinnish ? () => {
@@ -718,7 +734,7 @@ var finnishRule = ruleCreator({
         if (!found) {
           return;
         }
-        if (!validate.variables && found.type === AST_NODE_TYPES4.VariableDeclarator) {
+        if (!validate.variables && isVariableDeclarator(found)) {
           return;
         }
         if (!validate.parameters) {
@@ -779,12 +795,29 @@ var finnishRule = ruleCreator({
         }
       },
       "ObjectExpression > Property[computed=false] > Identifier": (node) => {
-        if (validate.properties) {
-          const parent = node.parent;
-          if (node === parent.key && !isSourcesObjectAcceptingStaticObservableCreator(parent.parent.parent)) {
-            checkNode(node);
+        if (!validate.objects) {
+          return;
+        }
+        const found = findParent(
+          node,
+          "CallExpression",
+          "VariableDeclarator",
+          "TSSatisfiesExpression",
+          "TSAsExpression"
+        );
+        if (found) {
+          if (isCallExpression(found)) {
+            return;
+          } else if (isVariableDeclarator(found) && !!found.id.typeAnnotation) {
+            return;
+          } else if (isTSAsExpression(found) || isTSSatisfiesExpression(found)) {
+            return;
           }
         }
+        const parent = node.parent;
+        if (node === parent.key) {
+          checkNode(node, void 0, "shouldBeFinnishProperty");
+        }
       },
       "ObjectPattern > Property > Identifier": (node) => {
         const found = findParent(
@@ -797,7 +830,7 @@ var finnishRule = ruleCreator({
         if (!found) {
           return;
         }
-        if (!validate.variables && found.type === AST_NODE_TYPES4.VariableDeclarator) {
+        if (!validate.variables && isVariableDeclarator(found)) {
           return;
         }
         if (!validate.parameters) {
@@ -1073,19 +1106,20 @@ var noCreateRule = ruleCreator({
   defaultOptions: [],
   meta: {
     docs: {
-      description: "Disallow the static `Observable.create` function.",
+      description: "Disallow the static `Observable.create` and `Subject.create` functions.",
       recommended: "recommended",
       requiresTypeChecking: true
     },
     messages: {
-      forbidden: "Observable.create is forbidden; use new Observable."
+      forbidden: "Observable.create is forbidden; use new Observable.",
+      forbiddenSubject: "Subject.create is forbidden."
     },
     schema: [],
     type: "problem"
   },
   name: "no-create",
   create: (context) => {
-    const { couldBeObservable } = getTypeServices(context);
+    const { couldBeObservable, couldBeType: couldBeType2 } = getTypeServices(context);
     return {
       "CallExpression > MemberExpression[object.name='Observable'] > Identifier[name='create']": (node) => {
         const memberExpression = node.parent;
@@ -1095,6 +1129,15 @@ var noCreateRule = ruleCreator({
             node
           });
         }
+      },
+      "CallExpression > MemberExpression[object.name=/^(Subject|BehaviorSubject|AsyncSubject|ReplaySubject)$/] > Identifier[name='create']": (node) => {
+        const memberExpression = node.parent;
+        if (couldBeType2(memberExpression.object, /^(Subject|BehaviorSubject|AsyncSubject|ReplaySubject)$/)) {
+          context.report({
+            messageId: "forbiddenSubject",
+            node
+          });
+        }
       }
     };
   }
@@ -2048,7 +2091,7 @@ var noIgnoredTakewhileValueRule = ruleCreator({
 
 // src/rules/no-implicit-any-catch.ts
 import {
-  AST_NODE_TYPES as AST_NODE_TYPES5
+  AST_NODE_TYPES as AST_NODE_TYPES4
 } from "@typescript-eslint/utils";
 function isParenthesised(sourceCode, node) {
   const before = sourceCode.getTokenBefore(node);
@@ -2060,7 +2103,7 @@ var noImplicitAnyCatchRule = ruleCreator({
   defaultOptions: defaultOptions8,
   meta: {
     docs: {
-      description: "Disallow implicit `any` error parameters in `catchError` operators.",
+      description: "Disallow implicit `any` error parameters in `catchError`, `subscribe`, and `tap`.",
       recommended: {
         recommended: true,
         strict: [{
@@ -2075,8 +2118,10 @@ var noImplicitAnyCatchRule = ruleCreator({
       explicitAny: "Explicit `any` in error callback.",
       implicitAny: "Implicit `any` in error callback.",
       narrowed: "Error type must be `unknown` or `any`.",
+      narrowedAllowError: "Error type must be `unknown`, `any`, or `Error`.",
       suggestExplicitUnknown: "Use `unknown` instead to explicitly and safely assert the type is correct.",
-      suggestExplicitAny: "Use `any` instead to explicitly opt out of type safety."
+      suggestExplicitAny: "Use `any` instead to explicitly opt out of type safety.",
+      suggestExplicitError: "Use `Error` instead."
     },
     schema: [
       {
@@ -2086,6 +2131,11 @@ var noImplicitAnyCatchRule = ruleCreator({
             type: "boolean",
             description: "Allow error variable to be explicitly typed as `any`.",
             default: true
+          },
+          allowExplicitError: {
+            type: "boolean",
+            description: "Allow narrowing error type to `Error`.",
+            default: false
           }
         },
         type: "object"
@@ -2096,7 +2146,7 @@ var noImplicitAnyCatchRule = ruleCreator({
   name: "no-implicit-any-catch",
   create: (context) => {
     const [config = {}] = context.options;
-    const { allowExplicitAny = true } = config;
+    const { allowExplicitAny = true, allowExplicitError = false } = config;
     const { couldBeObservable } = getTypeServices(context);
     const sourceCode = context.sourceCode;
     function createReplacerFix(typeAnnotation, replaceWith) {
@@ -2126,7 +2176,7 @@ var noImplicitAnyCatchRule = ruleCreator({
           const {
             typeAnnotation: { type }
           } = typeAnnotation;
-          if (type === AST_NODE_TYPES5.TSAnyKeyword) {
+          if (type === AST_NODE_TYPES4.TSAnyKeyword) {
             if (allowExplicitAny) {
               return;
             }
@@ -2140,21 +2190,34 @@ var noImplicitAnyCatchRule = ruleCreator({
                 }
               ]
             });
-          } else if (type !== AST_NODE_TYPES5.TSUnknownKeyword) {
-            context.report({
-              messageId: "narrowed",
-              node: param,
-              suggest: [
-                {
-                  messageId: "suggestExplicitUnknown",
-                  fix: createReplacerFix(typeAnnotation, "unknown")
-                },
-                allowExplicitAny ? {
-                  messageId: "suggestExplicitAny",
-                  fix: createReplacerFix(typeAnnotation, "any")
-                } : null
-              ].filter((x) => !!x)
-            });
+          } else if (type !== AST_NODE_TYPES4.TSUnknownKeyword) {
+            let isAllowedError = false;
+            if (allowExplicitError && type === AST_NODE_TYPES4.TSTypeReference) {
+              const typeRef = typeAnnotation.typeAnnotation;
+              if (isIdentifier(typeRef.typeName)) {
+                isAllowedError = typeRef.typeName.name === "Error";
+              }
+            }
+            if (!isAllowedError) {
+              context.report({
+                messageId: allowExplicitError ? "narrowedAllowError" : "narrowed",
+                node: param,
+                suggest: [
+                  {
+                    messageId: "suggestExplicitUnknown",
+                    fix: createReplacerFix(typeAnnotation, "unknown")
+                  },
+                  allowExplicitAny ? {
+                    messageId: "suggestExplicitAny",
+                    fix: createReplacerFix(typeAnnotation, "any")
+                  } : null,
+                  allowExplicitError && !isAllowedError ? {
+                    messageId: "suggestExplicitError",
+                    fix: createReplacerFix(typeAnnotation, "Error")
+                  } : null
+                ].filter((x) => !!x)
+              });
+            }
           }
         } else {
           const hasRestParams = restParams.length > 0;
@@ -2309,7 +2372,7 @@ var noInternalRule = ruleCreator({
 });
 
 // src/rules/no-misused-observables.ts
-import { AST_NODE_TYPES as AST_NODE_TYPES6, ESLintUtils as ESLintUtils9 } from "@typescript-eslint/utils";
+import { AST_NODE_TYPES as AST_NODE_TYPES5, ESLintUtils as ESLintUtils9 } from "@typescript-eslint/utils";
 import { getFunctionHeadLocation, isFunction } from "@typescript-eslint/utils/ast-utils";
 import * as tsutils4 from "ts-api-utils";
 import ts5 from "typescript";
@@ -2675,55 +2738,55 @@ function getPropertyContextualType(checker, tsNode) {
 }
 function isPossiblyFunctionType(node) {
   switch (node.typeAnnotation.type) {
-    case AST_NODE_TYPES6.TSConditionalType:
-    case AST_NODE_TYPES6.TSConstructorType:
-    case AST_NODE_TYPES6.TSFunctionType:
-    case AST_NODE_TYPES6.TSImportType:
-    case AST_NODE_TYPES6.TSIndexedAccessType:
-    case AST_NODE_TYPES6.TSInferType:
-    case AST_NODE_TYPES6.TSIntersectionType:
-    case AST_NODE_TYPES6.TSQualifiedName:
-    case AST_NODE_TYPES6.TSThisType:
-    case AST_NODE_TYPES6.TSTypeOperator:
-    case AST_NODE_TYPES6.TSTypeQuery:
-    case AST_NODE_TYPES6.TSTypeReference:
-    case AST_NODE_TYPES6.TSUnionType:
+    case AST_NODE_TYPES5.TSConditionalType:
+    case AST_NODE_TYPES5.TSConstructorType:
+    case AST_NODE_TYPES5.TSFunctionType:
+    case AST_NODE_TYPES5.TSImportType:
+    case AST_NODE_TYPES5.TSIndexedAccessType:
+    case AST_NODE_TYPES5.TSInferType:
+    case AST_NODE_TYPES5.TSIntersectionType:
+    case AST_NODE_TYPES5.TSQualifiedName:
+    case AST_NODE_TYPES5.TSThisType:
+    case AST_NODE_TYPES5.TSTypeOperator:
+    case AST_NODE_TYPES5.TSTypeQuery:
+    case AST_NODE_TYPES5.TSTypeReference:
+    case AST_NODE_TYPES5.TSUnionType:
       return true;
-    case AST_NODE_TYPES6.TSTypeLiteral:
+    case AST_NODE_TYPES5.TSTypeLiteral:
       return node.typeAnnotation.members.some(
-        (member) => member.type === AST_NODE_TYPES6.TSCallSignatureDeclaration || member.type === AST_NODE_TYPES6.TSConstructSignatureDeclaration
+        (member) => member.type === AST_NODE_TYPES5.TSCallSignatureDeclaration || member.type === AST_NODE_TYPES5.TSConstructSignatureDeclaration
       );
-    case AST_NODE_TYPES6.TSAbstractKeyword:
-    case AST_NODE_TYPES6.TSAnyKeyword:
-    case AST_NODE_TYPES6.TSArrayType:
-    case AST_NODE_TYPES6.TSAsyncKeyword:
-    case AST_NODE_TYPES6.TSBigIntKeyword:
-    case AST_NODE_TYPES6.TSBooleanKeyword:
-    case AST_NODE_TYPES6.TSDeclareKeyword:
-    case AST_NODE_TYPES6.TSExportKeyword:
-    case AST_NODE_TYPES6.TSIntrinsicKeyword:
-    case AST_NODE_TYPES6.TSLiteralType:
-    case AST_NODE_TYPES6.TSMappedType:
-    case AST_NODE_TYPES6.TSNamedTupleMember:
-    case AST_NODE_TYPES6.TSNeverKeyword:
-    case AST_NODE_TYPES6.TSNullKeyword:
-    case AST_NODE_TYPES6.TSNumberKeyword:
-    case AST_NODE_TYPES6.TSObjectKeyword:
-    case AST_NODE_TYPES6.TSOptionalType:
-    case AST_NODE_TYPES6.TSPrivateKeyword:
-    case AST_NODE_TYPES6.TSProtectedKeyword:
-    case AST_NODE_TYPES6.TSPublicKeyword:
-    case AST_NODE_TYPES6.TSReadonlyKeyword:
-    case AST_NODE_TYPES6.TSRestType:
-    case AST_NODE_TYPES6.TSStaticKeyword:
-    case AST_NODE_TYPES6.TSStringKeyword:
-    case AST_NODE_TYPES6.TSSymbolKeyword:
-    case AST_NODE_TYPES6.TSTemplateLiteralType:
-    case AST_NODE_TYPES6.TSTupleType:
-    case AST_NODE_TYPES6.TSTypePredicate:
-    case AST_NODE_TYPES6.TSUndefinedKeyword:
-    case AST_NODE_TYPES6.TSUnknownKeyword:
-    case AST_NODE_TYPES6.TSVoidKeyword:
+    case AST_NODE_TYPES5.TSAbstractKeyword:
+    case AST_NODE_TYPES5.TSAnyKeyword:
+    case AST_NODE_TYPES5.TSArrayType:
+    case AST_NODE_TYPES5.TSAsyncKeyword:
+    case AST_NODE_TYPES5.TSBigIntKeyword:
+    case AST_NODE_TYPES5.TSBooleanKeyword:
+    case AST_NODE_TYPES5.TSDeclareKeyword:
+    case AST_NODE_TYPES5.TSExportKeyword:
+    case AST_NODE_TYPES5.TSIntrinsicKeyword:
+    case AST_NODE_TYPES5.TSLiteralType:
+    case AST_NODE_TYPES5.TSMappedType:
+    case AST_NODE_TYPES5.TSNamedTupleMember:
+    case AST_NODE_TYPES5.TSNeverKeyword:
+    case AST_NODE_TYPES5.TSNullKeyword:
+    case AST_NODE_TYPES5.TSNumberKeyword:
+    case AST_NODE_TYPES5.TSObjectKeyword:
+    case AST_NODE_TYPES5.TSOptionalType:
+    case AST_NODE_TYPES5.TSPrivateKeyword:
+    case AST_NODE_TYPES5.TSProtectedKeyword:
+    case AST_NODE_TYPES5.TSPublicKeyword:
+    case AST_NODE_TYPES5.TSReadonlyKeyword:
+    case AST_NODE_TYPES5.TSRestType:
+    case AST_NODE_TYPES5.TSStaticKeyword:
+    case AST_NODE_TYPES5.TSStringKeyword:
+    case AST_NODE_TYPES5.TSSymbolKeyword:
+    case AST_NODE_TYPES5.TSTemplateLiteralType:
+    case AST_NODE_TYPES5.TSTupleType:
+    case AST_NODE_TYPES5.TSTypePredicate:
+    case AST_NODE_TYPES5.TSUndefinedKeyword:
+    case AST_NODE_TYPES5.TSUnknownKeyword:
+    case AST_NODE_TYPES5.TSVoidKeyword:
       return false;
   }
 }
@@ -2850,7 +2913,7 @@ function isExpressionObserver(expressionStatement, couldBeType2) {
 }
 
 // src/rules/no-sharereplay.ts
-import { AST_NODE_TYPES as AST_NODE_TYPES7 } from "@typescript-eslint/utils";
+import { AST_NODE_TYPES as AST_NODE_TYPES6 } from "@typescript-eslint/utils";
 var defaultOptions10 = [];
 var noSharereplayRule = ruleCreator({
   defaultOptions: defaultOptions10,
@@ -2881,7 +2944,7 @@ var noSharereplayRule = ruleCreator({
       "CallExpression[callee.name='shareReplay']": (node) => {
         let report = true;
         if (allowConfig) {
-          report = node.arguments.length !== 1 || node.arguments[0].type !== AST_NODE_TYPES7.ObjectExpression;
+          report = node.arguments.length !== 1 || node.arguments[0].type !== AST_NODE_TYPES6.ObjectExpression;
         }
         if (report) {
           context.report({
@@ -3118,7 +3181,7 @@ var noSubscribeHandlersRule = ruleCreator({
 });
 
 // src/rules/no-subscribe-in-pipe.ts
-import { AST_NODE_TYPES as AST_NODE_TYPES8 } from "@typescript-eslint/utils";
+import { AST_NODE_TYPES as AST_NODE_TYPES7 } from "@typescript-eslint/utils";
 var noSubscribeInPipeRule = ruleCreator({
   defaultOptions: [],
   meta: {
@@ -3139,7 +3202,7 @@ var noSubscribeInPipeRule = ruleCreator({
     function isWithinPipe(node) {
       let parent = node.parent;
       while (parent) {
-        if (parent.type === AST_NODE_TYPES8.CallExpression && parent.callee.type === AST_NODE_TYPES8.MemberExpression && parent.callee.property.type === AST_NODE_TYPES8.Identifier && parent.callee.property.name === "pipe") {
+        if (parent.type === AST_NODE_TYPES7.CallExpression && parent.callee.type === AST_NODE_TYPES7.MemberExpression && parent.callee.property.type === AST_NODE_TYPES7.Identifier && parent.callee.property.name === "pipe") {
           return true;
         }
         parent = parent.parent;
@@ -4074,7 +4137,7 @@ var preferRootOperatorsRule = ruleCreator({
 });
 
 // src/rules/suffix-subjects.ts
-import { AST_NODE_TYPES as AST_NODE_TYPES9, ESLintUtils as ESLintUtils12 } from "@typescript-eslint/utils";
+import { AST_NODE_TYPES as AST_NODE_TYPES8, ESLintUtils as ESLintUtils12 } from "@typescript-eslint/utils";
 var defaultOptions18 = [];
 var suffixSubjectsRule = ruleCreator({
   defaultOptions: defaultOptions18,
@@ -4158,7 +4221,7 @@ var suffixSubjectsRule = ruleCreator({
         if (!found) {
           return;
         }
-        if (!validate.variables && found.type === AST_NODE_TYPES9.VariableDeclarator) {
+        if (!validate.variables && found.type === AST_NODE_TYPES8.VariableDeclarator) {
           return;
         }
         if (!validate.parameters) {
@@ -4225,7 +4288,7 @@ var suffixSubjectsRule = ruleCreator({
         if (!found) {
           return;
         }
-        if (!validate.variables && found.type === AST_NODE_TYPES9.VariableDeclarator) {
+        if (!validate.variables && found.type === AST_NODE_TYPES8.VariableDeclarator) {
           return;
         }
         if (!validate.parameters) {
@@ -4287,7 +4350,8 @@ var throwErrorRule = ruleCreator({
       requiresTypeChecking: true
     },
     messages: {
-      forbidden: "Passing non-Error values is forbidden."
+      forbidden: "Passing non-Error values is forbidden.",
+      suggestErrorConstructor: "Wrap string in Error constructor."
     },
     schema: [
       {
@@ -4298,7 +4362,8 @@ var throwErrorRule = ruleCreator({
         type: "object"
       }
     ],
-    type: "problem"
+    type: "problem",
+    hasSuggestions: true
   },
   name: "throw-error",
   create: (context) => {
@@ -4326,9 +4391,22 @@ var throwErrorRule = ruleCreator({
       if (couldBeType(type, /^Error$/)) {
         return;
       }
+      const isString = isTemplateLiteral(reportNode) || isLiteral(reportNode) && typeof reportNode.value === "string";
       context.report({
         messageId: "forbidden",
-        node: reportNode
+        node: reportNode,
+        ...isString && {
+          suggest: [
+            {
+              messageId: "suggestErrorConstructor",
+              fix: (fixer) => {
+                const sourceCode = context.sourceCode;
+                const nodeText = sourceCode.getText(reportNode);
+                return fixer.replaceText(reportNode, `new Error(${nodeText})`);
+              }
+            }
+          ]
+        }
       });
     }
     function checkThrowError(node) {

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "eslint-plugin-rxjs-x",
   "type": "commonjs",
-  "version": "0.9.0",
+  "version": "0.9.2",
   "packageManager": "yarn@4.12.0+sha512.f45ab632439a67f8bc759bf32ead036a1f413287b9042726b7cc4818b7b49e14e9423ba49b18f9e06ea4941c1ad062385b1d8760a8d5091a1a31e5f6219afca8",
   "description": "Modern ESLint plugin for RxJS",
   "author": "Jason Weinzierl <weinzierljason@gmail.com>",
@@ -84,7 +84,7 @@
     "@typescript/vfs": "^1.6.2",
     "@vitest/coverage-v8": "^3.2.4",
     "@vitest/eslint-plugin": "^1.4.0",
-    "bumpp": "^10.4.0",
+    "bumpp": "^10.4.1",
     "eslint": "^9.39.2",
     "eslint-config-flat-gitignore": "^2.1.0",
     "eslint-doc-generator": "^2.4.0",