eslint-plugin-rxjs-x 0.7.3 → 0.7.4

package/dist/index.js

@@ -1,6 +1,6 @@
 "use strict";Object.defineProperty(exports, "__esModule", {value: true}); function _interopRequireWildcard(obj) { if (obj && obj.__esModule) { return obj; } else { var newObj = {}; if (obj != null) { for (var key in obj) { if (Object.prototype.hasOwnProperty.call(obj, key)) { newObj[key] = obj[key]; } } } newObj.default = obj; return newObj; } } function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }// package.json
 var name = "eslint-plugin-rxjs-x";
-var version = "0.7.3";
+var version = "0.7.4";
 
 // src/configs/recommended.ts
 var createRecommendedConfig = (plugin2) => ({
@@ -284,6 +284,9 @@ function isPropertyDefinition(node) {
 function isUnaryExpression(node) {
   return node.type === _utils.AST_NODE_TYPES.UnaryExpression;
 }
+function isUnionType(node) {
+  return node.type === _utils.AST_NODE_TYPES.TSUnionType;
+}
 
 // src/etc/get-type-services.ts
 function getTypeServices(context) {
@@ -389,6 +392,41 @@ function findIsLastOperatorOrderValid(pipeCallExpression, operatorsRegExp, allow
   return { isOrderValid, operatorNode };
 }
 
+// src/constants.ts
+var defaultObservable = String.raw`[Aa]ction(s|s\$|\$)$`;
+var SOURCES_OBJECT_ACCEPTING_STATIC_OBSERVABLE_CREATORS = [
+  "combineLatest",
+  "forkJoin"
+];
+var DEFAULT_VALID_POST_COMPLETION_OPERATORS = [
+  "count",
+  "defaultIfEmpty",
+  "endWith",
+  "every",
+  "finalize",
+  "finally",
+  "isEmpty",
+  "last",
+  "max",
+  "min",
+  "publish",
+  "publishBehavior",
+  "publishLast",
+  "publishReplay",
+  "reduce",
+  "share",
+  "shareReplay",
+  "skipLast",
+  "takeLast",
+  "throwIfEmpty",
+  "toArray"
+];
+
+// src/utils/is-sources-object-accepting-static-observable-creator.ts
+function isSourcesObjectAcceptingStaticObservableCreator(expression) {
+  return isCallExpression(expression) && isIdentifier(expression.callee) && SOURCES_OBJECT_ACCEPTING_STATIC_OBSERVABLE_CREATORS.includes(expression.callee.name);
+}
+
 // src/utils/rule-creator.ts
 
 var REPO_URL = "https://github.com/JasonWeinzierl/eslint-plugin-rxjs-x";
@@ -717,7 +755,7 @@ var finnishRule = ruleCreator({
       "ObjectExpression > Property[computed=false] > Identifier": (node) => {
         if (validate.properties) {
           const parent = node.parent;
-          if (node === parent.key) {
+          if (node === parent.key && !isSourcesObjectAcceptingStaticObservableCreator(parent.parent.parent)) {
             checkNode(node);
           }
         }
@@ -1028,34 +1066,6 @@ var noCreateRule = ruleCreator({
 
 
 
-
-// src/constants.ts
-var defaultObservable = String.raw`[Aa]ction(s|s\$|\$)$`;
-var DEFAULT_VALID_POST_COMPLETION_OPERATORS = [
-  "count",
-  "defaultIfEmpty",
-  "endWith",
-  "every",
-  "finalize",
-  "finally",
-  "isEmpty",
-  "last",
-  "max",
-  "min",
-  "publish",
-  "publishBehavior",
-  "publishLast",
-  "publishReplay",
-  "reduce",
-  "share",
-  "shareReplay",
-  "skipLast",
-  "takeLast",
-  "throwIfEmpty",
-  "toArray"
-];
-
-// src/rules/no-cyclic-action.ts
 function isTypeReference2(type) {
   return Boolean(type.target);
 }
@@ -1180,21 +1190,25 @@ var noExplicitGenericsRule = ruleCreator({
       });
     }
     function checkBehaviorSubjects(node) {
+      var _a;
       const parent = node.parent;
       const {
         arguments: [value]
       } = parent;
-      if (isArrayExpression(value) || isObjectExpression(value)) {
+      const typeArgs = (_a = parent.typeArguments) == null ? void 0 : _a.params[0];
+      if (isArrayExpression(value) || isObjectExpression(value) || typeArgs && isUnionType(typeArgs)) {
         return;
       }
       report(node);
     }
     function checkNotifications(node) {
+      var _a;
       const parent = node.parent;
       const {
         arguments: [, value]
       } = parent;
-      if (isArrayExpression(value) || isObjectExpression(value)) {
+      const typeArgs = (_a = parent.typeArguments) == null ? void 0 : _a.params[0];
+      if (isArrayExpression(value) || isObjectExpression(value) || typeArgs && isUnionType(typeArgs)) {
         return;
       }
       report(node);
@@ -3911,7 +3925,7 @@ var suffixSubjectsRule = ruleCreator({
       "ObjectExpression > Property[computed=false] > Identifier": (node) => {
         if (validate.properties) {
           const parent = node.parent;
-          if (node === parent.key) {
+          if (node === parent.key && !isSourcesObjectAcceptingStaticObservableCreator(parent.parent.parent)) {
             checkNode(node);
           }
         }

package/dist/index.mjs

@@ -1,6 +1,6 @@
 // package.json
 var name = "eslint-plugin-rxjs-x";
-var version = "0.7.3";
+var version = "0.7.4";
 
 // src/configs/recommended.ts
 var createRecommendedConfig = (plugin2) => ({
@@ -284,6 +284,9 @@ function isPropertyDefinition(node) {
 function isUnaryExpression(node) {
   return node.type === AST_NODE_TYPES.UnaryExpression;
 }
+function isUnionType(node) {
+  return node.type === AST_NODE_TYPES.TSUnionType;
+}
 
 // src/etc/get-type-services.ts
 function getTypeServices(context) {
@@ -389,6 +392,41 @@ function findIsLastOperatorOrderValid(pipeCallExpression, operatorsRegExp, allow
   return { isOrderValid, operatorNode };
 }
 
+// src/constants.ts
+var defaultObservable = String.raw`[Aa]ction(s|s\$|\$)$`;
+var SOURCES_OBJECT_ACCEPTING_STATIC_OBSERVABLE_CREATORS = [
+  "combineLatest",
+  "forkJoin"
+];
+var DEFAULT_VALID_POST_COMPLETION_OPERATORS = [
+  "count",
+  "defaultIfEmpty",
+  "endWith",
+  "every",
+  "finalize",
+  "finally",
+  "isEmpty",
+  "last",
+  "max",
+  "min",
+  "publish",
+  "publishBehavior",
+  "publishLast",
+  "publishReplay",
+  "reduce",
+  "share",
+  "shareReplay",
+  "skipLast",
+  "takeLast",
+  "throwIfEmpty",
+  "toArray"
+];
+
+// src/utils/is-sources-object-accepting-static-observable-creator.ts
+function isSourcesObjectAcceptingStaticObservableCreator(expression) {
+  return isCallExpression(expression) && isIdentifier(expression.callee) && SOURCES_OBJECT_ACCEPTING_STATIC_OBSERVABLE_CREATORS.includes(expression.callee.name);
+}
+
 // src/utils/rule-creator.ts
 import { ESLintUtils as ESLintUtils2 } from "@typescript-eslint/utils";
 var REPO_URL = "https://github.com/JasonWeinzierl/eslint-plugin-rxjs-x";
@@ -717,7 +755,7 @@ var finnishRule = ruleCreator({
       "ObjectExpression > Property[computed=false] > Identifier": (node) => {
         if (validate.properties) {
           const parent = node.parent;
-          if (node === parent.key) {
+          if (node === parent.key && !isSourcesObjectAcceptingStaticObservableCreator(parent.parent.parent)) {
             checkNode(node);
           }
         }
@@ -1028,34 +1066,6 @@ var noCreateRule = ruleCreator({
 import { ESLintUtils as ESLintUtils4 } from "@typescript-eslint/utils";
 import { stripIndent as stripIndent3 } from "common-tags";
 import ts5 from "typescript";
-
-// src/constants.ts
-var defaultObservable = String.raw`[Aa]ction(s|s\$|\$)$`;
-var DEFAULT_VALID_POST_COMPLETION_OPERATORS = [
-  "count",
-  "defaultIfEmpty",
-  "endWith",
-  "every",
-  "finalize",
-  "finally",
-  "isEmpty",
-  "last",
-  "max",
-  "min",
-  "publish",
-  "publishBehavior",
-  "publishLast",
-  "publishReplay",
-  "reduce",
-  "share",
-  "shareReplay",
-  "skipLast",
-  "takeLast",
-  "throwIfEmpty",
-  "toArray"
-];
-
-// src/rules/no-cyclic-action.ts
 function isTypeReference2(type) {
   return Boolean(type.target);
 }
@@ -1180,21 +1190,25 @@ var noExplicitGenericsRule = ruleCreator({
       });
     }
     function checkBehaviorSubjects(node) {
+      var _a;
       const parent = node.parent;
       const {
         arguments: [value]
       } = parent;
-      if (isArrayExpression(value) || isObjectExpression(value)) {
+      const typeArgs = (_a = parent.typeArguments) == null ? void 0 : _a.params[0];
+      if (isArrayExpression(value) || isObjectExpression(value) || typeArgs && isUnionType(typeArgs)) {
         return;
       }
       report(node);
     }
     function checkNotifications(node) {
+      var _a;
       const parent = node.parent;
       const {
         arguments: [, value]
       } = parent;
-      if (isArrayExpression(value) || isObjectExpression(value)) {
+      const typeArgs = (_a = parent.typeArguments) == null ? void 0 : _a.params[0];
+      if (isArrayExpression(value) || isObjectExpression(value) || typeArgs && isUnionType(typeArgs)) {
         return;
       }
       report(node);
@@ -3911,7 +3925,7 @@ var suffixSubjectsRule = ruleCreator({
       "ObjectExpression > Property[computed=false] > Identifier": (node) => {
         if (validate.properties) {
           const parent = node.parent;
-          if (node === parent.key) {
+          if (node === parent.key && !isSourcesObjectAcceptingStaticObservableCreator(parent.parent.parent)) {
             checkNode(node);
           }
         }

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "eslint-plugin-rxjs-x",
   "type": "commonjs",
-  "version": "0.7.3",
+  "version": "0.7.4",
   "packageManager": "yarn@4.9.1+sha512.f95ce356460e05be48d66401c1ae64ef84d163dd689964962c6888a9810865e39097a5e9de748876c2e0bf89b232d583c33982773e9903ae7a76257270986538",
   "description": "ESLint v9+ plugin for RxJS",
   "author": "Jason Weinzierl <weinzierljason@gmail.com>",