eslint-plugin-rxjs-x 0.7.1 → 0.7.3
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/dist/index.d.mts +4 -1
- package/dist/index.d.ts +4 -1
- package/dist/index.js +216 -153
- package/dist/index.mjs +252 -189
- package/package.json +19 -20
- package/docs/rules/ban-observables.md +0 -42
- package/docs/rules/ban-operators.md +0 -44
- package/docs/rules/finnish.md +0 -91
- package/docs/rules/just.md +0 -20
- package/docs/rules/macro.md +0 -11
- package/docs/rules/no-async-subscribe.md +0 -54
- package/docs/rules/no-compat.md +0 -13
- package/docs/rules/no-connectable.md +0 -33
- package/docs/rules/no-create.md +0 -43
- package/docs/rules/no-cyclic-action.md +0 -88
- package/docs/rules/no-explicit-generics.md +0 -32
- package/docs/rules/no-exposed-subjects.md +0 -68
- package/docs/rules/no-finnish.md +0 -42
- package/docs/rules/no-floating-observables.md +0 -68
- package/docs/rules/no-ignored-default-value.md +0 -43
- package/docs/rules/no-ignored-error.md +0 -53
- package/docs/rules/no-ignored-notifier.md +0 -47
- package/docs/rules/no-ignored-replay-buffer.md +0 -47
- package/docs/rules/no-ignored-subscribe.md +0 -46
- package/docs/rules/no-ignored-subscription.md +0 -46
- package/docs/rules/no-ignored-takewhile-value.md +0 -35
- package/docs/rules/no-implicit-any-catch.md +0 -109
- package/docs/rules/no-index.md +0 -34
- package/docs/rules/no-internal.md +0 -38
- package/docs/rules/no-misused-observables.md +0 -101
- package/docs/rules/no-nested-subscribe.md +0 -46
- package/docs/rules/no-redundant-notify.md +0 -50
- package/docs/rules/no-sharereplay.md +0 -49
- package/docs/rules/no-subclass.md +0 -23
- package/docs/rules/no-subject-unsubscribe.md +0 -63
- package/docs/rules/no-subject-value.md +0 -19
- package/docs/rules/no-subscribe-handlers.md +0 -53
- package/docs/rules/no-subscribe-in-pipe.md +0 -55
- package/docs/rules/no-tap.md +0 -7
- package/docs/rules/no-topromise.md +0 -37
- package/docs/rules/no-unbound-methods.md +0 -61
- package/docs/rules/no-unsafe-catch.md +0 -74
- package/docs/rules/no-unsafe-first.md +0 -40
- package/docs/rules/no-unsafe-subject-next.md +0 -46
- package/docs/rules/no-unsafe-switchmap.md +0 -64
- package/docs/rules/no-unsafe-takeuntil.md +0 -72
- package/docs/rules/prefer-observer.md +0 -66
- package/docs/rules/prefer-root-operators.md +0 -45
- package/docs/rules/suffix-subjects.md +0 -81
- package/docs/rules/throw-error.md +0 -53
package/dist/index.mjs
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
// package.json
|
|
2
2
|
var name = "eslint-plugin-rxjs-x";
|
|
3
|
-
var version = "0.7.
|
|
3
|
+
var version = "0.7.3";
|
|
4
4
|
|
|
5
5
|
// src/configs/recommended.ts
|
|
6
6
|
var createRecommendedConfig = (plugin2) => ({
|
|
@@ -74,11 +74,10 @@ var createStrictConfig = (plugin2) => ({
|
|
|
74
74
|
});
|
|
75
75
|
|
|
76
76
|
// src/rules/ban-observables.ts
|
|
77
|
-
import { AST_NODE_TYPES } from "@typescript-eslint/utils";
|
|
77
|
+
import { AST_NODE_TYPES as AST_NODE_TYPES3 } from "@typescript-eslint/utils";
|
|
78
78
|
import { stripIndent } from "common-tags";
|
|
79
79
|
|
|
80
|
-
// src/utils.ts
|
|
81
|
-
import { ESLintUtils } from "@typescript-eslint/utils";
|
|
80
|
+
// src/utils/create-regexp-for-words.ts
|
|
82
81
|
function createRegExpForWords(config) {
|
|
83
82
|
if (!(config == null ? void 0 : config.length)) {
|
|
84
83
|
return void 0;
|
|
@@ -91,81 +90,11 @@ function createRegExpForWords(config) {
|
|
|
91
90
|
const joined = words.map((word) => String.raw`(\b|_)${word}(\b|_)`).join("|");
|
|
92
91
|
return new RegExp(`(${joined})`, flags);
|
|
93
92
|
}
|
|
93
|
+
|
|
94
|
+
// src/utils/escape-regexp.ts
|
|
94
95
|
function escapeRegExp(text) {
|
|
95
96
|
return text.replace(/[-/\\^$*+?.()|[\]{}]/g, "\\$&");
|
|
96
97
|
}
|
|
97
|
-
var REPO_URL = "https://github.com/JasonWeinzierl/eslint-plugin-rxjs-x";
|
|
98
|
-
var ruleCreator = ESLintUtils.RuleCreator(
|
|
99
|
-
(name2) => `${REPO_URL}/blob/v${version}/docs/rules/${name2}.md`
|
|
100
|
-
);
|
|
101
|
-
|
|
102
|
-
// src/rules/ban-observables.ts
|
|
103
|
-
var defaultOptions = [];
|
|
104
|
-
var banObservablesRule = ruleCreator({
|
|
105
|
-
defaultOptions,
|
|
106
|
-
meta: {
|
|
107
|
-
docs: {
|
|
108
|
-
description: "Disallow banned observable creators."
|
|
109
|
-
},
|
|
110
|
-
messages: {
|
|
111
|
-
forbidden: "RxJS observable is banned: {{name}}{{explanation}}."
|
|
112
|
-
},
|
|
113
|
-
schema: [
|
|
114
|
-
{
|
|
115
|
-
type: "object",
|
|
116
|
-
description: stripIndent`
|
|
117
|
-
An object containing keys that are names of observable factory functions
|
|
118
|
-
and values that are either booleans or strings containing the explanation for the ban.`
|
|
119
|
-
}
|
|
120
|
-
],
|
|
121
|
-
type: "problem"
|
|
122
|
-
},
|
|
123
|
-
name: "ban-observables",
|
|
124
|
-
create: (context) => {
|
|
125
|
-
const bans = [];
|
|
126
|
-
const [config] = context.options;
|
|
127
|
-
if (!config) {
|
|
128
|
-
return {};
|
|
129
|
-
}
|
|
130
|
-
Object.entries(config).forEach(([key, value]) => {
|
|
131
|
-
if (value !== false) {
|
|
132
|
-
bans.push({
|
|
133
|
-
explanation: typeof value === "string" ? value : "",
|
|
134
|
-
regExp: new RegExp(`^${key}$`)
|
|
135
|
-
});
|
|
136
|
-
}
|
|
137
|
-
});
|
|
138
|
-
function getFailure(name2) {
|
|
139
|
-
for (let b = 0, length = bans.length; b < length; ++b) {
|
|
140
|
-
const ban = bans[b];
|
|
141
|
-
if (ban.regExp.test(name2)) {
|
|
142
|
-
const explanation = ban.explanation ? `: ${ban.explanation}` : "";
|
|
143
|
-
return {
|
|
144
|
-
messageId: "forbidden",
|
|
145
|
-
data: { name: name2, explanation }
|
|
146
|
-
};
|
|
147
|
-
}
|
|
148
|
-
}
|
|
149
|
-
return void 0;
|
|
150
|
-
}
|
|
151
|
-
return {
|
|
152
|
-
"ImportDeclaration[source.value='rxjs'] > ImportSpecifier": (node) => {
|
|
153
|
-
const identifier = node.imported;
|
|
154
|
-
const name2 = identifier.type === AST_NODE_TYPES.Identifier ? identifier.name : identifier.value;
|
|
155
|
-
const failure = getFailure(name2);
|
|
156
|
-
if (failure) {
|
|
157
|
-
context.report({
|
|
158
|
-
...failure,
|
|
159
|
-
node: identifier
|
|
160
|
-
});
|
|
161
|
-
}
|
|
162
|
-
}
|
|
163
|
-
};
|
|
164
|
-
}
|
|
165
|
-
});
|
|
166
|
-
|
|
167
|
-
// src/rules/ban-operators.ts
|
|
168
|
-
import { stripIndent as stripIndent2 } from "common-tags";
|
|
169
98
|
|
|
170
99
|
// src/etc/could-be-function.ts
|
|
171
100
|
import ts2 from "typescript";
|
|
@@ -281,84 +210,84 @@ function getLoc(node) {
|
|
|
281
210
|
}
|
|
282
211
|
|
|
283
212
|
// src/etc/get-type-services.ts
|
|
284
|
-
import { ESLintUtils
|
|
213
|
+
import { ESLintUtils } from "@typescript-eslint/utils";
|
|
285
214
|
import ts4 from "typescript";
|
|
286
215
|
|
|
287
216
|
// src/etc/is.ts
|
|
288
|
-
import { AST_NODE_TYPES
|
|
217
|
+
import { AST_NODE_TYPES } from "@typescript-eslint/utils";
|
|
289
218
|
function hasTypeAnnotation(node) {
|
|
290
219
|
return "typeAnnotation" in node && !!node.typeAnnotation;
|
|
291
220
|
}
|
|
292
221
|
function isArrayExpression(node) {
|
|
293
|
-
return node.type ===
|
|
222
|
+
return node.type === AST_NODE_TYPES.ArrayExpression;
|
|
294
223
|
}
|
|
295
224
|
function isArrayPattern(node) {
|
|
296
|
-
return node.type ===
|
|
225
|
+
return node.type === AST_NODE_TYPES.ArrayPattern;
|
|
297
226
|
}
|
|
298
227
|
function isArrowFunctionExpression(node) {
|
|
299
|
-
return node.type ===
|
|
228
|
+
return node.type === AST_NODE_TYPES.ArrowFunctionExpression;
|
|
300
229
|
}
|
|
301
230
|
function isBlockStatement(node) {
|
|
302
|
-
return node.type ===
|
|
231
|
+
return node.type === AST_NODE_TYPES.BlockStatement;
|
|
303
232
|
}
|
|
304
233
|
function isCallExpression(node) {
|
|
305
|
-
return node.type ===
|
|
234
|
+
return node.type === AST_NODE_TYPES.CallExpression;
|
|
306
235
|
}
|
|
307
236
|
function isChainExpression(node) {
|
|
308
|
-
return node.type ===
|
|
237
|
+
return node.type === AST_NODE_TYPES.ChainExpression;
|
|
309
238
|
}
|
|
310
239
|
function isFunctionDeclaration(node) {
|
|
311
|
-
return node.type ===
|
|
240
|
+
return node.type === AST_NODE_TYPES.FunctionDeclaration;
|
|
312
241
|
}
|
|
313
242
|
function isFunctionExpression(node) {
|
|
314
|
-
return node.type ===
|
|
243
|
+
return node.type === AST_NODE_TYPES.FunctionExpression;
|
|
315
244
|
}
|
|
316
245
|
function isIdentifier(node) {
|
|
317
|
-
return node.type ===
|
|
246
|
+
return node.type === AST_NODE_TYPES.Identifier;
|
|
318
247
|
}
|
|
319
248
|
function isImportDeclaration(node) {
|
|
320
|
-
return node.type ===
|
|
249
|
+
return node.type === AST_NODE_TYPES.ImportDeclaration;
|
|
321
250
|
}
|
|
322
251
|
function isImportNamespaceSpecifier(node) {
|
|
323
|
-
return node.type ===
|
|
252
|
+
return node.type === AST_NODE_TYPES.ImportNamespaceSpecifier;
|
|
324
253
|
}
|
|
325
254
|
function isImportSpecifier(node) {
|
|
326
|
-
return node.type ===
|
|
255
|
+
return node.type === AST_NODE_TYPES.ImportSpecifier;
|
|
327
256
|
}
|
|
328
257
|
function isJSXExpressionContainer(node) {
|
|
329
|
-
return node.type ===
|
|
258
|
+
return node.type === AST_NODE_TYPES.JSXExpressionContainer;
|
|
330
259
|
}
|
|
331
260
|
function isLiteral(node) {
|
|
332
|
-
return node.type ===
|
|
261
|
+
return node.type === AST_NODE_TYPES.Literal;
|
|
333
262
|
}
|
|
334
263
|
function isMemberExpression(node) {
|
|
335
|
-
return node.type ===
|
|
264
|
+
return node.type === AST_NODE_TYPES.MemberExpression;
|
|
336
265
|
}
|
|
337
266
|
function isMethodDefinition(node) {
|
|
338
|
-
return node.type ===
|
|
267
|
+
return node.type === AST_NODE_TYPES.MethodDefinition;
|
|
339
268
|
}
|
|
340
269
|
function isObjectExpression(node) {
|
|
341
|
-
return node.type ===
|
|
270
|
+
return node.type === AST_NODE_TYPES.ObjectExpression;
|
|
342
271
|
}
|
|
343
272
|
function isObjectPattern(node) {
|
|
344
|
-
return node.type ===
|
|
273
|
+
return node.type === AST_NODE_TYPES.ObjectPattern;
|
|
345
274
|
}
|
|
346
275
|
function isProgram(node) {
|
|
347
|
-
return node.type ===
|
|
276
|
+
return node.type === AST_NODE_TYPES.Program;
|
|
348
277
|
}
|
|
349
278
|
function isProperty(node) {
|
|
350
|
-
return node.type ===
|
|
279
|
+
return node.type === AST_NODE_TYPES.Property;
|
|
351
280
|
}
|
|
352
281
|
function isPropertyDefinition(node) {
|
|
353
|
-
return node.type ===
|
|
282
|
+
return node.type === AST_NODE_TYPES.PropertyDefinition;
|
|
354
283
|
}
|
|
355
284
|
function isUnaryExpression(node) {
|
|
356
|
-
return node.type ===
|
|
285
|
+
return node.type === AST_NODE_TYPES.UnaryExpression;
|
|
357
286
|
}
|
|
358
287
|
|
|
359
288
|
// src/etc/get-type-services.ts
|
|
360
289
|
function getTypeServices(context) {
|
|
361
|
-
const services =
|
|
290
|
+
const services = ESLintUtils.getParserServices(context);
|
|
362
291
|
const { esTreeNodeToTSNodeMap, program, getTypeAtLocation } = services;
|
|
363
292
|
const typeChecker = program.getTypeChecker();
|
|
364
293
|
const couldBeType2 = (node, name2, qualified) => {
|
|
@@ -370,11 +299,19 @@ function getTypeServices(context) {
|
|
|
370
299
|
);
|
|
371
300
|
};
|
|
372
301
|
const couldReturnType = (node, name2, qualified) => {
|
|
373
|
-
var _a;
|
|
374
302
|
let tsTypeNode;
|
|
375
303
|
const tsNode = esTreeNodeToTSNodeMap.get(node);
|
|
376
304
|
if (ts4.isArrowFunction(tsNode) || ts4.isFunctionDeclaration(tsNode) || ts4.isMethodDeclaration(tsNode) || ts4.isFunctionExpression(tsNode)) {
|
|
377
|
-
|
|
305
|
+
if (tsNode.type) {
|
|
306
|
+
tsTypeNode = tsNode.type;
|
|
307
|
+
} else if (tsNode.body && ts4.isBlock(tsNode.body)) {
|
|
308
|
+
const returnStatement = tsNode.body.statements.find(ts4.isReturnStatement);
|
|
309
|
+
if (returnStatement == null ? void 0 : returnStatement.expression) {
|
|
310
|
+
tsTypeNode = returnStatement.expression;
|
|
311
|
+
}
|
|
312
|
+
} else {
|
|
313
|
+
tsTypeNode = tsNode.body;
|
|
314
|
+
}
|
|
378
315
|
} else if (ts4.isCallSignatureDeclaration(tsNode) || ts4.isMethodSignature(tsNode)) {
|
|
379
316
|
tsTypeNode = tsNode.type;
|
|
380
317
|
} else if (ts4.isPropertySignature(tsNode)) {
|
|
@@ -407,18 +344,125 @@ function getTypeServices(context) {
|
|
|
407
344
|
|
|
408
345
|
// src/etc/is-import.ts
|
|
409
346
|
import { DefinitionType } from "@typescript-eslint/scope-manager";
|
|
410
|
-
import { AST_NODE_TYPES as
|
|
347
|
+
import { AST_NODE_TYPES as AST_NODE_TYPES2 } from "@typescript-eslint/utils";
|
|
411
348
|
function isImport(scope, name2, source) {
|
|
412
349
|
const variable = scope.variables.find((variable2) => variable2.name === name2);
|
|
413
350
|
if (variable) {
|
|
414
351
|
return variable.defs.some(
|
|
415
|
-
(def) => def.type === DefinitionType.ImportBinding && def.parent.type ===
|
|
352
|
+
(def) => def.type === DefinitionType.ImportBinding && def.parent.type === AST_NODE_TYPES2.ImportDeclaration && (typeof source === "string" ? def.parent.source.value === source : source.test(def.parent.source.value))
|
|
416
353
|
);
|
|
417
354
|
}
|
|
418
355
|
return scope.upper ? isImport(scope.upper, name2, source) : false;
|
|
419
356
|
}
|
|
420
357
|
|
|
358
|
+
// src/utils/find-is-last-operator-order-valid.ts
|
|
359
|
+
function findIsLastOperatorOrderValid(pipeCallExpression, operatorsRegExp, allow) {
|
|
360
|
+
let isOrderValid = true;
|
|
361
|
+
let operatorNode;
|
|
362
|
+
for (let i = pipeCallExpression.arguments.length - 1; i >= 0; i--) {
|
|
363
|
+
const arg = pipeCallExpression.arguments[i];
|
|
364
|
+
if (operatorNode) {
|
|
365
|
+
break;
|
|
366
|
+
}
|
|
367
|
+
if (!isCallExpression(arg)) {
|
|
368
|
+
isOrderValid = false;
|
|
369
|
+
continue;
|
|
370
|
+
}
|
|
371
|
+
let operatorName;
|
|
372
|
+
if (isIdentifier(arg.callee)) {
|
|
373
|
+
operatorName = arg.callee.name;
|
|
374
|
+
} else if (isMemberExpression(arg.callee) && isIdentifier(arg.callee.property)) {
|
|
375
|
+
operatorName = arg.callee.property.name;
|
|
376
|
+
} else {
|
|
377
|
+
isOrderValid = false;
|
|
378
|
+
continue;
|
|
379
|
+
}
|
|
380
|
+
if (operatorsRegExp.test(operatorName)) {
|
|
381
|
+
operatorNode = arg.callee;
|
|
382
|
+
break;
|
|
383
|
+
}
|
|
384
|
+
if (!allow.includes(operatorName)) {
|
|
385
|
+
isOrderValid = false;
|
|
386
|
+
continue;
|
|
387
|
+
}
|
|
388
|
+
}
|
|
389
|
+
return { isOrderValid, operatorNode };
|
|
390
|
+
}
|
|
391
|
+
|
|
392
|
+
// src/utils/rule-creator.ts
|
|
393
|
+
import { ESLintUtils as ESLintUtils2 } from "@typescript-eslint/utils";
|
|
394
|
+
var REPO_URL = "https://github.com/JasonWeinzierl/eslint-plugin-rxjs-x";
|
|
395
|
+
var ruleCreator = ESLintUtils2.RuleCreator(
|
|
396
|
+
(name2) => `${REPO_URL}/blob/v${version}/docs/rules/${name2}.md`
|
|
397
|
+
);
|
|
398
|
+
|
|
399
|
+
// src/rules/ban-observables.ts
|
|
400
|
+
var defaultOptions = [];
|
|
401
|
+
var banObservablesRule = ruleCreator({
|
|
402
|
+
defaultOptions,
|
|
403
|
+
meta: {
|
|
404
|
+
docs: {
|
|
405
|
+
description: "Disallow banned observable creators."
|
|
406
|
+
},
|
|
407
|
+
messages: {
|
|
408
|
+
forbidden: "RxJS observable is banned: {{name}}{{explanation}}."
|
|
409
|
+
},
|
|
410
|
+
schema: [
|
|
411
|
+
{
|
|
412
|
+
type: "object",
|
|
413
|
+
description: stripIndent`
|
|
414
|
+
An object containing keys that are names of observable factory functions
|
|
415
|
+
and values that are either booleans or strings containing the explanation for the ban.`
|
|
416
|
+
}
|
|
417
|
+
],
|
|
418
|
+
type: "problem"
|
|
419
|
+
},
|
|
420
|
+
name: "ban-observables",
|
|
421
|
+
create: (context) => {
|
|
422
|
+
const bans = [];
|
|
423
|
+
const [config] = context.options;
|
|
424
|
+
if (!config) {
|
|
425
|
+
return {};
|
|
426
|
+
}
|
|
427
|
+
Object.entries(config).forEach(([key, value]) => {
|
|
428
|
+
if (value !== false) {
|
|
429
|
+
bans.push({
|
|
430
|
+
explanation: typeof value === "string" ? value : "",
|
|
431
|
+
regExp: new RegExp(`^${key}$`)
|
|
432
|
+
});
|
|
433
|
+
}
|
|
434
|
+
});
|
|
435
|
+
function getFailure(name2) {
|
|
436
|
+
for (let b = 0, length = bans.length; b < length; ++b) {
|
|
437
|
+
const ban = bans[b];
|
|
438
|
+
if (ban.regExp.test(name2)) {
|
|
439
|
+
const explanation = ban.explanation ? `: ${ban.explanation}` : "";
|
|
440
|
+
return {
|
|
441
|
+
messageId: "forbidden",
|
|
442
|
+
data: { name: name2, explanation }
|
|
443
|
+
};
|
|
444
|
+
}
|
|
445
|
+
}
|
|
446
|
+
return void 0;
|
|
447
|
+
}
|
|
448
|
+
return {
|
|
449
|
+
"ImportDeclaration[source.value='rxjs'] > ImportSpecifier": (node) => {
|
|
450
|
+
const identifier = node.imported;
|
|
451
|
+
const name2 = identifier.type === AST_NODE_TYPES3.Identifier ? identifier.name : identifier.value;
|
|
452
|
+
const failure = getFailure(name2);
|
|
453
|
+
if (failure) {
|
|
454
|
+
context.report({
|
|
455
|
+
...failure,
|
|
456
|
+
node: identifier
|
|
457
|
+
});
|
|
458
|
+
}
|
|
459
|
+
}
|
|
460
|
+
};
|
|
461
|
+
}
|
|
462
|
+
});
|
|
463
|
+
|
|
421
464
|
// src/rules/ban-operators.ts
|
|
465
|
+
import { stripIndent as stripIndent2 } from "common-tags";
|
|
422
466
|
var defaultOptions2 = [];
|
|
423
467
|
var banOperatorsRule = ruleCreator({
|
|
424
468
|
defaultOptions: defaultOptions2,
|
|
@@ -987,6 +1031,29 @@ import ts5 from "typescript";
|
|
|
987
1031
|
|
|
988
1032
|
// src/constants.ts
|
|
989
1033
|
var defaultObservable = String.raw`[Aa]ction(s|s\$|\$)$`;
|
|
1034
|
+
var DEFAULT_VALID_POST_COMPLETION_OPERATORS = [
|
|
1035
|
+
"count",
|
|
1036
|
+
"defaultIfEmpty",
|
|
1037
|
+
"endWith",
|
|
1038
|
+
"every",
|
|
1039
|
+
"finalize",
|
|
1040
|
+
"finally",
|
|
1041
|
+
"isEmpty",
|
|
1042
|
+
"last",
|
|
1043
|
+
"max",
|
|
1044
|
+
"min",
|
|
1045
|
+
"publish",
|
|
1046
|
+
"publishBehavior",
|
|
1047
|
+
"publishLast",
|
|
1048
|
+
"publishReplay",
|
|
1049
|
+
"reduce",
|
|
1050
|
+
"share",
|
|
1051
|
+
"shareReplay",
|
|
1052
|
+
"skipLast",
|
|
1053
|
+
"takeLast",
|
|
1054
|
+
"throwIfEmpty",
|
|
1055
|
+
"toArray"
|
|
1056
|
+
];
|
|
990
1057
|
|
|
991
1058
|
// src/rules/no-cyclic-action.ts
|
|
992
1059
|
function isTypeReference2(type) {
|
|
@@ -1757,8 +1824,10 @@ var noIgnoredSubscribeRule = ruleCreator({
|
|
|
1757
1824
|
});
|
|
1758
1825
|
|
|
1759
1826
|
// src/rules/no-ignored-subscription.ts
|
|
1827
|
+
import { stripIndent as stripIndent4 } from "common-tags";
|
|
1828
|
+
var defaultOptions7 = [];
|
|
1760
1829
|
var noIgnoredSubscriptionRule = ruleCreator({
|
|
1761
|
-
defaultOptions:
|
|
1830
|
+
defaultOptions: defaultOptions7,
|
|
1762
1831
|
meta: {
|
|
1763
1832
|
docs: {
|
|
1764
1833
|
description: "Disallow ignoring the subscription returned by `subscribe`.",
|
|
@@ -1767,12 +1836,44 @@ var noIgnoredSubscriptionRule = ruleCreator({
|
|
|
1767
1836
|
messages: {
|
|
1768
1837
|
forbidden: "Ignoring returned subscriptions is forbidden."
|
|
1769
1838
|
},
|
|
1770
|
-
schema: [
|
|
1839
|
+
schema: [
|
|
1840
|
+
{
|
|
1841
|
+
properties: {
|
|
1842
|
+
completers: { type: "array", items: { type: "string" }, description: "An array of operator names that will complete the observable and silence this rule.", default: ["takeUntil", "takeWhile", "take", "first", "last", "takeUntilDestroyed"] },
|
|
1843
|
+
postCompleters: { type: "array", items: { type: "string" }, description: "An array of operator names that are allowed to follow the completion operators.", default: DEFAULT_VALID_POST_COMPLETION_OPERATORS }
|
|
1844
|
+
},
|
|
1845
|
+
type: "object",
|
|
1846
|
+
description: stripIndent4`
|
|
1847
|
+
An object with optional \`completers\` and \`postCompleters\` properties.
|
|
1848
|
+
The \`completers\` property is an array containing the names of operators that will complete the observable and silence this rule.
|
|
1849
|
+
The \`postCompleters\` property is an array containing the names of the operators that are allowed to follow the completion operators.
|
|
1850
|
+
`
|
|
1851
|
+
}
|
|
1852
|
+
],
|
|
1771
1853
|
type: "problem"
|
|
1772
1854
|
},
|
|
1773
1855
|
name: "no-ignored-subscription",
|
|
1774
1856
|
create: (context) => {
|
|
1857
|
+
const [config = {}] = context.options;
|
|
1858
|
+
const {
|
|
1859
|
+
completers = ["takeUntil", "takeWhile", "take", "first", "last", "takeUntilDestroyed"],
|
|
1860
|
+
postCompleters = DEFAULT_VALID_POST_COMPLETION_OPERATORS
|
|
1861
|
+
} = config;
|
|
1862
|
+
const checkedOperatorsRegExp = new RegExp(
|
|
1863
|
+
`^(${completers.join("|")})$`
|
|
1864
|
+
);
|
|
1775
1865
|
const { couldBeObservable, couldBeType: couldBeType2 } = getTypeServices(context);
|
|
1866
|
+
function hasAllowedOperator(node) {
|
|
1867
|
+
if (isCallExpression(node) && isMemberExpression(node.callee) && isIdentifier(node.callee.property) && node.callee.property.name === "pipe") {
|
|
1868
|
+
const { isOrderValid, operatorNode } = findIsLastOperatorOrderValid(
|
|
1869
|
+
node,
|
|
1870
|
+
checkedOperatorsRegExp,
|
|
1871
|
+
postCompleters
|
|
1872
|
+
);
|
|
1873
|
+
return isOrderValid && !!operatorNode;
|
|
1874
|
+
}
|
|
1875
|
+
return false;
|
|
1876
|
+
}
|
|
1776
1877
|
return {
|
|
1777
1878
|
"ExpressionStatement > CallExpression > MemberExpression[property.name='subscribe']": (node) => {
|
|
1778
1879
|
if (couldBeObservable(node.object)) {
|
|
@@ -1780,6 +1881,9 @@ var noIgnoredSubscriptionRule = ruleCreator({
|
|
|
1780
1881
|
if (callExpression.arguments.length === 1 && couldBeType2(callExpression.arguments[0], "Subscriber")) {
|
|
1781
1882
|
return;
|
|
1782
1883
|
}
|
|
1884
|
+
if (hasAllowedOperator(node.object)) {
|
|
1885
|
+
return;
|
|
1886
|
+
}
|
|
1783
1887
|
context.report({
|
|
1784
1888
|
messageId: "forbidden",
|
|
1785
1889
|
node: node.property
|
|
@@ -1854,9 +1958,9 @@ function isParenthesised(sourceCode, node) {
|
|
|
1854
1958
|
const after = sourceCode.getTokenAfter(node);
|
|
1855
1959
|
return before && after && before.value === "(" && before.range[1] <= node.range[0] && after.value === ")" && after.range[0] >= node.range[1];
|
|
1856
1960
|
}
|
|
1857
|
-
var
|
|
1961
|
+
var defaultOptions8 = [];
|
|
1858
1962
|
var noImplicitAnyCatchRule = ruleCreator({
|
|
1859
|
-
defaultOptions:
|
|
1963
|
+
defaultOptions: defaultOptions8,
|
|
1860
1964
|
meta: {
|
|
1861
1965
|
docs: {
|
|
1862
1966
|
description: "Disallow implicit `any` error parameters in `catchError` operators.",
|
|
@@ -2130,9 +2234,9 @@ function parseChecksVoidReturn(checksVoidReturn) {
|
|
|
2130
2234
|
};
|
|
2131
2235
|
}
|
|
2132
2236
|
}
|
|
2133
|
-
var
|
|
2237
|
+
var defaultOptions9 = [];
|
|
2134
2238
|
var noMisusedObservablesRule = ruleCreator({
|
|
2135
|
-
defaultOptions:
|
|
2239
|
+
defaultOptions: defaultOptions9,
|
|
2136
2240
|
meta: {
|
|
2137
2241
|
docs: {
|
|
2138
2242
|
description: "Disallow Observables in places not designed to handle them.",
|
|
@@ -2620,9 +2724,9 @@ function isExpressionObserver(expressionStatement, couldBeType2) {
|
|
|
2620
2724
|
|
|
2621
2725
|
// src/rules/no-sharereplay.ts
|
|
2622
2726
|
import { AST_NODE_TYPES as AST_NODE_TYPES7 } from "@typescript-eslint/utils";
|
|
2623
|
-
var
|
|
2727
|
+
var defaultOptions10 = [];
|
|
2624
2728
|
var noSharereplayRule = ruleCreator({
|
|
2625
|
-
defaultOptions:
|
|
2729
|
+
defaultOptions: defaultOptions10,
|
|
2626
2730
|
meta: {
|
|
2627
2731
|
docs: {
|
|
2628
2732
|
description: "Disallow unsafe `shareReplay` usage.",
|
|
@@ -3061,10 +3165,10 @@ var noUnboundMethodsRule = ruleCreator({
|
|
|
3061
3165
|
});
|
|
3062
3166
|
|
|
3063
3167
|
// src/rules/no-unsafe-catch.ts
|
|
3064
|
-
import { stripIndent as
|
|
3065
|
-
var
|
|
3168
|
+
import { stripIndent as stripIndent5 } from "common-tags";
|
|
3169
|
+
var defaultOptions11 = [];
|
|
3066
3170
|
var noUnsafeCatchRule = ruleCreator({
|
|
3067
|
-
defaultOptions:
|
|
3171
|
+
defaultOptions: defaultOptions11,
|
|
3068
3172
|
meta: {
|
|
3069
3173
|
docs: {
|
|
3070
3174
|
description: "Disallow unsafe `catchError` usage in effects and epics.",
|
|
@@ -3079,7 +3183,7 @@ var noUnsafeCatchRule = ruleCreator({
|
|
|
3079
3183
|
observable: { type: "string", description: "A RegExp that matches an effect or epic's actions observable.", default: defaultObservable }
|
|
3080
3184
|
},
|
|
3081
3185
|
type: "object",
|
|
3082
|
-
description:
|
|
3186
|
+
description: stripIndent5`
|
|
3083
3187
|
An optional object with an optional \`observable\` property.
|
|
3084
3188
|
The property can be specified as a regular expression string and is used to identify the action observables from which effects and epics are composed.`
|
|
3085
3189
|
}
|
|
@@ -3122,10 +3226,10 @@ var noUnsafeCatchRule = ruleCreator({
|
|
|
3122
3226
|
});
|
|
3123
3227
|
|
|
3124
3228
|
// src/rules/no-unsafe-first.ts
|
|
3125
|
-
import { stripIndent as
|
|
3126
|
-
var
|
|
3229
|
+
import { stripIndent as stripIndent6 } from "common-tags";
|
|
3230
|
+
var defaultOptions12 = [];
|
|
3127
3231
|
var noUnsafeFirstRule = ruleCreator({
|
|
3128
|
-
defaultOptions:
|
|
3232
|
+
defaultOptions: defaultOptions12,
|
|
3129
3233
|
meta: {
|
|
3130
3234
|
docs: {
|
|
3131
3235
|
description: "Disallow unsafe `first`/`take` usage in effects and epics.",
|
|
@@ -3140,7 +3244,7 @@ var noUnsafeFirstRule = ruleCreator({
|
|
|
3140
3244
|
observable: { type: "string", description: "A RegExp that matches an effect or epic's actions observable.", default: defaultObservable }
|
|
3141
3245
|
},
|
|
3142
3246
|
type: "object",
|
|
3143
|
-
description:
|
|
3247
|
+
description: stripIndent6`
|
|
3144
3248
|
An optional object with an optional \`observable\` property.
|
|
3145
3249
|
The property can be specified as a regular expression string and is used to identify the action observables from which effects and epics are composed.`
|
|
3146
3250
|
}
|
|
@@ -3245,11 +3349,11 @@ var noUnsafeSubjectNext = ruleCreator({
|
|
|
3245
3349
|
});
|
|
3246
3350
|
|
|
3247
3351
|
// src/rules/no-unsafe-switchmap.ts
|
|
3248
|
-
import { stripIndent as
|
|
3352
|
+
import { stripIndent as stripIndent7 } from "common-tags";
|
|
3249
3353
|
import decamelize from "decamelize";
|
|
3250
|
-
var
|
|
3354
|
+
var defaultOptions13 = [];
|
|
3251
3355
|
var noUnsafeSwitchmapRule = ruleCreator({
|
|
3252
|
-
defaultOptions:
|
|
3356
|
+
defaultOptions: defaultOptions13,
|
|
3253
3357
|
meta: {
|
|
3254
3358
|
docs: {
|
|
3255
3359
|
description: "Disallow unsafe `switchMap` usage in effects and epics.",
|
|
@@ -3282,7 +3386,7 @@ var noUnsafeSwitchmapRule = ruleCreator({
|
|
|
3282
3386
|
}
|
|
3283
3387
|
},
|
|
3284
3388
|
type: "object",
|
|
3285
|
-
description:
|
|
3389
|
+
description: stripIndent7`
|
|
3286
3390
|
An optional object with optional \`allow\`, \`disallow\` and \`observable\` properties.
|
|
3287
3391
|
The properties can be specified as regular expression strings or as arrays of words.
|
|
3288
3392
|
The \`allow\` or \`disallow\` properties are mutually exclusive. Whether or not
|
|
@@ -3371,33 +3475,10 @@ var noUnsafeSwitchmapRule = ruleCreator({
|
|
|
3371
3475
|
});
|
|
3372
3476
|
|
|
3373
3477
|
// src/rules/no-unsafe-takeuntil.ts
|
|
3374
|
-
import { stripIndent as
|
|
3375
|
-
var
|
|
3376
|
-
var allowedOperators = [
|
|
3377
|
-
"count",
|
|
3378
|
-
"defaultIfEmpty",
|
|
3379
|
-
"endWith",
|
|
3380
|
-
"every",
|
|
3381
|
-
"finalize",
|
|
3382
|
-
"finally",
|
|
3383
|
-
"isEmpty",
|
|
3384
|
-
"last",
|
|
3385
|
-
"max",
|
|
3386
|
-
"min",
|
|
3387
|
-
"publish",
|
|
3388
|
-
"publishBehavior",
|
|
3389
|
-
"publishLast",
|
|
3390
|
-
"publishReplay",
|
|
3391
|
-
"reduce",
|
|
3392
|
-
"share",
|
|
3393
|
-
"shareReplay",
|
|
3394
|
-
"skipLast",
|
|
3395
|
-
"takeLast",
|
|
3396
|
-
"throwIfEmpty",
|
|
3397
|
-
"toArray"
|
|
3398
|
-
];
|
|
3478
|
+
import { stripIndent as stripIndent8 } from "common-tags";
|
|
3479
|
+
var defaultOptions14 = [];
|
|
3399
3480
|
var noUnsafeTakeuntilRule = ruleCreator({
|
|
3400
|
-
defaultOptions:
|
|
3481
|
+
defaultOptions: defaultOptions14,
|
|
3401
3482
|
meta: {
|
|
3402
3483
|
docs: {
|
|
3403
3484
|
description: "Disallow applying operators after `takeUntil`.",
|
|
@@ -3411,10 +3492,10 @@ var noUnsafeTakeuntilRule = ruleCreator({
|
|
|
3411
3492
|
{
|
|
3412
3493
|
properties: {
|
|
3413
3494
|
alias: { type: "array", items: { type: "string" }, description: "An array of operator names that should be treated similarly to `takeUntil`." },
|
|
3414
|
-
allow: { type: "array", items: { type: "string" }, description: "An array of operator names that are allowed to follow `takeUntil`.", default:
|
|
3495
|
+
allow: { type: "array", items: { type: "string" }, description: "An array of operator names that are allowed to follow `takeUntil`.", default: DEFAULT_VALID_POST_COMPLETION_OPERATORS }
|
|
3415
3496
|
},
|
|
3416
3497
|
type: "object",
|
|
3417
|
-
description:
|
|
3498
|
+
description: stripIndent8`
|
|
3418
3499
|
An optional object with optional \`alias\` and \`allow\` properties.
|
|
3419
3500
|
The \`alias\` property is an array containing the names of operators that aliases for \`takeUntil\`.
|
|
3420
3501
|
The \`allow\` property is an array containing the names of the operators that are allowed to follow \`takeUntil\`.`
|
|
@@ -3426,7 +3507,7 @@ var noUnsafeTakeuntilRule = ruleCreator({
|
|
|
3426
3507
|
create: (context) => {
|
|
3427
3508
|
let checkedOperatorsRegExp = /^takeUntil$/;
|
|
3428
3509
|
const [config = {}] = context.options;
|
|
3429
|
-
const { alias, allow =
|
|
3510
|
+
const { alias, allow = DEFAULT_VALID_POST_COMPLETION_OPERATORS } = config;
|
|
3430
3511
|
if (alias) {
|
|
3431
3512
|
checkedOperatorsRegExp = new RegExp(
|
|
3432
3513
|
`^(${alias.concat("takeUntil").join("|")})$`
|
|
@@ -3438,35 +3519,17 @@ var noUnsafeTakeuntilRule = ruleCreator({
|
|
|
3438
3519
|
if (!pipeCallExpression.arguments || !couldBeObservable(pipeCallExpression)) {
|
|
3439
3520
|
return;
|
|
3440
3521
|
}
|
|
3441
|
-
|
|
3442
|
-
|
|
3443
|
-
|
|
3444
|
-
|
|
3445
|
-
|
|
3446
|
-
|
|
3447
|
-
|
|
3448
|
-
|
|
3449
|
-
|
|
3450
|
-
|
|
3451
|
-
|
|
3452
|
-
operatorName = arg.callee.property.name;
|
|
3453
|
-
} else {
|
|
3454
|
-
return "disallowed";
|
|
3455
|
-
}
|
|
3456
|
-
if (checkedOperatorsRegExp.test(operatorName)) {
|
|
3457
|
-
if (state === "disallowed") {
|
|
3458
|
-
context.report({
|
|
3459
|
-
messageId: "forbidden",
|
|
3460
|
-
node: arg.callee
|
|
3461
|
-
});
|
|
3462
|
-
}
|
|
3463
|
-
return "taken";
|
|
3464
|
-
}
|
|
3465
|
-
if (!allow.includes(operatorName)) {
|
|
3466
|
-
return "disallowed";
|
|
3467
|
-
}
|
|
3468
|
-
return state;
|
|
3469
|
-
}, "allowed");
|
|
3522
|
+
const { isOrderValid, operatorNode } = findIsLastOperatorOrderValid(
|
|
3523
|
+
pipeCallExpression,
|
|
3524
|
+
checkedOperatorsRegExp,
|
|
3525
|
+
allow
|
|
3526
|
+
);
|
|
3527
|
+
if (!isOrderValid && operatorNode) {
|
|
3528
|
+
context.report({
|
|
3529
|
+
messageId: "forbidden",
|
|
3530
|
+
node: operatorNode
|
|
3531
|
+
});
|
|
3532
|
+
}
|
|
3470
3533
|
}
|
|
3471
3534
|
return {
|
|
3472
3535
|
[`CallExpression[callee.property.name='pipe'] > CallExpression[callee.name=${checkedOperatorsRegExp}]`]: checkNode,
|
|
@@ -3476,9 +3539,9 @@ var noUnsafeTakeuntilRule = ruleCreator({
|
|
|
3476
3539
|
});
|
|
3477
3540
|
|
|
3478
3541
|
// src/rules/prefer-observer.ts
|
|
3479
|
-
var
|
|
3542
|
+
var defaultOptions15 = [];
|
|
3480
3543
|
var preferObserverRule = ruleCreator({
|
|
3481
|
-
defaultOptions:
|
|
3544
|
+
defaultOptions: defaultOptions15,
|
|
3482
3545
|
meta: {
|
|
3483
3546
|
docs: {
|
|
3484
3547
|
description: "Disallow passing separate handlers to `subscribe` and `tap`.",
|
|
@@ -3714,9 +3777,9 @@ var preferRootOperatorsRule = ruleCreator({
|
|
|
3714
3777
|
|
|
3715
3778
|
// src/rules/suffix-subjects.ts
|
|
3716
3779
|
import { AST_NODE_TYPES as AST_NODE_TYPES9, ESLintUtils as ESLintUtils11 } from "@typescript-eslint/utils";
|
|
3717
|
-
var
|
|
3780
|
+
var defaultOptions16 = [];
|
|
3718
3781
|
var suffixSubjectsRule = ruleCreator({
|
|
3719
|
-
defaultOptions:
|
|
3782
|
+
defaultOptions: defaultOptions16,
|
|
3720
3783
|
meta: {
|
|
3721
3784
|
docs: {
|
|
3722
3785
|
description: "Enforce the use of a suffix in subject identifiers.",
|
|
@@ -3913,9 +3976,9 @@ var suffixSubjectsRule = ruleCreator({
|
|
|
3913
3976
|
// src/rules/throw-error.ts
|
|
3914
3977
|
import { ESLintUtils as ESLintUtils12 } from "@typescript-eslint/utils";
|
|
3915
3978
|
import * as tsutils4 from "ts-api-utils";
|
|
3916
|
-
var
|
|
3979
|
+
var defaultOptions17 = [];
|
|
3917
3980
|
var throwErrorRule = ruleCreator({
|
|
3918
|
-
defaultOptions:
|
|
3981
|
+
defaultOptions: defaultOptions17,
|
|
3919
3982
|
meta: {
|
|
3920
3983
|
docs: {
|
|
3921
3984
|
description: "Enforce passing only `Error` values to `throwError`.",
|