eslint-plugin-rxjs-x 0.7.0 → 0.7.1

package/dist/index.d.mts

@@ -146,7 +146,7 @@ declare const rxjsX: {
         'no-subscribe-handlers': TSESLint.RuleModule<"forbidden", [], RxjsXRuleDocs, TSESLint.RuleListener>;
         'no-subscribe-in-pipe': TSESLint.RuleModule<"forbidden", [], RxjsXRuleDocs, TSESLint.RuleListener>;
         'no-tap': TSESLint.RuleModule<"forbidden", [], RxjsXRuleDocs, TSESLint.RuleListener>;
-        'no-topromise': TSESLint.RuleModule<"forbidden" | "suggestLastValueFrom" | "suggestFirstValueFrom", [], RxjsXRuleDocs, TSESLint.RuleListener>;
+        'no-topromise': TSESLint.RuleModule<"forbidden" | "suggestLastValueFromWithDefault" | "suggestLastValueFrom" | "suggestFirstValueFrom", [], RxjsXRuleDocs, TSESLint.RuleListener>;
         'no-unbound-methods': TSESLint.RuleModule<"forbidden", [], RxjsXRuleDocs, TSESLint.RuleListener>;
         'no-unsafe-catch': TSESLint.RuleModule<"forbidden", readonly {
             observable?: string;

package/dist/index.d.ts

@@ -146,7 +146,7 @@ declare const rxjsX: {
         'no-subscribe-handlers': TSESLint.RuleModule<"forbidden", [], RxjsXRuleDocs, TSESLint.RuleListener>;
         'no-subscribe-in-pipe': TSESLint.RuleModule<"forbidden", [], RxjsXRuleDocs, TSESLint.RuleListener>;
         'no-tap': TSESLint.RuleModule<"forbidden", [], RxjsXRuleDocs, TSESLint.RuleListener>;
-        'no-topromise': TSESLint.RuleModule<"forbidden" | "suggestLastValueFrom" | "suggestFirstValueFrom", [], RxjsXRuleDocs, TSESLint.RuleListener>;
+        'no-topromise': TSESLint.RuleModule<"forbidden" | "suggestLastValueFromWithDefault" | "suggestLastValueFrom" | "suggestFirstValueFrom", [], RxjsXRuleDocs, TSESLint.RuleListener>;
         'no-unbound-methods': TSESLint.RuleModule<"forbidden", [], RxjsXRuleDocs, TSESLint.RuleListener>;
         'no-unsafe-catch': TSESLint.RuleModule<"forbidden", readonly {
             observable?: string;

package/dist/index.js

@@ -1,6 +1,6 @@
 "use strict";Object.defineProperty(exports, "__esModule", {value: true}); function _interopRequireWildcard(obj) { if (obj && obj.__esModule) { return obj; } else { var newObj = {}; if (obj != null) { for (var key in obj) { if (Object.prototype.hasOwnProperty.call(obj, key)) { newObj[key] = obj[key]; } } } newObj.default = obj; return newObj; } } function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }// package.json
 var name = "eslint-plugin-rxjs-x";
-var version = "0.7.0";
+var version = "0.7.1";
 
 // src/configs/recommended.ts
 var createRecommendedConfig = (plugin2) => ({
@@ -2909,6 +2909,7 @@ var noTopromiseRule = ruleCreator({
     hasSuggestions: true,
     messages: {
       forbidden: "The toPromise method is forbidden.",
+      suggestLastValueFromWithDefault: "Use lastValueFrom(..., { defaultValue: undefined }) instead.",
       suggestLastValueFrom: "Use lastValueFrom instead.",
       suggestFirstValueFrom: "Use firstValueFrom instead."
     },
@@ -2926,7 +2927,7 @@ var noTopromiseRule = ruleCreator({
       const [, quote] = match;
       return quote;
     }
-    function createFix(conversion, callExpression, observableNode, importDeclarations) {
+    function createFix(conversion, callExpression, observableNode, importDeclarations, { withDefault } = {}) {
       return function* fix(fixer) {
         var _a, _b, _c;
         let namespace = "";
@@ -2957,7 +2958,7 @@ import { ${functionName} } from ${quote}rxjs${quote};`
         }
         yield fixer.replaceText(
           callExpression,
-          `${namespace}${functionName}(${context.sourceCode.getText(observableNode)})`
+          `${namespace}${functionName}(${context.sourceCode.getText(observableNode)}${withDefault ? ", { defaultValue: undefined }" : ""})`
         );
       };
     }
@@ -2976,6 +2977,10 @@ import { ${functionName} } from ${quote}rxjs${quote};`
           messageId: "forbidden",
           node: memberExpression.property,
           suggest: [
+            {
+              messageId: "suggestLastValueFromWithDefault",
+              fix: createFix("lastValueFrom", node, memberExpression.object, importDeclarations, { withDefault: true })
+            },
             {
               messageId: "suggestLastValueFrom",
               fix: createFix("lastValueFrom", node, memberExpression.object, importDeclarations)

package/dist/index.mjs

@@ -1,6 +1,6 @@
 // package.json
 var name = "eslint-plugin-rxjs-x";
-var version = "0.7.0";
+var version = "0.7.1";
 
 // src/configs/recommended.ts
 var createRecommendedConfig = (plugin2) => ({
@@ -2909,6 +2909,7 @@ var noTopromiseRule = ruleCreator({
     hasSuggestions: true,
     messages: {
       forbidden: "The toPromise method is forbidden.",
+      suggestLastValueFromWithDefault: "Use lastValueFrom(..., { defaultValue: undefined }) instead.",
       suggestLastValueFrom: "Use lastValueFrom instead.",
       suggestFirstValueFrom: "Use firstValueFrom instead."
     },
@@ -2926,7 +2927,7 @@ var noTopromiseRule = ruleCreator({
       const [, quote] = match;
       return quote;
     }
-    function createFix(conversion, callExpression, observableNode, importDeclarations) {
+    function createFix(conversion, callExpression, observableNode, importDeclarations, { withDefault } = {}) {
       return function* fix(fixer) {
         var _a, _b, _c;
         let namespace = "";
@@ -2957,7 +2958,7 @@ import { ${functionName} } from ${quote}rxjs${quote};`
         }
         yield fixer.replaceText(
           callExpression,
-          `${namespace}${functionName}(${context.sourceCode.getText(observableNode)})`
+          `${namespace}${functionName}(${context.sourceCode.getText(observableNode)}${withDefault ? ", { defaultValue: undefined }" : ""})`
         );
       };
     }
@@ -2976,6 +2977,10 @@ import { ${functionName} } from ${quote}rxjs${quote};`
           messageId: "forbidden",
           node: memberExpression.property,
           suggest: [
+            {
+              messageId: "suggestLastValueFromWithDefault",
+              fix: createFix("lastValueFrom", node, memberExpression.object, importDeclarations, { withDefault: true })
+            },
             {
               messageId: "suggestLastValueFrom",
               fix: createFix("lastValueFrom", node, memberExpression.object, importDeclarations)

package/docs/rules/no-topromise.md

@@ -10,9 +10,10 @@
 
 This rule effects failures if the `toPromise` method is used.
 
-This rule provides two editor suggestions which replace `toPromise` with either:
+This rule provides three editor suggestions which replace `toPromise` with either:
 
-- `lastValueFrom(...)`, which behaves closest to the behavior of `toPromise`,
+- `lastValueFrom(..., { defaultValue: undefined })`, which imitates the behavior of `toPromise`,
+- or `lastValueFrom(...)`, which throws `EmptyError` instead of defaulting to `undefined`,
 - or `firstValueFrom(...)`.
 
 ## When Not To Use It
@@ -26,6 +27,10 @@ Type checked lint rules are more powerful than traditional lint rules, but also
 
 - [Conversion to Promises](https://rxjs.dev/deprecations/to-promise)
 
+## Related To
+
+- [`no-ignored-default-value`](./no-ignored-default-value.md)
+
 ## Resources
 
 - [Rule source](https://github.com/JasonWeinzierl/eslint-plugin-rxjs-x/blob/main/src/rules/no-topromise.ts)

package/package.json

@@ -1,8 +1,8 @@
 {
   "name": "eslint-plugin-rxjs-x",
   "type": "commonjs",
-  "version": "0.7.0",
-  "packageManager": "yarn@4.6.0+sha512.5383cc12567a95f1d668fbe762dfe0075c595b4bfff433be478dbbe24e05251a8e8c3eb992a986667c1d53b6c3a9c85b8398c35a960587fbd9fa3a0915406728",
+  "version": "0.7.1",
+  "packageManager": "yarn@4.7.0+sha512.5a0afa1d4c1d844b3447ee3319633797bcd6385d9a44be07993ae52ff4facabccafb4af5dcd1c2f9a94ac113e5e9ff56f6130431905884414229e284e37bb7c9",
   "description": "ESLint v9+ plugin for RxJS",
   "author": "Jason Weinzierl <weinzierljason@gmail.com>",
   "license": "MIT",