eslint-plugin-rxjs-x 0.6.2 → 0.7.1

package/dist/index.d.mts

@@ -146,7 +146,7 @@ declare const rxjsX: {
         'no-subscribe-handlers': TSESLint.RuleModule<"forbidden", [], RxjsXRuleDocs, TSESLint.RuleListener>;
         'no-subscribe-in-pipe': TSESLint.RuleModule<"forbidden", [], RxjsXRuleDocs, TSESLint.RuleListener>;
         'no-tap': TSESLint.RuleModule<"forbidden", [], RxjsXRuleDocs, TSESLint.RuleListener>;
-        'no-topromise': TSESLint.RuleModule<"forbidden" | "suggestLastValueFrom" | "suggestFirstValueFrom", [], RxjsXRuleDocs, TSESLint.RuleListener>;
+        'no-topromise': TSESLint.RuleModule<"forbidden" | "suggestLastValueFromWithDefault" | "suggestLastValueFrom" | "suggestFirstValueFrom", [], RxjsXRuleDocs, TSESLint.RuleListener>;
         'no-unbound-methods': TSESLint.RuleModule<"forbidden", [], RxjsXRuleDocs, TSESLint.RuleListener>;
         'no-unsafe-catch': TSESLint.RuleModule<"forbidden", readonly {
             observable?: string;

package/dist/index.d.ts

@@ -146,7 +146,7 @@ declare const rxjsX: {
         'no-subscribe-handlers': TSESLint.RuleModule<"forbidden", [], RxjsXRuleDocs, TSESLint.RuleListener>;
         'no-subscribe-in-pipe': TSESLint.RuleModule<"forbidden", [], RxjsXRuleDocs, TSESLint.RuleListener>;
         'no-tap': TSESLint.RuleModule<"forbidden", [], RxjsXRuleDocs, TSESLint.RuleListener>;
-        'no-topromise': TSESLint.RuleModule<"forbidden" | "suggestLastValueFrom" | "suggestFirstValueFrom", [], RxjsXRuleDocs, TSESLint.RuleListener>;
+        'no-topromise': TSESLint.RuleModule<"forbidden" | "suggestLastValueFromWithDefault" | "suggestLastValueFrom" | "suggestFirstValueFrom", [], RxjsXRuleDocs, TSESLint.RuleListener>;
         'no-unbound-methods': TSESLint.RuleModule<"forbidden", [], RxjsXRuleDocs, TSESLint.RuleListener>;
         'no-unsafe-catch': TSESLint.RuleModule<"forbidden", readonly {
             observable?: string;

package/dist/index.js

@@ -1,6 +1,6 @@
 "use strict";Object.defineProperty(exports, "__esModule", {value: true}); function _interopRequireWildcard(obj) { if (obj && obj.__esModule) { return obj; } else { var newObj = {}; if (obj != null) { for (var key in obj) { if (Object.prototype.hasOwnProperty.call(obj, key)) { newObj[key] = obj[key]; } } } newObj.default = obj; return newObj; } } function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }// package.json
 var name = "eslint-plugin-rxjs-x";
-var version = "0.6.2";
+var version = "0.7.1";
 
 // src/configs/recommended.ts
 var createRecommendedConfig = (plugin2) => ({
@@ -94,8 +94,9 @@ function createRegExpForWords(config) {
 function escapeRegExp(text) {
   return text.replace(/[-/\\^$*+?.()|[\]{}]/g, "\\$&");
 }
+var REPO_URL = "https://github.com/JasonWeinzierl/eslint-plugin-rxjs-x";
 var ruleCreator = _utils.ESLintUtils.RuleCreator(
-  (name2) => `https://github.com/JasonWeinzierl/eslint-plugin-rxjs-x/blob/main/docs/rules/${name2}.md`
+  (name2) => `${REPO_URL}/blob/v${version}/docs/rules/${name2}.md`
 );
 
 // src/rules/ban-observables.ts
@@ -2908,6 +2909,7 @@ var noTopromiseRule = ruleCreator({
     hasSuggestions: true,
     messages: {
       forbidden: "The toPromise method is forbidden.",
+      suggestLastValueFromWithDefault: "Use lastValueFrom(..., { defaultValue: undefined }) instead.",
       suggestLastValueFrom: "Use lastValueFrom instead.",
       suggestFirstValueFrom: "Use firstValueFrom instead."
     },
@@ -2925,7 +2927,7 @@ var noTopromiseRule = ruleCreator({
       const [, quote] = match;
       return quote;
     }
-    function createFix(conversion, callExpression, observableNode, importDeclarations) {
+    function createFix(conversion, callExpression, observableNode, importDeclarations, { withDefault } = {}) {
       return function* fix(fixer) {
         var _a, _b, _c;
         let namespace = "";
@@ -2956,7 +2958,7 @@ import { ${functionName} } from ${quote}rxjs${quote};`
         }
         yield fixer.replaceText(
           callExpression,
-          `${namespace}${functionName}(${context.sourceCode.getText(observableNode)})`
+          `${namespace}${functionName}(${context.sourceCode.getText(observableNode)}${withDefault ? ", { defaultValue: undefined }" : ""})`
         );
       };
     }
@@ -2975,6 +2977,10 @@ import { ${functionName} } from ${quote}rxjs${quote};`
           messageId: "forbidden",
           node: memberExpression.property,
           suggest: [
+            {
+              messageId: "suggestLastValueFromWithDefault",
+              fix: createFix("lastValueFrom", node, memberExpression.object, importDeclarations, { withDefault: true })
+            },
             {
               messageId: "suggestLastValueFrom",
               fix: createFix("lastValueFrom", node, memberExpression.object, importDeclarations)
@@ -4041,9 +4047,9 @@ var rxjsX = {
     strict: createStrictConfig(plugin)
   }
 };
-var src_default = rxjsX;
+var index_default = rxjsX;
 
 
-exports.default = src_default;
+exports.default = index_default;
 
 module.exports = exports.default;

package/dist/index.mjs

@@ -1,6 +1,6 @@
 // package.json
 var name = "eslint-plugin-rxjs-x";
-var version = "0.6.2";
+var version = "0.7.1";
 
 // src/configs/recommended.ts
 var createRecommendedConfig = (plugin2) => ({
@@ -94,8 +94,9 @@ function createRegExpForWords(config) {
 function escapeRegExp(text) {
   return text.replace(/[-/\\^$*+?.()|[\]{}]/g, "\\$&");
 }
+var REPO_URL = "https://github.com/JasonWeinzierl/eslint-plugin-rxjs-x";
 var ruleCreator = ESLintUtils.RuleCreator(
-  (name2) => `https://github.com/JasonWeinzierl/eslint-plugin-rxjs-x/blob/main/docs/rules/${name2}.md`
+  (name2) => `${REPO_URL}/blob/v${version}/docs/rules/${name2}.md`
 );
 
 // src/rules/ban-observables.ts
@@ -2908,6 +2909,7 @@ var noTopromiseRule = ruleCreator({
     hasSuggestions: true,
     messages: {
       forbidden: "The toPromise method is forbidden.",
+      suggestLastValueFromWithDefault: "Use lastValueFrom(..., { defaultValue: undefined }) instead.",
       suggestLastValueFrom: "Use lastValueFrom instead.",
       suggestFirstValueFrom: "Use firstValueFrom instead."
     },
@@ -2925,7 +2927,7 @@ var noTopromiseRule = ruleCreator({
       const [, quote] = match;
       return quote;
     }
-    function createFix(conversion, callExpression, observableNode, importDeclarations) {
+    function createFix(conversion, callExpression, observableNode, importDeclarations, { withDefault } = {}) {
       return function* fix(fixer) {
         var _a, _b, _c;
         let namespace = "";
@@ -2956,7 +2958,7 @@ import { ${functionName} } from ${quote}rxjs${quote};`
         }
         yield fixer.replaceText(
           callExpression,
-          `${namespace}${functionName}(${context.sourceCode.getText(observableNode)})`
+          `${namespace}${functionName}(${context.sourceCode.getText(observableNode)}${withDefault ? ", { defaultValue: undefined }" : ""})`
         );
       };
     }
@@ -2975,6 +2977,10 @@ import { ${functionName} } from ${quote}rxjs${quote};`
           messageId: "forbidden",
           node: memberExpression.property,
           suggest: [
+            {
+              messageId: "suggestLastValueFromWithDefault",
+              fix: createFix("lastValueFrom", node, memberExpression.object, importDeclarations, { withDefault: true })
+            },
             {
               messageId: "suggestLastValueFrom",
               fix: createFix("lastValueFrom", node, memberExpression.object, importDeclarations)
@@ -4041,7 +4047,7 @@ var rxjsX = {
     strict: createStrictConfig(plugin)
   }
 };
-var src_default = rxjsX;
+var index_default = rxjsX;
 export {
-  src_default as default
+  index_default as default
 };

package/docs/rules/no-topromise.md

@@ -10,9 +10,10 @@
 
 This rule effects failures if the `toPromise` method is used.
 
-This rule provides two editor suggestions which replace `toPromise` with either:
+This rule provides three editor suggestions which replace `toPromise` with either:
 
-- `lastValueFrom(...)`, which behaves closest to the behavior of `toPromise`,
+- `lastValueFrom(..., { defaultValue: undefined })`, which imitates the behavior of `toPromise`,
+- or `lastValueFrom(...)`, which throws `EmptyError` instead of defaulting to `undefined`,
 - or `firstValueFrom(...)`.
 
 ## When Not To Use It
@@ -26,6 +27,10 @@ Type checked lint rules are more powerful than traditional lint rules, but also
 
 - [Conversion to Promises](https://rxjs.dev/deprecations/to-promise)
 
+## Related To
+
+- [`no-ignored-default-value`](./no-ignored-default-value.md)
+
 ## Resources
 
 - [Rule source](https://github.com/JasonWeinzierl/eslint-plugin-rxjs-x/blob/main/src/rules/no-topromise.ts)

package/package.json

@@ -1,8 +1,8 @@
 {
   "name": "eslint-plugin-rxjs-x",
   "type": "commonjs",
-  "version": "0.6.2",
-  "packageManager": "yarn@4.6.0+sha512.5383cc12567a95f1d668fbe762dfe0075c595b4bfff433be478dbbe24e05251a8e8c3eb992a986667c1d53b6c3a9c85b8398c35a960587fbd9fa3a0915406728",
+  "version": "0.7.1",
+  "packageManager": "yarn@4.7.0+sha512.5a0afa1d4c1d844b3447ee3319633797bcd6385d9a44be07993ae52ff4facabccafb4af5dcd1c2f9a94ac113e5e9ff56f6130431905884414229e284e37bb7c9",
   "description": "ESLint v9+ plugin for RxJS",
   "author": "Jason Weinzierl <weinzierljason@gmail.com>",
   "license": "MIT",
@@ -55,11 +55,11 @@
     "typecheck": "tsc --noEmit"
   },
   "dependencies": {
-    "@typescript-eslint/scope-manager": "^8.1.0",
-    "@typescript-eslint/utils": "^8.1.0",
+    "@typescript-eslint/scope-manager": "^8.19.1",
+    "@typescript-eslint/utils": "^8.19.1",
     "common-tags": "^1.8.0",
     "decamelize": "^5.0.1",
-    "ts-api-utils": "^1.3.0",
+    "ts-api-utils": "^2.0.0",
     "tslib": "^2.1.0"
   },
   "peerDependencies": {
@@ -73,28 +73,28 @@
     }
   },
   "devDependencies": {
-    "@eslint/js": "^9.17.0",
-    "@stylistic/eslint-plugin": "^2.12.1",
+    "@eslint/js": "^9.22.0",
+    "@stylistic/eslint-plugin": "^4.2.0",
     "@types/common-tags": "^1.8.4",
     "@types/node": "~18.18.0",
-    "@typescript-eslint/rule-tester": "^8.19.1",
-    "@typescript/vfs": "^1.6.0",
-    "@vitest/coverage-v8": "^2.1.8",
-    "@vitest/eslint-plugin": "^1.1.24",
-    "bumpp": "^9.9.3",
-    "eslint": "^9.17.0",
-    "eslint-config-flat-gitignore": "^0.3.0",
-    "eslint-doc-generator": "^2.0.2",
-    "eslint-import-resolver-typescript": "^3.7.0",
+    "@typescript-eslint/rule-tester": "^8.26.1",
+    "@typescript/vfs": "^1.6.1",
+    "@vitest/coverage-v8": "^3.0.8",
+    "@vitest/eslint-plugin": "^1.1.37",
+    "bumpp": "^10.1.0",
+    "eslint": "^9.22.0",
+    "eslint-config-flat-gitignore": "^2.1.0",
+    "eslint-doc-generator": "^2.1.1",
+    "eslint-import-resolver-typescript": "^3.8.5",
     "eslint-plugin-eslint-plugin": "^6.4.0",
     "eslint-plugin-import-x": "^4.6.1",
-    "eslint-plugin-n": "^17.15.1",
-    "markdownlint-cli2": "^0.17.1",
-    "rxjs": "^7.8.1",
-    "tsup": "^8.3.5",
-    "typescript": "~5.7.2",
-    "typescript-eslint": "^8.19.1",
-    "vitest": "^2.1.8"
+    "eslint-plugin-n": "^17.16.2",
+    "markdownlint-cli2": "^0.17.2",
+    "rxjs": "^7.8.2",
+    "tsup": "^8.4.0",
+    "typescript": "~5.7.3",
+    "typescript-eslint": "^8.26.1",
+    "vitest": "^3.0.8"
   },
   "engines": {
     "node": "^18.18.0 || ^20.9.0 || >= 21.1.0"