eslint-plugin-rxjs-x 0.3.0 → 0.3.1

package/dist/index.js

@@ -1,6 +1,6 @@
 "use strict";Object.defineProperty(exports, "__esModule", {value: true}); function _interopRequireWildcard(obj) { if (obj && obj.__esModule) { return obj; } else { var newObj = {}; if (obj != null) { for (var key in obj) { if (Object.prototype.hasOwnProperty.call(obj, key)) { newObj[key] = obj[key]; } } } newObj.default = obj; return newObj; } } function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }// package.json
 var name = "eslint-plugin-rxjs-x";
-var version = "0.3.0";
+var version = "0.3.1";
 
 // src/configs/recommended.ts
 var createRecommendedConfig = (plugin2) => ({
@@ -1370,6 +1370,7 @@ var noIgnoredDefaultValueRule = ruleCreator({
 });
 
 // src/rules/no-ignored-error.ts
+
 var noIgnoredErrorRule = ruleCreator({
   defaultOptions: [],
   meta: {
@@ -1385,12 +1386,44 @@ var noIgnoredErrorRule = ruleCreator({
   },
   name: "no-ignored-error",
   create: (context) => {
+    const { getTypeAtLocation } = _utils.ESLintUtils.getParserServices(context);
     const { couldBeObservable, couldBeFunction: couldBeFunction2 } = getTypeServices(context);
+    function isMissingErrorCallback(callExpression) {
+      if (callExpression.arguments.length >= 2) {
+        return false;
+      }
+      return couldBeFunction2(callExpression.arguments[0]);
+    }
+    function isObjMissingError(arg) {
+      return !arg.properties.some(
+        (property) => isProperty(property) && isIdentifier(property.key) && property.key.name === "error"
+      );
+    }
+    function isTypeMissingError(arg) {
+      const argType = getTypeAtLocation(arg);
+      return !(argType == null ? void 0 : argType.getProperties().some((p) => p.name === "error"));
+    }
+    function isMissingErrorProperty(callExpression) {
+      if (callExpression.arguments.length !== 1) {
+        return false;
+      }
+      const [arg] = callExpression.arguments;
+      if (isObjectExpression(arg)) {
+        return isObjMissingError(arg);
+      }
+      if (isIdentifier(arg)) {
+        return isTypeMissingError(arg);
+      }
+      if (isMemberExpression(arg) && isIdentifier(arg.property)) {
+        return isTypeMissingError(arg.property);
+      }
+      return false;
+    }
     return {
       "CallExpression[arguments.length > 0] > MemberExpression > Identifier[name='subscribe']": (node) => {
         const memberExpression = node.parent;
         const callExpression = memberExpression.parent;
-        if (callExpression.arguments.length < 2 && couldBeObservable(memberExpression.object) && couldBeFunction2(callExpression.arguments[0])) {
+        if ((isMissingErrorCallback(callExpression) || isMissingErrorProperty(callExpression)) && couldBeObservable(memberExpression.object)) {
           context.report({
             messageId: "forbidden",
             node

package/dist/index.mjs

@@ -1,6 +1,6 @@
 // package.json
 var name = "eslint-plugin-rxjs-x";
-var version = "0.3.0";
+var version = "0.3.1";
 
 // src/configs/recommended.ts
 var createRecommendedConfig = (plugin2) => ({
@@ -1370,6 +1370,7 @@ var noIgnoredDefaultValueRule = ruleCreator({
 });
 
 // src/rules/no-ignored-error.ts
+import { ESLintUtils as ESLintUtils7 } from "@typescript-eslint/utils";
 var noIgnoredErrorRule = ruleCreator({
   defaultOptions: [],
   meta: {
@@ -1385,12 +1386,44 @@ var noIgnoredErrorRule = ruleCreator({
   },
   name: "no-ignored-error",
   create: (context) => {
+    const { getTypeAtLocation } = ESLintUtils7.getParserServices(context);
     const { couldBeObservable, couldBeFunction: couldBeFunction2 } = getTypeServices(context);
+    function isMissingErrorCallback(callExpression) {
+      if (callExpression.arguments.length >= 2) {
+        return false;
+      }
+      return couldBeFunction2(callExpression.arguments[0]);
+    }
+    function isObjMissingError(arg) {
+      return !arg.properties.some(
+        (property) => isProperty(property) && isIdentifier(property.key) && property.key.name === "error"
+      );
+    }
+    function isTypeMissingError(arg) {
+      const argType = getTypeAtLocation(arg);
+      return !(argType == null ? void 0 : argType.getProperties().some((p) => p.name === "error"));
+    }
+    function isMissingErrorProperty(callExpression) {
+      if (callExpression.arguments.length !== 1) {
+        return false;
+      }
+      const [arg] = callExpression.arguments;
+      if (isObjectExpression(arg)) {
+        return isObjMissingError(arg);
+      }
+      if (isIdentifier(arg)) {
+        return isTypeMissingError(arg);
+      }
+      if (isMemberExpression(arg) && isIdentifier(arg.property)) {
+        return isTypeMissingError(arg.property);
+      }
+      return false;
+    }
     return {
       "CallExpression[arguments.length > 0] > MemberExpression > Identifier[name='subscribe']": (node) => {
         const memberExpression = node.parent;
         const callExpression = memberExpression.parent;
-        if (callExpression.arguments.length < 2 && couldBeObservable(memberExpression.object) && couldBeFunction2(callExpression.arguments[0])) {
+        if ((isMissingErrorCallback(callExpression) || isMissingErrorProperty(callExpression)) && couldBeObservable(memberExpression.object)) {
           context.report({
             messageId: "forbidden",
             node
@@ -2317,7 +2350,7 @@ var noTopromiseRule = ruleCreator({
 });
 
 // src/rules/no-unbound-methods.ts
-import { ESLintUtils as ESLintUtils7 } from "@typescript-eslint/utils";
+import { ESLintUtils as ESLintUtils8 } from "@typescript-eslint/utils";
 var noUnboundMethodsRule = ruleCreator({
   defaultOptions: [],
   meta: {
@@ -2334,7 +2367,7 @@ var noUnboundMethodsRule = ruleCreator({
   },
   name: "no-unbound-methods",
   create: (context) => {
-    const { getTypeAtLocation } = ESLintUtils7.getParserServices(context);
+    const { getTypeAtLocation } = ESLintUtils8.getParserServices(context);
     const { couldBeObservable, couldBeSubscription } = getTypeServices(context);
     const nodeMap = /* @__PURE__ */ new WeakMap();
     function mapArguments(node) {
@@ -2512,7 +2545,7 @@ var noUnsafeFirstRule = ruleCreator({
 });
 
 // src/rules/no-unsafe-subject-next.ts
-import { ESLintUtils as ESLintUtils8 } from "@typescript-eslint/utils";
+import { ESLintUtils as ESLintUtils9 } from "@typescript-eslint/utils";
 import * as tsutils2 from "ts-api-utils";
 import ts6 from "typescript";
 var noUnsafeSubjectNext = ruleCreator({
@@ -2531,7 +2564,7 @@ var noUnsafeSubjectNext = ruleCreator({
   },
   name: "no-unsafe-subject-next",
   create: (context) => {
-    const { getTypeAtLocation, program } = ESLintUtils8.getParserServices(context);
+    const { getTypeAtLocation, program } = ESLintUtils9.getParserServices(context);
     const typeChecker = program.getTypeChecker();
     return {
       [`CallExpression[callee.property.name='next']`]: (node) => {
@@ -2895,7 +2928,7 @@ function isValidArgText(argText) {
 }
 
 // src/rules/suffix-subjects.ts
-import { AST_NODE_TYPES as AST_NODE_TYPES7, ESLintUtils as ESLintUtils9 } from "@typescript-eslint/utils";
+import { AST_NODE_TYPES as AST_NODE_TYPES7, ESLintUtils as ESLintUtils10 } from "@typescript-eslint/utils";
 var defaultOptions13 = [];
 var suffixSubjectsRule = ruleCreator({
   defaultOptions: defaultOptions13,
@@ -2923,7 +2956,7 @@ var suffixSubjectsRule = ruleCreator({
   },
   name: "suffix-subjects",
   create: (context) => {
-    const { esTreeNodeToTSNodeMap } = ESLintUtils9.getParserServices(context);
+    const { esTreeNodeToTSNodeMap } = ESLintUtils10.getParserServices(context);
     const { couldBeType: couldBeType2 } = getTypeServices(context);
     const [config = {}] = context.options;
     const validate = {
@@ -3093,7 +3126,7 @@ var suffixSubjectsRule = ruleCreator({
 });
 
 // src/rules/throw-error.ts
-import { ESLintUtils as ESLintUtils10 } from "@typescript-eslint/utils";
+import { ESLintUtils as ESLintUtils11 } from "@typescript-eslint/utils";
 import * as tsutils3 from "ts-api-utils";
 var defaultOptions14 = [];
 var throwErrorRule = ruleCreator({
@@ -3119,7 +3152,7 @@ var throwErrorRule = ruleCreator({
   },
   name: "throw-error",
   create: (context) => {
-    const { esTreeNodeToTSNodeMap, program, getTypeAtLocation } = ESLintUtils10.getParserServices(context);
+    const { esTreeNodeToTSNodeMap, program, getTypeAtLocation } = ESLintUtils11.getParserServices(context);
     const { couldBeObservable } = getTypeServices(context);
     const [config = {}] = context.options;
     const { allowThrowingAny = true, allowThrowingUnknown = true } = config;

package/docs/rules/no-async-subscribe.md

@@ -7,6 +7,9 @@
 <!-- end auto-generated rule header -->
 
 This rule effects failures if async functions are passed to `subscribe`.
+Developers are encouraged to avoid race conditions
+by instead using RxJS operators which can handle both Promises and Observables
+(e.g. `concatMap`, `switchMap`, `mergeMap`, `exhaustMap`).
 
 ## Rule details
 
@@ -14,16 +17,26 @@ Examples of **incorrect** code for this rule:
 
 ```ts
 import { of } from "rxjs";
-of(42).subscribe(async () => console.log(value));
+
+of(42).subscribe(async value => {
+    const data1 = await fetch(`https://api.some.com/things/${value}`);
+    const data2 = await fetch(`https://api.some.com/things/${data1.id}`);
+    console.log(data2);
+});
 ```
 
 Examples of **correct** code for this rule:
 
 ```ts
 import { of } from "rxjs";
-of(42).subscribe(() => console.log(value));
+
+of(42).pipe(
+    switchMap(value => fetch(`http://api.some.com/things/${value}`)),
+    switchMap(data1 => fetch(`http://api.some.com/things/${data1.id}`)),
+).subscribe(data2 => console.log(data2));
 ```
 
 ## Further reading
 
 - [Why does this rule exist?](https://stackoverflow.com/q/71559135)
+- [Higher-order Observables](https://rxjs.dev/guide/higher-order-observables)

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "eslint-plugin-rxjs-x",
   "type": "commonjs",
-  "version": "0.3.0",
+  "version": "0.3.1",
   "packageManager": "yarn@4.5.1+sha512.341db9396b6e289fecc30cd7ab3af65060e05ebff4b3b47547b278b9e67b08f485ecd8c79006b405446262142c7a38154445ef7f17c1d5d1de7d90bf9ce7054d",
   "description": "ESLint v9+ plugin for RxJS",
   "author": "Jason Weinzierl <weinzierljason@gmail.com>",
@@ -90,7 +90,6 @@
     "markdownlint-cli2": "^0.15.0",
     "rxjs": "^7.8.1",
     "tsup": "^8.3.5",
-    "tsx": "^4.19.2",
     "typescript": "~5.6.3",
     "typescript-eslint": "^8.14.0",
     "vitest": "^2.1.5"