eslint-plugin-rxjs-x 0.2.2 → 0.2.4

package/README.md

@@ -70,7 +70,7 @@ The package includes the following rules.
 | [ban-operators](docs/rules/ban-operators.md)                           | Disallow banned operators.                                                                           |    |    |    |    |    |
 | [finnish](docs/rules/finnish.md)                                       | Enforce Finnish notation.                                                                            |    |    |    | 💭 |    |
 | [just](docs/rules/just.md)                                             | Require the use of `just` instead of `of`.                                                           |    | 🔧 |    |    |    |
-| [macro](docs/rules/macro.md)                                           | Require the use of the RxJS Tools Babel macro.                                                       |    | 🔧 |    |    |    |
+| [macro](docs/rules/macro.md)                                           | Require the use of the RxJS Tools Babel macro.                                                       |    | 🔧 |    |    | ❌  |
 | [no-async-subscribe](docs/rules/no-async-subscribe.md)                 | Disallow passing `async` functions to `subscribe`.                                                   | ✅  |    |    | 💭 |    |
 | [no-compat](docs/rules/no-compat.md)                                   | Disallow the `rxjs-compat` package.                                                                  |    |    |    |    |    |
 | [no-connectable](docs/rules/no-connectable.md)                         | Disallow operators that return connectable observables.                                              |    |    |    | 💭 |    |

package/dist/index.js

@@ -1,6 +1,6 @@
 "use strict";Object.defineProperty(exports, "__esModule", {value: true}); function _interopRequireWildcard(obj) { if (obj && obj.__esModule) { return obj; } else { var newObj = {}; if (obj != null) { for (var key in obj) { if (Object.prototype.hasOwnProperty.call(obj, key)) { newObj[key] = obj[key]; } } } newObj.default = obj; return newObj; } } function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }// package.json
 var name = "eslint-plugin-rxjs-x";
-var version = "0.2.2";
+var version = "0.2.4";
 
 // src/configs/recommended.ts
 var createRecommendedConfig = (plugin2) => ({
@@ -723,6 +723,7 @@ var justRule = ruleCreator({
 var macroRule = ruleCreator({
   defaultOptions: [],
   meta: {
+    deprecated: true,
     docs: {
       description: "Require the use of the RxJS Tools Babel macro."
     },
@@ -1412,6 +1413,7 @@ var noIgnoredObservableRule = ruleCreator({
 });
 
 // src/rules/no-ignored-replay-buffer.ts
+
 var noIgnoredReplayBufferRule = ruleCreator({
   defaultOptions: [],
   meta: {
@@ -1427,6 +1429,14 @@ var noIgnoredReplayBufferRule = ruleCreator({
   },
   name: "no-ignored-replay-buffer",
   create: (context) => {
+    function checkShareReplayConfig(node, shareReplayConfigArg) {
+      if (!shareReplayConfigArg.properties.some((p) => p.type === _utils.AST_NODE_TYPES.Property && p.key.type === _utils.AST_NODE_TYPES.Identifier && p.key.name === "bufferSize")) {
+        context.report({
+          messageId: "forbidden",
+          node
+        });
+      }
+    }
     function checkNode(node, { arguments: args }) {
       if (!args || args.length === 0) {
         context.report({
@@ -1434,6 +1444,12 @@ var noIgnoredReplayBufferRule = ruleCreator({
           node
         });
       }
+      if (node.name === "shareReplay" && (args == null ? void 0 : args.length) === 1) {
+        const arg = args[0];
+        if (arg.type === _utils.AST_NODE_TYPES.ObjectExpression) {
+          checkShareReplayConfig(node, arg);
+        }
+      }
     }
     return {
       "NewExpression > Identifier[name='ReplaySubject']": (node) => {
@@ -1448,6 +1464,11 @@ var noIgnoredReplayBufferRule = ruleCreator({
       "CallExpression > Identifier[name=/^(publishReplay|shareReplay)$/]": (node) => {
         const callExpression = node.parent;
         checkNode(node, callExpression);
+      },
+      "CallExpression > MemberExpression > Identifier[name=/^(publishReplay|shareReplay)$/]": (node) => {
+        const memberExpression = node.parent;
+        const callExpression = memberExpression.parent;
+        checkNode(node, callExpression);
       }
     };
   }

package/dist/index.mjs

@@ -1,6 +1,6 @@
 // package.json
 var name = "eslint-plugin-rxjs-x";
-var version = "0.2.2";
+var version = "0.2.4";
 
 // src/configs/recommended.ts
 var createRecommendedConfig = (plugin2) => ({
@@ -723,6 +723,7 @@ var justRule = ruleCreator({
 var macroRule = ruleCreator({
   defaultOptions: [],
   meta: {
+    deprecated: true,
     docs: {
       description: "Require the use of the RxJS Tools Babel macro."
     },
@@ -1412,6 +1413,7 @@ var noIgnoredObservableRule = ruleCreator({
 });
 
 // src/rules/no-ignored-replay-buffer.ts
+import { AST_NODE_TYPES as AST_NODE_TYPES6 } from "@typescript-eslint/utils";
 var noIgnoredReplayBufferRule = ruleCreator({
   defaultOptions: [],
   meta: {
@@ -1427,6 +1429,14 @@ var noIgnoredReplayBufferRule = ruleCreator({
   },
   name: "no-ignored-replay-buffer",
   create: (context) => {
+    function checkShareReplayConfig(node, shareReplayConfigArg) {
+      if (!shareReplayConfigArg.properties.some((p) => p.type === AST_NODE_TYPES6.Property && p.key.type === AST_NODE_TYPES6.Identifier && p.key.name === "bufferSize")) {
+        context.report({
+          messageId: "forbidden",
+          node
+        });
+      }
+    }
     function checkNode(node, { arguments: args }) {
       if (!args || args.length === 0) {
         context.report({
@@ -1434,6 +1444,12 @@ var noIgnoredReplayBufferRule = ruleCreator({
           node
         });
       }
+      if (node.name === "shareReplay" && (args == null ? void 0 : args.length) === 1) {
+        const arg = args[0];
+        if (arg.type === AST_NODE_TYPES6.ObjectExpression) {
+          checkShareReplayConfig(node, arg);
+        }
+      }
     }
     return {
       "NewExpression > Identifier[name='ReplaySubject']": (node) => {
@@ -1448,6 +1464,11 @@ var noIgnoredReplayBufferRule = ruleCreator({
       "CallExpression > Identifier[name=/^(publishReplay|shareReplay)$/]": (node) => {
         const callExpression = node.parent;
         checkNode(node, callExpression);
+      },
+      "CallExpression > MemberExpression > Identifier[name=/^(publishReplay|shareReplay)$/]": (node) => {
+        const memberExpression = node.parent;
+        const callExpression = memberExpression.parent;
+        checkNode(node, callExpression);
       }
     };
   }
@@ -1575,7 +1596,7 @@ var noIgnoredTakewhileValueRule = ruleCreator({
 
 // src/rules/no-implicit-any-catch.ts
 import {
-  AST_NODE_TYPES as AST_NODE_TYPES6
+  AST_NODE_TYPES as AST_NODE_TYPES7
 } from "@typescript-eslint/utils";
 function isParenthesised(sourceCode, node) {
   const before = sourceCode.getTokenBefore(node);
@@ -1631,7 +1652,7 @@ var noImplicitAnyCatchRule = ruleCreator({
           const {
             typeAnnotation: { type }
           } = typeAnnotation;
-          if (type === AST_NODE_TYPES6.TSAnyKeyword) {
+          if (type === AST_NODE_TYPES7.TSAnyKeyword) {
             let fix2 = function(fixer) {
               return fixer.replaceText(typeAnnotation, ": unknown");
             };
@@ -1650,7 +1671,7 @@ var noImplicitAnyCatchRule = ruleCreator({
                 }
               ]
             });
-          } else if (type !== AST_NODE_TYPES6.TSUnknownKeyword) {
+          } else if (type !== AST_NODE_TYPES7.TSUnknownKeyword) {
             let fix2 = function(fixer) {
               return fixer.replaceText(typeAnnotation, ": unknown");
             };
@@ -1945,7 +1966,7 @@ function isExpressionObserver(expressionStatement, couldBeType2) {
 }
 
 // src/rules/no-sharereplay.ts
-import { AST_NODE_TYPES as AST_NODE_TYPES7 } from "@typescript-eslint/utils";
+import { AST_NODE_TYPES as AST_NODE_TYPES8 } from "@typescript-eslint/utils";
 var defaultOptions7 = [];
 var noSharereplayRule = ruleCreator({
   defaultOptions: defaultOptions7,
@@ -1976,7 +1997,7 @@ var noSharereplayRule = ruleCreator({
       "CallExpression[callee.name='shareReplay']": (node) => {
         let report = true;
         if (allowConfig) {
-          report = node.arguments.length !== 1 || node.arguments[0].type !== AST_NODE_TYPES7.ObjectExpression;
+          report = node.arguments.length !== 1 || node.arguments[0].type !== AST_NODE_TYPES8.ObjectExpression;
         }
         if (report) {
           context.report({
@@ -2780,7 +2801,7 @@ function isValidArgText(argText) {
 }
 
 // src/rules/suffix-subjects.ts
-import { AST_NODE_TYPES as AST_NODE_TYPES8, ESLintUtils as ESLintUtils5 } from "@typescript-eslint/utils";
+import { AST_NODE_TYPES as AST_NODE_TYPES9, ESLintUtils as ESLintUtils5 } from "@typescript-eslint/utils";
 var defaultOptions13 = [];
 var suffixSubjectsRule = ruleCreator({
   defaultOptions: defaultOptions13,
@@ -2864,7 +2885,7 @@ var suffixSubjectsRule = ruleCreator({
         if (!found) {
           return;
         }
-        if (!validate.variables && found.type === AST_NODE_TYPES8.VariableDeclarator) {
+        if (!validate.variables && found.type === AST_NODE_TYPES9.VariableDeclarator) {
           return;
         }
         if (!validate.parameters) {
@@ -2931,7 +2952,7 @@ var suffixSubjectsRule = ruleCreator({
         if (!found) {
           return;
         }
-        if (!validate.variables && found.type === AST_NODE_TYPES8.VariableDeclarator) {
+        if (!validate.variables && found.type === AST_NODE_TYPES9.VariableDeclarator) {
           return;
         }
         if (!validate.parameters) {

package/docs/rules/macro.md

@@ -1,7 +1,11 @@
 # Require the use of the RxJS Tools Babel macro (`rxjs-x/macro`)
 
+❌ This rule is deprecated.
+
 🔧 This rule is automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/latest/user-guide/command-line-interface#--fix).
 
 <!-- end auto-generated rule header -->
 
 This rule ensures that modules that import `rxjs` also import the Babel macro for [RxJS Tools](https://rxjs.tools).
+
+This rule is deprecated because [`babel-plugin-rxjs-tools`](https://www.npmjs.com/package/babel-plugin-rxjs-tools) is unmaintained.

package/docs/rules/no-exposed-subjects.md

@@ -4,7 +4,7 @@
 
 <!-- end auto-generated rule header -->
 
-This rule prevents exposed (i.e. non-private) subjects. Developers should instead expose observables via the subjects' `toObservable` method.
+This rule prevents exposed (i.e. non-private) subjects. Developers should instead expose observables via the subjects' `asObservable` method.
 
 ## Rule details
 
@@ -24,7 +24,7 @@ import { Subject } from "rxjs";
 class Answers {
   private _answers: Subject<string>;
   get answers() {
-    return this._answers.toObservable();
+    return this._answers.asObservable();
   }
 }
 ```

package/docs/rules/no-ignored-replay-buffer.md

@@ -15,6 +15,11 @@ import { ReplaySubject } from "rxjs";
 const subject = new ReplaySubject<number>();
 ```
 
+```ts
+import { of, shareReplay } from "rxjs";
+of(42).pipe(shareReplay({ refCount: true }));
+```
+
 Examples of **correct** code for this rule:
 
 ```ts
@@ -26,3 +31,8 @@ const subject = new ReplaySubject<number>(1);
 import { ReplaySubject } from "rxjs";
 const subject = new ReplaySubject<number>(Infinity);
 ```
+
+```ts
+import { of, shareReplay } from "rxjs";
+of(42).pipe(shareReplay({ refCount: true, bufferSize: 1 }));
+```

package/docs/rules/no-nested-subscribe.md

@@ -24,9 +24,9 @@ Examples of **correct** code for this rule:
 
 ```ts
 import { of, timer } from "rxjs";
-import { mapTo, mergeMap } from "rxjs/operators";
+import { map, mergeMap } from "rxjs/operators";
 
 of(42, 54).pipe(
-  mergeMap((value) => timer(1e3).pipe(mapTo(value)))
+  mergeMap((value) => timer(1e3).pipe(map(() => value)))
 ).subscribe((value) => console.log(value));
 ```

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "eslint-plugin-rxjs-x",
   "type": "commonjs",
-  "version": "0.2.2",
+  "version": "0.2.4",
   "packageManager": "yarn@4.5.1+sha512.341db9396b6e289fecc30cd7ab3af65060e05ebff4b3b47547b278b9e67b08f485ecd8c79006b405446262142c7a38154445ef7f17c1d5d1de7d90bf9ce7054d",
   "description": "ESLint v9+ plugin for RxJS",
   "author": "Jason Weinzierl <weinzierljason@gmail.com>",
@@ -65,11 +65,16 @@
     "rxjs": ">=7.0.0",
     "typescript": ">=4.7.4"
   },
+  "peerDependenciesMeta": {
+    "rxjs": {
+      "optional": true
+    }
+  },
   "devDependencies": {
     "@eslint/js": "^9.14.0",
     "@stylistic/eslint-plugin": "^2.10.1",
     "@types/common-tags": "^1.8.4",
-    "@types/node": "^18.18.0",
+    "@types/node": "~18.18.0",
     "@typescript-eslint/rule-tester": "^8.13.0",
     "@typescript/vfs": "^1.6.0",
     "@vitest/coverage-v8": "^2.1.4",
@@ -83,7 +88,7 @@
     "eslint-plugin-import-x": "^4.4.0",
     "eslint-plugin-n": "^17.13.1",
     "markdownlint-cli2": "^0.14.0",
-    "rxjs": "^7.0.0",
+    "rxjs": "^7.8.1",
     "tsup": "^8.3.5",
     "tsx": "^4.19.2",
     "typescript": "~5.6.3",