eslint-plugin-rxjs-x 0.2.1 → 0.2.3

package/dist/index.js

@@ -1,6 +1,6 @@
 "use strict";Object.defineProperty(exports, "__esModule", {value: true}); function _interopRequireWildcard(obj) { if (obj && obj.__esModule) { return obj; } else { var newObj = {}; if (obj != null) { for (var key in obj) { if (Object.prototype.hasOwnProperty.call(obj, key)) { newObj[key] = obj[key]; } } } newObj.default = obj; return newObj; } } function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }// package.json
 var name = "eslint-plugin-rxjs-x";
-var version = "0.2.1";
+var version = "0.2.3";
 
 // src/configs/recommended.ts
 var createRecommendedConfig = (plugin2) => ({
@@ -187,7 +187,7 @@ var banOperatorsRule = ruleCreator({
 
 
 // src/etc/could-be-function.ts
-var _typescript = require('typescript'); var ts2 = _interopRequireWildcard(_typescript); var ts = _interopRequireWildcard(_typescript); var ts3 = _interopRequireWildcard(_typescript); var ts4 = _interopRequireWildcard(_typescript); var ts5 = _interopRequireWildcard(_typescript); var ts6 = _interopRequireWildcard(_typescript);
+var _typescript = require('typescript'); var _typescript2 = _interopRequireDefault(_typescript);
 
 // src/etc/could-be-type.ts
 var _tsapiutils = require('ts-api-utils'); var tsutils = _interopRequireWildcard(_tsapiutils); var tsutils2 = _interopRequireWildcard(_tsapiutils); var tsutils3 = _interopRequireWildcard(_tsapiutils); var tsutils4 = _interopRequireWildcard(_tsapiutils);
@@ -226,11 +226,11 @@ function couldImplement(type, name2, qualified) {
   const { symbol } = type;
   if (symbol) {
     const { valueDeclaration } = symbol;
-    if (valueDeclaration && ts.isClassDeclaration(valueDeclaration)) {
+    if (valueDeclaration && _typescript2.default.isClassDeclaration(valueDeclaration)) {
       const { heritageClauses } = valueDeclaration;
       if (heritageClauses) {
         const implemented = heritageClauses.some(
-          ({ token, types }) => token === ts.SyntaxKind.ImplementsKeyword && types.some((node) => isMatchingNode(node, name2, qualified))
+          ({ token, types }) => token === _typescript2.default.SyntaxKind.ImplementsKeyword && types.some((node) => isMatchingNode(node, name2, qualified))
         );
         if (implemented) {
           return true;
@@ -259,7 +259,7 @@ function isMatchingNode(node, name2, qualified) {
 
 // src/etc/could-be-function.ts
 function couldBeFunction(type) {
-  return type.getCallSignatures().length > 0 || couldBeType(type, "Function") || couldBeType(type, "ArrowFunction") || couldBeType(type, ts2.InternalSymbolName.Function);
+  return type.getCallSignatures().length > 0 || couldBeType(type, "Function") || couldBeType(type, "ArrowFunction") || couldBeType(type, _typescript2.default.InternalSymbolName.Function);
 }
 
 // src/etc/find-parent.ts
@@ -285,8 +285,8 @@ function findParent(node, ...args) {
 
 function getLoc(node) {
   const sourceFile = node.getSourceFile();
-  const start = ts3.getLineAndCharacterOfPosition(sourceFile, node.getStart());
-  const end = ts3.getLineAndCharacterOfPosition(sourceFile, node.getEnd());
+  const start = _typescript2.default.getLineAndCharacterOfPosition(sourceFile, node.getStart());
+  const end = _typescript2.default.getLineAndCharacterOfPosition(sourceFile, node.getEnd());
   return {
     start: {
       line: start.line + 1,
@@ -369,9 +369,9 @@ function getTypeServices(context) {
     var _a;
     let tsTypeNode;
     const tsNode = esTreeNodeToTSNodeMap.get(node);
-    if (ts4.isArrowFunction(tsNode) || ts4.isFunctionDeclaration(tsNode) || ts4.isMethodDeclaration(tsNode) || ts4.isFunctionExpression(tsNode)) {
+    if (_typescript2.default.isArrowFunction(tsNode) || _typescript2.default.isFunctionDeclaration(tsNode) || _typescript2.default.isMethodDeclaration(tsNode) || _typescript2.default.isFunctionExpression(tsNode)) {
       tsTypeNode = (_a = tsNode.type) != null ? _a : tsNode.body;
-    } else if (ts4.isCallSignatureDeclaration(tsNode) || ts4.isMethodSignature(tsNode)) {
+    } else if (_typescript2.default.isCallSignatureDeclaration(tsNode) || _typescript2.default.isMethodSignature(tsNode)) {
       tsTypeNode = tsNode.type;
     }
     return Boolean(
@@ -969,7 +969,7 @@ var noCyclicActionRule = ruleCreator({
       const operatorType = getType(operatorCallExpression);
       const [signature] = typeChecker.getSignaturesOfType(
         operatorType,
-        ts5.SignatureKind.Call
+        _typescript2.default.SignatureKind.Call
       );
       if (!signature) {
         return;
@@ -1412,6 +1412,7 @@ var noIgnoredObservableRule = ruleCreator({
 });
 
 // src/rules/no-ignored-replay-buffer.ts
+
 var noIgnoredReplayBufferRule = ruleCreator({
   defaultOptions: [],
   meta: {
@@ -1427,6 +1428,14 @@ var noIgnoredReplayBufferRule = ruleCreator({
   },
   name: "no-ignored-replay-buffer",
   create: (context) => {
+    function checkShareReplayConfig(node, shareReplayConfigArg) {
+      if (!shareReplayConfigArg.properties.some((p) => p.type === _utils.AST_NODE_TYPES.Property && p.key.type === _utils.AST_NODE_TYPES.Identifier && p.key.name === "bufferSize")) {
+        context.report({
+          messageId: "forbidden",
+          node
+        });
+      }
+    }
     function checkNode(node, { arguments: args }) {
       if (!args || args.length === 0) {
         context.report({
@@ -1434,6 +1443,12 @@ var noIgnoredReplayBufferRule = ruleCreator({
           node
         });
       }
+      if (node.name === "shareReplay" && (args == null ? void 0 : args.length) === 1) {
+        const arg = args[0];
+        if (arg.type === _utils.AST_NODE_TYPES.ObjectExpression) {
+          checkShareReplayConfig(node, arg);
+        }
+      }
     }
     return {
       "NewExpression > Identifier[name='ReplaySubject']": (node) => {
@@ -1448,6 +1463,11 @@ var noIgnoredReplayBufferRule = ruleCreator({
       "CallExpression > Identifier[name=/^(publishReplay|shareReplay)$/]": (node) => {
         const callExpression = node.parent;
         checkNode(node, callExpression);
+      },
+      "CallExpression > MemberExpression > Identifier[name=/^(publishReplay|shareReplay)$/]": (node) => {
+        const memberExpression = node.parent;
+        const callExpression = memberExpression.parent;
+        checkNode(node, callExpression);
       }
     };
   }
@@ -2424,17 +2444,17 @@ var noUnsafeSubjectNext = ruleCreator({
           const type = getType(node.callee.object);
           if (tsutils3.isTypeReference(type) && couldBeType(type, "Subject")) {
             const [typeArg] = typeChecker.getTypeArguments(type);
-            if (tsutils3.isTypeFlagSet(typeArg, ts6.TypeFlags.Any)) {
+            if (tsutils3.isTypeFlagSet(typeArg, _typescript2.default.TypeFlags.Any)) {
               return;
             }
-            if (tsutils3.isTypeFlagSet(typeArg, ts6.TypeFlags.Unknown)) {
+            if (tsutils3.isTypeFlagSet(typeArg, _typescript2.default.TypeFlags.Unknown)) {
               return;
             }
-            if (tsutils3.isTypeFlagSet(typeArg, ts6.TypeFlags.Void)) {
+            if (tsutils3.isTypeFlagSet(typeArg, _typescript2.default.TypeFlags.Void)) {
               return;
             }
             if (tsutils3.isUnionType(typeArg) && typeArg.types.some(
-              (t) => tsutils3.isTypeFlagSet(t, ts6.TypeFlags.Void)
+              (t) => tsutils3.isTypeFlagSet(t, _typescript2.default.TypeFlags.Void)
             )) {
               return;
             }

package/dist/index.mjs

@@ -1,6 +1,6 @@
 // package.json
 var name = "eslint-plugin-rxjs-x";
-var version = "0.2.1";
+var version = "0.2.3";
 
 // src/configs/recommended.ts
 var createRecommendedConfig = (plugin2) => ({
@@ -187,11 +187,11 @@ var banOperatorsRule = ruleCreator({
 import { AST_NODE_TYPES as AST_NODE_TYPES5, ESLintUtils as ESLintUtils3 } from "@typescript-eslint/utils";
 
 // src/etc/could-be-function.ts
-import * as ts2 from "typescript";
+import ts2 from "typescript";
 
 // src/etc/could-be-type.ts
 import * as tsutils from "ts-api-utils";
-import * as ts from "typescript";
+import ts from "typescript";
 function couldBeType(type, name2, qualified) {
   if (tsutils.isTypeReference(type)) {
     type = type.target;
@@ -282,7 +282,7 @@ function findParent(node, ...args) {
 }
 
 // src/etc/get-loc.ts
-import * as ts3 from "typescript";
+import ts3 from "typescript";
 function getLoc(node) {
   const sourceFile = node.getSourceFile();
   const start = ts3.getLineAndCharacterOfPosition(sourceFile, node.getStart());
@@ -302,7 +302,7 @@ function getLoc(node) {
 // src/etc/get-type-services.ts
 import { ESLintUtils as ESLintUtils2 } from "@typescript-eslint/utils";
 import * as tsutils2 from "ts-api-utils";
-import * as ts4 from "typescript";
+import ts4 from "typescript";
 
 // src/etc/is.ts
 import { AST_NODE_TYPES as AST_NODE_TYPES3 } from "@typescript-eslint/utils";
@@ -920,7 +920,7 @@ var noCreateRule = ruleCreator({
 
 // src/rules/no-cyclic-action.ts
 import { stripIndent as stripIndent3 } from "common-tags";
-import * as ts5 from "typescript";
+import ts5 from "typescript";
 
 // src/constants.ts
 var defaultObservable = String.raw`[Aa]ction(s|s\$|\$)$`;
@@ -1412,6 +1412,7 @@ var noIgnoredObservableRule = ruleCreator({
 });
 
 // src/rules/no-ignored-replay-buffer.ts
+import { AST_NODE_TYPES as AST_NODE_TYPES6 } from "@typescript-eslint/utils";
 var noIgnoredReplayBufferRule = ruleCreator({
   defaultOptions: [],
   meta: {
@@ -1427,6 +1428,14 @@ var noIgnoredReplayBufferRule = ruleCreator({
   },
   name: "no-ignored-replay-buffer",
   create: (context) => {
+    function checkShareReplayConfig(node, shareReplayConfigArg) {
+      if (!shareReplayConfigArg.properties.some((p) => p.type === AST_NODE_TYPES6.Property && p.key.type === AST_NODE_TYPES6.Identifier && p.key.name === "bufferSize")) {
+        context.report({
+          messageId: "forbidden",
+          node
+        });
+      }
+    }
     function checkNode(node, { arguments: args }) {
       if (!args || args.length === 0) {
         context.report({
@@ -1434,6 +1443,12 @@ var noIgnoredReplayBufferRule = ruleCreator({
           node
         });
       }
+      if (node.name === "shareReplay" && (args == null ? void 0 : args.length) === 1) {
+        const arg = args[0];
+        if (arg.type === AST_NODE_TYPES6.ObjectExpression) {
+          checkShareReplayConfig(node, arg);
+        }
+      }
     }
     return {
       "NewExpression > Identifier[name='ReplaySubject']": (node) => {
@@ -1448,6 +1463,11 @@ var noIgnoredReplayBufferRule = ruleCreator({
       "CallExpression > Identifier[name=/^(publishReplay|shareReplay)$/]": (node) => {
         const callExpression = node.parent;
         checkNode(node, callExpression);
+      },
+      "CallExpression > MemberExpression > Identifier[name=/^(publishReplay|shareReplay)$/]": (node) => {
+        const memberExpression = node.parent;
+        const callExpression = memberExpression.parent;
+        checkNode(node, callExpression);
       }
     };
   }
@@ -1575,7 +1595,7 @@ var noIgnoredTakewhileValueRule = ruleCreator({
 
 // src/rules/no-implicit-any-catch.ts
 import {
-  AST_NODE_TYPES as AST_NODE_TYPES6
+  AST_NODE_TYPES as AST_NODE_TYPES7
 } from "@typescript-eslint/utils";
 function isParenthesised(sourceCode, node) {
   const before = sourceCode.getTokenBefore(node);
@@ -1631,7 +1651,7 @@ var noImplicitAnyCatchRule = ruleCreator({
           const {
             typeAnnotation: { type }
           } = typeAnnotation;
-          if (type === AST_NODE_TYPES6.TSAnyKeyword) {
+          if (type === AST_NODE_TYPES7.TSAnyKeyword) {
             let fix2 = function(fixer) {
               return fixer.replaceText(typeAnnotation, ": unknown");
             };
@@ -1650,7 +1670,7 @@ var noImplicitAnyCatchRule = ruleCreator({
                 }
               ]
             });
-          } else if (type !== AST_NODE_TYPES6.TSUnknownKeyword) {
+          } else if (type !== AST_NODE_TYPES7.TSUnknownKeyword) {
             let fix2 = function(fixer) {
               return fixer.replaceText(typeAnnotation, ": unknown");
             };
@@ -1945,7 +1965,7 @@ function isExpressionObserver(expressionStatement, couldBeType2) {
 }
 
 // src/rules/no-sharereplay.ts
-import { AST_NODE_TYPES as AST_NODE_TYPES7 } from "@typescript-eslint/utils";
+import { AST_NODE_TYPES as AST_NODE_TYPES8 } from "@typescript-eslint/utils";
 var defaultOptions7 = [];
 var noSharereplayRule = ruleCreator({
   defaultOptions: defaultOptions7,
@@ -1976,7 +1996,7 @@ var noSharereplayRule = ruleCreator({
       "CallExpression[callee.name='shareReplay']": (node) => {
         let report = true;
         if (allowConfig) {
-          report = node.arguments.length !== 1 || node.arguments[0].type !== AST_NODE_TYPES7.ObjectExpression;
+          report = node.arguments.length !== 1 || node.arguments[0].type !== AST_NODE_TYPES8.ObjectExpression;
         }
         if (report) {
           context.report({
@@ -2400,7 +2420,7 @@ var noUnsafeFirstRule = ruleCreator({
 
 // src/rules/no-unsafe-subject-next.ts
 import * as tsutils3 from "ts-api-utils";
-import * as ts6 from "typescript";
+import ts6 from "typescript";
 var noUnsafeSubjectNext = ruleCreator({
   defaultOptions: [],
   meta: {
@@ -2780,7 +2800,7 @@ function isValidArgText(argText) {
 }
 
 // src/rules/suffix-subjects.ts
-import { AST_NODE_TYPES as AST_NODE_TYPES8, ESLintUtils as ESLintUtils5 } from "@typescript-eslint/utils";
+import { AST_NODE_TYPES as AST_NODE_TYPES9, ESLintUtils as ESLintUtils5 } from "@typescript-eslint/utils";
 var defaultOptions13 = [];
 var suffixSubjectsRule = ruleCreator({
   defaultOptions: defaultOptions13,
@@ -2864,7 +2884,7 @@ var suffixSubjectsRule = ruleCreator({
         if (!found) {
           return;
         }
-        if (!validate.variables && found.type === AST_NODE_TYPES8.VariableDeclarator) {
+        if (!validate.variables && found.type === AST_NODE_TYPES9.VariableDeclarator) {
           return;
         }
         if (!validate.parameters) {
@@ -2931,7 +2951,7 @@ var suffixSubjectsRule = ruleCreator({
         if (!found) {
           return;
         }
-        if (!validate.variables && found.type === AST_NODE_TYPES8.VariableDeclarator) {
+        if (!validate.variables && found.type === AST_NODE_TYPES9.VariableDeclarator) {
           return;
         }
         if (!validate.parameters) {

package/docs/rules/no-ignored-replay-buffer.md

@@ -15,6 +15,11 @@ import { ReplaySubject } from "rxjs";
 const subject = new ReplaySubject<number>();
 ```
 
+```ts
+import { of, shareReplay } from "rxjs";
+of(42).pipe(shareReplay({ refCount: true }));
+```
+
 Examples of **correct** code for this rule:
 
 ```ts
@@ -26,3 +31,8 @@ const subject = new ReplaySubject<number>(1);
 import { ReplaySubject } from "rxjs";
 const subject = new ReplaySubject<number>(Infinity);
 ```
+
+```ts
+import { of, shareReplay } from "rxjs";
+of(42).pipe(shareReplay({ refCount: true, bufferSize: 1 }));
+```

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "eslint-plugin-rxjs-x",
   "type": "commonjs",
-  "version": "0.2.1",
+  "version": "0.2.3",
   "packageManager": "yarn@4.5.1+sha512.341db9396b6e289fecc30cd7ab3af65060e05ebff4b3b47547b278b9e67b08f485ecd8c79006b405446262142c7a38154445ef7f17c1d5d1de7d90bf9ce7054d",
   "description": "ESLint v9+ plugin for RxJS",
   "author": "Jason Weinzierl <weinzierljason@gmail.com>",
@@ -63,13 +63,18 @@
   "peerDependencies": {
     "eslint": "^8.57.0 || ^9.0.0",
     "rxjs": ">=7.0.0",
-    "typescript": ">=4.2.0"
+    "typescript": ">=4.7.4"
+  },
+  "peerDependenciesMeta": {
+    "rxjs": {
+      "optional": true
+    }
   },
   "devDependencies": {
     "@eslint/js": "^9.14.0",
     "@stylistic/eslint-plugin": "^2.10.1",
     "@types/common-tags": "^1.8.4",
-    "@types/node": "^18.18.0",
+    "@types/node": "~18.18.0",
     "@typescript-eslint/rule-tester": "^8.13.0",
     "@typescript/vfs": "^1.6.0",
     "@vitest/coverage-v8": "^2.1.4",
@@ -83,7 +88,7 @@
     "eslint-plugin-import-x": "^4.4.0",
     "eslint-plugin-n": "^17.13.1",
     "markdownlint-cli2": "^0.14.0",
-    "rxjs": "^7.0.0",
+    "rxjs": "^7.8.1",
     "tsup": "^8.3.5",
     "tsx": "^4.19.2",
     "typescript": "~5.6.3",