eslint-plugin-rxjs-x 0.2.0 → 0.2.2

package/README.md

@@ -17,7 +17,7 @@ Almost all of these rules require the TypeScript parser for ESLint and are indic
 
 See [typescript-eslint's Getting Started](https://typescript-eslint.io/getting-started) for a full ESLint setup guide.
 
-Then use the `recommended` configuration in your `eslint.config.mjs`:
+Then use the `recommended` configuration in your `eslint.config.mjs` and enable typed linting:
 
 ```js
 // @ts-check
@@ -26,6 +26,7 @@ import rxjsX from 'eslint-plugin-rxjs-x';
 
 export default tseslint.config({
     extends: [
+        ...tseslint.configs.recommended,
         rxjsX.configs.recommended,
     ],
     languageOptions: {
@@ -36,6 +37,10 @@ export default tseslint.config({
 });
 ```
 
+The above example uses `typescript-eslint`'s built-in config to set up the TypeScript parser for us.
+Enabling `projectService` then turns on typed linting.
+See [Linting with Type Information](https://typescript-eslint.io/getting-started/typed-linting/) for details.
+
 ## Configs
 
 <!-- begin auto-generated configs list -->

package/dist/index.js

@@ -1,6 +1,6 @@
 "use strict";Object.defineProperty(exports, "__esModule", {value: true}); function _interopRequireWildcard(obj) { if (obj && obj.__esModule) { return obj; } else { var newObj = {}; if (obj != null) { for (var key in obj) { if (Object.prototype.hasOwnProperty.call(obj, key)) { newObj[key] = obj[key]; } } } newObj.default = obj; return newObj; } } function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { default: obj }; }// package.json
 var name = "eslint-plugin-rxjs-x";
-var version = "0.2.0";
+var version = "0.2.2";
 
 // src/configs/recommended.ts
 var createRecommendedConfig = (plugin2) => ({
@@ -187,7 +187,7 @@ var banOperatorsRule = ruleCreator({
 
 
 // src/etc/could-be-function.ts
-var _typescript = require('typescript'); var ts2 = _interopRequireWildcard(_typescript); var ts = _interopRequireWildcard(_typescript); var ts3 = _interopRequireWildcard(_typescript); var ts4 = _interopRequireWildcard(_typescript); var ts5 = _interopRequireWildcard(_typescript); var ts6 = _interopRequireWildcard(_typescript);
+var _typescript = require('typescript'); var _typescript2 = _interopRequireDefault(_typescript);
 
 // src/etc/could-be-type.ts
 var _tsapiutils = require('ts-api-utils'); var tsutils = _interopRequireWildcard(_tsapiutils); var tsutils2 = _interopRequireWildcard(_tsapiutils); var tsutils3 = _interopRequireWildcard(_tsapiutils); var tsutils4 = _interopRequireWildcard(_tsapiutils);
@@ -226,11 +226,11 @@ function couldImplement(type, name2, qualified) {
   const { symbol } = type;
   if (symbol) {
     const { valueDeclaration } = symbol;
-    if (valueDeclaration && ts.isClassDeclaration(valueDeclaration)) {
+    if (valueDeclaration && _typescript2.default.isClassDeclaration(valueDeclaration)) {
       const { heritageClauses } = valueDeclaration;
       if (heritageClauses) {
         const implemented = heritageClauses.some(
-          ({ token, types }) => token === ts.SyntaxKind.ImplementsKeyword && types.some((node) => isMatchingNode(node, name2, qualified))
+          ({ token, types }) => token === _typescript2.default.SyntaxKind.ImplementsKeyword && types.some((node) => isMatchingNode(node, name2, qualified))
         );
         if (implemented) {
           return true;
@@ -259,7 +259,7 @@ function isMatchingNode(node, name2, qualified) {
 
 // src/etc/could-be-function.ts
 function couldBeFunction(type) {
-  return type.getCallSignatures().length > 0 || couldBeType(type, "Function") || couldBeType(type, "ArrowFunction") || couldBeType(type, ts2.InternalSymbolName.Function);
+  return type.getCallSignatures().length > 0 || couldBeType(type, "Function") || couldBeType(type, "ArrowFunction") || couldBeType(type, _typescript2.default.InternalSymbolName.Function);
 }
 
 // src/etc/find-parent.ts
@@ -285,8 +285,8 @@ function findParent(node, ...args) {
 
 function getLoc(node) {
   const sourceFile = node.getSourceFile();
-  const start = ts3.getLineAndCharacterOfPosition(sourceFile, node.getStart());
-  const end = ts3.getLineAndCharacterOfPosition(sourceFile, node.getEnd());
+  const start = _typescript2.default.getLineAndCharacterOfPosition(sourceFile, node.getStart());
+  const end = _typescript2.default.getLineAndCharacterOfPosition(sourceFile, node.getEnd());
   return {
     start: {
       line: start.line + 1,
@@ -369,9 +369,9 @@ function getTypeServices(context) {
     var _a;
     let tsTypeNode;
     const tsNode = esTreeNodeToTSNodeMap.get(node);
-    if (ts4.isArrowFunction(tsNode) || ts4.isFunctionDeclaration(tsNode) || ts4.isMethodDeclaration(tsNode) || ts4.isFunctionExpression(tsNode)) {
+    if (_typescript2.default.isArrowFunction(tsNode) || _typescript2.default.isFunctionDeclaration(tsNode) || _typescript2.default.isMethodDeclaration(tsNode) || _typescript2.default.isFunctionExpression(tsNode)) {
       tsTypeNode = (_a = tsNode.type) != null ? _a : tsNode.body;
-    } else if (ts4.isCallSignatureDeclaration(tsNode) || ts4.isMethodSignature(tsNode)) {
+    } else if (_typescript2.default.isCallSignatureDeclaration(tsNode) || _typescript2.default.isMethodSignature(tsNode)) {
       tsTypeNode = tsNode.type;
     }
     return Boolean(
@@ -518,7 +518,7 @@ var finnishRule = ruleCreator({
         });
       } : () => {
       };
-      if (couldBeObservable(typeNode || nameNode) || couldReturnObservable(typeNode || nameNode)) {
+      if (couldBeObservable(typeNode != null ? typeNode : nameNode) || couldReturnObservable(typeNode != null ? typeNode : nameNode)) {
         for (const name2 of names) {
           const { regExp, validate: validate2 } = name2;
           if (regExp.test(text) && !validate2) {
@@ -528,7 +528,7 @@ var finnishRule = ruleCreator({
         }
         for (const type of types) {
           const { regExp, validate: validate2 } = type;
-          if ((couldBeType2(typeNode || nameNode, regExp) || couldReturnType(typeNode || nameNode, regExp)) && !validate2) {
+          if ((couldBeType2(typeNode != null ? typeNode : nameNode, regExp) || couldReturnType(typeNode != null ? typeNode : nameNode, regExp)) && !validate2) {
             shouldNotBeFinnish();
             return;
           }
@@ -969,7 +969,7 @@ var noCyclicActionRule = ruleCreator({
       const operatorType = getType(operatorCallExpression);
       const [signature] = typeChecker.getSignaturesOfType(
         operatorType,
-        ts5.SignatureKind.Call
+        _typescript2.default.SignatureKind.Call
       );
       if (!signature) {
         return;
@@ -1201,7 +1201,7 @@ var noFinnishRule = ruleCreator({
     const { esTreeNodeToTSNodeMap } = _utils.ESLintUtils.getParserServices(context);
     const { couldBeObservable, couldReturnObservable } = getTypeServices(context);
     function checkNode(nameNode, typeNode) {
-      if (couldBeObservable(typeNode || nameNode) || couldReturnObservable(typeNode || nameNode)) {
+      if (couldBeObservable(typeNode != null ? typeNode : nameNode) || couldReturnObservable(typeNode != null ? typeNode : nameNode)) {
         const tsNode = esTreeNodeToTSNodeMap.get(nameNode);
         if (/[$]+$/.test(tsNode.getText())) {
           context.report({
@@ -2424,17 +2424,17 @@ var noUnsafeSubjectNext = ruleCreator({
           const type = getType(node.callee.object);
           if (tsutils3.isTypeReference(type) && couldBeType(type, "Subject")) {
             const [typeArg] = typeChecker.getTypeArguments(type);
-            if (tsutils3.isTypeFlagSet(typeArg, ts6.TypeFlags.Any)) {
+            if (tsutils3.isTypeFlagSet(typeArg, _typescript2.default.TypeFlags.Any)) {
               return;
             }
-            if (tsutils3.isTypeFlagSet(typeArg, ts6.TypeFlags.Unknown)) {
+            if (tsutils3.isTypeFlagSet(typeArg, _typescript2.default.TypeFlags.Unknown)) {
               return;
             }
-            if (tsutils3.isTypeFlagSet(typeArg, ts6.TypeFlags.Void)) {
+            if (tsutils3.isTypeFlagSet(typeArg, _typescript2.default.TypeFlags.Void)) {
               return;
             }
             if (tsutils3.isUnionType(typeArg) && typeArg.types.some(
-              (t) => tsutils3.isTypeFlagSet(t, ts6.TypeFlags.Void)
+              (t) => tsutils3.isTypeFlagSet(t, _typescript2.default.TypeFlags.Void)
             )) {
               return;
             }
@@ -2838,10 +2838,10 @@ var suffixSubjectsRule = ruleCreator({
     function checkNode(nameNode, typeNode) {
       const tsNode = esTreeNodeToTSNodeMap.get(nameNode);
       const text = tsNode.getText();
-      if (!suffixRegex.test(text) && couldBeType2(typeNode || nameNode, "Subject")) {
+      if (!suffixRegex.test(text) && couldBeType2(typeNode != null ? typeNode : nameNode, "Subject")) {
         for (const type of types) {
           const { regExp, validate: validate2 } = type;
-          if (couldBeType2(typeNode || nameNode, regExp) && !validate2) {
+          if (couldBeType2(typeNode != null ? typeNode : nameNode, regExp) && !validate2) {
             return;
           }
         }

package/dist/index.mjs

@@ -1,6 +1,6 @@
 // package.json
 var name = "eslint-plugin-rxjs-x";
-var version = "0.2.0";
+var version = "0.2.2";
 
 // src/configs/recommended.ts
 var createRecommendedConfig = (plugin2) => ({
@@ -187,11 +187,11 @@ var banOperatorsRule = ruleCreator({
 import { AST_NODE_TYPES as AST_NODE_TYPES5, ESLintUtils as ESLintUtils3 } from "@typescript-eslint/utils";
 
 // src/etc/could-be-function.ts
-import * as ts2 from "typescript";
+import ts2 from "typescript";
 
 // src/etc/could-be-type.ts
 import * as tsutils from "ts-api-utils";
-import * as ts from "typescript";
+import ts from "typescript";
 function couldBeType(type, name2, qualified) {
   if (tsutils.isTypeReference(type)) {
     type = type.target;
@@ -282,7 +282,7 @@ function findParent(node, ...args) {
 }
 
 // src/etc/get-loc.ts
-import * as ts3 from "typescript";
+import ts3 from "typescript";
 function getLoc(node) {
   const sourceFile = node.getSourceFile();
   const start = ts3.getLineAndCharacterOfPosition(sourceFile, node.getStart());
@@ -302,7 +302,7 @@ function getLoc(node) {
 // src/etc/get-type-services.ts
 import { ESLintUtils as ESLintUtils2 } from "@typescript-eslint/utils";
 import * as tsutils2 from "ts-api-utils";
-import * as ts4 from "typescript";
+import ts4 from "typescript";
 
 // src/etc/is.ts
 import { AST_NODE_TYPES as AST_NODE_TYPES3 } from "@typescript-eslint/utils";
@@ -518,7 +518,7 @@ var finnishRule = ruleCreator({
         });
       } : () => {
       };
-      if (couldBeObservable(typeNode || nameNode) || couldReturnObservable(typeNode || nameNode)) {
+      if (couldBeObservable(typeNode != null ? typeNode : nameNode) || couldReturnObservable(typeNode != null ? typeNode : nameNode)) {
         for (const name2 of names) {
           const { regExp, validate: validate2 } = name2;
           if (regExp.test(text) && !validate2) {
@@ -528,7 +528,7 @@ var finnishRule = ruleCreator({
         }
         for (const type of types) {
           const { regExp, validate: validate2 } = type;
-          if ((couldBeType2(typeNode || nameNode, regExp) || couldReturnType(typeNode || nameNode, regExp)) && !validate2) {
+          if ((couldBeType2(typeNode != null ? typeNode : nameNode, regExp) || couldReturnType(typeNode != null ? typeNode : nameNode, regExp)) && !validate2) {
             shouldNotBeFinnish();
             return;
           }
@@ -920,7 +920,7 @@ var noCreateRule = ruleCreator({
 
 // src/rules/no-cyclic-action.ts
 import { stripIndent as stripIndent3 } from "common-tags";
-import * as ts5 from "typescript";
+import ts5 from "typescript";
 
 // src/constants.ts
 var defaultObservable = String.raw`[Aa]ction(s|s\$|\$)$`;
@@ -1201,7 +1201,7 @@ var noFinnishRule = ruleCreator({
     const { esTreeNodeToTSNodeMap } = ESLintUtils4.getParserServices(context);
     const { couldBeObservable, couldReturnObservable } = getTypeServices(context);
     function checkNode(nameNode, typeNode) {
-      if (couldBeObservable(typeNode || nameNode) || couldReturnObservable(typeNode || nameNode)) {
+      if (couldBeObservable(typeNode != null ? typeNode : nameNode) || couldReturnObservable(typeNode != null ? typeNode : nameNode)) {
         const tsNode = esTreeNodeToTSNodeMap.get(nameNode);
         if (/[$]+$/.test(tsNode.getText())) {
           context.report({
@@ -2400,7 +2400,7 @@ var noUnsafeFirstRule = ruleCreator({
 
 // src/rules/no-unsafe-subject-next.ts
 import * as tsutils3 from "ts-api-utils";
-import * as ts6 from "typescript";
+import ts6 from "typescript";
 var noUnsafeSubjectNext = ruleCreator({
   defaultOptions: [],
   meta: {
@@ -2838,10 +2838,10 @@ var suffixSubjectsRule = ruleCreator({
     function checkNode(nameNode, typeNode) {
       const tsNode = esTreeNodeToTSNodeMap.get(nameNode);
       const text = tsNode.getText();
-      if (!suffixRegex.test(text) && couldBeType2(typeNode || nameNode, "Subject")) {
+      if (!suffixRegex.test(text) && couldBeType2(typeNode != null ? typeNode : nameNode, "Subject")) {
         for (const type of types) {
           const { regExp, validate: validate2 } = type;
-          if (couldBeType2(typeNode || nameNode, regExp) && !validate2) {
+          if (couldBeType2(typeNode != null ? typeNode : nameNode, regExp) && !validate2) {
             return;
           }
         }

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "eslint-plugin-rxjs-x",
   "type": "commonjs",
-  "version": "0.2.0",
+  "version": "0.2.2",
   "packageManager": "yarn@4.5.1+sha512.341db9396b6e289fecc30cd7ab3af65060e05ebff4b3b47547b278b9e67b08f485ecd8c79006b405446262142c7a38154445ef7f17c1d5d1de7d90bf9ce7054d",
   "description": "ESLint v9+ plugin for RxJS",
   "author": "Jason Weinzierl <weinzierljason@gmail.com>",
@@ -53,8 +53,8 @@
     "typecheck": "tsc --noEmit"
   },
   "dependencies": {
-    "@typescript-eslint/scope-manager": "^8.12.2",
-    "@typescript-eslint/utils": "^8.12.2",
+    "@typescript-eslint/scope-manager": "^8.1.0",
+    "@typescript-eslint/utils": "^8.1.0",
     "common-tags": "^1.8.0",
     "decamelize": "^5.0.1",
     "ts-api-utils": "^1.3.0",
@@ -63,31 +63,31 @@
   "peerDependencies": {
     "eslint": "^8.57.0 || ^9.0.0",
     "rxjs": ">=7.0.0",
-    "typescript": ">=4.2.0"
+    "typescript": ">=4.7.4"
   },
   "devDependencies": {
-    "@eslint/js": "^9.13.0",
+    "@eslint/js": "^9.14.0",
     "@stylistic/eslint-plugin": "^2.10.1",
     "@types/common-tags": "^1.8.4",
     "@types/node": "^18.18.0",
-    "@typescript-eslint/rule-tester": "^8.12.2",
+    "@typescript-eslint/rule-tester": "^8.13.0",
     "@typescript/vfs": "^1.6.0",
     "@vitest/coverage-v8": "^2.1.4",
     "@vitest/eslint-plugin": "^1.1.7",
     "bumpp": "^9.8.0",
-    "eslint": "^9.13.0",
+    "eslint": "^9.14.0",
     "eslint-config-flat-gitignore": "^0.3.0",
     "eslint-doc-generator": "^1.7.1",
     "eslint-import-resolver-typescript": "^3.6.3",
     "eslint-plugin-eslint-plugin": "^6.3.1",
     "eslint-plugin-import-x": "^4.4.0",
-    "eslint-plugin-n": "^17.12.0",
+    "eslint-plugin-n": "^17.13.1",
     "markdownlint-cli2": "^0.14.0",
     "rxjs": "^7.0.0",
     "tsup": "^8.3.5",
     "tsx": "^4.19.2",
     "typescript": "~5.6.3",
-    "typescript-eslint": "^8.12.2",
+    "typescript-eslint": "^8.13.0",
     "vitest": "^2.1.4"
   },
   "engines": {