eslint-plugin-react-x 5.8.3 → 5.8.4-next.0

package/dist/index.js

@@ -143,7 +143,7 @@ const rules$6 = {
 //#endregion
 //#region package.json
 var name$6 = "eslint-plugin-react-x";
-var version = "5.8.3";
+var version = "5.8.4-next.0";
 
 //#endregion
 //#region src/utils/create-rule.ts
@@ -1326,8 +1326,7 @@ function identifierExistsInPattern(pattern, name) {
 		case AST_NODE_TYPES.Identifier: return pattern.name === name;
 		case AST_NODE_TYPES.ObjectPattern: return pattern.properties.some((p) => {
 			if (p.type === AST_NODE_TYPES.Property) return identifierExistsInPattern(p.value, name);
-			if (p.type === AST_NODE_TYPES.RestElement) return identifierExistsInPattern(p.argument, name);
-			return false;
+			return identifierExistsInPattern(p.argument, name);
 		});
 		case AST_NODE_TYPES.ArrayPattern: return pattern.elements.some((el) => el != null && identifierExistsInPattern(el, name));
 		case AST_NODE_TYPES.RestElement: return identifierExistsInPattern(pattern.argument, name);
@@ -1405,9 +1404,12 @@ function create$48(context) {
 		if (variable == null) return null;
 		for (const def of variable.defs) {
 			if (def.type !== DefinitionType.Parameter) continue;
-			if (def.node == null) continue;
 			let fn = def.node;
-			while (fn != null && !Check.isFunction(fn)) fn = fn.parent ?? null;
+			for (;;) {
+				if (Check.isFunction(fn)) break;
+				fn = fn.parent ?? null;
+				if (fn == null) break;
+			}
 			if (fn == null) continue;
 			const func = fn;
 			if (func.params.some((param) => identifierExistsInPattern(param, id.name))) return func;
@@ -1428,7 +1430,7 @@ function create$48(context) {
 		CallExpression(node) {
 			if (isUseStateCall(node) || core.isUseReducerCall(context, node)) {
 				const declarator = node.parent;
-				if (declarator?.type === AST_NODE_TYPES.VariableDeclarator && declarator.id?.type === AST_NODE_TYPES.ArrayPattern) {
+				if (declarator.type === AST_NODE_TYPES.VariableDeclarator && declarator.id.type === AST_NODE_TYPES.ArrayPattern) {
 					const [firstElement] = declarator.id.elements;
 					if (firstElement?.type === AST_NODE_TYPES.Identifier && isRefLikeName(firstElement.name)) context.report({
 						data: { name: firstElement.name },
@@ -3105,7 +3107,7 @@ function create$21(context) {
 				...hc.api.getAllHooks(program),
 				...cc.api.getAllComponents(program)
 			];
-			for (const lazy of lazyCalls) if (Traverse.findParent(lazy, (n) => significantParents.some((p) => p.node === n))) context.report({
+			for (const lazy of lazyCalls) if (Traverse.findParent(lazy, (n) => significantParents.some((p) => p.node === n)) != null) context.report({
 				messageId: "default",
 				node: lazy
 			});
@@ -3749,7 +3751,7 @@ function create$9(context) {
 		CallExpression(node) {
 			if (!core.isUseStateLikeCall(node, additionalStateHooks)) return;
 			const { parent } = node;
-			if (parent?.type !== AST_NODE_TYPES.VariableDeclarator || parent.id.type !== AST_NODE_TYPES.ArrayPattern) return;
+			if (parent.type !== AST_NODE_TYPES.VariableDeclarator || parent.id.type !== AST_NODE_TYPES.ArrayPattern) return;
 			const [stateEl] = parent.id.elements;
 			if (stateEl?.type !== AST_NODE_TYPES.Identifier) return;
 			stateEntries.push({
@@ -4159,7 +4161,8 @@ function create$7(context) {
 				case expr.type === AST_NODE_TYPES.Identifier: {
 					const builtinName = resolveBuiltinObjectName(context, expr);
 					if (builtinName == null) return;
-					if (!IMPURE_FUNCS.get("globalThis")?.has(builtinName)) return;
+					const globalThisImpure = IMPURE_FUNCS.get("globalThis");
+					if (globalThisImpure == null || !globalThisImpure.has(builtinName)) return;
 					const func = Traverse.findParent(node, Check.isFunction);
 					if (func == null) return;
 					cEntries.push({
@@ -4174,7 +4177,8 @@ function create$7(context) {
 					const objectName = resolveBuiltinObjectName(context, rootId);
 					if (objectName == null) return;
 					const propertyName = expr.property.name;
-					if (!IMPURE_FUNCS.get(objectName)?.has(propertyName)) return;
+					const objectImpure = IMPURE_FUNCS.get(objectName);
+					if (objectImpure == null || !objectImpure.has(propertyName)) return;
 					const func = Traverse.findParent(node, Check.isFunction);
 					if (func == null) return;
 					cEntries.push({
@@ -4238,7 +4242,7 @@ function isInNullCheckTest(node) {
 		if (!isLiteralNull(parent.left === node || Extract.unwrap(parent.left) === node ? parent.right : parent.left)) return false;
 		if (isIfTest(parent)) return true;
 		const grandparent = parent.parent;
-		if (grandparent?.type === AST_NODE_TYPES.UnaryExpression && grandparent.operator === "!" && isIfTest(grandparent)) return true;
+		if (grandparent.type === AST_NODE_TYPES.UnaryExpression && grandparent.operator === "!" && isIfTest(grandparent)) return true;
 		return false;
 	}
 	if (parent.type === AST_NODE_TYPES.UnaryExpression && parent.operator === "!") return isIfTest(parent);
@@ -4390,7 +4394,7 @@ function create$6(context) {
 				let isLazyInit = isInNullCheckTest(node);
 				if (!isLazyInit) {
 					let current = node.parent;
-					findIf: while (current != null) {
+					findIf: for (;;) {
 						if (current.type === AST_NODE_TYPES.IfStatement) {
 							if (isRefCurrentNullCheck(current.test, refName)) isLazyInit = true;
 							break;
@@ -6740,7 +6744,7 @@ function isRefInExpression(context, node) {
 * @returns The actual CallExpression node
 */
 function getSetStateCallExpression(node) {
-	return node.type === AST_NODE_TYPES.Identifier && node.parent?.type === AST_NODE_TYPES.CallExpression ? node.parent : node;
+	return node.type === AST_NODE_TYPES.Identifier && node.parent.type === AST_NODE_TYPES.CallExpression ? node.parent : node;
 }
 
 //#endregion
@@ -7174,7 +7178,7 @@ function getDynamicComponentSource(context, variable, isInsideRender, seen = /*
 			for (const ref of variable.references) {
 				if (!ref.isWrite()) continue;
 				const id = ref.identifier;
-				if (id.parent?.type === AST_NODE_TYPES.AssignmentExpression && id.parent.left === id) {
+				if (id.parent.type === AST_NODE_TYPES.AssignmentExpression && id.parent.left === id) {
 					const source = resolveDynamicValue(context, id.parent.right, isInsideRender, seen);
 					if (source != null) return {
 						creationNode: source,
@@ -7400,7 +7404,7 @@ function create$1(context) {
 			if (node.type !== AST_NODE_TYPES.AssignmentExpression) return;
 			const left = Extract.unwrap(node.left);
 			if (left.type !== AST_NODE_TYPES.Identifier) return;
-			if (Traverse.findParent(node, Check.isFunction, (n) => n === callback)) return;
+			if (Traverse.findParent(node, Check.isFunction, (n) => n === callback) != null) return;
 			const variable = findVariable(context.sourceCode.getScope(left), left);
 			if (variable != null && variable.defs.length > 0 && isDeclaredInsideCallback(variable, callback)) return;
 			violations.push({

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-x",
-  "version": "5.8.3",
+  "version": "5.8.4-next.0",
   "description": "A set of composable ESLint rules for libraries and frameworks that use React as a UI runtime.",
   "keywords": [
     "react",
@@ -45,12 +45,12 @@
     "string-ts": "^2.3.1",
     "ts-api-utils": "^2.5.0",
     "ts-pattern": "^5.9.0",
-    "@eslint-react/ast": "5.8.3",
-    "@eslint-react/core": "5.8.3",
-    "@eslint-react/eslint": "5.8.3",
-    "@eslint-react/jsx": "5.8.3",
-    "@eslint-react/shared": "5.8.3",
-    "@eslint-react/var": "5.8.3"
+    "@eslint-react/ast": "5.8.4-next.0",
+    "@eslint-react/core": "5.8.4-next.0",
+    "@eslint-react/jsx": "5.8.4-next.0",
+    "@eslint-react/shared": "5.8.4-next.0",
+    "@eslint-react/eslint": "5.8.4-next.0",
+    "@eslint-react/var": "5.8.4-next.0"
   },
   "devDependencies": {
     "@types/react": "^19.2.14",
@@ -63,8 +63,8 @@
     "tsl": "^1.0.30",
     "tsl-dx": "^0.12.1",
     "typescript": "^6.0.3",
-    "@local/configs": "0.0.0",
-    "@local/eff": "3.0.0-beta.72"
+    "@local/eff": "3.0.0-beta.72",
+    "@local/configs": "0.0.0"
   },
   "peerDependencies": {
     "eslint": "^10.3.0",