eslint-plugin-react-x 5.7.2 → 5.7.3

package/dist/index.js

@@ -143,7 +143,7 @@ const rules$6 = {
 //#endregion
 //#region package.json
 var name$6 = "eslint-plugin-react-x";
-var version = "5.7.2";
+var version = "5.7.3";
 
 //#endregion
 //#region src/utils/create-rule.ts
@@ -1279,6 +1279,46 @@ const MUTATING_ARRAY_METHODS = new Set([
 	"splice",
 	"unshift"
 ]);
+/**
+* Check if a name is ref-like ("ref" or ends with "Ref").
+* Refs are mutable by design and exempted from immutability checks.
+*/
+function isRefLikeName(name) {
+	return name === "ref" || name.endsWith("Ref");
+}
+/**
+* Check if any identifier or property name in a member-expression chain
+* is ref-like.
+*/
+function hasRefLikeNameInChain(node) {
+	if (node.type === AST_NODE_TYPES.Identifier) return isRefLikeName(node.name);
+	if (node.type === AST_NODE_TYPES.MemberExpression) {
+		const propName = Extract.getPropertyName(node.property);
+		if (propName != null && isRefLikeName(propName)) return true;
+		return hasRefLikeNameInChain(node.object);
+	}
+	return false;
+}
+/**
+* Check if `name` appears anywhere inside a parameter pattern.
+* @param pattern - The parameter pattern to search in.
+* @param name - The identifier name to look for.
+*/
+function identifierExistsInPattern(pattern, name) {
+	switch (pattern.type) {
+		case AST_NODE_TYPES.Identifier: return pattern.name === name;
+		case AST_NODE_TYPES.ObjectPattern: return pattern.properties.some((p) => {
+			if (p.type === AST_NODE_TYPES.Property) return identifierExistsInPattern(p.value, name);
+			if (p.type === AST_NODE_TYPES.RestElement) return identifierExistsInPattern(p.argument, name);
+			return false;
+		});
+		case AST_NODE_TYPES.ArrayPattern: return pattern.elements.some((el) => el != null && identifierExistsInPattern(el, name));
+		case AST_NODE_TYPES.RestElement: return identifierExistsInPattern(pattern.argument, name);
+		case AST_NODE_TYPES.AssignmentPattern: return identifierExistsInPattern(pattern.left, name);
+		case AST_NODE_TYPES.MemberExpression: return Extract.getRootIdentifier(pattern)?.name === name;
+		default: return false;
+	}
+}
 
 //#endregion
 //#region src/rules/immutability/immutability.ts
@@ -1289,7 +1329,8 @@ var immutability_default = createRule({
 		docs: { description: "Validates against mutating props, state, and other values that are immutable." },
 		messages: {
 			mutatingArrayMethod: "Do not call '{{method}}()' on '{{name}}'. Props and state are immutable — create a new array instead.",
-			mutatingAssignment: "Do not mutate '{{name}}' directly. Props and state are immutable — create a new object instead."
+			mutatingAssignment: "Do not mutate '{{name}}' directly. Props and state are immutable — create a new object instead.",
+			noRefLikeStateName: "State variable '{{name}}' should not be named 'ref' or end with 'Ref'. Use a different name to avoid confusion with mutable refs."
 		},
 		schema: []
 	},
@@ -1309,14 +1350,6 @@ function create$48(context) {
 	function isUseStateCall(node) {
 		return core.isUseStateLikeCall(node, additionalStateHooks);
 	}
-	function isUseReducerCall(node) {
-		const callee = Extract.unwrap(node.callee);
-		if (callee.type === AST_NODE_TYPES.Identifier) return callee.name === "useReducer";
-		if (callee.type === AST_NODE_TYPES.MemberExpression) {
-			if (Extract.getRootIdentifier(callee)?.name === "React") return Extract.getPropertyName(callee.property) === "useReducer";
-		}
-		return false;
-	}
 	/**
 	* Return true when `id` is the *value* variable (index 0) produced by a
 	* `useState(…)` or `useReducer(…)` call.
@@ -1326,32 +1359,12 @@ function create$48(context) {
 	function isStateValue(id) {
 		const initNode = resolve(context, id);
 		if (initNode == null || initNode.type !== AST_NODE_TYPES.CallExpression) return false;
-		if (!isUseStateCall(initNode) && !isUseReducerCall(initNode)) return false;
+		if (!isUseStateCall(initNode) && !core.isUseReducerCall(context, initNode)) return false;
 		const declarator = initNode.parent;
 		if (!("id" in declarator) || declarator.id?.type !== AST_NODE_TYPES.ArrayPattern) return true;
 		return declarator.id.elements.findIndex((el) => el?.type === AST_NODE_TYPES.Identifier && el.name === id.name) === 0;
 	}
 	/**
-	* Check if `name` appears anywhere inside a parameter pattern.
-	* @param pattern - The parameter pattern to search in.
-	* @param name - The identifier name to look for.
-	*/
-	function identifierExistsInPattern(pattern, name) {
-		switch (pattern.type) {
-			case AST_NODE_TYPES.Identifier: return pattern.name === name;
-			case AST_NODE_TYPES.ObjectPattern: return pattern.properties.some((p) => {
-				if (p.type === AST_NODE_TYPES.Property) return identifierExistsInPattern(p.value, name);
-				if (p.type === AST_NODE_TYPES.RestElement) return identifierExistsInPattern(p.argument, name);
-				return false;
-			});
-			case AST_NODE_TYPES.ArrayPattern: return pattern.elements.some((el) => el != null && identifierExistsInPattern(el, name));
-			case AST_NODE_TYPES.RestElement: return identifierExistsInPattern(pattern.argument, name);
-			case AST_NODE_TYPES.AssignmentPattern: return identifierExistsInPattern(pattern.left, name);
-			case AST_NODE_TYPES.MemberExpression: return Extract.getRootIdentifier(pattern)?.name === name;
-			default: return false;
-		}
-	}
-	/**
 	* Return the function node when `id` is a parameter of any position in any
 	* ancestor function; otherwise return `null`.
 	*
@@ -1396,6 +1409,17 @@ function create$48(context) {
 		* @param node The CallExpression node to analyze.
 		*/
 		CallExpression(node) {
+			if (isUseStateCall(node) || core.isUseReducerCall(context, node)) {
+				const declarator = node.parent;
+				if (declarator?.type === AST_NODE_TYPES.VariableDeclarator && declarator.id?.type === AST_NODE_TYPES.ArrayPattern) {
+					const [firstElement] = declarator.id.elements;
+					if (firstElement?.type === AST_NODE_TYPES.Identifier && isRefLikeName(firstElement.name)) context.report({
+						data: { name: firstElement.name },
+						messageId: "noRefLikeStateName",
+						node: firstElement
+					});
+				}
+			}
 			const callee = Extract.unwrap(node.callee);
 			if (callee.type !== AST_NODE_TYPES.MemberExpression) return;
 			const { object, property } = callee;
@@ -1404,6 +1428,7 @@ function create$48(context) {
 			const rootId = Extract.getRootIdentifier(object);
 			if (rootId == null) return;
 			if (rootId.name === "draft") return;
+			if (hasRefLikeNameInChain(object)) return;
 			const enclosingFn = Traverse.findParent(node, Check.isFunction);
 			if (enclosingFn == null) return;
 			const isState = isStateValue(rootId);
@@ -1434,6 +1459,7 @@ function create$48(context) {
 			const rootId = Extract.getRootIdentifier(node.left);
 			if (rootId == null) return;
 			if (rootId.name === "draft") return;
+			if (hasRefLikeNameInChain(node.left.object)) return;
 			const enclosingFn = Traverse.findParent(node, Check.isFunction);
 			if (enclosingFn == null) return;
 			const isState = isStateValue(rootId);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-x",
-  "version": "5.7.2",
+  "version": "5.7.3",
   "description": "A set of composable ESLint rules for libraries and frameworks that use React as a UI runtime.",
   "keywords": [
     "react",
@@ -36,21 +36,21 @@
     "dist"
   ],
   "dependencies": {
-    "@typescript-eslint/scope-manager": "^8.59.1",
-    "@typescript-eslint/type-utils": "^8.59.1",
-    "@typescript-eslint/types": "^8.59.1",
-    "@typescript-eslint/typescript-estree": "^8.59.1",
-    "@typescript-eslint/utils": "^8.59.1",
+    "@typescript-eslint/scope-manager": "^8.59.2",
+    "@typescript-eslint/type-utils": "^8.59.2",
+    "@typescript-eslint/types": "^8.59.2",
+    "@typescript-eslint/typescript-estree": "^8.59.2",
+    "@typescript-eslint/utils": "^8.59.2",
     "compare-versions": "^6.1.1",
     "string-ts": "^2.3.1",
     "ts-api-utils": "^2.5.0",
     "ts-pattern": "^5.9.0",
-    "@eslint-react/ast": "5.7.2",
-    "@eslint-react/core": "5.7.2",
-    "@eslint-react/eslint": "5.7.2",
-    "@eslint-react/jsx": "5.7.2",
-    "@eslint-react/shared": "5.7.2",
-    "@eslint-react/var": "5.7.2"
+    "@eslint-react/ast": "5.7.3",
+    "@eslint-react/eslint": "5.7.3",
+    "@eslint-react/jsx": "5.7.3",
+    "@eslint-react/shared": "5.7.3",
+    "@eslint-react/core": "5.7.3",
+    "@eslint-react/var": "5.7.3"
   },
   "devDependencies": {
     "@types/react": "^19.2.14",