eslint-plugin-react-x 5.5.2-next.0 → 5.5.3-next.0

package/dist/index.js

@@ -142,7 +142,7 @@ const rules$6 = {
 //#endregion
 //#region package.json
 var name$6 = "eslint-plugin-react-x";
-var version = "5.5.2-next.0";
+var version = "5.5.3-next.0";
 
 //#endregion
 //#region src/utils/create-rule.ts
@@ -6932,6 +6932,83 @@ function create$4(context) {
 	});
 }
 
+//#endregion
+//#region src/rules/static-components/lib.ts
+function resolveDynamicValue(context, node, isInsideRender, seen) {
+	const expr = Extract.unwrap(node);
+	switch (expr.type) {
+		case AST_NODE_TYPES.FunctionExpression:
+		case AST_NODE_TYPES.ArrowFunctionExpression:
+		case AST_NODE_TYPES.NewExpression:
+		case AST_NODE_TYPES.CallExpression:
+		case AST_NODE_TYPES.ClassExpression: return expr;
+		case AST_NODE_TYPES.ConditionalExpression: {
+			const consequent = resolveDynamicValue(context, expr.consequent, isInsideRender, seen);
+			if (consequent != null) return consequent;
+			return resolveDynamicValue(context, expr.alternate, isInsideRender, seen);
+		}
+		case AST_NODE_TYPES.Identifier:
+		case AST_NODE_TYPES.JSXIdentifier: {
+			const resolved = findVariableForIdentifier(context, expr);
+			if (resolved == null) return null;
+			return getDynamicComponentSource(context, resolved, isInsideRender, seen).creationNode;
+		}
+		default: return null;
+	}
+}
+function findVariableForIdentifier(context, identifier) {
+	let scope = context.sourceCode.getScope(identifier);
+	while (scope != null) {
+		const variable = scope.variables.find((v) => v.name === identifier.name);
+		if (variable != null) return variable;
+		scope = scope.upper;
+	}
+	return null;
+}
+function getDynamicComponentSource(context, variable, isInsideRender, seen = /* @__PURE__ */ new Set()) {
+	if (seen.has(variable)) return {
+		isDynamic: false,
+		creationNode: null
+	};
+	seen.add(variable);
+	for (const def of variable.defs) {
+		const defNode = def.node;
+		if (!isInsideRender(defNode)) continue;
+		if (defNode.type === AST_NODE_TYPES.FunctionDeclaration) return {
+			isDynamic: true,
+			creationNode: defNode
+		};
+		if (defNode.type === AST_NODE_TYPES.ClassDeclaration) return {
+			isDynamic: true,
+			creationNode: defNode
+		};
+		if (defNode.type === AST_NODE_TYPES.VariableDeclarator) {
+			if (defNode.init != null) {
+				const source = resolveDynamicValue(context, defNode.init, isInsideRender, seen);
+				if (source != null) return {
+					isDynamic: true,
+					creationNode: source
+				};
+			}
+			for (const ref of variable.references) {
+				if (!ref.isWrite()) continue;
+				const id = ref.identifier;
+				if (id.parent?.type === AST_NODE_TYPES.AssignmentExpression && id.parent.left === id) {
+					const source = resolveDynamicValue(context, id.parent.right, isInsideRender, seen);
+					if (source != null) return {
+						isDynamic: true,
+						creationNode: source
+					};
+				}
+			}
+		}
+	}
+	return {
+		isDynamic: false,
+		creationNode: null
+	};
+}
+
 //#endregion
 //#region src/rules/static-components/static-components.ts
 const RULE_NAME$3 = "static-components";
@@ -6939,51 +7016,16 @@ var static_components_default = createRule({
 	meta: {
 		type: "problem",
 		docs: { description: "Validates that components are static, not recreated every render." },
-		messages: { default: "Component '{{name}}' is created during render. Components created during render will reset their state each time they are created. Declare components outside of render." },
+		messages: {
+			default: "Cannot create components during render. Components created during render will reset their state each time they are created. Declare components outside of render.",
+			createdHere: "The component is created during render here."
+		},
 		schema: []
 	},
 	name: RULE_NAME$3,
 	create: create$3,
 	defaultOptions: []
 });
-function findVariableForJSXIdentifier(context, jsxId) {
-	let scope = context.sourceCode.getScope(jsxId);
-	while (scope != null) {
-		const variable = scope.variables.find((v) => v.name === jsxId.name);
-		if (variable != null) return variable;
-		scope = scope.upper;
-	}
-	return null;
-}
-function isDynamicallyCreatedValue(node) {
-	const expr = Extract.unwrap(node);
-	switch (expr.type) {
-		case AST_NODE_TYPES.FunctionExpression:
-		case AST_NODE_TYPES.ArrowFunctionExpression:
-		case AST_NODE_TYPES.NewExpression:
-		case AST_NODE_TYPES.CallExpression:
-		case AST_NODE_TYPES.ClassExpression: return true;
-		case AST_NODE_TYPES.ConditionalExpression: return isDynamicallyCreatedValue(expr.consequent) || isDynamicallyCreatedValue(expr.alternate);
-		default: return false;
-	}
-}
-function hasDynamicAssignment(variable) {
-	for (const ref of variable.references) {
-		if (!ref.isWrite()) continue;
-		const id = ref.identifier;
-		if (id.parent?.type === AST_NODE_TYPES.AssignmentExpression && id.parent.left === id) {
-			if (isDynamicallyCreatedValue(id.parent.right)) return true;
-		}
-	}
-	return false;
-}
-function isDynamicallyCreated(node, variable) {
-	if (node.type === AST_NODE_TYPES.FunctionDeclaration) return true;
-	if (node.type === AST_NODE_TYPES.ClassDeclaration) return true;
-	if (node.type === AST_NODE_TYPES.VariableDeclarator && node.init != null) return isDynamicallyCreatedValue(node.init);
-	if (node.type === AST_NODE_TYPES.VariableDeclarator && node.init == null && variable != null) return hasDynamicAssignment(variable);
-	return false;
-}
 function create$3(context) {
 	const hint = core.FunctionComponentDetectionHint.DoNotIncludeJsxWithNumberValue | core.FunctionComponentDetectionHint.DoNotIncludeJsxWithBooleanValue | core.FunctionComponentDetectionHint.DoNotIncludeJsxWithNullValue | core.FunctionComponentDetectionHint.DoNotIncludeJsxWithStringValue | core.FunctionComponentDetectionHint.DoNotIncludeJsxWithUndefinedValue | core.FunctionComponentDetectionHint.RequireBothSidesOfLogicalExpressionToBeJsx | core.FunctionComponentDetectionHint.RequireBothBranchesOfConditionalExpressionToBeJsx | core.FunctionComponentDetectionHint.DoNotIncludeFunctionDefinedAsArrayPatternElement | core.FunctionComponentDetectionHint.DoNotIncludeFunctionDefinedAsArrayExpressionElement | core.FunctionComponentDetectionHint.DoNotIncludeFunctionDefinedAsArrayMapCallback;
 	const fc = core.getFunctionComponentCollector(context, { hint });
@@ -7009,20 +7051,27 @@ function create$3(context) {
 					return false;
 				});
 			}
+			const isInsideRender = (node) => getEnclosingComponent(node) != null;
 			for (const { name, node: jsxNode } of jsxCandidates) {
 				const jsxName = jsxNode.name;
-				const variable = findVariableForJSXIdentifier(context, jsxName);
+				const variable = findVariableForIdentifier(context, jsxName);
 				if (variable == null || variable.defs.length === 0) continue;
 				const def = variable.defs.at(0);
 				if (def == null) continue;
 				const defNode = def.node;
 				if (getEnclosingComponent(defNode) == null) continue;
-				if (!isDynamicallyCreated(defNode, variable)) continue;
+				const result = getDynamicComponentSource(context, variable, isInsideRender);
+				if (!result.isDynamic) continue;
 				context.report({
 					data: { name },
 					messageId: "default",
 					node: jsxNode.name
 				});
+				if (result.creationNode != null) context.report({
+					data: { name },
+					messageId: "createdHere",
+					node: result.creationNode
+				});
 			}
 		}
 	});
@@ -7149,11 +7198,11 @@ var use_memo_default = createRule({
 		type: "problem",
 		docs: { description: "Validates that 'useMemo' is called with a callback that returns a value." },
 		messages: {
-			mustReturnAValue: "useMemo() callbacks must return a value. This useMemo() callback doesn't return a value. useMemo() is for computing and caching values, not for arbitrary side effects.",
-			noAsyncOrGeneratorFunctions: "useMemo() callbacks may not be async or generator functions. useMemo() callbacks are called once and must synchronously return a value.",
-			noParameters: "useMemo() callbacks may not accept parameters. useMemo() callbacks are called by React to cache calculations across re-renders. They should not take parameters. Instead, directly reference the props, state, or local variables needed for the computation.",
-			noReassigningOuterVariables: "useMemo() callbacks may not reassign variables declared outside of the callback. useMemo() callbacks must be pure functions and cannot reassign variables defined outside of the callback function.",
-			resultMustBeUsed: "useMemo() result is unused. This useMemo() value is unused. useMemo() is for computing and caching values, not for arbitrary side effects."
+			noParameters: "useMemo() callbacks may not accept parameters.\n\nuseMemo() callbacks are called by React to cache calculations across re-renders. They should not take parameters. Instead, directly reference the props, state, or local variables needed for the computation.",
+			noAsyncOrGeneratorFunctions: "useMemo() callbacks may not be async or generator functions.\n\nuseMemo() callbacks are called once and must synchronously return a value.",
+			noReassigningOuterVariables: "useMemo() callbacks may not reassign variables declared outside of the callback.\n\nuseMemo() callbacks must be pure functions and cannot reassign variables defined outside of the callback function.",
+			mustReturnAValue: "useMemo() callbacks must return a value.\n\nThis useMemo() callback doesn't return a value. useMemo() is for computing and caching values, not for arbitrary side effects.",
+			resultMustBeUsed: "useMemo() result is unused.\n\nThis useMemo() value is unused. useMemo() is for computing and caching values, not for arbitrary side effects."
 		},
 		schema: []
 	},
@@ -7185,7 +7234,7 @@ function create$1(context) {
 		if (!core.isUseMemoCall(context, node)) return;
 		let parent = node.parent;
 		while (Check.isTypeExpression(parent)) parent = parent.parent;
-		if (!(parent.type === AST_NODE_TYPES.VariableDeclarator || parent.type === AST_NODE_TYPES.AssignmentExpression || parent.type === AST_NODE_TYPES.AssignmentPattern || parent.type === AST_NODE_TYPES.Property || parent.type === AST_NODE_TYPES.ReturnStatement || parent.type === AST_NODE_TYPES.JSXExpressionContainer || parent.type === AST_NODE_TYPES.CallExpression || parent.type === AST_NODE_TYPES.NewExpression || parent.type === AST_NODE_TYPES.ArrayExpression || parent.type === AST_NODE_TYPES.ConditionalExpression || parent.type === AST_NODE_TYPES.LogicalExpression || parent.type === AST_NODE_TYPES.SequenceExpression || parent.type === AST_NODE_TYPES.SpreadElement || parent.type === AST_NODE_TYPES.TemplateLiteral || parent.type === AST_NODE_TYPES.BinaryExpression || parent.type === AST_NODE_TYPES.UnaryExpression || parent.type === AST_NODE_TYPES.MemberExpression || parent.type === AST_NODE_TYPES.TaggedTemplateExpression || parent.type === AST_NODE_TYPES.ChainExpression || parent.type === AST_NODE_TYPES.ArrowFunctionExpression)) {
+		if (!(parent.type === AST_NODE_TYPES.VariableDeclarator || parent.type === AST_NODE_TYPES.AssignmentExpression || parent.type === AST_NODE_TYPES.AssignmentPattern || parent.type === AST_NODE_TYPES.Property || parent.type === AST_NODE_TYPES.ReturnStatement || parent.type === AST_NODE_TYPES.JSXExpressionContainer || parent.type === AST_NODE_TYPES.CallExpression || parent.type === AST_NODE_TYPES.NewExpression || parent.type === AST_NODE_TYPES.ArrayExpression || parent.type === AST_NODE_TYPES.ConditionalExpression || parent.type === AST_NODE_TYPES.LogicalExpression || parent.type === AST_NODE_TYPES.SequenceExpression || parent.type === AST_NODE_TYPES.SpreadElement || parent.type === AST_NODE_TYPES.TemplateLiteral || parent.type === AST_NODE_TYPES.BinaryExpression || parent.type === AST_NODE_TYPES.UnaryExpression || parent.type === AST_NODE_TYPES.MemberExpression || parent.type === AST_NODE_TYPES.TaggedTemplateExpression || parent.type === AST_NODE_TYPES.ChainExpression || parent.type === AST_NODE_TYPES.ArrowFunctionExpression || parent.type === AST_NODE_TYPES.ForOfStatement || parent.type === AST_NODE_TYPES.ForInStatement)) {
 			context.report({
 				messageId: "resultMustBeUsed",
 				node

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-x",
-  "version": "5.5.2-next.0",
+  "version": "5.5.3-next.0",
   "description": "A set of composable ESLint rules for libraries and frameworks that use React as a UI runtime.",
   "keywords": [
     "react",
@@ -46,12 +46,12 @@
     "string-ts": "^2.3.1",
     "ts-api-utils": "^2.5.0",
     "ts-pattern": "^5.9.0",
-    "@eslint-react/core": "5.5.2-next.0",
-    "@eslint-react/eslint": "5.5.2-next.0",
-    "@eslint-react/jsx": "5.5.2-next.0",
-    "@eslint-react/shared": "5.5.2-next.0",
-    "@eslint-react/ast": "5.5.2-next.0",
-    "@eslint-react/var": "5.5.2-next.0"
+    "@eslint-react/ast": "5.5.3-next.0",
+    "@eslint-react/core": "5.5.3-next.0",
+    "@eslint-react/shared": "5.5.3-next.0",
+    "@eslint-react/jsx": "5.5.3-next.0",
+    "@eslint-react/eslint": "5.5.3-next.0",
+    "@eslint-react/var": "5.5.3-next.0"
   },
   "devDependencies": {
     "@types/react": "^19.2.14",