eslint-plugin-react-x 5.5.1-next.0 → 5.5.2-beta.0

package/dist/index.js

@@ -142,7 +142,7 @@ const rules$6 = {
 //#endregion
 //#region package.json
 var name$6 = "eslint-plugin-react-x";
-var version = "5.5.1-next.0";
+var version = "5.5.2-beta.0";
 
 //#endregion
 //#region src/utils/create-rule.ts
@@ -2726,7 +2726,7 @@ function report(context) {
 * @param node The AST node
 * @returns The nested return statements in the node
 */
-function getNestedReturnStatements(node) {
+function getNestedReturnStatements$1(node) {
 	const statements = [];
 	const boundaryNode = Check.isFunction(node) ? node : Traverse.findParent(node, Check.isFunction);
 	simpleTraverse(node, { enter(node) {
@@ -2778,7 +2778,7 @@ function create$23(context) {
 	}
 	function checkBlock(node) {
 		const descriptors = [];
-		for (const stmt of getNestedReturnStatements(node)) {
+		for (const stmt of getNestedReturnStatements$1(node)) {
 			if (stmt.argument == null) continue;
 			const desc = check(stmt.argument);
 			if (desc == null) continue;
@@ -7115,6 +7115,32 @@ function create$2(context) {
 	});
 }
 
+//#endregion
+//#region src/rules/use-memo/lib.ts
+function isInsideNestedFunction(node, boundary) {
+	let current = node.parent;
+	while (current && current !== boundary) {
+		if (Check.isFunction(current)) return true;
+		current = current.parent;
+	}
+	return false;
+}
+/**
+* Gets the nested return statements in the node that are within the same function
+* @param node The AST node
+* @returns The nested return statements in the node
+*/
+function getNestedReturnStatements(node) {
+	const statements = [];
+	const boundaryNode = Check.isFunction(node) ? node : Traverse.findParent(node, Check.isFunction);
+	simpleTraverse(node, { enter(node) {
+		if (node.type !== AST_NODE_TYPES.ReturnStatement) return;
+		if (Traverse.findParent(node, Check.isFunction) !== boundaryNode) return;
+		statements.push(node);
+	} });
+	return statements;
+}
+
 //#endregion
 //#region src/rules/use-memo/use-memo.ts
 const RULE_NAME$1 = "use-memo";
@@ -7123,10 +7149,11 @@ var use_memo_default = createRule({
 		type: "problem",
 		docs: { description: "Validates that 'useMemo' is called with a callback that returns a value." },
 		messages: {
-			asyncOrGeneratorCallback: "The callback passed to 'useMemo' must be a regular function. 'useMemo' callbacks are called synchronously by React and must immediately return a value. Async and generator functions are not supported.",
-			callbackWithParameters: "The callback passed to 'useMemo' may not accept parameters. 'useMemo' callbacks are called by React without arguments. Instead, directly reference the props, state, or local variables needed for the computation.",
-			missingReturnValue: "The callback passed to 'useMemo' must return a value. Without a return value, 'useMemo' always returns 'undefined', which defeats its purpose.",
-			notAssignedToVariable: "The return value of 'useMemo' must be assigned to a variable. Calling 'useMemo' without capturing its return value is likely a mistake — use 'useEffect' for side effects instead."
+			mustReturnAValue: "useMemo() callbacks must return a value. This useMemo() callback doesn't return a value. useMemo() is for computing and caching values, not for arbitrary side effects.",
+			noAsyncOrGeneratorFunctions: "useMemo() callbacks may not be async or generator functions. useMemo() callbacks are called once and must synchronously return a value.",
+			noParameters: "useMemo() callbacks may not accept parameters. useMemo() callbacks are called by React to cache calculations across re-renders. They should not take parameters. Instead, directly reference the props, state, or local variables needed for the computation.",
+			noReassigningOuterVariables: "useMemo() callbacks may not reassign variables declared outside of the callback. useMemo() callbacks must be pure functions and cannot reassign variables defined outside of the callback function.",
+			resultMustBeUsed: "useMemo() result is unused. This useMemo() value is unused. useMemo() is for computing and caching values, not for arbitrary side effects."
 		},
 		schema: []
 	},
@@ -7136,13 +7163,31 @@ var use_memo_default = createRule({
 });
 function create$1(context) {
 	if (!context.sourceCode.text.includes("useMemo")) return {};
+	function validateNoOuterVariableReassignment(callback) {
+		const violations = [];
+		const callbackScope = context.sourceCode.getScope(callback);
+		const localVars = new Set(callbackScope.variables.map((v) => v.name));
+		if (callback.body == null) return violations;
+		simpleTraverse(callback.body, { enter(node) {
+			if (node.type !== AST_NODE_TYPES.AssignmentExpression) return;
+			const left = Extract.unwrap(node.left);
+			if (left.type !== AST_NODE_TYPES.Identifier) return;
+			if (localVars.has(left.name)) return;
+			if (isInsideNestedFunction(node, callback)) return;
+			violations.push({
+				messageId: "noReassigningOuterVariables",
+				node: left
+			});
+		} });
+		return violations;
+	}
 	return merge({ CallExpression(node) {
 		if (!core.isUseMemoCall(context, node)) return;
 		let parent = node.parent;
 		while (Check.isTypeExpression(parent)) parent = parent.parent;
 		if (!(parent.type === AST_NODE_TYPES.VariableDeclarator || parent.type === AST_NODE_TYPES.AssignmentExpression || parent.type === AST_NODE_TYPES.AssignmentPattern || parent.type === AST_NODE_TYPES.Property || parent.type === AST_NODE_TYPES.ReturnStatement || parent.type === AST_NODE_TYPES.JSXExpressionContainer || parent.type === AST_NODE_TYPES.CallExpression || parent.type === AST_NODE_TYPES.NewExpression || parent.type === AST_NODE_TYPES.ArrayExpression || parent.type === AST_NODE_TYPES.ConditionalExpression || parent.type === AST_NODE_TYPES.LogicalExpression || parent.type === AST_NODE_TYPES.SequenceExpression || parent.type === AST_NODE_TYPES.SpreadElement || parent.type === AST_NODE_TYPES.TemplateLiteral || parent.type === AST_NODE_TYPES.BinaryExpression || parent.type === AST_NODE_TYPES.UnaryExpression || parent.type === AST_NODE_TYPES.MemberExpression || parent.type === AST_NODE_TYPES.TaggedTemplateExpression || parent.type === AST_NODE_TYPES.ChainExpression || parent.type === AST_NODE_TYPES.ArrowFunctionExpression)) {
 			context.report({
-				messageId: "notAssignedToVariable",
+				messageId: "resultMustBeUsed",
 				node
 			});
 			return;
@@ -7155,26 +7200,27 @@ function create$1(context) {
 			const firstParam = callback.params[0];
 			if (firstParam == null) return;
 			context.report({
-				messageId: "callbackWithParameters",
+				messageId: "noParameters",
 				node: firstParam.type === AST_NODE_TYPES.Identifier ? firstParam : callback
 			});
 		}
 		if (callback.async || callback.generator) context.report({
-			messageId: "asyncOrGeneratorCallback",
+			messageId: "noAsyncOrGeneratorFunctions",
 			node: callback
 		});
+		for (const violation of validateNoOuterVariableReassignment(callback)) context.report(violation);
 		if (callback.type === AST_NODE_TYPES.ArrowFunctionExpression && callback.body.type !== AST_NODE_TYPES.BlockStatement) return;
 		if (callback.body.type !== AST_NODE_TYPES.BlockStatement) return;
-		const returnStatements = getNestedReturnStatements(callbackArg);
+		const returnStatements = getNestedReturnStatements(callback);
 		if (returnStatements.length === 0) {
 			context.report({
-				messageId: "missingReturnValue",
+				messageId: "mustReturnAValue",
 				node: callbackArg
 			});
 			return;
 		}
 		if (!returnStatements.some((stmt) => stmt.argument != null)) context.report({
-			messageId: "missingReturnValue",
+			messageId: "mustReturnAValue",
 			node: callbackArg
 		});
 	} });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-x",
-  "version": "5.5.1-next.0",
+  "version": "5.5.2-beta.0",
   "description": "A set of composable ESLint rules for libraries and frameworks that use React as a UI runtime.",
   "keywords": [
     "react",
@@ -46,18 +46,22 @@
     "string-ts": "^2.3.1",
     "ts-api-utils": "^2.5.0",
     "ts-pattern": "^5.9.0",
-    "@eslint-react/ast": "5.5.1-next.0",
-    "@eslint-react/core": "5.5.1-next.0",
-    "@eslint-react/eslint": "5.5.1-next.0",
-    "@eslint-react/jsx": "5.5.1-next.0",
-    "@eslint-react/shared": "5.5.1-next.0",
-    "@eslint-react/var": "5.5.1-next.0"
+    "@eslint-react/core": "5.5.2-beta.0",
+    "@eslint-react/jsx": "5.5.2-beta.0",
+    "@eslint-react/var": "5.5.2-beta.0",
+    "@eslint-react/shared": "5.5.2-beta.0",
+    "@eslint-react/eslint": "5.5.2-beta.0",
+    "@eslint-react/ast": "5.5.2-beta.0"
   },
   "devDependencies": {
     "@types/react": "^19.2.14",
     "@types/react-dom": "^19.2.3",
+    "dedent": "^1.7.2",
     "eslint": "^10.2.1",
+    "react": "^19.2.5",
+    "react-dom": "^19.2.5",
     "tsdown": "^0.21.10",
+    "tsl": "^1.0.30",
     "tsl-dx": "^0.12.0",
     "@local/configs": "0.0.0",
     "@local/eff": "3.0.0-beta.72"