eslint-plugin-react-x 5.4.0-next.0 → 5.5.0-next.0

package/dist/index.js

@@ -2,9 +2,9 @@ import { DEFAULT_ESLINT_REACT_SETTINGS, getSettingsFromContext, toRegExp } from
 import { Check, Compare, Extract, Traverse, is, isOneOf } from "@eslint-react/ast";
 import * as core from "@eslint-react/core";
 import { merge } from "@eslint-react/eslint";
+import { JsxDetectionHint, findParentAttribute, getElementFullType, hasAttribute, isJsxLike } from "@eslint-react/jsx";
 import { AST_NODE_TYPES } from "@typescript-eslint/types";
 import { ESLintUtils } from "@typescript-eslint/utils";
-import { JsxDetectionHint, findParentAttribute, getElementFullType, hasAttribute, isJsxLike } from "@eslint-react/jsx";
 import { findVariable, getStaticValue } from "@typescript-eslint/utils/ast-utils";
 import { computeObjectType, isAssignmentTargetEqual, resolve, resolveEnclosingAssignmentTarget } from "@eslint-react/var";
 import { DefinitionType } from "@typescript-eslint/scope-manager";
@@ -35,7 +35,7 @@ var __exportAll = (all, no_symbols) => {
 //#region src/configs/disable-conflict-eslint-plugin-react.ts
 var disable_conflict_eslint_plugin_react_exports = /* @__PURE__ */ __exportAll({
 	name: () => name$10,
-	rules: () => rules$10
+	rules: () => rules$9
 });
 const conflictingRules$1 = [
 	"react/button-has-type",
@@ -80,18 +80,17 @@ const conflictingRules$1 = [
 	"react/void-dom-elements-no-children"
 ];
 const name$10 = "react-x/disable-conflict-eslint-plugin-react";
-const rules$10 = Object.fromEntries(conflictingRules$1.map((key) => [key, "off"]));
+const rules$9 = Object.fromEntries(conflictingRules$1.map((key) => [key, "off"]));
 
 //#endregion
 //#region src/configs/disable-conflict-eslint-plugin-react-hooks.ts
 var disable_conflict_eslint_plugin_react_hooks_exports = /* @__PURE__ */ __exportAll({
 	name: () => name$9,
-	rules: () => rules$9
+	rules: () => rules$8
 });
 const conflictingRules = [
 	"react-hooks/exhaustive-deps",
 	"react-hooks/rules-of-hooks",
-	"react-hooks/component-hook-factories",
 	"react-hooks/error-boundaries",
 	"react-hooks/globals",
 	"react-hooks/immutability",
@@ -103,16 +102,16 @@ const conflictingRules = [
 	"react-hooks/use-memo"
 ];
 const name$9 = "react-x/disable-conflict-eslint-plugin-react-hooks";
-const rules$9 = Object.fromEntries(conflictingRules.map((key) => [key, "off"]));
+const rules$8 = Object.fromEntries(conflictingRules.map((key) => [key, "off"]));
 
 //#endregion
 //#region src/configs/disable-experimental.ts
 var disable_experimental_exports = /* @__PURE__ */ __exportAll({
 	name: () => name$8,
-	rules: () => rules$8
+	rules: () => rules$7
 });
 const name$8 = "react-x/disable-experimental";
-const rules$8 = {
+const rules$7 = {
 	"react-x/globals": "off",
 	"react-x/immutability": "off",
 	"react-x/no-duplicate-key": "off",
@@ -129,10 +128,10 @@ const rules$8 = {
 //#region src/configs/disable-type-checked.ts
 var disable_type_checked_exports = /* @__PURE__ */ __exportAll({
 	name: () => name$7,
-	rules: () => rules$7
+	rules: () => rules$6
 });
 const name$7 = "react-x/disable-type-checked";
-const rules$7 = {
+const rules$6 = {
 	"react-x/no-implicit-children": "off",
 	"react-x/no-implicit-key": "off",
 	"react-x/no-implicit-ref": "off",
@@ -143,52 +142,7 @@ const rules$7 = {
 //#endregion
 //#region package.json
 var name$6 = "eslint-plugin-react-x";
-var version = "5.4.0-next.0";
-
-//#endregion
-//#region src/rules/component-hook-factories/lib.ts
-/**
-* Check if a function parameter has a type annotation that looks like a React component type.
-* Matches types like ComponentType, React.ComponentType, FC, React.FC, etc.
-* @param param The parameter to check.
-*/
-function hasComponentTypeAnnotation(param) {
-	if (param.type !== AST_NODE_TYPES.Identifier || param.typeAnnotation == null) return false;
-	const annotation = param.typeAnnotation.typeAnnotation;
-	if (annotation.type === AST_NODE_TYPES.TSTypeReference) return isComponentTypeName(annotation.typeName);
-	return false;
-}
-/**
-* Check if a type name refers to a known React component type.
-* @param typeName The type name to check.
-*/
-function isComponentTypeName(typeName) {
-	if (typeName.type === AST_NODE_TYPES.Identifier) return /^(ComponentType|FC|ComponentClass|FunctionComponent|Component)$/.test(typeName.name);
-	if (typeName.type === AST_NODE_TYPES.TSQualifiedName) {
-		if (typeName.left.type === AST_NODE_TYPES.Identifier && typeName.left.name === "React") return isComponentTypeName(typeName.right);
-	}
-	return false;
-}
-/**
-* Heuristically check if a function is a Higher Order Component (HOC) based on its parameters.
-* Considers a function an HOC if it takes a parameter that looks like a React component
-* (by name or type annotation). This does not validate that the function actually returns
-* a React component.
-* @param fn The function to check.
-*/
-function isHigherOrderComponent(fn) {
-	return fn.params.some((param) => {
-		if (param.type === AST_NODE_TYPES.Identifier && core.isFunctionComponentNameLoose(param.name)) return true;
-		if (hasComponentTypeAnnotation(param)) return true;
-		return false;
-	});
-}
-function isTestMock$1(node) {
-	return node != null && node.type === AST_NODE_TYPES.MemberExpression && node.object.type === AST_NODE_TYPES.Identifier && node.property.type === AST_NODE_TYPES.Identifier && node.property.name === "mock";
-}
-function isTestMockCallback$1(node) {
-	return node != null && Check.isFunction(node) && node.parent.type === AST_NODE_TYPES.CallExpression && isTestMock$1(node.parent.callee) && node.parent.arguments[1] === node;
-}
+var version = "5.5.0-next.0";
 
 //#endregion
 //#region src/utils/create-rule.ts
@@ -197,72 +151,6 @@ function getDocsUrl(ruleName) {
 }
 const createRule = ESLintUtils.RuleCreator(getDocsUrl);
 
-//#endregion
-//#region src/rules/component-hook-factories/component-hook-factories.ts
-const RULE_NAME$50 = "component-hook-factories";
-var component_hook_factories_default = createRule({
-	meta: {
-		type: "problem",
-		docs: { description: "Disallows higher order functions that define components or hooks inside them." },
-		messages: {
-			component: "Do not define component '{{name}}' inside a function. Components should be defined at the module level. Move it to the top level.",
-			hook: "Do not define hook '{{name}}' inside a function. Hooks should be defined at the module level. Move it to the top level."
-		},
-		schema: []
-	},
-	name: RULE_NAME$50,
-	create: create$50,
-	defaultOptions: []
-});
-function create$50(context) {
-	const hint = core.FunctionComponentDetectionHint.DoNotIncludeJsxWithNumberValue | core.FunctionComponentDetectionHint.DoNotIncludeJsxWithBooleanValue | core.FunctionComponentDetectionHint.DoNotIncludeJsxWithNullValue | core.FunctionComponentDetectionHint.DoNotIncludeJsxWithStringValue | core.FunctionComponentDetectionHint.DoNotIncludeJsxWithUndefinedValue | core.FunctionComponentDetectionHint.RequireBothSidesOfLogicalExpressionToBeJsx | core.FunctionComponentDetectionHint.RequireBothBranchesOfConditionalExpressionToBeJsx | core.FunctionComponentDetectionHint.DoNotIncludeFunctionDefinedAsArrayPatternElement | core.FunctionComponentDetectionHint.DoNotIncludeFunctionDefinedAsArrayExpressionElement | core.FunctionComponentDetectionHint.DoNotIncludeFunctionDefinedAsArrayMapCallback;
-	const fc = core.getFunctionComponentCollector(context, { hint });
-	const cc = core.getClassComponentCollector(context);
-	const hc = core.getHookCollector(context);
-	const reported = /* @__PURE__ */ new Set();
-	return merge(fc.visitor, cc.visitor, hc.visitor, { "Program:exit"(program) {
-		const fComponents = [...fc.api.getAllComponents(program)];
-		const cComponents = [...cc.api.getAllComponents(program)];
-		const hooks = [...hc.api.getAllHooks(program)];
-		for (const { name, node } of fComponents) {
-			if (name == null) continue;
-			const parentFn = Traverse.findParent(node, Check.isFunction);
-			if (parentFn == null) continue;
-			if (Traverse.findParent(node, isTestMockCallback$1) != null) continue;
-			if (isHigherOrderComponent(parentFn)) continue;
-			if (reported.has(node)) continue;
-			context.report({
-				data: { name },
-				messageId: "component",
-				node
-			});
-			reported.add(node);
-		}
-		for (const { name = "unknown", node } of cComponents) {
-			const parentFn = Traverse.findParent(node, Check.isFunction);
-			if (parentFn == null) continue;
-			if (Traverse.findParent(node, isTestMockCallback$1) != null) continue;
-			if (isHigherOrderComponent(parentFn)) continue;
-			context.report({
-				data: { name },
-				messageId: "component",
-				node
-			});
-		}
-		for (const { name, node } of hooks) {
-			if (Traverse.findParent(node, Check.isFunction) == null) continue;
-			if (Traverse.findParent(node, isTestMockCallback$1) != null) continue;
-			if (reported.has(node)) continue;
-			context.report({
-				data: { name },
-				messageId: "hook",
-				node
-			});
-			reported.add(node);
-		}
-	} });
-}
-
 //#endregion
 //#region src/rules/error-boundaries/error-boundaries.ts
 const RULE_NAME$49 = "error-boundaries";
@@ -7520,7 +7408,6 @@ const plugin = {
 		version
 	},
 	rules: {
-		"component-hook-factories": component_hook_factories_default,
 		"error-boundaries": error_boundaries_default,
 		"exhaustive-deps": rule$1,
 		globals: globals_default,
@@ -7581,12 +7468,11 @@ const plugin = {
 var recommended_exports = /* @__PURE__ */ __exportAll({
 	name: () => name$5,
 	plugins: () => plugins$5,
-	rules: () => rules$6,
+	rules: () => rules$5,
 	settings: () => settings$5
 });
 const name$5 = "react-x/recommended";
-const rules$6 = {
-	"react-x/component-hook-factories": "error",
+const rules$5 = {
 	"react-x/error-boundaries": "error",
 	"react-x/exhaustive-deps": "warn",
 	"react-x/no-access-state-in-setstate": "error",
@@ -7628,13 +7514,6 @@ const rules$6 = {
 const plugins$5 = { "react-x": plugin };
 const settings$5 = { "react-x": DEFAULT_ESLINT_REACT_SETTINGS };
 
-//#endregion
-//#region src/configs/_ts.ts
-/**
-* Disables rules that are already handled by TypeScript
-*/
-const rules$5 = {};
-
 //#endregion
 //#region src/configs/recommended-typescript.ts
 var recommended_typescript_exports = /* @__PURE__ */ __exportAll({
@@ -7644,10 +7523,7 @@ var recommended_typescript_exports = /* @__PURE__ */ __exportAll({
 	settings: () => settings$4
 });
 const name$4 = "react-x/recommended-typescript";
-const rules$4 = {
-	...rules$6,
-	...rules$5
-};
+const rules$4 = { ...rules$5 };
 const plugins$4 = { ...plugins$5 };
 const settings$4 = { ...settings$5 };
 
@@ -7677,7 +7553,7 @@ var strict_exports = /* @__PURE__ */ __exportAll({
 });
 const name$2 = "react-x/strict";
 const rules$2 = {
-	...rules$6,
+	...rules$5,
 	"react-x/no-class-component": "error",
 	"react-x/no-misused-capture-owner-stack": "error",
 	"react-x/no-unstable-context-value": "warn",
@@ -7695,10 +7571,7 @@ var strict_typescript_exports = /* @__PURE__ */ __exportAll({
 	settings: () => settings$1
 });
 const name$1 = "react-x/strict-typescript";
-const rules$1 = {
-	...rules$2,
-	...rules$5
-};
+const rules$1 = { ...rules$2 };
 const plugins$1 = { ...plugins$2 };
 const settings$1 = { ...settings$2 };
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-x",
-  "version": "5.4.0-next.0",
+  "version": "5.5.0-next.0",
   "description": "A set of composable ESLint rules for libraries and frameworks that use React as a UI runtime.",
   "keywords": [
     "react",
@@ -46,12 +46,12 @@
     "string-ts": "^2.3.1",
     "ts-api-utils": "^2.5.0",
     "ts-pattern": "^5.9.0",
-    "@eslint-react/ast": "5.4.0-next.0",
-    "@eslint-react/eslint": "5.4.0-next.0",
-    "@eslint-react/jsx": "5.4.0-next.0",
-    "@eslint-react/shared": "5.4.0-next.0",
-    "@eslint-react/core": "5.4.0-next.0",
-    "@eslint-react/var": "5.4.0-next.0"
+    "@eslint-react/ast": "5.5.0-next.0",
+    "@eslint-react/core": "5.5.0-next.0",
+    "@eslint-react/eslint": "5.5.0-next.0",
+    "@eslint-react/shared": "5.5.0-next.0",
+    "@eslint-react/jsx": "5.5.0-next.0",
+    "@eslint-react/var": "5.5.0-next.0"
   },
   "devDependencies": {
     "@types/react": "^19.2.14",
@@ -59,8 +59,8 @@
     "eslint": "^10.2.1",
     "tsdown": "^0.21.10",
     "tsl-dx": "^0.12.0",
-    "@local/configs": "0.0.0",
-    "@local/eff": "3.0.0-beta.72"
+    "@local/eff": "3.0.0-beta.72",
+    "@local/configs": "0.0.0"
   },
   "peerDependencies": {
     "eslint": "^10.2.1",