eslint-plugin-react-x 5.30.0-beta.0 → 5.30.0-beta.2

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (2) hide show
  1. package/dist/index.js +14 -190
  2. package/package.json +7 -8
package/dist/index.js CHANGED
@@ -1,6 +1,6 @@
1
1
  import { DEFAULT_ESLINT_REACT_SETTINGS, getSettingsFromContext, toRegExp } from "@eslint-react/shared";
2
2
  import * as ESLintUtils from "@typescript-eslint/utils/eslint-utils";
3
- import { Check, Compare, Extract, Traverse } from "@eslint-react/ast";
3
+ import { Check, Collect, Compare, Extract, Traverse } from "@eslint-react/ast";
4
4
  import * as core from "@eslint-react/core";
5
5
  import { getConstrainedTypeAtLocation, getText, merge, report } from "@eslint-react/eslint";
6
6
  import { AST_NODE_TYPES } from "@typescript-eslint/types";
@@ -8,11 +8,10 @@ import { P, isMatching, match } from "ts-pattern";
8
8
  import { isAssignmentTargetEqual, isInitializedFromReact, resolveEnclosingAssignmentTarget, resolveObjectType, resolveOrigin } from "@eslint-react/var";
9
9
  import { DefinitionType, ScopeType } from "@typescript-eslint/scope-manager";
10
10
  import { findVariable, getStaticValue } from "@typescript-eslint/utils/ast-utils";
11
- import { findParentAttribute, getElementFullType, hasAttribute, isAttribute } from "@eslint-react/jsx";
11
+ import { findParentAttribute, getCreateElementPropsObject, getElementFullType, hasAttribute, isAttribute, isInsideCreateElementProps } from "@eslint-react/jsx";
12
12
  import { compare } from "compare-versions";
13
13
  import { unionConstituents } from "ts-api-utils";
14
14
  import "typescript";
15
- import { simpleTraverse } from "@typescript-eslint/typescript-estree";
16
15
  import { delimiterCase, snakeCase, toLowerCase } from "string-ts";
17
16
  // \0rolldown/runtime.js
18
17
  var __defProp = Object.defineProperty;
@@ -130,7 +129,7 @@ const rules$6 = {
130
129
  };
131
130
  // package.json
132
131
  var name$6 = "eslint-plugin-react-x";
133
- var version = "5.30.0-beta.0";
132
+ var version = "5.30.0-beta.2";
134
133
  // src/utils/create-rule.ts
135
134
  function getDocsUrl(ruleName) {
136
135
  return `https://eslint-react.xyz/docs/rules/${ruleName}`;
@@ -1750,7 +1749,7 @@ function create$46(context) {
1750
1749
  }
1751
1750
  function getPropsObject(node) {
1752
1751
  const props = node.arguments[1];
1753
- if (core.isCreateElementCall(context, node)) return core.getCreateElementPropsObject(context, node);
1752
+ if (core.isCreateElementCall(context, node)) return getCreateElementPropsObject(context, node);
1754
1753
  if (!core.isCloneElementCall(context, node)) return null;
1755
1754
  return props?.type === AST_NODE_TYPES.ObjectExpression ? props : null;
1756
1755
  }
@@ -2684,16 +2683,6 @@ const KNOWN_CALLBACK_POSITIONS = /* @__PURE__ */ new Map([
2684
2683
  ["from", 1],
2685
2684
  ["map", 0]
2686
2685
  ]);
2687
- function getReturnStatements$1(node) {
2688
- const stmts = [];
2689
- const boundary = Check.isFunction(node) ? node : Traverse.findParent(node, Check.isFunction);
2690
- simpleTraverse(node, { enter(node) {
2691
- if (node.type !== AST_NODE_TYPES.ReturnStatement) return;
2692
- if (Traverse.hasParent(node, Check.isFunction, (n) => n === boundary)) return;
2693
- stmts.push(node);
2694
- } });
2695
- return stmts;
2696
- }
2697
2686
  var no_missing_key_default = createRule({
2698
2687
  meta: {
2699
2688
  type: "problem",
@@ -2741,8 +2730,7 @@ function create$24(context) {
2741
2730
  }
2742
2731
  }
2743
2732
  function visitIteratorCallback(node) {
2744
- if (node.body.type !== AST_NODE_TYPES.BlockStatement) return visitItemExpression(node.body);
2745
- return getReturnStatements$1(node.body).flatMap((stmt) => stmt.argument == null ? [] : visitItemExpression(stmt.argument));
2733
+ return Collect.getReturnExpressions(node).flatMap(visitItemExpression);
2746
2734
  }
2747
2735
  return {
2748
2736
  ArrayExpression(node) {
@@ -2930,7 +2918,7 @@ function create$22(context) {
2930
2918
  });
2931
2919
  continue;
2932
2920
  }
2933
- if (core.isInsideCreateElementProps(context, component)) {
2921
+ if (isInsideCreateElementProps(context, component)) {
2934
2922
  context.report({
2935
2923
  data: { suggestion: "Move it to the top level or pass it as a prop." },
2936
2924
  messageId: "default",
@@ -6385,95 +6373,11 @@ function createFactCollector$3(additionalStateHooks, additionalEffectHooks) {
6385
6373
  };
6386
6374
  }
6387
6375
  // src/rules/set-state-in-effect/helpers.ts
6388
- const IDENTIFIER_VISITOR_KEYS = {
6389
- [AST_NODE_TYPES.ArrayExpression]: ["elements"],
6390
- [AST_NODE_TYPES.ArrayPattern]: ["elements"],
6391
- [AST_NODE_TYPES.AssignmentExpression]: ["left", "right"],
6392
- [AST_NODE_TYPES.AssignmentPattern]: ["left", "right"],
6393
- [AST_NODE_TYPES.AwaitExpression]: ["argument"],
6394
- [AST_NODE_TYPES.BinaryExpression]: ["left", "right"],
6395
- [AST_NODE_TYPES.CallExpression]: ["callee", "arguments"],
6396
- [AST_NODE_TYPES.ChainExpression]: ["expression"],
6397
- [AST_NODE_TYPES.ConditionalExpression]: [
6398
- "test",
6399
- "consequent",
6400
- "alternate"
6401
- ],
6402
- [AST_NODE_TYPES.ForInStatement]: ["left", "right"],
6403
- [AST_NODE_TYPES.ForOfStatement]: ["left", "right"],
6404
- [AST_NODE_TYPES.ImportExpression]: ["source"],
6405
- [AST_NODE_TYPES.LogicalExpression]: ["left", "right"],
6406
- [AST_NODE_TYPES.MemberExpression]: ["object", "property"],
6407
- [AST_NODE_TYPES.NewExpression]: ["callee", "arguments"],
6408
- [AST_NODE_TYPES.ObjectExpression]: ["properties"],
6409
- [AST_NODE_TYPES.ObjectPattern]: ["properties"],
6410
- [AST_NODE_TYPES.Property]: ["value"],
6411
- [AST_NODE_TYPES.SequenceExpression]: ["expressions"],
6412
- [AST_NODE_TYPES.SpreadElement]: ["argument"],
6413
- [AST_NODE_TYPES.TaggedTemplateExpression]: ["tag", "quasi"],
6414
- [AST_NODE_TYPES.TemplateLiteral]: ["expressions"],
6415
- [AST_NODE_TYPES.TSAsExpression]: ["expression"],
6416
- [AST_NODE_TYPES.TSInstantiationExpression]: ["expression"],
6417
- [AST_NODE_TYPES.TSNonNullExpression]: ["expression"],
6418
- [AST_NODE_TYPES.TSSatisfiesExpression]: ["expression"],
6419
- [AST_NODE_TYPES.TSTypeAssertion]: ["expression"],
6420
- [AST_NODE_TYPES.UnaryExpression]: ["argument"],
6421
- [AST_NODE_TYPES.UpdateExpression]: ["argument"],
6422
- [AST_NODE_TYPES.YieldExpression]: ["argument"]
6423
- };
6424
- function getIdentifiers(node) {
6425
- const identifiers = [];
6426
- simpleTraverse(node, {
6427
- enter(node, parent) {
6428
- if (node.type !== AST_NODE_TYPES.Identifier) return;
6429
- if (parent?.type === AST_NODE_TYPES.MemberExpression && !parent.computed && parent.property === node) return;
6430
- identifiers.push(node);
6431
- },
6432
- visitorKeys: IDENTIFIER_VISITOR_KEYS
6433
- });
6434
- return identifiers;
6435
- }
6436
6376
  function isTerminatingStatement(node) {
6437
6377
  if (node.type === AST_NODE_TYPES.ReturnStatement || node.type === AST_NODE_TYPES.ThrowStatement) return true;
6438
6378
  if (node.type === AST_NODE_TYPES.BlockStatement) return node.body.some(isTerminatingStatement);
6439
6379
  return false;
6440
6380
  }
6441
- function getReturnExpressions(fn) {
6442
- if (fn.type === AST_NODE_TYPES.ArrowFunctionExpression && fn.body.type !== AST_NODE_TYPES.BlockStatement) return [fn.body];
6443
- const returns = [];
6444
- const visitStatements = (statements) => {
6445
- for (const statement of statements) switch (statement.type) {
6446
- case AST_NODE_TYPES.ReturnStatement:
6447
- if (statement.argument != null) returns.push(statement.argument);
6448
- break;
6449
- case AST_NODE_TYPES.BlockStatement:
6450
- visitStatements(statement.body);
6451
- break;
6452
- case AST_NODE_TYPES.IfStatement:
6453
- visitStatements([statement.consequent]);
6454
- if (statement.alternate != null) visitStatements([statement.alternate]);
6455
- break;
6456
- case AST_NODE_TYPES.SwitchStatement:
6457
- for (const switchCase of statement.cases) visitStatements(switchCase.consequent);
6458
- break;
6459
- case AST_NODE_TYPES.TryStatement:
6460
- visitStatements([statement.block]);
6461
- if (statement.handler != null) visitStatements([statement.handler.body]);
6462
- if (statement.finalizer != null) visitStatements([statement.finalizer]);
6463
- break;
6464
- case AST_NODE_TYPES.DoWhileStatement:
6465
- case AST_NODE_TYPES.ForInStatement:
6466
- case AST_NODE_TYPES.ForOfStatement:
6467
- case AST_NODE_TYPES.ForStatement:
6468
- case AST_NODE_TYPES.LabeledStatement:
6469
- case AST_NODE_TYPES.WhileStatement:
6470
- case AST_NODE_TYPES.WithStatement: visitStatements([statement.body]);
6471
- }
6472
- };
6473
- if (fn.body.type !== AST_NODE_TYPES.BlockStatement) return [];
6474
- visitStatements(fn.body.body);
6475
- return returns;
6476
- }
6477
6381
  function getConditionalBranch(node) {
6478
6382
  let child = node;
6479
6383
  let current = node.parent;
@@ -6531,7 +6435,7 @@ const EMPTY_FACTS = {
6531
6435
  };
6532
6436
  function createSetStateResolver$1(context, facts = EMPTY_FACTS) {
6533
6437
  const { additionalRefHooks, additionalStateHooks } = getSettingsFromContext(context);
6534
- const getReturnExpressions$1 = memoize(getReturnExpressions);
6438
+ const getReturnExpressions = memoize(Collect.getReturnExpressions);
6535
6439
  function isUseRefCall(node) {
6536
6440
  return node.type === AST_NODE_TYPES.CallExpression && core.isUseRefLikeCall(node, additionalRefHooks);
6537
6441
  }
@@ -6617,7 +6521,7 @@ function createSetStateResolver$1(context, facts = EMPTY_FACTS) {
6617
6521
  const targets = [];
6618
6522
  for (const factory of factories) {
6619
6523
  if (factory.kind !== "function" || factory.node.async) continue;
6620
- for (const returnExpression of getReturnExpressions$1(factory.node)) targets.push(...resolveValues(returnExpression, new Set(seen)));
6524
+ for (const returnExpression of getReturnExpressions(factory.node)) targets.push(...resolveValues(returnExpression, new Set(seen)));
6621
6525
  }
6622
6526
  return uniqueTargets(targets);
6623
6527
  }
@@ -6709,7 +6613,7 @@ function createSetStateResolver$1(context, facts = EMPTY_FACTS) {
6709
6613
  if (seen.has(key)) continue;
6710
6614
  seen.add(key);
6711
6615
  const childRefParams = getRefDerivedParams(expression, target.node, refParams);
6712
- if (getReturnExpressions$1(target.node).some((r) => isRefValue(r, childRefParams, seen, mode))) return true;
6616
+ if (getReturnExpressions(target.node).some((r) => isRefValue(r, childRefParams, seen, mode))) return true;
6713
6617
  }
6714
6618
  return isRefValue(expression.callee, refParams, seen, mode) || expression.arguments.some((a) => isRefValue(a, refParams, seen, mode));
6715
6619
  case AST_NODE_TYPES.BinaryExpression:
@@ -6737,7 +6641,7 @@ function createSetStateResolver$1(context, facts = EMPTY_FACTS) {
6737
6641
  return context.sourceCode.getScope(expression.body).references.some((r) => isRefValue(r.identifier, refParams, seen, "argument"));
6738
6642
  }
6739
6643
  function isRefInExpression(node, refParams) {
6740
- return getIdentifiers(node).some((id) => isInitializedFromRef(id, refParams));
6644
+ return Collect.getIdentifiers(node).some((id) => isInitializedFromRef(id, refParams));
6741
6645
  }
6742
6646
  function isRefGatedContext(node, refParams) {
6743
6647
  let child = node;
@@ -7240,16 +7144,6 @@ function isResultUsed(node) {
7240
7144
  while (Check.isTypeExpression(parent)) parent = parent.parent;
7241
7145
  return parent.type === AST_NODE_TYPES.VariableDeclarator || parent.type === AST_NODE_TYPES.AssignmentExpression || parent.type === AST_NODE_TYPES.AssignmentPattern || parent.type === AST_NODE_TYPES.Property || parent.type === AST_NODE_TYPES.ReturnStatement || parent.type === AST_NODE_TYPES.JSXExpressionContainer || parent.type === AST_NODE_TYPES.CallExpression || parent.type === AST_NODE_TYPES.NewExpression || parent.type === AST_NODE_TYPES.ArrayExpression || parent.type === AST_NODE_TYPES.ConditionalExpression || parent.type === AST_NODE_TYPES.LogicalExpression || parent.type === AST_NODE_TYPES.SequenceExpression || parent.type === AST_NODE_TYPES.SpreadElement || parent.type === AST_NODE_TYPES.TemplateLiteral || parent.type === AST_NODE_TYPES.BinaryExpression || parent.type === AST_NODE_TYPES.UnaryExpression || parent.type === AST_NODE_TYPES.MemberExpression || parent.type === AST_NODE_TYPES.TaggedTemplateExpression || parent.type === AST_NODE_TYPES.ChainExpression || parent.type === AST_NODE_TYPES.ArrowFunctionExpression || parent.type === AST_NODE_TYPES.ForOfStatement || parent.type === AST_NODE_TYPES.ForInStatement;
7242
7146
  }
7243
- function getReturnStatements(node) {
7244
- const statements = [];
7245
- const boundary = Check.isFunction(node) ? node : Traverse.findParent(node, Check.isFunction);
7246
- simpleTraverse(node, { enter(node) {
7247
- if (node.type !== AST_NODE_TYPES.ReturnStatement) return;
7248
- if (Traverse.hasParent(node, Check.isFunction, (n) => n === boundary)) return;
7249
- statements.push(node);
7250
- } });
7251
- return statements;
7252
- }
7253
7147
  // src/rules/use-memo/collect.ts
7254
7148
  function createFactCollector(isUseMemoCall) {
7255
7149
  const facts = { calls: [] };
@@ -7263,7 +7157,7 @@ function createFactCollector(isUseMemoCall) {
7263
7157
  target
7264
7158
  });
7265
7159
  }
7266
- simpleTraverse(callback.body, { enter(node) {
7160
+ Traverse.simpleTraverse(callback.body, { enter(node) {
7267
7161
  switch (node.type) {
7268
7162
  case AST_NODE_TYPES.AssignmentExpression:
7269
7163
  for (const target of Extract.getAssignmentTargets(node.left)) pushWrite(node, target);
@@ -7289,7 +7183,7 @@ function createFactCollector(isUseMemoCall) {
7289
7183
  callbackArg,
7290
7184
  isResultUsed: isResultUsed(node),
7291
7185
  node,
7292
- returnStatements: callbackFunction != null ? getReturnStatements(callbackFunction) : [],
7186
+ returnStatements: callbackFunction != null ? Collect.getReturnStatements(callbackFunction) : [],
7293
7187
  writes: callbackFunction != null ? collectWrites(callbackFunction) : []
7294
7188
  });
7295
7189
  } }
@@ -7383,76 +7277,6 @@ const LAZY_INIT_ALLOW_LIST = [
7383
7277
  "String",
7384
7278
  "Number"
7385
7279
  ];
7386
- const EXPRESSION_VISITOR_KEYS = {
7387
- [AST_NODE_TYPES.ArrayExpression]: ["elements"],
7388
- [AST_NODE_TYPES.ArrayPattern]: ["elements"],
7389
- [AST_NODE_TYPES.AssignmentExpression]: ["left", "right"],
7390
- [AST_NODE_TYPES.AssignmentPattern]: ["left", "right"],
7391
- [AST_NODE_TYPES.AwaitExpression]: ["argument"],
7392
- [AST_NODE_TYPES.BinaryExpression]: ["left", "right"],
7393
- [AST_NODE_TYPES.CallExpression]: ["callee", "arguments"],
7394
- [AST_NODE_TYPES.ChainExpression]: ["expression"],
7395
- [AST_NODE_TYPES.ConditionalExpression]: [
7396
- "test",
7397
- "consequent",
7398
- "alternate"
7399
- ],
7400
- [AST_NODE_TYPES.Decorator]: ["expression"],
7401
- [AST_NODE_TYPES.DoWhileStatement]: ["test"],
7402
- [AST_NODE_TYPES.ExpressionStatement]: ["expression"],
7403
- [AST_NODE_TYPES.ForInStatement]: ["left", "right"],
7404
- [AST_NODE_TYPES.ForOfStatement]: ["left", "right"],
7405
- [AST_NODE_TYPES.ForStatement]: ["test"],
7406
- [AST_NODE_TYPES.IfStatement]: [
7407
- "test",
7408
- "consequent",
7409
- "alternate"
7410
- ],
7411
- [AST_NODE_TYPES.ImportExpression]: ["source"],
7412
- [AST_NODE_TYPES.JSXExpressionContainer]: ["expression"],
7413
- [AST_NODE_TYPES.JSXSpreadChild]: ["expression"],
7414
- [AST_NODE_TYPES.LogicalExpression]: ["left", "right"],
7415
- [AST_NODE_TYPES.MemberExpression]: ["object", "property"],
7416
- [AST_NODE_TYPES.NewExpression]: ["callee", "arguments"],
7417
- [AST_NODE_TYPES.ObjectExpression]: ["properties"],
7418
- [AST_NODE_TYPES.ObjectPattern]: ["properties"],
7419
- [AST_NODE_TYPES.Property]: ["value"],
7420
- [AST_NODE_TYPES.SequenceExpression]: ["expressions"],
7421
- [AST_NODE_TYPES.SpreadElement]: ["argument"],
7422
- [AST_NODE_TYPES.SwitchCase]: ["test", "consequent"],
7423
- [AST_NODE_TYPES.TaggedTemplateExpression]: ["tag", "quasi"],
7424
- [AST_NODE_TYPES.TemplateLiteral]: ["expressions"],
7425
- [AST_NODE_TYPES.TSAsExpression]: ["expression"],
7426
- [AST_NODE_TYPES.TSClassImplements]: ["expression"],
7427
- [AST_NODE_TYPES.TSExportAssignment]: ["expression"],
7428
- [AST_NODE_TYPES.TSExternalModuleReference]: ["expression"],
7429
- [AST_NODE_TYPES.TSInstantiationExpression]: ["expression"],
7430
- [AST_NODE_TYPES.TSInterfaceHeritage]: ["expression"],
7431
- [AST_NODE_TYPES.TSNonNullExpression]: ["expression"],
7432
- [AST_NODE_TYPES.TSSatisfiesExpression]: ["expression"],
7433
- [AST_NODE_TYPES.TSTypeAssertion]: ["expression"],
7434
- [AST_NODE_TYPES.UnaryExpression]: ["argument"],
7435
- [AST_NODE_TYPES.UpdateExpression]: ["argument"],
7436
- [AST_NODE_TYPES.WhileStatement]: ["test"],
7437
- [AST_NODE_TYPES.YieldExpression]: ["argument"]
7438
- };
7439
- function getExpressionsOfType(type) {
7440
- const isNodeOfType = Check.is(type);
7441
- const recurse = (node) => {
7442
- const expressions = [];
7443
- simpleTraverse(node, {
7444
- enter(node, parent) {
7445
- if (parent?.type === AST_NODE_TYPES.MemberExpression && !parent.computed && parent.property === node) return;
7446
- if (isNodeOfType(node)) expressions.push(node);
7447
- },
7448
- visitorKeys: EXPRESSION_VISITOR_KEYS
7449
- });
7450
- return expressions;
7451
- };
7452
- return recurse;
7453
- }
7454
- const getNewExpressions = getExpressionsOfType(AST_NODE_TYPES.NewExpression);
7455
- const getCallExpressions = getExpressionsOfType(AST_NODE_TYPES.CallExpression);
7456
7280
  // src/rules/use-state/use-state.ts
7457
7281
  const RULE_NAME = "use-state";
7458
7282
  const defaultOptions = [{
@@ -7501,7 +7325,7 @@ function create(context) {
7501
7325
  if (enforceLazyInitialization) {
7502
7326
  const [useStateInput] = node.arguments;
7503
7327
  if (useStateInput != null) {
7504
- for (const expr of getNewExpressions(useStateInput)) {
7328
+ for (const expr of Collect.getNewExpressions(useStateInput)) {
7505
7329
  if (!hasProperty(expr.callee, "name")) continue;
7506
7330
  if (LAZY_INIT_ALLOW_LIST.includes(expr.callee.name)) continue;
7507
7331
  if (Traverse.hasParent(expr, core.isUseCall(context))) continue;
@@ -7510,7 +7334,7 @@ function create(context) {
7510
7334
  node: expr
7511
7335
  });
7512
7336
  }
7513
- for (const expr of getCallExpressions(useStateInput)) {
7337
+ for (const expr of Collect.getCallExpressions(useStateInput)) {
7514
7338
  if (!hasProperty(expr.callee, "name")) continue;
7515
7339
  if (core.isHookName(expr.callee.name)) continue;
7516
7340
  if (LAZY_INIT_ALLOW_LIST.includes(expr.callee.name)) continue;
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "eslint-plugin-react-x",
3
- "version": "5.30.0-beta.0",
3
+ "version": "5.30.0-beta.2",
4
4
  "description": "A set of composable ESLint rules for libraries and frameworks that use React as a UI runtime.",
5
5
  "keywords": [
6
6
  "react",
@@ -36,15 +36,14 @@
36
36
  "dist"
37
37
  ],
38
38
  "dependencies": {
39
- "@eslint-react/ast": "5.30.0-beta.0",
40
- "@eslint-react/core": "5.30.0-beta.0",
41
- "@eslint-react/eslint": "5.30.0-beta.0",
42
- "@eslint-react/jsx": "5.30.0-beta.0",
43
- "@eslint-react/shared": "5.30.0-beta.0",
44
- "@eslint-react/var": "5.30.0-beta.0",
39
+ "@eslint-react/ast": "5.30.0-beta.2",
40
+ "@eslint-react/core": "5.30.0-beta.2",
41
+ "@eslint-react/eslint": "5.30.0-beta.2",
42
+ "@eslint-react/jsx": "5.30.0-beta.2",
43
+ "@eslint-react/shared": "5.30.0-beta.2",
44
+ "@eslint-react/var": "5.30.0-beta.2",
45
45
  "@typescript-eslint/scope-manager": "^8.72.0",
46
46
  "@typescript-eslint/types": "^8.72.0",
47
- "@typescript-eslint/typescript-estree": "^8.72.0",
48
47
  "@typescript-eslint/utils": "^8.72.0",
49
48
  "compare-versions": "^6.1.1",
50
49
  "string-ts": "^2.3.1",