eslint-plugin-react-x 5.28.3 → 5.28.5

package/dist/index.js

@@ -135,7 +135,7 @@ const rules$6 = {
 //#endregion
 //#region package.json
 var name$6 = "eslint-plugin-react-x";
-var version = "5.28.3";
+var version = "5.28.5";
 //#endregion
 //#region src/utils/create-rule.ts
 function getDocsUrl(ruleName) {
@@ -157,7 +157,7 @@ var error_boundaries_default = createRule({
 });
 function create$50(context) {
 	if (!context.sourceCode.text.includes("try")) return {};
-	const hint = core.JsxDetectionHint.DoNotIncludeJsxWithNullValue | core.JsxDetectionHint.DoNotIncludeJsxWithNumberValue | core.JsxDetectionHint.DoNotIncludeJsxWithBigIntValue | core.JsxDetectionHint.DoNotIncludeJsxWithStringValue | core.JsxDetectionHint.DoNotIncludeJsxWithBooleanValue | core.JsxDetectionHint.DoNotIncludeJsxWithUndefinedValue | core.JsxDetectionHint.DoNotIncludeJsxWithEmptyArrayValue;
+	const hint = core.JSXDetectionHint.DoNotIncludeJSXWithNullValue | core.JSXDetectionHint.DoNotIncludeJSXWithNumberValue | core.JSXDetectionHint.DoNotIncludeJSXWithBigIntValue | core.JSXDetectionHint.DoNotIncludeJSXWithStringValue | core.JSXDetectionHint.DoNotIncludeJSXWithBooleanValue | core.JSXDetectionHint.DoNotIncludeJSXWithUndefinedValue | core.JSXDetectionHint.DoNotIncludeJSXWithEmptyArrayValue;
 	const fc = core.getFunctionComponentCollector(context);
 	const hc = core.getHookCollector(context);
 	const reported = /* @__PURE__ */ new Set();
@@ -184,7 +184,7 @@ function create$50(context) {
 			}
 			for (const { rets } of funcs) for (const ret of rets) {
 				if (ret == null) continue;
-				if (!core.isJsxLike(context, ret, hint)) continue;
+				if (!core.isJSXLike(context, ret, hint)) continue;
 				const stmt = Traverse.findEnclosingTryBlock(ret);
 				if (stmt != null && !reported.has(stmt)) {
 					context.report({
@@ -2920,7 +2920,7 @@ var no_nested_component_definitions_default = createRule({
 	create: create$22
 });
 function create$22(context) {
-	const hint = core.FunctionComponentDetectionHint.DoNotIncludeJsxWithNumberValue | core.FunctionComponentDetectionHint.DoNotIncludeJsxWithBooleanValue | core.FunctionComponentDetectionHint.DoNotIncludeJsxWithNullValue | core.FunctionComponentDetectionHint.DoNotIncludeJsxWithStringValue | core.FunctionComponentDetectionHint.DoNotIncludeJsxWithUndefinedValue | core.FunctionComponentDetectionHint.RequireBothSidesOfLogicalExpressionToBeJsx | core.FunctionComponentDetectionHint.RequireBothBranchesOfConditionalExpressionToBeJsx | core.FunctionComponentDetectionHint.DoNotIncludeFunctionDefinedAsArrayPatternElement | core.FunctionComponentDetectionHint.DoNotIncludeFunctionDefinedAsArrayExpressionElement | core.FunctionComponentDetectionHint.DoNotIncludeFunctionDefinedAsArrayMapCallback | core.FunctionComponentDetectionHint.DoNotIncludeFunctionDefinedAsArrayFlatMapCallback;
+	const hint = core.FunctionComponentDetectionHint.DoNotIncludeJSXWithNumberValue | core.FunctionComponentDetectionHint.DoNotIncludeJSXWithBooleanValue | core.FunctionComponentDetectionHint.DoNotIncludeJSXWithNullValue | core.FunctionComponentDetectionHint.DoNotIncludeJSXWithStringValue | core.FunctionComponentDetectionHint.DoNotIncludeJSXWithUndefinedValue | core.FunctionComponentDetectionHint.RequireBothSidesOfLogicalExpressionToBeJSX | core.FunctionComponentDetectionHint.RequireBothBranchesOfConditionalExpressionToBeJSX | core.FunctionComponentDetectionHint.DoNotIncludeFunctionDefinedAsArrayPatternElement | core.FunctionComponentDetectionHint.DoNotIncludeFunctionDefinedAsArrayExpressionElement | core.FunctionComponentDetectionHint.DoNotIncludeFunctionDefinedAsArrayMapCallback | core.FunctionComponentDetectionHint.DoNotIncludeFunctionDefinedAsArrayFlatMapCallback;
 	const fc = core.getFunctionComponentCollector(context, { hint });
 	const cc = core.getClassComponentCollector(context);
 	return merge(fc.visitor, cc.visitor, { "Program:exit"(program) {
@@ -3232,36 +3232,38 @@ function create$13(context) {
 	if (compilationMode === "annotation" && context.sourceCode.ast.body.some((stmt) => Check.isDirective(stmt, "use memo"))) return {};
 	const isReact18OrBelow = compare(version, "19.0.0", "<");
 	const { api, visitor } = core.getFunctionComponentCollector(context);
-	const valueExpressions = [];
+	const constructions = /* @__PURE__ */ new WeakMap();
 	return merge(visitor, {
 		JSXOpeningElement(node) {
 			const selfName = getElementFullType(node.parent).split(".").at(-1);
 			if (selfName == null) return;
 			if (!isContextName(selfName, isReact18OrBelow)) return;
+			const enclosingFunction = Traverse.findParent(node, Check.isFunction);
+			if (enclosingFunction == null) return;
+			if (compilationMode === "annotation" && core.isFunctionHasDirective(enclosingFunction, "use memo")) return;
 			const attribute = node.attributes.findLast(isAttribute("value"));
 			if (attribute?.value?.type !== AST_NODE_TYPES.JSXExpressionContainer) return;
-			const { expression } = attribute.value;
-			if (expression.type === AST_NODE_TYPES.JSXEmptyExpression) return;
-			valueExpressions.push(expression);
+			const valueExpression = attribute.value.expression;
+			const construction = resolveObjectType(context, valueExpression);
+			if (construction == null) return;
+			if (core.isHookCall(construction.node)) return;
+			getOrInsertComputed(constructions, enclosingFunction, () => []).push(construction);
 		},
 		"Program:exit"(program) {
-			const components = api.getAllComponents(program).filter(({ directives }) => compilationMode !== "annotation" || !directives.some((d) => d.directive === "use memo")).map(({ node }) => node).sort((a, b) => a.range[1] - a.range[0] - (b.range[1] - b.range[0]));
-			for (const valueExpression of valueExpressions) {
-				const component = components.find((node) => node.range[0] <= valueExpression.range[0] && valueExpression.range[1] <= node.range[1]);
-				if (component == null) continue;
-				const construction = resolveObjectType(context, valueExpression, { boundary: component });
-				if (construction == null) continue;
-				if (core.isHookCall(construction.node)) continue;
-				const { kind, node: constructionNode } = construction;
-				const suggestion = kind === "function" ? "Consider wrapping it in a useCallback hook." : "Consider wrapping it in a useMemo hook.";
-				context.report({
-					data: {
-						kind: getHumanReadableKind$1(constructionNode),
-						suggestion
-					},
-					messageId: "unstable-context-value",
-					node: constructionNode
-				});
+			for (const { directives, node: component } of api.getAllComponents(program)) {
+				if (compilationMode === "annotation" && directives.some((d) => d.directive === "use memo")) continue;
+				for (const construction of constructions.get(component) ?? []) {
+					const { kind, node: constructionNode } = construction;
+					const suggestion = kind === "function" ? "Consider wrapping it in a useCallback hook." : "Consider wrapping it in a useMemo hook.";
+					context.report({
+						data: {
+							kind: getHumanReadableKind$1(constructionNode),
+							suggestion
+						},
+						messageId: "unstable-context-value",
+						node: constructionNode
+					});
+				}
 			}
 		}
 	});
@@ -3309,28 +3311,28 @@ function create$12(context, [options]) {
 	if (compilationMode === "infer" || compilationMode === "all") return {};
 	if (compilationMode === "annotation" && context.sourceCode.ast.body.some((stmt) => Check.isDirective(stmt, "use memo"))) return {};
 	const { api, visitor } = core.getFunctionComponentCollector(context);
-	const declarators = [];
+	const declarators = /* @__PURE__ */ new WeakMap();
 	const { safeDefaultProps = [] } = options;
 	const safePatterns = safeDefaultProps.map((s) => toRegExp(s));
 	return merge(visitor, {
 		[SEL_OBJECT_DESTRUCTURING_VARIABLE_DECLARATOR](node) {
-			declarators.push(node);
+			const enclosingFunction = Traverse.findParent(node, Check.isFunction);
+			if (enclosingFunction == null) return;
+			getOrInsertComputed(declarators, enclosingFunction, () => []).push(node);
 		},
 		"Program:exit"(program) {
-			const components = api.getAllComponents(program).map(({ node }) => node).sort((a, b) => a.range[1] - a.range[0] - (b.range[1] - b.range[0]));
-			const innermostComponentOf = (node) => components.find((component) => component.range[0] <= node.range[0] && node.range[1] <= component.range[1]);
-			for (const component of components) {
+			for (const { node: component } of api.getAllComponents(program)) {
 				const { params } = component;
 				const [props] = params;
 				if (props == null) continue;
 				const properties = match(props).with({ type: AST_NODE_TYPES.ObjectPattern }, ({ properties }) => properties).with({ type: AST_NODE_TYPES.Identifier }, ({ name }) => {
-					return declarators.filter((d) => d.init.name === name && innermostComponentOf(d) === component).flatMap((d) => d.id.properties);
+					return declarators.get(component)?.filter((d) => d.init.name === name).flatMap((d) => d.id.properties) ?? [];
 				}).otherwise(() => []);
 				for (const prop of properties) {
 					if (prop.type !== AST_NODE_TYPES.Property || prop.value.type !== AST_NODE_TYPES.AssignmentPattern) continue;
 					const { value } = prop;
 					const { right } = value;
-					const construction = resolveObjectType(context, value, { boundary: component });
+					const construction = resolveObjectType(context, value);
 					if (construction == null) continue;
 					if (core.isHookCall(construction.node)) continue;
 					if (safePatterns.length > 0) {
@@ -7130,7 +7132,7 @@ var static_components_default = createRule({
 	create: create$3
 });
 function create$3(context) {
-	const hint = core.FunctionComponentDetectionHint.DoNotIncludeJsxWithNumberValue | core.FunctionComponentDetectionHint.DoNotIncludeJsxWithBooleanValue | core.FunctionComponentDetectionHint.DoNotIncludeJsxWithNullValue | core.FunctionComponentDetectionHint.DoNotIncludeJsxWithStringValue | core.FunctionComponentDetectionHint.DoNotIncludeJsxWithUndefinedValue | core.FunctionComponentDetectionHint.RequireBothSidesOfLogicalExpressionToBeJsx | core.FunctionComponentDetectionHint.RequireBothBranchesOfConditionalExpressionToBeJsx | core.FunctionComponentDetectionHint.DoNotIncludeFunctionDefinedAsArrayPatternElement | core.FunctionComponentDetectionHint.DoNotIncludeFunctionDefinedAsArrayExpressionElement | core.FunctionComponentDetectionHint.DoNotIncludeFunctionDefinedAsArrayMapCallback;
+	const hint = core.FunctionComponentDetectionHint.DoNotIncludeJSXWithNumberValue | core.FunctionComponentDetectionHint.DoNotIncludeJSXWithBooleanValue | core.FunctionComponentDetectionHint.DoNotIncludeJSXWithNullValue | core.FunctionComponentDetectionHint.DoNotIncludeJSXWithStringValue | core.FunctionComponentDetectionHint.DoNotIncludeJSXWithUndefinedValue | core.FunctionComponentDetectionHint.RequireBothSidesOfLogicalExpressionToBeJSX | core.FunctionComponentDetectionHint.RequireBothBranchesOfConditionalExpressionToBeJSX | core.FunctionComponentDetectionHint.DoNotIncludeFunctionDefinedAsArrayPatternElement | core.FunctionComponentDetectionHint.DoNotIncludeFunctionDefinedAsArrayExpressionElement | core.FunctionComponentDetectionHint.DoNotIncludeFunctionDefinedAsArrayMapCallback;
 	const fc = core.getFunctionComponentCollector(context, { hint });
 	const cc = core.getClassComponentCollector(context);
 	const { facts, visitor } = createFactCollector$1();

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-x",
-  "version": "5.28.3",
+  "version": "5.28.5",
   "description": "A set of composable ESLint rules for libraries and frameworks that use React as a UI runtime.",
   "keywords": [
     "react",
@@ -36,12 +36,12 @@
     "dist"
   ],
   "dependencies": {
-    "@eslint-react/ast": "5.28.3",
-    "@eslint-react/core": "5.28.3",
-    "@eslint-react/eslint": "5.28.3",
-    "@eslint-react/jsx": "5.28.3",
-    "@eslint-react/shared": "5.28.3",
-    "@eslint-react/var": "5.28.3",
+    "@eslint-react/ast": "5.28.5",
+    "@eslint-react/core": "5.28.5",
+    "@eslint-react/eslint": "5.28.5",
+    "@eslint-react/jsx": "5.28.5",
+    "@eslint-react/shared": "5.28.5",
+    "@eslint-react/var": "5.28.5",
     "@typescript-eslint/scope-manager": "^8.72.0",
     "@typescript-eslint/types": "^8.72.0",
     "@typescript-eslint/typescript-estree": "^8.72.0",