eslint-plugin-react-x 5.27.1 → 5.27.3

package/dist/index.js

@@ -135,7 +135,7 @@ const rules$6 = {
 //#endregion
 //#region package.json
 var name$6 = "eslint-plugin-react-x";
-var version = "5.27.1";
+var version = "5.27.3";
 //#endregion
 //#region src/utils/create-rule.ts
 function getDocsUrl(ruleName) {
@@ -6422,7 +6422,8 @@ function isHookDecl(node) {
 	if (node.type !== AST_NODE_TYPES.VariableDeclarator) return false;
 	if (!Check.isIdentifier(node.id)) return false;
 	const init = node.init;
-	if (init == null || init.type !== AST_NODE_TYPES.CallExpression) return false;
+	if (init == null) return false;
+	if (init.type !== AST_NODE_TYPES.CallExpression) return false;
 	const name = Extract.getCalleeName(init);
 	return name != null && core.isHookName(name);
 }
@@ -6462,13 +6463,11 @@ function createFactCollector$3(additionalStateHooks, additionalEffectHooks) {
 	}
 	function getFunctionKind(node) {
 		const parent = Traverse.findParent(node, not(Check.isTypeExpression)) ?? node.parent;
-		switch (true) {
-			case node.async:
-			case parent.type === AST_NODE_TYPES.CallExpression && isThenCall(parent): return "deferred";
-			case node.type !== AST_NODE_TYPES.FunctionDeclaration && parent.type === AST_NODE_TYPES.CallExpression && parent.callee === node: return "immediate";
-			case isUseEffectSetupCallback(node): return "setup";
-			default: return "other";
-		}
+		if (node.async) return "deferred";
+		if (parent.type === AST_NODE_TYPES.CallExpression && isThenCall(parent)) return "deferred";
+		if (node.type !== AST_NODE_TYPES.FunctionDeclaration && parent.type === AST_NODE_TYPES.CallExpression && parent.callee === node) return "immediate";
+		if (isUseEffectSetupCallback(node)) return "setup";
+		return "other";
 	}
 	return {
 		facts,
@@ -6488,7 +6487,8 @@ function createFactCollector$3(additionalStateHooks, additionalEffectHooks) {
 			},
 			CallExpression(node) {
 				const entry = functionEntries.at(-1);
-				if (entry == null || entry.node.async) return;
+				if (entry == null) return;
+				if (entry.node.async) return;
 				if (isUseStateCall(node)) return;
 				if (isUseEffectCall(node)) {
 					const setup = node.arguments.at(0);
@@ -6504,20 +6504,17 @@ function createFactCollector$3(additionalStateHooks, additionalEffectHooks) {
 			},
 			Identifier(node) {
 				if (node.parent.type === AST_NODE_TYPES.CallExpression && node.parent.callee === node) return;
-				switch (node.parent.type) {
-					case AST_NODE_TYPES.ArrowFunctionExpression:
-						if (node === node.parent.body) facts.setStateReferences.push({
-							kind: "callback-body",
-							node
-						});
-						return;
-					case AST_NODE_TYPES.CallExpression:
-						if (node === node.parent.arguments.at(0)) facts.setStateReferences.push({
-							kind: "call-argument",
-							node
-						});
-						return;
+				if (node.parent.type === AST_NODE_TYPES.ArrowFunctionExpression && node === node.parent.body) {
+					facts.setStateReferences.push({
+						kind: "callback-body",
+						node
+					});
+					return;
 				}
+				if (node.parent.type === AST_NODE_TYPES.CallExpression && node === node.parent.arguments.at(0)) facts.setStateReferences.push({
+					kind: "call-argument",
+					node
+				});
 			}
 		}
 	};
@@ -6547,9 +6544,9 @@ function createSetStateResolver$1(context) {
 				const innerCallee = Extract.unwrap(callee.callee);
 				if (innerCallee.type !== AST_NODE_TYPES.MemberExpression) return false;
 				if (!hasProperty(innerCallee.object, "name")) return false;
-				const isAt = Extract.getCalleeName(callee) === "at";
+				if (!(Extract.getCalleeName(callee) === "at")) return false;
 				const [index] = callee.arguments;
-				if (!isAt || index == null) return false;
+				if (index == null) return false;
 				const indexScope = context.sourceCode.getScope(node);
 				return getStaticValue(index, indexScope)?.value === 1 && isSetStateId(innerCallee.object);
 			}
@@ -6591,32 +6588,30 @@ function isInitializedFromRef(context, id, refParams, seen = /* @__PURE__ */ new
 		const writeExpr = reference.writeExpr == null ? null : Extract.unwrap(reference.writeExpr);
 		if (writeExpr == null) continue;
 		if (writeExpr.range[1] > id.range[0]) continue;
-		if (Traverse.findParent(writeExpr, and(Check.isFunction, (n) => !Traverse.hasParent(id, (m) => m === n))) != null) continue;
+		if (Traverse.hasParent(writeExpr, and(Check.isFunction, (n) => !Traverse.hasParent(id, (m) => m === n)))) continue;
 		if (isExpressionFromRef(context, writeExpr, refParams, seen)) return true;
 	}
 	return false;
 }
 function isExpressionFromRef(context, init, refParams, seen) {
 	const { additionalRefHooks } = getSettingsFromContext(context);
-	switch (true) {
-		case init.type === AST_NODE_TYPES.MemberExpression: {
-			let current = init;
-			while (current.type === AST_NODE_TYPES.MemberExpression) {
-				const property = Extract.unwrap(current.property);
-				const object = Extract.unwrap(current.object);
-				if (!current.computed && Check.isIdentifier(property, "current")) {
-					const sourceName = getRefSourceName(object);
-					if (sourceName === "ref" || sourceName?.endsWith("Ref") === true) return true;
-					if (object.type === AST_NODE_TYPES.Identifier && isParameterId(context, object)) return true;
-				}
-				current = object;
+	if (init.type === AST_NODE_TYPES.CallExpression && core.isUseRefLikeCall(init, additionalRefHooks)) return true;
+	if (init.type === AST_NODE_TYPES.MemberExpression) {
+		let current = init;
+		while (current.type === AST_NODE_TYPES.MemberExpression) {
+			const property = Extract.unwrap(current.property);
+			const object = Extract.unwrap(current.object);
+			if (!current.computed && Check.isIdentifier(property, "current")) {
+				const sourceName = getRefSourceName(object);
+				if (sourceName === "ref" || sourceName?.endsWith("Ref") === true) return true;
+				if (object.type === AST_NODE_TYPES.Identifier && isParameterId(context, object)) return true;
 			}
-			if (Check.isIdentifier(current) && (current.name === "ref" || current.name.endsWith("Ref"))) return true;
-			return getNestedIdentifiers(init).some((id) => isInitializedFromRef(context, id, refParams, seen));
+			current = object;
 		}
-		case init.type === AST_NODE_TYPES.CallExpression && core.isUseRefLikeCall(init, additionalRefHooks): return true;
-		default: return getNestedIdentifiers(init).some((id) => isInitializedFromRef(context, id, refParams, seen));
+		if (Check.isIdentifier(current) && (current.name === "ref" || current.name.endsWith("Ref"))) return true;
+		return getNestedIdentifiers(init).some((id) => isInitializedFromRef(context, id, refParams, seen));
 	}
+	return getNestedIdentifiers(init).some((id) => isInitializedFromRef(context, id, refParams, seen));
 }
 function isArgumentUsingRefValue(context, node, refParams) {
 	const isUsingRefValue = (n) => {
@@ -6708,11 +6703,14 @@ function inferViolations$2(context, facts) {
 	for (const { enclosingFunction, enclosingFunctionKind, node, setupFunction } of facts.calls) {
 		if (isUseStateOrThenCall(node)) continue;
 		if (!resolver.isSetStateCall(node)) {
-			if (setupFunction != null && enclosingFunction === setupFunction) trackedFnCalls.push(node);
+			if (setupFunction == null) continue;
+			if (enclosingFunction !== setupFunction) continue;
+			trackedFnCalls.push(node);
 			continue;
 		}
 		if (enclosingFunctionKind === "deferred") continue;
-		if (setupFunction != null && (enclosingFunction === setupFunction || enclosingFunctionKind === "immediate" && Traverse.findParent(enclosingFunction, Check.isFunction) === setupFunction)) {
+		const syncEnclosingFunction = enclosingFunctionKind === "immediate" ? Traverse.findParent(enclosingFunction, Check.isFunction) : enclosingFunction;
+		if (setupFunction != null && syncEnclosingFunction === setupFunction) {
 			const args0 = node.arguments.at(0);
 			if (args0 == null) continue;
 			if (isArgumentUsingRefValue(context, args0)) continue;
@@ -6755,7 +6753,8 @@ function inferViolations$2(context, facts) {
 	};
 	const getRefDerivedParams = (call, callee) => {
 		const origin = resolveOrigin(context, callee);
-		if (origin == null || !Check.isFunction(origin)) return void 0;
+		if (origin == null) return void 0;
+		if (!Check.isFunction(origin)) return void 0;
 		const refParams = /* @__PURE__ */ new Set();
 		origin.params.forEach((param, index) => {
 			const paramId = param.type === AST_NODE_TYPES.Identifier ? param : param.type === AST_NODE_TYPES.AssignmentPattern && param.left.type === AST_NODE_TYPES.Identifier ? param.left : null;
@@ -6819,9 +6818,9 @@ var set_state_in_effect_default = createRule({
 function create$5(context) {
 	if (!/use\w*Effect/u.test(context.sourceCode.text)) return {};
 	const { additionalEffectHooks, additionalStateHooks } = getSettingsFromContext(context);
-	const facts = createFactCollector$3(additionalStateHooks, additionalEffectHooks);
-	return merge(facts.visitor, { "Program:exit"() {
-		for (const violation of inferViolations$2(context, facts.facts)) context.report({
+	const { facts, visitor } = createFactCollector$3(additionalStateHooks, additionalEffectHooks);
+	return merge(visitor, { "Program:exit"() {
+		for (const violation of inferViolations$2(context, facts)) context.report({
 			data: { name: violation.name },
 			messageId: "default",
 			node: violation.node
@@ -6901,7 +6900,8 @@ function createFactCollector$2(context) {
 				const componentFn = componentFnStack.at(-1);
 				if (componentFn == null) return;
 				const entry = functionEntries.at(-1);
-				if (entry == null || entry.node !== componentFn) return;
+				if (entry == null) return;
+				if (entry.node !== componentFn) return;
 				if (componentFn.body.type !== AST_NODE_TYPES.BlockStatement) return;
 				const body = componentFn.body.body;
 				let stmt = node;
@@ -6943,9 +6943,9 @@ function createSetStateResolver(context) {
 				const innerCallee = Extract.unwrap(callee.callee);
 				if (innerCallee.type !== AST_NODE_TYPES.MemberExpression) return false;
 				if (!hasProperty(innerCallee.object, "name")) return false;
-				const isAt = Extract.getCalleeName(callee) === "at";
+				if (!(Extract.getCalleeName(callee) === "at")) return false;
 				const [index] = callee.arguments;
-				if (!isAt || index == null) return false;
+				if (index == null) return false;
 				const indexScope = context.sourceCode.getScope(node);
 				return getStaticValue(index, indexScope)?.value === 1 && isSetStateId(innerCallee.object);
 			}
@@ -6997,9 +6997,9 @@ var set_state_in_render_default = createRule({
 	create: create$4
 });
 function create$4(context) {
-	const facts = createFactCollector$2(context);
-	return merge(facts.visitor, { "Program:exit"() {
-		for (const violation of inferViolations$1(context, facts.facts)) context.report({
+	const { facts, visitor } = createFactCollector$2(context);
+	return merge(visitor, { "Program:exit"() {
+		for (const violation of inferViolations$1(context, facts)) context.report({
 			data: { name: violation.name },
 			messageId: "default",
 			node: violation.node
@@ -7061,7 +7061,8 @@ function findReassignmentCreationSite(context, variable, isInsideRender, seen) {
 	for (const ref of variable.references) {
 		if (!ref.isWrite()) continue;
 		const { identifier } = ref;
-		if (identifier.parent.type !== AST_NODE_TYPES.AssignmentExpression || identifier.parent.left !== identifier) continue;
+		if (identifier.parent.type !== AST_NODE_TYPES.AssignmentExpression) continue;
+		if (identifier.parent.left !== identifier) continue;
 		const source = findDynamicCreationSite(context, identifier.parent.right, isInsideRender, seen);
 		if (source != null) return source;
 	}
@@ -7081,11 +7082,13 @@ function resolveDynamicComponentOrigin(context, variable, isInsideRender, seen =
 			isDynamic: true
 		};
 		if (defNode.type !== AST_NODE_TYPES.VariableDeclarator) continue;
-		const initSource = defNode.init == null ? null : findDynamicCreationSite(context, defNode.init, isInsideRender, seen);
-		if (initSource != null) return {
-			creationNode: initSource,
-			isDynamic: true
-		};
+		if (defNode.init != null) {
+			const initSource = findDynamicCreationSite(context, defNode.init, isInsideRender, seen);
+			if (initSource != null) return {
+				creationNode: initSource,
+				isDynamic: true
+			};
+		}
 		const reassignmentSource = findReassignmentCreationSite(context, variable, isInsideRender, seen);
 		if (reassignmentSource != null) return {
 			creationNode: reassignmentSource,
@@ -7134,22 +7137,22 @@ function create$3(context) {
 	const hint = core.FunctionComponentDetectionHint.DoNotIncludeJsxWithNumberValue | core.FunctionComponentDetectionHint.DoNotIncludeJsxWithBooleanValue | core.FunctionComponentDetectionHint.DoNotIncludeJsxWithNullValue | core.FunctionComponentDetectionHint.DoNotIncludeJsxWithStringValue | core.FunctionComponentDetectionHint.DoNotIncludeJsxWithUndefinedValue | core.FunctionComponentDetectionHint.RequireBothSidesOfLogicalExpressionToBeJsx | core.FunctionComponentDetectionHint.RequireBothBranchesOfConditionalExpressionToBeJsx | core.FunctionComponentDetectionHint.DoNotIncludeFunctionDefinedAsArrayPatternElement | core.FunctionComponentDetectionHint.DoNotIncludeFunctionDefinedAsArrayExpressionElement | core.FunctionComponentDetectionHint.DoNotIncludeFunctionDefinedAsArrayMapCallback;
 	const fc = core.getFunctionComponentCollector(context, { hint });
 	const cc = core.getClassComponentCollector(context);
-	const facts = createFactCollector$1();
-	return merge(fc.visitor, cc.visitor, facts.visitor, { "Program:exit"(program) {
+	const { facts, visitor } = createFactCollector$1();
+	return merge(fc.visitor, cc.visitor, visitor, { "Program:exit"(program) {
 		const isInsideRender = createRenderBoundaryChecker([...fc.api.getAllComponents(program), ...cc.api.getAllComponents(program)].map((component) => component.node));
 		const reportedCreations = /* @__PURE__ */ new Set();
-		for (const effect of inferCreatedComponents(context, facts.facts.componentUsages, isInsideRender)) {
+		for (const effect of inferCreatedComponents(context, facts.componentUsages, isInsideRender)) {
 			context.report({
 				messageId: "default",
 				node: effect.node
 			});
-			if (effect.creationNode != null && !reportedCreations.has(effect.creationNode)) {
-				reportedCreations.add(effect.creationNode);
-				context.report({
-					messageId: "created-here",
-					node: effect.creationNode
-				});
-			}
+			if (effect.creationNode == null) continue;
+			if (reportedCreations.has(effect.creationNode)) continue;
+			reportedCreations.add(effect.creationNode);
+			context.report({
+				messageId: "created-here",
+				node: effect.creationNode
+			});
 		}
 	} });
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-x",
-  "version": "5.27.1",
+  "version": "5.27.3",
   "description": "A set of composable ESLint rules for libraries and frameworks that use React as a UI runtime.",
   "keywords": [
     "react",
@@ -36,12 +36,12 @@
     "dist"
   ],
   "dependencies": {
-    "@eslint-react/ast": "5.27.1",
-    "@eslint-react/core": "5.27.1",
-    "@eslint-react/eslint": "5.27.1",
-    "@eslint-react/jsx": "5.27.1",
-    "@eslint-react/shared": "5.27.1",
-    "@eslint-react/var": "5.27.1",
+    "@eslint-react/ast": "5.27.3",
+    "@eslint-react/core": "5.27.3",
+    "@eslint-react/eslint": "5.27.3",
+    "@eslint-react/jsx": "5.27.3",
+    "@eslint-react/shared": "5.27.3",
+    "@eslint-react/var": "5.27.3",
     "@typescript-eslint/scope-manager": "^8.71.2",
     "@typescript-eslint/types": "^8.71.2",
     "@typescript-eslint/typescript-estree": "^8.71.2",
@@ -56,6 +56,8 @@
     "@local/eff": "0.0.0",
     "@local/testkit": "0.0.0",
     "@rbxts/react": "17.3.7-ts.2",
+    "@tsconfig/node20": "^20.1.10",
+    "@types/node": "^20.19.43",
     "@types/react": "^19.3.0",
     "@types/react-dom": "^19.3.0",
     "dedent": "^1.7.2",