eslint-plugin-react-x 5.23.2 → 5.23.3

package/dist/index.js

@@ -144,7 +144,7 @@ const rules$6 = {
 //#endregion
 //#region package.json
 var name$6 = "eslint-plugin-react-x";
-var version = "5.23.2";
+var version = "5.23.3";
 
 //#endregion
 //#region src/utils/create-rule.ts
@@ -1681,13 +1681,29 @@ function getMutatedObject(mutation) {
 function inferDirectMutations(context, mutations, components) {
 	const directMutations = [];
 	for (const mutation of mutations) {
-		if (mutation.kind !== "value") continue;
 		if (mutation.node.type === AST_NODE_TYPES.CallExpression && isKnownNonMutatingMethodCall(context, mutation.node)) continue;
 		if (isRefMutation(context, mutation)) continue;
 		const variable = findVariable(context.sourceCode.getScope(mutation.root), mutation.root);
 		if (variable == null) continue;
 		const origin = classifyFrozenOrigin(context, variable, components);
 		if (origin == null) continue;
+		if (mutation.kind === "binding") {
+			switch (origin.kind) {
+				case "props":
+					directMutations.push({
+						name: origin.name,
+						detail: "It is a prop of this component and must not be reassigned.",
+						node: mutation.node
+					});
+					break;
+				case "state": directMutations.push({
+					name: origin.name,
+					detail: `It is a state value returned from '${origin.hook}' and must not be reassigned.`,
+					node: mutation.node
+				});
+			}
+			continue;
+		}
 		switch (origin.kind) {
 			case "props":
 				directMutations.push({
@@ -7974,7 +7990,7 @@ function isInitializedFromRef(context, name, initialScope, seen = /* @__PURE__ *
 				return Check.isIdentifier(object) && (object.name === "ref" || object.name.endsWith("Ref"));
 			}
 			case init.type === AST_NODE_TYPES.CallExpression && core.isUseRefLikeCall(init, additionalRefHooks): return true;
-			case init.type === AST_NODE_TYPES.CallExpression: return getNestedIdentifiers(init).some((id) => isInitializedFromRef(context, id.name, context.sourceCode.getScope(id), seen));
+			default: return getNestedIdentifiers(init).some((id) => isInitializedFromRef(context, id.name, context.sourceCode.getScope(id), seen));
 		}
 	}
 	return false;
@@ -7987,6 +8003,7 @@ function isInitializedFromRef(context, name, initialScope, seen = /* @__PURE__ *
 * @returns `true` if the node is inside a ref-gated conditional block
 */
 function isRefGatedContext(context, node) {
+	let child = node;
 	let current = node.parent;
 	while (current != null) {
 		if (Check.isFunction(current)) break;
@@ -7996,10 +8013,24 @@ function isRefGatedContext(context, node) {
 		if (current.type === AST_NODE_TYPES.ConditionalExpression) {
 			if (isRefInExpression(context, current.test)) return true;
 		}
+		if (current.type === AST_NODE_TYPES.BlockStatement) {
+			const index = current.body.findIndex((statement) => statement === child);
+			for (const statement of current.body.slice(0, Math.max(0, index))) {
+				if (statement.type !== AST_NODE_TYPES.IfStatement) continue;
+				if (!isRefInExpression(context, statement.test)) continue;
+				if (isTerminatingStatement(statement.consequent)) return true;
+			}
+		}
+		child = current;
 		current = current.parent;
 	}
 	return false;
 }
+function isTerminatingStatement(node) {
+	if (node.type === AST_NODE_TYPES.ReturnStatement || node.type === AST_NODE_TYPES.ThrowStatement) return true;
+	if (node.type === AST_NODE_TYPES.BlockStatement) return node.body.some(isTerminatingStatement);
+	return false;
+}
 function isRefInExpression(context, node) {
 	return getNestedIdentifiers(node).some((id) => isInitializedFromRef(context, id.name, context.sourceCode.getScope(id)));
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-x",
-  "version": "5.23.2",
+  "version": "5.23.3",
   "description": "A set of composable ESLint rules for libraries and frameworks that use React as a UI runtime.",
   "keywords": [
     "react",
@@ -36,12 +36,12 @@
     "dist"
   ],
   "dependencies": {
-    "@eslint-react/ast": "5.23.2",
-    "@eslint-react/core": "5.23.2",
-    "@eslint-react/eslint": "5.23.2",
-    "@eslint-react/jsx": "5.23.2",
-    "@eslint-react/shared": "5.23.2",
-    "@eslint-react/var": "5.23.2",
+    "@eslint-react/ast": "5.23.3",
+    "@eslint-react/core": "5.23.3",
+    "@eslint-react/eslint": "5.23.3",
+    "@eslint-react/jsx": "5.23.3",
+    "@eslint-react/shared": "5.23.3",
+    "@eslint-react/var": "5.23.3",
     "@typescript-eslint/scope-manager": "^8.71.0",
     "@typescript-eslint/types": "^8.71.0",
     "@typescript-eslint/typescript-estree": "^8.71.0",