eslint-plugin-react-x 5.21.1 → 5.21.2

package/dist/index.js

@@ -144,7 +144,7 @@ const rules$6 = {
 //#endregion
 //#region package.json
 var name$6 = "eslint-plugin-react-x";
-var version = "5.21.1";
+var version = "5.21.2";
 
 //#endregion
 //#region src/utils/create-rule.ts
@@ -1807,7 +1807,7 @@ function create$47(context) {
 	if (!context.sourceCode.text.includes("setState")) return {};
 	return { MemberExpression(node) {
 		if (!core.isAPI("this.state")(context, node)) return;
-		const fact = Traverse.findParent(Traverse.findParent(node, (n) => Check.is(AST_NODE_TYPES.CallExpression)(n) && core.isThisSetStateCall(n)), Check.isClass);
+		const fact = Traverse.findParent(Traverse.findParent(node, (n) => Check.isCallExpression(n) && core.isThisSetStateCall(n)), Check.isClass);
 		if (fact == null || !core.isClassComponent(fact)) return;
 		context.report({
 			messageId: "default",
@@ -2329,7 +2329,7 @@ var no_direct_mutation_state_default = createRule({
 	defaultOptions: []
 });
 function isConstructorFunction(node) {
-	return Check.isOneOf([AST_NODE_TYPES.FunctionDeclaration, AST_NODE_TYPES.FunctionExpression])(node) && Check.isPropertyOrMethod(node.parent) && Check.isIdentifier(node.parent.key) && node.parent.key.name === "constructor";
+	return Check.isOneOf([AST_NODE_TYPES.FunctionDeclaration, AST_NODE_TYPES.FunctionExpression])(node) && Check.isPropertyOrMethod(node.parent) && Check.isIdentifier(node.parent.key, "constructor");
 }
 function isAssignmentToThisState(node) {
 	const { left } = node;
@@ -2345,7 +2345,7 @@ function isAssignmentToThisState(node) {
 function create$33(context) {
 	return { AssignmentExpression(node) {
 		if (!isAssignmentToThisState(node)) return;
-		const fact = Traverse.findParent(node, Check.isOneOf([AST_NODE_TYPES.ClassDeclaration, AST_NODE_TYPES.ClassExpression]));
+		const fact = Traverse.findParent(node, Check.isClass);
 		if (fact == null) return;
 		if (core.isClassComponent(fact) && context.sourceCode.getScope(node).block !== Traverse.findParent(node, isConstructorFunction)) context.report({
 			messageId: "default",
@@ -2397,7 +2397,8 @@ function create$32(context) {
 					const call = Traverse.findParent(jsxElement, (n) => {
 						if (n.type !== AST_NODE_TYPES.CallExpression) return false;
 						const callee = Extract.unwrap(n.callee);
-						return callee.type === AST_NODE_TYPES.MemberExpression && Check.isIdentifier(callee.property) && callee.property.name === "map";
+						if (callee.type !== AST_NODE_TYPES.MemberExpression) return false;
+						return Check.isIdentifier(callee.property, "map");
 					});
 					const iter = Traverse.findParent(jsxElement, Check.isFunction, (n) => n === call);
 					if (!Check.isFunction(iter)) return;
@@ -3242,7 +3243,7 @@ function create$27(context) {
 	*/
 	function visit(node, seen = /* @__PURE__ */ new Set()) {
 		if (node == null) return null;
-		if (Check.is(AST_NODE_TYPES.JSXExpressionContainer)(node)) return visit(node.expression, seen);
+		if (Check.isJSXExpressionContainer(node)) return visit(node.expression, seen);
 		if (Check.isJSX(node)) return null;
 		if (Check.isTypeExpression(node)) return visit(node.expression, seen);
 		return match(node).with({
@@ -3560,8 +3561,8 @@ function create$23(context) {
 			if (node.source.value !== importSource) return;
 			for (const specifier of node.specifiers) {
 				if (specifier.type !== AST_NODE_TYPES.ImportSpecifier) continue;
-				if (specifier.imported.type !== AST_NODE_TYPES.Identifier) continue;
-				if (specifier.imported.name === "captureOwnerStack") context.report({
+				if (!Check.isIdentifier(specifier.imported, "captureOwnerStack")) continue;
+				context.report({
 					messageId: "useNamespaceImport",
 					node: specifier
 				});
@@ -3906,15 +3907,22 @@ function create$18(context) {
 
 //#endregion
 //#region src/rules/no-unnecessary-use-prefix/lib.ts
-const WELL_KNOWN_HOOKS = ["useMDXComponents"];
+const WELL_KNOWN_HOOKS = ["use", "useMDXComponents"];
 function containsUseComments(context, node) {
 	return context.sourceCode.getCommentsInside(node).some(({ value }) => /use\([\s\S]*?\)/u.test(value) || /use[A-Z0-9]\w*\([\s\S]*?\)/u.test(value));
 }
-function isTestMock(node) {
-	return node != null && node.type === AST_NODE_TYPES.MemberExpression && Check.isIdentifier(node.object) && Check.isIdentifier(node.property) && node.property.name === "mock";
+function isTestMockCall(node) {
+	if (node == null || node.type !== AST_NODE_TYPES.CallExpression) return false;
+	const { callee } = node;
+	if (callee.type !== AST_NODE_TYPES.MemberExpression) return false;
+	if (Check.isIdentifier(callee.object) && Check.isIdentifier(callee.property, "mock")) return true;
+	return Check.isIdentifier(callee.object, "mock") && Check.isIdentifier(callee.property, "module");
 }
-function isTestMockCallback(node) {
-	return node != null && Check.isFunction(node) && node.parent.type === AST_NODE_TYPES.CallExpression && isTestMock(node.parent.callee) && node.parent.arguments[1] === node;
+function isInTestMock(node) {
+	return Traverse.findParent(node, (n) => {
+		if (!isTestMockCall(n)) return false;
+		return n.arguments.slice(1).some((arg) => arg.range[0] <= node.range[0] && node.range[1] <= arg.range[1]);
+	}) != null;
 }
 
 //#endregion
@@ -3940,7 +3948,7 @@ function create$17(context) {
 			if (core.isFunctionEmpty(node)) continue;
 			if (WELL_KNOWN_HOOKS.includes(name)) continue;
 			if (containsUseComments(context, node)) continue;
-			if (Traverse.findParent(node, isTestMockCallback) != null) continue;
+			if (isInTestMock(node)) continue;
 			context.report({
 				data: { name },
 				messageId: "default",
@@ -4175,7 +4183,7 @@ function create$12(context, [options]) {
 					if (safePatterns.length > 0) {
 						const getName = (n) => Check.isIdentifier(n) ? n.name : null;
 						const name = match(right).with({ type: AST_NODE_TYPES.NewExpression }, (n) => getName(n.callee)).with({ type: AST_NODE_TYPES.CallExpression }, (n) => {
-							return match(Extract.unwrap(n.callee)).when(Check.isIdentifier, ({ name }) => name).when(Check.is(AST_NODE_TYPES.MemberExpression), ({ object }) => getName(object)).otherwise(() => null);
+							return match(Extract.unwrap(n.callee)).when(Check.isIdentifier, ({ name }) => name).when(Check.isMemberExpression, ({ object }) => getName(object)).otherwise(() => null);
 						}).otherwise(() => null);
 						if (name != null && safePatterns.some((pattern) => pattern.test(name))) continue;
 					}
@@ -4214,6 +4222,14 @@ const LIFECYCLE_METHODS = /* @__PURE__ */ new Set([
 	"UNSAFE_componentWillReceiveProps",
 	"UNSAFE_componentWillUpdate"
 ]);
+const HOST_CONVENTION_METHODS = /* @__PURE__ */ new Set([
+	"blur",
+	"focus",
+	"measure",
+	"measureInWindow",
+	"measureLayout",
+	"setNativeProps"
+]);
 
 //#endregion
 //#region src/rules/no-unused-class-component-members/no-unused-class-component-members.ts
@@ -4244,6 +4260,7 @@ function create$11(context) {
 			if (LIFECYCLE_METHODS.has(methodName)) {
 				if (methodName === "shouldComponentUpdate" && core.isPureComponent(node)) {} else continue;
 			}
+			if (HOST_CONVENTION_METHODS.has(methodName)) continue;
 			context.report({
 				data: {
 					className: id != null ? context.sourceCode.getText(id) : "Component",
@@ -4888,6 +4905,23 @@ function isCatalogObject(name) {
 	return IMPURE_FUNCS.has(name) || PURE_FUNCS.has(name);
 }
 /**
+* Check if the program has a top-level `use client` directive, marking the
+* module as a client module in React Server Components conventions.
+*/
+function hasUseClientDirective(program) {
+	return program.body.some((stmt) => stmt.type === AST_NODE_TYPES.ExpressionStatement && stmt.directive === "use client");
+}
+/**
+* Check if the node is an argument of a `useRef`-like call, e.g.
+* `useRef(document.createElement("div"))`. The initializer is evaluated on
+* every render but stored only on the first one, which is a widely used idiom
+* (ex: portals), so impure calls in this position are exempted.
+*/
+function isUseRefInitializerArgument(node) {
+	const { parent } = node;
+	return parent.type === AST_NODE_TYPES.CallExpression && parent.arguments.some((arg) => arg === node) && core.isUseRefLikeCall(parent);
+}
+/**
 * Find the property key under which `name` is bound in an object destructuring
 * pattern, e.g. `"random"` for `random` in `const { random } = Math` or for
 * `r` in `const { random: r } = Math`.
@@ -5000,6 +5034,7 @@ function create$7(context) {
 					const resolved = resolveBuiltinObjectName(context, expr);
 					if (resolved == null) return;
 					if (!(resolved.property != null ? IMPURE_FUNCS.get(resolved.object)?.has(resolved.property) ?? false : IMPURE_FUNCS.get("globalThis")?.has(resolved.object) ?? false)) return;
+					if (isUseRefInitializerArgument(node)) return;
 					const func = Traverse.findParent(node, Check.isFunction);
 					if (func == null) return;
 					cEntries.push({
@@ -5012,6 +5047,7 @@ function create$7(context) {
 					const resolved = resolveBuiltinMember(context, expr);
 					if (resolved == null || resolved.property == null) return;
 					if (!IMPURE_FUNCS.get(resolved.object)?.has(resolved.property)) return;
+					if (isUseRefInitializerArgument(node)) return;
 					const func = Traverse.findParent(node, Check.isFunction);
 					if (func == null) return;
 					cEntries.push({
@@ -5030,6 +5066,7 @@ function create$7(context) {
 			const ctorName = resolved.property != null && isCatalogObject(resolved.object) ? resolved.property : resolved.object;
 			if (!IMPURE_CTORS.has(ctorName)) return;
 			if (ctorName === "Date" && node.arguments.length > 0) return;
+			if (isUseRefInitializerArgument(node)) return;
 			const func = Traverse.findParent(node, Check.isFunction);
 			if (func == null) return;
 			nEntries.push({
@@ -5041,8 +5078,10 @@ function create$7(context) {
 			const comps = fc.api.getAllComponents(node);
 			const hooks = hc.api.getAllHooks(node);
 			const funcs = [...comps, ...hooks];
+			const isClientModule = hasUseClientDirective(node);
 			for (const { func, node } of [...cEntries, ...nEntries]) {
 				if (!funcs.some((f) => f.node === func)) continue;
+				if (!isClientModule && func.async && comps.some((comp) => comp.node === func)) continue;
 				context.report({
 					data: { name: context.sourceCode.getText(node) },
 					messageId: "default",
@@ -5347,9 +5386,7 @@ function createFactCollector() {
 //#region src/rules/refs/effects.ts
 /** The nearest strict ancestor of `node` that is a component or hook. */
 function findBoundary(node, boundaries) {
-	return Traverse.findParent(node, (candidate) => {
-		return Check.isFunction(candidate) && boundaries.has(candidate);
-	});
+	return Traverse.findParent(node, (candidate) => Check.isFunction(candidate) && boundaries.has(candidate));
 }
 /** The boundary containing `node`, where `node` is the nearest enclosing function of the fact. */
 function getBoundaryOf(node, boundaries) {
@@ -7941,10 +7978,14 @@ function isInitializedFromRef(context, name, initialScope, seen = /* @__PURE__ *
 	seen.add(name);
 	for (const { node } of findVariable(initialScope, name)?.defs ?? []) {
 		if (node.type !== AST_NODE_TYPES.VariableDeclarator) continue;
-		const init = node.init;
+		const init = node.init == null ? null : Extract.unwrap(node.init);
 		if (init == null) continue;
 		switch (true) {
-			case init.type === AST_NODE_TYPES.MemberExpression && Check.isIdentifier(init.object) && (init.object.name === "ref" || init.object.name.endsWith("Ref")): return true;
+			case init.type === AST_NODE_TYPES.MemberExpression: {
+				let object = Extract.unwrap(init.object);
+				while (object.type === AST_NODE_TYPES.MemberExpression) object = Extract.unwrap(object.object);
+				return Check.isIdentifier(object) && (object.name === "ref" || object.name.endsWith("Ref"));
+			}
 			case init.type === AST_NODE_TYPES.CallExpression && core.isUseRefLikeCall(init, additionalRefHooks): return true;
 			case init.type === AST_NODE_TYPES.CallExpression: return getNestedIdentifiers(init).some((id) => isInitializedFromRef(context, id.name, context.sourceCode.getScope(id), seen));
 		}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-x",
-  "version": "5.21.1",
+  "version": "5.21.2",
   "description": "A set of composable ESLint rules for libraries and frameworks that use React as a UI runtime.",
   "keywords": [
     "react",
@@ -36,12 +36,12 @@
     "dist"
   ],
   "dependencies": {
-    "@eslint-react/ast": "5.21.1",
-    "@eslint-react/core": "5.21.1",
-    "@eslint-react/eslint": "5.21.1",
-    "@eslint-react/jsx": "5.21.1",
-    "@eslint-react/shared": "5.21.1",
-    "@eslint-react/var": "5.21.1",
+    "@eslint-react/ast": "5.21.2",
+    "@eslint-react/core": "5.21.2",
+    "@eslint-react/eslint": "5.21.2",
+    "@eslint-react/jsx": "5.21.2",
+    "@eslint-react/shared": "5.21.2",
+    "@eslint-react/var": "5.21.2",
     "@typescript-eslint/scope-manager": "^8.70.1",
     "@typescript-eslint/types": "^8.70.1",
     "@typescript-eslint/typescript-estree": "^8.70.1",