eslint-plugin-react-x 5.18.3 → 5.18.4

package/dist/index.js

@@ -145,7 +145,7 @@ const rules$6 = {
 //#endregion
 //#region package.json
 var name$6 = "eslint-plugin-react-x";
-var version = "5.18.3";
+var version = "5.18.4";
 
 //#endregion
 //#region src/utils/create-rule.ts
@@ -531,15 +531,16 @@ const rule$1 = {
 					declaredDependency = analyzePropertyChain(declaredDependencyNode, null);
 				} catch (error) {
 					if (error instanceof Error && /Unsupported node type/.test(error.message)) {
-						if (declaredDependencyNode.type === "Literal") if (declaredDependencyNode.value && dependencies.has(declaredDependencyNode.value)) reportProblem({
-							node: declaredDependencyNode,
-							message: `The ${declaredDependencyNode.raw} literal is not a valid dependency because it never changes. Did you mean to include ${declaredDependencyNode.value} in the array instead?`
-						});
-						else reportProblem({
-							node: declaredDependencyNode,
-							message: `The ${declaredDependencyNode.raw} literal is not a valid dependency because it never changes. You can safely remove it.`
-						});
-						else reportProblem({
+						if (declaredDependencyNode.type === "Literal") {
+							if (declaredDependencyNode.value && dependencies.has(declaredDependencyNode.value)) reportProblem({
+								node: declaredDependencyNode,
+								message: `The ${declaredDependencyNode.raw} literal is not a valid dependency because it never changes. Did you mean to include ${declaredDependencyNode.value} in the array instead?`
+							});
+							else reportProblem({
+								node: declaredDependencyNode,
+								message: `The ${declaredDependencyNode.raw} literal is not a valid dependency because it never changes. You can safely remove it.`
+							});
+						} else reportProblem({
 							node: declaredDependencyNode,
 							message: `React Hook ${getSourceCode().getText(reactiveHook)} has a complex expression in the dependency array. Extract it to a separate variable so it can be statically checked.`
 						});
@@ -813,7 +814,6 @@ const rule$1 = {
 									visitFunctionWithDependencies(init, declaredDependenciesNode, reactiveHook, reactiveHookName, isEffect, isAutoDepsHook);
 									return;
 							}
-							break;
 					}
 					break;
 				default:
@@ -906,9 +906,10 @@ function collectRecommendations({ dependencies, declaredDependencies, stableDepe
 	const unnecessaryDependencies = /* @__PURE__ */ new Set();
 	const duplicateDependencies = /* @__PURE__ */ new Set();
 	declaredDependencies.forEach(({ key }) => {
-		if (satisfyingDependencies.has(key)) if (suggestedDependencies.indexOf(key) === -1) suggestedDependencies.push(key);
-		else duplicateDependencies.add(key);
-		else if (isEffect && !key.endsWith(".current") && !externalDependencies.has(key)) {
+		if (satisfyingDependencies.has(key)) {
+			if (suggestedDependencies.indexOf(key) === -1) suggestedDependencies.push(key);
+			else duplicateDependencies.add(key);
+		} else if (isEffect && !key.endsWith(".current") && !externalDependencies.has(key)) {
 			if (suggestedDependencies.indexOf(key) === -1) suggestedDependencies.push(key);
 		} else unnecessaryDependencies.add(key);
 	});
@@ -967,10 +968,12 @@ function scanForConstructions({ declaredDependencies, declaredDependenciesNode,
 	function isUsedOutsideOfHook(ref) {
 		let foundWriteExpr = false;
 		for (const reference of ref.references) {
-			if (reference.writeExpr) if (foundWriteExpr) return true;
-			else {
-				foundWriteExpr = true;
-				continue;
+			if (reference.writeExpr) {
+				if (foundWriteExpr) return true;
+				else {
+					foundWriteExpr = true;
+					continue;
+				}
 			}
 			let currentScope = reference.from;
 			while (currentScope !== scope && currentScope != null) currentScope = currentScope.upper;
@@ -1005,9 +1008,11 @@ function getDependency(node) {
 * This particular node might still represent a required member, so check .optional field.
 */
 function markNode(node, optionalChains, result) {
-	if (optionalChains) if ("optional" in node && node.optional) {
-		if (!optionalChains.has(result)) optionalChains.set(result, true);
-	} else optionalChains.set(result, false);
+	if (optionalChains) {
+		if ("optional" in node && node.optional) {
+			if (!optionalChains.has(result)) optionalChains.set(result, true);
+		} else optionalChains.set(result, false);
+	}
 }
 /**
 * Assuming () means the passed node.
@@ -1916,10 +1921,12 @@ function create$40(context) {
 	if (!context.sourceCode.text.includes("Component")) return {};
 	const { api, visitor } = core.getClassComponentCollector(context);
 	return merge(visitor, { "Program:exit"(program) {
-		for (const { name = "anonymous", node: component } of api.getAllComponents(program)) {
+		for (const { id, name = "anonymous", node: component } of api.getAllComponents(program)) {
 			if (component.body.body.some((m) => core.isComponentDidCatch(m) || core.isGetDerivedStateFromError(m))) continue;
+			const classToken = context.sourceCode.getFirstToken(component, { filter: (token) => token.value === "class" });
 			context.report({
 				data: { name },
+				loc: (id ?? classToken ?? component).loc,
 				messageId: "default",
 				node: component
 			});
@@ -4084,7 +4091,9 @@ function create$11(context) {
 		for (const def of defs) {
 			const methodName = def.name;
 			if (usages?.has(methodName) ?? false) continue;
-			if (LIFECYCLE_METHODS.has(methodName)) if (methodName === "shouldComponentUpdate" && core.isPureComponent(currentClass)) {} else continue;
+			if (LIFECYCLE_METHODS.has(methodName)) {
+				if (methodName === "shouldComponentUpdate" && core.isPureComponent(currentClass)) {} else continue;
+			}
 			context.report({
 				data: {
 					className: id != null ? context.sourceCode.getText(id) : "Component",
@@ -4155,9 +4164,7 @@ function collectUsedPropKeysOfObjectPattern(context, usedPropKeys, objectPattern
 			usedPropKeys.add(key);
 			break;
 		}
-		case AST_NODE_TYPES.RestElement:
-			if (!collectUsedPropsOfRestElement(context, usedPropKeys, property)) return false;
-			break;
+		case AST_NODE_TYPES.RestElement: if (!collectUsedPropsOfRestElement(context, usedPropKeys, property)) return false;
 	}
 	return true;
 }
@@ -4189,18 +4196,14 @@ function collectUsedPropKeysOfReference(context, usedPropKeys, ref) {
 				return true;
 			}
 			break;
-		case AST_NODE_TYPES.VariableDeclarator:
-			if (parent.id.type === AST_NODE_TYPES.ObjectPattern && parent.init === valueNode) return collectUsedPropKeysOfObjectPattern(context, usedPropKeys, parent.id);
-			break;
+		case AST_NODE_TYPES.VariableDeclarator: if (parent.id.type === AST_NODE_TYPES.ObjectPattern && parent.init === valueNode) return collectUsedPropKeysOfObjectPattern(context, usedPropKeys, parent.id);
 	}
 	return false;
 }
 function getKeyOfExpression(expr) {
 	switch (expr.type) {
 		case AST_NODE_TYPES.Identifier: return expr.name;
-		case AST_NODE_TYPES.Literal:
-			if (typeof expr.value === "string") return expr.value;
-			break;
+		case AST_NODE_TYPES.Literal: if (typeof expr.value === "string") return expr.value;
 	}
 	return null;
 }
@@ -4287,7 +4290,8 @@ function create$9(context) {
 		},
 		"Program:exit"() {
 			for (const { name, node } of stateEntries) {
-				const variable = findVariable(context.sourceCode.getScope(node), name);
+				const scope = context.sourceCode.getScope(node);
+				const variable = findVariable(scope, name);
 				if (variable == null) continue;
 				let hasRead = false;
 				for (const ref of variable.references) {
@@ -4643,7 +4647,8 @@ const IMPURE_CTORS = /* @__PURE__ */ new Set([
 function resolveBuiltinObjectName(context, node, seen = /* @__PURE__ */ new Set()) {
 	if (seen.has(node.name)) return null;
 	seen.add(node.name);
-	const variable = findVariable(context.sourceCode.getScope(node), node);
+	const scope = context.sourceCode.getScope(node);
+	const variable = findVariable(scope, node);
 	if (variable == null) return node.name;
 	const def = variable.defs[0];
 	if (def == null) return node.name;
@@ -5860,10 +5865,12 @@ var CodePathState = class {
 		this.forkBypassPath();
 		const lastCaseSegments = forkContext.head;
 		brokenForkContext.add(lastSegments);
-		if (!context.lastIsDefault) if (context.defaultBodySegments) {
-			removeConnection(context.defaultSegments, context.defaultBodySegments);
-			makeLooped(this, lastCaseSegments, context.defaultBodySegments);
-		} else brokenForkContext.add(lastCaseSegments);
+		if (!context.lastIsDefault) {
+			if (context.defaultBodySegments) {
+				removeConnection(context.defaultSegments, context.defaultBodySegments);
+				makeLooped(this, lastCaseSegments, context.defaultBodySegments);
+			} else brokenForkContext.add(lastCaseSegments);
+		}
 		for (let i = 0; i < context.countForks; ++i) this.forkContext = this.forkContext.upper;
 		this.forkContext.replaceHead(brokenForkContext.makeNext(0, -1));
 	}
@@ -6265,10 +6272,12 @@ var CodePathState = class {
 		const forkContext = this.forkContext;
 		if (!forkContext.reachable) return;
 		const context = getContinueContext(this, label);
-		if (context) if (context.continueDestSegments != null) {
-			makeLooped(this, forkContext.head, context.continueDestSegments);
-			if (context.type === "ForInStatement" || context.type === "ForOfStatement") context.brokenForkContext.add(forkContext.head);
-		} else context.continueForkContext.add(forkContext.head);
+		if (context) {
+			if (context.continueDestSegments != null) {
+				makeLooped(this, forkContext.head, context.continueDestSegments);
+				if (context.type === "ForInStatement" || context.type === "ForOfStatement") context.brokenForkContext.add(forkContext.head);
+			} else context.continueForkContext.add(forkContext.head);
+		}
 		forkContext.replaceHead(forkContext.makeUnreachable(-1, -1));
 	}
 	/**
@@ -6663,14 +6672,11 @@ function preprocess(analyzer, node) {
 				state.makeForInOfBody();
 			}
 			break;
-		case "AssignmentPattern":
-			if (parent.right === node) {
-				state.pushForkContext();
-				state.forkBypassPath();
-				state.forkPath();
-			}
-			break;
-		default: break;
+		case "AssignmentPattern": if (parent.right === node) {
+			state.pushForkContext();
+			state.forkBypassPath();
+			state.forkPath();
+		}
 	}
 }
 /**
@@ -6745,10 +6751,7 @@ function processCodePathToEnter(analyzer, node) {
 		case "ForOfStatement":
 			state.pushLoopContext(node.type, getLabel(node));
 			break;
-		case "LabeledStatement":
-			if (!breakableTypePattern.test(node.body.type)) state.pushBreakContext(false, node.label.name);
-			break;
-		default: break;
+		case "LabeledStatement": if (!breakableTypePattern.test(node.body.type)) state.pushBreakContext(false, node.label.name);
 	}
 	forwardCurrentToHead(analyzer, node);
 }
@@ -6826,10 +6829,7 @@ function processCodePathToExit(analyzer, node) {
 		case "AssignmentPattern":
 			state.popForkContext();
 			break;
-		case "LabeledStatement":
-			if (!breakableTypePattern.test(node.body.type)) state.popBreakContext();
-			break;
-		default: break;
+		case "LabeledStatement": if (!breakableTypePattern.test(node.body.type)) state.popBreakContext();
 	}
 	if (!dontForward) forwardCurrentToHead(analyzer, node);
 }
@@ -6854,10 +6854,7 @@ function postprocess(analyzer, node) {
 		case "StaticBlock":
 			endCodePath();
 			break;
-		case "CallExpression":
-			if (node.optional === true && node.arguments.length === 0) CodePath.getState(analyzer.codePath).makeOptionalRight();
-			break;
-		default: break;
+		case "CallExpression": if (node.optional === true && node.arguments.length === 0) CodePath.getState(analyzer.codePath).makeOptionalRight();
 	}
 	if (isPropertyDefinitionValue(node)) endCodePath();
 }
@@ -7317,12 +7314,13 @@ const rule = {
 */
 function getFunctionName(node) {
 	if (node.type === "ComponentDeclaration" || node.type === "HookDeclaration" || node.type === "FunctionDeclaration" || node.type === "FunctionExpression" && node.id) return node.id;
-	else if (node.type === "FunctionExpression" || node.type === "ArrowFunctionExpression") if (node.parent?.type === "VariableDeclarator" && node.parent.init === node) return node.parent.id;
-	else if (node.parent?.type === "AssignmentExpression" && node.parent.right === node && node.parent.operator === "=") return node.parent.left;
-	else if (node.parent?.type === "Property" && node.parent.value === node && !node.parent.computed) return node.parent.key;
-	else if (node.parent?.type === "AssignmentPattern" && node.parent.right === node && !node.parent.computed) return node.parent.left;
-	else return;
-	else return;
+	else if (node.type === "FunctionExpression" || node.type === "ArrowFunctionExpression") {
+		if (node.parent?.type === "VariableDeclarator" && node.parent.init === node) return node.parent.id;
+		else if (node.parent?.type === "AssignmentExpression" && node.parent.right === node && node.parent.operator === "=") return node.parent.left;
+		else if (node.parent?.type === "Property" && node.parent.value === node && !node.parent.computed) return node.parent.key;
+		else if (node.parent?.type === "AssignmentPattern" && node.parent.right === node && !node.parent.computed) return node.parent.left;
+		else return;
+	} else return;
 }
 /**
 * Convenience function for peeking the last item in a stack.
@@ -7554,13 +7552,15 @@ function create$5(context) {
 				const isAt = Extract.getCalleeName(callee) === "at";
 				const [index] = callee.arguments;
 				if (!isAt || index == null) return false;
-				return getStaticValue(index, context.sourceCode.getScope(node))?.value === 1 && isIdFromUseStateCall(innerCallee.object);
+				const indexScope = context.sourceCode.getScope(node);
+				return getStaticValue(index, indexScope)?.value === 1 && isIdFromUseStateCall(innerCallee.object);
 			}
 			case AST_NODE_TYPES.Identifier: return isIdFromUseStateCall(callee, 1);
 			case AST_NODE_TYPES.MemberExpression: {
 				if (!("name" in callee.object)) return false;
 				const property = callee.property;
-				return getStaticValue(property, context.sourceCode.getScope(node))?.value === 1 && isIdFromUseStateCall(callee.object, 1);
+				const propertyScope = context.sourceCode.getScope(node);
+				return getStaticValue(property, propertyScope)?.value === 1 && isIdFromUseStateCall(callee.object, 1);
 			}
 			default: return false;
 		}
@@ -7713,7 +7713,6 @@ function isInsideConditional(node, stopAt) {
 			case AST_NODE_TYPES.LogicalExpression:
 			case AST_NODE_TYPES.SwitchStatement:
 			case AST_NODE_TYPES.SwitchCase: return true;
-			default: break;
 		}
 		current = current.parent;
 	}
@@ -7776,13 +7775,15 @@ function create$4(context) {
 				const isAt = Extract.getCalleeName(callee) === "at";
 				const [index] = callee.arguments;
 				if (!isAt || index == null) return false;
-				return getStaticValue(index, context.sourceCode.getScope(node))?.value === 1 && isIdFromUseStateCall(innerCallee.object);
+				const indexScope = context.sourceCode.getScope(node);
+				return getStaticValue(index, indexScope)?.value === 1 && isIdFromUseStateCall(innerCallee.object);
 			}
 			case AST_NODE_TYPES.Identifier: return isIdFromUseStateCall(callee, 1);
 			case AST_NODE_TYPES.MemberExpression: {
 				if (!("name" in callee.object)) return false;
 				const property = callee.property;
-				return getStaticValue(property, context.sourceCode.getScope(node))?.value === 1 && isIdFromUseStateCall(callee.object, 1);
+				const propertyScope = context.sourceCode.getScope(node);
+				return getStaticValue(property, propertyScope)?.value === 1 && isIdFromUseStateCall(callee.object, 1);
 			}
 			default: return false;
 		}
@@ -7857,7 +7858,8 @@ const DYNAMIC_EXPRESSION_TYPES = /* @__PURE__ */ new Set([
 	AST_NODE_TYPES.NewExpression
 ]);
 function findVariableForIdentifier(context, identifier) {
-	return findVariable(context.sourceCode.getScope(identifier), identifier.name);
+	const scope = context.sourceCode.getScope(identifier);
+	return findVariable(scope, identifier.name);
 }
 /**
 * Resolves an expression down to the node that dynamically created its value, if any.
@@ -8121,7 +8123,8 @@ function create$1(context) {
 			const left = Extract.unwrap(node.left);
 			if (left.type !== AST_NODE_TYPES.Identifier) return;
 			if (Traverse.findParent(node, Check.isFunction, (n) => n === callback) != null) return;
-			const variable = findVariable(context.sourceCode.getScope(left), left);
+			const scope = context.sourceCode.getScope(left);
+			const variable = findVariable(scope, left);
 			if (variable != null && variable.defs.length > 0 && isDeclaredInsideCallback(variable, callback)) return;
 			violations.push({
 				messageId: "noReassigningOuterVariables",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-x",
-  "version": "5.18.3",
+  "version": "5.18.4",
   "description": "A set of composable ESLint rules for libraries and frameworks that use React as a UI runtime.",
   "keywords": [
     "react",
@@ -45,26 +45,26 @@
     "string-ts": "^2.3.1",
     "ts-api-utils": "^2.5.0",
     "ts-pattern": "^5.9.0",
-    "@eslint-react/ast": "5.18.3",
-    "@eslint-react/core": "5.18.3",
-    "@eslint-react/eslint": "5.18.3",
-    "@eslint-react/shared": "5.18.3",
-    "@eslint-react/var": "5.18.3",
-    "@eslint-react/jsx": "5.18.3"
+    "@eslint-react/ast": "5.18.4",
+    "@eslint-react/core": "5.18.4",
+    "@eslint-react/eslint": "5.18.4",
+    "@eslint-react/jsx": "5.18.4",
+    "@eslint-react/var": "5.18.4",
+    "@eslint-react/shared": "5.18.4"
   },
   "devDependencies": {
     "@types/react": "^19.2.18",
     "@types/react-dom": "^19.2.4",
     "dedent": "^1.7.2",
-    "eslint": "^10.8.0",
+    "eslint": "^10.8.1",
     "react": "^19.2.8",
     "react-dom": "^19.2.8",
     "tsdown": "^0.22.14",
     "tsl": "^1.0.30",
     "tsl-dx": "^0.13.3",
     "typescript": "6.0.3",
-    "@local/eff": "0.0.0",
-    "@local/configs": "0.0.0"
+    "@local/configs": "0.0.0",
+    "@local/eff": "0.0.0"
   },
   "peerDependencies": {
     "eslint": "*",