eslint-plugin-react-x 5.14.7 → 5.14.8

package/dist/index.js

@@ -144,7 +144,7 @@ const rules$6 = {
 //#endregion
 //#region package.json
 var name$6 = "eslint-plugin-react-x";
-var version = "5.14.7";
+var version = "5.14.8";
 
 //#endregion
 //#region src/utils/create-rule.ts
@@ -4212,21 +4212,6 @@ const IMPURE_CTORS = /* @__PURE__ */ new Set([
 	"Worker",
 	"XMLHttpRequest"
 ]);
-
-//#endregion
-//#region src/rules/purity/purity.ts
-const RULE_NAME$7 = "purity";
-var purity_default = createRule({
-	meta: {
-		type: "problem",
-		docs: { description: "Validates that components and hooks are pure by checking that they do not call known-impure functions during render." },
-		messages: { default: "Do not call '{{name}}' during render. Components and hooks must be pure. Move this call into an event handler, effect, or state initializer." },
-		schema: []
-	},
-	name: RULE_NAME$7,
-	create: create$7,
-	defaultOptions: []
-});
 /**
 * Recursively resolve an identifier to the root builtin global object name.
 * Follows simple assignment chains like `const M = Math` or `const w = window`.
@@ -4254,6 +4239,21 @@ function resolveBuiltinObjectName(context, node, seen = /* @__PURE__ */ new Set(
 	}
 	return null;
 }
+
+//#endregion
+//#region src/rules/purity/purity.ts
+const RULE_NAME$7 = "purity";
+var purity_default = createRule({
+	meta: {
+		type: "problem",
+		docs: { description: "Validates that components and hooks are pure by checking that they do not call known-impure functions during render." },
+		messages: { default: "Do not call '{{name}}' during render. Components and hooks must be pure. Move this call into an event handler, effect, or state initializer." },
+		schema: []
+	},
+	name: RULE_NAME$7,
+	create: create$7,
+	defaultOptions: []
+});
 function create$7(context) {
 	const hc = core.getHookCollector(context);
 	const fc = core.getFunctionComponentCollector(context);
@@ -4341,6 +4341,150 @@ const SYNC_ARRAY_CALLBACKS = /* @__PURE__ */ new Set([
 	"some",
 	"sort"
 ]);
+function createBindingResolver(context) {
+	const bindings = /* @__PURE__ */ new Map();
+	const memberBindings = /* @__PURE__ */ new Map();
+	const jsxRefs = /* @__PURE__ */ new Set();
+	function getVariable(node) {
+		return findVariable(context.sourceCode.getScope(node), node) ?? null;
+	}
+	function getBindingValue(node) {
+		const value = Extract.unwrap(node);
+		if (value.type === AST_NODE_TYPES.Identifier) {
+			const variable = getVariable(value);
+			return variable == null ? { kind: "unknown" } : {
+				kind: "variable",
+				variable
+			};
+		}
+		if (isFunctionExpressionLike(value)) return {
+			kind: "function",
+			node: value
+		};
+		if (value.type === AST_NODE_TYPES.CallExpression && (core.isUseRefCall(context, value) || core.isCreateRefCall(context, value))) return { kind: "ref" };
+		if (value.type === AST_NODE_TYPES.MemberExpression) {
+			const property = Extract.getPropertyName(value.property);
+			if (property != null && isRefLikeName(property)) return { kind: "ref" };
+		}
+		return { kind: "unknown" };
+	}
+	function addBinding(variable, value, position) {
+		const events = bindings.get(variable) ?? [];
+		bindings.set(variable, events);
+		events.push({
+			position,
+			value
+		});
+	}
+	function addIdentifierBinding(node, value, position = node.range[0]) {
+		const variable = getVariable(node);
+		if (variable != null) addBinding(variable, getBindingValue(value), position);
+	}
+	function addFunctionBinding(node, value, position) {
+		const variable = getVariable(node);
+		if (variable != null) addBinding(variable, {
+			kind: "function",
+			node: value
+		}, position);
+	}
+	function addMemberBinding(object, property, value, position) {
+		const variable = getVariable(object);
+		if (variable == null) return;
+		const properties = memberBindings.get(variable) ?? /* @__PURE__ */ new Map();
+		memberBindings.set(variable, properties);
+		const events = properties.get(property) ?? [];
+		properties.set(property, events);
+		events.push({
+			position,
+			value: getBindingValue(value)
+		});
+	}
+	function addJsxRef(node) {
+		const variable = getVariable(node);
+		if (variable != null) jsxRefs.add(variable);
+	}
+	function resolveRef(variable, position, seen = /* @__PURE__ */ new Set()) {
+		if (seen.has(variable)) return null;
+		seen.add(variable);
+		if (jsxRefs.has(variable) || isRefLikeName(variable.name)) return variable;
+		const event = getLatestValue(bindings.get(variable), position);
+		if (event != null) switch (event.value.kind) {
+			case "ref": return variable;
+			case "variable": return resolveRef(event.value.variable, event.position, seen);
+			case "function":
+			case "unknown": return null;
+		}
+		return null;
+	}
+	function resolveFunction(variable, position, seen = /* @__PURE__ */ new Set()) {
+		if (seen.has(variable)) return null;
+		seen.add(variable);
+		const event = getLatestValue(bindings.get(variable), position);
+		if (event == null) return null;
+		switch (event.value.kind) {
+			case "function": return event.value.node;
+			case "variable": return resolveFunction(event.value.variable, event.position, seen);
+			case "ref":
+			case "unknown": return null;
+		}
+	}
+	function resolveCallable(node, position) {
+		const callee = Extract.unwrap(node);
+		if (isFunctionExpressionLike(callee)) return callee;
+		if (callee.type === AST_NODE_TYPES.Identifier) {
+			const variable = getVariable(callee);
+			return variable == null ? null : resolveFunction(variable, position);
+		}
+		if (callee.type !== AST_NODE_TYPES.MemberExpression) return null;
+		const object = Extract.unwrap(callee.object);
+		const property = Extract.getPropertyName(callee.property);
+		if (object.type !== AST_NODE_TYPES.Identifier || property == null) return null;
+		const variable = getVariable(object);
+		if (variable == null) return null;
+		const event = getLatestValue(memberBindings.get(variable)?.get(property), position);
+		if (event == null) return null;
+		if (event.value.kind === "function") return event.value.node;
+		if (event.value.kind === "variable") return resolveFunction(event.value.variable, event.position);
+		return null;
+	}
+	function getRefTarget(node) {
+		const object = Extract.unwrap(node.object);
+		if (object.type === AST_NODE_TYPES.Identifier) {
+			const variable = getVariable(object);
+			if (variable == null) return null;
+			const identity = resolveRef(variable, node.range[0]);
+			return identity == null ? null : { identity };
+		}
+		if (object.type === AST_NODE_TYPES.MemberExpression) {
+			const property = Extract.getPropertyName(object.property);
+			if (property != null && isRefLikeName(property)) return { identity: null };
+		}
+		return null;
+	}
+	function getNullBranch(test, identity) {
+		return getNullCheckBranch(test, (candidate) => {
+			if (candidate.type !== AST_NODE_TYPES.MemberExpression || Extract.getPropertyName(candidate.property) !== "current") return false;
+			return getRefTarget(candidate)?.identity === identity;
+		}, (candidate) => {
+			if (candidate.type === AST_NODE_TYPES.Literal) return candidate.value == null;
+			if (candidate.type === AST_NODE_TYPES.UnaryExpression && candidate.operator === "void") return true;
+			if (candidate.type !== AST_NODE_TYPES.Identifier || candidate.name !== "undefined") return false;
+			const variable = getVariable(candidate);
+			return variable == null || variable.defs.length === 0;
+		});
+	}
+	return {
+		addFunctionBinding,
+		addIdentifierBinding,
+		addJsxRef,
+		addMemberBinding,
+		getNullBranch,
+		getRefTarget,
+		getVariable,
+		resolveCallable,
+		resolveRef
+	};
+}
 function getLatestValue(events, position) {
 	let latest = null;
 	for (const event of events ?? []) {
@@ -4381,6 +4525,16 @@ function isReachedThroughFunctions(node, boundary, reached) {
 	}
 	return current === boundary;
 }
+function getRefAccess(node) {
+	let parent = node.parent;
+	while (Check.isTypeExpression(parent)) parent = parent.parent;
+	const isDirectWrite = parent.type === AST_NODE_TYPES.AssignmentExpression ? parent.left === node || Extract.unwrap(parent.left) === node : parent.type === AST_NODE_TYPES.UpdateExpression ? parent.argument === node || Extract.unwrap(parent.argument) === node : false;
+	return {
+		isInitializationWrite: parent.type === AST_NODE_TYPES.AssignmentExpression && parent.operator === "=" && (parent.left === node || Extract.unwrap(parent.left) === node),
+		isWrite: isDirectWrite || isNestedRefCurrentWrite(node),
+		node
+	};
+}
 /**
 * Check whether `node` (a `ref.current` MemberExpression) is being written to indirectly through
 * a nested property write, e.g. `ref.current.inner = value` or `ref.current.inner++`.
@@ -4402,16 +4556,6 @@ function isNestedRefCurrentWrite(node) {
 		return false;
 	}
 }
-function getRefAccess(node) {
-	let parent = node.parent;
-	while (Check.isTypeExpression(parent)) parent = parent.parent;
-	const isDirectWrite = parent.type === AST_NODE_TYPES.AssignmentExpression ? parent.left === node || Extract.unwrap(parent.left) === node : parent.type === AST_NODE_TYPES.UpdateExpression ? parent.argument === node || Extract.unwrap(parent.argument) === node : false;
-	return {
-		isInitializationWrite: parent.type === AST_NODE_TYPES.AssignmentExpression && parent.operator === "=" && (parent.left === node || Extract.unwrap(parent.left) === node),
-		isWrite: isDirectWrite || isNestedRefCurrentWrite(node),
-		node
-	};
-}
 /**
 * Parse an exact nullish check and return the branch where the checked value is null/undefined.
 * Truthiness checks such as `!ref.current` are deliberately excluded: falsy ref values are not
@@ -4475,7 +4619,7 @@ function isAfterTerminatingNonNullGuard(node, getNullBranch) {
 		statement = statement.parent;
 	}
 	const block = statement.parent;
-	const index = block.body.indexOf(statement);
+	const index = block.body.findIndex((sibling) => sibling === statement);
 	for (let i = index - 1; i >= 0; i--) {
 		const sibling = block.body[i];
 		if (sibling?.type !== AST_NODE_TYPES.IfStatement) continue;
@@ -4509,156 +4653,33 @@ var refs_default = createRule({
 function create$6(context) {
 	const hc = core.getHookCollector(context);
 	const fc = core.getFunctionComponentCollector(context);
-	const bindings = /* @__PURE__ */ new Map();
-	const memberBindings = /* @__PURE__ */ new Map();
-	const jsxRefs = /* @__PURE__ */ new Set();
+	const { addFunctionBinding, addIdentifierBinding, addJsxRef, addMemberBinding, getNullBranch, getRefTarget, getVariable, resolveCallable, resolveRef } = createBindingResolver(context);
 	const calls = [];
 	const refAccesses = [];
-	function getVariable(node) {
-		return findVariable(context.sourceCode.getScope(node), node) ?? null;
-	}
-	function addBinding(variable, value, position) {
-		const events = bindings.get(variable) ?? [];
-		bindings.set(variable, events);
-		events.push({
-			position,
-			value
-		});
-	}
-	function addIdentifierBinding(node, value, position = node.range[0]) {
-		const variable = getVariable(node);
-		if (variable != null) addBinding(variable, value, position);
-	}
-	function addMemberBinding(object, property, value, position) {
-		const variable = getVariable(object);
-		if (variable == null) return;
-		const properties = memberBindings.get(variable) ?? /* @__PURE__ */ new Map();
-		memberBindings.set(variable, properties);
-		const events = properties.get(property) ?? [];
-		properties.set(property, events);
-		events.push({
-			position,
-			value
-		});
-	}
-	function bindingValueFrom(node) {
-		const value = Extract.unwrap(node);
-		if (value.type === AST_NODE_TYPES.Identifier) {
-			const variable = getVariable(value);
-			return variable == null ? { kind: "unknown" } : {
-				kind: "variable",
-				variable
-			};
-		}
-		if (isFunctionExpressionLike(value)) return {
-			kind: "function",
-			node: value
-		};
-		if (value.type === AST_NODE_TYPES.CallExpression && (core.isUseRefCall(context, value) || core.isCreateRefCall(context, value))) return { kind: "ref" };
-		if (value.type === AST_NODE_TYPES.MemberExpression) {
-			const property = Extract.getPropertyName(value.property);
-			if (property != null && isRefLikeName(property)) return { kind: "ref" };
-		}
-		return { kind: "unknown" };
-	}
-	function resolveRef(variable, position, seen = /* @__PURE__ */ new Set()) {
-		if (seen.has(variable)) return null;
-		seen.add(variable);
-		if (jsxRefs.has(variable) || isRefLikeName(variable.name)) return variable;
-		const event = getLatestValue(bindings.get(variable), position);
-		if (event != null) switch (event.value.kind) {
-			case "ref": return variable;
-			case "variable": return resolveRef(event.value.variable, event.position, seen);
-			case "function":
-			case "unknown": return null;
-		}
-		return null;
-	}
-	function resolveFunction(variable, position, seen = /* @__PURE__ */ new Set()) {
-		if (seen.has(variable)) return null;
-		seen.add(variable);
-		const event = getLatestValue(bindings.get(variable), position);
-		if (event == null) return null;
-		switch (event.value.kind) {
-			case "function": return event.value.node;
-			case "variable": return resolveFunction(event.value.variable, event.position, seen);
-			case "ref":
-			case "unknown": return null;
-		}
-	}
-	function resolveCallable(node, position) {
-		const callee = Extract.unwrap(node);
-		if (isFunctionExpressionLike(callee)) return callee;
-		if (callee.type === AST_NODE_TYPES.Identifier) {
-			const variable = getVariable(callee);
-			return variable == null ? null : resolveFunction(variable, position);
-		}
-		if (callee.type !== AST_NODE_TYPES.MemberExpression) return null;
-		const object = Extract.unwrap(callee.object);
-		const property = Extract.getPropertyName(callee.property);
-		if (object.type !== AST_NODE_TYPES.Identifier || property == null) return null;
-		const variable = getVariable(object);
-		if (variable == null) return null;
-		const event = getLatestValue(memberBindings.get(variable)?.get(property), position);
-		if (event == null) return null;
-		if (event.value.kind === "function") return event.value.node;
-		if (event.value.kind === "variable") return resolveFunction(event.value.variable, event.position);
-		return null;
-	}
-	function getRefTarget(node) {
-		const object = Extract.unwrap(node.object);
-		if (object.type === AST_NODE_TYPES.Identifier) {
-			const variable = getVariable(object);
-			if (variable == null) return null;
-			const identity = resolveRef(variable, node.range[0]);
-			return identity == null ? null : { identity };
-		}
-		if (object.type === AST_NODE_TYPES.MemberExpression) {
-			const property = Extract.getPropertyName(object.property);
-			if (property != null && isRefLikeName(property)) return { identity: null };
-		}
-		return null;
-	}
-	function getNullBranch(test, identity) {
-		return getNullCheckBranch(test, (candidate) => {
-			if (candidate.type !== AST_NODE_TYPES.MemberExpression || Extract.getPropertyName(candidate.property) !== "current") return false;
-			return getRefTarget(candidate)?.identity === identity;
-		}, (candidate) => {
-			if (candidate.type === AST_NODE_TYPES.Literal) return candidate.value == null;
-			if (candidate.type === AST_NODE_TYPES.UnaryExpression && candidate.operator === "void") return true;
-			if (candidate.type !== AST_NODE_TYPES.Identifier || candidate.name !== "undefined") return false;
-			const variable = getVariable(candidate);
-			return variable == null || variable.defs.length === 0;
-		});
-	}
 	return merge(hc.visitor, fc.visitor, {
 		AssignmentExpression(node) {
 			if (node.operator !== "=") return;
 			const left = Extract.unwrap(node.left);
 			if (left.type === AST_NODE_TYPES.Identifier) {
-				addIdentifierBinding(left, bindingValueFrom(node.right), node.range[0]);
+				addIdentifierBinding(left, node.right, node.range[0]);
 				return;
 			}
 			if (left.type !== AST_NODE_TYPES.MemberExpression) return;
 			const object = Extract.unwrap(left.object);
 			const property = Extract.getPropertyName(left.property);
-			if (object.type === AST_NODE_TYPES.Identifier && property != null) addMemberBinding(object, property, bindingValueFrom(node.right), node.range[0]);
+			if (object.type === AST_NODE_TYPES.Identifier && property != null) addMemberBinding(object, property, node.right, node.range[0]);
 		},
 		CallExpression(node) {
 			calls.push(node);
 		},
 		FunctionDeclaration(node) {
-			if (node.id != null) addIdentifierBinding(node.id, {
-				kind: "function",
-				node
-			}, -1);
+			if (node.id != null) addFunctionBinding(node.id, node, -1);
 		},
 		JSXAttribute(node) {
 			if (node.name.type !== AST_NODE_TYPES.JSXIdentifier || node.name.name !== "ref" || node.value?.type !== AST_NODE_TYPES.JSXExpressionContainer) return;
 			const expression = Extract.unwrap(node.value.expression);
 			if (expression.type !== AST_NODE_TYPES.Identifier) return;
-			const variable = getVariable(expression);
-			if (variable != null) jsxRefs.add(variable);
+			addJsxRef(expression);
 		},
 		MemberExpression(node) {
 			if (Extract.getPropertyName(node.property) !== "current") return;
@@ -4752,7 +4773,7 @@ function create$6(context) {
 		},
 		VariableDeclarator(node) {
 			if (node.id.type !== AST_NODE_TYPES.Identifier || node.init == null) return;
-			addIdentifierBinding(node.id, bindingValueFrom(node.init), node.range[0]);
+			addIdentifierBinding(node.id, node.init, node.range[0]);
 		}
 	});
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-x",
-  "version": "5.14.7",
+  "version": "5.14.8",
   "description": "A set of composable ESLint rules for libraries and frameworks that use React as a UI runtime.",
   "keywords": [
     "react",
@@ -45,12 +45,12 @@
     "string-ts": "^2.3.1",
     "ts-api-utils": "^2.5.0",
     "ts-pattern": "^5.9.0",
-    "@eslint-react/ast": "5.14.7",
-    "@eslint-react/core": "5.14.7",
-    "@eslint-react/eslint": "5.14.7",
-    "@eslint-react/jsx": "5.14.7",
-    "@eslint-react/var": "5.14.7",
-    "@eslint-react/shared": "5.14.7"
+    "@eslint-react/core": "5.14.8",
+    "@eslint-react/eslint": "5.14.8",
+    "@eslint-react/jsx": "5.14.8",
+    "@eslint-react/var": "5.14.8",
+    "@eslint-react/shared": "5.14.8",
+    "@eslint-react/ast": "5.14.8"
   },
   "devDependencies": {
     "@types/react": "^19.2.17",
@@ -59,7 +59,7 @@
     "eslint": "^10.7.0",
     "react": "^19.2.7",
     "react-dom": "^19.2.7",
-    "tsdown": "^0.22.4",
+    "tsdown": "^0.22.5",
     "tsl": "^1.0.30",
     "tsl-dx": "^0.13.2",
     "typescript": "6.0.3",