eslint-plugin-react-x 4.0.2-beta.0 → 4.0.2-beta.1

package/dist/index.js

@@ -147,7 +147,7 @@ const rules$7 = {
 //#endregion
 //#region package.json
 var name$6 = "eslint-plugin-react-x";
-var version = "4.0.2-beta.0";
+var version = "4.0.2-beta.1";
 
 //#endregion
 //#region src/utils/create-rule.ts
@@ -1377,8 +1377,12 @@ function create$54(context) {
 		return declarator.id.elements.findIndex((el) => el?.type === AST_NODE_TYPES.Identifier && el.name === id.name) === 0;
 	}
 	/**
-	* Return true when `id` is a direct (non-destructured) props parameter at
-	* position 0 of any ancestor function.
+	* Return the function node when `id` is a direct (non-destructured) props
+	* parameter at position 0 of any ancestor function; otherwise return `null`.
+	*
+	* The caller must later verify (at Program:exit) that the returned function
+	* is actually a component or hook — event handler parameters share the same
+	* syntactic shape but should **not** be treated as React props.
 	*
 	* Uses scope resolution so that references to `props` inside nested arrow
 	* functions (ex: event handlers) are correctly traced back to the component
@@ -1390,18 +1394,19 @@ function create$54(context) {
 	*     };
 	*   }
 	* @param id The identifier to check. May be a reference to the props parameter, e.g. used inside an event handler nested in the component body — scope resolution will trace it back to the original declaration.
-	* @returns True if `id` is a props parameter, false otherwise.
+	* @returns The function node where `id` is the first parameter, or `null`.
 	*/
-	function isPropsObject(id) {
+	function getPropsDefiningFunction(id) {
 		const variable = findVariable(context.sourceCode.getScope(id), id);
-		if (variable == null) return false;
+		if (variable == null) return null;
 		for (const def of variable.defs) {
 			if (def.type !== DefinitionType.Parameter) continue;
 			if (!ast.isFunction(def.node)) continue;
-			const firstParam = def.node.params.at(0);
-			return firstParam?.type === AST_NODE_TYPES.Identifier && firstParam.name === id.name;
+			const fn = def.node;
+			const firstParam = fn.params.at(0);
+			if (firstParam?.type === AST_NODE_TYPES.Identifier && firstParam.name === id.name) return fn;
 		}
-		return false;
+		return null;
 	}
 	return defineRuleListener(hCollector.visitor, cCollector.visitor, {
 		CallExpression(node) {
@@ -1415,8 +1420,8 @@ function create$54(context) {
 			const enclosingFn = ast.findParent(node, ast.isFunction);
 			if (enclosingFn == null) return;
 			const isState = isStateValue(rootId);
-			const isProps = isPropsObject(rootId);
-			if (!isState && !isProps) return;
+			const propsDefiningFunc = !isState ? getPropsDefiningFunction(rootId) : null;
+			if (!isState && propsDefiningFunc == null) return;
 			violations.push({
 				data: {
 					name: context.sourceCode.getText(object),
@@ -1424,7 +1429,8 @@ function create$54(context) {
 				},
 				func: enclosingFn,
 				messageId: "mutatingArrayMethod",
-				node
+				node,
+				...propsDefiningFunc != null ? { propsDefiningFunc } : {}
 			});
 		},
 		AssignmentExpression(node) {
@@ -1435,20 +1441,21 @@ function create$54(context) {
 			const enclosingFn = ast.findParent(node, ast.isFunction);
 			if (enclosingFn == null) return;
 			const isState = isStateValue(rootId);
-			const isProps = isPropsObject(rootId);
-			if (!isState && !isProps) return;
+			const propsDefiningFunc = !isState ? getPropsDefiningFunction(rootId) : null;
+			if (!isState && propsDefiningFunc == null) return;
 			violations.push({
 				data: { name: context.sourceCode.getText(node.left.object) },
 				func: enclosingFn,
 				messageId: "mutatingAssignment",
-				node
+				node,
+				...propsDefiningFunc != null ? { propsDefiningFunc } : {}
 			});
 		},
 		"Program:exit"(node) {
 			const comps = cCollector.api.getAllComponents(node);
 			const hooks = hCollector.api.getAllHooks(node);
 			const funcs = [...comps, ...hooks];
-			for (const { data, func, messageId, node } of violations) {
+			for (const { data, func, messageId, node, propsDefiningFunc } of violations) {
 				let current = func;
 				let insideComponentOrHook = false;
 				while (current != null) {
@@ -1459,6 +1466,9 @@ function create$54(context) {
 					current = ast.findParent(current, ast.isFunction);
 				}
 				if (!insideComponentOrHook) continue;
+				if (propsDefiningFunc != null) {
+					if (!funcs.some((f) => f.node === propsDefiningFunc)) continue;
+				}
 				context.report({
 					data,
 					messageId,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-x",
-  "version": "4.0.2-beta.0",
+  "version": "4.0.2-beta.1",
   "description": "A set of composable ESLint rules for libraries and frameworks that use React as a UI runtime.",
   "keywords": [
     "react",
@@ -45,11 +45,11 @@
     "string-ts": "^2.3.1",
     "ts-api-utils": "^2.5.0",
     "ts-pattern": "^5.9.0",
-    "@eslint-react/ast": "4.0.2-beta.0",
-    "@eslint-react/core": "4.0.2-beta.0",
-    "@eslint-react/shared": "4.0.2-beta.0",
-    "@eslint-react/var": "4.0.2-beta.0",
-    "@eslint-react/jsx": "4.0.2-beta.0"
+    "@eslint-react/ast": "4.0.2-beta.1",
+    "@eslint-react/core": "4.0.2-beta.1",
+    "@eslint-react/shared": "4.0.2-beta.1",
+    "@eslint-react/jsx": "4.0.2-beta.1",
+    "@eslint-react/var": "4.0.2-beta.1"
   },
   "devDependencies": {
     "@types/react": "^19.2.14",