eslint-plugin-react-x 3.0.0-next.56 → 3.0.0-next.58

package/dist/index.js

@@ -1,4 +1,4 @@
-import { DEFAULT_ESLINT_REACT_SETTINGS, IMPURE_CTORS, IMPURE_FUNCS, WEBSITE_URL, coerceSettings, defineRuleListener, getSettingsFromContext, report, toRegExp } from "@eslint-react/shared";
+import { DEFAULT_ESLINT_REACT_SETTINGS, IMPURE_CTORS, IMPURE_FUNCS, WEBSITE_URL, defineRuleListener, getSettingsFromContext, report, toRegExp } from "@eslint-react/shared";
 import * as ast from "@eslint-react/ast";
 import * as core from "@eslint-react/core";
 import { ESLintUtils } from "@typescript-eslint/utils";
@@ -68,7 +68,7 @@ const rules$7 = {
 //#endregion
 //#region package.json
 var name$6 = "eslint-plugin-react-x";
-var version = "3.0.0-next.56";
+var version = "3.0.0-next.58";
 
 //#endregion
 //#region src/utils/create-rule.ts
@@ -1812,7 +1812,6 @@ function create$51(context) {
 //#endregion
 //#region src/rules/no-array-index-key/no-array-index-key.ts
 const RULE_NAME$50 = "no-array-index-key";
-const REACT_CHILDREN_METHOD = ["forEach", "map"];
 function getIndexParamPosition(methodName) {
 	switch (methodName) {
 		case "every":
@@ -1830,19 +1829,6 @@ function getIndexParamPosition(methodName) {
 		default: return -1;
 	}
 }
-function isReactChildrenMethod(name) {
-	return REACT_CHILDREN_METHOD.includes(name);
-}
-function isUsingReactChildren(context, node) {
-	const { importSource = "react" } = coerceSettings(context.settings);
-	const { callee } = node;
-	if (!("property" in callee) || !("object" in callee) || !("name" in callee.property)) return false;
-	if (!isReactChildrenMethod(callee.property.name)) return false;
-	const initialScope = context.sourceCode.getScope(node);
-	if (callee.object.type === AST_NODE_TYPES.Identifier && callee.object.name === "Children") return true;
-	if (callee.object.type === AST_NODE_TYPES.MemberExpression && "name" in callee.object.object) return core.isInitializedFromReact(callee.object.object.name, initialScope, importSource);
-	return false;
-}
 function getMapIndexParamName(context, node) {
 	const { callee } = node;
 	if (callee.type !== AST_NODE_TYPES.MemberExpression) return unit;
@@ -1850,7 +1836,7 @@ function getMapIndexParamName(context, node) {
 	const { name } = callee.property;
 	const indexPosition = getIndexParamPosition(name);
 	if (indexPosition === -1) return unit;
-	const callbackArg = node.arguments[isUsingReactChildren(context, node) ? 1 : 0];
+	const callbackArg = node.arguments[core.isChildrenMap(context, callee) || core.isChildrenForEach(context, callee) ? 1 : 0];
 	if (callbackArg == null) return unit;
 	if (!ast.isOneOf([AST_NODE_TYPES.ArrowFunctionExpression, AST_NODE_TYPES.FunctionExpression])(callbackArg)) return unit;
 	const { params } = callbackArg;
@@ -3990,7 +3976,6 @@ function create$9(context, [option]) {
 	* Check if a fragment node is useless and should be reported
 	*/
 	function checkNode(context, node) {
-		if (node.type === AST_NODE_TYPES.JSXElement && core.getJsxAttribute(context, node)("key") != null) return;
 		if (core.isJsxHostElement(context, node.parent)) context.report({
 			messageId: "default",
 			node,
@@ -4056,6 +4041,8 @@ function create$9(context, [option]) {
 	return defineRuleListener({
 		JSXElement(node) {
 			if (!core.isJsxFragmentElement(context, node, jsxConfig)) return;
+			if (core.getJsxAttribute(context, node)("key") != null) return;
+			if (core.getJsxAttribute(context, node)("ref") != null) return;
 			checkNode(context, node);
 		},
 		JSXFragment(node) {
@@ -4262,6 +4249,8 @@ function create$5(context) {
 	/**
 	* Check if a test expression is a null check on `ref.current` for a given ref name.
 	* Matches forms like `ref.current === null`, `null === ref.current`, and their != variants.
+	* @param test
+	* @param refName
 	*/
 	function isRefCurrentNullCheck(test, refName) {
 		if (test.type !== AST_NODE_TYPES.BinaryExpression) return false;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-x",
-  "version": "3.0.0-next.56",
+  "version": "3.0.0-next.58",
   "description": "A set of composable ESLint rules for libraries and frameworks that use React as a UI runtime.",
   "keywords": [
     "react",
@@ -45,11 +45,11 @@
     "string-ts": "^2.3.1",
     "ts-api-utils": "^2.4.0",
     "ts-pattern": "^5.9.0",
-    "@eslint-react/core": "3.0.0-next.56",
-    "@eslint-react/eff": "3.0.0-next.56",
-    "@eslint-react/shared": "3.0.0-next.56",
-    "@eslint-react/ast": "3.0.0-next.56",
-    "@eslint-react/var": "3.0.0-next.56"
+    "@eslint-react/ast": "3.0.0-next.58",
+    "@eslint-react/core": "3.0.0-next.58",
+    "@eslint-react/eff": "3.0.0-next.58",
+    "@eslint-react/var": "3.0.0-next.58",
+    "@eslint-react/shared": "3.0.0-next.58"
   },
   "devDependencies": {
     "@types/react": "^19.2.14",