eslint-plugin-react-x 3.0.0-next.20 → 3.0.0-next.23

package/dist/index.js

@@ -70,7 +70,7 @@ const rules$7 = {
 //#endregion
 //#region package.json
 var name$6 = "eslint-plugin-react-x";
-var version = "3.0.0-next.20";
+var version = "3.0.0-next.23";
 
 //#endregion
 //#region src/utils/create-rule.ts
@@ -475,6 +475,23 @@ function findComponentOrHookScope(node) {
 	return null;
 }
 /**
+* Check if a variable's definition is contained within a given AST node.
+* Used to exclude callback-local variables from the reactive deps list —
+* a variable declared inside the effect/memo callback is a local, not a dep.
+* @param variable - the variable to check
+* @param node - the node that must NOT contain the variable's definition
+*/
+function isDefinedInsideNode(variable, node) {
+	for (const def of variable.defs) {
+		let current = def.name;
+		while (current.parent != null) {
+			current = current.parent;
+			if (current === node) return true;
+		}
+	}
+	return false;
+}
+/**
 * Check if a variable is defined within the given function scope (reactive).
 * @param variable - the variable to check
 * @param scopeNode - the function scope to check against
@@ -586,6 +603,7 @@ function create$64(context) {
 				if (variable == null) continue;
 				if (isStableVariable(variable)) continue;
 				if (!isDefinedInScope(variable, componentScope)) continue;
+				if (isDefinedInsideNode(variable, callbackNode)) continue;
 				reactiveDeps.add(memberExprText);
 				continue;
 			}
@@ -593,6 +611,7 @@ function create$64(context) {
 			if (variable == null) continue;
 			if (isStableVariable(variable)) continue;
 			if (!isDefinedInScope(variable, componentScope)) continue;
+			if (isDefinedInsideNode(variable, callbackNode)) continue;
 			reactiveDeps.add(identifier.name);
 		}
 		return reactiveDeps;
@@ -642,6 +661,32 @@ function create$64(context) {
 		return deps;
 	}
 	/**
+	* Check if a reactive dependency is covered by a declared dependency.
+	* A declared dep covers a reactive dep if they are equal, or if the
+	* declared dep is a prefix ancestor (e.g. `array` covers `array.map`,
+	* `obj` covers `obj.a?.toString`).
+	* @param reactiveDep
+	* @param declaredDeps
+	*/
+	function isCoveredByDeclaredDep(reactiveDep, declaredDeps) {
+		if (declaredDeps.has(reactiveDep)) return true;
+		for (const declared of declaredDeps) if (reactiveDep.startsWith(`${declared}.`) || reactiveDep.startsWith(`${declared}?.`)) return true;
+		return false;
+	}
+	/**
+	* Check if a declared dependency covers at least one reactive dependency.
+	* A declared dep is considered necessary if it equals a reactive dep, or if
+	* it is a prefix ancestor of any reactive dep (e.g. `array` is necessary
+	* when `array.map` is reactive).
+	* @param declaredDep
+	* @param reactiveDeps
+	*/
+	function declaredDepCoversAny(declaredDep, reactiveDeps) {
+		if (reactiveDeps.has(declaredDep)) return true;
+		for (const reactive of reactiveDeps) if (reactive.startsWith(`${declaredDep}.`) || reactive.startsWith(`${declaredDep}?.`)) return true;
+		return false;
+	}
+	/**
 	* Generate a fix that produces a corrected dependency array.
 	* Removes unnecessary deps, adds missing deps, and sorts all alphabetically.
 	* @param depsNode - the dependency array node
@@ -666,9 +711,9 @@ function create$64(context) {
 		const reactiveDeps = collectReactiveDeps(callback, componentScope);
 		const declaredDeps = getDeclaredDeps(depsNode);
 		const missingDeps = /* @__PURE__ */ new Set();
-		for (const dep of reactiveDeps) if (!declaredDeps.has(dep)) missingDeps.add(dep);
+		for (const dep of reactiveDeps) if (!isCoveredByDeclaredDep(dep, declaredDeps)) missingDeps.add(dep);
 		const unnecessaryDeps = /* @__PURE__ */ new Set();
-		for (const dep of declaredDeps) if (!reactiveDeps.has(dep)) unnecessaryDeps.add(dep);
+		for (const dep of declaredDeps) if (!declaredDepCoversAny(dep, reactiveDeps)) unnecessaryDeps.add(dep);
 		const hasMissing = missingDeps.size > 0;
 		const hasUnnecessary = unnecessaryDeps.size > 0;
 		if (!hasMissing && !hasUnnecessary) return;
@@ -953,7 +998,7 @@ function create$58(context) {
 					fix: (fixer) => fixer.removeRange([node.name.range[1], value.range[1]])
 				});
 				break;
-			case policy === -1 && value === null:
+			case policy === -1 && value == null:
 				context.report({
 					messageId: "default",
 					node: node.value ?? node,
@@ -2104,7 +2149,14 @@ function create$32(ctx) {
 		}
 	}
 	function checkBlock(node) {
-		return ast.getNestedReturnStatements(node).filter((stmt) => stmt.argument != null).map((stmt) => check(stmt.argument)).filter((d) => d != null);
+		const descriptors = [];
+		for (const stmt of ast.getNestedReturnStatements(node)) {
+			if (stmt.argument == null) continue;
+			const desc = check(stmt.argument);
+			if (desc == null) continue;
+			descriptors.push(desc);
+		}
+		return descriptors;
 	}
 	return defineRuleListener({
 		ArrayExpression(node) {
@@ -3940,6 +3992,7 @@ function create$5(context) {
 			if (entry == null) continue;
 			if (entry.kind === "component" || entry.kind === "hook") return entry;
 		}
+		return unit;
 	}
 	function checkHookCall(node) {
 		const hookName = getHookName(node);
@@ -4734,7 +4787,6 @@ const plugin = {
 		"no-missing-component-display-name": no_missing_component_display_name_default,
 		"no-missing-context-display-name": no_missing_context_display_name_default,
 		"no-missing-key": no_missing_key_default,
-		"use-memo": use_memo_default,
 		"no-misused-capture-owner-stack": no_misused_capture_owner_stack_default,
 		"no-nested-component-definitions": no_nested_component_definitions_default,
 		"no-nested-lazy-component-declarations": no_nested_lazy_component_declarations_default,
@@ -4765,6 +4817,7 @@ const plugin = {
 		"set-state-in-effect": set_state_in_effect_default,
 		"set-state-in-render": set_state_in_render_default,
 		"unsupported-syntax": unsupported_syntax_default,
+		"use-memo": use_memo_default,
 		"use-state": use_state_default
 	}
 };
@@ -4803,8 +4856,6 @@ const rules$6 = {
 	"react-x/no-direct-mutation-state": "error",
 	"react-x/no-forward-ref": "warn",
 	"react-x/no-missing-key": "error",
-	"react-x/use-memo": "error",
-	"react-x/use-state": "warn",
 	"react-x/no-nested-component-definitions": "error",
 	"react-x/no-nested-lazy-component-declarations": "error",
 	"react-x/no-redundant-should-component-update": "error",
@@ -4821,7 +4872,9 @@ const rules$6 = {
 	"react-x/rules-of-hooks": "error",
 	"react-x/set-state-in-effect": "warn",
 	"react-x/set-state-in-render": "error",
-	"react-x/unsupported-syntax": "error"
+	"react-x/unsupported-syntax": "error",
+	"react-x/use-memo": "error",
+	"react-x/use-state": "warn"
 };
 const plugins$5 = { "react-x": plugin };
 const settings$5 = { "react-x": DEFAULT_ESLINT_REACT_SETTINGS };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-x",
-  "version": "3.0.0-next.20",
+  "version": "3.0.0-next.23",
   "description": "A set of composable ESLint rules for libraries and frameworks that use React as a UI runtime.",
   "keywords": [
     "react",
@@ -46,11 +46,11 @@
     "string-ts": "^2.3.1",
     "ts-api-utils": "^2.4.0",
     "ts-pattern": "^5.9.0",
-    "@eslint-react/ast": "3.0.0-next.20",
-    "@eslint-react/eff": "3.0.0-next.20",
-    "@eslint-react/core": "3.0.0-next.20",
-    "@eslint-react/shared": "3.0.0-next.20",
-    "@eslint-react/var": "3.0.0-next.20"
+    "@eslint-react/ast": "3.0.0-next.23",
+    "@eslint-react/core": "3.0.0-next.23",
+    "@eslint-react/eff": "3.0.0-next.23",
+    "@eslint-react/shared": "3.0.0-next.23",
+    "@eslint-react/var": "3.0.0-next.23"
   },
   "devDependencies": {
     "@types/react": "^19.2.14",
@@ -71,6 +71,6 @@
   "scripts": {
     "build": "tsdown",
     "lint:publish": "publint",
-    "lint:ts": "tsc --noEmit"
+    "lint:ts": "tsl"
   }
 }