eslint-plugin-react-x 3.0.0-next.14 → 3.0.0-next.16

package/dist/index.js

@@ -48,7 +48,8 @@ const rules$8 = {
 	"react-x/no-unused-props": "off",
 	"react-x/prefer-read-only-props": "off",
 	"react-x/refs": "off",
-	"react-x/rules-of-hooks": "off"
+	"react-x/rules-of-hooks": "off",
+	"react-x/set-state-in-render": "off"
 };
 
 //#endregion
@@ -68,7 +69,7 @@ const rules$7 = {
 //#endregion
 //#region package.json
 var name$6 = "eslint-plugin-react-x";
-var version = "3.0.0-next.14";
+var version = "3.0.0-next.16";
 
 //#endregion
 //#region src/utils/create-rule.ts
@@ -3861,7 +3862,7 @@ function isWriteAfterNullCheckIf(node, refName) {
 var refs_default = createRule({
 	meta: {
 		type: "problem",
-		docs: { description: "Validates correct usage of refs by checking that ref.current is not read or written during render." },
+		docs: { description: "Validates correct usage of refs by checking that 'ref.current' is not read or written during render." },
 		messages: {
 			readDuringRender: "Do not read 'ref.current' during render. Refs are not available during rendering and their values may be stale or inconsistent. Move this read into an effect or event handler.",
 			writeDuringRender: "Do not write to 'ref.current' during render. Refs should only be mutated in effects or event handlers. Move this write into an effect or event handler."
@@ -4208,6 +4209,17 @@ function create$2(context) {
 			default: return false;
 		}
 	}
+	function isHookDecl(node) {
+		if (node.type !== AST_NODE_TYPES.VariableDeclarator) return false;
+		if (node.id.type !== AST_NODE_TYPES.Identifier) return false;
+		const init = node.init;
+		if (init == null || init.type !== AST_NODE_TYPES.CallExpression) return false;
+		switch (init.callee.type) {
+			case AST_NODE_TYPES.Identifier: return core.isHookName(init.callee.name);
+			case AST_NODE_TYPES.MemberExpression: return init.callee.property.type === AST_NODE_TYPES.Identifier && core.isHookName(init.callee.property.name);
+			default: return false;
+		}
+	}
 	return defineRuleListener({
 		":function"(node) {
 			const kind = getFunctionKind(node);
@@ -4234,7 +4246,19 @@ function create$2(context) {
 					case entry.kind === "immediate" && ast.findParentNode(entry.node, ast.isFunction) === setupFunction: {
 						const args0 = node.arguments.at(0);
 						if (args0 == null) return;
-						if (isSetterUsingRefValue(context, args0)) return;
+						function isArgumentUsingRefValue(context, node) {
+							const isUsingRefValue = (n) => {
+								switch (n.type) {
+									case AST_NODE_TYPES.Identifier: return core.isInitializedFromRef(n.name, context.sourceCode.getScope(n));
+									case AST_NODE_TYPES.MemberExpression: return isUsingRefValue(n.object);
+									case AST_NODE_TYPES.CallExpression: return isUsingRefValue(n.callee) || ast.getNestedIdentifiers(n).some(isUsingRefValue);
+									default: return false;
+								}
+							};
+							if (isUsingRefValue(node)) return true;
+							return ast.isFunction(node) && context.sourceCode.getScope(node.body).references.some((r) => isUsingRefValue(r.identifier));
+						}
+						if (isArgumentUsingRefValue(context, args0)) return;
 						context.report({
 							messageId: "default",
 							node,
@@ -4243,7 +4267,7 @@ function create$2(context) {
 						return;
 					}
 					default: {
-						const init = ast.findParentNode(node, isVariableDeclaratorFromHookCall)?.init;
+						const init = ast.findParentNode(node, isHookDecl)?.init;
 						if (init == null) getOrElseUpdate(setStateCallsByFn, entry.node, () => []).push(node);
 						else getOrElseUpdate(setStateInHookCallbacks, init, () => []).push(node);
 					}
@@ -4264,14 +4288,14 @@ function create$2(context) {
 					const parent = node.parent.parent;
 					if (parent.type !== AST_NODE_TYPES.CallExpression) break;
 					if (!core.isUseMemoCall(parent)) break;
-					const init = ast.findParentNode(parent, isVariableDeclaratorFromHookCall)?.init;
+					const init = ast.findParentNode(parent, isHookDecl)?.init;
 					if (init != null) getOrElseUpdate(setStateInEffectArg, init, () => []).push(node);
 					break;
 				}
 				case AST_NODE_TYPES.CallExpression:
 					if (node !== node.parent.arguments.at(0)) break;
 					if (core.isUseCallbackCall(node.parent)) {
-						const init = ast.findParentNode(node.parent, isVariableDeclaratorFromHookCall)?.init;
+						const init = ast.findParentNode(node.parent, isHookDecl)?.init;
 						if (init != null) getOrElseUpdate(setStateInEffectArg, init, () => []).push(node);
 						break;
 					}
@@ -4315,31 +4339,6 @@ function create$2(context) {
 		}
 	});
 }
-function isSetterUsingRefValue(context, node) {
-	const isUsingRefValue = (n) => {
-		switch (n.type) {
-			case AST_NODE_TYPES.Identifier: return core.isInitializedFromRef(n.name, context.sourceCode.getScope(n));
-			case AST_NODE_TYPES.MemberExpression: return isUsingRefValue(n.object);
-			case AST_NODE_TYPES.CallExpression: return isUsingRefValue(n.callee) || ast.getNestedIdentifiers(n).some(isUsingRefValue);
-			default: return false;
-		}
-	};
-	if (isUsingRefValue(node)) return true;
-	return ast.isFunction(node) && context.sourceCode.getScope(node.body).references.some((r) => isUsingRefValue(r.identifier));
-}
-function isInitFromHookCall(init) {
-	if (init?.type !== AST_NODE_TYPES.CallExpression) return false;
-	switch (init.callee.type) {
-		case AST_NODE_TYPES.Identifier: return core.isHookName(init.callee.name);
-		case AST_NODE_TYPES.MemberExpression: return init.callee.property.type === AST_NODE_TYPES.Identifier && core.isHookName(init.callee.property.name);
-		default: return false;
-	}
-}
-function isVariableDeclaratorFromHookCall(node) {
-	if (node.type !== AST_NODE_TYPES.VariableDeclarator) return false;
-	if (node.id.type !== AST_NODE_TYPES.Identifier) return false;
-	return isInitFromHookCall(node.init);
-}
 
 //#endregion
 //#region src/rules/set-state-in-render.ts
@@ -4415,15 +4414,15 @@ function create$1(context) {
 		}
 		return false;
 	}
-	function isComponentLikeFunction(node) {
+	function isComponentOrHookLikeFunction(node) {
 		const id = ast.getFunctionId(node);
 		if (id == null) return false;
-		if (id.type === AST_NODE_TYPES.Identifier) return core.isComponentName(id.name);
-		if (id.type === AST_NODE_TYPES.MemberExpression && id.property.type === AST_NODE_TYPES.Identifier) return core.isComponentName(id.property.name);
+		if (id.type === AST_NODE_TYPES.Identifier) return core.isComponentName(id.name) || core.isHookName(id.name);
+		if (id.type === AST_NODE_TYPES.MemberExpression && id.property.type === AST_NODE_TYPES.Identifier) return core.isComponentName(id.property.name) || core.isHookName(id.property.name);
 		return false;
 	}
 	function getFunctionKind(node) {
-		if (isComponentLikeFunction(node)) return "component";
+		if (isComponentOrHookLikeFunction(node)) return "component";
 		const parent = ast.findParentNode(node, not(ast.isTypeExpression)) ?? node.parent;
 		if (parent.type === AST_NODE_TYPES.CallExpression && parent.callee !== node) return "callback";
 		return "other";

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-x",
-  "version": "3.0.0-next.14",
+  "version": "3.0.0-next.16",
   "description": "A set of composable ESLint rules for libraries and frameworks that use React as a UI runtime.",
   "keywords": [
     "react",
@@ -45,11 +45,11 @@
     "is-immutable-type": "^5.0.1",
     "ts-api-utils": "^2.4.0",
     "ts-pattern": "^5.9.0",
-    "@eslint-react/ast": "3.0.0-next.14",
-    "@eslint-react/core": "3.0.0-next.14",
-    "@eslint-react/eff": "3.0.0-next.14",
-    "@eslint-react/shared": "3.0.0-next.14",
-    "@eslint-react/var": "3.0.0-next.14"
+    "@eslint-react/ast": "3.0.0-next.16",
+    "@eslint-react/core": "3.0.0-next.16",
+    "@eslint-react/eff": "3.0.0-next.16",
+    "@eslint-react/shared": "3.0.0-next.16",
+    "@eslint-react/var": "3.0.0-next.16"
   },
   "devDependencies": {
     "@types/react": "^19.2.14",