eslint-plugin-react-x 3.0.0-next.12 → 3.0.0-next.14

package/dist/index.js

@@ -5,7 +5,7 @@ import { ESLintUtils } from "@typescript-eslint/utils";
 import { P, isMatching, match } from "ts-pattern";
 import ts from "typescript";
 import { AST_NODE_TYPES } from "@typescript-eslint/types";
-import { findEnclosingAssignmentTarget, findVariable, getChildScopes, getObjectType, getVariableDefinitionNode, isAssignmentTargetEqual } from "@eslint-react/var";
+import { findEnclosingAssignmentTarget, findVariable, getChildScopes, getObjectType, getVariableInitializer, isAssignmentTargetEqual } from "@eslint-react/var";
 import { DefinitionType } from "@typescript-eslint/scope-manager";
 import { constFalse, constTrue, constVoid, flow, getOrElseUpdate, identity, not, unit } from "@eslint-react/eff";
 import { compare } from "compare-versions";
@@ -68,7 +68,7 @@ const rules$7 = {
 //#endregion
 //#region package.json
 var name$6 = "eslint-plugin-react-x";
-var version = "3.0.0-next.12";
+var version = "3.0.0-next.14";
 
 //#endregion
 //#region src/utils/create-rule.ts
@@ -2499,7 +2499,7 @@ function create$23(context) {
 		const [arg0, arg1] = init.arguments;
 		if (arg0 == null || arg1 == null) return;
 		if (!match(arg1).with({ type: AST_NODE_TYPES.ArrayExpression }, (n) => n.elements.length === 0).with({ type: AST_NODE_TYPES.Identifier }, (n) => {
-			const variableNode = getVariableDefinitionNode(findVariable(n.name, scope), 0);
+			const variableNode = getVariableInitializer(findVariable(n.name, scope), 0);
 			if (variableNode?.type !== AST_NODE_TYPES.ArrayExpression) return false;
 			return variableNode.elements.length === 0;
 		}).otherwise(() => false)) {
@@ -2510,7 +2510,7 @@ function create$23(context) {
 			if (n.body.type === AST_NODE_TYPES.ArrowFunctionExpression) return n.body;
 			return n;
 		}).with({ type: AST_NODE_TYPES.FunctionExpression }, identity).with({ type: AST_NODE_TYPES.Identifier }, (n) => {
-			const variableNode = getVariableDefinitionNode(findVariable(n.name, scope), 0);
+			const variableNode = getVariableInitializer(findVariable(n.name, scope), 0);
 			if (variableNode?.type !== AST_NODE_TYPES.ArrowFunctionExpression && variableNode?.type !== AST_NODE_TYPES.FunctionExpression) return null;
 			return variableNode;
 		}).otherwise(() => null);
@@ -2580,7 +2580,7 @@ function create$22(context) {
 			return;
 		}
 		if (!match(arg1).with({ type: AST_NODE_TYPES.ArrayExpression }, (n) => n.elements.length === 0).with({ type: AST_NODE_TYPES.Identifier }, (n) => {
-			const variableNode = getVariableDefinitionNode(findVariable(n.name, scope), 0);
+			const variableNode = getVariableInitializer(findVariable(n.name, scope), 0);
 			if (variableNode?.type !== AST_NODE_TYPES.ArrayExpression) return false;
 			return variableNode.elements.length === 0;
 		}).otherwise(() => false)) {
@@ -2591,7 +2591,7 @@ function create$22(context) {
 			if (n.body.type === AST_NODE_TYPES.ArrowFunctionExpression) return n.body;
 			return n;
 		}).with({ type: AST_NODE_TYPES.FunctionExpression }, identity).with({ type: AST_NODE_TYPES.Identifier }, (n) => {
-			const variableNode = getVariableDefinitionNode(findVariable(n.name, scope), 0);
+			const variableNode = getVariableInitializer(findVariable(n.name, scope), 0);
 			if (variableNode?.type !== AST_NODE_TYPES.ArrowFunctionExpression && variableNode?.type !== AST_NODE_TYPES.FunctionExpression) return null;
 			return variableNode;
 		}).otherwise(() => null);
@@ -4180,7 +4180,7 @@ function create$2(context) {
 		}
 	}
 	function isIdFromUseStateCall(topLevelId, at) {
-		const variableNode = getVariableDefinitionNode(findVariable(topLevelId, context.sourceCode.getScope(topLevelId)), 0);
+		const variableNode = getVariableInitializer(findVariable(topLevelId, context.sourceCode.getScope(topLevelId)), 0);
 		if (variableNode == null) return false;
 		if (variableNode.type !== AST_NODE_TYPES.CallExpression) return false;
 		if (!isUseStateCall(variableNode)) return false;
@@ -4231,13 +4231,17 @@ function create$2(context) {
 					case entry.kind === "deferred":
 					case entry.node.async: break;
 					case entry.node === setupFunction:
-					case entry.kind === "immediate" && ast.findParentNode(entry.node, ast.isFunction) === setupFunction:
+					case entry.kind === "immediate" && ast.findParentNode(entry.node, ast.isFunction) === setupFunction: {
+						const args0 = node.arguments.at(0);
+						if (args0 == null) return;
+						if (isSetterUsingRefValue(context, args0)) return;
 						context.report({
 							messageId: "default",
 							node,
 							data: { name: context.sourceCode.getText(node.callee) }
 						});
 						return;
+					}
 					default: {
 						const init = ast.findParentNode(node, isVariableDeclaratorFromHookCall)?.init;
 						if (init == null) getOrElseUpdate(setStateCallsByFn, entry.node, () => []).push(node);
@@ -4276,7 +4280,7 @@ function create$2(context) {
 		},
 		"Program:exit"() {
 			const getSetStateCalls = (id, initialScope) => {
-				const node = getVariableDefinitionNode(findVariable(id, initialScope), 0);
+				const node = getVariableInitializer(findVariable(id, initialScope), 0);
 				switch (node?.type) {
 					case AST_NODE_TYPES.ArrowFunctionExpression:
 					case AST_NODE_TYPES.FunctionDeclaration:
@@ -4311,6 +4315,18 @@ function create$2(context) {
 		}
 	});
 }
+function isSetterUsingRefValue(context, node) {
+	const isUsingRefValue = (n) => {
+		switch (n.type) {
+			case AST_NODE_TYPES.Identifier: return core.isInitializedFromRef(n.name, context.sourceCode.getScope(n));
+			case AST_NODE_TYPES.MemberExpression: return isUsingRefValue(n.object);
+			case AST_NODE_TYPES.CallExpression: return isUsingRefValue(n.callee) || ast.getNestedIdentifiers(n).some(isUsingRefValue);
+			default: return false;
+		}
+	};
+	if (isUsingRefValue(node)) return true;
+	return ast.isFunction(node) && context.sourceCode.getScope(node.body).references.some((r) => isUsingRefValue(r.identifier));
+}
 function isInitFromHookCall(init) {
 	if (init?.type !== AST_NODE_TYPES.CallExpression) return false;
 	switch (init.callee.type) {
@@ -4348,7 +4364,7 @@ function create$1(context) {
 		return core.isUseStateLikeCall(node, additionalStateHooks);
 	}
 	function isIdFromUseStateCall(topLevelId, at) {
-		const variableNode = getVariableDefinitionNode(findVariable(topLevelId, context.sourceCode.getScope(topLevelId)), 0);
+		const variableNode = getVariableInitializer(findVariable(topLevelId, context.sourceCode.getScope(topLevelId)), 0);
 		if (variableNode == null) return false;
 		if (variableNode.type !== AST_NODE_TYPES.CallExpression) return false;
 		if (!isUseStateCall(variableNode)) return false;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-x",
-  "version": "3.0.0-next.12",
+  "version": "3.0.0-next.14",
   "description": "A set of composable ESLint rules for libraries and frameworks that use React as a UI runtime.",
   "keywords": [
     "react",
@@ -45,11 +45,11 @@
     "is-immutable-type": "^5.0.1",
     "ts-api-utils": "^2.4.0",
     "ts-pattern": "^5.9.0",
-    "@eslint-react/core": "3.0.0-next.12",
-    "@eslint-react/eff": "3.0.0-next.12",
-    "@eslint-react/ast": "3.0.0-next.12",
-    "@eslint-react/shared": "3.0.0-next.12",
-    "@eslint-react/var": "3.0.0-next.12"
+    "@eslint-react/ast": "3.0.0-next.14",
+    "@eslint-react/core": "3.0.0-next.14",
+    "@eslint-react/eff": "3.0.0-next.14",
+    "@eslint-react/shared": "3.0.0-next.14",
+    "@eslint-react/var": "3.0.0-next.14"
   },
   "devDependencies": {
     "@types/react": "^19.2.14",