eslint-plugin-react-x 2.7.5-next.10 → 2.7.5-next.11

package/dist/index.js

@@ -68,7 +68,7 @@ const rules$7 = {
 //#endregion
 //#region package.json
 var name$6 = "eslint-plugin-react-x";
-var version = "2.7.5-next.10";
+var version = "2.7.5-next.11";
 
 //#endregion
 //#region src/utils/create-rule.ts
@@ -2073,7 +2073,7 @@ const RULE_NAME$20 = "no-unnecessary-key";
 var no_unnecessary_key_default = createRule({
 	meta: {
 		type: "problem",
-		docs: { description: "Disallows unnecessary 'key' props on elements." },
+		docs: { description: "Disallows unnecessary 'key' props on nested child elements when rendering lists." },
 		messages: { noUnnecessaryKey: "Unnecessary `key` prop on this element. {{reason}}" },
 		schema: []
 	},
@@ -2087,44 +2087,26 @@ function create$20(context) {
 		...getJsxConfigFromContext(context),
 		...getJsxConfigFromAnnotation(context)
 	};
-	const { ctx, visitor } = useComponentCollector(context);
-	const constantKeys = /* @__PURE__ */ new Set();
-	return defineRuleListener(visitor, {
-		JSXAttribute(node) {
-			if (node.name.name !== "key") return;
-			const jsxElement = node.parent.parent;
-			if (isJsxFragmentElement(context, jsxElement, jsxConfig)) return;
-			if (jsxElement.openingElement.attributes.some((attr) => attr.type === AST_NODE_TYPES.JSXSpreadAttribute)) return;
-			if (AST.findParentNode(jsxElement, (n) => isRenderFunctionLoose(context, n)) != null) return;
-			const mapCallback = AST.findParentNode(jsxElement, isArrayMethodCallback);
-			if (mapCallback == null || AST.findParentNode(jsxElement, AST.isFunction) !== mapCallback) {
-				constantKeys.add(node);
-				return;
-			}
-			if (context.sourceCode.getScope(mapCallback) !== context.sourceCode.getScope(jsxElement)) return;
-			const keyedElementOrElse = AST.findParentNode(jsxElement, (n) => {
-				if (n === mapCallback) return true;
-				return AST.isJSXElement(n) && getJsxAttribute(context, n)("key") != null;
-			});
-			if (keyedElementOrElse == null || keyedElementOrElse === mapCallback) return;
-			context.report({
-				messageId: "noUnnecessaryKey",
-				node,
-				data: { reason: "A parent element already has a `key` prop in the same list rendering context." }
-			});
-		},
-		"Program:exit"(node) {
-			const components = ctx.getAllComponents(node);
-			for (const key of constantKeys) {
-				if (AST.findParentNode(key, (n) => AST.isConditional(n) || AST.isControlFlow(n) || findEnclosingAssignmentTarget(n) != null || components.some((comp) => comp.node === n && comp.rets.length > 1)) != null) continue;
-				context.report({
-					messageId: "noUnnecessaryKey",
-					node: key,
-					data: { reason: "The `key` prop is not needed outside of dynamic rendering contexts." }
-				});
-			}
-		}
-	});
+	return { JSXAttribute(node) {
+		if (node.name.name !== "key") return;
+		const jsxElement = node.parent.parent;
+		if (isJsxFragmentElement(context, jsxElement, jsxConfig)) return;
+		if (jsxElement.openingElement.attributes.some((attr) => attr.type === AST_NODE_TYPES.JSXSpreadAttribute)) return;
+		if (AST.findParentNode(jsxElement, (n) => isRenderFunctionLoose(context, n)) != null) return;
+		const mapCallback = AST.findParentNode(jsxElement, isArrayMethodCallback);
+		if (mapCallback == null || AST.findParentNode(jsxElement, AST.isFunction) !== mapCallback) return;
+		if (context.sourceCode.getScope(mapCallback) !== context.sourceCode.getScope(jsxElement)) return;
+		const keyedElementOrElse = AST.findParentNode(jsxElement, (n) => {
+			if (n === mapCallback) return true;
+			return AST.isJSXElement(n) && getJsxAttribute(context, n)("key") != null;
+		});
+		if (keyedElementOrElse == null || keyedElementOrElse === mapCallback) return;
+		context.report({
+			messageId: "noUnnecessaryKey",
+			node,
+			data: { reason: "A parent element already has a `key` prop in the same list rendering context." }
+		});
+	} };
 }
 function getArrayMethodCallbackPosition(methodName) {
 	switch (methodName) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-x",
-  "version": "2.7.5-next.10",
+  "version": "2.7.5-next.11",
   "description": "A set of composable ESLint rules for for libraries and frameworks that use React as a UI runtime.",
   "keywords": [
     "react",
@@ -46,11 +46,11 @@
     "string-ts": "^2.3.1",
     "ts-api-utils": "^2.4.0",
     "ts-pattern": "^5.9.0",
-    "@eslint-react/ast": "2.7.5-next.10",
-    "@eslint-react/core": "2.7.5-next.10",
-    "@eslint-react/eff": "2.7.5-next.10",
-    "@eslint-react/shared": "2.7.5-next.10",
-    "@eslint-react/var": "2.7.5-next.10"
+    "@eslint-react/ast": "2.7.5-next.11",
+    "@eslint-react/core": "2.7.5-next.11",
+    "@eslint-react/eff": "2.7.5-next.11",
+    "@eslint-react/shared": "2.7.5-next.11",
+    "@eslint-react/var": "2.7.5-next.11"
   },
   "devDependencies": {
     "@types/react": "^19.2.10",