eslint-plugin-react-x 2.7.4 → 2.7.5-beta.11

package/dist/index.js

@@ -3,7 +3,7 @@ import { AST_NODE_TYPES } from "@typescript-eslint/types";
 import { ESLintUtils } from "@typescript-eslint/utils";
 import { P, isMatching, match } from "ts-pattern";
 import ts from "typescript";
-import { ComponentDetectionHint, ComponentFlag, DEFAULT_COMPONENT_DETECTION_HINT, JsxEmit, findParentJsxAttribute, getJsxAttribute, getJsxAttributeName, getJsxConfigFromAnnotation, getJsxConfigFromContext, getJsxElementType, isAssignmentToThisState, isCaptureOwnerStackCall, isChildrenCount, isChildrenForEach, isChildrenMap, isChildrenOnly, isChildrenToArray, isChildrenToArrayCall, isClassComponent, isCloneElementCall, isComponentDidCatch, isComponentDidMount, isComponentDidUpdate, isComponentNameLoose, isComponentWillMount, isComponentWillReceiveProps, isComponentWillUpdate, isCreateContextCall, isCreateElementCall, isCreateRefCall, isDeclaredInRenderPropLoose, isDirectValueOfRenderPropertyLoose, isForwardRefCall, isGetDerivedStateFromError, isGetDerivedStateFromProps, isInitializedFromReact, isJsxFragmentElement, isJsxHostElement, isJsxText, isLazyCall, isReactHookCall, isReactHookName, isRenderFunctionLoose, isRenderMethodLike, isThisSetState, isUnsafeComponentWillMount, isUnsafeComponentWillReceiveProps, isUnsafeComponentWillUpdate, isUseCall, isUseCallbackCall, isUseContextCall, isUseEffectLikeCall, isUseMemoCall, isUseRefCall, isUseStateCall, useComponentCollector, useComponentCollectorLegacy, useHookCollector } from "@eslint-react/core";
+import { ComponentDetectionHint, ComponentFlag, DEFAULT_COMPONENT_DETECTION_HINT, JsxEmit, findParentJsxAttribute, getJsxAttribute, getJsxAttributeName, getJsxConfigFromAnnotation, getJsxConfigFromContext, getJsxElementType, isAssignmentToThisState, isCaptureOwnerStackCall, isChildrenCount, isChildrenForEach, isChildrenMap, isChildrenOnly, isChildrenToArray, isChildrenToArrayCall, isClassComponent, isCloneElementCall, isComponentDidCatch, isComponentDidMount, isComponentDidUpdate, isComponentNameLoose, isComponentWillMount, isComponentWillReceiveProps, isComponentWillUpdate, isCreateContextCall, isCreateElementCall, isCreateRefCall, isDeclaredInRenderPropLoose, isDirectValueOfRenderPropertyLoose, isForwardRefCall, isGetDerivedStateFromError, isGetDerivedStateFromProps, isHookCall, isHookName, isInitializedFromReact, isJsxFragmentElement, isJsxHostElement, isJsxText, isLazyCall, isRenderFunctionLoose, isRenderMethodLike, isThisSetState, isUnsafeComponentWillMount, isUnsafeComponentWillReceiveProps, isUnsafeComponentWillUpdate, isUseCall, isUseCallbackCall, isUseContextCall, isUseEffectLikeCall, isUseMemoCall, isUseRefCall, isUseStateCall, useComponentCollector, useComponentCollectorLegacy, useHookCollector } from "@eslint-react/core";
 import * as AST from "@eslint-react/ast";
 import { findEnclosingAssignmentTarget, findVariable, getChildScopes, getObjectType, getVariableDefinitionNode, isAssignmentTargetEqual } from "@eslint-react/var";
 import { constFalse, constTrue, flow, getOrElseUpdate, identity, unit } from "@eslint-react/eff";
@@ -68,7 +68,7 @@ const rules$7 = {
 //#endregion
 //#region package.json
 var name$6 = "eslint-plugin-react-x";
-var version = "2.7.4";
+var version = "2.7.5-beta.11";
 
 //#endregion
 //#region src/utils/create-rule.ts
@@ -1294,7 +1294,7 @@ function create$35(context) {
 	} };
 }
 /**
-* Determines whether the given CallExpression can be safely auto-fixed by replacing
+* Determine whether the given CallExpression can be safely auto-fixed by replacing
 * the usage of `forwardRef` with passing `ref` as a prop
 *
 * @param context The rule context object
@@ -1471,7 +1471,7 @@ const RULE_NAME$32 = "no-missing-component-display-name";
 var no_missing_component_display_name_default = createRule({
 	meta: {
 		type: "problem",
-		docs: { description: "Enforces that all components have a 'displayName' that can be used in devtools." },
+		docs: { description: "Enforces that all components have a 'displayName' that can be used in DevTools." },
 		messages: { noMissingComponentDisplayName: "Add missing 'displayName' for component." },
 		schema: []
 	},
@@ -1483,7 +1483,6 @@ function create$32(context) {
 	if (!context.sourceCode.text.includes("memo") && !context.sourceCode.text.includes("forwardRef")) return {};
 	const { ctx, visitor } = useComponentCollector(context, {
 		collectDisplayName: true,
-		collectHookCalls: false,
 		hint: DEFAULT_COMPONENT_DETECTION_HINT
 	});
 	return defineRuleListener(visitor, { "Program:exit"(program) {
@@ -1506,7 +1505,7 @@ const RULE_NAME$31 = "no-missing-context-display-name";
 var no_missing_context_display_name_default = createRule({
 	meta: {
 		type: "problem",
-		docs: { description: "Enforces that all contexts have a 'displayName' that can be used in devtools." },
+		docs: { description: "Enforces that all contexts have a 'displayName' that can be used in DevTools." },
 		fixable: "code",
 		messages: { noMissingContextDisplayName: "Add missing 'displayName' for context." },
 		schema: []
@@ -1776,7 +1775,7 @@ function create$28(context) {
 	} });
 }
 /**
-* Determines whether the node is inside JSX attribute value
+* Determine whether the node is inside JSX attribute value
 * @param node The AST node to check
 * @returns `true` if the node is inside JSX attribute value
 */
@@ -1784,7 +1783,7 @@ function isInsideJSXAttributeValue(node) {
 	return node.parent.type === AST_NODE_TYPES.JSXAttribute || findParentJsxAttribute(node, (n) => n.value?.type === AST_NODE_TYPES.JSXExpressionContainer) != null;
 }
 /**
-* Checks whether a given node is declared inside a class component's render block
+* Check whether a given node is declared inside a class component's render block
 * Ex: class C extends React.Component { render() { const Nested = () => <div />; } }
 * @param node The AST node being checked
 * @returns `true` if the node is inside a class component's render block
@@ -1793,7 +1792,7 @@ function isInsideRenderMethod(node) {
 	return AST.findParentNode(node, (n) => isRenderMethodLike(n) && isClassComponent(n.parent.parent)) != null;
 }
 /**
-* Determines whether the node is inside `createElement`'s props argument
+* Determine whether the node is inside `createElement`'s props argument
 * @param context The rule context
 * @param node The AST node to check
 * @returns `true` if the node is inside `createElement`'s props
@@ -1835,7 +1834,7 @@ function create$27(context) {
 			const classComponents = collectorLegacy.ctx.getAllComponents(program);
 			for (const lazy of lazyComponentDeclarations) if (AST.findParentNode(lazy, (n) => {
 				if (AST.isJSX(n)) return true;
-				if (n.type === AST_NODE_TYPES.CallExpression) return isReactHookCall(n) || isCreateElementCall(context, n) || isCreateContextCall(context, n);
+				if (n.type === AST_NODE_TYPES.CallExpression) return isHookCall(n) || isCreateElementCall(context, n) || isCreateContextCall(context, n);
 				if (AST.isFunction(n)) return functionComponents.some((c) => c.node === n);
 				if (AST.isClass(n)) return classComponents.some((c) => c.node === n);
 				return false;
@@ -2074,7 +2073,7 @@ const RULE_NAME$20 = "no-unnecessary-key";
 var no_unnecessary_key_default = createRule({
 	meta: {
 		type: "problem",
-		docs: { description: "Disallows unnecessary 'key' props on elements." },
+		docs: { description: "Disallows unnecessary 'key' props on nested child elements when rendering lists." },
 		messages: { noUnnecessaryKey: "Unnecessary `key` prop on this element. {{reason}}" },
 		schema: []
 	},
@@ -2088,44 +2087,26 @@ function create$20(context) {
 		...getJsxConfigFromContext(context),
 		...getJsxConfigFromAnnotation(context)
 	};
-	const { ctx, visitor } = useComponentCollector(context);
-	const constantKeys = /* @__PURE__ */ new Set();
-	return defineRuleListener(visitor, {
-		JSXAttribute(node) {
-			if (node.name.name !== "key") return;
-			const jsxElement = node.parent.parent;
-			if (isJsxFragmentElement(context, jsxElement, jsxConfig)) return;
-			if (jsxElement.openingElement.attributes.some((attr) => attr.type === AST_NODE_TYPES.JSXSpreadAttribute)) return;
-			if (AST.findParentNode(jsxElement, (n) => isRenderFunctionLoose(context, n)) != null) return;
-			const mapCallback = AST.findParentNode(jsxElement, isArrayMethodCallback);
-			if (mapCallback == null || AST.findParentNode(jsxElement, AST.isFunction) !== mapCallback) {
-				constantKeys.add(node);
-				return;
-			}
-			if (context.sourceCode.getScope(mapCallback) !== context.sourceCode.getScope(jsxElement)) return;
-			const keyedElementOrElse = AST.findParentNode(jsxElement, (n) => {
-				if (n === mapCallback) return true;
-				return AST.isJSXElement(n) && getJsxAttribute(context, n)("key") != null;
-			});
-			if (keyedElementOrElse == null || keyedElementOrElse === mapCallback) return;
-			context.report({
-				messageId: "noUnnecessaryKey",
-				node,
-				data: { reason: "A parent element already has a `key` prop in the same list rendering context." }
-			});
-		},
-		"Program:exit"(node) {
-			const components = ctx.getAllComponents(node);
-			for (const key of constantKeys) {
-				if (AST.findParentNode(key, (n) => AST.isConditional(n) || AST.isControlFlow(n) || findEnclosingAssignmentTarget(n) != null || components.some((comp) => comp.node === n && comp.rets.length > 1)) != null) continue;
-				context.report({
-					messageId: "noUnnecessaryKey",
-					node: key,
-					data: { reason: "The `key` prop is not needed outside of dynamic rendering contexts." }
-				});
-			}
-		}
-	});
+	return { JSXAttribute(node) {
+		if (node.name.name !== "key") return;
+		const jsxElement = node.parent.parent;
+		if (isJsxFragmentElement(context, jsxElement, jsxConfig)) return;
+		if (jsxElement.openingElement.attributes.some((attr) => attr.type === AST_NODE_TYPES.JSXSpreadAttribute)) return;
+		if (AST.findParentNode(jsxElement, (n) => isRenderFunctionLoose(context, n)) != null) return;
+		const mapCallback = AST.findParentNode(jsxElement, isArrayMethodCallback);
+		if (mapCallback == null || AST.findParentNode(jsxElement, AST.isFunction) !== mapCallback) return;
+		if (context.sourceCode.getScope(mapCallback) !== context.sourceCode.getScope(jsxElement)) return;
+		const keyedElementOrElse = AST.findParentNode(jsxElement, (n) => {
+			if (n === mapCallback) return true;
+			return AST.isJSXElement(n) && getJsxAttribute(context, n)("key") != null;
+		});
+		if (keyedElementOrElse == null || keyedElementOrElse === mapCallback) return;
+		context.report({
+			messageId: "noUnnecessaryKey",
+			node,
+			data: { reason: "A parent element already has a `key` prop in the same list rendering context." }
+		});
+	} };
 }
 function getArrayMethodCallbackPosition(methodName) {
 	switch (methodName) {
@@ -2496,7 +2477,7 @@ function create$12(context) {
 			const valueExpression = value.expression;
 			const construction = getObjectType(valueExpression, context.sourceCode.getScope(valueExpression));
 			if (construction == null) return;
-			if (isReactHookCall(construction.node)) return;
+			if (isHookCall(construction.node)) return;
 			getOrElseUpdate(constructions, functionEntry.node, () => []).push(construction);
 		},
 		"Program:exit"(program) {
@@ -2577,7 +2558,7 @@ function create$11(context, [options]) {
 					const { right } = value;
 					const construction = getObjectType(value, context.sourceCode.getScope(value));
 					if (construction == null) continue;
-					if (isReactHookCall(construction.node)) continue;
+					if (isHookCall(construction.node)) continue;
 					if (safePatterns.length > 0) {
 						const identifier = extractIdentifier(right);
 						if (identifier != null && safePatterns.some((pattern) => pattern.test(identifier))) continue;
@@ -2969,7 +2950,7 @@ function create$7(context) {
 	const hookCalls = /* @__PURE__ */ new Set();
 	return {
 		CallExpression(node) {
-			if (!isReactHookCall(node)) return;
+			if (!isHookCall(node)) return;
 			hookCalls.add(node);
 		},
 		ImportDeclaration(node) {
@@ -3353,7 +3334,7 @@ function create$1(context) {
 		}
 		for (const expr of AST.getNestedCallExpressions(useStateInput)) {
 			if (!("name" in expr.callee)) continue;
-			if (isReactHookName(expr.callee.name)) continue;
+			if (isHookName(expr.callee.name)) continue;
 			if (ALLOW_LIST.includes(expr.callee.name)) continue;
 			if (AST.findParentNode(expr, isUseCall) != null) continue;
 			context.report({

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-x",
-  "version": "2.7.4",
+  "version": "2.7.5-beta.11",
   "description": "A set of composable ESLint rules for for libraries and frameworks that use React as a UI runtime.",
   "keywords": [
     "react",
@@ -37,23 +37,23 @@
     "./package.json"
   ],
   "dependencies": {
-    "@typescript-eslint/scope-manager": "^8.53.1",
-    "@typescript-eslint/type-utils": "^8.53.1",
-    "@typescript-eslint/types": "^8.53.1",
-    "@typescript-eslint/utils": "^8.53.1",
+    "@typescript-eslint/scope-manager": "^8.54.0",
+    "@typescript-eslint/type-utils": "^8.54.0",
+    "@typescript-eslint/types": "^8.54.0",
+    "@typescript-eslint/utils": "^8.54.0",
     "compare-versions": "^6.1.1",
     "is-immutable-type": "^5.0.1",
     "string-ts": "^2.3.1",
     "ts-api-utils": "^2.4.0",
     "ts-pattern": "^5.9.0",
-    "@eslint-react/ast": "2.7.4",
-    "@eslint-react/core": "2.7.4",
-    "@eslint-react/eff": "2.7.4",
-    "@eslint-react/shared": "2.7.4",
-    "@eslint-react/var": "2.7.4"
+    "@eslint-react/ast": "2.7.5-beta.11",
+    "@eslint-react/core": "2.7.5-beta.11",
+    "@eslint-react/eff": "2.7.5-beta.11",
+    "@eslint-react/shared": "2.7.5-beta.11",
+    "@eslint-react/var": "2.7.5-beta.11"
   },
   "devDependencies": {
-    "@types/react": "^19.2.9",
+    "@types/react": "^19.2.10",
     "@types/react-dom": "^19.2.3",
     "tsdown": "^0.20.1",
     "@local/configs": "0.0.0"