eslint-plugin-react-x 2.5.6-next.4 → 2.5.6-next.5

package/dist/index.js

@@ -34,7 +34,7 @@ var __exportAll = (all, symbols) => {
 //#endregion
 //#region package.json
 var name$6 = "eslint-plugin-react-x";
-var version = "2.5.6-next.4";
+var version = "2.5.6-next.5";
 
 //#endregion
 //#region src/utils/create-rule.ts
@@ -426,12 +426,13 @@ var jsx_shorthand_fragment_default = createRule({
 });
 function create$55(context) {
 	const policy = context.options[0] ?? defaultOptions$3[0];
-	const { jsxFragmentFactory } = {
+	const jsxConfig = {
 		...getJsxConfigFromContext(context),
 		...getJsxConfigFromAnnotation(context)
 	};
+	const { jsxFragmentFactory } = jsxConfig;
 	return match(policy).with(1, () => ({ JSXElement(node) {
-		if (!isJsxFragmentElement(context, node)) return;
+		if (!isJsxFragmentElement(context, node, jsxConfig)) return;
 		if (node.openingElement.attributes.length > 0) return;
 		context.report({
 			messageId: "jsxShorthandFragment",
@@ -2059,8 +2060,8 @@ const RULE_NAME$19 = "no-unnecessary-key";
 var no_unnecessary_key_default = createRule({
 	meta: {
 		type: "problem",
-		docs: { description: "Prevents 'key' from being placed on non-top-level elements in list rendering." },
-		messages: { noUnnecessaryKey: "Unnecessary `key` prop on this element. The `key` should be on the top-level element returned from the array." },
+		docs: { description: "Disallows unnecessary `key` props on elements." },
+		messages: { noUnnecessaryKey: "Unnecessary `key` prop on this element. {{reason}}" },
 		schema: []
 	},
 	name: RULE_NAME$19,
@@ -2069,20 +2070,34 @@ var no_unnecessary_key_default = createRule({
 });
 function create$19(context) {
 	if (!context.sourceCode.text.includes("key=")) return {};
+	const jsxConfig = {
+		...getJsxConfigFromContext(context),
+		...getJsxConfigFromAnnotation(context)
+	};
 	return { JSXAttribute(node) {
 		if (node.name.name !== "key") return;
 		const jsxElement = node.parent.parent;
-		const initialScope = context.sourceCode.getScope(jsxElement);
-		const pMapCallback = AST.findParentNode(jsxElement, isMapCallback);
-		if (pMapCallback == null || context.sourceCode.getScope(pMapCallback) !== initialScope) return;
-		const pKeyedElementOrElse = AST.findParentNode(jsxElement, (n) => {
-			if (n === pMapCallback) return true;
-			return AST.isJSXElement(n) && n.openingElement.attributes.some((n$1) => n$1.type === AST_NODE_TYPES.JSXAttribute && n$1.name.type === AST_NODE_TYPES.JSXIdentifier && n$1.name.name === "key");
+		if (isJsxFragmentElement(context, jsxElement, jsxConfig)) return;
+		if (jsxElement.openingElement.attributes.some((attr) => attr.type === AST_NODE_TYPES.JSXSpreadAttribute)) return;
+		const mapCallback = AST.findParentNode(jsxElement, isMapCallback);
+		if (mapCallback == null || AST.findParentNode(jsxElement, AST.isFunction) !== mapCallback) {
+			if (!(AST.findParentNode(jsxElement, (n) => AST.isConditional(n) || AST.isControlFlow(n) || getInstanceId(n) != null) != null)) context.report({
+				messageId: "noUnnecessaryKey",
+				node,
+				data: { reason: "The `key` prop is not needed outside of dynamic rendering contexts." }
+			});
+			return;
+		}
+		if (context.sourceCode.getScope(mapCallback) !== context.sourceCode.getScope(jsxElement)) return;
+		const keyedElementOrElse = AST.findParentNode(jsxElement, (n) => {
+			if (n === mapCallback) return true;
+			return AST.isJSXElement(n) && getJsxAttribute(context, n)("key") != null;
 		});
-		if (pKeyedElementOrElse == null || pKeyedElementOrElse === pMapCallback) return;
+		if (keyedElementOrElse == null || keyedElementOrElse === mapCallback) return;
 		context.report({
 			messageId: "noUnnecessaryKey",
-			node
+			node,
+			data: { reason: "A parent element already has a `key` prop in the same list rendering context." }
 		});
 	} };
 }
@@ -3009,6 +3024,10 @@ var no_useless_fragment_default = createRule({
 });
 function create$5(context, [option]) {
 	const { allowEmptyFragment = false, allowExpressions = true } = option;
+	const jsxConfig = {
+		...getJsxConfigFromContext(context),
+		...getJsxConfigFromAnnotation(context)
+	};
 	/**
 	* Check if a fragment node is useless and should be reported
 	*/
@@ -3078,7 +3097,7 @@ function create$5(context, [option]) {
 	}
 	return {
 		JSXElement(node) {
-			if (!isJsxFragmentElement(context, node)) return;
+			if (!isJsxFragmentElement(context, node, jsxConfig)) return;
 			checkNode(context, node);
 		},
 		JSXFragment(node) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-x",
-  "version": "2.5.6-next.4",
+  "version": "2.5.6-next.5",
   "description": "A set of composable ESLint rules for for libraries and frameworks that use React as a UI runtime.",
   "keywords": [
     "react",
@@ -46,11 +46,11 @@
     "string-ts": "^2.3.1",
     "ts-api-utils": "^2.4.0",
     "ts-pattern": "^5.9.0",
-    "@eslint-react/core": "2.5.6-next.4",
-    "@eslint-react/eff": "2.5.6-next.4",
-    "@eslint-react/ast": "2.5.6-next.4",
-    "@eslint-react/var": "2.5.6-next.4",
-    "@eslint-react/shared": "2.5.6-next.4"
+    "@eslint-react/ast": "2.5.6-next.5",
+    "@eslint-react/core": "2.5.6-next.5",
+    "@eslint-react/eff": "2.5.6-next.5",
+    "@eslint-react/shared": "2.5.6-next.5",
+    "@eslint-react/var": "2.5.6-next.5"
   },
   "devDependencies": {
     "@types/react": "^19.2.8",