eslint-plugin-react-x 2.3.8-next.1 → 2.3.9-next.0

package/dist/index.js

@@ -6,11 +6,12 @@ import { P, isMatching, match } from "ts-pattern";
 import ts from "typescript";
 import * as AST from "@eslint-react/ast";
 import { findVariable, getChildScopes, getObjectType, getVariableDefinitionNode } from "@eslint-react/var";
-import { ComponentDetectionHint, ComponentFlag, DEFAULT_COMPONENT_DETECTION_HINT, JsxEmit, findParentJsxAttribute, getInstanceId, getJsxAttribute, getJsxAttributeName, getJsxConfigFromAnnotation, getJsxConfigFromContext, getJsxElementType, isAssignmentToThisState, isCaptureOwnerStackCall, isChildrenCount, isChildrenForEach, isChildrenMap, isChildrenOnly, isChildrenToArray, isChildrenToArrayCall, isClassComponent, isCloneElementCall, isComponentDidCatch, isComponentDidMount, isComponentDidUpdate, isComponentNameLoose, isComponentWillMount, isComponentWillReceiveProps, isComponentWillUpdate, isCreateContextCall, isCreateElementCall, isCreateRefCall, isDeclaredInRenderPropLoose, isDirectValueOfRenderPropertyLoose, isForwardRefCall, isGetDerivedStateFromError, isGetDerivedStateFromProps, isInitializedFromReact, isInstanceIdEqual, isJsxFragmentElement, isJsxHostElement, isJsxText, isLazyCall, isReactHookCall, isReactHookName, isRenderMethodLike, isThisSetState, isUnsafeComponentWillMount, isUnsafeComponentWillReceiveProps, isUnsafeComponentWillUpdate, isUseCall, isUseCallbackCall, isUseContextCall, isUseMemoCall, isUseStateCall, useComponentCollector, useComponentCollectorLegacy, useHookCollector } from "@eslint-react/core";
+import { ComponentDetectionHint, ComponentFlag, DEFAULT_COMPONENT_DETECTION_HINT, JsxEmit, findParentJsxAttribute, getInstanceId, getJsxAttribute, getJsxAttributeName, getJsxConfigFromAnnotation, getJsxConfigFromContext, getJsxElementType, isAssignmentToThisState, isCaptureOwnerStackCall, isChildrenCount, isChildrenForEach, isChildrenMap, isChildrenOnly, isChildrenToArray, isChildrenToArrayCall, isClassComponent, isCloneElementCall, isComponentDidCatch, isComponentDidMount, isComponentDidUpdate, isComponentNameLoose, isComponentWillMount, isComponentWillReceiveProps, isComponentWillUpdate, isCreateContextCall, isCreateElementCall, isCreateRefCall, isDeclaredInRenderPropLoose, isDirectValueOfRenderPropertyLoose, isForwardRefCall, isGetDerivedStateFromError, isGetDerivedStateFromProps, isInitializedFromReact, isInstanceIdEqual, isJsxFragmentElement, isJsxHostElement, isJsxText, isLazyCall, isReactHookCall, isReactHookName, isRenderMethodLike, isThisSetState, isUnsafeComponentWillMount, isUnsafeComponentWillReceiveProps, isUnsafeComponentWillUpdate, isUseCall, isUseCallbackCall, isUseContextCall, isUseEffectLikeCall, isUseMemoCall, isUseStateCall, useComponentCollector, useComponentCollectorLegacy, useHookCollector } from "@eslint-react/core";
 import { constFalse, constTrue, flow, getOrElseUpdate, identity, unit } from "@eslint-react/eff";
 import { compare } from "compare-versions";
 import { getConstrainedTypeAtLocation, isTypeReadonly } from "@typescript-eslint/type-utils";
-import { getStaticValue } from "@typescript-eslint/utils/ast-utils";
+import { getStaticValue, isIdentifier, isVariableDeclarator } from "@typescript-eslint/utils/ast-utils";
+import "@typescript-eslint/utils/ts-eslint";
 import { getTypeImmutability, isImmutable, isReadonlyDeep, isReadonlyShallow, isUnknown } from "is-immutable-type";
 import { camelCase } from "string-ts";
 
@@ -33,7 +34,7 @@ var __export = (all, symbols) => {
 //#endregion
 //#region package.json
 var name$6 = "eslint-plugin-react-x";
-var version = "2.3.8-next.1";
+var version = "2.3.9-next.0";
 
 //#endregion
 //#region src/utils/create-rule.ts
@@ -2274,7 +2275,10 @@ var no_unnecessary_use_callback_default = createRule({
 			description: "Disallow unnecessary usage of `useCallback`.",
 			[Symbol.for("rule_features")]: RULE_FEATURES$16
 		},
-		messages: { noUnnecessaryUseCallback: "An 'useCallback' with empty deps and no references to the component scope may be unnecessary." },
+		messages: {
+			noUnnecessaryUseCallback: "An 'useCallback' with empty deps and no references to the component scope may be unnecessary.",
+			noUnnecessaryUseCallbackInsideUseEffect: "{{name}} is only used inside 1 useEffect, which may be unnecessary. You can move the computation into useEffect directly and merge the dependency arrays."
+		},
 		schema: []
 	},
 	name: RULE_NAME$18,
@@ -2285,6 +2289,7 @@ function create$18(context) {
 	if (!context.sourceCode.text.includes("useCallback")) return {};
 	return { CallExpression(node) {
 		if (!isUseCallbackCall(node)) return;
+		const checkForUsageInsideUseEffectReport = checkForUsageInsideUseEffect$1(context.sourceCode, node);
 		const initialScope = context.sourceCode.getScope(node);
 		const component = context.sourceCode.getScope(node).block;
 		if (!AST.isFunction(component)) return;
@@ -2294,7 +2299,10 @@ function create$18(context) {
 			const variableNode = getVariableDefinitionNode(findVariable(n.name, initialScope), 0);
 			if (variableNode?.type !== AST_NODE_TYPES.ArrayExpression) return false;
 			return variableNode.elements.length === 0;
-		}).otherwise(() => false)) return;
+		}).otherwise(() => false)) {
+			report(context)(checkForUsageInsideUseEffectReport);
+			return;
+		}
 		const arg0Node = match(arg0).with({ type: AST_NODE_TYPES.ArrowFunctionExpression }, (n) => {
 			if (n.body.type === AST_NODE_TYPES.ArrowFunctionExpression) return n.body;
 			return n;
@@ -2304,12 +2312,34 @@ function create$18(context) {
 			return variableNode;
 		}).otherwise(() => null);
 		if (arg0Node == null) return;
-		if (!getChildScopes(context.sourceCode.getScope(arg0Node)).flatMap((x) => x.references).some((x) => x.resolved?.scope.block === component)) context.report({
-			messageId: "noUnnecessaryUseCallback",
-			node
-		});
+		if (!getChildScopes(context.sourceCode.getScope(arg0Node)).flatMap((x) => x.references).some((x) => x.resolved?.scope.block === component)) {
+			context.report({
+				messageId: "noUnnecessaryUseCallback",
+				node
+			});
+			return;
+		}
+		report(context)(checkForUsageInsideUseEffectReport);
 	} };
 }
+function checkForUsageInsideUseEffect$1(sourceCode, node) {
+	if (!/use\w*Effect/u.test(sourceCode.text)) return;
+	if (!isVariableDeclarator(node.parent)) return;
+	if (!isIdentifier(node.parent.id)) return;
+	const usages = (sourceCode.getDeclaredVariables(node.parent)[0]?.references ?? []).filter((ref) => !(ref.init ?? false));
+	const effectSet = /* @__PURE__ */ new Set();
+	for (const usage of usages) {
+		const effect = AST.findParentNode(usage.identifier, isUseEffectLikeCall);
+		if (effect == null) return;
+		effectSet.add(effect);
+		if (effectSet.size > 1) return;
+	}
+	return {
+		messageId: "noUnnecessaryUseCallbackInsideUseEffect",
+		node,
+		data: { name: node.parent.id.name }
+	};
+}
 
 //#endregion
 //#region src/rules/no-unnecessary-use-memo.ts
@@ -2322,7 +2352,10 @@ var no_unnecessary_use_memo_default = createRule({
 			description: "Disallow unnecessary usage of `useMemo`.",
 			[Symbol.for("rule_features")]: RULE_FEATURES$15
 		},
-		messages: { noUnnecessaryUseMemo: "An 'useMemo' with empty deps and no references to the component scope may be unnecessary." },
+		messages: {
+			noUnnecessaryUseMemo: "An 'useMemo' with empty deps and no references to the component scope may be unnecessary.",
+			noUnnecessaryUseMemoInsideUseEffect: "{{name}} is only used inside 1 useEffect, which may be unnecessary. You can move the computation into useEffect directly and merge the dependency arrays."
+		},
 		schema: []
 	},
 	name: RULE_NAME$17,
@@ -2334,16 +2367,23 @@ function create$17(context) {
 	return { CallExpression(node) {
 		const initialScope = context.sourceCode.getScope(node);
 		if (!isUseMemoCall(node)) return;
+		const checkForUsageInsideUseEffectReport = checkForUsageInsideUseEffect(context.sourceCode, node);
 		const component = context.sourceCode.getScope(node).block;
 		if (!AST.isFunction(component)) return;
 		const [arg0, arg1] = node.arguments;
 		if (arg0 == null || arg1 == null) return;
-		if (AST.isFunction(arg0) && [...AST.getNestedCallExpressions(arg0.body), ...AST.getNestedNewExpressions(arg0.body)].length > 0) return;
+		if (AST.isFunction(arg0) && [...AST.getNestedCallExpressions(arg0.body), ...AST.getNestedNewExpressions(arg0.body)].length > 0) {
+			report(context)(checkForUsageInsideUseEffectReport);
+			return;
+		}
 		if (!match(arg1).with({ type: AST_NODE_TYPES.ArrayExpression }, (n) => n.elements.length === 0).with({ type: AST_NODE_TYPES.Identifier }, (n) => {
 			const variableNode = getVariableDefinitionNode(findVariable(n.name, initialScope), 0);
 			if (variableNode?.type !== AST_NODE_TYPES.ArrayExpression) return false;
 			return variableNode.elements.length === 0;
-		}).otherwise(() => false)) return;
+		}).otherwise(() => false)) {
+			report(context)(checkForUsageInsideUseEffectReport);
+			return;
+		}
 		const arg0Node = match(arg0).with({ type: AST_NODE_TYPES.ArrowFunctionExpression }, (n) => {
 			if (n.body.type === AST_NODE_TYPES.ArrowFunctionExpression) return n.body;
 			return n;
@@ -2353,12 +2393,34 @@ function create$17(context) {
 			return variableNode;
 		}).otherwise(() => null);
 		if (arg0Node == null) return;
-		if (!getChildScopes(context.sourceCode.getScope(arg0Node)).flatMap((x) => x.references).some((x) => x.resolved?.scope.block === component)) context.report({
-			messageId: "noUnnecessaryUseMemo",
-			node
-		});
+		if (!getChildScopes(context.sourceCode.getScope(arg0Node)).flatMap((x) => x.references).some((x) => x.resolved?.scope.block === component)) {
+			context.report({
+				messageId: "noUnnecessaryUseMemo",
+				node
+			});
+			return;
+		}
+		report(context)(checkForUsageInsideUseEffectReport);
 	} };
 }
+function checkForUsageInsideUseEffect(sourceCode, node) {
+	if (!/use\w*Effect/u.test(sourceCode.text)) return;
+	if (!isVariableDeclarator(node.parent)) return;
+	if (!isIdentifier(node.parent.id)) return;
+	const usages = (sourceCode.getDeclaredVariables(node.parent)[0]?.references ?? []).filter((ref) => !(ref.init ?? false));
+	const effectSet = /* @__PURE__ */ new Set();
+	for (const usage of usages) {
+		const effect = AST.findParentNode(usage.identifier, isUseEffectLikeCall);
+		if (effect == null) return;
+		effectSet.add(effect);
+		if (effectSet.size > 1) return;
+	}
+	return {
+		messageId: "noUnnecessaryUseMemoInsideUseEffect",
+		node,
+		data: { name: node.parent.id.name }
+	};
+}
 
 //#endregion
 //#region src/rules/no-unnecessary-use-prefix.ts

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-x",
-  "version": "2.3.8-next.1",
+  "version": "2.3.9-next.0",
   "description": "A set of composable ESLint rules for for libraries and frameworks that use React as a UI runtime.",
   "keywords": [
     "react",
@@ -37,30 +37,30 @@
     "./package.json"
   ],
   "dependencies": {
-    "@typescript-eslint/scope-manager": "^8.47.0",
-    "@typescript-eslint/type-utils": "^8.47.0",
-    "@typescript-eslint/types": "^8.47.0",
-    "@typescript-eslint/utils": "^8.47.0",
+    "@typescript-eslint/scope-manager": "^8.48.0",
+    "@typescript-eslint/type-utils": "^8.48.0",
+    "@typescript-eslint/types": "^8.48.0",
+    "@typescript-eslint/utils": "^8.48.0",
     "compare-versions": "^6.1.1",
     "is-immutable-type": "^5.0.1",
     "string-ts": "^2.2.1",
     "ts-api-utils": "^2.1.0",
     "ts-pattern": "^5.9.0",
-    "@eslint-react/ast": "2.3.8-next.1",
-    "@eslint-react/core": "2.3.8-next.1",
-    "@eslint-react/eff": "2.3.8-next.1",
-    "@eslint-react/var": "2.3.8-next.1",
-    "@eslint-react/shared": "2.3.8-next.1"
+    "@eslint-react/ast": "2.3.9-next.0",
+    "@eslint-react/eff": "2.3.9-next.0",
+    "@eslint-react/core": "2.3.9-next.0",
+    "@eslint-react/shared": "2.3.9-next.0",
+    "@eslint-react/var": "2.3.9-next.0"
   },
   "devDependencies": {
-    "@types/react": "^19.2.6",
+    "@types/react": "^19.2.7",
     "@types/react-dom": "^19.2.3",
-    "tsdown": "^0.16.6",
+    "tsdown": "^0.16.7",
     "@local/configs": "0.0.0"
   },
   "peerDependencies": {
-    "eslint": "^9.39.1",
-    "typescript": "^5.9.3"
+    "eslint": "^8.57.0 || ^9.0.0",
+    "typescript": ">=4.8.4 <6.0.0"
   },
   "engines": {
     "node": ">=20.19.0"