eslint-plugin-react-x 2.3.10-next.1 → 2.3.10-next.2

package/dist/index.js

@@ -1,7 +1,7 @@
 import { DEFAULT_ESLINT_REACT_SETTINGS, WEBSITE_URL, coerceSettings, getConfigAdapters, getSettingsFromContext, report, toRegExp } from "@eslint-react/shared";
 import { AST_NODE_TYPES } from "@typescript-eslint/types";
 import { ESLintUtils } from "@typescript-eslint/utils";
-import { isFalseLiteralType, isTrueLiteralType, isTypeFlagSet, unionConstituents } from "ts-api-utils";
+import { isFalseLiteralType, isPropertyReadonlyInType, isTrueLiteralType, isTypeFlagSet, unionConstituents } from "ts-api-utils";
 import { P, isMatching, match } from "ts-pattern";
 import ts from "typescript";
 import * as AST from "@eslint-react/ast";
@@ -34,7 +34,7 @@ var __export = (all, symbols) => {
 //#endregion
 //#region package.json
 var name$6 = "eslint-plugin-react-x";
-var version = "2.3.10-next.1";
+var version = "2.3.10-next.2";
 
 //#endregion
 //#region src/utils/create-rule.ts
@@ -3451,6 +3451,7 @@ var prefer_read_only_props_default = createRule({
 });
 function create$2(context) {
 	const services = ESLintUtils.getParserServices(context, false);
+	const checker = services.program.getTypeChecker();
 	const { ctx, listeners } = useComponentCollector(context);
 	return {
 		...listeners,
@@ -3461,7 +3462,10 @@ function create$2(context) {
 				if (component.name == null) continue;
 				const [props] = component.node.params;
 				if (props == null) continue;
-				if (isTypeReadonlyLoose(services, getConstrainedTypeAtLocation(services, props))) continue;
+				const propsType = getConstrainedTypeAtLocation(services, props);
+				if (isTypeReadonly(services.program, propsType)) continue;
+				if (isTypeReadonlyLoose(services, propsType)) continue;
+				if (propsType.isClassOrInterface() && isClassOrInterfaceReadonlyLoose(checker, propsType)) continue;
 				context.report({
 					messageId: "preferReadOnlyProps",
 					node: props
@@ -3471,7 +3475,6 @@ function create$2(context) {
 	};
 }
 function isTypeReadonlyLoose(services, type) {
-	if (isTypeReadonly(services.program, type)) return true;
 	try {
 		const im = getTypeImmutability(services.program, type);
 		return isUnknown(im) || isImmutable(im) || isReadonlyShallow(im) || isReadonlyDeep(im);
@@ -3479,6 +3482,18 @@ function isTypeReadonlyLoose(services, type) {
 		return true;
 	}
 }
+function isClassOrInterfaceReadonlyLoose(checker, type) {
+	const baseTypes = type.getBaseTypes() ?? [];
+	const properties = type.getProperties();
+	if (properties.length === 0) return true;
+	if (baseTypes.length === 0) return properties.every((property) => isPropertyReadonlyInType(type, property.getEscapedName(), checker));
+	for (const property of properties) {
+		const propertyName = property.getEscapedName();
+		if (isPropertyReadonlyInType(type, propertyName, checker)) continue;
+		else if (baseTypes.length > 0) return baseTypes.every((heritageType) => isPropertyReadonlyInType(heritageType, propertyName, checker));
+	}
+	return true;
+}
 
 //#endregion
 //#region src/rules/prefer-use-state-lazy-initialization.ts

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-x",
-  "version": "2.3.10-next.1",
+  "version": "2.3.10-next.2",
   "description": "A set of composable ESLint rules for for libraries and frameworks that use React as a UI runtime.",
   "keywords": [
     "react",
@@ -46,16 +46,16 @@
     "string-ts": "^2.3.1",
     "ts-api-utils": "^2.1.0",
     "ts-pattern": "^5.9.0",
-    "@eslint-react/ast": "2.3.10-next.1",
-    "@eslint-react/shared": "2.3.10-next.1",
-    "@eslint-react/core": "2.3.10-next.1",
-    "@eslint-react/var": "2.3.10-next.1",
-    "@eslint-react/eff": "2.3.10-next.1"
+    "@eslint-react/ast": "2.3.10-next.2",
+    "@eslint-react/eff": "2.3.10-next.2",
+    "@eslint-react/core": "2.3.10-next.2",
+    "@eslint-react/shared": "2.3.10-next.2",
+    "@eslint-react/var": "2.3.10-next.2"
   },
   "devDependencies": {
     "@types/react": "^19.2.7",
     "@types/react-dom": "^19.2.3",
-    "tsdown": "^0.17.0-beta.3",
+    "tsdown": "^0.17.0-beta.4",
     "@local/configs": "0.0.0"
   },
   "peerDependencies": {