eslint-plugin-react-x 2.0.5-beta.1 → 2.0.5-beta.3

package/dist/index.js

@@ -6,7 +6,7 @@ import { P, isMatching, match } from "ts-pattern";
 import ts from "typescript";
 import * as AST from "@eslint-react/ast";
 import { ConstructionDetectionHint, findVariable, getChildScopes, getConstruction, getVariableDefinitionNode } from "@eslint-react/var";
-import { ComponentDetectionHint, ComponentFlag, DEFAULT_COMPONENT_DETECTION_HINT, JsxEmit, findParentJsxAttribute, getInstanceId, getJsxAttribute, getJsxAttributeName, getJsxConfigFromAnnotation, getJsxConfigFromContext, getJsxElementType, hasJsxAttribute, isAssignmentToThisState, isCaptureOwnerStackCall, isChildrenCount, isChildrenForEach, isChildrenMap, isChildrenOnly, isChildrenToArray, isChildrenToArrayCall, isClassComponent, isCloneElementCall, isComponentDidCatch, isComponentDidMount, isComponentDidUpdate, isComponentNameLoose, isComponentWillMount, isComponentWillReceiveProps, isComponentWillUpdate, isCreateContextCall, isCreateElementCall, isCreateRefCall, isDeclaredInRenderPropLoose, isDirectValueOfRenderPropertyLoose, isForwardRefCall, isGetDerivedStateFromError, isGetDerivedStateFromProps, isInitializedFromReact, isInstanceIdEqual, isJsxFragmentElement, isJsxHostElement, isJsxText, isLazyCall, isReactHookCall, isReactHookName, isRenderMethodLike, isThisSetState, isUnsafeComponentWillMount, isUnsafeComponentWillReceiveProps, isUnsafeComponentWillUpdate, isUseCall, isUseCallbackCall, isUseContextCall, isUseMemoCall, isUseStateCall, useComponentCollector, useComponentCollectorLegacy, useHookCollector } from "@eslint-react/core";
+import { ComponentDetectionHint, ComponentFlag, DEFAULT_COMPONENT_DETECTION_HINT, JsxEmit, findParentJsxAttribute, getInstanceId, getJsxAttribute, getJsxAttributeName, getJsxConfigFromAnnotation, getJsxConfigFromContext, getJsxElementType, isAssignmentToThisState, isCaptureOwnerStackCall, isChildrenCount, isChildrenForEach, isChildrenMap, isChildrenOnly, isChildrenToArray, isChildrenToArrayCall, isClassComponent, isCloneElementCall, isComponentDidCatch, isComponentDidMount, isComponentDidUpdate, isComponentNameLoose, isComponentWillMount, isComponentWillReceiveProps, isComponentWillUpdate, isCreateContextCall, isCreateElementCall, isCreateRefCall, isDeclaredInRenderPropLoose, isDirectValueOfRenderPropertyLoose, isForwardRefCall, isGetDerivedStateFromError, isGetDerivedStateFromProps, isInitializedFromReact, isInstanceIdEqual, isJsxFragmentElement, isJsxHostElement, isJsxText, isLazyCall, isReactHookCall, isReactHookName, isRenderMethodLike, isThisSetState, isUnsafeComponentWillMount, isUnsafeComponentWillReceiveProps, isUnsafeComponentWillUpdate, isUseCall, isUseCallbackCall, isUseContextCall, isUseMemoCall, isUseStateCall, useComponentCollector, useComponentCollectorLegacy, useHookCollector } from "@eslint-react/core";
 import { report, toRegExp } from "@eslint-react/kit";
 import { constFalse, constTrue, flow, getOrElseUpdate, identity, unit } from "@eslint-react/eff";
 import { compare } from "compare-versions";
@@ -115,7 +115,7 @@ const settings = { ...settings$1 };
 //#endregion
 //#region package.json
 var name = "eslint-plugin-react-x";
-var version = "2.0.5-beta.1";
+var version = "2.0.5-beta.3";
 
 //#endregion
 //#region src/utils/create-rule.ts
@@ -905,7 +905,7 @@ var no_children_prop_default = createRule({
 });
 function create$46(context) {
 	return { JSXElement(node) {
-		const childrenProp = getJsxAttribute(context, node.openingElement.attributes, context.sourceCode.getScope(node))("children");
+		const childrenProp = getJsxAttribute(context, node)("children");
 		if (childrenProp != null) context.report({
 			messageId: "noChildrenProp",
 			node: childrenProp
@@ -1534,8 +1534,7 @@ var no_implicit_key_default = createRule({
 });
 function create$32(context) {
 	return { JSXOpeningElement(node) {
-		const initialScope = context.sourceCode.getScope(node);
-		const keyProp = getJsxAttribute(context, node.attributes, initialScope)("key");
+		const keyProp = getJsxAttribute(context, node.parent)("key");
 		const isKeyPropOnElement = node.attributes.some((n) => n.type === AST_NODE_TYPES.JSXAttribute && n.name.type === AST_NODE_TYPES.JSXIdentifier && n.name.name === "key");
 		if (keyProp != null && !isKeyPropOnElement) context.report({
 			messageId: "noImplicitKey",
@@ -1751,14 +1750,12 @@ function create$28(context) {
 	const state = { isWithinChildrenToArray: false };
 	function checkIteratorElement(node) {
 		switch (node.type) {
-			case AST_NODE_TYPES.JSXElement: {
-				const initialScope = context.sourceCode.getScope(node);
-				if (!hasJsxAttribute(context, "key", node.openingElement.attributes, initialScope)) return {
+			case AST_NODE_TYPES.JSXElement:
+				if (getJsxAttribute(context, node)("key") == null) return {
 					messageId: "missingKey",
 					node
 				};
 				return null;
-			}
 			case AST_NODE_TYPES.JSXFragment: return {
 				messageId: "unexpectedFragmentSyntax",
 				node
@@ -1794,7 +1791,7 @@ function create$28(context) {
 			const elements = node.elements.filter(AST.is(AST_NODE_TYPES.JSXElement));
 			if (elements.length === 0) return;
 			const initialScope = context.sourceCode.getScope(node);
-			for (const element of elements) if (!hasJsxAttribute(context, "key", element.openingElement.attributes, initialScope)) context.report({
+			for (const element of elements) if (getJsxAttribute(context, element, initialScope)("key") == null) context.report({
 				messageId: "missingKey",
 				node: element
 			});
@@ -3266,8 +3263,7 @@ function trimLikeReact(text) {
 * Check if a fragment node is useless and should be reported
 */
 function checkNode(context, node, allowExpressions) {
-	const initialScope = context.sourceCode.getScope(node);
-	if (node.type === AST_NODE_TYPES.JSXElement && hasJsxAttribute(context, "key", node.openingElement.attributes, initialScope)) return;
+	if (node.type === AST_NODE_TYPES.JSXElement && getJsxAttribute(context, node)("key") != null) return;
 	if (isJsxHostElement(context, node.parent)) context.report({
 		messageId: "uselessFragment",
 		node,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-x",
-  "version": "2.0.5-beta.1",
+  "version": "2.0.5-beta.3",
   "description": "A set of composable ESLint rules for for libraries and frameworks that use React as a UI runtime.",
   "keywords": [
     "react",
@@ -43,12 +43,12 @@
     "string-ts": "^2.2.1",
     "ts-api-utils": "^2.1.0",
     "ts-pattern": "^5.8.0",
-    "@eslint-react/core": "2.0.5-beta.1",
-    "@eslint-react/ast": "2.0.5-beta.1",
-    "@eslint-react/eff": "2.0.5-beta.1",
-    "@eslint-react/shared": "2.0.5-beta.1",
-    "@eslint-react/kit": "2.0.5-beta.1",
-    "@eslint-react/var": "2.0.5-beta.1"
+    "@eslint-react/ast": "2.0.5-beta.3",
+    "@eslint-react/eff": "2.0.5-beta.3",
+    "@eslint-react/core": "2.0.5-beta.3",
+    "@eslint-react/kit": "2.0.5-beta.3",
+    "@eslint-react/shared": "2.0.5-beta.3",
+    "@eslint-react/var": "2.0.5-beta.3"
   },
   "devDependencies": {
     "@types/react": "^19.1.16",
@@ -58,7 +58,7 @@
   },
   "peerDependencies": {
     "eslint": "^9.36.0",
-    "typescript": "^5.9.2"
+    "typescript": "^5.9.3"
   },
   "engines": {
     "node": ">=20.19.0"