eslint-plugin-react-x 1.53.1-next.0 → 1.53.1-next.2

package/dist/index.js

@@ -5,11 +5,13 @@ var __getOwnPropDesc = Object.getOwnPropertyDescriptor;
 var __getOwnPropNames = Object.getOwnPropertyNames;
 var __getProtoOf = Object.getPrototypeOf;
 var __hasOwnProp = Object.prototype.hasOwnProperty;
-var __export = (target, all) => {
+var __export = (all) => {
+	let target = {};
 	for (var name$4 in all) __defProp(target, name$4, {
 		get: all[name$4],
 		enumerable: true
 	});
+	return target;
 };
 var __copyProps = (to, from, except, desc) => {
 	if (from && typeof from === "object" || typeof from === "function") for (var keys = __getOwnPropNames(from), i = 0, n = keys.length, key; i < n; i++) {
@@ -27,24 +29,37 @@ var __toESM = (mod, isNodeMode, target) => (target = mod != null ? __create(__ge
 }) : target, mod));
 
 //#endregion
-const __eslint_react_shared = __toESM(require("@eslint-react/shared"));
-const __eslint_react_core = __toESM(require("@eslint-react/core"));
-const __typescript_eslint_utils = __toESM(require("@typescript-eslint/utils"));
-const __eslint_react_kit = __toESM(require("@eslint-react/kit"));
-const __typescript_eslint_types = __toESM(require("@typescript-eslint/types"));
-const __eslint_react_var = __toESM(require("@eslint-react/var"));
-const ts_pattern = __toESM(require("ts-pattern"));
-const __eslint_react_ast = __toESM(require("@eslint-react/ast"));
-const __eslint_react_eff = __toESM(require("@eslint-react/eff"));
-const compare_versions = __toESM(require("compare-versions"));
-const __typescript_eslint_type_utils = __toESM(require("@typescript-eslint/type-utils"));
-const ts_api_utils = __toESM(require("ts-api-utils"));
-const typescript = __toESM(require("typescript"));
-const is_immutable_type = __toESM(require("is-immutable-type"));
+let __eslint_react_shared = require("@eslint-react/shared");
+__eslint_react_shared = __toESM(__eslint_react_shared);
+let __eslint_react_core = require("@eslint-react/core");
+__eslint_react_core = __toESM(__eslint_react_core);
+let __typescript_eslint_utils = require("@typescript-eslint/utils");
+__typescript_eslint_utils = __toESM(__typescript_eslint_utils);
+let __eslint_react_kit = require("@eslint-react/kit");
+__eslint_react_kit = __toESM(__eslint_react_kit);
+let __typescript_eslint_types = require("@typescript-eslint/types");
+__typescript_eslint_types = __toESM(__typescript_eslint_types);
+let __eslint_react_var = require("@eslint-react/var");
+__eslint_react_var = __toESM(__eslint_react_var);
+let ts_pattern = require("ts-pattern");
+ts_pattern = __toESM(ts_pattern);
+let __eslint_react_ast = require("@eslint-react/ast");
+__eslint_react_ast = __toESM(__eslint_react_ast);
+let __eslint_react_eff = require("@eslint-react/eff");
+__eslint_react_eff = __toESM(__eslint_react_eff);
+let compare_versions = require("compare-versions");
+compare_versions = __toESM(compare_versions);
+let __typescript_eslint_type_utils = require("@typescript-eslint/type-utils");
+__typescript_eslint_type_utils = __toESM(__typescript_eslint_type_utils);
+let ts_api_utils = require("ts-api-utils");
+ts_api_utils = __toESM(ts_api_utils);
+let typescript = require("typescript");
+typescript = __toESM(typescript);
+let is_immutable_type = require("is-immutable-type");
+is_immutable_type = __toESM(is_immutable_type);
 
 //#region src/configs/recommended.ts
-var recommended_exports = {};
-__export(recommended_exports, {
+var recommended_exports = __export({
 	name: () => name$3,
 	rules: () => rules$2,
 	settings: () => settings$2
@@ -98,8 +113,7 @@ const settings$2 = { "react-x": __eslint_react_shared.DEFAULT_ESLINT_REACT_SETTI
 
 //#endregion
 //#region src/configs/recommended-typescript.ts
-var recommended_typescript_exports = {};
-__export(recommended_typescript_exports, {
+var recommended_typescript_exports = __export({
 	name: () => name$2,
 	rules: () => rules$1,
 	settings: () => settings$1
@@ -116,8 +130,7 @@ const settings$1 = { ...settings$2 };
 
 //#endregion
 //#region src/configs/recommended-type-checked.ts
-var recommended_type_checked_exports = {};
-__export(recommended_type_checked_exports, {
+var recommended_type_checked_exports = __export({
 	name: () => name$1,
 	rules: () => rules,
 	settings: () => settings
@@ -132,7 +145,7 @@ const settings = { ...settings$1 };
 //#endregion
 //#region package.json
 var name = "eslint-plugin-react-x";
-var version = "1.53.1-next.0";
+var version = "1.53.1-next.2";
 
 //#endregion
 //#region src/utils/create-rule.ts
@@ -363,11 +376,10 @@ var jsx_uses_react_default = createRule({
 	defaultOptions: []
 });
 function create$51(context) {
-	const jsxConfig = {
+	const { jsx, jsxFactory, jsxFragmentFactory } = {
 		...__eslint_react_kit.JsxConfig.getFromContext(context),
 		...__eslint_react_kit.JsxConfig.getFromAnnotation(context)
 	};
-	const { jsx, jsxFactory, jsxFragmentFactory } = jsxConfig;
 	if (jsx === JsxEmit.ReactJSX || jsx === JsxEmit.ReactJSXDev) return {};
 	function handleJsxElement(node) {
 		context.sourceCode.markVariableAsUsed(jsxFactory, node);
@@ -510,8 +522,7 @@ function create$49(context) {
 			const [setState, hasThisState = false] = setStateEntries.at(-1) ?? [];
 			if (setState == null || hasThisState) return;
 			if (node.init == null || !__eslint_react_ast.isThisExpression(node.init) || node.id.type !== __typescript_eslint_types.AST_NODE_TYPES.ObjectPattern) return;
-			const hasState = node.id.properties.some((prop) => prop.type === __typescript_eslint_types.AST_NODE_TYPES.Property && isKeyLiteral$2(prop, prop.key) && __eslint_react_ast.getPropertyName(prop.key) === "state");
-			if (!hasState) return;
+			if (!node.id.properties.some((prop) => prop.type === __typescript_eslint_types.AST_NODE_TYPES.Property && isKeyLiteral$2(prop, prop.key) && __eslint_react_ast.getPropertyName(prop.key) === "state")) return;
 			context.report({
 				messageId: "noAccessStateInSetstate",
 				node
@@ -1089,8 +1100,7 @@ function create$34(context) {
 	const { version: version$1 } = (0, __eslint_react_shared.getSettingsFromContext)(context);
 	if ((0, compare_versions.compare)(version$1, "19.0.0", "<")) return {};
 	return { JSXElement(node) {
-		const fullName = __eslint_react_core.getElementType(context, node);
-		const parts = fullName.split(".");
+		const parts = __eslint_react_core.getElementType(context, node).split(".");
 		const selfName = parts.pop();
 		const contextFullName = parts.join(".");
 		const contextSelfName = parts.pop();
@@ -1507,23 +1517,20 @@ function create$27(context) {
 			type: __typescript_eslint_types.AST_NODE_TYPES.LogicalExpression,
 			operator: "&&"
 		}, ({ left, right }) => {
-			const isLeftUnaryNot = left.type === __typescript_eslint_types.AST_NODE_TYPES.UnaryExpression && left.operator === "!";
-			if (isLeftUnaryNot) return getReportDescriptor(right);
+			if (left.type === __typescript_eslint_types.AST_NODE_TYPES.UnaryExpression && left.operator === "!") return getReportDescriptor(right);
 			const initialScope = context.sourceCode.getScope(left);
-			const isLeftNan = left.type === __typescript_eslint_types.AST_NODE_TYPES.Identifier && left.name === "NaN" || __eslint_react_var.toStaticValue({
+			if (left.type === __typescript_eslint_types.AST_NODE_TYPES.Identifier && left.name === "NaN" || __eslint_react_var.toStaticValue({
 				kind: "lazy",
 				node: left,
 				initialScope
-			}).value === "NaN";
-			if (isLeftNan) return {
+			}).value === "NaN") return {
 				messageId: "noLeakedConditionalRendering",
 				node: left,
 				data: { value: context.sourceCode.getText(left) }
 			};
 			const leftType = (0, __typescript_eslint_type_utils.getConstrainedTypeAtLocation)(services, left);
 			const leftTypeVariants = inspectVariantTypes((0, ts_api_utils.unionTypeParts)(leftType));
-			const isLeftValid = Array.from(leftTypeVariants.values()).every((type) => allowedVariants.some((allowed) => allowed === type));
-			if (isLeftValid) return getReportDescriptor(right);
+			if (Array.from(leftTypeVariants.values()).every((type) => allowedVariants.some((allowed) => allowed === type))) return getReportDescriptor(right);
 			return {
 				messageId: "noLeakedConditionalRendering",
 				node: left,
@@ -1532,8 +1539,7 @@ function create$27(context) {
 		}).with({ type: __typescript_eslint_types.AST_NODE_TYPES.ConditionalExpression }, ({ alternate, consequent }) => {
 			return getReportDescriptor(consequent) ?? getReportDescriptor(alternate);
 		}).with({ type: __typescript_eslint_types.AST_NODE_TYPES.Identifier }, (n) => {
-			const variable = __eslint_react_var.findVariable(n.name, context.sourceCode.getScope(n));
-			const variableDefNode = variable?.defs.at(0)?.node;
+			const variableDefNode = __eslint_react_var.findVariable(n.name, context.sourceCode.getScope(n))?.defs.at(0)?.node;
 			return (0, ts_pattern.match)(variableDefNode).with({ init: ts_pattern.P.select({ type: ts_pattern.P.not(__typescript_eslint_types.AST_NODE_TYPES.VariableDeclaration) }) }, getReportDescriptor).otherwise(() => __eslint_react_eff.unit);
 		}).otherwise(() => __eslint_react_eff.unit);
 	}
@@ -1623,13 +1629,12 @@ function create$25(context) {
 					});
 					continue;
 				}
-				const hasDisplayNameAssignment = displayNameAssignments.some((node) => {
+				if (!displayNameAssignments.some((node) => {
 					const left = node.left;
 					if (left.type !== __typescript_eslint_types.AST_NODE_TYPES.MemberExpression) return false;
 					const object = left.object;
 					return __eslint_react_core.isInstanceIdEqual(context, id, object);
-				});
-				if (!hasDisplayNameAssignment) {
+				})) {
 					const semi = __eslint_react_kit.LanguagePreference.defaultLanguagePreference.semicolons === "always" ? ";" : "";
 					context.report({
 						messageId: "noMissingContextDisplayName",
@@ -1959,19 +1964,16 @@ function create$21(context) {
 		"Program:exit"(program) {
 			const functionComponents = [...collector.ctx.getAllComponents(program).values()];
 			const classComponents = [...collectorLegacy.ctx.getAllComponents(program).values()];
-			for (const lazy of lazyComponentDeclarations) {
-				const significantParent = __eslint_react_ast.findParentNode(lazy, (n) => {
-					if (__eslint_react_ast.isJSX(n)) return true;
-					if (n.type === __typescript_eslint_types.AST_NODE_TYPES.CallExpression) return __eslint_react_core.isReactHookCall(n) || __eslint_react_core.isCreateElementCall(context, n) || __eslint_react_core.isCreateContextCall(context, n);
-					if (__eslint_react_ast.isFunction(n)) return functionComponents.some((c) => c.node === n);
-					if (__eslint_react_ast.isClass(n)) return classComponents.some((c) => c.node === n);
-					return false;
-				});
-				if (significantParent != null) context.report({
-					messageId: "noNestedLazyComponentDeclarations",
-					node: lazy
-				});
-			}
+			for (const lazy of lazyComponentDeclarations) if (__eslint_react_ast.findParentNode(lazy, (n) => {
+				if (__eslint_react_ast.isJSX(n)) return true;
+				if (n.type === __typescript_eslint_types.AST_NODE_TYPES.CallExpression) return __eslint_react_core.isReactHookCall(n) || __eslint_react_core.isCreateElementCall(context, n) || __eslint_react_core.isCreateContextCall(context, n);
+				if (__eslint_react_ast.isFunction(n)) return functionComponents.some((c) => c.node === n);
+				if (__eslint_react_ast.isClass(n)) return classComponents.some((c) => c.node === n);
+				return false;
+			}) != null) context.report({
+				messageId: "noNestedLazyComponentDeclarations",
+				node: lazy
+			});
 		}
 	};
 }
@@ -2363,8 +2365,7 @@ function create$11(context) {
 	return {
 		...listeners,
 		JSXOpeningElement(node) {
-			const fullName = __eslint_react_core.getElementType(context, node.parent);
-			const selfName = fullName.split(".").at(-1);
+			const selfName = __eslint_react_core.getElementType(context, node.parent).split(".").at(-1);
 			if (selfName == null) return;
 			if (!isContextName(selfName, isReact18OrBelow)) return;
 			const functionEntry = ctx.getCurrentEntry();
@@ -2698,11 +2699,10 @@ function create$8(context) {
 			if (currentMethod === constructorEntries.at(-1)) return;
 			if (!currentClass.body.body.includes(currentMethod)) return;
 			if (node.init == null || !__eslint_react_ast.isThisExpression(node.init) || node.id.type !== __typescript_eslint_types.AST_NODE_TYPES.ObjectPattern) return;
-			const hasState = node.id.properties.some((prop) => {
+			if (!node.id.properties.some((prop) => {
 				if (prop.type === __typescript_eslint_types.AST_NODE_TYPES.Property && isKeyLiteral(prop, prop.key)) return __eslint_react_ast.getPropertyName(prop.key) === "state";
 				return false;
-			});
-			if (!hasState) return;
+			})) return;
 			const defNode = stateDefs.get(currentClass)?.node;
 			stateDefs.set(currentClass, {
 				node: defNode,
@@ -2822,8 +2822,7 @@ function create$6(context) {
 		if (!__eslint_react_core.isForwardRefCall(context, node)) return;
 		const [component] = node.arguments;
 		if (component == null || !__eslint_react_ast.isFunction(component)) return;
-		const ref = component.params[1];
-		if (ref != null) return;
+		if (component.params[1] != null) return;
 		context.report({
 			messageId: "noUselessForwardRef",
 			node: node.callee
@@ -3055,8 +3054,7 @@ function create$3(context) {
 				const importDeclarationText = context.sourceCode.getText(node.parent);
 				const semi = importDeclarationText.endsWith(";") ? ";" : "";
 				const quote = node.parent.source.raw.at(0) ?? "'";
-				const isTypeImport = node.parent.importKind === "type";
-				const importStringPrefix = `import${isTypeImport ? " type" : ""}`;
+				const importStringPrefix = `import${node.parent.importKind === "type" ? " type" : ""}`;
 				const importSourceQuoted = `${quote}${importSource}${quote}`;
 				if (!hasOtherSpecifiers) return fixer.replaceText(node.parent, `${importStringPrefix} * as ${node.local.name} from ${importSourceQuoted}${semi}`);
 				const specifiers = importDeclarationText.slice(importDeclarationText.indexOf("{"), importDeclarationText.indexOf("}") + 1);
@@ -3139,8 +3137,7 @@ function create$1(context) {
 	return { JSXAttribute(node) {
 		const { value } = node;
 		const propName = __eslint_react_core.getAttributeName(context, node);
-		const hasValueTrue = value?.type === __typescript_eslint_types.AST_NODE_TYPES.JSXExpressionContainer && value.expression.type === __typescript_eslint_types.AST_NODE_TYPES.Literal && value.expression.value === true;
-		if (!hasValueTrue) return;
+		if (!(value?.type === __typescript_eslint_types.AST_NODE_TYPES.JSXExpressionContainer && value.expression.type === __typescript_eslint_types.AST_NODE_TYPES.Literal && value.expression.value === true)) return;
 		context.report({
 			messageId: "preferShorthandBoolean",
 			node: node.value ?? node,
@@ -3172,8 +3169,7 @@ var prefer_shorthand_fragment_default = createRule({
 function create(context) {
 	return { JSXElement(node) {
 		if (!__eslint_react_core.isFragmentElement(context, node)) return;
-		const hasAttributes = node.openingElement.attributes.length > 0;
-		if (hasAttributes) return;
+		if (node.openingElement.attributes.length > 0) return;
 		context.report({
 			messageId: "preferShorthandFragment",
 			node,

package/dist/index.mjs

@@ -15,17 +15,18 @@ import { getTypeImmutability, isImmutable, isReadonlyDeep, isReadonlyShallow, is
 
 //#region rolldown:runtime
 var __defProp = Object.defineProperty;
-var __export = (target, all) => {
+var __export = (all) => {
+	let target = {};
 	for (var name$4 in all) __defProp(target, name$4, {
 		get: all[name$4],
 		enumerable: true
 	});
+	return target;
 };
 
 //#endregion
 //#region src/configs/recommended.ts
-var recommended_exports = {};
-__export(recommended_exports, {
+var recommended_exports = __export({
 	name: () => name$3,
 	rules: () => rules$2,
 	settings: () => settings$2
@@ -79,8 +80,7 @@ const settings$2 = { "react-x": DEFAULT_ESLINT_REACT_SETTINGS };
 
 //#endregion
 //#region src/configs/recommended-typescript.ts
-var recommended_typescript_exports = {};
-__export(recommended_typescript_exports, {
+var recommended_typescript_exports = __export({
 	name: () => name$2,
 	rules: () => rules$1,
 	settings: () => settings$1
@@ -97,8 +97,7 @@ const settings$1 = { ...settings$2 };
 
 //#endregion
 //#region src/configs/recommended-type-checked.ts
-var recommended_type_checked_exports = {};
-__export(recommended_type_checked_exports, {
+var recommended_type_checked_exports = __export({
 	name: () => name$1,
 	rules: () => rules,
 	settings: () => settings
@@ -113,7 +112,7 @@ const settings = { ...settings$1 };
 //#endregion
 //#region package.json
 var name = "eslint-plugin-react-x";
-var version = "1.53.1-next.0";
+var version = "1.53.1-next.2";
 
 //#endregion
 //#region src/utils/create-rule.ts
@@ -344,11 +343,10 @@ var jsx_uses_react_default = createRule({
 	defaultOptions: []
 });
 function create$51(context) {
-	const jsxConfig = {
+	const { jsx, jsxFactory, jsxFragmentFactory } = {
 		...JsxConfig.getFromContext(context),
 		...JsxConfig.getFromAnnotation(context)
 	};
-	const { jsx, jsxFactory, jsxFragmentFactory } = jsxConfig;
 	if (jsx === JsxEmit.ReactJSX || jsx === JsxEmit.ReactJSXDev) return {};
 	function handleJsxElement(node) {
 		context.sourceCode.markVariableAsUsed(jsxFactory, node);
@@ -491,8 +489,7 @@ function create$49(context) {
 			const [setState, hasThisState = false] = setStateEntries.at(-1) ?? [];
 			if (setState == null || hasThisState) return;
 			if (node.init == null || !AST.isThisExpression(node.init) || node.id.type !== AST_NODE_TYPES.ObjectPattern) return;
-			const hasState = node.id.properties.some((prop) => prop.type === AST_NODE_TYPES.Property && isKeyLiteral$2(prop, prop.key) && AST.getPropertyName(prop.key) === "state");
-			if (!hasState) return;
+			if (!node.id.properties.some((prop) => prop.type === AST_NODE_TYPES.Property && isKeyLiteral$2(prop, prop.key) && AST.getPropertyName(prop.key) === "state")) return;
 			context.report({
 				messageId: "noAccessStateInSetstate",
 				node
@@ -1070,8 +1067,7 @@ function create$34(context) {
 	const { version: version$1 } = getSettingsFromContext(context);
 	if (compare(version$1, "19.0.0", "<")) return {};
 	return { JSXElement(node) {
-		const fullName = ER.getElementType(context, node);
-		const parts = fullName.split(".");
+		const parts = ER.getElementType(context, node).split(".");
 		const selfName = parts.pop();
 		const contextFullName = parts.join(".");
 		const contextSelfName = parts.pop();
@@ -1488,23 +1484,20 @@ function create$27(context) {
 			type: AST_NODE_TYPES.LogicalExpression,
 			operator: "&&"
 		}, ({ left, right }) => {
-			const isLeftUnaryNot = left.type === AST_NODE_TYPES.UnaryExpression && left.operator === "!";
-			if (isLeftUnaryNot) return getReportDescriptor(right);
+			if (left.type === AST_NODE_TYPES.UnaryExpression && left.operator === "!") return getReportDescriptor(right);
 			const initialScope = context.sourceCode.getScope(left);
-			const isLeftNan = left.type === AST_NODE_TYPES.Identifier && left.name === "NaN" || VAR.toStaticValue({
+			if (left.type === AST_NODE_TYPES.Identifier && left.name === "NaN" || VAR.toStaticValue({
 				kind: "lazy",
 				node: left,
 				initialScope
-			}).value === "NaN";
-			if (isLeftNan) return {
+			}).value === "NaN") return {
 				messageId: "noLeakedConditionalRendering",
 				node: left,
 				data: { value: context.sourceCode.getText(left) }
 			};
 			const leftType = getConstrainedTypeAtLocation(services, left);
 			const leftTypeVariants = inspectVariantTypes(unionTypeParts(leftType));
-			const isLeftValid = Array.from(leftTypeVariants.values()).every((type) => allowedVariants.some((allowed) => allowed === type));
-			if (isLeftValid) return getReportDescriptor(right);
+			if (Array.from(leftTypeVariants.values()).every((type) => allowedVariants.some((allowed) => allowed === type))) return getReportDescriptor(right);
 			return {
 				messageId: "noLeakedConditionalRendering",
 				node: left,
@@ -1513,8 +1506,7 @@ function create$27(context) {
 		}).with({ type: AST_NODE_TYPES.ConditionalExpression }, ({ alternate, consequent }) => {
 			return getReportDescriptor(consequent) ?? getReportDescriptor(alternate);
 		}).with({ type: AST_NODE_TYPES.Identifier }, (n) => {
-			const variable = VAR.findVariable(n.name, context.sourceCode.getScope(n));
-			const variableDefNode = variable?.defs.at(0)?.node;
+			const variableDefNode = VAR.findVariable(n.name, context.sourceCode.getScope(n))?.defs.at(0)?.node;
 			return match(variableDefNode).with({ init: P.select({ type: P.not(AST_NODE_TYPES.VariableDeclaration) }) }, getReportDescriptor).otherwise(() => unit);
 		}).otherwise(() => unit);
 	}
@@ -1604,13 +1596,12 @@ function create$25(context) {
 					});
 					continue;
 				}
-				const hasDisplayNameAssignment = displayNameAssignments.some((node) => {
+				if (!displayNameAssignments.some((node) => {
 					const left = node.left;
 					if (left.type !== AST_NODE_TYPES.MemberExpression) return false;
 					const object = left.object;
 					return ER.isInstanceIdEqual(context, id, object);
-				});
-				if (!hasDisplayNameAssignment) {
+				})) {
 					const semi = LanguagePreference.defaultLanguagePreference.semicolons === "always" ? ";" : "";
 					context.report({
 						messageId: "noMissingContextDisplayName",
@@ -1940,19 +1931,16 @@ function create$21(context) {
 		"Program:exit"(program) {
 			const functionComponents = [...collector.ctx.getAllComponents(program).values()];
 			const classComponents = [...collectorLegacy.ctx.getAllComponents(program).values()];
-			for (const lazy of lazyComponentDeclarations) {
-				const significantParent = AST.findParentNode(lazy, (n) => {
-					if (AST.isJSX(n)) return true;
-					if (n.type === AST_NODE_TYPES.CallExpression) return ER.isReactHookCall(n) || ER.isCreateElementCall(context, n) || ER.isCreateContextCall(context, n);
-					if (AST.isFunction(n)) return functionComponents.some((c) => c.node === n);
-					if (AST.isClass(n)) return classComponents.some((c) => c.node === n);
-					return false;
-				});
-				if (significantParent != null) context.report({
-					messageId: "noNestedLazyComponentDeclarations",
-					node: lazy
-				});
-			}
+			for (const lazy of lazyComponentDeclarations) if (AST.findParentNode(lazy, (n) => {
+				if (AST.isJSX(n)) return true;
+				if (n.type === AST_NODE_TYPES.CallExpression) return ER.isReactHookCall(n) || ER.isCreateElementCall(context, n) || ER.isCreateContextCall(context, n);
+				if (AST.isFunction(n)) return functionComponents.some((c) => c.node === n);
+				if (AST.isClass(n)) return classComponents.some((c) => c.node === n);
+				return false;
+			}) != null) context.report({
+				messageId: "noNestedLazyComponentDeclarations",
+				node: lazy
+			});
 		}
 	};
 }
@@ -2344,8 +2332,7 @@ function create$11(context) {
 	return {
 		...listeners,
 		JSXOpeningElement(node) {
-			const fullName = ER.getElementType(context, node.parent);
-			const selfName = fullName.split(".").at(-1);
+			const selfName = ER.getElementType(context, node.parent).split(".").at(-1);
 			if (selfName == null) return;
 			if (!isContextName(selfName, isReact18OrBelow)) return;
 			const functionEntry = ctx.getCurrentEntry();
@@ -2679,11 +2666,10 @@ function create$8(context) {
 			if (currentMethod === constructorEntries.at(-1)) return;
 			if (!currentClass.body.body.includes(currentMethod)) return;
 			if (node.init == null || !AST.isThisExpression(node.init) || node.id.type !== AST_NODE_TYPES.ObjectPattern) return;
-			const hasState = node.id.properties.some((prop) => {
+			if (!node.id.properties.some((prop) => {
 				if (prop.type === AST_NODE_TYPES.Property && isKeyLiteral(prop, prop.key)) return AST.getPropertyName(prop.key) === "state";
 				return false;
-			});
-			if (!hasState) return;
+			})) return;
 			const defNode = stateDefs.get(currentClass)?.node;
 			stateDefs.set(currentClass, {
 				node: defNode,
@@ -2803,8 +2789,7 @@ function create$6(context) {
 		if (!ER.isForwardRefCall(context, node)) return;
 		const [component] = node.arguments;
 		if (component == null || !AST.isFunction(component)) return;
-		const ref = component.params[1];
-		if (ref != null) return;
+		if (component.params[1] != null) return;
 		context.report({
 			messageId: "noUselessForwardRef",
 			node: node.callee
@@ -3036,8 +3021,7 @@ function create$3(context) {
 				const importDeclarationText = context.sourceCode.getText(node.parent);
 				const semi = importDeclarationText.endsWith(";") ? ";" : "";
 				const quote = node.parent.source.raw.at(0) ?? "'";
-				const isTypeImport = node.parent.importKind === "type";
-				const importStringPrefix = `import${isTypeImport ? " type" : ""}`;
+				const importStringPrefix = `import${node.parent.importKind === "type" ? " type" : ""}`;
 				const importSourceQuoted = `${quote}${importSource}${quote}`;
 				if (!hasOtherSpecifiers) return fixer.replaceText(node.parent, `${importStringPrefix} * as ${node.local.name} from ${importSourceQuoted}${semi}`);
 				const specifiers = importDeclarationText.slice(importDeclarationText.indexOf("{"), importDeclarationText.indexOf("}") + 1);
@@ -3120,8 +3104,7 @@ function create$1(context) {
 	return { JSXAttribute(node) {
 		const { value } = node;
 		const propName = ER.getAttributeName(context, node);
-		const hasValueTrue = value?.type === AST_NODE_TYPES.JSXExpressionContainer && value.expression.type === AST_NODE_TYPES.Literal && value.expression.value === true;
-		if (!hasValueTrue) return;
+		if (!(value?.type === AST_NODE_TYPES.JSXExpressionContainer && value.expression.type === AST_NODE_TYPES.Literal && value.expression.value === true)) return;
 		context.report({
 			messageId: "preferShorthandBoolean",
 			node: node.value ?? node,
@@ -3153,8 +3136,7 @@ var prefer_shorthand_fragment_default = createRule({
 function create(context) {
 	return { JSXElement(node) {
 		if (!ER.isFragmentElement(context, node)) return;
-		const hasAttributes = node.openingElement.attributes.length > 0;
-		if (hasAttributes) return;
+		if (node.openingElement.attributes.length > 0) return;
 		context.report({
 			messageId: "preferShorthandFragment",
 			node,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-x",
-  "version": "1.53.1-next.0",
+  "version": "1.53.1-next.2",
   "description": "4-7x faster composable ESLint rules for for libraries and frameworks that use React as a UI runtime.",
   "keywords": [
     "react",
@@ -42,26 +42,26 @@
     "./package.json"
   ],
   "dependencies": {
-    "@typescript-eslint/scope-manager": "^8.42.0",
-    "@typescript-eslint/type-utils": "^8.42.0",
-    "@typescript-eslint/types": "^8.42.0",
-    "@typescript-eslint/utils": "^8.42.0",
+    "@typescript-eslint/scope-manager": "^8.43.0",
+    "@typescript-eslint/type-utils": "^8.43.0",
+    "@typescript-eslint/types": "^8.43.0",
+    "@typescript-eslint/utils": "^8.43.0",
     "compare-versions": "^6.1.1",
     "is-immutable-type": "^5.0.1",
     "string-ts": "^2.2.1",
     "ts-pattern": "^5.8.0",
-    "@eslint-react/ast": "1.53.1-next.0",
-    "@eslint-react/eff": "1.53.1-next.0",
-    "@eslint-react/core": "1.53.1-next.0",
-    "@eslint-react/shared": "1.53.1-next.0",
-    "@eslint-react/kit": "1.53.1-next.0",
-    "@eslint-react/var": "1.53.1-next.0"
+    "@eslint-react/ast": "1.53.1-next.2",
+    "@eslint-react/core": "1.53.1-next.2",
+    "@eslint-react/shared": "1.53.1-next.2",
+    "@eslint-react/eff": "1.53.1-next.2",
+    "@eslint-react/kit": "1.53.1-next.2",
+    "@eslint-react/var": "1.53.1-next.2"
   },
   "devDependencies": {
     "@types/react": "^19.1.12",
     "@types/react-dom": "^19.1.9",
     "ts-api-utils": "^2.1.0",
-    "tsdown": "^0.14.2",
+    "tsdown": "^0.15.0",
     "@local/configs": "0.0.0"
   },
   "peerDependencies": {