eslint-plugin-react-x 1.38.0-next.8 → 1.38.0

package/dist/index.js

@@ -4,11 +4,11 @@ var shared = require('@eslint-react/shared');
 var JSX8 = require('@eslint-react/jsx');
 var utils = require('@typescript-eslint/utils');
 var types = require('@typescript-eslint/types');
+var eff = require('@eslint-react/eff');
 var VAR2 = require('@eslint-react/var');
+var tsPattern = require('ts-pattern');
 var AST11 = require('@eslint-react/ast');
 var core = require('@eslint-react/core');
-var eff = require('@eslint-react/eff');
-var tsPattern = require('ts-pattern');
 var kit = require('@eslint-react/kit');
 var compareVersions = require('compare-versions');
 var typeUtils = require('@typescript-eslint/type-utils');
@@ -57,7 +57,6 @@ __export(recommended_exports, {
 var name = "react-x/recommended";
 var rules = {
   "react-x/jsx-no-duplicate-props": "warn",
-  "react-x/jsx-no-undef": "error",
   "react-x/jsx-uses-vars": "warn",
   "react-x/no-access-state-in-setstate": "error",
   "react-x/no-array-index-key": "warn",
@@ -139,7 +138,7 @@ var settings3 = {
 
 // package.json
 var name4 = "eslint-plugin-react-x";
-var version = "1.38.0-next.8";
+var version = "1.38.0";
 var createRule = utils.ESLintUtils.RuleCreator(shared.getDocsUrl("x"));
 
 // src/rules/avoid-shorthand-boolean.ts
@@ -260,7 +259,7 @@ var jsx_no_undef_default = createRule({
       [Symbol.for("rule_features")]: RULE_FEATURES4
     },
     messages: {
-      jsxNoUndef: "JSX variable {{name}} is not defined."
+      jsxNoUndef: "JSX variable '{{name}}' is not defined."
     },
     schema: []
   },
@@ -270,22 +269,18 @@ var jsx_no_undef_default = createRule({
 });
 function create4(context) {
   return {
-    JSXIdentifier(node) {
-      if (node.name === "this") {
-        return;
-      }
-      if (/^[a-z]/u.test(node.name)) {
-        return;
-      }
-      if (node.parent.type === types.AST_NODE_TYPES.JSXMemberExpression && node.parent.property === node) {
-        return;
-      }
-      const initialScope = context.sourceCode.getScope(node);
-      if (VAR2__namespace.findVariable(node.name, initialScope) == null) {
+    JSXOpeningElement(node) {
+      const name5 = tsPattern.match(node.name).with({ type: types.AST_NODE_TYPES.JSXIdentifier }, (n) => n.name).with({ type: types.AST_NODE_TYPES.JSXMemberExpression, object: { type: types.AST_NODE_TYPES.JSXIdentifier } }, (n) => n.object.name).otherwise(() => eff._);
+      if (name5 == null) return;
+      if (name5 === "this") return;
+      if (/^[a-z]/u.test(name5)) return;
+      if (VAR2__namespace.findVariable(name5, context.sourceCode.getScope(node)) == null) {
         context.report({
           messageId: "jsxNoUndef",
           node,
-          data: { name: node.name }
+          data: {
+            name: name5
+          }
         });
       }
     }
@@ -297,7 +292,7 @@ var jsx_uses_vars_default = createRule({
   meta: {
     type: "problem",
     docs: {
-      description: "Marks variables used in JSX as used.",
+      description: "Marks variables used in JSX elements as used.",
       [Symbol.for("rule_features")]: RULE_FEATURES5
     },
     messages: {
@@ -446,20 +441,6 @@ function create6(context) {
 var RULE_NAME7 = "no-array-index-key";
 var RULE_FEATURES7 = [];
 var reactChildrenMethod = ["forEach", "map"];
-var iteratorFunctionIndexParamPosition = /* @__PURE__ */ new Map([
-  ["every", 1],
-  ["filter", 1],
-  ["find", 1],
-  ["findIndex", 1],
-  ["findLast", 1],
-  ["findLastIndex", 1],
-  ["flatMap", 1],
-  ["forEach", 1],
-  ["map", 1],
-  ["reduce", 2],
-  ["reduceRight", 2],
-  ["some", 1]
-]);
 function isReactChildrenMethod(name5) {
   return reactChildrenMethod.some((method) => method === name5);
 }
@@ -490,7 +471,7 @@ function getMapIndexParamName(context, node) {
     return eff._;
   }
   const { name: name5 } = callee.property;
-  if (!iteratorFunctionIndexParamPosition.has(name5)) {
+  if (!AST11__namespace.ITERATOR_FUNCTION_INDEX_PARAM_POSITION.has(name5)) {
     return eff._;
   }
   const callbackArg = node.arguments[isUsingReactChildren(context, node) ? 1 : 0];
@@ -501,7 +482,7 @@ function getMapIndexParamName(context, node) {
     return eff._;
   }
   const { params } = callbackArg;
-  const indexParamPosition = iteratorFunctionIndexParamPosition.get(name5);
+  const indexParamPosition = AST11__namespace.ITERATOR_FUNCTION_INDEX_PARAM_POSITION.get(name5);
   if (indexParamPosition == null) {
     return eff._;
   }
@@ -1359,7 +1340,7 @@ function create25(context) {
           break;
         }
         default: {
-          const call = AST11__namespace.findParentNode(jsxElement, AST11__namespace.isMapCallLoose);
+          const call = AST11__namespace.findParentNode(jsxElement, AST11__namespace.isArrayMapCallLoose);
           const iter = AST11__namespace.findParentNode(jsxElement, (n) => n === call || AST11__namespace.isFunction(n));
           if (!AST11__namespace.isFunction(iter)) return;
           const arg0 = call?.arguments[0];
@@ -1896,7 +1877,7 @@ function create31(context) {
       if (state.isWithinChildrenToArray) {
         return;
       }
-      const isMapCall = AST11__namespace.isMapCallLoose(node);
+      const isMapCall = AST11__namespace.isArrayMapCallLoose(node);
       if (!isMapCall && !isArrayFromCall(node)) {
         return;
       }
@@ -1951,7 +1932,7 @@ var no_nested_component_definitions_default = createRule({
   defaultOptions: []
 });
 function create32(context) {
-  const hint = core.ERComponentHint.SkipMapCallback | core.ERComponentHint.SkipNullLiteral | core.ERComponentHint.SkipUndefined | core.ERComponentHint.SkipBooleanLiteral | core.ERComponentHint.SkipStringLiteral | core.ERComponentHint.SkipNumberLiteral | core.ERComponentHint.StrictLogical | core.ERComponentHint.StrictConditional;
+  const hint = core.ERComponentHint.SkipArrayMapArgument | core.ERComponentHint.SkipNullLiteral | core.ERComponentHint.SkipUndefined | core.ERComponentHint.SkipBooleanLiteral | core.ERComponentHint.SkipStringLiteral | core.ERComponentHint.SkipNumberLiteral | core.ERComponentHint.StrictLogical | core.ERComponentHint.StrictConditional;
   const collector = core.useComponentCollector(context, { hint });
   const collectorLegacy = core.useComponentCollectorLegacy();
   return {

package/dist/index.mjs

@@ -2,11 +2,11 @@ import { getDocsUrl, getSettingsFromContext, unsafeDecodeSettings, DEFAULT_ESLIN
 import * as JSX8 from '@eslint-react/jsx';
 import { ESLintUtils } from '@typescript-eslint/utils';
 import { AST_NODE_TYPES } from '@typescript-eslint/types';
+import { _, flow, getOrUpdate, constTrue, constFalse } from '@eslint-react/eff';
 import * as VAR2 from '@eslint-react/var';
+import { match, isMatching, P } from 'ts-pattern';
 import * as AST11 from '@eslint-react/ast';
 import { isClassComponent, isThisSetState, isChildrenCount, isChildrenForEach, isChildrenMap, isChildrenOnly, isChildrenToArray, useComponentCollectorLegacy, isComponentDidCatch, isGetDerivedStateFromError, isCloneElementCall, isComponentNameLoose, isCreateRefCall, isAssignmentToThisState, isForwardRefCall, useComponentCollector, DEFAULT_COMPONENT_HINT, ERComponentFlag, getInstanceId, isInstanceIdEqual, DISPLAY_NAME_ASSIGNMENT_SELECTOR, isCreateContextCall, isChildrenToArrayCall, ERComponentHint, isDirectValueOfRenderPropertyLoose, isDeclaredInRenderPropLoose, isInsideRenderMethod, isCreateElementCall, isReactHookCall, isReactHookCallWithNameAlias, isGetDerivedStateFromProps, isInitializedFromReact } from '@eslint-react/core';
-import { _, flow, getOrUpdate, constTrue, constFalse } from '@eslint-react/eff';
-import { isMatching, match, P } from 'ts-pattern';
 import { createReport } from '@eslint-react/kit';
 import { compare } from 'compare-versions';
 import { getConstrainedTypeAtLocation, isTypeReadonly } from '@typescript-eslint/type-utils';
@@ -30,7 +30,6 @@ __export(recommended_exports, {
 var name = "react-x/recommended";
 var rules = {
   "react-x/jsx-no-duplicate-props": "warn",
-  "react-x/jsx-no-undef": "error",
   "react-x/jsx-uses-vars": "warn",
   "react-x/no-access-state-in-setstate": "error",
   "react-x/no-array-index-key": "warn",
@@ -112,7 +111,7 @@ var settings3 = {
 
 // package.json
 var name4 = "eslint-plugin-react-x";
-var version = "1.38.0-next.8";
+var version = "1.38.0";
 var createRule = ESLintUtils.RuleCreator(getDocsUrl("x"));
 
 // src/rules/avoid-shorthand-boolean.ts
@@ -233,7 +232,7 @@ var jsx_no_undef_default = createRule({
       [Symbol.for("rule_features")]: RULE_FEATURES4
     },
     messages: {
-      jsxNoUndef: "JSX variable {{name}} is not defined."
+      jsxNoUndef: "JSX variable '{{name}}' is not defined."
     },
     schema: []
   },
@@ -243,22 +242,18 @@ var jsx_no_undef_default = createRule({
 });
 function create4(context) {
   return {
-    JSXIdentifier(node) {
-      if (node.name === "this") {
-        return;
-      }
-      if (/^[a-z]/u.test(node.name)) {
-        return;
-      }
-      if (node.parent.type === AST_NODE_TYPES.JSXMemberExpression && node.parent.property === node) {
-        return;
-      }
-      const initialScope = context.sourceCode.getScope(node);
-      if (VAR2.findVariable(node.name, initialScope) == null) {
+    JSXOpeningElement(node) {
+      const name5 = match(node.name).with({ type: AST_NODE_TYPES.JSXIdentifier }, (n) => n.name).with({ type: AST_NODE_TYPES.JSXMemberExpression, object: { type: AST_NODE_TYPES.JSXIdentifier } }, (n) => n.object.name).otherwise(() => _);
+      if (name5 == null) return;
+      if (name5 === "this") return;
+      if (/^[a-z]/u.test(name5)) return;
+      if (VAR2.findVariable(name5, context.sourceCode.getScope(node)) == null) {
         context.report({
           messageId: "jsxNoUndef",
           node,
-          data: { name: node.name }
+          data: {
+            name: name5
+          }
         });
       }
     }
@@ -270,7 +265,7 @@ var jsx_uses_vars_default = createRule({
   meta: {
     type: "problem",
     docs: {
-      description: "Marks variables used in JSX as used.",
+      description: "Marks variables used in JSX elements as used.",
       [Symbol.for("rule_features")]: RULE_FEATURES5
     },
     messages: {
@@ -419,20 +414,6 @@ function create6(context) {
 var RULE_NAME7 = "no-array-index-key";
 var RULE_FEATURES7 = [];
 var reactChildrenMethod = ["forEach", "map"];
-var iteratorFunctionIndexParamPosition = /* @__PURE__ */ new Map([
-  ["every", 1],
-  ["filter", 1],
-  ["find", 1],
-  ["findIndex", 1],
-  ["findLast", 1],
-  ["findLastIndex", 1],
-  ["flatMap", 1],
-  ["forEach", 1],
-  ["map", 1],
-  ["reduce", 2],
-  ["reduceRight", 2],
-  ["some", 1]
-]);
 function isReactChildrenMethod(name5) {
   return reactChildrenMethod.some((method) => method === name5);
 }
@@ -463,7 +444,7 @@ function getMapIndexParamName(context, node) {
     return _;
   }
   const { name: name5 } = callee.property;
-  if (!iteratorFunctionIndexParamPosition.has(name5)) {
+  if (!AST11.ITERATOR_FUNCTION_INDEX_PARAM_POSITION.has(name5)) {
     return _;
   }
   const callbackArg = node.arguments[isUsingReactChildren(context, node) ? 1 : 0];
@@ -474,7 +455,7 @@ function getMapIndexParamName(context, node) {
     return _;
   }
   const { params } = callbackArg;
-  const indexParamPosition = iteratorFunctionIndexParamPosition.get(name5);
+  const indexParamPosition = AST11.ITERATOR_FUNCTION_INDEX_PARAM_POSITION.get(name5);
   if (indexParamPosition == null) {
     return _;
   }
@@ -1332,7 +1313,7 @@ function create25(context) {
           break;
         }
         default: {
-          const call = AST11.findParentNode(jsxElement, AST11.isMapCallLoose);
+          const call = AST11.findParentNode(jsxElement, AST11.isArrayMapCallLoose);
           const iter = AST11.findParentNode(jsxElement, (n) => n === call || AST11.isFunction(n));
           if (!AST11.isFunction(iter)) return;
           const arg0 = call?.arguments[0];
@@ -1869,7 +1850,7 @@ function create31(context) {
       if (state.isWithinChildrenToArray) {
         return;
       }
-      const isMapCall = AST11.isMapCallLoose(node);
+      const isMapCall = AST11.isArrayMapCallLoose(node);
       if (!isMapCall && !isArrayFromCall(node)) {
         return;
       }
@@ -1924,7 +1905,7 @@ var no_nested_component_definitions_default = createRule({
   defaultOptions: []
 });
 function create32(context) {
-  const hint = ERComponentHint.SkipMapCallback | ERComponentHint.SkipNullLiteral | ERComponentHint.SkipUndefined | ERComponentHint.SkipBooleanLiteral | ERComponentHint.SkipStringLiteral | ERComponentHint.SkipNumberLiteral | ERComponentHint.StrictLogical | ERComponentHint.StrictConditional;
+  const hint = ERComponentHint.SkipArrayMapArgument | ERComponentHint.SkipNullLiteral | ERComponentHint.SkipUndefined | ERComponentHint.SkipBooleanLiteral | ERComponentHint.SkipStringLiteral | ERComponentHint.SkipNumberLiteral | ERComponentHint.StrictLogical | ERComponentHint.StrictConditional;
   const collector = useComponentCollector(context, { hint });
   const collectorLegacy = useComponentCollectorLegacy();
   return {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-x",
-  "version": "1.38.0-next.8",
+  "version": "1.38.0",
   "description": "A set of composable linting rules for libraries and frameworks that use React as a UI runtime.",
   "keywords": [
     "react",
@@ -42,21 +42,21 @@
     "./package.json"
   ],
   "dependencies": {
-    "@typescript-eslint/scope-manager": "^8.27.0",
-    "@typescript-eslint/type-utils": "^8.27.0",
-    "@typescript-eslint/types": "^8.27.0",
-    "@typescript-eslint/utils": "^8.27.0",
+    "@typescript-eslint/scope-manager": "^8.28.0",
+    "@typescript-eslint/type-utils": "^8.28.0",
+    "@typescript-eslint/types": "^8.28.0",
+    "@typescript-eslint/utils": "^8.28.0",
     "compare-versions": "^6.1.1",
     "is-immutable-type": "^5.0.1",
     "string-ts": "^2.2.1",
     "ts-pattern": "^5.6.2",
-    "@eslint-react/ast": "1.38.0-next.8",
-    "@eslint-react/eff": "1.38.0-next.8",
-    "@eslint-react/jsx": "1.38.0-next.8",
-    "@eslint-react/kit": "1.38.0-next.8",
-    "@eslint-react/core": "1.38.0-next.8",
-    "@eslint-react/shared": "1.38.0-next.8",
-    "@eslint-react/var": "1.38.0-next.8"
+    "@eslint-react/ast": "1.38.0",
+    "@eslint-react/eff": "1.38.0",
+    "@eslint-react/core": "1.38.0",
+    "@eslint-react/jsx": "1.38.0",
+    "@eslint-react/kit": "1.38.0",
+    "@eslint-react/var": "1.38.0",
+    "@eslint-react/shared": "1.38.0"
   },
   "devDependencies": {
     "@types/react": "^19.0.12",