eslint-plugin-react-x 1.37.1 → 1.37.2-beta.1

package/dist/index.mjs

@@ -11,6 +11,7 @@ import { getConstrainedTypeAtLocation, isTypeReadonly } from '@typescript-eslint
 import { ESLintUtils } from '@typescript-eslint/utils';
 import { unionConstituents, isTypeFlagSet, isTrueLiteralType, isFalseLiteralType } from 'ts-api-utils';
 import ts from 'typescript';
+import { getTypeImmutability, isUnknown, isImmutable, isReadonlyShallow, isReadonlyDeep } from 'is-immutable-type';
 
 var __defProp = Object.defineProperty;
 var __export = (target, all) => {
@@ -108,7 +109,7 @@ var settings3 = {
 
 // package.json
 var name4 = "eslint-plugin-react-x";
-var version = "1.37.1";
+var version = "1.37.2-beta.1";
 var createRule = createRuleForPlugin("x");
 
 // src/rules/avoid-shorthand-boolean.ts
@@ -558,20 +559,21 @@ var no_children_map_default = createRule({
     schema: []
   },
   name: RULE_NAME7,
-  create(context) {
-    return {
-      MemberExpression(node) {
-        if (isChildrenMap(context, node)) {
-          context.report({
-            messageId: "noChildrenMap",
-            node: node.property
-          });
-        }
-      }
-    };
-  },
+  create: create7,
   defaultOptions: []
 });
+function create7(context) {
+  return {
+    MemberExpression(node) {
+      if (isChildrenMap(context, node)) {
+        context.report({
+          messageId: "noChildrenMap",
+          node: node.property
+        });
+      }
+    }
+  };
+}
 var RULE_NAME8 = "no-children-only";
 var RULE_FEATURES8 = [];
 var no_children_only_default = createRule({
@@ -587,10 +589,10 @@ var no_children_only_default = createRule({
     schema: []
   },
   name: RULE_NAME8,
-  create: create7,
+  create: create8,
   defaultOptions: []
 });
-function create7(context) {
+function create8(context) {
   return {
     MemberExpression(node) {
       if (isChildrenOnly(context, node)) {
@@ -617,10 +619,10 @@ var no_children_prop_default = createRule({
     schema: []
   },
   name: RULE_NAME9,
-  create: create8,
+  create: create9,
   defaultOptions: []
 });
-function create8(context) {
+function create9(context) {
   return {
     JSXElement(node) {
       const attribute = JSX8.getAttribute(
@@ -652,10 +654,10 @@ var no_children_to_array_default = createRule({
     schema: []
   },
   name: RULE_NAME10,
-  create: create9,
+  create: create10,
   defaultOptions: []
 });
-function create9(context) {
+function create10(context) {
   return {
     MemberExpression(node) {
       if (isChildrenToArray(context, node)) {
@@ -682,10 +684,10 @@ var no_class_component_default = createRule({
     schema: []
   },
   name: RULE_NAME11,
-  create: create10,
+  create: create11,
   defaultOptions: []
 });
-function create10(context) {
+function create11(context) {
   if (!context.sourceCode.text.includes("Component")) return {};
   const { ctx, listeners } = useComponentCollectorLegacy();
   return {
@@ -722,10 +724,10 @@ var no_clone_element_default = createRule({
     schema: []
   },
   name: RULE_NAME12,
-  create: create11,
+  create: create12,
   defaultOptions: []
 });
-function create11(context) {
+function create12(context) {
   return {
     CallExpression(node) {
       if (!isCloneElementCall(context, node)) {
@@ -753,36 +755,37 @@ var no_comment_textnodes_default = createRule({
     schema: []
   },
   name: RULE_NAME13,
-  create(context) {
-    function hasCommentLike(node) {
-      if (AST11.isOneOf([AST_NODE_TYPES.JSXAttribute, AST_NODE_TYPES.JSXExpressionContainer])(node.parent)) {
-        return false;
-      }
-      const rawValue = context.sourceCode.getText(node);
-      return /^\s*\/(?:\/|\*)/mu.test(rawValue);
-    }
-    const visitorFunction = (node) => {
-      if (!AST11.isOneOf([AST_NODE_TYPES.JSXElement, AST_NODE_TYPES.JSXFragment])(node.parent)) {
-        return;
-      }
-      if (!hasCommentLike(node)) {
-        return;
-      }
-      if (!node.parent.type.includes("JSX")) {
-        return;
-      }
-      context.report({
-        messageId: "noCommentTextnodes",
-        node
-      });
-    };
-    return {
-      JSXText: visitorFunction,
-      Literal: visitorFunction
-    };
-  },
+  create: create13,
   defaultOptions: []
 });
+function create13(context) {
+  function hasCommentLike(node) {
+    if (AST11.isOneOf([AST_NODE_TYPES.JSXAttribute, AST_NODE_TYPES.JSXExpressionContainer])(node.parent)) {
+      return false;
+    }
+    const rawValue = context.sourceCode.getText(node);
+    return /^\s*\/(?:\/|\*)/mu.test(rawValue);
+  }
+  const visitorFunction = (node) => {
+    if (!AST11.isOneOf([AST_NODE_TYPES.JSXElement, AST_NODE_TYPES.JSXFragment])(node.parent)) {
+      return;
+    }
+    if (!hasCommentLike(node)) {
+      return;
+    }
+    if (!node.parent.type.includes("JSX")) {
+      return;
+    }
+    context.report({
+      messageId: "noCommentTextnodes",
+      node
+    });
+  };
+  return {
+    JSXText: visitorFunction,
+    Literal: visitorFunction
+  };
+}
 var RULE_NAME14 = "no-complex-conditional-rendering";
 var RULE_FEATURES14 = [];
 var no_complex_conditional_rendering_default = createRule({
@@ -798,10 +801,10 @@ var no_complex_conditional_rendering_default = createRule({
     schema: []
   },
   name: RULE_NAME14,
-  create: create12,
+  create: create14,
   defaultOptions: []
 });
-function create12(context) {
+function create14(context) {
   const visitorFunction = (node) => {
     const jsxExpContainer = node.parent?.parent;
     if (!AST11.is(AST_NODE_TYPES.JSXExpressionContainer)(jsxExpContainer)) {
@@ -847,10 +850,10 @@ var no_component_will_mount_default = createRule({
     schema: []
   },
   name: RULE_NAME15,
-  create: create13,
+  create: create15,
   defaultOptions: []
 });
-function create13(context) {
+function create15(context) {
   if (!context.sourceCode.text.includes("componentWillMount")) return {};
   const { ctx, listeners } = useComponentCollectorLegacy();
   return {
@@ -898,10 +901,10 @@ var no_component_will_receive_props_default = createRule({
     schema: []
   },
   name: RULE_NAME16,
-  create: create14,
+  create: create16,
   defaultOptions: []
 });
-function create14(context) {
+function create16(context) {
   if (!context.sourceCode.text.includes("componentWillReceiveProps")) return {};
   const { ctx, listeners } = useComponentCollectorLegacy();
   return {
@@ -949,10 +952,10 @@ var no_component_will_update_default = createRule({
     schema: []
   },
   name: RULE_NAME17,
-  create: create15,
+  create: create17,
   defaultOptions: []
 });
-function create15(context) {
+function create17(context) {
   if (!context.sourceCode.text.includes("componentWillUpdate")) return {};
   const { ctx, listeners } = useComponentCollectorLegacy();
   return {
@@ -997,10 +1000,10 @@ var no_context_provider_default = createRule({
     schema: []
   },
   name: RULE_NAME18,
-  create: create16,
+  create: create18,
   defaultOptions: []
 });
-function create16(context) {
+function create18(context) {
   if (!context.sourceCode.text.includes("Provider")) return {};
   const { version: version2 } = getSettingsFromContext(context);
   if (compare(version2, "19.0.0", "<")) return {};
@@ -1047,10 +1050,10 @@ var no_create_ref_default = createRule({
     schema: []
   },
   name: RULE_NAME19,
-  create: create17,
+  create: create19,
   defaultOptions: []
 });
-function create17(context) {
+function create19(context) {
   return {
     CallExpression(node) {
       if (isCreateRefCall(context, node) && AST11.findParentNode(node, isClassComponent) == null) {
@@ -1074,10 +1077,10 @@ var no_default_props_default = createRule({
     schema: []
   },
   name: RULE_NAME20,
-  create: create18,
+  create: create20,
   defaultOptions: []
 });
-function create18(context) {
+function create20(context) {
   if (!context.sourceCode.text.includes("defaultProps")) return {};
   return {
     AssignmentExpression(node) {
@@ -1129,10 +1132,10 @@ var no_direct_mutation_state_default = createRule({
     schema: []
   },
   name: RULE_NAME21,
-  create: create19,
+  create: create21,
   defaultOptions: []
 });
-function create19(context) {
+function create21(context) {
   return {
     AssignmentExpression(node) {
       if (!isAssignmentToThisState(node)) return;
@@ -1168,10 +1171,10 @@ var no_duplicate_jsx_props_default = createRule({
     schema: []
   },
   name: RULE_NAME22,
-  create: create20,
+  create: create22,
   defaultOptions: []
 });
-function create20(context) {
+function create22(context) {
   return {
     JSXOpeningElement(node) {
       const props = [];
@@ -1210,10 +1213,10 @@ var no_duplicate_key_default = createRule({
     schema: []
   },
   name: RULE_NAME23,
-  create: create21,
+  create: create23,
   defaultOptions: []
 });
-function create21(context) {
+function create23(context) {
   if (!context.sourceCode.getText().includes("key=")) {
     return {};
   }
@@ -1295,10 +1298,10 @@ var no_forward_ref_default = createRule({
     schema: []
   },
   name: RULE_NAME24,
-  create: create22,
+  create: create24,
   defaultOptions: []
 });
-function create22(context) {
+function create24(context) {
   if (!context.sourceCode.text.includes("forwardRef")) {
     return {};
   }
@@ -1401,10 +1404,10 @@ var no_implicit_key_default = createRule({
     schema: []
   },
   name: RULE_NAME25,
-  create: create23,
+  create: create25,
   defaultOptions: []
 });
-function create23(context) {
+function create25(context) {
   return {
     JSXOpeningElement(node) {
       const initialScope = context.sourceCode.getScope(node);
@@ -1513,10 +1516,10 @@ var no_leaked_conditional_rendering_default = createRule({
     schema: []
   },
   name: RULE_NAME26,
-  create: create24,
+  create: create26,
   defaultOptions: []
 });
-function create24(context) {
+function create26(context) {
   if (!context.sourceCode.text.includes("&&") && !context.sourceCode.text.includes("?")) return {};
   const { version: version2 } = getSettingsFromContext(context);
   const allowedVariants = [
@@ -1588,10 +1591,10 @@ var no_missing_component_display_name_default = createRule({
     schema: []
   },
   name: RULE_NAME27,
-  create: create25,
+  create: create27,
   defaultOptions: []
 });
-function create25(context) {
+function create27(context) {
   if (!context.sourceCode.text.includes("memo") && !context.sourceCode.text.includes("forwardRef")) return {};
   const {
     ctx,
@@ -1641,10 +1644,10 @@ var no_missing_context_display_name_default = createRule({
     schema: []
   },
   name: RULE_NAME28,
-  create: create26,
+  create: create28,
   defaultOptions: []
 });
-function create26(context) {
+function create28(context) {
   if (!context.sourceCode.text.includes("createContext")) return {};
   const createCalls = [];
   const displayNameAssignments = [];
@@ -1698,10 +1701,10 @@ var no_missing_key_default = createRule({
     schema: []
   },
   name: RULE_NAME29,
-  create: create27,
+  create: create29,
   defaultOptions: []
 });
-function create27(context) {
+function create29(context) {
   const report = createReport(context);
   const state = { isWithinChildrenToArray: false };
   function checkIteratorElement(node) {
@@ -1830,10 +1833,10 @@ var no_nested_component_definitions_default = createRule({
     schema: []
   },
   name: RULE_NAME30,
-  create: create28,
+  create: create30,
   defaultOptions: []
 });
-function create28(context) {
+function create30(context) {
   const hint = ERComponentHint.SkipMapCallback | ERComponentHint.SkipNullLiteral | ERComponentHint.SkipUndefined | ERComponentHint.SkipBooleanLiteral | ERComponentHint.SkipStringLiteral | ERComponentHint.SkipNumberLiteral | ERComponentHint.StrictLogical | ERComponentHint.StrictConditional;
   const collector = useComponentCollector(context, { hint });
   const collectorLegacy = useComponentCollectorLegacy();
@@ -1939,10 +1942,10 @@ var no_prop_types_default = createRule({
     schema: []
   },
   name: RULE_NAME31,
-  create: create29,
+  create: create31,
   defaultOptions: []
 });
-function create29(context) {
+function create31(context) {
   if (!context.sourceCode.text.includes("propTypes")) {
     return {};
   }
@@ -1996,10 +1999,10 @@ var no_redundant_should_component_update_default = createRule({
     schema: []
   },
   name: RULE_NAME32,
-  create: create30,
+  create: create32,
   defaultOptions: []
 });
-function create30(context) {
+function create32(context) {
   if (!context.sourceCode.text.includes("shouldComponentUpdate")) return {};
   const { ctx, listeners } = useComponentCollectorLegacy();
   return {
@@ -2044,10 +2047,10 @@ var no_set_state_in_component_did_mount_default = createRule({
     schema: []
   },
   name: RULE_NAME33,
-  create: create31,
+  create: create33,
   defaultOptions: []
 });
-function create31(context) {
+function create33(context) {
   if (!context.sourceCode.text.includes("componentDidMount")) return {};
   return {
     CallExpression(node) {
@@ -2086,10 +2089,10 @@ var no_set_state_in_component_did_update_default = createRule({
     schema: []
   },
   name: RULE_NAME34,
-  create: create32,
+  create: create34,
   defaultOptions: []
 });
-function create32(context) {
+function create34(context) {
   if (!context.sourceCode.text.includes("componentDidUpdate")) return {};
   return {
     CallExpression(node) {
@@ -2128,10 +2131,10 @@ var no_set_state_in_component_will_update_default = createRule({
     schema: []
   },
   name: RULE_NAME35,
-  create: create33,
+  create: create35,
   defaultOptions: []
 });
-function create33(context) {
+function create35(context) {
   if (!context.sourceCode.text.includes("componentWillUpdate")) return {};
   return {
     CallExpression(node) {
@@ -2179,10 +2182,10 @@ var no_string_refs_default = createRule({
     schema: []
   },
   name: RULE_NAME36,
-  create: create34,
+  create: create36,
   defaultOptions: []
 });
-function create34(context) {
+function create36(context) {
   return {
     JSXAttribute(node) {
       if (node.name.name !== "ref") {
@@ -2215,10 +2218,10 @@ var no_unsafe_component_will_mount_default = createRule({
     schema: []
   },
   name: RULE_NAME37,
-  create: create35,
+  create: create37,
   defaultOptions: []
 });
-function create35(context) {
+function create37(context) {
   if (!context.sourceCode.text.includes("UNSAFE_componentWillMount")) return {};
   const { ctx, listeners } = useComponentCollectorLegacy();
   return {
@@ -2257,10 +2260,10 @@ var no_unsafe_component_will_receive_props_default = createRule({
     schema: []
   },
   name: RULE_NAME38,
-  create: create36,
+  create: create38,
   defaultOptions: []
 });
-function create36(context) {
+function create38(context) {
   if (!context.sourceCode.text.includes("UNSAFE_componentWillReceiveProps")) {
     return {};
   }
@@ -2301,10 +2304,10 @@ var no_unsafe_component_will_update_default = createRule({
     schema: []
   },
   name: RULE_NAME39,
-  create: create37,
+  create: create39,
   defaultOptions: []
 });
-function create37(context) {
+function create39(context) {
   if (!context.sourceCode.text.includes("UNSAFE_componentWillUpdate")) return {};
   const { ctx, listeners } = useComponentCollectorLegacy();
   return {
@@ -2340,10 +2343,10 @@ var no_unstable_context_value_default = createRule({
     schema: []
   },
   name: RULE_NAME40,
-  create: create38,
+  create: create40,
   defaultOptions: []
 });
-function create38(context) {
+function create40(context) {
   const { version: version2 } = getSettingsFromContext(context);
   const isReact18OrBelow = compare(version2, "19.0.0", "<");
   const { ctx, listeners } = useComponentCollector(context);
@@ -2413,10 +2416,10 @@ var no_unstable_default_props_default = createRule({
     schema: []
   },
   name: RULE_NAME41,
-  create: create39,
+  create: create41,
   defaultOptions: []
 });
-function create39(context) {
+function create41(context) {
   const { ctx, listeners } = useComponentCollector(context);
   const declarators = /* @__PURE__ */ new Map();
   return {
@@ -2507,10 +2510,10 @@ var no_unused_class_component_members_default = createRule({
     schema: []
   },
   name: RULE_NAME42,
-  create: create40,
+  create: create42,
   defaultOptions: []
 });
-function create40(context) {
+function create42(context) {
   const classEntries = [];
   const methodEntries = [];
   const propertyDefs = /* @__PURE__ */ new WeakMap();
@@ -2638,10 +2641,10 @@ var no_unused_state_default = createRule({
     schema: []
   },
   name: RULE_NAME43,
-  create: create41,
+  create: create43,
   defaultOptions: []
 });
-function create41(context) {
+function create43(context) {
   const classEntries = [];
   const methodEntries = [];
   const constructorEntries = [];
@@ -2793,10 +2796,10 @@ var no_use_context_default = createRule({
     schema: []
   },
   name: RULE_NAME44,
-  create: create42,
+  create: create44,
   defaultOptions: []
 });
-function create42(context) {
+function create44(context) {
   if (!context.sourceCode.text.includes("useContext")) return {};
   const settings4 = getSettingsFromContext(context);
   const useContextAlias = /* @__PURE__ */ new Set();
@@ -2889,10 +2892,10 @@ var no_useless_forward_ref_default = createRule({
     schema: []
   },
   name: RULE_NAME45,
-  create: create43,
+  create: create45,
   defaultOptions: []
 });
-function create43(context) {
+function create45(context) {
   return {
     CallExpression(node) {
       if (!isForwardRefCall(context, node)) {
@@ -2940,10 +2943,10 @@ var no_useless_fragment_default = createRule({
     }]
   },
   name: RULE_NAME46,
-  create: create44,
+  create: create46,
   defaultOptions
 });
-function create44(context, [option]) {
+function create46(context, [option]) {
   const { allowExpressions = true } = option;
   return {
     JSXElement(node) {
@@ -3073,10 +3076,10 @@ var prefer_destructuring_assignment_default = createRule({
     schema: []
   },
   name: RULE_NAME47,
-  create: create45,
+  create: create47,
   defaultOptions: []
 });
-function create45(context) {
+function create47(context) {
   const { ctx, listeners } = useComponentCollector(context);
   const memberExpressionWithNames = [];
   return {
@@ -3154,10 +3157,10 @@ var prefer_react_namespace_import_default = createRule({
     schema: []
   },
   name: RULE_NAME48,
-  create: create46,
+  create: create48,
   defaultOptions: []
 });
-function create46(context) {
+function create48(context) {
   const { importSource } = getSettingsFromContext(context);
   return {
     [`ImportDeclaration[source.value="${importSource}"] ImportDefaultSpecifier`](node) {
@@ -3207,10 +3210,10 @@ var prefer_read_only_props_default = createRule({
     schema: []
   },
   name: RULE_NAME49,
-  create: create47,
+  create: create49,
   defaultOptions: []
 });
-function create47(context) {
+function create49(context) {
   const services = ESLintUtils.getParserServices(context, false);
   const { ctx, listeners } = useComponentCollector(context);
   return {
@@ -3223,7 +3226,7 @@ function create47(context) {
           continue;
         }
         const propsType = getConstrainedTypeAtLocation(services, props);
-        if (isTypeReadonly(services.program, propsType)) {
+        if (isTypeReadonlyLoose(services, propsType)) {
           continue;
         }
         context.report({ messageId: "preferReadOnlyProps", node: props });
@@ -3231,6 +3234,15 @@ function create47(context) {
     }
   };
 }
+function isTypeReadonlyLoose(services, type) {
+  if (isTypeReadonly(services.program, type)) return true;
+  try {
+    const im = getTypeImmutability(services.program, type);
+    return isUnknown(im) || isImmutable(im) || isReadonlyShallow(im) || isReadonlyDeep(im);
+  } catch {
+    return true;
+  }
+}
 var RULE_NAME50 = "prefer-shorthand-boolean";
 var RULE_FEATURES49 = [
   "FIX"
@@ -3249,10 +3261,10 @@ var prefer_shorthand_boolean_default = createRule({
     schema: []
   },
   name: RULE_NAME50,
-  create: create48,
+  create: create50,
   defaultOptions: []
 });
-function create48(context) {
+function create50(context) {
   return {
     JSXAttribute(node) {
       const { value } = node;
@@ -3290,10 +3302,10 @@ var prefer_shorthand_fragment_default = createRule({
     schema: []
   },
   name: RULE_NAME51,
-  create: create49,
+  create: create51,
   defaultOptions: []
 });
-function create49(context) {
+function create51(context) {
   return {
     JSXElement(node) {
       if (!JSX8.isFragmentElement(node)) return;
@@ -3333,10 +3345,10 @@ var use_jsx_vars_default = createRule({
     schema: []
   },
   name: RULE_NAME52,
-  create: create50,
+  create: create52,
   defaultOptions: []
 });
-function create50(context) {
+function create52(context) {
   return {
     JSXOpeningElement(node) {
       switch (node.name.type) {