eslint-plugin-react-x 1.23.3-next.4 → 1.23.3-next.6

package/dist/index.js

@@ -42,7 +42,7 @@ var ts__default = /*#__PURE__*/_interopDefault(ts);
 
 // package.json
 var name = "eslint-plugin-react-x";
-var version = "1.23.3-next.4";
+var version = "1.23.3-next.6";
 var createRule = shared.createRuleForPlugin("x");
 
 // src/rules/avoid-shorthand-boolean.ts
@@ -66,7 +66,7 @@ var avoid_shorthand_boolean_default = createRule({
   name: RULE_NAME,
   create(context) {
     function getReportDescriptor(node) {
-      return node.value ? eff.O.none() : eff.O.some({
+      return node.value != null ? eff.O.none() : eff.O.some({
         messageId: "avoidShorthandBoolean",
         node,
         data: {
@@ -136,11 +136,11 @@ var ensure_forward_ref_using_ref_default = createRule({
           return;
         }
         const [component] = node.arguments;
-        if (!component || !AST11__namespace.isFunction(component)) {
+        if (component == null || !AST11__namespace.isFunction(component)) {
           return;
         }
         const [_, ref] = component.params;
-        if (ref) {
+        if (ref != null) {
           return;
         }
         context.report({
@@ -221,15 +221,15 @@ var no_access_state_in_setstate_default = createRule({
           return;
         }
         const [currClass, isComponent] = classStack.at(-1) ?? [];
-        if (!currClass || !isComponent) {
+        if (currClass == null || !isComponent) {
           return;
         }
         const [currMethod, isStatic] = methodStack.at(-1) ?? [];
-        if (!currMethod || isStatic) {
+        if (currMethod == null || isStatic) {
           return;
         }
         const [setState, hasThisState] = setStateStack.at(-1) ?? [];
-        if (!setState || hasThisState) {
+        if (setState == null || hasThisState) {
           return;
         }
         if (!eff.O.exists(getName(node.property), (name2) => name2 === "state")) {
@@ -251,18 +251,18 @@ var no_access_state_in_setstate_default = createRule({
       },
       VariableDeclarator(node) {
         const [currClass, isComponent] = classStack.at(-1) ?? [];
-        if (!currClass || !isComponent) {
+        if (currClass == null || !isComponent) {
           return;
         }
         const [currMethod, isStatic] = methodStack.at(-1) ?? [];
-        if (!currMethod || isStatic) {
+        if (currMethod == null || isStatic) {
           return;
         }
         const [setState, hasThisState] = setStateStack.at(-1) ?? [];
-        if (!setState || hasThisState) {
+        if (setState == null || hasThisState) {
           return;
         }
-        if (!(node.init && AST11__namespace.isThisExpression(node.init) && node.id.type === types.AST_NODE_TYPES.ObjectPattern)) {
+        if (!(node.init != null && AST11__namespace.isThisExpression(node.init) && node.id.type === types.AST_NODE_TYPES.ObjectPattern)) {
           return;
         }
         const hasState = node.id.properties.some((prop) => {
@@ -299,16 +299,6 @@ var iteratorFunctionIndexParamPosition = /* @__PURE__ */ new Map([
   ["reduceRight", 2],
   ["some", 1]
 ]);
-var isToStringCall = tsPattern.isMatching({
-  type: types.AST_NODE_TYPES.CallExpression,
-  callee: {
-    type: types.AST_NODE_TYPES.MemberExpression,
-    property: {
-      type: types.AST_NODE_TYPES.Identifier,
-      name: "toString"
-    }
-  }
-});
 function isReactChildrenMethod(name2) {
   return reactChildrenMethod.some((method) => method === name2);
 }
@@ -343,7 +333,7 @@ function getMapIndexParamName(node, context) {
     return eff.O.none();
   }
   const callbackArg = node.arguments[isUsingReactChildren(node, context) ? 1 : 0];
-  if (!callbackArg) {
+  if (callbackArg == null) {
     return eff.O.none();
   }
   if (!AST11__namespace.isOneOf([types.AST_NODE_TYPES.ArrowFunctionExpression, types.AST_NODE_TYPES.FunctionExpression])(callbackArg)) {
@@ -358,7 +348,7 @@ function getMapIndexParamName(node, context) {
     return eff.O.none();
   }
   const param = params.at(indexParamPosition);
-  return param && "name" in param ? eff.O.some(param.name) : eff.O.none();
+  return param != null && "name" in param ? eff.O.some(param.name) : eff.O.none();
 }
 var no_array_index_key_default = createRule({
   meta: {
@@ -375,40 +365,57 @@ var no_array_index_key_default = createRule({
   name: RULE_NAME5,
   create(context) {
     const indexParamNames = [];
-    const isCreateOrCloneElementCall = eff.or(core.isCreateElementCall(context), core.isCloneElementCall(context));
     function isArrayIndex(node) {
       return node.type === types.AST_NODE_TYPES.Identifier && indexParamNames.some(eff.O.exists((name2) => name2 === node.name));
     }
-    function getReportDescriptor(node) {
-      if (isArrayIndex(node)) {
-        return [{ messageId: "noArrayIndexKey", node }];
-      }
-      if (AST11__namespace.isOneOf([types.AST_NODE_TYPES.TemplateLiteral, types.AST_NODE_TYPES.BinaryExpression])(node)) {
-        const exps = types.AST_NODE_TYPES.TemplateLiteral === node.type ? node.expressions : AST11__namespace.getIdentifiersFromBinaryExpression(node);
-        return exps.reduce((acc, exp) => {
-          if (isArrayIndex(exp)) {
-            return [...acc, { messageId: "noArrayIndexKey", node: exp }];
+    function isCreateOrCloneElementCall(node) {
+      return core.isCreateElementCall(node, context) || core.isCloneElementCall(node, context);
+    }
+    function getReportDescriptors(node) {
+      switch (node.type) {
+        // key={bar}
+        case types.AST_NODE_TYPES.Identifier: {
+          if (indexParamNames.some(eff.O.exists((name2) => name2 === node.name))) {
+            return [{
+              messageId: "noArrayIndexKey",
+              node
+            }];
           }
-          return acc;
-        }, []);
-      }
-      if (isToStringCall(node)) {
-        if (!("object" in node.callee && isArrayIndex(node.callee.object))) {
           return [];
         }
-        return [{ messageId: "noArrayIndexKey", node: node.callee.object }];
-      }
-      const isStringCall = tsPattern.isMatching({
-        type: types.AST_NODE_TYPES.CallExpression,
-        callee: {
-          type: types.AST_NODE_TYPES.Identifier,
-          name: "String"
-        }
-      }, node);
-      if (isStringCall) {
-        const [arg] = node.arguments;
-        if (arg && isArrayIndex(arg)) {
-          return [{ messageId: "noArrayIndexKey", node: arg }];
+        // key={`foo-${bar}`} or key={'foo' + bar}
+        case types.AST_NODE_TYPES.TemplateLiteral:
+        case types.AST_NODE_TYPES.BinaryExpression: {
+          const descriptors = [];
+          const expressions = node.type === types.AST_NODE_TYPES.TemplateLiteral ? node.expressions : AST11__namespace.getIdentifiersFromBinaryExpression(node);
+          for (const expression of expressions) {
+            if (isArrayIndex(expression)) {
+              descriptors.push({
+                messageId: "noArrayIndexKey",
+                node: expression
+              });
+            }
+          }
+          return descriptors;
+        }
+        // key={bar.toString()} or key={String(bar)}
+        case types.AST_NODE_TYPES.CallExpression: {
+          switch (true) {
+            // key={bar.toString()}
+            case (node.callee.type === types.AST_NODE_TYPES.MemberExpression && node.callee.property.type === types.AST_NODE_TYPES.Identifier && node.callee.property.name === "toString" && isArrayIndex(node.callee.object)): {
+              return [{
+                messageId: "noArrayIndexKey",
+                node: node.callee.object
+              }];
+            }
+            // key={String(bar)}
+            case (node.callee.type === types.AST_NODE_TYPES.Identifier && node.callee.name === "String" && node.arguments[0] != null && isArrayIndex(node.arguments[0])): {
+              return [{
+                messageId: "noArrayIndexKey",
+                node: node.arguments[0]
+              }];
+            }
+          }
         }
       }
       return [];
@@ -433,7 +440,7 @@ var no_array_index_key_default = createRule({
           if (!("value" in prop)) {
             continue;
           }
-          const descriptors = getReportDescriptor(prop.value);
+          const descriptors = getReportDescriptors(prop.value);
           for (const descriptor of descriptors) {
             context.report(descriptor);
           }
@@ -449,11 +456,10 @@ var no_array_index_key_default = createRule({
         if (indexParamNames.length === 0) {
           return;
         }
-        const { value } = node;
-        if (value?.type !== types.AST_NODE_TYPES.JSXExpressionContainer) {
+        if (node.value?.type !== types.AST_NODE_TYPES.JSXExpressionContainer) {
           return;
         }
-        const descriptors = getReportDescriptor(value.expression);
+        const descriptors = getReportDescriptors(node.value.expression);
         for (const descriptor of descriptors) {
           context.report(descriptor);
         }
@@ -1017,7 +1023,7 @@ var no_context_provider_default = createRule({
             const providerName = elementName.replace(/\.Provider$/, "");
             const openingElement = node.openingElement;
             const closingElement = node.closingElement;
-            if (!closingElement) {
+            if (closingElement == null) {
               return fixer.replaceText(openingElement.name, providerName);
             }
             return [
@@ -1259,7 +1265,7 @@ var no_duplicate_key_default = createRule({
     function isKeyValueEqual(a, b) {
       const aValue = a.value;
       const bValue = b.value;
-      if (aValue === null || bValue === null) {
+      if (aValue == null || bValue == null) {
         return false;
       }
       return AST11__namespace.isNodeEqual(aValue, bValue);
@@ -1367,7 +1373,7 @@ var no_forward_ref_default = createRule({
 function getFix(node, context) {
   return (fixer) => {
     const [componentNode] = node.arguments;
-    if (!componentNode || !AST11__namespace.isFunction(componentNode)) {
+    if (componentNode == null || !AST11__namespace.isFunction(componentNode)) {
       return [];
     }
     return [
@@ -1388,7 +1394,7 @@ function getComponentPropsFixes(node, typeArguments, fixer, context) {
   const getText = (node2) => context.sourceCode.getText(node2);
   const [arg0, arg1] = node.params;
   const [typeArg0, typeArg1] = typeArguments;
-  if (!arg0) {
+  if (arg0 == null) {
     return [];
   }
   const fixedArg0Text = tsPattern.match(arg0).with({ type: types.AST_NODE_TYPES.Identifier }, (n) => eff.O.some(`...${n.name}`)).with({ type: types.AST_NODE_TYPES.ObjectPattern }, (n) => eff.O.some(n.properties.map(getText).join(", "))).otherwise(eff.O.none);
@@ -1398,7 +1404,7 @@ function getComponentPropsFixes(node, typeArguments, fixer, context) {
   }
   const fixedPropsText = fixedArg0Text.value;
   const fixedRefText = fixedArg1Text.value;
-  if (!typeArg0 || !typeArg1) {
+  if (typeArg0 == null || typeArg1 == null) {
     return [
       fixer.replaceText(
         arg0,
@@ -1409,7 +1415,7 @@ function getComponentPropsFixes(node, typeArguments, fixer, context) {
           "}"
         ].join(" ")
       ),
-      ...arg1 ? [fixer.remove(arg1), fixer.removeRange([arg0.range[1], arg1.range[0]])] : []
+      ...arg1 == null ? [] : [fixer.remove(arg1), fixer.removeRange([arg0.range[1], arg1.range[0]])]
     ];
   }
   return [
@@ -1428,7 +1434,7 @@ function getComponentPropsFixes(node, typeArguments, fixer, context) {
         "}"
       ].join(" ")
     ),
-    ...arg1 ? [fixer.remove(arg1), fixer.removeRange([arg0.range[1], arg1.range[0]])] : []
+    ...arg1 == null ? [] : [fixer.remove(arg1), fixer.removeRange([arg0.range[1], arg1.range[0]])]
   ];
 }
 var RULE_NAME26 = "no-implicit-key";
@@ -1504,7 +1510,7 @@ function inspectVariantTypes(types) {
   }
   const booleans = types.filter(tsHelpers.isBooleanType);
   switch (true) {
-    case (booleans.length === 1 && !!booleans[0]): {
+    case (booleans.length === 1 && booleans[0] != null): {
       const [first] = booleans;
       const evaluated = eff.F.pipe(
         tsPattern.match(first).when(tsApiUtils.isTrueLiteralType, () => eff.O.some("truthy boolean")).when(tsApiUtils.isFalseLiteralType, () => eff.O.some("falsy boolean")).otherwise(eff.O.none)
@@ -1663,7 +1669,7 @@ var no_missing_component_display_name_default = createRule({
       "Program:exit"(node) {
         const components = ctx.getAllComponents(node);
         for (const { node: node2, displayName, flag } of components.values()) {
-          const isMemoOrForwardRef = Boolean(flag & core.ERFunctionComponentFlag.ForwardRef) || Boolean(flag & core.ERFunctionComponentFlag.Memo);
+          const isMemoOrForwardRef = (flag & (core.ERFunctionComponentFlag.ForwardRef | core.ERFunctionComponentFlag.Memo)) > 0n;
           if (eff.O.isSome(AST11__namespace.getFunctionIdentifier(node2))) {
             continue;
           }
@@ -1745,7 +1751,7 @@ var no_missing_key_default = createRule({
     }
     function checkBlockStatement(node) {
       return AST11__namespace.getNestedReturnStatements(node).reduce((acc, statement) => {
-        if (!statement.argument) {
+        if (statement.argument == null) {
           return acc;
         }
         const mbDescriptor = checkIteratorElement(statement.argument);
@@ -2021,7 +2027,7 @@ var no_redundant_should_component_update_default = createRule({
       "Program:exit"(node) {
         const components = ctx.getAllComponents(node);
         for (const { name: name2, node: component, flag } of components.values()) {
-          if (!(flag & core.ERClassComponentFlag.PureComponent)) {
+          if ((flag & core.ERClassComponentFlag.PureComponent) === 0n) {
             continue;
           }
           const { body } = component.body;
@@ -2493,7 +2499,7 @@ var no_unstable_default_props_default = createRule({
         for (const { node: component } of components.values()) {
           const { params } = component;
           const [props] = params;
-          if (!props) {
+          if (props == null) {
             continue;
           }
           const properties = tsPattern.match(props).with({ type: types.AST_NODE_TYPES.ObjectPattern }, ({ properties: properties2 }) => properties2).with({ type: types.AST_NODE_TYPES.Identifier }, ({ name: name2 }) => {
@@ -2605,13 +2611,13 @@ var no_unused_class_component_members_default = createRule({
     }
     function classExit() {
       const currentClass = classStack.pop();
-      if (!currentClass || !core.isClassComponent(currentClass)) {
+      if (currentClass == null || !core.isClassComponent(currentClass)) {
         return;
       }
       const className = eff.O.map(AST11__namespace.getClassIdentifier(currentClass), (id) => id.name);
       const defs = propertyDefs.get(currentClass);
       const usages = propertyUsages.get(currentClass);
-      if (!defs) {
+      if (defs == null) {
         return;
       }
       for (const def of defs) {
@@ -2635,7 +2641,7 @@ var no_unused_class_component_members_default = createRule({
     function methodEnter(node) {
       methodStack.push(node);
       const currentClass = classStack.at(-1);
-      if (!currentClass || !core.isClassComponent(currentClass)) {
+      if (currentClass == null || !core.isClassComponent(currentClass)) {
         return;
       }
       if (node.static) {
@@ -2656,7 +2662,7 @@ var no_unused_class_component_members_default = createRule({
       MemberExpression(node) {
         const currentClass = classStack.at(-1);
         const currentMethod = methodStack.at(-1);
-        if (!currentClass || !currentMethod) {
+        if (currentClass == null || currentMethod == null) {
           return;
         }
         if (!core.isClassComponent(currentClass) || currentMethod.static) {
@@ -2678,13 +2684,13 @@ var no_unused_class_component_members_default = createRule({
       VariableDeclarator(node) {
         const currentClass = classStack.at(-1);
         const currentMethod = methodStack.at(-1);
-        if (!currentClass || !currentMethod) {
+        if (currentClass == null || currentMethod == null) {
           return;
         }
         if (!core.isClassComponent(currentClass) || currentMethod.static) {
           return;
         }
-        if (node.init && AST11__namespace.isThisExpression(node.init) && node.id.type === types.AST_NODE_TYPES.ObjectPattern) {
+        if (node.init != null && AST11__namespace.isThisExpression(node.init) && node.id.type === types.AST_NODE_TYPES.ObjectPattern) {
           for (const prop of node.id.properties) {
             if (prop.type === types.AST_NODE_TYPES.Property && AST11__namespace.isKeyLiteralLike(prop, prop.key)) {
               const mbName = getName3(prop.key);
@@ -2755,7 +2761,7 @@ var no_unused_state_default = createRule({
     }
     function classExit() {
       const currentClass = classStack.pop();
-      if (!currentClass || !core.isClassComponent(currentClass)) {
+      if (currentClass == null || !core.isClassComponent(currentClass)) {
         return;
       }
       const className = eff.O.map(AST11__namespace.getClassIdentifier(currentClass), (id) => id.name);
@@ -2774,7 +2780,7 @@ var no_unused_state_default = createRule({
     function methodEnter(node) {
       methodStack.push(node);
       const currentClass = classStack.at(-1);
-      if (!currentClass || !core.isClassComponent(currentClass)) {
+      if (currentClass == null || !core.isClassComponent(currentClass)) {
         return;
       }
       if (node.static) {
@@ -2803,11 +2809,11 @@ var no_unused_state_default = createRule({
           return;
         }
         const currentClass = classStack.at(-1);
-        if (!currentClass || !core.isClassComponent(currentClass)) {
+        if (currentClass == null || !core.isClassComponent(currentClass)) {
           return;
         }
         const currentConstructor = constructorStack.at(-1);
-        if (!currentConstructor || !currentClass.body.body.includes(currentConstructor)) {
+        if (currentConstructor == null || !currentClass.body.body.includes(currentConstructor)) {
           return;
         }
         const [_, isUsed] = stateDefs.get(currentClass) ?? [eff.O.none(), false];
@@ -2825,11 +2831,11 @@ var no_unused_state_default = createRule({
           return;
         }
         const currentClass = classStack.at(-1);
-        if (!currentClass || !core.isClassComponent(currentClass)) {
+        if (currentClass == null || !core.isClassComponent(currentClass)) {
           return;
         }
         const currentMethod = methodStack.at(-1);
-        if (!currentMethod || currentMethod.static) {
+        if (currentMethod == null || currentMethod.static) {
           return;
         }
         if (currentMethod === constructorStack.at(-1)) {
@@ -2849,11 +2855,11 @@ var no_unused_state_default = createRule({
       "PropertyDefinition:exit": methodExit,
       VariableDeclarator(node) {
         const currentClass = classStack.at(-1);
-        if (!currentClass || !core.isClassComponent(currentClass)) {
+        if (currentClass == null || !core.isClassComponent(currentClass)) {
           return;
         }
         const currentMethod = methodStack.at(-1);
-        if (!currentMethod || currentMethod.static) {
+        if (currentMethod == null || currentMethod.static) {
           return;
         }
         if (currentMethod === constructorStack.at(-1)) {
@@ -2862,7 +2868,7 @@ var no_unused_state_default = createRule({
         if (!currentClass.body.body.includes(currentMethod)) {
           return;
         }
-        if (!(node.init && AST11__namespace.isThisExpression(node.init) && node.id.type === types.AST_NODE_TYPES.ObjectPattern)) {
+        if (!(node.init != null && AST11__namespace.isThisExpression(node.init) && node.id.type === types.AST_NODE_TYPES.ObjectPattern)) {
           return;
         }
         const hasState = node.id.properties.some((prop) => {
@@ -3008,7 +3014,7 @@ var prefer_destructuring_assignment_default = createRule({
         for (const [initialScope, memberExpression] of memberExpressionWithNames) {
           let scope = initialScope;
           let isComponent = isFunctionComponent(scope.block);
-          while (!isComponent && scope.upper && scope.upper !== scope) {
+          while (!isComponent && scope.upper != null && scope.upper !== scope) {
             scope = scope.upper;
             isComponent = isFunctionComponent(scope.block);
           }
@@ -3134,7 +3140,7 @@ var prefer_read_only_props_default = createRule({
         const components = ctx.getAllComponents(node);
         for (const [_, component] of components) {
           const [props] = component.node.params;
-          if (!props) {
+          if (props == null) {
             continue;
           }
           const propsType = typeUtils.getConstrainedTypeAtLocation(services, props);
@@ -3223,7 +3229,7 @@ var prefer_shorthand_fragment_default = createRule({
         node,
         fix: (fixer) => {
           const { closingElement, openingElement } = node;
-          if (!closingElement) {
+          if (closingElement == null) {
             return [];
           }
           return [

package/dist/index.mjs

@@ -1,8 +1,8 @@
-import { F, O, or, isString, not, isNullable } from '@eslint-react/eff';
+import { F, O, isString, not, or, isNullable } from '@eslint-react/eff';
 import * as JSX7 from '@eslint-react/jsx';
 import { createRuleForPlugin, getSettingsFromContext, unsafeDecodeSettings } from '@eslint-react/shared';
 import * as AST11 from '@eslint-react/ast';
-import { isForwardRefCall, isThisSetState, isClassComponent, isCreateElementCall, isCloneElementCall, isChildrenCount, isChildrenForEach, isChildrenMap, isChildrenOnly, isChildrenToArray, useComponentCollectorLegacy, isCreateRefCall, isComponentName, useComponentCollector, ERFunctionComponentFlag, isChildrenToArrayCall, ERComponentHint, isDirectValueOfRenderPropertyLoose, isDeclaredInRenderPropLoose, isInsideCreateElementProps, isInsideRenderMethod, ERClassComponentFlag, isReactHookCall, isInitializedFromReact } from '@eslint-react/core';
+import { isForwardRefCall, isThisSetState, isClassComponent, isChildrenCount, isChildrenForEach, isChildrenMap, isChildrenOnly, isChildrenToArray, useComponentCollectorLegacy, isCloneElementCall, isCreateRefCall, isComponentName, useComponentCollector, ERFunctionComponentFlag, isChildrenToArrayCall, ERComponentHint, isDirectValueOfRenderPropertyLoose, isDeclaredInRenderPropLoose, isInsideCreateElementProps, isInsideRenderMethod, ERClassComponentFlag, isReactHookCall, isCreateElementCall, isInitializedFromReact } from '@eslint-react/core';
 import { AST_NODE_TYPES } from '@typescript-eslint/types';
 import { isMatching, match, P } from 'ts-pattern';
 import { compare } from 'compare-versions';
@@ -15,7 +15,7 @@ import { getTypeImmutability, isUnknown, isImmutable, isReadonlyShallow, isReado
 
 // package.json
 var name = "eslint-plugin-react-x";
-var version = "1.23.3-next.4";
+var version = "1.23.3-next.6";
 var createRule = createRuleForPlugin("x");
 
 // src/rules/avoid-shorthand-boolean.ts
@@ -39,7 +39,7 @@ var avoid_shorthand_boolean_default = createRule({
   name: RULE_NAME,
   create(context) {
     function getReportDescriptor(node) {
-      return node.value ? O.none() : O.some({
+      return node.value != null ? O.none() : O.some({
         messageId: "avoidShorthandBoolean",
         node,
         data: {
@@ -109,11 +109,11 @@ var ensure_forward_ref_using_ref_default = createRule({
           return;
         }
         const [component] = node.arguments;
-        if (!component || !AST11.isFunction(component)) {
+        if (component == null || !AST11.isFunction(component)) {
           return;
         }
         const [_, ref] = component.params;
-        if (ref) {
+        if (ref != null) {
           return;
         }
         context.report({
@@ -194,15 +194,15 @@ var no_access_state_in_setstate_default = createRule({
           return;
         }
         const [currClass, isComponent] = classStack.at(-1) ?? [];
-        if (!currClass || !isComponent) {
+        if (currClass == null || !isComponent) {
           return;
         }
         const [currMethod, isStatic] = methodStack.at(-1) ?? [];
-        if (!currMethod || isStatic) {
+        if (currMethod == null || isStatic) {
           return;
         }
         const [setState, hasThisState] = setStateStack.at(-1) ?? [];
-        if (!setState || hasThisState) {
+        if (setState == null || hasThisState) {
           return;
         }
         if (!O.exists(getName(node.property), (name2) => name2 === "state")) {
@@ -224,18 +224,18 @@ var no_access_state_in_setstate_default = createRule({
       },
       VariableDeclarator(node) {
         const [currClass, isComponent] = classStack.at(-1) ?? [];
-        if (!currClass || !isComponent) {
+        if (currClass == null || !isComponent) {
           return;
         }
         const [currMethod, isStatic] = methodStack.at(-1) ?? [];
-        if (!currMethod || isStatic) {
+        if (currMethod == null || isStatic) {
           return;
         }
         const [setState, hasThisState] = setStateStack.at(-1) ?? [];
-        if (!setState || hasThisState) {
+        if (setState == null || hasThisState) {
           return;
         }
-        if (!(node.init && AST11.isThisExpression(node.init) && node.id.type === AST_NODE_TYPES.ObjectPattern)) {
+        if (!(node.init != null && AST11.isThisExpression(node.init) && node.id.type === AST_NODE_TYPES.ObjectPattern)) {
           return;
         }
         const hasState = node.id.properties.some((prop) => {
@@ -272,16 +272,6 @@ var iteratorFunctionIndexParamPosition = /* @__PURE__ */ new Map([
   ["reduceRight", 2],
   ["some", 1]
 ]);
-var isToStringCall = isMatching({
-  type: AST_NODE_TYPES.CallExpression,
-  callee: {
-    type: AST_NODE_TYPES.MemberExpression,
-    property: {
-      type: AST_NODE_TYPES.Identifier,
-      name: "toString"
-    }
-  }
-});
 function isReactChildrenMethod(name2) {
   return reactChildrenMethod.some((method) => method === name2);
 }
@@ -316,7 +306,7 @@ function getMapIndexParamName(node, context) {
     return O.none();
   }
   const callbackArg = node.arguments[isUsingReactChildren(node, context) ? 1 : 0];
-  if (!callbackArg) {
+  if (callbackArg == null) {
     return O.none();
   }
   if (!AST11.isOneOf([AST_NODE_TYPES.ArrowFunctionExpression, AST_NODE_TYPES.FunctionExpression])(callbackArg)) {
@@ -331,7 +321,7 @@ function getMapIndexParamName(node, context) {
     return O.none();
   }
   const param = params.at(indexParamPosition);
-  return param && "name" in param ? O.some(param.name) : O.none();
+  return param != null && "name" in param ? O.some(param.name) : O.none();
 }
 var no_array_index_key_default = createRule({
   meta: {
@@ -348,40 +338,57 @@ var no_array_index_key_default = createRule({
   name: RULE_NAME5,
   create(context) {
     const indexParamNames = [];
-    const isCreateOrCloneElementCall = or(isCreateElementCall(context), isCloneElementCall(context));
     function isArrayIndex(node) {
       return node.type === AST_NODE_TYPES.Identifier && indexParamNames.some(O.exists((name2) => name2 === node.name));
     }
-    function getReportDescriptor(node) {
-      if (isArrayIndex(node)) {
-        return [{ messageId: "noArrayIndexKey", node }];
-      }
-      if (AST11.isOneOf([AST_NODE_TYPES.TemplateLiteral, AST_NODE_TYPES.BinaryExpression])(node)) {
-        const exps = AST_NODE_TYPES.TemplateLiteral === node.type ? node.expressions : AST11.getIdentifiersFromBinaryExpression(node);
-        return exps.reduce((acc, exp) => {
-          if (isArrayIndex(exp)) {
-            return [...acc, { messageId: "noArrayIndexKey", node: exp }];
+    function isCreateOrCloneElementCall(node) {
+      return isCreateElementCall(node, context) || isCloneElementCall(node, context);
+    }
+    function getReportDescriptors(node) {
+      switch (node.type) {
+        // key={bar}
+        case AST_NODE_TYPES.Identifier: {
+          if (indexParamNames.some(O.exists((name2) => name2 === node.name))) {
+            return [{
+              messageId: "noArrayIndexKey",
+              node
+            }];
           }
-          return acc;
-        }, []);
-      }
-      if (isToStringCall(node)) {
-        if (!("object" in node.callee && isArrayIndex(node.callee.object))) {
           return [];
         }
-        return [{ messageId: "noArrayIndexKey", node: node.callee.object }];
-      }
-      const isStringCall = isMatching({
-        type: AST_NODE_TYPES.CallExpression,
-        callee: {
-          type: AST_NODE_TYPES.Identifier,
-          name: "String"
-        }
-      }, node);
-      if (isStringCall) {
-        const [arg] = node.arguments;
-        if (arg && isArrayIndex(arg)) {
-          return [{ messageId: "noArrayIndexKey", node: arg }];
+        // key={`foo-${bar}`} or key={'foo' + bar}
+        case AST_NODE_TYPES.TemplateLiteral:
+        case AST_NODE_TYPES.BinaryExpression: {
+          const descriptors = [];
+          const expressions = node.type === AST_NODE_TYPES.TemplateLiteral ? node.expressions : AST11.getIdentifiersFromBinaryExpression(node);
+          for (const expression of expressions) {
+            if (isArrayIndex(expression)) {
+              descriptors.push({
+                messageId: "noArrayIndexKey",
+                node: expression
+              });
+            }
+          }
+          return descriptors;
+        }
+        // key={bar.toString()} or key={String(bar)}
+        case AST_NODE_TYPES.CallExpression: {
+          switch (true) {
+            // key={bar.toString()}
+            case (node.callee.type === AST_NODE_TYPES.MemberExpression && node.callee.property.type === AST_NODE_TYPES.Identifier && node.callee.property.name === "toString" && isArrayIndex(node.callee.object)): {
+              return [{
+                messageId: "noArrayIndexKey",
+                node: node.callee.object
+              }];
+            }
+            // key={String(bar)}
+            case (node.callee.type === AST_NODE_TYPES.Identifier && node.callee.name === "String" && node.arguments[0] != null && isArrayIndex(node.arguments[0])): {
+              return [{
+                messageId: "noArrayIndexKey",
+                node: node.arguments[0]
+              }];
+            }
+          }
         }
       }
       return [];
@@ -406,7 +413,7 @@ var no_array_index_key_default = createRule({
           if (!("value" in prop)) {
             continue;
           }
-          const descriptors = getReportDescriptor(prop.value);
+          const descriptors = getReportDescriptors(prop.value);
           for (const descriptor of descriptors) {
             context.report(descriptor);
           }
@@ -422,11 +429,10 @@ var no_array_index_key_default = createRule({
         if (indexParamNames.length === 0) {
           return;
         }
-        const { value } = node;
-        if (value?.type !== AST_NODE_TYPES.JSXExpressionContainer) {
+        if (node.value?.type !== AST_NODE_TYPES.JSXExpressionContainer) {
           return;
         }
-        const descriptors = getReportDescriptor(value.expression);
+        const descriptors = getReportDescriptors(node.value.expression);
         for (const descriptor of descriptors) {
           context.report(descriptor);
         }
@@ -990,7 +996,7 @@ var no_context_provider_default = createRule({
             const providerName = elementName.replace(/\.Provider$/, "");
             const openingElement = node.openingElement;
             const closingElement = node.closingElement;
-            if (!closingElement) {
+            if (closingElement == null) {
               return fixer.replaceText(openingElement.name, providerName);
             }
             return [
@@ -1232,7 +1238,7 @@ var no_duplicate_key_default = createRule({
     function isKeyValueEqual(a, b) {
       const aValue = a.value;
       const bValue = b.value;
-      if (aValue === null || bValue === null) {
+      if (aValue == null || bValue == null) {
         return false;
       }
       return AST11.isNodeEqual(aValue, bValue);
@@ -1340,7 +1346,7 @@ var no_forward_ref_default = createRule({
 function getFix(node, context) {
   return (fixer) => {
     const [componentNode] = node.arguments;
-    if (!componentNode || !AST11.isFunction(componentNode)) {
+    if (componentNode == null || !AST11.isFunction(componentNode)) {
       return [];
     }
     return [
@@ -1361,7 +1367,7 @@ function getComponentPropsFixes(node, typeArguments, fixer, context) {
   const getText = (node2) => context.sourceCode.getText(node2);
   const [arg0, arg1] = node.params;
   const [typeArg0, typeArg1] = typeArguments;
-  if (!arg0) {
+  if (arg0 == null) {
     return [];
   }
   const fixedArg0Text = match(arg0).with({ type: AST_NODE_TYPES.Identifier }, (n) => O.some(`...${n.name}`)).with({ type: AST_NODE_TYPES.ObjectPattern }, (n) => O.some(n.properties.map(getText).join(", "))).otherwise(O.none);
@@ -1371,7 +1377,7 @@ function getComponentPropsFixes(node, typeArguments, fixer, context) {
   }
   const fixedPropsText = fixedArg0Text.value;
   const fixedRefText = fixedArg1Text.value;
-  if (!typeArg0 || !typeArg1) {
+  if (typeArg0 == null || typeArg1 == null) {
     return [
       fixer.replaceText(
         arg0,
@@ -1382,7 +1388,7 @@ function getComponentPropsFixes(node, typeArguments, fixer, context) {
           "}"
         ].join(" ")
       ),
-      ...arg1 ? [fixer.remove(arg1), fixer.removeRange([arg0.range[1], arg1.range[0]])] : []
+      ...arg1 == null ? [] : [fixer.remove(arg1), fixer.removeRange([arg0.range[1], arg1.range[0]])]
     ];
   }
   return [
@@ -1401,7 +1407,7 @@ function getComponentPropsFixes(node, typeArguments, fixer, context) {
         "}"
       ].join(" ")
     ),
-    ...arg1 ? [fixer.remove(arg1), fixer.removeRange([arg0.range[1], arg1.range[0]])] : []
+    ...arg1 == null ? [] : [fixer.remove(arg1), fixer.removeRange([arg0.range[1], arg1.range[0]])]
   ];
 }
 var RULE_NAME26 = "no-implicit-key";
@@ -1477,7 +1483,7 @@ function inspectVariantTypes(types) {
   }
   const booleans = types.filter(tsHelpers.isBooleanType);
   switch (true) {
-    case (booleans.length === 1 && !!booleans[0]): {
+    case (booleans.length === 1 && booleans[0] != null): {
       const [first] = booleans;
       const evaluated = F.pipe(
         match(first).when(isTrueLiteralType, () => O.some("truthy boolean")).when(isFalseLiteralType, () => O.some("falsy boolean")).otherwise(O.none)
@@ -1636,7 +1642,7 @@ var no_missing_component_display_name_default = createRule({
       "Program:exit"(node) {
         const components = ctx.getAllComponents(node);
         for (const { node: node2, displayName, flag } of components.values()) {
-          const isMemoOrForwardRef = Boolean(flag & ERFunctionComponentFlag.ForwardRef) || Boolean(flag & ERFunctionComponentFlag.Memo);
+          const isMemoOrForwardRef = (flag & (ERFunctionComponentFlag.ForwardRef | ERFunctionComponentFlag.Memo)) > 0n;
           if (O.isSome(AST11.getFunctionIdentifier(node2))) {
             continue;
           }
@@ -1718,7 +1724,7 @@ var no_missing_key_default = createRule({
     }
     function checkBlockStatement(node) {
       return AST11.getNestedReturnStatements(node).reduce((acc, statement) => {
-        if (!statement.argument) {
+        if (statement.argument == null) {
           return acc;
         }
         const mbDescriptor = checkIteratorElement(statement.argument);
@@ -1994,7 +2000,7 @@ var no_redundant_should_component_update_default = createRule({
       "Program:exit"(node) {
         const components = ctx.getAllComponents(node);
         for (const { name: name2, node: component, flag } of components.values()) {
-          if (!(flag & ERClassComponentFlag.PureComponent)) {
+          if ((flag & ERClassComponentFlag.PureComponent) === 0n) {
             continue;
           }
           const { body } = component.body;
@@ -2466,7 +2472,7 @@ var no_unstable_default_props_default = createRule({
         for (const { node: component } of components.values()) {
           const { params } = component;
           const [props] = params;
-          if (!props) {
+          if (props == null) {
             continue;
           }
           const properties = match(props).with({ type: AST_NODE_TYPES.ObjectPattern }, ({ properties: properties2 }) => properties2).with({ type: AST_NODE_TYPES.Identifier }, ({ name: name2 }) => {
@@ -2578,13 +2584,13 @@ var no_unused_class_component_members_default = createRule({
     }
     function classExit() {
       const currentClass = classStack.pop();
-      if (!currentClass || !isClassComponent(currentClass)) {
+      if (currentClass == null || !isClassComponent(currentClass)) {
         return;
       }
       const className = O.map(AST11.getClassIdentifier(currentClass), (id) => id.name);
       const defs = propertyDefs.get(currentClass);
       const usages = propertyUsages.get(currentClass);
-      if (!defs) {
+      if (defs == null) {
         return;
       }
       for (const def of defs) {
@@ -2608,7 +2614,7 @@ var no_unused_class_component_members_default = createRule({
     function methodEnter(node) {
       methodStack.push(node);
       const currentClass = classStack.at(-1);
-      if (!currentClass || !isClassComponent(currentClass)) {
+      if (currentClass == null || !isClassComponent(currentClass)) {
         return;
       }
       if (node.static) {
@@ -2629,7 +2635,7 @@ var no_unused_class_component_members_default = createRule({
       MemberExpression(node) {
         const currentClass = classStack.at(-1);
         const currentMethod = methodStack.at(-1);
-        if (!currentClass || !currentMethod) {
+        if (currentClass == null || currentMethod == null) {
           return;
         }
         if (!isClassComponent(currentClass) || currentMethod.static) {
@@ -2651,13 +2657,13 @@ var no_unused_class_component_members_default = createRule({
       VariableDeclarator(node) {
         const currentClass = classStack.at(-1);
         const currentMethod = methodStack.at(-1);
-        if (!currentClass || !currentMethod) {
+        if (currentClass == null || currentMethod == null) {
           return;
         }
         if (!isClassComponent(currentClass) || currentMethod.static) {
           return;
         }
-        if (node.init && AST11.isThisExpression(node.init) && node.id.type === AST_NODE_TYPES.ObjectPattern) {
+        if (node.init != null && AST11.isThisExpression(node.init) && node.id.type === AST_NODE_TYPES.ObjectPattern) {
           for (const prop of node.id.properties) {
             if (prop.type === AST_NODE_TYPES.Property && AST11.isKeyLiteralLike(prop, prop.key)) {
               const mbName = getName3(prop.key);
@@ -2728,7 +2734,7 @@ var no_unused_state_default = createRule({
     }
     function classExit() {
       const currentClass = classStack.pop();
-      if (!currentClass || !isClassComponent(currentClass)) {
+      if (currentClass == null || !isClassComponent(currentClass)) {
         return;
       }
       const className = O.map(AST11.getClassIdentifier(currentClass), (id) => id.name);
@@ -2747,7 +2753,7 @@ var no_unused_state_default = createRule({
     function methodEnter(node) {
       methodStack.push(node);
       const currentClass = classStack.at(-1);
-      if (!currentClass || !isClassComponent(currentClass)) {
+      if (currentClass == null || !isClassComponent(currentClass)) {
         return;
       }
       if (node.static) {
@@ -2776,11 +2782,11 @@ var no_unused_state_default = createRule({
           return;
         }
         const currentClass = classStack.at(-1);
-        if (!currentClass || !isClassComponent(currentClass)) {
+        if (currentClass == null || !isClassComponent(currentClass)) {
           return;
         }
         const currentConstructor = constructorStack.at(-1);
-        if (!currentConstructor || !currentClass.body.body.includes(currentConstructor)) {
+        if (currentConstructor == null || !currentClass.body.body.includes(currentConstructor)) {
           return;
         }
         const [_, isUsed] = stateDefs.get(currentClass) ?? [O.none(), false];
@@ -2798,11 +2804,11 @@ var no_unused_state_default = createRule({
           return;
         }
         const currentClass = classStack.at(-1);
-        if (!currentClass || !isClassComponent(currentClass)) {
+        if (currentClass == null || !isClassComponent(currentClass)) {
           return;
         }
         const currentMethod = methodStack.at(-1);
-        if (!currentMethod || currentMethod.static) {
+        if (currentMethod == null || currentMethod.static) {
           return;
         }
         if (currentMethod === constructorStack.at(-1)) {
@@ -2822,11 +2828,11 @@ var no_unused_state_default = createRule({
       "PropertyDefinition:exit": methodExit,
       VariableDeclarator(node) {
         const currentClass = classStack.at(-1);
-        if (!currentClass || !isClassComponent(currentClass)) {
+        if (currentClass == null || !isClassComponent(currentClass)) {
           return;
         }
         const currentMethod = methodStack.at(-1);
-        if (!currentMethod || currentMethod.static) {
+        if (currentMethod == null || currentMethod.static) {
           return;
         }
         if (currentMethod === constructorStack.at(-1)) {
@@ -2835,7 +2841,7 @@ var no_unused_state_default = createRule({
         if (!currentClass.body.body.includes(currentMethod)) {
           return;
         }
-        if (!(node.init && AST11.isThisExpression(node.init) && node.id.type === AST_NODE_TYPES.ObjectPattern)) {
+        if (!(node.init != null && AST11.isThisExpression(node.init) && node.id.type === AST_NODE_TYPES.ObjectPattern)) {
           return;
         }
         const hasState = node.id.properties.some((prop) => {
@@ -2981,7 +2987,7 @@ var prefer_destructuring_assignment_default = createRule({
         for (const [initialScope, memberExpression] of memberExpressionWithNames) {
           let scope = initialScope;
           let isComponent = isFunctionComponent(scope.block);
-          while (!isComponent && scope.upper && scope.upper !== scope) {
+          while (!isComponent && scope.upper != null && scope.upper !== scope) {
             scope = scope.upper;
             isComponent = isFunctionComponent(scope.block);
           }
@@ -3107,7 +3113,7 @@ var prefer_read_only_props_default = createRule({
         const components = ctx.getAllComponents(node);
         for (const [_, component] of components) {
           const [props] = component.node.params;
-          if (!props) {
+          if (props == null) {
             continue;
           }
           const propsType = getConstrainedTypeAtLocation(services, props);
@@ -3196,7 +3202,7 @@ var prefer_shorthand_fragment_default = createRule({
         node,
         fix: (fixer) => {
           const { closingElement, openingElement } = node;
-          if (!closingElement) {
+          if (closingElement == null) {
             return [];
           }
           return [

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-x",
-  "version": "1.23.3-next.4",
+  "version": "1.23.3-next.6",
   "description": "A set of composable ESLint rules for libraries and frameworks that use React as a UI runtime.",
   "keywords": [
     "react",
@@ -48,16 +48,16 @@
     "is-immutable-type": "^5.0.1",
     "string-ts": "^2.2.0",
     "ts-pattern": "^5.6.0",
-    "@eslint-react/ast": "1.23.3-next.4",
-    "@eslint-react/core": "1.23.3-next.4",
-    "@eslint-react/jsx": "1.23.3-next.4",
-    "@eslint-react/eff": "1.23.3-next.4",
-    "@eslint-react/shared": "1.23.3-next.4",
-    "@eslint-react/types": "1.23.3-next.4",
-    "@eslint-react/var": "1.23.3-next.4"
+    "@eslint-react/ast": "1.23.3-next.6",
+    "@eslint-react/core": "1.23.3-next.6",
+    "@eslint-react/jsx": "1.23.3-next.6",
+    "@eslint-react/eff": "1.23.3-next.6",
+    "@eslint-react/shared": "1.23.3-next.6",
+    "@eslint-react/var": "1.23.3-next.6",
+    "@eslint-react/types": "1.23.3-next.6"
   },
   "devDependencies": {
-    "@types/react": "^19.0.3",
+    "@types/react": "^19.0.4",
     "@types/react-dom": "^19.0.2",
     "ts-api-utils": "^2.0.0",
     "tsup": "^8.3.5",