eslint-plugin-react-x 1.23.3-next.3 → 1.23.3-next.5

package/dist/index.js

@@ -42,7 +42,7 @@ var ts__default = /*#__PURE__*/_interopDefault(ts);
 
 // package.json
 var name = "eslint-plugin-react-x";
-var version = "1.23.3-next.3";
+var version = "1.23.3-next.5";
 var createRule = shared.createRuleForPlugin("x");
 
 // src/rules/avoid-shorthand-boolean.ts
@@ -299,16 +299,6 @@ var iteratorFunctionIndexParamPosition = /* @__PURE__ */ new Map([
   ["reduceRight", 2],
   ["some", 1]
 ]);
-var isToStringCall = tsPattern.isMatching({
-  type: types.AST_NODE_TYPES.CallExpression,
-  callee: {
-    type: types.AST_NODE_TYPES.MemberExpression,
-    property: {
-      type: types.AST_NODE_TYPES.Identifier,
-      name: "toString"
-    }
-  }
-});
 function isReactChildrenMethod(name2) {
   return reactChildrenMethod.some((method) => method === name2);
 }
@@ -375,40 +365,57 @@ var no_array_index_key_default = createRule({
   name: RULE_NAME5,
   create(context) {
     const indexParamNames = [];
-    const isCreateOrCloneElementCall = eff.or(core.isCreateElementCall(context), core.isCloneElementCall(context));
     function isArrayIndex(node) {
       return node.type === types.AST_NODE_TYPES.Identifier && indexParamNames.some(eff.O.exists((name2) => name2 === node.name));
     }
-    function getReportDescriptor(node) {
-      if (isArrayIndex(node)) {
-        return [{ messageId: "noArrayIndexKey", node }];
-      }
-      if (AST11__namespace.isOneOf([types.AST_NODE_TYPES.TemplateLiteral, types.AST_NODE_TYPES.BinaryExpression])(node)) {
-        const exps = types.AST_NODE_TYPES.TemplateLiteral === node.type ? node.expressions : AST11__namespace.getIdentifiersFromBinaryExpression(node);
-        return exps.reduce((acc, exp) => {
-          if (isArrayIndex(exp)) {
-            return [...acc, { messageId: "noArrayIndexKey", node: exp }];
+    function isCreateOrCloneElementCall(node) {
+      return core.isCreateElementCall(node, context) || core.isCloneElementCall(node, context);
+    }
+    function getReportDescriptors(node) {
+      switch (node.type) {
+        // key={bar}
+        case types.AST_NODE_TYPES.Identifier: {
+          if (indexParamNames.some(eff.O.exists((name2) => name2 === node.name))) {
+            return [{
+              messageId: "noArrayIndexKey",
+              node
+            }];
           }
-          return acc;
-        }, []);
-      }
-      if (isToStringCall(node)) {
-        if (!("object" in node.callee && isArrayIndex(node.callee.object))) {
           return [];
         }
-        return [{ messageId: "noArrayIndexKey", node: node.callee.object }];
-      }
-      const isStringCall = tsPattern.isMatching({
-        type: types.AST_NODE_TYPES.CallExpression,
-        callee: {
-          type: types.AST_NODE_TYPES.Identifier,
-          name: "String"
-        }
-      }, node);
-      if (isStringCall) {
-        const [arg] = node.arguments;
-        if (arg && isArrayIndex(arg)) {
-          return [{ messageId: "noArrayIndexKey", node: arg }];
+        // key={`foo-${bar}`} or key={'foo' + bar}
+        case types.AST_NODE_TYPES.TemplateLiteral:
+        case types.AST_NODE_TYPES.BinaryExpression: {
+          const descriptors = [];
+          const expressions = node.type === types.AST_NODE_TYPES.TemplateLiteral ? node.expressions : AST11__namespace.getIdentifiersFromBinaryExpression(node);
+          for (const expression of expressions) {
+            if (isArrayIndex(expression)) {
+              descriptors.push({
+                messageId: "noArrayIndexKey",
+                node: expression
+              });
+            }
+          }
+          return descriptors;
+        }
+        // key={bar.toString()} or key={String(bar)}
+        case types.AST_NODE_TYPES.CallExpression: {
+          switch (true) {
+            // key={bar.toString()}
+            case (node.callee.type === types.AST_NODE_TYPES.MemberExpression && node.callee.property.type === types.AST_NODE_TYPES.Identifier && node.callee.property.name === "toString" && isArrayIndex(node.callee.object)): {
+              return [{
+                messageId: "noArrayIndexKey",
+                node: node.callee.object
+              }];
+            }
+            // key={String(bar)}
+            case (node.callee.type === types.AST_NODE_TYPES.Identifier && node.callee.name === "String" && node.arguments[0] && isArrayIndex(node.arguments[0])): {
+              return [{
+                messageId: "noArrayIndexKey",
+                node: node.arguments[0]
+              }];
+            }
+          }
         }
       }
       return [];
@@ -433,7 +440,7 @@ var no_array_index_key_default = createRule({
           if (!("value" in prop)) {
             continue;
           }
-          const descriptors = getReportDescriptor(prop.value);
+          const descriptors = getReportDescriptors(prop.value);
           for (const descriptor of descriptors) {
             context.report(descriptor);
           }
@@ -449,11 +456,10 @@ var no_array_index_key_default = createRule({
         if (indexParamNames.length === 0) {
           return;
         }
-        const { value } = node;
-        if (value?.type !== types.AST_NODE_TYPES.JSXExpressionContainer) {
+        if (node.value?.type !== types.AST_NODE_TYPES.JSXExpressionContainer) {
           return;
         }
-        const descriptors = getReportDescriptor(value.expression);
+        const descriptors = getReportDescriptors(node.value.expression);
         for (const descriptor of descriptors) {
           context.report(descriptor);
         }

package/dist/index.mjs

@@ -1,8 +1,8 @@
-import { F, O, or, isString, not, isNullable } from '@eslint-react/eff';
+import { F, O, isString, not, or, isNullable } from '@eslint-react/eff';
 import * as JSX7 from '@eslint-react/jsx';
 import { createRuleForPlugin, getSettingsFromContext, unsafeDecodeSettings } from '@eslint-react/shared';
 import * as AST11 from '@eslint-react/ast';
-import { isForwardRefCall, isThisSetState, isClassComponent, isCreateElementCall, isCloneElementCall, isChildrenCount, isChildrenForEach, isChildrenMap, isChildrenOnly, isChildrenToArray, useComponentCollectorLegacy, isCreateRefCall, isComponentName, useComponentCollector, ERFunctionComponentFlag, isChildrenToArrayCall, ERComponentHint, isDirectValueOfRenderPropertyLoose, isDeclaredInRenderPropLoose, isInsideCreateElementProps, isInsideRenderMethod, ERClassComponentFlag, isReactHookCall, isInitializedFromReact } from '@eslint-react/core';
+import { isForwardRefCall, isThisSetState, isClassComponent, isChildrenCount, isChildrenForEach, isChildrenMap, isChildrenOnly, isChildrenToArray, useComponentCollectorLegacy, isCloneElementCall, isCreateRefCall, isComponentName, useComponentCollector, ERFunctionComponentFlag, isChildrenToArrayCall, ERComponentHint, isDirectValueOfRenderPropertyLoose, isDeclaredInRenderPropLoose, isInsideCreateElementProps, isInsideRenderMethod, ERClassComponentFlag, isReactHookCall, isCreateElementCall, isInitializedFromReact } from '@eslint-react/core';
 import { AST_NODE_TYPES } from '@typescript-eslint/types';
 import { isMatching, match, P } from 'ts-pattern';
 import { compare } from 'compare-versions';
@@ -15,7 +15,7 @@ import { getTypeImmutability, isUnknown, isImmutable, isReadonlyShallow, isReado
 
 // package.json
 var name = "eslint-plugin-react-x";
-var version = "1.23.3-next.3";
+var version = "1.23.3-next.5";
 var createRule = createRuleForPlugin("x");
 
 // src/rules/avoid-shorthand-boolean.ts
@@ -272,16 +272,6 @@ var iteratorFunctionIndexParamPosition = /* @__PURE__ */ new Map([
   ["reduceRight", 2],
   ["some", 1]
 ]);
-var isToStringCall = isMatching({
-  type: AST_NODE_TYPES.CallExpression,
-  callee: {
-    type: AST_NODE_TYPES.MemberExpression,
-    property: {
-      type: AST_NODE_TYPES.Identifier,
-      name: "toString"
-    }
-  }
-});
 function isReactChildrenMethod(name2) {
   return reactChildrenMethod.some((method) => method === name2);
 }
@@ -348,40 +338,57 @@ var no_array_index_key_default = createRule({
   name: RULE_NAME5,
   create(context) {
     const indexParamNames = [];
-    const isCreateOrCloneElementCall = or(isCreateElementCall(context), isCloneElementCall(context));
     function isArrayIndex(node) {
       return node.type === AST_NODE_TYPES.Identifier && indexParamNames.some(O.exists((name2) => name2 === node.name));
     }
-    function getReportDescriptor(node) {
-      if (isArrayIndex(node)) {
-        return [{ messageId: "noArrayIndexKey", node }];
-      }
-      if (AST11.isOneOf([AST_NODE_TYPES.TemplateLiteral, AST_NODE_TYPES.BinaryExpression])(node)) {
-        const exps = AST_NODE_TYPES.TemplateLiteral === node.type ? node.expressions : AST11.getIdentifiersFromBinaryExpression(node);
-        return exps.reduce((acc, exp) => {
-          if (isArrayIndex(exp)) {
-            return [...acc, { messageId: "noArrayIndexKey", node: exp }];
+    function isCreateOrCloneElementCall(node) {
+      return isCreateElementCall(node, context) || isCloneElementCall(node, context);
+    }
+    function getReportDescriptors(node) {
+      switch (node.type) {
+        // key={bar}
+        case AST_NODE_TYPES.Identifier: {
+          if (indexParamNames.some(O.exists((name2) => name2 === node.name))) {
+            return [{
+              messageId: "noArrayIndexKey",
+              node
+            }];
           }
-          return acc;
-        }, []);
-      }
-      if (isToStringCall(node)) {
-        if (!("object" in node.callee && isArrayIndex(node.callee.object))) {
           return [];
         }
-        return [{ messageId: "noArrayIndexKey", node: node.callee.object }];
-      }
-      const isStringCall = isMatching({
-        type: AST_NODE_TYPES.CallExpression,
-        callee: {
-          type: AST_NODE_TYPES.Identifier,
-          name: "String"
-        }
-      }, node);
-      if (isStringCall) {
-        const [arg] = node.arguments;
-        if (arg && isArrayIndex(arg)) {
-          return [{ messageId: "noArrayIndexKey", node: arg }];
+        // key={`foo-${bar}`} or key={'foo' + bar}
+        case AST_NODE_TYPES.TemplateLiteral:
+        case AST_NODE_TYPES.BinaryExpression: {
+          const descriptors = [];
+          const expressions = node.type === AST_NODE_TYPES.TemplateLiteral ? node.expressions : AST11.getIdentifiersFromBinaryExpression(node);
+          for (const expression of expressions) {
+            if (isArrayIndex(expression)) {
+              descriptors.push({
+                messageId: "noArrayIndexKey",
+                node: expression
+              });
+            }
+          }
+          return descriptors;
+        }
+        // key={bar.toString()} or key={String(bar)}
+        case AST_NODE_TYPES.CallExpression: {
+          switch (true) {
+            // key={bar.toString()}
+            case (node.callee.type === AST_NODE_TYPES.MemberExpression && node.callee.property.type === AST_NODE_TYPES.Identifier && node.callee.property.name === "toString" && isArrayIndex(node.callee.object)): {
+              return [{
+                messageId: "noArrayIndexKey",
+                node: node.callee.object
+              }];
+            }
+            // key={String(bar)}
+            case (node.callee.type === AST_NODE_TYPES.Identifier && node.callee.name === "String" && node.arguments[0] && isArrayIndex(node.arguments[0])): {
+              return [{
+                messageId: "noArrayIndexKey",
+                node: node.arguments[0]
+              }];
+            }
+          }
         }
       }
       return [];
@@ -406,7 +413,7 @@ var no_array_index_key_default = createRule({
           if (!("value" in prop)) {
             continue;
           }
-          const descriptors = getReportDescriptor(prop.value);
+          const descriptors = getReportDescriptors(prop.value);
           for (const descriptor of descriptors) {
             context.report(descriptor);
           }
@@ -422,11 +429,10 @@ var no_array_index_key_default = createRule({
         if (indexParamNames.length === 0) {
           return;
         }
-        const { value } = node;
-        if (value?.type !== AST_NODE_TYPES.JSXExpressionContainer) {
+        if (node.value?.type !== AST_NODE_TYPES.JSXExpressionContainer) {
           return;
         }
-        const descriptors = getReportDescriptor(value.expression);
+        const descriptors = getReportDescriptors(node.value.expression);
         for (const descriptor of descriptors) {
           context.report(descriptor);
         }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-x",
-  "version": "1.23.3-next.3",
+  "version": "1.23.3-next.5",
   "description": "A set of composable ESLint rules for libraries and frameworks that use React as a UI runtime.",
   "keywords": [
     "react",
@@ -20,7 +20,6 @@
   },
   "license": "MIT",
   "author": "Eva1ent<rel1cx@proton.me>",
-  "sideEffects": false,
   "exports": {
     ".": {
       "import": {
@@ -35,7 +34,6 @@
     "./package.json": "./package.json"
   },
   "main": "dist/index.js",
-  "module": "dist/index.mjs",
   "types": "dist/index.d.ts",
   "files": [
     "dist",
@@ -50,34 +48,34 @@
     "is-immutable-type": "^5.0.1",
     "string-ts": "^2.2.0",
     "ts-pattern": "^5.6.0",
-    "@eslint-react/ast": "1.23.3-next.3",
-    "@eslint-react/eff": "1.23.3-next.3",
-    "@eslint-react/core": "1.23.3-next.3",
-    "@eslint-react/jsx": "1.23.3-next.3",
-    "@eslint-react/shared": "1.23.3-next.3",
-    "@eslint-react/types": "1.23.3-next.3",
-    "@eslint-react/var": "1.23.3-next.3"
+    "@eslint-react/ast": "1.23.3-next.5",
+    "@eslint-react/core": "1.23.3-next.5",
+    "@eslint-react/eff": "1.23.3-next.5",
+    "@eslint-react/shared": "1.23.3-next.5",
+    "@eslint-react/types": "1.23.3-next.5",
+    "@eslint-react/var": "1.23.3-next.5",
+    "@eslint-react/jsx": "1.23.3-next.5"
   },
   "devDependencies": {
-    "@types/react": "^19.0.3",
+    "@types/react": "^19.0.4",
     "@types/react-dom": "^19.0.2",
-    "tsup": "^8.3.5",
     "ts-api-utils": "^2.0.0",
+    "tsup": "^8.3.5",
     "@workspace/configs": "0.0.0"
   },
   "peerDependencies": {
     "eslint": "^8.57.0 || ^9.0.0",
-    "typescript": "^4.9.5 || ^5.3.3",
-    "ts-api-utils": "^2.0.0"
+    "ts-api-utils": "^2.0.0",
+    "typescript": "^4.9.5 || ^5.3.3"
   },
   "peerDependenciesMeta": {
     "eslint": {
       "optional": false
     },
-    "typescript": {
+    "ts-api-utils": {
       "optional": true
     },
-    "ts-api-utils": {
+    "typescript": {
       "optional": true
     }
   },
@@ -88,6 +86,8 @@
   "publishConfig": {
     "access": "public"
   },
+  "sideEffects": false,
+  "module": "dist/index.mjs",
   "scripts": {
     "build": "tsup --dts-resolve",
     "lint:publish": "publint",