npm - eslint-plugin-react-x - Versions diffs - 1.22.2-next.1 → 1.22.2-next.11 - Mend

eslint-plugin-react-x 1.22.2-next.1 → 1.22.2-next.11

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (3) hide show

package/dist/index.js CHANGED Viewed

@@ -1,7 +1,7 @@
 'use strict';
 var eff = require('@eslint-react/eff');
-var JSX8 = require('@eslint-react/jsx');
+var JSX7 = require('@eslint-react/jsx');
 var shared = require('@eslint-react/shared');
 var AST11 = require('@eslint-react/ast');
 var core = require('@eslint-react/core');
@@ -35,14 +35,14 @@ function _interopNamespace(e) {
   return Object.freeze(n);
 }
-var JSX8__namespace = /*#__PURE__*/_interopNamespace(JSX8);
+var JSX7__namespace = /*#__PURE__*/_interopNamespace(JSX7);
 var AST11__namespace = /*#__PURE__*/_interopNamespace(AST11);
 var VAR__namespace = /*#__PURE__*/_interopNamespace(VAR);
 var ts__default = /*#__PURE__*/_interopDefault(ts);
 // package.json
 var name = "eslint-plugin-react-x";
-var version = "1.22.2-next.1";
+var version = "1.22.2-next.11";
 var createRule = shared.createRuleForPlugin("x");
 // src/rules/avoid-shorthand-boolean.ts
@@ -70,7 +70,7 @@ var avoid_shorthand_boolean_default = createRule({
         messageId: "avoidShorthandBoolean",
         node,
         data: {
-          propName: JSX8__namespace.getPropName(node)
+          propName: JSX7__namespace.getPropName(node)
         },
         fix: (fixer) => fixer.insertTextAfter(node.name, `={true}`)
       });
@@ -151,7 +151,7 @@ var RULE_FEATURES4 = [
   "CHK"
 ];
 function getName(node) {
-  if (node.type === types.AST_NODE_TYPES.TSAsExpression) {
+  if (AST11__namespace.isTypeExpression(node)) {
     return getName(node.expression);
   }
   if (node.type === types.AST_NODE_TYPES.Identifier || node.type === types.AST_NODE_TYPES.PrivateIdentifier) {
@@ -327,12 +327,10 @@ var no_array_index_key_default = createRule({
   name: RULE_NAME5,
   create(context) {
     const indexParamNames = [];
+    const isCreateOrCloneElementCall = eff.or(core.isCreateElementCall(context), core.isCloneElementCall(context));
     function isArrayIndex(node) {
       return node.type === types.AST_NODE_TYPES.Identifier && indexParamNames.some(eff.O.exists((name2) => name2 === node.name));
     }
-    function isCreateOrCloneElementCall(node) {
-      return core.isCreateElementCall(node, context) || core.isCloneElementCall(node, context);
-    }
     function getReportDescriptor(node) {
       if (isArrayIndex(node)) return [{ messageId: "noArrayIndexKey", node }];
       if (AST11__namespace.isOneOf([types.AST_NODE_TYPES.TemplateLiteral, types.AST_NODE_TYPES.BinaryExpression])(node)) {
@@ -537,7 +535,7 @@ var no_children_prop_default = createRule({
     return {
       JSXElement(node) {
         const initialScope = context.sourceCode.getScope(node);
-        const prop = JSX8__namespace.getProp(node.openingElement.attributes, "children", initialScope);
+        const prop = JSX7__namespace.getProp(node.openingElement.attributes, "children", initialScope);
         const reportDescriptor = eff.O.map(prop, (prop2) => ({ messageId: "noChildrenProp", node: prop2 }));
         eff.O.map(reportDescriptor, context.report);
       }
@@ -912,7 +910,7 @@ var no_context_provider_default = createRule({
     if (compareVersions.compare(version2, "19.0.0", "<")) return {};
     return {
       JSXElement(node) {
-        const elementName = JSX8__namespace.getElementName(node.openingElement);
+        const elementName = JSX7__namespace.getElementName(node.openingElement);
         if (!elementName.endsWith(".Provider")) return;
         context.report({
           messageId: "noContextProvider",
@@ -1009,7 +1007,7 @@ var RULE_FEATURES22 = [
   "CHK"
 ];
 function getName2(node) {
-  if (node.type === types.AST_NODE_TYPES.TSAsExpression) {
+  if (AST11__namespace.isTypeExpression(node)) {
     return getName2(node.expression);
   }
   if (node.type === types.AST_NODE_TYPES.Identifier || node.type === types.AST_NODE_TYPES.PrivateIdentifier) {
@@ -1123,116 +1121,61 @@ var no_duplicate_key_default = createRule({
   },
   name: RULE_NAME24,
   create(context) {
-    const isWithinChildrenToArrayRef = eff.MutRef.make(false);
-    function isKeyEqual(a, b) {
-      return VAR__namespace.isNodeValueEqual(a, b, [context.sourceCode.getScope(a), context.sourceCode.getScope(b)]);
-    }
-    function checkIteratorElement(node) {
-      if (node.type !== types.AST_NODE_TYPES.JSXElement) return eff.O.none();
-      const initialScope = context.sourceCode.getScope(node);
-      return eff.F.pipe(
-        JSX8__namespace.findPropInAttributes(node.openingElement.attributes, initialScope)("key"),
-        eff.O.flatMap((k) => "value" in k ? eff.O.fromNullable(k.value) : eff.O.none()),
-        eff.O.flatMap((v) => {
-          return isKeyEqual(v, v) ? eff.O.some({
-            messageId: "noDuplicateKey",
-            node: v,
-            data: {
-              value: context.sourceCode.getText(v)
-            }
-          }) : eff.O.none();
-        })
-      );
-    }
-    function checkExpression(node) {
-      switch (node.type) {
-        case types.AST_NODE_TYPES.ConditionalExpression:
-          if (!("consequent" in node)) return eff.O.none();
-          return eff.F.pipe(
-            checkIteratorElement(node.consequent),
-            eff.O.orElse(() => checkIteratorElement(node.alternate))
-          );
-        case types.AST_NODE_TYPES.JSXElement:
-        case types.AST_NODE_TYPES.JSXFragment:
-          return checkIteratorElement(node);
-        case types.AST_NODE_TYPES.LogicalExpression:
-          if (!("left" in node)) return eff.O.none();
-          return eff.F.pipe(
-            checkIteratorElement(node.left),
-            eff.O.orElse(() => checkIteratorElement(node.right))
-          );
-        default:
-          return eff.O.none();
-      }
-    }
-    function checkBlockStatement(node) {
-      return AST11__namespace.getNestedReturnStatements(node).reduce((acc, statement) => {
-        if (!statement.argument) return acc;
-        const maybeDescriptor = checkIteratorElement(statement.argument);
-        if (eff.O.isNone(maybeDescriptor)) return acc;
-        const descriptor = maybeDescriptor.value;
-        return [...acc, descriptor];
-      }, []);
+    if (!context.sourceCode.getText().includes("key=")) return {};
+    const keyedEntries = /* @__PURE__ */ new Map();
+    function isKeyValueEqual(a, b) {
+      const aValue = a.value;
+      const bValue = b.value;
+      if (aValue === null || bValue === null) return false;
+      return AST11__namespace.isNodeEqual(aValue, bValue);
     }
-    const seen = /* @__PURE__ */ new WeakSet();
     return {
-      "ArrayExpression, JSXElement > JSXElement"(node) {
-        if (eff.MutRef.get(isWithinChildrenToArrayRef)) return;
-        const elements = tsPattern.match(node).with({ type: types.AST_NODE_TYPES.ArrayExpression }, ({ elements: elements2 }) => elements2).with({ type: types.AST_NODE_TYPES.JSXElement }, ({ parent }) => "children" in parent ? parent.children : []).otherwise(() => []).filter(AST11__namespace.is(types.AST_NODE_TYPES.JSXElement)).filter((element) => !seen.has(element));
-        const keys = elements.reduce(
-          (acc, element) => {
-            const attr = element.openingElement.attributes.findLast((attr2) => {
-              if (attr2.type !== types.AST_NODE_TYPES.JSXAttribute) return false;
-              return attr2.name.name === "key";
+      "JSXAttribute[name.name='key']"(node) {
+        const jsxElement = node.parent.parent;
+        switch (jsxElement.parent.type) {
+          case types.AST_NODE_TYPES.ArrayExpression:
+          case types.AST_NODE_TYPES.JSXElement:
+          case types.AST_NODE_TYPES.JSXFragment: {
+            const root = jsxElement.parent;
+            const prevKeys = keyedEntries.get(root)?.keys ?? [];
+            keyedEntries.set(root, {
+              hasDuplicate: prevKeys.some((prevKey) => isKeyValueEqual(prevKey, node)),
+              keys: [...prevKeys, node],
+              root: jsxElement.parent
             });
-            if (!attr || !("value" in attr) || attr.value === null) return acc;
-            const { value } = attr;
-            if (acc.length === 0) return [[element, attr, value]];
-            if (acc.some(([_, _1, v]) => isKeyEqual(v, value))) {
-              return [...acc, [element, attr, value]];
-            }
-            return acc;
-          },
-          []
-        );
-        if (keys.length < 2) return;
-        for (const [element, attr, value] of keys) {
-          seen.add(element);
-          context.report({
-            messageId: "noDuplicateKey",
-            node: attr,
-            data: {
-              value: context.sourceCode.getText(value)
+            break;
+          }
+          default: {
+            const entry = eff.F.pipe(
+              eff.O.Do,
+              eff.O.bind("call", () => AST11__namespace.traverseUpGuard(jsxElement, AST11__namespace.isMapCallLoose)),
+              eff.O.bind("iter", ({ call }) => AST11__namespace.traverseUpStop(jsxElement, call, AST11__namespace.isFunction)),
+              eff.O.bind("arg0", ({ call }) => eff.O.fromNullable(call.arguments[0]))
+            );
+            for (const { arg0, call, iter } of eff.O.toArray(entry)) {
+              if (AST11__namespace.unwrapTypeExpression(arg0) !== iter) continue;
+              keyedEntries.set(call, {
+                hasDuplicate: node.value?.type === types.AST_NODE_TYPES.Literal,
+                keys: [node],
+                root: call
+              });
             }
-          });
+          }
         }
       },
-      CallExpression(node) {
-        if (core.isChildrenToArrayCall(node, context)) eff.MutRef.set(isWithinChildrenToArrayRef, true);
-        const isMapCall = AST11__namespace.isMapCallLoose(node);
-        const isArrayFromCall = tsPattern.isMatching({
-          type: types.AST_NODE_TYPES.CallExpression,
-          callee: {
-            type: types.AST_NODE_TYPES.MemberExpression,
-            property: {
-              name: "from"
-            }
-          }
-        }, node);
-        if (!isMapCall && !isArrayFromCall) return;
-        if (eff.MutRef.get(isWithinChildrenToArrayRef)) return;
-        const fn = node.arguments[isMapCall ? 0 : 1];
-        if (!AST11__namespace.isOneOf([types.AST_NODE_TYPES.ArrowFunctionExpression, types.AST_NODE_TYPES.FunctionExpression])(fn)) return;
-        if (fn.body.type === types.AST_NODE_TYPES.BlockStatement) {
-          for (const descriptor of checkBlockStatement(fn.body)) {
-            context.report(descriptor);
+      "Program:exit"() {
+        for (const { hasDuplicate, keys } of keyedEntries.values()) {
+          if (!hasDuplicate) continue;
+          for (const key of keys) {
+            context.report({
+              messageId: "noDuplicateKey",
+              node: key,
+              data: {
+                value: context.sourceCode.getText(key)
+              }
+            });
           }
-          return;
         }
-        eff.O.map(checkExpression(fn.body), context.report);
-      },
-      "CallExpression:exit"(node) {
-        if (core.isChildrenToArrayCall(node, context)) eff.MutRef.set(isWithinChildrenToArrayRef, false);
       }
     };
   },
@@ -1355,7 +1298,7 @@ var no_implicit_key_default = createRule({
   create(context) {
     function getReportDescriptor(node) {
       const initialScope = context.sourceCode.getScope(node);
-      const keyPropFound = JSX8__namespace.findPropInAttributes(node.attributes, initialScope)("key");
+      const keyPropFound = JSX7__namespace.findPropInAttributes(node.attributes, initialScope)("key");
       const keyPropOnElement = node.attributes.some(
         (n) => AST11__namespace.is(types.AST_NODE_TYPES.JSXAttribute)(n) && n.name.name === "key"
       );
@@ -1595,12 +1538,12 @@ var no_missing_key_default = createRule({
   },
   name: RULE_NAME29,
   create(context) {
-    const isWithinChildrenToArrayRef = eff.MutRef.make(false);
+    const state = { isWithinChildrenToArray: false };
     function checkIteratorElement(node) {
       switch (node.type) {
         case types.AST_NODE_TYPES.JSXElement: {
           const initialScope = context.sourceCode.getScope(node);
-          if (!JSX8__namespace.hasProp(node.openingElement.attributes, "key", initialScope)) {
+          if (!JSX7__namespace.hasProp(node.openingElement.attributes, "key", initialScope)) {
             return eff.O.some({
               messageId: "noMissingKey",
               node
@@ -1644,12 +1587,12 @@ var no_missing_key_default = createRule({
     }
     return {
       ArrayExpression(node) {
-        if (eff.MutRef.get(isWithinChildrenToArrayRef)) return;
+        if (state.isWithinChildrenToArray) return;
         const elements = node.elements.filter(AST11__namespace.is(types.AST_NODE_TYPES.JSXElement));
         if (elements.length === 0) return;
         const initialScope = context.sourceCode.getScope(node);
         for (const element of elements) {
-          if (!JSX8__namespace.hasProp(element.openingElement.attributes, "key", initialScope)) {
+          if (!JSX7__namespace.hasProp(element.openingElement.attributes, "key", initialScope)) {
             context.report({
               messageId: "noMissingKey",
               node: element
@@ -1658,7 +1601,8 @@ var no_missing_key_default = createRule({
         }
       },
       CallExpression(node) {
-        if (core.isChildrenToArrayCall(node, context)) eff.MutRef.set(isWithinChildrenToArrayRef, true);
+        state.isWithinChildrenToArray ||= core.isChildrenToArrayCall(node, context);
+        if (state.isWithinChildrenToArray) return;
         const isMapCall = AST11__namespace.isMapCallLoose(node);
         const isArrayFromCall = tsPattern.isMatching({
           type: types.AST_NODE_TYPES.CallExpression,
@@ -1670,7 +1614,6 @@ var no_missing_key_default = createRule({
           }
         }, node);
         if (!isMapCall && !isArrayFromCall) return;
-        if (eff.MutRef.get(isWithinChildrenToArrayRef)) return;
         const fn = node.arguments[isMapCall ? 0 : 1];
         if (!AST11__namespace.isOneOf([types.AST_NODE_TYPES.ArrowFunctionExpression, types.AST_NODE_TYPES.FunctionExpression])(fn)) return;
         if (fn.body.type === types.AST_NODE_TYPES.BlockStatement) {
@@ -1682,10 +1625,11 @@ var no_missing_key_default = createRule({
         eff.O.map(checkExpression(fn.body), context.report);
       },
       "CallExpression:exit"(node) {
-        if (core.isChildrenToArrayCall(node, context)) eff.MutRef.set(isWithinChildrenToArrayRef, false);
+        if (!core.isChildrenToArrayCall(node, context)) return;
+        state.isWithinChildrenToArray = false;
       },
       JSXFragment(node) {
-        if (eff.MutRef.get(isWithinChildrenToArrayRef)) return;
+        if (state.isWithinChildrenToArray) return;
         if (node.parent.type === types.AST_NODE_TYPES.ArrayExpression) {
           context.report({
             messageId: "noMissingKeyWithFragment",
@@ -1736,7 +1680,7 @@ var no_nested_components_default = createRule({
           if (eff.O.isNone(componentName)) continue;
           const name2 = componentName.value;
           const isInsideProperty = component.parent.type === types.AST_NODE_TYPES.Property;
-          const isInsideJSXPropValue = component.parent.type === types.AST_NODE_TYPES.JSXAttribute || eff.O.isSome(JSX8__namespace.traverseUpProp(node, (n) => n.value?.type === types.AST_NODE_TYPES.JSXExpressionContainer));
+          const isInsideJSXPropValue = component.parent.type === types.AST_NODE_TYPES.JSXAttribute || eff.O.isSome(JSX7__namespace.traverseUpProp(node, (n) => n.value?.type === types.AST_NODE_TYPES.JSXExpressionContainer));
           if (isInsideJSXPropValue) {
             if (!core.isDeclaredInRenderPropLoose(component)) {
               context.report({
@@ -1782,7 +1726,7 @@ var no_nested_components_default = createRule({
           }
         }
         for (const { name: name2, node: component } of classComponents) {
-          if (eff.O.isNone(AST11__namespace.traverseUp(component, (node2) => isClassComponent11(node2) || isFunctionComponent(node2)))) {
+          if (eff.O.isNone(AST11__namespace.traverseUp(component, eff.or(isClassComponent11, isFunctionComponent)))) {
             continue;
           }
           context.report({
@@ -1912,22 +1856,25 @@ var no_set_state_in_component_did_mount_default = createRule({
     if (!context.sourceCode.text.includes("componentDidMount")) return {};
     function getReportDescriptor(node) {
       if (!core.isThisSetState(node)) return eff.O.none();
-      const maybeParentClass = AST11__namespace.traverseUp(
-        node,
-        AST11__namespace.isOneOf([types.AST_NODE_TYPES.ClassDeclaration, types.AST_NODE_TYPES.ClassExpression])
+      return eff.F.pipe(
+        eff.O.Do,
+        eff.O.bind("clazz", () => AST11__namespace.traverseUpGuard(node, core.isClassComponent)),
+        eff.O.bind("method", ({ clazz }) => AST11__namespace.traverseUpStop(node, clazz, isComponentDidMount)),
+        eff.O.bind("methodScope", ({ method }) => eff.O.some(context.sourceCode.getScope(method))),
+        eff.O.bind("upperScope", () => eff.O.fromNullable(context.sourceCode.getScope(node).upper)),
+        eff.O.filter(
+          ({
+            clazz,
+            method,
+            methodScope,
+            upperScope
+          }) => method.parent === clazz.body && upperScope === methodScope
+        ),
+        eff.O.map(() => ({
+          messageId: "noSetStateInComponentDidMount",
+          node
+        }))
       );
-      if (eff.O.isNone(maybeParentClass)) return eff.O.none();
-      const parentClass = maybeParentClass.value;
-      if (!core.isClassComponent(parentClass)) return eff.O.none();
-      const maybeParentMethod = AST11__namespace.traverseUp(node, isComponentDidMount);
-      if (eff.O.isNone(maybeParentMethod)) return eff.O.none();
-      const parentMethod = maybeParentMethod.value;
-      if (parentMethod.parent !== parentClass.body) return eff.O.none();
-      if (context.sourceCode.getScope(node).upper !== context.sourceCode.getScope(parentMethod)) return eff.O.none();
-      return eff.O.some({
-        messageId: "noSetStateInComponentDidMount",
-        node
-      });
     }
     return {
       CallExpression: eff.F.flow(getReportDescriptor, eff.O.map(context.report))
@@ -1959,22 +1906,19 @@ var no_set_state_in_component_did_update_default = createRule({
     if (!context.sourceCode.text.includes("componentDidUpdate")) return {};
     function getReportDescriptor(node) {
       if (!core.isThisSetState(node)) return eff.O.none();
-      const maybeParentClass = AST11__namespace.traverseUp(
-        node,
-        AST11__namespace.isOneOf([types.AST_NODE_TYPES.ClassDeclaration, types.AST_NODE_TYPES.ClassExpression])
+      return eff.F.pipe(
+        eff.O.Do,
+        eff.O.bind("clazz", () => AST11__namespace.traverseUpGuard(node, core.isClassComponent)),
+        eff.O.bind("method", ({ clazz }) => AST11__namespace.traverseUpStop(node, clazz, isComponentDidUpdate)),
+        eff.O.bind("upperScope", () => eff.O.fromNullable(context.sourceCode.getScope(node).upper)),
+        eff.O.filter(
+          ({ clazz, method, upperScope }) => method.parent === clazz.body && upperScope === context.sourceCode.getScope(method)
+        ),
+        eff.O.map(() => ({
+          messageId: "noSetStateInComponentDidUpdate",
+          node
+        }))
       );
-      if (eff.O.isNone(maybeParentClass)) return eff.O.none();
-      const parentClass = maybeParentClass.value;
-      if (!core.isClassComponent(parentClass)) return eff.O.none();
-      const maybeParentMethod = AST11__namespace.traverseUp(node, isComponentDidUpdate);
-      if (eff.O.isNone(maybeParentMethod)) return eff.O.none();
-      const parentMethod = maybeParentMethod.value;
-      if (parentMethod.parent !== parentClass.body) return eff.O.none();
-      if (context.sourceCode.getScope(node).upper !== context.sourceCode.getScope(parentMethod)) return eff.O.none();
-      return eff.O.some({
-        messageId: "noSetStateInComponentDidUpdate",
-        node
-      });
     }
     return {
       CallExpression: eff.F.flow(getReportDescriptor, eff.O.map(context.report))
@@ -2006,22 +1950,19 @@ var no_set_state_in_component_will_update_default = createRule({
     if (!context.sourceCode.text.includes("componentWillUpdate")) return {};
     function getReportDescriptor(node) {
       if (!core.isThisSetState(node)) return eff.O.none();
-      const maybeParentClass = AST11__namespace.traverseUp(
-        node,
-        AST11__namespace.isOneOf([types.AST_NODE_TYPES.ClassDeclaration, types.AST_NODE_TYPES.ClassExpression])
+      return eff.F.pipe(
+        eff.O.Do,
+        eff.O.bind("clazz", () => AST11__namespace.traverseUpGuard(node, core.isClassComponent)),
+        eff.O.bind("method", ({ clazz }) => AST11__namespace.traverseUpStop(node, clazz, isComponentWillUpdate3)),
+        eff.O.bind("upperScope", () => eff.O.fromNullable(context.sourceCode.getScope(node).upper)),
+        eff.O.filter(
+          ({ clazz, method, upperScope }) => method.parent === clazz.body && upperScope === context.sourceCode.getScope(method)
+        ),
+        eff.O.map(() => ({
+          messageId: "noSetStateInComponentWillUpdate",
+          node
+        }))
       );
-      if (eff.O.isNone(maybeParentClass)) return eff.O.none();
-      const parentClass = maybeParentClass.value;
-      if (!core.isClassComponent(parentClass)) return eff.O.none();
-      const maybeParentMethod = AST11__namespace.traverseUp(node, isComponentWillUpdate3);
-      if (eff.O.isNone(maybeParentMethod)) return eff.O.none();
-      const parentMethod = maybeParentMethod.value;
-      if (parentMethod.parent !== parentClass.body) return eff.O.none();
-      if (context.sourceCode.getScope(node).upper !== context.sourceCode.getScope(parentMethod)) return eff.O.none();
-      return eff.O.some({
-        messageId: "noSetStateInComponentWillUpdate",
-        node
-      });
     }
     return {
       CallExpression: eff.F.flow(getReportDescriptor, eff.O.map(context.report))
@@ -2219,39 +2160,40 @@ var no_unstable_context_value_default = createRule({
   name: RULE_NAME40,
   create(context) {
     const { ctx, listeners } = core.useComponentCollector(context);
-    const possibleValueConstructions = /* @__PURE__ */ new Map();
+    const constructions = /* @__PURE__ */ new Map();
     return {
       ...listeners,
       JSXOpeningElement(node) {
         const openingElementName = node.name;
         if (openingElementName.type !== types.AST_NODE_TYPES.JSXMemberExpression) return;
         if (openingElementName.property.name !== "Provider") return;
-        const maybeJSXValueAttribute = eff.O.fromNullable(
-          node.attributes.find((attribute) => {
-            return attribute.type === types.AST_NODE_TYPES.JSXAttribute && attribute.name.name === "value";
-          })
+        const constructionEntry = eff.F.pipe(
+          eff.O.Do,
+          eff.O.bind("function", ctx.getCurrentFunction),
+          eff.O.bind("attribute", () => eff.O.fromNullable(
+            node.attributes.find((attribute) => {
+              return attribute.type === types.AST_NODE_TYPES.JSXAttribute && attribute.name.name === "value";
+            })
+          )),
+          eff.O.bind("value", ({ attribute }) => "value" in attribute ? eff.O.some(attribute.value) : eff.O.none()),
+          eff.O.bind("valueExpression", ({ value }) => value?.type === types.AST_NODE_TYPES.JSXExpressionContainer ? eff.O.some(value.expression) : eff.O.none()),
+          eff.O.bind("construction", ({ valueExpression }) => {
+            const initialScope = context.sourceCode.getScope(valueExpression);
+            return eff.O.some(VAR__namespace.inspectConstruction(valueExpression, initialScope));
+          }),
+          eff.O.filter(({ construction }) => construction._tag !== "None")
         );
-        if (eff.O.isNone(maybeJSXValueAttribute) || !("value" in maybeJSXValueAttribute.value)) return;
-        const valueNode = maybeJSXValueAttribute.value.value;
-        if (valueNode?.type !== types.AST_NODE_TYPES.JSXExpressionContainer) return;
-        const valueExpression = valueNode.expression;
-        const initialScope = context.sourceCode.getScope(valueExpression);
-        const construction = VAR__namespace.inspectConstruction(valueExpression, initialScope);
-        if (construction._tag === "None") return;
-        eff.O.map(
-          ctx.getCurrentFunction(),
-          ([_, currentFn]) => possibleValueConstructions.set(currentFn, [
-            ...possibleValueConstructions.get(currentFn) ?? [],
+        for (const { construction, function: [_, fNode] } of eff.O.toArray(constructionEntry)) {
+          constructions.set(fNode, [
+            ...constructions.get(fNode) ?? [],
             construction
-          ])
-        );
+          ]);
+        }
       },
       "Program:exit"(node) {
         const components = ctx.getAllComponents(node).values();
         for (const { node: component } of components) {
-          const constructions = possibleValueConstructions.get(component);
-          if (!constructions) continue;
-          for (const construction of constructions) {
+          for (const construction of constructions.get(component) ?? []) {
             if (construction._tag === "None") continue;
             const { node: constructionNode, _tag } = construction;
             const messageId = _tag.startsWith("Function") ? "noUnstableContextValueWithFunction" : "noUnstableContextValueWithIdentifier";
@@ -2288,7 +2230,7 @@ var no_unstable_default_props_default = createRule({
   name: RULE_NAME41,
   create(context) {
     const { ctx, listeners } = core.useComponentCollector(context);
-    const possibleDestructuringDeclarators = /* @__PURE__ */ new WeakMap();
+    const declarators = /* @__PURE__ */ new WeakMap();
     return {
       ...listeners,
       "Program:exit"(node) {
@@ -2298,10 +2240,7 @@ var no_unstable_default_props_default = createRule({
           const [props] = params;
           if (!props) continue;
           const properties = tsPattern.match(props).with({ type: types.AST_NODE_TYPES.ObjectPattern }, ({ properties: properties2 }) => properties2).with({ type: types.AST_NODE_TYPES.Identifier }, ({ name: name2 }) => {
-            const variableDeclarators = possibleDestructuringDeclarators.get(component);
-            if (!variableDeclarators) return [];
-            const declarators = variableDeclarators.filter((d) => d.init.name === name2);
-            return declarators.flatMap((d) => d.id.properties);
+            return declarators.get(component)?.filter((d) => d.init.name === name2).flatMap((d) => d.id.properties) ?? [];
           }).otherwise(() => []);
           for (const prop of properties) {
             if (prop.type !== types.AST_NODE_TYPES.Property || prop.value.type !== types.AST_NODE_TYPES.AssignmentPattern) continue;
@@ -2326,13 +2265,10 @@ var no_unstable_default_props_default = createRule({
         }
       },
       "VariableDeclarator[id.type='ObjectPattern'][init.type='Identifier']"(node) {
-        eff.O.map(
-          ctx.getCurrentFunction(),
-          ([_, currentFn]) => possibleDestructuringDeclarators.set(currentFn, [
-            ...possibleDestructuringDeclarators.get(currentFn) ?? [],
-            node
-          ])
-        );
+        for (const [_, currentFn] of eff.O.toArray(ctx.getCurrentFunction())) {
+          const prevDeclarators = declarators.get(currentFn) ?? [];
+          declarators.set(currentFn, [...prevDeclarators, node]);
+        }
       }
     };
   },
@@ -2360,7 +2296,7 @@ var LIFECYCLE_METHODS = /* @__PURE__ */ new Set([
   "UNSAFE_componentWillUpdate"
 ]);
 function getName3(node) {
-  if (node.type === types.AST_NODE_TYPES.TSAsExpression) {
+  if (AST11__namespace.isTypeExpression(node)) {
     return getName3(node.expression);
   }
   if (node.type === types.AST_NODE_TYPES.Identifier || node.type === types.AST_NODE_TYPES.PrivateIdentifier) {
@@ -2460,7 +2396,9 @@ var no_unused_class_component_members_default = createRule({
         if (node.init && AST11__namespace.isThisExpression(node.init) && node.id.type === types.AST_NODE_TYPES.ObjectPattern) {
           for (const prop of node.id.properties) {
             if (prop.type === types.AST_NODE_TYPES.Property && AST11__namespace.isKeyLiteralLike(prop, prop.key)) {
-              eff.O.map(getName3(prop.key), (name2) => propertyUsages.get(currentClass)?.add(name2));
+              for (const name2 of eff.O.toArray(getName3(prop.key))) {
+                propertyUsages.get(currentClass)?.add(name2);
+              }
             }
           }
         }
@@ -2474,7 +2412,7 @@ var RULE_FEATURES43 = [
   "CHK"
 ];
 function getName4(node) {
-  if (node.type === types.AST_NODE_TYPES.TSAsExpression) {
+  if (AST11__namespace.isTypeExpression(node)) {
     return getName4(node.expression);
   }
   if (node.type === types.AST_NODE_TYPES.Identifier || node.type === types.AST_NODE_TYPES.PrivateIdentifier) {
@@ -2617,18 +2555,18 @@ var no_unused_state_default = createRule({
 var RULE_NAME44 = "no-useless-fragment";
 function check(node, context, allowExpressions) {
   const initialScope = context.sourceCode.getScope(node);
-  if (JSX8__namespace.isKeyedElement(node, initialScope)) return;
-  if (JSX8__namespace.isBuiltInElement(node.parent)) context.report({ messageId: "noUselessFragmentInBuiltIn", node });
+  if (JSX7__namespace.isKeyedElement(node, initialScope)) return;
+  if (JSX7__namespace.isBuiltInElement(node.parent)) context.report({ messageId: "noUselessFragmentInBuiltIn", node });
   if (node.children.length === 0) return context.report({ messageId: "noUselessFragment", node });
   const isChildren = AST11__namespace.isOneOf([types.AST_NODE_TYPES.JSXElement, types.AST_NODE_TYPES.JSXFragment])(node.parent);
   const [firstChildren] = node.children;
-  if (allowExpressions && node.children.length === 1 && JSX8__namespace.isLiteral(firstChildren) && !isChildren) return;
+  if (allowExpressions && node.children.length === 1 && JSX7__namespace.isLiteral(firstChildren) && !isChildren) return;
   if (!allowExpressions && isChildren) {
     return context.report({ messageId: "noUselessFragment", node });
   } else if (!allowExpressions && !isChildren && node.children.length === 1) {
     return context.report({ messageId: "noUselessFragment", node });
   }
-  const nonPaddingChildren = node.children.filter((child) => !JSX8__namespace.isPaddingSpaces(child));
+  const nonPaddingChildren = node.children.filter((child) => !JSX7__namespace.isPaddingSpaces(child));
   if (nonPaddingChildren.length > 1) return;
   if (nonPaddingChildren.length === 0) return context.report({ messageId: "noUselessFragment", node });
   const [first] = nonPaddingChildren;
@@ -2870,7 +2808,7 @@ var prefer_shorthand_boolean_default = createRule({
   create(context) {
     function getReportDescriptor(node) {
       const { value } = node;
-      const propName = JSX8__namespace.getPropName(node);
+      const propName = JSX7__namespace.getPropName(node);
       const hasValueTrue = value?.type === types.AST_NODE_TYPES.JSXExpressionContainer && value.expression.type === types.AST_NODE_TYPES.Literal && value.expression.value === true;
       if (!hasValueTrue) return eff.O.none();
       return eff.O.some({
@@ -2927,10 +2865,8 @@ var use_jsx_vars_default = createRule({
   meta: {
     type: "problem",
     docs: {
-      description: (
-        // eslint-disable-next-line eslint-plugin/require-meta-docs-description
-        "helpes `eslint/no-unused-vars` to correctly mark JSX variables as used."
-      ),
+      // eslint-disable-next-line eslint-plugin/require-meta-docs-description
+      description: "helpes `eslint/no-unused-vars` to correctly mark JSX variables as used.",
       [Symbol.for("rule_features")]: RULE_FEATURES49
     },
     messages: {
@@ -2953,9 +2889,9 @@ var use_jsx_vars_default = createRule({
     return {
       JSXOpeningElement(node) {
         if (node.name.type === types.AST_NODE_TYPES.JSXIdentifier && /^[a-z]/u.test(node.name.name)) return;
-        eff.O.map(getName5(node.name), (name2) => {
+        for (const name2 of eff.O.toArray(getName5(node.name))) {
           context.sourceCode.markVariableAsUsed(name2, node);
-        });
+        }
       }
     };
   },

package/dist/index.mjs CHANGED Viewed

@@ -1,8 +1,8 @@
-import { F, O, isString, MutRef, isNullable } from '@eslint-react/eff';
-import * as JSX8 from '@eslint-react/jsx';
+import { F, O, or, isString, isNullable } from '@eslint-react/eff';
+import * as JSX7 from '@eslint-react/jsx';
 import { createRuleForPlugin, normalizeSettings, decodeSettings, unsafeReadSettings } from '@eslint-react/shared';
 import * as AST11 from '@eslint-react/ast';
-import { isForwardRefCall, isThisSetState, isClassComponent, isChildrenCount, isChildrenForEach, isChildrenMap, isChildrenOnly, isChildrenToArray, useComponentCollectorLegacy, isCloneElementCall, isCreateRefCall, isComponentName, isChildrenToArrayCall, useComponentCollector, ERFunctionComponentFlag, ERComponentHint, isDirectValueOfRenderPropertyLoose, isDeclaredInRenderPropLoose, isInsideCreateElementProps, isInsideRenderMethod, ERClassComponentFlag, isFragmentElement, isCreateElementCall, isInitializedFromReact } from '@eslint-react/core';
+import { isForwardRefCall, isThisSetState, isClassComponent, isCreateElementCall, isCloneElementCall, isChildrenCount, isChildrenForEach, isChildrenMap, isChildrenOnly, isChildrenToArray, useComponentCollectorLegacy, isCreateRefCall, isComponentName, useComponentCollector, ERFunctionComponentFlag, isChildrenToArrayCall, ERComponentHint, isDirectValueOfRenderPropertyLoose, isDeclaredInRenderPropLoose, isInsideCreateElementProps, isInsideRenderMethod, ERClassComponentFlag, isFragmentElement, isInitializedFromReact } from '@eslint-react/core';
 import { AST_NODE_TYPES } from '@typescript-eslint/types';
 import { isMatching, P, match } from 'ts-pattern';
 import { compare } from 'compare-versions';
@@ -15,7 +15,7 @@ import { getTypeImmutability, isUnknown, isImmutable, isReadonlyShallow, isReado
 // package.json
 var name = "eslint-plugin-react-x";
-var version = "1.22.2-next.1";
+var version = "1.22.2-next.11";
 var createRule = createRuleForPlugin("x");
 // src/rules/avoid-shorthand-boolean.ts
@@ -43,7 +43,7 @@ var avoid_shorthand_boolean_default = createRule({
         messageId: "avoidShorthandBoolean",
         node,
         data: {
-          propName: JSX8.getPropName(node)
+          propName: JSX7.getPropName(node)
         },
         fix: (fixer) => fixer.insertTextAfter(node.name, `={true}`)
       });
@@ -124,7 +124,7 @@ var RULE_FEATURES4 = [
   "CHK"
 ];
 function getName(node) {
-  if (node.type === AST_NODE_TYPES.TSAsExpression) {
+  if (AST11.isTypeExpression(node)) {
     return getName(node.expression);
   }
   if (node.type === AST_NODE_TYPES.Identifier || node.type === AST_NODE_TYPES.PrivateIdentifier) {
@@ -300,12 +300,10 @@ var no_array_index_key_default = createRule({
   name: RULE_NAME5,
   create(context) {
     const indexParamNames = [];
+    const isCreateOrCloneElementCall = or(isCreateElementCall(context), isCloneElementCall(context));
     function isArrayIndex(node) {
       return node.type === AST_NODE_TYPES.Identifier && indexParamNames.some(O.exists((name2) => name2 === node.name));
     }
-    function isCreateOrCloneElementCall(node) {
-      return isCreateElementCall(node, context) || isCloneElementCall(node, context);
-    }
     function getReportDescriptor(node) {
       if (isArrayIndex(node)) return [{ messageId: "noArrayIndexKey", node }];
       if (AST11.isOneOf([AST_NODE_TYPES.TemplateLiteral, AST_NODE_TYPES.BinaryExpression])(node)) {
@@ -510,7 +508,7 @@ var no_children_prop_default = createRule({
     return {
       JSXElement(node) {
         const initialScope = context.sourceCode.getScope(node);
-        const prop = JSX8.getProp(node.openingElement.attributes, "children", initialScope);
+        const prop = JSX7.getProp(node.openingElement.attributes, "children", initialScope);
         const reportDescriptor = O.map(prop, (prop2) => ({ messageId: "noChildrenProp", node: prop2 }));
         O.map(reportDescriptor, context.report);
       }
@@ -885,7 +883,7 @@ var no_context_provider_default = createRule({
     if (compare(version2, "19.0.0", "<")) return {};
     return {
       JSXElement(node) {
-        const elementName = JSX8.getElementName(node.openingElement);
+        const elementName = JSX7.getElementName(node.openingElement);
         if (!elementName.endsWith(".Provider")) return;
         context.report({
           messageId: "noContextProvider",
@@ -982,7 +980,7 @@ var RULE_FEATURES22 = [
   "CHK"
 ];
 function getName2(node) {
-  if (node.type === AST_NODE_TYPES.TSAsExpression) {
+  if (AST11.isTypeExpression(node)) {
     return getName2(node.expression);
   }
   if (node.type === AST_NODE_TYPES.Identifier || node.type === AST_NODE_TYPES.PrivateIdentifier) {
@@ -1096,116 +1094,61 @@ var no_duplicate_key_default = createRule({
   },
   name: RULE_NAME24,
   create(context) {
-    const isWithinChildrenToArrayRef = MutRef.make(false);
-    function isKeyEqual(a, b) {
-      return VAR.isNodeValueEqual(a, b, [context.sourceCode.getScope(a), context.sourceCode.getScope(b)]);
-    }
-    function checkIteratorElement(node) {
-      if (node.type !== AST_NODE_TYPES.JSXElement) return O.none();
-      const initialScope = context.sourceCode.getScope(node);
-      return F.pipe(
-        JSX8.findPropInAttributes(node.openingElement.attributes, initialScope)("key"),
-        O.flatMap((k) => "value" in k ? O.fromNullable(k.value) : O.none()),
-        O.flatMap((v) => {
-          return isKeyEqual(v, v) ? O.some({
-            messageId: "noDuplicateKey",
-            node: v,
-            data: {
-              value: context.sourceCode.getText(v)
-            }
-          }) : O.none();
-        })
-      );
-    }
-    function checkExpression(node) {
-      switch (node.type) {
-        case AST_NODE_TYPES.ConditionalExpression:
-          if (!("consequent" in node)) return O.none();
-          return F.pipe(
-            checkIteratorElement(node.consequent),
-            O.orElse(() => checkIteratorElement(node.alternate))
-          );
-        case AST_NODE_TYPES.JSXElement:
-        case AST_NODE_TYPES.JSXFragment:
-          return checkIteratorElement(node);
-        case AST_NODE_TYPES.LogicalExpression:
-          if (!("left" in node)) return O.none();
-          return F.pipe(
-            checkIteratorElement(node.left),
-            O.orElse(() => checkIteratorElement(node.right))
-          );
-        default:
-          return O.none();
-      }
-    }
-    function checkBlockStatement(node) {
-      return AST11.getNestedReturnStatements(node).reduce((acc, statement) => {
-        if (!statement.argument) return acc;
-        const maybeDescriptor = checkIteratorElement(statement.argument);
-        if (O.isNone(maybeDescriptor)) return acc;
-        const descriptor = maybeDescriptor.value;
-        return [...acc, descriptor];
-      }, []);
+    if (!context.sourceCode.getText().includes("key=")) return {};
+    const keyedEntries = /* @__PURE__ */ new Map();
+    function isKeyValueEqual(a, b) {
+      const aValue = a.value;
+      const bValue = b.value;
+      if (aValue === null || bValue === null) return false;
+      return AST11.isNodeEqual(aValue, bValue);
     }
-    const seen = /* @__PURE__ */ new WeakSet();
     return {
-      "ArrayExpression, JSXElement > JSXElement"(node) {
-        if (MutRef.get(isWithinChildrenToArrayRef)) return;
-        const elements = match(node).with({ type: AST_NODE_TYPES.ArrayExpression }, ({ elements: elements2 }) => elements2).with({ type: AST_NODE_TYPES.JSXElement }, ({ parent }) => "children" in parent ? parent.children : []).otherwise(() => []).filter(AST11.is(AST_NODE_TYPES.JSXElement)).filter((element) => !seen.has(element));
-        const keys = elements.reduce(
-          (acc, element) => {
-            const attr = element.openingElement.attributes.findLast((attr2) => {
-              if (attr2.type !== AST_NODE_TYPES.JSXAttribute) return false;
-              return attr2.name.name === "key";
+      "JSXAttribute[name.name='key']"(node) {
+        const jsxElement = node.parent.parent;
+        switch (jsxElement.parent.type) {
+          case AST_NODE_TYPES.ArrayExpression:
+          case AST_NODE_TYPES.JSXElement:
+          case AST_NODE_TYPES.JSXFragment: {
+            const root = jsxElement.parent;
+            const prevKeys = keyedEntries.get(root)?.keys ?? [];
+            keyedEntries.set(root, {
+              hasDuplicate: prevKeys.some((prevKey) => isKeyValueEqual(prevKey, node)),
+              keys: [...prevKeys, node],
+              root: jsxElement.parent
             });
-            if (!attr || !("value" in attr) || attr.value === null) return acc;
-            const { value } = attr;
-            if (acc.length === 0) return [[element, attr, value]];
-            if (acc.some(([_, _1, v]) => isKeyEqual(v, value))) {
-              return [...acc, [element, attr, value]];
-            }
-            return acc;
-          },
-          []
-        );
-        if (keys.length < 2) return;
-        for (const [element, attr, value] of keys) {
-          seen.add(element);
-          context.report({
-            messageId: "noDuplicateKey",
-            node: attr,
-            data: {
-              value: context.sourceCode.getText(value)
+            break;
+          }
+          default: {
+            const entry = F.pipe(
+              O.Do,
+              O.bind("call", () => AST11.traverseUpGuard(jsxElement, AST11.isMapCallLoose)),
+              O.bind("iter", ({ call }) => AST11.traverseUpStop(jsxElement, call, AST11.isFunction)),
+              O.bind("arg0", ({ call }) => O.fromNullable(call.arguments[0]))
+            );
+            for (const { arg0, call, iter } of O.toArray(entry)) {
+              if (AST11.unwrapTypeExpression(arg0) !== iter) continue;
+              keyedEntries.set(call, {
+                hasDuplicate: node.value?.type === AST_NODE_TYPES.Literal,
+                keys: [node],
+                root: call
+              });
             }
-          });
+          }
         }
       },
-      CallExpression(node) {
-        if (isChildrenToArrayCall(node, context)) MutRef.set(isWithinChildrenToArrayRef, true);
-        const isMapCall = AST11.isMapCallLoose(node);
-        const isArrayFromCall = isMatching({
-          type: AST_NODE_TYPES.CallExpression,
-          callee: {
-            type: AST_NODE_TYPES.MemberExpression,
-            property: {
-              name: "from"
-            }
-          }
-        }, node);
-        if (!isMapCall && !isArrayFromCall) return;
-        if (MutRef.get(isWithinChildrenToArrayRef)) return;
-        const fn = node.arguments[isMapCall ? 0 : 1];
-        if (!AST11.isOneOf([AST_NODE_TYPES.ArrowFunctionExpression, AST_NODE_TYPES.FunctionExpression])(fn)) return;
-        if (fn.body.type === AST_NODE_TYPES.BlockStatement) {
-          for (const descriptor of checkBlockStatement(fn.body)) {
-            context.report(descriptor);
+      "Program:exit"() {
+        for (const { hasDuplicate, keys } of keyedEntries.values()) {
+          if (!hasDuplicate) continue;
+          for (const key of keys) {
+            context.report({
+              messageId: "noDuplicateKey",
+              node: key,
+              data: {
+                value: context.sourceCode.getText(key)
+              }
+            });
           }
-          return;
         }
-        O.map(checkExpression(fn.body), context.report);
-      },
-      "CallExpression:exit"(node) {
-        if (isChildrenToArrayCall(node, context)) MutRef.set(isWithinChildrenToArrayRef, false);
       }
     };
   },
@@ -1328,7 +1271,7 @@ var no_implicit_key_default = createRule({
   create(context) {
     function getReportDescriptor(node) {
       const initialScope = context.sourceCode.getScope(node);
-      const keyPropFound = JSX8.findPropInAttributes(node.attributes, initialScope)("key");
+      const keyPropFound = JSX7.findPropInAttributes(node.attributes, initialScope)("key");
       const keyPropOnElement = node.attributes.some(
         (n) => AST11.is(AST_NODE_TYPES.JSXAttribute)(n) && n.name.name === "key"
       );
@@ -1568,12 +1511,12 @@ var no_missing_key_default = createRule({
   },
   name: RULE_NAME29,
   create(context) {
-    const isWithinChildrenToArrayRef = MutRef.make(false);
+    const state = { isWithinChildrenToArray: false };
     function checkIteratorElement(node) {
       switch (node.type) {
         case AST_NODE_TYPES.JSXElement: {
           const initialScope = context.sourceCode.getScope(node);
-          if (!JSX8.hasProp(node.openingElement.attributes, "key", initialScope)) {
+          if (!JSX7.hasProp(node.openingElement.attributes, "key", initialScope)) {
             return O.some({
               messageId: "noMissingKey",
               node
@@ -1617,12 +1560,12 @@ var no_missing_key_default = createRule({
     }
     return {
       ArrayExpression(node) {
-        if (MutRef.get(isWithinChildrenToArrayRef)) return;
+        if (state.isWithinChildrenToArray) return;
         const elements = node.elements.filter(AST11.is(AST_NODE_TYPES.JSXElement));
         if (elements.length === 0) return;
         const initialScope = context.sourceCode.getScope(node);
         for (const element of elements) {
-          if (!JSX8.hasProp(element.openingElement.attributes, "key", initialScope)) {
+          if (!JSX7.hasProp(element.openingElement.attributes, "key", initialScope)) {
             context.report({
               messageId: "noMissingKey",
               node: element
@@ -1631,7 +1574,8 @@ var no_missing_key_default = createRule({
         }
       },
       CallExpression(node) {
-        if (isChildrenToArrayCall(node, context)) MutRef.set(isWithinChildrenToArrayRef, true);
+        state.isWithinChildrenToArray ||= isChildrenToArrayCall(node, context);
+        if (state.isWithinChildrenToArray) return;
         const isMapCall = AST11.isMapCallLoose(node);
         const isArrayFromCall = isMatching({
           type: AST_NODE_TYPES.CallExpression,
@@ -1643,7 +1587,6 @@ var no_missing_key_default = createRule({
           }
         }, node);
         if (!isMapCall && !isArrayFromCall) return;
-        if (MutRef.get(isWithinChildrenToArrayRef)) return;
         const fn = node.arguments[isMapCall ? 0 : 1];
         if (!AST11.isOneOf([AST_NODE_TYPES.ArrowFunctionExpression, AST_NODE_TYPES.FunctionExpression])(fn)) return;
         if (fn.body.type === AST_NODE_TYPES.BlockStatement) {
@@ -1655,10 +1598,11 @@ var no_missing_key_default = createRule({
         O.map(checkExpression(fn.body), context.report);
       },
       "CallExpression:exit"(node) {
-        if (isChildrenToArrayCall(node, context)) MutRef.set(isWithinChildrenToArrayRef, false);
+        if (!isChildrenToArrayCall(node, context)) return;
+        state.isWithinChildrenToArray = false;
       },
       JSXFragment(node) {
-        if (MutRef.get(isWithinChildrenToArrayRef)) return;
+        if (state.isWithinChildrenToArray) return;
         if (node.parent.type === AST_NODE_TYPES.ArrayExpression) {
           context.report({
             messageId: "noMissingKeyWithFragment",
@@ -1709,7 +1653,7 @@ var no_nested_components_default = createRule({
           if (O.isNone(componentName)) continue;
           const name2 = componentName.value;
           const isInsideProperty = component.parent.type === AST_NODE_TYPES.Property;
-          const isInsideJSXPropValue = component.parent.type === AST_NODE_TYPES.JSXAttribute || O.isSome(JSX8.traverseUpProp(node, (n) => n.value?.type === AST_NODE_TYPES.JSXExpressionContainer));
+          const isInsideJSXPropValue = component.parent.type === AST_NODE_TYPES.JSXAttribute || O.isSome(JSX7.traverseUpProp(node, (n) => n.value?.type === AST_NODE_TYPES.JSXExpressionContainer));
           if (isInsideJSXPropValue) {
             if (!isDeclaredInRenderPropLoose(component)) {
               context.report({
@@ -1755,7 +1699,7 @@ var no_nested_components_default = createRule({
           }
         }
         for (const { name: name2, node: component } of classComponents) {
-          if (O.isNone(AST11.traverseUp(component, (node2) => isClassComponent11(node2) || isFunctionComponent(node2)))) {
+          if (O.isNone(AST11.traverseUp(component, or(isClassComponent11, isFunctionComponent)))) {
             continue;
           }
           context.report({
@@ -1885,22 +1829,25 @@ var no_set_state_in_component_did_mount_default = createRule({
     if (!context.sourceCode.text.includes("componentDidMount")) return {};
     function getReportDescriptor(node) {
       if (!isThisSetState(node)) return O.none();
-      const maybeParentClass = AST11.traverseUp(
-        node,
-        AST11.isOneOf([AST_NODE_TYPES.ClassDeclaration, AST_NODE_TYPES.ClassExpression])
+      return F.pipe(
+        O.Do,
+        O.bind("clazz", () => AST11.traverseUpGuard(node, isClassComponent)),
+        O.bind("method", ({ clazz }) => AST11.traverseUpStop(node, clazz, isComponentDidMount)),
+        O.bind("methodScope", ({ method }) => O.some(context.sourceCode.getScope(method))),
+        O.bind("upperScope", () => O.fromNullable(context.sourceCode.getScope(node).upper)),
+        O.filter(
+          ({
+            clazz,
+            method,
+            methodScope,
+            upperScope
+          }) => method.parent === clazz.body && upperScope === methodScope
+        ),
+        O.map(() => ({
+          messageId: "noSetStateInComponentDidMount",
+          node
+        }))
       );
-      if (O.isNone(maybeParentClass)) return O.none();
-      const parentClass = maybeParentClass.value;
-      if (!isClassComponent(parentClass)) return O.none();
-      const maybeParentMethod = AST11.traverseUp(node, isComponentDidMount);
-      if (O.isNone(maybeParentMethod)) return O.none();
-      const parentMethod = maybeParentMethod.value;
-      if (parentMethod.parent !== parentClass.body) return O.none();
-      if (context.sourceCode.getScope(node).upper !== context.sourceCode.getScope(parentMethod)) return O.none();
-      return O.some({
-        messageId: "noSetStateInComponentDidMount",
-        node
-      });
     }
     return {
       CallExpression: F.flow(getReportDescriptor, O.map(context.report))
@@ -1932,22 +1879,19 @@ var no_set_state_in_component_did_update_default = createRule({
     if (!context.sourceCode.text.includes("componentDidUpdate")) return {};
     function getReportDescriptor(node) {
       if (!isThisSetState(node)) return O.none();
-      const maybeParentClass = AST11.traverseUp(
-        node,
-        AST11.isOneOf([AST_NODE_TYPES.ClassDeclaration, AST_NODE_TYPES.ClassExpression])
+      return F.pipe(
+        O.Do,
+        O.bind("clazz", () => AST11.traverseUpGuard(node, isClassComponent)),
+        O.bind("method", ({ clazz }) => AST11.traverseUpStop(node, clazz, isComponentDidUpdate)),
+        O.bind("upperScope", () => O.fromNullable(context.sourceCode.getScope(node).upper)),
+        O.filter(
+          ({ clazz, method, upperScope }) => method.parent === clazz.body && upperScope === context.sourceCode.getScope(method)
+        ),
+        O.map(() => ({
+          messageId: "noSetStateInComponentDidUpdate",
+          node
+        }))
       );
-      if (O.isNone(maybeParentClass)) return O.none();
-      const parentClass = maybeParentClass.value;
-      if (!isClassComponent(parentClass)) return O.none();
-      const maybeParentMethod = AST11.traverseUp(node, isComponentDidUpdate);
-      if (O.isNone(maybeParentMethod)) return O.none();
-      const parentMethod = maybeParentMethod.value;
-      if (parentMethod.parent !== parentClass.body) return O.none();
-      if (context.sourceCode.getScope(node).upper !== context.sourceCode.getScope(parentMethod)) return O.none();
-      return O.some({
-        messageId: "noSetStateInComponentDidUpdate",
-        node
-      });
     }
     return {
       CallExpression: F.flow(getReportDescriptor, O.map(context.report))
@@ -1979,22 +1923,19 @@ var no_set_state_in_component_will_update_default = createRule({
     if (!context.sourceCode.text.includes("componentWillUpdate")) return {};
     function getReportDescriptor(node) {
       if (!isThisSetState(node)) return O.none();
-      const maybeParentClass = AST11.traverseUp(
-        node,
-        AST11.isOneOf([AST_NODE_TYPES.ClassDeclaration, AST_NODE_TYPES.ClassExpression])
+      return F.pipe(
+        O.Do,
+        O.bind("clazz", () => AST11.traverseUpGuard(node, isClassComponent)),
+        O.bind("method", ({ clazz }) => AST11.traverseUpStop(node, clazz, isComponentWillUpdate3)),
+        O.bind("upperScope", () => O.fromNullable(context.sourceCode.getScope(node).upper)),
+        O.filter(
+          ({ clazz, method, upperScope }) => method.parent === clazz.body && upperScope === context.sourceCode.getScope(method)
+        ),
+        O.map(() => ({
+          messageId: "noSetStateInComponentWillUpdate",
+          node
+        }))
       );
-      if (O.isNone(maybeParentClass)) return O.none();
-      const parentClass = maybeParentClass.value;
-      if (!isClassComponent(parentClass)) return O.none();
-      const maybeParentMethod = AST11.traverseUp(node, isComponentWillUpdate3);
-      if (O.isNone(maybeParentMethod)) return O.none();
-      const parentMethod = maybeParentMethod.value;
-      if (parentMethod.parent !== parentClass.body) return O.none();
-      if (context.sourceCode.getScope(node).upper !== context.sourceCode.getScope(parentMethod)) return O.none();
-      return O.some({
-        messageId: "noSetStateInComponentWillUpdate",
-        node
-      });
     }
     return {
       CallExpression: F.flow(getReportDescriptor, O.map(context.report))
@@ -2192,39 +2133,40 @@ var no_unstable_context_value_default = createRule({
   name: RULE_NAME40,
   create(context) {
     const { ctx, listeners } = useComponentCollector(context);
-    const possibleValueConstructions = /* @__PURE__ */ new Map();
+    const constructions = /* @__PURE__ */ new Map();
     return {
       ...listeners,
       JSXOpeningElement(node) {
         const openingElementName = node.name;
         if (openingElementName.type !== AST_NODE_TYPES.JSXMemberExpression) return;
         if (openingElementName.property.name !== "Provider") return;
-        const maybeJSXValueAttribute = O.fromNullable(
-          node.attributes.find((attribute) => {
-            return attribute.type === AST_NODE_TYPES.JSXAttribute && attribute.name.name === "value";
-          })
+        const constructionEntry = F.pipe(
+          O.Do,
+          O.bind("function", ctx.getCurrentFunction),
+          O.bind("attribute", () => O.fromNullable(
+            node.attributes.find((attribute) => {
+              return attribute.type === AST_NODE_TYPES.JSXAttribute && attribute.name.name === "value";
+            })
+          )),
+          O.bind("value", ({ attribute }) => "value" in attribute ? O.some(attribute.value) : O.none()),
+          O.bind("valueExpression", ({ value }) => value?.type === AST_NODE_TYPES.JSXExpressionContainer ? O.some(value.expression) : O.none()),
+          O.bind("construction", ({ valueExpression }) => {
+            const initialScope = context.sourceCode.getScope(valueExpression);
+            return O.some(VAR.inspectConstruction(valueExpression, initialScope));
+          }),
+          O.filter(({ construction }) => construction._tag !== "None")
         );
-        if (O.isNone(maybeJSXValueAttribute) || !("value" in maybeJSXValueAttribute.value)) return;
-        const valueNode = maybeJSXValueAttribute.value.value;
-        if (valueNode?.type !== AST_NODE_TYPES.JSXExpressionContainer) return;
-        const valueExpression = valueNode.expression;
-        const initialScope = context.sourceCode.getScope(valueExpression);
-        const construction = VAR.inspectConstruction(valueExpression, initialScope);
-        if (construction._tag === "None") return;
-        O.map(
-          ctx.getCurrentFunction(),
-          ([_, currentFn]) => possibleValueConstructions.set(currentFn, [
-            ...possibleValueConstructions.get(currentFn) ?? [],
+        for (const { construction, function: [_, fNode] } of O.toArray(constructionEntry)) {
+          constructions.set(fNode, [
+            ...constructions.get(fNode) ?? [],
             construction
-          ])
-        );
+          ]);
+        }
       },
       "Program:exit"(node) {
         const components = ctx.getAllComponents(node).values();
         for (const { node: component } of components) {
-          const constructions = possibleValueConstructions.get(component);
-          if (!constructions) continue;
-          for (const construction of constructions) {
+          for (const construction of constructions.get(component) ?? []) {
             if (construction._tag === "None") continue;
             const { node: constructionNode, _tag } = construction;
             const messageId = _tag.startsWith("Function") ? "noUnstableContextValueWithFunction" : "noUnstableContextValueWithIdentifier";
@@ -2261,7 +2203,7 @@ var no_unstable_default_props_default = createRule({
   name: RULE_NAME41,
   create(context) {
     const { ctx, listeners } = useComponentCollector(context);
-    const possibleDestructuringDeclarators = /* @__PURE__ */ new WeakMap();
+    const declarators = /* @__PURE__ */ new WeakMap();
     return {
       ...listeners,
       "Program:exit"(node) {
@@ -2271,10 +2213,7 @@ var no_unstable_default_props_default = createRule({
           const [props] = params;
           if (!props) continue;
           const properties = match(props).with({ type: AST_NODE_TYPES.ObjectPattern }, ({ properties: properties2 }) => properties2).with({ type: AST_NODE_TYPES.Identifier }, ({ name: name2 }) => {
-            const variableDeclarators = possibleDestructuringDeclarators.get(component);
-            if (!variableDeclarators) return [];
-            const declarators = variableDeclarators.filter((d) => d.init.name === name2);
-            return declarators.flatMap((d) => d.id.properties);
+            return declarators.get(component)?.filter((d) => d.init.name === name2).flatMap((d) => d.id.properties) ?? [];
           }).otherwise(() => []);
           for (const prop of properties) {
             if (prop.type !== AST_NODE_TYPES.Property || prop.value.type !== AST_NODE_TYPES.AssignmentPattern) continue;
@@ -2299,13 +2238,10 @@ var no_unstable_default_props_default = createRule({
         }
       },
       "VariableDeclarator[id.type='ObjectPattern'][init.type='Identifier']"(node) {
-        O.map(
-          ctx.getCurrentFunction(),
-          ([_, currentFn]) => possibleDestructuringDeclarators.set(currentFn, [
-            ...possibleDestructuringDeclarators.get(currentFn) ?? [],
-            node
-          ])
-        );
+        for (const [_, currentFn] of O.toArray(ctx.getCurrentFunction())) {
+          const prevDeclarators = declarators.get(currentFn) ?? [];
+          declarators.set(currentFn, [...prevDeclarators, node]);
+        }
       }
     };
   },
@@ -2333,7 +2269,7 @@ var LIFECYCLE_METHODS = /* @__PURE__ */ new Set([
   "UNSAFE_componentWillUpdate"
 ]);
 function getName3(node) {
-  if (node.type === AST_NODE_TYPES.TSAsExpression) {
+  if (AST11.isTypeExpression(node)) {
     return getName3(node.expression);
   }
   if (node.type === AST_NODE_TYPES.Identifier || node.type === AST_NODE_TYPES.PrivateIdentifier) {
@@ -2433,7 +2369,9 @@ var no_unused_class_component_members_default = createRule({
         if (node.init && AST11.isThisExpression(node.init) && node.id.type === AST_NODE_TYPES.ObjectPattern) {
           for (const prop of node.id.properties) {
             if (prop.type === AST_NODE_TYPES.Property && AST11.isKeyLiteralLike(prop, prop.key)) {
-              O.map(getName3(prop.key), (name2) => propertyUsages.get(currentClass)?.add(name2));
+              for (const name2 of O.toArray(getName3(prop.key))) {
+                propertyUsages.get(currentClass)?.add(name2);
+              }
             }
           }
         }
@@ -2447,7 +2385,7 @@ var RULE_FEATURES43 = [
   "CHK"
 ];
 function getName4(node) {
-  if (node.type === AST_NODE_TYPES.TSAsExpression) {
+  if (AST11.isTypeExpression(node)) {
     return getName4(node.expression);
   }
   if (node.type === AST_NODE_TYPES.Identifier || node.type === AST_NODE_TYPES.PrivateIdentifier) {
@@ -2590,18 +2528,18 @@ var no_unused_state_default = createRule({
 var RULE_NAME44 = "no-useless-fragment";
 function check(node, context, allowExpressions) {
   const initialScope = context.sourceCode.getScope(node);
-  if (JSX8.isKeyedElement(node, initialScope)) return;
-  if (JSX8.isBuiltInElement(node.parent)) context.report({ messageId: "noUselessFragmentInBuiltIn", node });
+  if (JSX7.isKeyedElement(node, initialScope)) return;
+  if (JSX7.isBuiltInElement(node.parent)) context.report({ messageId: "noUselessFragmentInBuiltIn", node });
   if (node.children.length === 0) return context.report({ messageId: "noUselessFragment", node });
   const isChildren = AST11.isOneOf([AST_NODE_TYPES.JSXElement, AST_NODE_TYPES.JSXFragment])(node.parent);
   const [firstChildren] = node.children;
-  if (allowExpressions && node.children.length === 1 && JSX8.isLiteral(firstChildren) && !isChildren) return;
+  if (allowExpressions && node.children.length === 1 && JSX7.isLiteral(firstChildren) && !isChildren) return;
   if (!allowExpressions && isChildren) {
     return context.report({ messageId: "noUselessFragment", node });
   } else if (!allowExpressions && !isChildren && node.children.length === 1) {
     return context.report({ messageId: "noUselessFragment", node });
   }
-  const nonPaddingChildren = node.children.filter((child) => !JSX8.isPaddingSpaces(child));
+  const nonPaddingChildren = node.children.filter((child) => !JSX7.isPaddingSpaces(child));
   if (nonPaddingChildren.length > 1) return;
   if (nonPaddingChildren.length === 0) return context.report({ messageId: "noUselessFragment", node });
   const [first] = nonPaddingChildren;
@@ -2843,7 +2781,7 @@ var prefer_shorthand_boolean_default = createRule({
   create(context) {
     function getReportDescriptor(node) {
       const { value } = node;
-      const propName = JSX8.getPropName(node);
+      const propName = JSX7.getPropName(node);
       const hasValueTrue = value?.type === AST_NODE_TYPES.JSXExpressionContainer && value.expression.type === AST_NODE_TYPES.Literal && value.expression.value === true;
       if (!hasValueTrue) return O.none();
       return O.some({
@@ -2900,10 +2838,8 @@ var use_jsx_vars_default = createRule({
   meta: {
     type: "problem",
     docs: {
-      description: (
-        // eslint-disable-next-line eslint-plugin/require-meta-docs-description
-        "helpes `eslint/no-unused-vars` to correctly mark JSX variables as used."
-      ),
+      // eslint-disable-next-line eslint-plugin/require-meta-docs-description
+      description: "helpes `eslint/no-unused-vars` to correctly mark JSX variables as used.",
       [Symbol.for("rule_features")]: RULE_FEATURES49
     },
     messages: {
@@ -2926,9 +2862,9 @@ var use_jsx_vars_default = createRule({
     return {
       JSXOpeningElement(node) {
         if (node.name.type === AST_NODE_TYPES.JSXIdentifier && /^[a-z]/u.test(node.name.name)) return;
-        O.map(getName5(node.name), (name2) => {
+        for (const name2 of O.toArray(getName5(node.name))) {
           context.sourceCode.markVariableAsUsed(name2, node);
-        });
+        }
       }
     };
   },

package/package.json CHANGED Viewed

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-x",
-  "version": "1.22.2-next.1",
+  "version": "1.22.2-next.11",
   "description": "A set of composable ESLint rules for libraries and frameworks that use React as a UI runtime.",
   "keywords": [
     "react",
@@ -9,13 +9,13 @@
     "eslint-plugin",
     "eslint-plugin-react-x"
   ],
-  "homepage": "https://github.com/rel1cx/eslint-react",
+  "homepage": "https://github.com/rEl1cx/eslint-react",
   "bugs": {
-    "url": "https://github.com/rel1cx/eslint-react/issues"
+    "url": "https://github.com/rEl1cx/eslint-react/issues"
   },
   "repository": {
     "type": "git",
-    "url": "git+https://github.com/Rel1cx/eslint-react.git",
+    "url": "git+https://github.com/rEl1cx/eslint-react.git",
     "directory": "packages/plugins/eslint-plugin-react-x"
   },
   "license": "MIT",
@@ -49,13 +49,13 @@
     "string-ts": "^2.2.0",
     "ts-api-utils": "^2.0.0",
     "ts-pattern": "^5.6.0",
-    "@eslint-react/ast": "1.22.2-next.1",
-    "@eslint-react/core": "1.22.2-next.1",
-    "@eslint-react/jsx": "1.22.2-next.1",
-    "@eslint-react/types": "1.22.2-next.1",
-    "@eslint-react/eff": "1.22.2-next.1",
-    "@eslint-react/shared": "1.22.2-next.1",
-    "@eslint-react/var": "1.22.2-next.1"
+    "@eslint-react/ast": "1.22.2-next.11",
+    "@eslint-react/core": "1.22.2-next.11",
+    "@eslint-react/eff": "1.22.2-next.11",
+    "@eslint-react/jsx": "1.22.2-next.11",
+    "@eslint-react/shared": "1.22.2-next.11",
+    "@eslint-react/types": "1.22.2-next.11",
+    "@eslint-react/var": "1.22.2-next.11"
   },
   "devDependencies": {
     "@types/react": "^19.0.2",